profile
viewpoint
Bruno Abreu brunoabreu @vtex Rio de Janeiro

vtex/react-apollo 1

:recycle: React data container for the Apollo Client

afonso-praca/theme 0

Default theme for new VTEX stores

brunoabreu/babel 0

:tropical_fish: Babel is a compiler for writing next generation JavaScript.

brunoabreu/signalr-client-nodejs 0

This is a signalR client for node.js.

brunoabreu/webpack 0

A bundler for javascript and friends. Packs many modules into a few bundled assets. Code Splitting allows to load parts for the application on demand. Through "loaders," modules can be CommonJs, AMD, ES6 modules, CSS, Images, JSON, Coffeescript, LESS, ... and your custom stuff.

delete branch vtex-apps/btg360

delete branch : feature/async

delete time in 14 days

push eventvtex-apps/btg360

Bruno Abreu

commit sha c1d1983b8a3a3effd76ef12d82a5b751b77cf671

Make btg script async

view details

Bruno Abreu

commit sha 5954e9e0d854bbb8ac7fd352ead9f141d1c580e3

Remove extra spaces

view details

Bruno Abreu

commit sha 29b5d4a6f70704bd2cde3371d44614abe3309087

Update changelog

view details

Bruno Abreu

commit sha 2f1d0fafe85134437b50cb0ec7aa9b35a12caefc

Add defer to scripts

view details

Bruno Abreu

commit sha 9a6bc9bc71694398b182e78a7f4ee13860c868ca

Merge pull request #12 from vtex-apps/feature/async Make btg script async

view details

push time in 14 days

PR merged vtex-apps/btg360

Make btg script async
+44 -3

2 comments

4 changed files

brunoabreu

pr closed time in 14 days

push eventvtex-apps/btg360

Bruno Abreu

commit sha 2f1d0fafe85134437b50cb0ec7aa9b35a12caefc

Add defer to scripts

view details

push time in 14 days

delete branch vtex-apps/render-runtime

delete branch : fix/remove-sentry

delete time in 14 days

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 109f6273f4f36890ad6fa59b424e2a9e6f5324c6

Remove sentry

view details

Bruno Abreu

commit sha 96ffbaf6636394b1d76479ad016be78327d91d2b

Update changelog

view details

Bruno Abreu

commit sha 3b6faa1558369f6f74932657d4432827850b643f

Merge pull request #570 from vtex-apps/fix/remove-sentry Fix/remove sentry

view details

push time in 14 days

PR merged vtex-apps/render-runtime

Fix/remove sentry

What does this PR do? *

Stop including sentry script.

How to test it? *

https://storecomponents.myvtex.com Before, with sentry (between history and ramda): image

https://brunoh--storecomponents.myvtex.com After, without sentry: image

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+2 -5

2 comments

2 changed files

brunoabreu

pr closed time in 14 days

PR opened vtex-apps/render-runtime

Fix/remove sentry

What does this PR do? *

Stop including sentry script.

How to test it? *

https://storecomponents.myvtex.com Before, with sentry (between history and ramda): image

https://brunoh--storecomponents.myvtex.com After, without sentry: image

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+2 -5

0 comment

2 changed files

pr created time in 14 days

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 96ffbaf6636394b1d76479ad016be78327d91d2b

Update changelog

view details

push time in 14 days

create barnchvtex-apps/render-runtime

branch : fix/remove-sentry

created branch time in 14 days

push eventvtex-apps/btg360

Bruno Abreu

commit sha 29b5d4a6f70704bd2cde3371d44614abe3309087

Update changelog

view details

push time in 14 days

push eventvtex-apps/btg360

Bruno Abreu

commit sha 5954e9e0d854bbb8ac7fd352ead9f141d1c580e3

Remove extra spaces

view details

push time in 14 days

PR opened vtex-apps/btg360

Make btg script async
+41 -3

0 comment

3 changed files

pr created time in 14 days

create barnchvtex-apps/btg360

branch : feature/async

created branch time in 14 days

push eventvtex-apps/admin-pages

Bruno Abreu

commit sha 0d7a3c3a2811170c99233faf13d8432372c5dc66

Add custom entity scope message

view details

Bruno Abreu

commit sha 488f94bfc25bd84d20eb983e8131437878d9bb76

Update changelog

view details

Bruno Abreu

commit sha 813f51eef8bb3a4a9245e84e7af993127cba20c9

Merge pull request #356 from vtex-apps/feature/custom-entity-content Feature/custom entity content

view details

push time in 20 days

delete branch vtex-apps/admin-pages

delete branch : feature/custom-entity-content

delete time in 20 days

PR merged vtex-apps/admin-pages

Reviewers
Feature/custom entity content

What problem is this solving?

Add a new message for custom entity scopes. More details here: https://github.com/vtex/pages-graphql/pull/379

How should this be manually tested?

https://storelocator--eriksbikeshop.myvtex.com/admin/cms/site-editor/store/madison-east-madison-wi-53704/Mdea

<!-- Your friendly Checklist/Reminders 📝 -->

<!-- 📒 Update README.md. --> <!-- ❕ Update CHANGELOG.md. --> <!-- 🔮 Link this PR to a Clubhouse story (if applicable). --> <!-- 🤖 Update/create tests (important for bug fixes). --> <!-- 🚿 Delete the workspace after merging this PR (if applicable). -->

Screenshots or example usage

Type of changes

<!--- Add a ✔️ where applicable -->

✔️ Type of Change
_ Bug fix <!-- a non-breaking change which fixes an issue -->
✔️ New feature <!-- a non-breaking change which adds functionality -->
_ Breaking change <!-- fix or feature that would cause existing functionality to change -->
_ Technical improvements <!-- chores, refactors and overall reduction of technical debt -->

Notes

<!-- Put any relevant information that doesn't fit in the other sections here. -->

How does this PR make you feel? :link:

![](put .gif link here - can be found under "advanced" on giphy)

+12 -2

2 comments

7 changed files

brunoabreu

pr closed time in 20 days

PR opened vtex-apps/admin-pages

Feature/custom entity content

What problem is this solving?

Add a new message for custom entity scopes. More details here: https://github.com/vtex/pages-graphql/pull/379

How should this be manually tested?

https://storelocator--eriksbikeshop.myvtex.com/admin/cms/site-editor/store/madison-east-madison-wi-53704/Mdea

<!-- Your friendly Checklist/Reminders 📝 -->

<!-- 📒 Update README.md. --> <!-- ❕ Update CHANGELOG.md. --> <!-- 🔮 Link this PR to a Clubhouse story (if applicable). --> <!-- 🤖 Update/create tests (important for bug fixes). --> <!-- 🚿 Delete the workspace after merging this PR (if applicable). -->

Screenshots or example usage

Type of changes

<!--- Add a ✔️ where applicable -->

✔️ Type of Change
_ Bug fix <!-- a non-breaking change which fixes an issue -->
✔️ New feature <!-- a non-breaking change which adds functionality -->
_ Breaking change <!-- fix or feature that would cause existing functionality to change -->
_ Technical improvements <!-- chores, refactors and overall reduction of technical debt -->

Notes

<!-- Put any relevant information that doesn't fit in the other sections here. -->

How does this PR make you feel? :link:

![](put .gif link here - can be found under "advanced" on giphy)

+12 -2

0 comment

7 changed files

pr created time in 22 days

push eventvtex-apps/admin-pages

Bruno Abreu

commit sha 488f94bfc25bd84d20eb983e8131437878d9bb76

Update changelog

view details

push time in 22 days

create barnchvtex-apps/admin-pages

branch : feature/custom-entity-content

created branch time in 22 days

PullRequestReviewEvent

delete branch vtex-apps/render-runtime

delete branch : fix/errorpage

delete time in 25 days

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha cce8a0992c4e00553656c286e717614b465889bf

Wait async scripts to render error page

view details

Bruno Abreu

commit sha f7488a2573247375af3943692953b19136462bcb

Update changelog

view details

Bruno Abreu

commit sha eeac77e73103af1a860d9f13880f3d48810467e8

Merge pull request #569 from vtex-apps/fix/errorpage Fix/errorpage

view details

push time in 25 days

PR merged vtex-apps/render-runtime

Fix/errorpage

What does this PR do? *

Wait async scripts to render error page.

How to test it? *

Bug: https://errorbugasync--carrefourbr.myvtex.com/ Fixed: https://errorbugasyncfixed--carrefourbr.myvtex.com/

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+16 -7

2 comments

3 changed files

brunoabreu

pr closed time in 25 days

PR opened vtex-apps/render-runtime

Fix/errorpage

What does this PR do? *

Wait async scripts to render error page.

How to test it? *

Bug: https://errorbugasync--carrefourbr.myvtex.com/ Fixed: https://errorbugasyncfixed--carrefourbr.myvtex.com/

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+16 -7

0 comment

3 changed files

pr created time in 25 days

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha f7488a2573247375af3943692953b19136462bcb

Update changelog

view details

push time in 25 days

create barnchvtex-apps/render-runtime

branch : fix/errorpage

created branch time in 25 days

PullRequestReviewEvent

create barnchvtex-apps/slider-layout

branch : fix/permanent-slides

created branch time in a month

PullRequestReviewEvent

Pull request review commentvtex/node-vtex-api

Update runnable schema in runtime when provider app changes version

+import { IOClients } from '../../../../../clients'+import { PROVIDER_HEADER } from '../../../../../constants'+import { GraphQLOptions, ParamsContext, RecorderState } from '../../typings'+import { makeSchema } from '../schema/index'+import { ExecutableSchema } from '../typings'+import { GraphQLServiceContext } from '../typings'++export const updateSchema = <T extends IOClients, U extends RecorderState, V extends ParamsContext>(+  graphql: GraphQLOptions<T, U, V>,+  executableSchema: ExecutableSchema+) =>+  async function updateRunnableSchema(ctx: GraphQLServiceContext, next: () => Promise<void>) {+    const {+      clients: { apps },+      vtex: { logger },+      app,+    } = ctx+    // updates the provider app, fetches the new schema and generate a new runnable schema+    if (+      executableSchema.hasProvider &&+      (!executableSchema.provider || executableSchema.provider !== ctx.headers[PROVIDER_HEADER])+    ) {+      executableSchema.provider = ctx.headers[PROVIDER_HEADER]++      try {+        const newSchema = (await apps.getAppFile(ctx.headers[PROVIDER_HEADER], 'public/schema.graphql')).data.toString(

If something crashes here, shouldn't we try again next time?

If you set the provider earlier (executableSchema.provider = ctx.headers[PROVIDER_HEADER]), we will never have another attempt.

gris

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

delete branch vtex-apps/render-runtime

delete branch : feature/react-concurrent-mode

delete time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha cf10fe5b590b429991f14c39a3f477056276821e

Enable concurrent mode with a feature flag

view details

Bruno Abreu

commit sha 14b4dc7b76468084bbf32fd33cf4f98ae63b1ab8

Remove callback from render function

view details

Bruno Abreu

commit sha 0ccd28005b8359999285147550e4df3c71a4bc09

Update changelog

view details

Bruno Abreu

commit sha 83801542908409086d75bc9e27d8fa504391fbf8

Small fixes

view details

Bruno Abreu

commit sha 7fa11d54fb03d78b83cda217565e84a87db0578d

Merge pull request #566 from vtex-apps/feature/react-concurrent-mode React Concurrent Mode

view details

push time in a month

PR merged vtex-apps/render-runtime

React Concurrent Mode

What does this PR do? *

Enable react concurrent mode with a feature flag. This PR was based on this draft: https://github.com/vtex-apps/render-runtime/pull/563

How to test it? *

It is linked here https://brunoh--storecomponents.myvtex.com/

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

https://github.com/vtex/render-server/pull/670

+97 -39

2 comments

10 changed files

brunoabreu

pr closed time in a month

delete branch vtex-apps/render-runtime

delete branch : feature/lazy-runtime

delete time in a month

PR opened vtex-apps/render-runtime

React Concurrent Mode

What does this PR do? *

Enable react concurrent mode with a feature flag. This PR was based on this draft: https://github.com/vtex-apps/render-runtime/pull/563

How to test it? *

It is linked here https://brunoh--storecomponents.myvtex.com/

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

https://github.com/vtex/render-server/pull/670

+97 -39

0 comment

10 changed files

pr created time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 83801542908409086d75bc9e27d8fa504391fbf8

Small fixes

view details

push time in a month

create barnchvtex-apps/render-runtime

branch : feature/react-concurrent-mode

created branch time in a month

delete branch vtex-apps/render-runtime

delete branch : feature/async-lazy-scripts

delete time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 37c04f6f3ae6e3c010578d01dd5e1d60dbde216e

Wait the execution of async scripts to render.

view details

Bruno Abreu

commit sha ee7d027b2b3eb09ec2322cc311f06f9576b33d18

Update changelog

view details

Bruno Abreu

commit sha 6cdc027f0517b2857a9e5b22947f6e855d47f25b

Merge pull request #564 from vtex-apps/feature/async-lazy-scripts Async Scripts

view details

push time in a month

PR merged vtex-apps/render-runtime

Async Scripts

What does this PR do? *

Wait the execution of async scripts to start rendering.

How to test it? *

Working here: https://storetheme.vtex.com/?workspace=brunohp

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

https://github.com/vtex/render-server/pull/667 https://github.com/vtex/asset-server/pull/56

+15 -0

2 comments

3 changed files

brunoabreu

pr closed time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 37c04f6f3ae6e3c010578d01dd5e1d60dbde216e

Wait the execution of async scripts to render.

view details

Bruno Abreu

commit sha ee7d027b2b3eb09ec2322cc311f06f9576b33d18

Update changelog

view details

push time in a month

PR opened vtex-apps/render-runtime

Async Scripts

What does this PR do? *

Wait the execution of async scripts to start rendering.

How to test it? *

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

https://github.com/vtex/render-server/pull/667 https://github.com/vtex/asset-server/pull/56

+13 -0

0 comment

2 changed files

pr created time in a month

create barnchvtex-apps/render-runtime

branch : feature/async-lazy-scripts

created branch time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

create barnchvtex-apps/render-runtime

branch : feature/hydrate-batch

created branch time in a month

PullRequestReviewEvent

delete branch vtex-apps/render-runtime

delete branch : feature/split-hydrate-apollo-cache

delete time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 64a6a9bb621a7e6137754ba46ff0735a2dae8e34

Split hydrateApolloCache

view details

Bruno Abreu

commit sha 611a99dc2feadc358e467fcd414353d5b19e13c2

Update changelog

view details

Bruno Abreu

commit sha 1d098c5871b53c485ea78aa8c8bbcb4239fcebf8

Remove useless method

view details

Bruno Abreu

commit sha dcf3dac800a8e3c20d332f91ae7f7cb8138a7b8f

Remove imports

view details

Bruno Abreu

commit sha af4fb9a46f8e24c432f929cf054ea8fa6d313e8f

Use async apollo hydration when navigating too

view details

Bruno Abreu

commit sha e753a67f3b647e140f6f9f496fee7db0ee31e605

Merge pull request #561 from vtex-apps/feature/split-hydrate-apollo-cache Split hydrateApolloCache

view details

push time in a month

PR merged vtex-apps/render-runtime

Split hydrateApolloCache

What does this PR do? *

Does hydrateApolloCache separately from the hydrate from React, which reduces total blocking time

Also splits the hydrateApolloCache into multiple smaller ones, reducing the blocking time further.

Before (dev workspace, heavy search page): Screen Shot 2020-09-08 at 12 59 29

After (dev workspace, heavy search page): Screen Shot 2020-09-08 at 12 58 24

Before (prod workspace, heavy search page): Screen Shot 2020-09-08 at 13 18 08

After (prod workspace, heavy search page): Screen Shot 2020-09-08 at 14 00 14

Before (one single hydrateApolloCache task): Screen Shot 2020-09-08 at 13 18 13

After (split hydrateApolloCache task, highlighting the longest one): Screen Shot 2020-09-08 at 14 00 30

https://www.carrefour.com.br/Celulares-Smartphones-e-Smartwatches/Smartphones?ak-testab=vtex&workspace=lbebberapollo1

How to test it? *

Production workspace: https://www.carrefour.com.br/Celulares-Smartphones-e-Smartwatches/Smartphones?ak-testab=vtex&workspace=apollohydrate

Development workspace: https://brunoh--storecomponents.myvtex.com/apparel---accessories/

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+292 -170

2 comments

9 changed files

lbebber

pr closed time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha af4fb9a46f8e24c432f929cf054ea8fa6d313e8f

Use async apollo hydration when navigating too

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha dcf3dac800a8e3c20d332f91ae7f7cb8138a7b8f

Remove imports

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 1d098c5871b53c485ea78aa8c8bbcb4239fcebf8

Remove useless method

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 17a8d611e73d4517e8723bc81fe8fc4737157d2c

Fix lazy JSON parse

view details

Bruno Abreu

commit sha 7549e229389b33fb4d8025651ba66536a0233fd7

Update changelog

view details

Bruno Abreu

commit sha d4c748a7e6e344ec6988df70fa3087a592d77b67

Lint fix

view details

Bruno Abreu

commit sha 1a2ce500d700115be1bc59e7034b4748e650d0bd

Update comment

view details

Bruno Abreu

commit sha edbb11d7da58b9241acc2988c8d79ed0744dc3dc

Parse queryData separately

view details

Bruno Abreu

commit sha 6cb780f4b8b0b90f5a9f0cd58e6cfab217d11a56

Update changelog

view details

Bruno Abreu

commit sha af8e7367df3412bd5c5d13d62648a4b678e2e4a5

Make window variable set more generic

view details

Bruno Abreu

commit sha 59d8bb1cd5c2c59dfc22a9ade6a12c0269896f3f

Lint fix

view details

Bruno Abreu

commit sha 0524e04478349d59eec4ec0b5b4407f71ccf89ba

Release v8.115.1

view details

Bruno Abreu

commit sha a9542ed97b8ba945da63bdf9e9b42922aaef5c78

Merge pull request #560 from vtex-apps/fix/lazy-json-parse Fix/lazy json parse

view details

Tiago Gimenes

commit sha 27090c4ff51239c929a87901594066b57f84a5b9

eslint

view details

Tiago Gimenes

commit sha 807521d9ba82bc95a0a5f349cf95c4dfe564bcf5

scope critical related functions

view details

Tiago Gimenes

commit sha 4665ea99e49a5e7128bb0b4c74f73186aa8982ce

change names to make more sense

view details

Tiago Gimenes

commit sha f28927511874dde6645b6b63f5a22dfbfee472ab

fix rebase gone wrong

view details

Tiago Gimenes

commit sha acbd508cd7b6c033a8d7718cb44f139a8bbde39b

more fixes in rebase

view details

Tiago Gimenes

commit sha 3c75975e8744c60e20588472737f306d6108a9dc

Release v8.116.0-beta.0

view details

Tiago Gimenes

commit sha 3c01bc4b627c453816440ec99d1367269932fa64

Release v8.116.0-beta.1

view details

Tiago Gimenes

commit sha c7f7edfb94f476e985c55f006b71488db6a37b64

Release v8.116.0-beta.2

view details

Tiago Gimenes

commit sha 6a54cbf6e7358588e7e66f8db22e913869f43c3f

Release v8.116.0-beta.3

view details

Tiago Gimenes

commit sha e4899c8904966b326e22a58e35944d528d501751

Release v8.116.0-beta.4

view details

push time in a month

delete branch vtex-apps/render-runtime

delete branch : fix/lazy-json-parse

delete time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 17a8d611e73d4517e8723bc81fe8fc4737157d2c

Fix lazy JSON parse

view details

Bruno Abreu

commit sha 7549e229389b33fb4d8025651ba66536a0233fd7

Update changelog

view details

Bruno Abreu

commit sha d4c748a7e6e344ec6988df70fa3087a592d77b67

Lint fix

view details

Bruno Abreu

commit sha 1a2ce500d700115be1bc59e7034b4748e650d0bd

Update comment

view details

Bruno Abreu

commit sha edbb11d7da58b9241acc2988c8d79ed0744dc3dc

Parse queryData separately

view details

Bruno Abreu

commit sha 6cb780f4b8b0b90f5a9f0cd58e6cfab217d11a56

Update changelog

view details

Bruno Abreu

commit sha af8e7367df3412bd5c5d13d62648a4b678e2e4a5

Make window variable set more generic

view details

Bruno Abreu

commit sha 59d8bb1cd5c2c59dfc22a9ade6a12c0269896f3f

Lint fix

view details

Bruno Abreu

commit sha 0524e04478349d59eec4ec0b5b4407f71ccf89ba

Release v8.115.1

view details

Bruno Abreu

commit sha a9542ed97b8ba945da63bdf9e9b42922aaef5c78

Merge pull request #560 from vtex-apps/fix/lazy-json-parse Fix/lazy json parse

view details

push time in a month

PR merged vtex-apps/render-runtime

Fix/lazy json parse

What does this PR do?

It fixes lazy JSON parse. Also changes how we set the global variables making it more generic.

How to test it?

You can see it working here: https://brunoh--carrefourbr.myvtex.com/Celulares-Smartphones-e-Smartwatches/Smartphones?crfimt=hm-tlink%7Ccarrefour%7Cmenu%7Ccampanha%7Csmartphones%7C1%7C120820

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

Depends on https://github.com/vtex/render-server/pull/662 <!--- Optional -->

+20 -15

0 comment

4 changed files

brunoabreu

pr closed time in a month

created tagvtex-apps/render-runtime

tagv8.115.1

The VTEX Render framework runtime

created time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha edbb11d7da58b9241acc2988c8d79ed0744dc3dc

Parse queryData separately

view details

Bruno Abreu

commit sha 6cb780f4b8b0b90f5a9f0cd58e6cfab217d11a56

Update changelog

view details

Bruno Abreu

commit sha af8e7367df3412bd5c5d13d62648a4b678e2e4a5

Make window variable set more generic

view details

Bruno Abreu

commit sha 59d8bb1cd5c2c59dfc22a9ade6a12c0269896f3f

Lint fix

view details

Bruno Abreu

commit sha 0524e04478349d59eec4ec0b5b4407f71ccf89ba

Release v8.115.1

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 349130248dd6c158327bfdcf229c559a2f7e85a3

Lint fix

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha c28ff2baa8d62f05f83bc2ba36534e52b3858574

Make window variable set more generic

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 04fc5fbddf1a1c0efd036ccd96f45f21841f81b5

Release v8.115.1

view details

Bruno Abreu

commit sha 3cf508c8dcebb775822d3343149d60a07ad9ea42

Parse queryData separately

view details

Bruno Abreu

commit sha b7601a32b00e0e2cee70a92f511937e9f06cbfbe

Update changelog

view details

Bruno Abreu

commit sha c46d94e0d0053883a024e3fef8ab638b497c883c

Make window variable set more generic

view details

push time in a month

Pull request review commentvtex-apps/render-runtime

Fix/lazy json parse

 const getValue = (element: HTMLTemplateElement) => {   if (typeof element.content === 'undefined') {-    return element.innerHTML+    return element.textContent as string   }    // Using nodeValue instead of innerHTML because it's faster

👍

brunoabreu

comment created time in a month

PullRequestReviewEvent

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 1a2ce500d700115be1bc59e7034b4748e650d0bd

Update comment

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha d4c748a7e6e344ec6988df70fa3087a592d77b67

Lint fix

view details

push time in a month

PR opened vtex-apps/render-runtime

Fix/lazy json parse

What does this PR do?

It fixes lazy JSON parse.

How to test it?

You can see it working here: https://brunoh--carrefourbr.myvtex.com/Celulares-Smartphones-e-Smartwatches/Smartphones?crfimt=hm-tlink%7Ccarrefour%7Cmenu%7Ccampanha%7Csmartphones%7C1%7C120820

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

Depends on https://github.com/vtex/render-server/pull/662 <!--- Optional -->

+4 -2

0 comment

2 changed files

pr created time in a month

create barnchvtex-apps/render-runtime

branch : fix/lazy-json-parse

created branch time in a month

push eventvtex-apps/render-runtime

Lucas Bebber

commit sha e146215295303819252b669bc6375ae5e559a23b

Lazy init runtime JSON

view details

Bruno Abreu

commit sha b1f66cf5f2ad2f9dedef1dd3ef11f966524cd7a0

Refactor

view details

Bruno Abreu

commit sha 97fc881a7ba369183e582313810471fcf6dd1198

Check __DOM_READY__ to resolve contentLoadedPromise

view details

Bruno Abreu

commit sha 0bfe2e55bb7d51968cfea864824a8ee1b06eb108

Add a fallback strategy for IE11

view details

Bruno Abreu

commit sha 9893c94d19c52b7a06ec5bcad7aca4c0dbfb18bb

Get global var name from dataset.varname

view details

Bruno Abreu

commit sha 83b4af841253ea88729b0c266b47301b8ee95191

Add AMP proxy earlier

view details

Bruno Abreu

commit sha d1a8171fa658592e7c71c183ffa96fb69fc7c350

Update changelog

view details

Bruno Abreu

commit sha 0de62f5039dc79d77fd758e8cdb30547cdaa200b

Add a comment on childNodes usage

view details

Bruno Abreu

commit sha 9b2379e5280a104a618f29f29744f4e2ca040b75

Merge pull request #559 from vtex-apps/feature/lazy-runtime Lazy init runtime JSON

view details

push time in a month

PR merged vtex-apps/render-runtime

Lazy init runtime JSON

Prevents from adding RUNTIME et al as an inline script, instead adding them inline as a <template>.

See: https://github.com/vtex/render-server/pull/660

+252 -171

2 comments

9 changed files

lbebber

pr closed time in a month

PullRequestReviewEvent

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 0de62f5039dc79d77fd758e8cdb30547cdaa200b

Add a comment on childNodes usage

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha d1a8171fa658592e7c71c183ffa96fb69fc7c350

Update changelog

view details

push time in a month

push eventvtex-apps/render-runtime

Lucas Cordeiro

commit sha 34164210cfdd1df5275ff45584139f3a9b695dde

Add memo to blocks children

view details

Bruno Abreu

commit sha 1363b26f683aa8c2450d4bc40d224ade1fb9685d

Merge pull request #555 from vtex-apps/chore/memo-children Add memo to blocks children

view details

brunoabreu

commit sha 0cd3dde65d71b5dcb8ba6476983fe5c3134730dc

Release v8.114.1

view details

Lucas Bebber

commit sha e146215295303819252b669bc6375ae5e559a23b

Lazy init runtime JSON

view details

Bruno Abreu

commit sha b1f66cf5f2ad2f9dedef1dd3ef11f966524cd7a0

Refactor

view details

Bruno Abreu

commit sha 97fc881a7ba369183e582313810471fcf6dd1198

Check __DOM_READY__ to resolve contentLoadedPromise

view details

Bruno Abreu

commit sha 0bfe2e55bb7d51968cfea864824a8ee1b06eb108

Add a fallback strategy for IE11

view details

Bruno Abreu

commit sha 9893c94d19c52b7a06ec5bcad7aca4c0dbfb18bb

Get global var name from dataset.varname

view details

Bruno Abreu

commit sha 83b4af841253ea88729b0c266b47301b8ee95191

Add AMP proxy earlier

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha e823c4f34b3994d298a8593262724324e5514ea4

Refactor

view details

Bruno Abreu

commit sha 3689f3ee7b52b6bca26824fddf0d774695eb72c2

Check __DOM_READY__ to resolve contentLoadedPromise

view details

Bruno Abreu

commit sha e49e135ee0f57a8454731e45556fd6462b0ce021

Add a fallback strategy for IE11

view details

Bruno Abreu

commit sha 0afd3444e118e1c2d6b72a73b6d5044c04f26fce

Get global var name from dataset.varname

view details

Bruno Abreu

commit sha 97d596dc5611f62036a9aae94994ff52fe9b6b34

Add AMP proxy earlier

view details

push time in a month

push eventvtex-apps/render-runtime

Lucas Cordeiro

commit sha 34164210cfdd1df5275ff45584139f3a9b695dde

Add memo to blocks children

view details

Bruno Abreu

commit sha 1363b26f683aa8c2450d4bc40d224ade1fb9685d

Merge pull request #555 from vtex-apps/chore/memo-children Add memo to blocks children

view details

push time in a month

PR merged vtex-apps/render-runtime

Reviewers
Add memo to blocks children

What does this PR do? *

Adds a simple memoization to the children object passed down to blocks in order to enable memoization solely on the props, which can benefit components that render a lot of stuff to partially memoize some of the tree.

How to test it? *

Use the same testing plan as vtex-apps/checkout-cart#61. The product list component has been memoized (and it wouldn't work without this PR because the children would change every render, making the memoization useless) in order to avoid rendering all of the products in the orderForm when you alter the quantity of only one of them.

Describe alternatives you've considered, if any. *

One alternative would require a change in the product-list component itself, where it wouldn't depend on the children but would tigh the implementation of the product list item to the component itself and make any customizations the agencies have done thrown away.

Related to / Depends on *

N/A

+12 -9

4 comments

2 changed files

lucasecdb

pr closed time in a month

push eventvtex-apps/render-runtime

Lucas Bebber

commit sha f229984a30c25278a21c3378f1ff5fa8f18705ad

Keep workspace during navigation if it's set via querystring

view details

Lucas Bebber

commit sha 36e80442abccd8849784bff6b60f38e6abfbaa48

Update changelog

view details

Lucas Bebber

commit sha 5f49da9cfd40ae2cc8ef5a5165fba33af7416c34

Remove redundant appendWorkspace

view details

Lucas Bebber

commit sha 0b4148ef1bc525b4d4b85ff9de360d5d38991a97

Add back workspace to link href

view details

Bruno Abreu

commit sha 9fbf3b86b53089910760fc4262035cbfcb3da76f

Merge pull request #556 from vtex-apps/feature/keep-workspace Feature/keep workspace

view details

brunoabreu

commit sha 82b5c33a7db0d9ede8d0dca2a3a074044b75d622

Release v8.112.1

view details

Lucas Bebber

commit sha c43b7cef7767e28e2dee4de365e4500c6839f24c

Update changelog

view details

Lucas Bebber

commit sha eb3767c6d4822ff9c79ead7f4763393b98f5e0ef

Prevent setting workspace as undefined

view details

Lucas Bebber

commit sha dea9e347bb19065ed3ee436d267363e20f3ff5b4

Prevents setting searchParams if value is undefined

view details

Lucas Bebber

commit sha 799a9f37f494992d21faa9e686432959d9f70c89

Prevents setting workspace to links with a preset workspace

view details

Lucas Bebber

commit sha 9a4c2b493ab2363c0e5a5fcfd94557d6ad0714de

Append workspace to page based Links

view details

Lucas Bebber

commit sha 38272a5c1443897ce7b87b02cf28f62c236d33f0

Add workspace to querystring

view details

Lucas Bebber

commit sha 4860a6a7b5ab899a4aef1c35fe79b8893f9cbe5d

Cleanup stray commented out code

view details

Lucas Bebber

commit sha 3e590f17b4605aa3161e759fe7fa0bb138d4e20f

Append wks to url if its an empty string

view details

Lucas Bebber

commit sha d204fe8a21011916add6bf5f422e36685d0e522a

Update changelog

view details

Bruno Abreu

commit sha d073a384fd7b516f52f11c62e174d34f88e4e9d5

Merge pull request #558 from vtex-apps/fix/keep-workspace Fix/keep workspace

view details

brunoabreu

commit sha ba74852cccabbfdd14227ab38b5523a64fcfdfc5

Release v8.112.2

view details

Bruno Abreu

commit sha d4edd7a77bc8bf4483b10c2d921ec7654f91a84f

Check concatenated styles to decide on downloading new ones

view details

Bruno Abreu

commit sha 9309be2063675fec53925b2fc6855d97b9f67dda

Update changelog

view details

Bruno Abreu

commit sha 4d66929266a7169dcb790cf7c8d952d94eeb0323

Bring back groupAssetsByApp return type

view details

push time in a month

delete branch vtex-apps/render-runtime

delete branch : feature/css-concat

delete time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha d4edd7a77bc8bf4483b10c2d921ec7654f91a84f

Check concatenated styles to decide on downloading new ones

view details

Bruno Abreu

commit sha 9309be2063675fec53925b2fc6855d97b9f67dda

Update changelog

view details

Bruno Abreu

commit sha 4d66929266a7169dcb790cf7c8d952d94eeb0323

Bring back groupAssetsByApp return type

view details

Bruno Abreu

commit sha 83276cb1f44079e2f33819659ff0f7829f475c67

Merge pull request #557 from vtex-apps/feature/css-concat Feature/css concat

view details

push time in a month

PR merged vtex-apps/render-runtime

Feature/css concat

What does this PR do? *

It takes into account the new URL of concatenated CSSs to decide which assets to download.

How to test it? *

It is already installed here: https://www.carrefour.com.br/?v=1x&workspace=brunohp&ak-testab=vtex When browsing it downloads CSS only for styles not present in the concatenated CSS URL

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+31 -17

2 comments

2 changed files

brunoabreu

pr closed time in a month

push eventvtex-apps/render-runtime

Lucas Bebber

commit sha f229984a30c25278a21c3378f1ff5fa8f18705ad

Keep workspace during navigation if it's set via querystring

view details

Lucas Bebber

commit sha 36e80442abccd8849784bff6b60f38e6abfbaa48

Update changelog

view details

Lucas Bebber

commit sha 5f49da9cfd40ae2cc8ef5a5165fba33af7416c34

Remove redundant appendWorkspace

view details

Lucas Bebber

commit sha 0b4148ef1bc525b4d4b85ff9de360d5d38991a97

Add back workspace to link href

view details

Bruno Abreu

commit sha 9fbf3b86b53089910760fc4262035cbfcb3da76f

Merge pull request #556 from vtex-apps/feature/keep-workspace Feature/keep workspace

view details

brunoabreu

commit sha 82b5c33a7db0d9ede8d0dca2a3a074044b75d622

Release v8.112.1

view details

Lucas Bebber

commit sha c43b7cef7767e28e2dee4de365e4500c6839f24c

Update changelog

view details

Lucas Bebber

commit sha eb3767c6d4822ff9c79ead7f4763393b98f5e0ef

Prevent setting workspace as undefined

view details

Lucas Bebber

commit sha dea9e347bb19065ed3ee436d267363e20f3ff5b4

Prevents setting searchParams if value is undefined

view details

Lucas Bebber

commit sha 799a9f37f494992d21faa9e686432959d9f70c89

Prevents setting workspace to links with a preset workspace

view details

Lucas Bebber

commit sha 9a4c2b493ab2363c0e5a5fcfd94557d6ad0714de

Append workspace to page based Links

view details

Lucas Bebber

commit sha 38272a5c1443897ce7b87b02cf28f62c236d33f0

Add workspace to querystring

view details

Lucas Bebber

commit sha 4860a6a7b5ab899a4aef1c35fe79b8893f9cbe5d

Cleanup stray commented out code

view details

Lucas Bebber

commit sha 3e590f17b4605aa3161e759fe7fa0bb138d4e20f

Append wks to url if its an empty string

view details

Lucas Bebber

commit sha d204fe8a21011916add6bf5f422e36685d0e522a

Update changelog

view details

Bruno Abreu

commit sha d073a384fd7b516f52f11c62e174d34f88e4e9d5

Merge pull request #558 from vtex-apps/fix/keep-workspace Fix/keep workspace

view details

brunoabreu

commit sha ba74852cccabbfdd14227ab38b5523a64fcfdfc5

Release v8.112.2

view details

Bruno Abreu

commit sha d4edd7a77bc8bf4483b10c2d921ec7654f91a84f

Check concatenated styles to decide on downloading new ones

view details

Bruno Abreu

commit sha 9309be2063675fec53925b2fc6855d97b9f67dda

Update changelog

view details

Bruno Abreu

commit sha 4d66929266a7169dcb790cf7c8d952d94eeb0323

Bring back groupAssetsByApp return type

view details

push time in a month

delete branch vtex-apps/render-runtime

delete branch : fix/keep-workspace

delete time in a month

push eventvtex-apps/render-runtime

Lucas Bebber

commit sha c43b7cef7767e28e2dee4de365e4500c6839f24c

Update changelog

view details

Lucas Bebber

commit sha eb3767c6d4822ff9c79ead7f4763393b98f5e0ef

Prevent setting workspace as undefined

view details

Lucas Bebber

commit sha dea9e347bb19065ed3ee436d267363e20f3ff5b4

Prevents setting searchParams if value is undefined

view details

Lucas Bebber

commit sha 799a9f37f494992d21faa9e686432959d9f70c89

Prevents setting workspace to links with a preset workspace

view details

Lucas Bebber

commit sha 9a4c2b493ab2363c0e5a5fcfd94557d6ad0714de

Append workspace to page based Links

view details

Lucas Bebber

commit sha 38272a5c1443897ce7b87b02cf28f62c236d33f0

Add workspace to querystring

view details

Lucas Bebber

commit sha 4860a6a7b5ab899a4aef1c35fe79b8893f9cbe5d

Cleanup stray commented out code

view details

Lucas Bebber

commit sha 3e590f17b4605aa3161e759fe7fa0bb138d4e20f

Append wks to url if its an empty string

view details

Lucas Bebber

commit sha d204fe8a21011916add6bf5f422e36685d0e522a

Update changelog

view details

Bruno Abreu

commit sha d073a384fd7b516f52f11c62e174d34f88e4e9d5

Merge pull request #558 from vtex-apps/fix/keep-workspace Fix/keep workspace

view details

push time in a month

PR merged vtex-apps/render-runtime

Reviewers
Fix/keep workspace

What does this PR do? *

Prevents setting workspace to undefined Also keeps workspace on the url Also prevents changing workspace if the Link already sets one

https://storetheme.vtex.com/?workspace=lbebberwks4

How to test it? *

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+23 -9

2 comments

3 changed files

lbebber

pr closed time in a month

PullRequestReviewEvent

delete branch vtex-apps/render-runtime

delete branch : feature/keep-workspace

delete time in a month

push eventvtex-apps/render-runtime

Lucas Bebber

commit sha f229984a30c25278a21c3378f1ff5fa8f18705ad

Keep workspace during navigation if it's set via querystring

view details

Lucas Bebber

commit sha 36e80442abccd8849784bff6b60f38e6abfbaa48

Update changelog

view details

Lucas Bebber

commit sha 5f49da9cfd40ae2cc8ef5a5165fba33af7416c34

Remove redundant appendWorkspace

view details

Lucas Bebber

commit sha 0b4148ef1bc525b4d4b85ff9de360d5d38991a97

Add back workspace to link href

view details

Bruno Abreu

commit sha 9fbf3b86b53089910760fc4262035cbfcb3da76f

Merge pull request #556 from vtex-apps/feature/keep-workspace Feature/keep workspace

view details

push time in a month

PR merged vtex-apps/render-runtime

Feature/keep workspace

What does this PR do? *

Keeps workspace during navigation if it's set via querystring. Currently the workspace, if set this way, is reset during navigation and the page is reloaded.

https://www.carrefour.com.br/?ak-testab=vtex&workspace=lbebberwks1&v=01

How to test it? *

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+37 -4

2 comments

4 changed files

lbebber

pr closed time in a month

PR opened vtex-apps/render-runtime

Feature/css concat

What does this PR do? *

It takes into account the new URL of concatenated CSSs to decide which assets to download.

How to test it? *

It is already installed here: https://www.carrefour.com.br/?v=1x&workspace=brunohp&ak-testab=vtex When browsing it downloads CSS only for styles not present in the concatenated CSS URL

Describe alternatives you've considered, if any. *

<!--- Optional -->

Related to / Depends on *

<!--- Optional -->

+31 -17

0 comment

2 changed files

pr created time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 1f927e3bb8586ecd501bbee548edd2b4d1ae2503

Bring back groupAssetsByApp return type

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha 8413d81ad733fa8fd99a6bf221ff62172cbe898f

Check concatenated styles to decide on downloading new ones

view details

Bruno Abreu

commit sha 2eb8e45efb6636b1d9e591df5877a1bfb9998f0c

Update changelog

view details

push time in a month

push eventvtex-apps/render-runtime

Bruno Abreu

commit sha d219730b01a5aee08cc777fdccbf7161dc30d0e4

Update changelog

view details

push time in a month

create barnchvtex-apps/render-runtime

branch : feature/css-concat

created branch time in a month

more