profile
viewpoint
Brian Anderson brson PingCAP https://brson.github.io I write Rust code. Also, I do other things — things that aren't even related to Rust.

alexcrichton/flate2-rs 287

FLATE, Gzip, and Zlib bindings for Rust

brson/basic-http-server 249

A simple static HTTP server in Rust, for learning and local doc development

brson/annotated-std-rs 66

An annotation of the Rust standard library

brson/being-rust 15

Intro to Rust talk

brson/big_s 13

Rust's missing `String` literal

brson/archaea 11

Historic Rust code browsing

alegalle/rustgl_4_2_core 8

Opengl 3.2 - 4.2 bindings for rust

push eventbrson/tikv

Brian Anderson

commit sha 578978b146d2c18679c0855aa632de95c2f41a13

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 0441c9ec71a3aeb37182e7ecb20b4485128f798f

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 8d10a5b794b3c5610f7c98211043db35d3e3af5f

*: fix tests Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 7acf919a65c2f5eca55170163a463e9f7e857494

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha a06800a8220dd7218978c42c9456355a5fd9e8bf

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha c7cdcd06a817a004466bd7708ea4bbee58f533d2

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha bfaea3c63027875e1eb940eb0e11feb9a8cf926c

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 2dc2ecb5244c2e8a4e49f22dbcfce3122cbb70ed

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 44b79b3674379431af0ac76d9a9964f4b5fbc1d2

*: fix build Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 4416574f339e5adefe822c63b4b69ba34ea8f86d

*: rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 5 hours

pull request commenttikv/tikv

Parameterize much of raftstore ever engines

/test

brson

comment created time in 5 hours

pull request commenttikv/tikv

Parameterize much of raftstore ever engines

Sorry for the lazy commit messages.

brson

comment created time in 5 hours

push eventbrson/tikv

Brian Anderson

commit sha 3d25028805f7db3b40305e4300b9933440d2acbb

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 96ec57f550ad59db501ecd00faa8aab713c59f59

*: fix tests Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 725b48ffc25be54c26fe69b6a3af94b016016428

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 7a46814e99b3ad56e36fdab6cd773e2d5ea564ee

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 12c7747877e1c7734dc7f536cb711b0cc7e3f470

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 4de8507ec614c2b0d84a3fb4afc157bfb1750752

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha f7279bcf2a2e1738b17631f234c8f2f6e2b66c22

raftstore: Convert to engine_traits Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 0ea1a07729220b2acb9756c5cadc4ae13094c80b

*: fix build Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha fd6766c31a7a40b25cdec2e8b84a01b90d7eb746

*: rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 5 hours

PR opened tikv/tikv

Reviewers
Parameterize much of raftstore ever engines

<!-- Thank you for contributing to TiKV!

If you haven't already, please read TiKV's CONTRIBUTING document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two. -->

What have you changed?

Continued work on engine abstraction https://github.com/tikv/tikv/issues/6402.

We're now close to being able to remove the raftstore crate's dependency on rocksdb.

This PR replaces many concrete instances of RocksEngine and Arc<DB> with type parameters.

As part of the process it moves the DecodeProperties trait into engine_traits.

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

cargo test --all --no-run

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

<!--

  • If there is a document change, please file a PR in (docs) and add the PR number here.
  • If this PR should be mentioned in the release note, please update the release notes. --> no

Does this PR affect tidb-ansible?

<!-- If there is a configuration or metrics change, please file a PR in tidb-ansible, and add the PR number here. --> no

Refer to a related PR or issue link (optional)

https://github.com/tikv/tikv/issues/6402

Benchmark result if necessary (optional)

Any examples? (optional)

+416 -300

0 comment

37 changed files

pr created time in 5 hours

push eventbrson/tikv

Brian Anderson

commit sha 5169589e78c8faf1813b97230766f6b61339e20c

raftstore: Convert to engine_traits

view details

Brian Anderson

commit sha f554b2443de0d670d6cc7f3d6a5d7158df725225

raftstore: Convert to engine_traits

view details

Brian Anderson

commit sha e37183139b425477f76f6541b475f0744acab9c8

raftstore: Convert to engine_traits

view details

Brian Anderson

commit sha 31f2c37294a33f1afb66c0faeeba39896598f1ae

raftstore: Convert to engine_traits

view details

Brian Anderson

commit sha 830cdcdc67271fe06a4239ce450b4c3f97ca10d9

raftstore: Convert to engine_traits

view details

Brian Anderson

commit sha e36c8897bee1120fb37a76de40b521fb55aff211

*: fix build Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 6e33697ac7527974f7c90cba995c5474d690aa19

*: rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 5 hours

create barnchbrson/tikv

branch : engine-traits-raftstore

created branch time in 6 hours

issue commenttikv/tikv

Engine abstraction tracking issue

@Rustin-Liu a good next util to abstract would be util::compact_range. This is something preventing us from fully abstracting raftstore over engines.

It looks like that will require some new abstractions in engine_traits, perhaps a new file with a CompactExt trait that contains compact_range_cf_opt. I have not looked closely though.

brson

comment created time in 8 hours

issue commenttikv/tikv

Engine abstraction tracking issue

Now that raftstore is its own crate (thanks @overvenus), we have a nice intermediate goal: remove the engine dependency from raftstore. That simplifies the problem quite a bit.

brson

comment created time in 9 hours

pull request commenttikv/tikv

Move WriteBatch from engine to engine_traits/rocks

One tricky part of this patch is that each writebatch needs to be paired with the correct database, kv or raft. This is true moreso now that writebatch is created from a factory method on engine. It's possible I made mistakes in the porting such that a mixed up writebatches with the wrong database. This type of error may not manifest for a long time since rocks doesn't really care which database creates a given writebatch.

brson

comment created time in a day

pull request commenttikv/tikv

Move WriteBatch from engine to engine_traits/rocks

Oh one thing of note here is that the abstract WriteBatch API is slightly different from the old - write batches are created with a factory method on KvEngine, and themselves contain a reference to the engine, such that an engine reference doesn't need to be carried around with them.

Tikv itself mostly still pairs its DB instances with writebatch.

This patch also adds many new temporary calls to c(), to convert engine::rocks::Engine instances to RocksEngine. These will go away eventually.

brson

comment created time in a day

pull request commenttikv/tikv

Move WriteBatch from engine to engine_traits/rocks

cc @Rustin-Liu more engine abstraction.

brson

comment created time in a day

PR opened tikv/tikv

Reviewers
Move WriteBatch from engine to engine_traits/rocks

<!-- Thank you for contributing to TiKV!

If you haven't already, please read TiKV's CONTRIBUTING document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two. -->

What have you changed?

More engine abstraction, re https://github.com/tikv/tikv/issues/6402

This ports tikv to use RocksWriteBatch from engine_rocks, and removes WriteBatch from the engine crate.

It does not convert tikv to use generic WriteBatches yet. That will be future work.

There's nothing particularly tricky to note here. Just a lot of code moving around. I reworked this patch many times so history is a bit messy.

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

cargo test --all --no-run

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

no

Does this PR affect tidb-ansible?

no

Refer to a related PR or issue link (optional)

https://github.com/tikv/tikv/issues/6402

Benchmark result if necessary (optional)

Any examples? (optional)

+401 -407

0 comment

24 changed files

pr created time in a day

push eventbrson/tikv

Brian Anderson

commit sha e76d30bb20dcdab310d4a1c032953c0b3539641e

engine: Remove some methods from Engine Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 2fe90535c94c5b97005773ab6ea06fe38473e24f

engine: Remove WriteBatch from exports Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha b644fcf82c33533f6d5471ca3c96ded152a9b673

*: rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

pull request commenttikv/tikv

engine_rocks,engine_traits: abstract rocks util

/merge

Rustin-Liu

comment created time in a day

push eventbrson/tikv

Brian Anderson

commit sha 6cbb9488661118d8a96e7b6fa33c8cb739a1807e

tests: Port benches to RocksWriteBatch Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

push eventbrson/tikv

Brian Anderson

commit sha bafd80ab337e70a565fe502938339961850a6dc4

benches: Tweak function for writebatch Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha b941291b42ca4a5d8f76287492281d374096a4de

Upgrade to 3.0.9

view details

push time in a day

push eventbrson/tikv

YangKeao

commit sha b7920b087017e0ac67c6d72d005bf14b68076a78

Remove jemalloc from default feature of tikv-alloc (#6206) Signed-off-by: Yang Keao <keao.yang@yahoo.com>

view details

pingcap-github-bot

commit sha 46510f515b0313b8d1cca2145f22f47943c84437

rafstore: disable table split by default (#6253)

view details

Wenxuan

commit sha 7187a384f3755fbd9993ea34a910797117a37b9f

[release-3.0] Fix an unstable test (#6292) Signed-off-by: Breezewish <breezewish@pingcap.com>

view details

pingcap-github-bot

commit sha 44404381a0746710b928536ef9fc104d93d0d3f3

tidb_query: fix analyze column inconsistent behavior betwen TiDB and TiKV (#6055) (#6096) Signed-off-by: Lonng <heng@lonng.org>

view details

Lei Zhao

commit sha 5da607a1bc533a022a3b7c0ade9900c3426a00cb

cop/endpoint: relax log level (#6051)

view details

Lei Zhao

commit sha ab9d15b209704e2ab8a78af3185ceaad4d415631

lock_manager: polish waiter manager (#6244) (#6296)

view details

gengliqi

commit sha 6333c3ba44d8da64c86dbaca0df37f6ecf44f4e0

raftstore/apply: skip notification for synchronous destroy (#6297) Signed-off-by: gengliqi <gengliqiii@gmail.com>

view details

YangKeao

commit sha 40a135577a5ec44526cb8f6bec3fd5d5e3fcdcbe

[release-3.0] cherry pick: update pprof-rs to v0.3.12 (#6085) Signed-off-by: Lonng <heng@lonng.org> Signed-off-by: Yang Keao <keao.yang@yahoo.com>

view details

qupeng

commit sha e08266f3019e3ba2258575e4638f04528eabbcb7

fix error handling about rocksdb iterator (#6326) Signed-off-by: qupeng <qupeng@pingcap.com>

view details

Lei Zhao

commit sha 3d371cfb2a6d0f9dc8d3319ac4cc7016d84995b3

txn: use Commit to clean up pessimistic locks (#6353) (#6354) * txn: use Commit to clean up pessimistic locks (#6353) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Shirly

commit sha 0d3168cfd8224fbc48a07796df83ddac0fbcbf46

bump v3.0.8 (#6380)

view details

yiwu-arbug

commit sha 74ba6fed4b643b14539e087addfcb11a89caa661

Update rocksdb. Update rust-rocksdb branch for 3.0 branch (#6260) Signed-off-by: Yi Wu <yiwu@pingcap.com>

view details

Lei Zhao

commit sha d225a0e5b5a6dc203ebb86015846d8ade06ed1e1

lock_manager: more metrics (#6392) (#6422) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Lei Zhao

commit sha 47ff98cc22f7e933c25dee747e944e6f44582c92

lock_manager: update default config (#6426) (#6429) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Lei Zhao

commit sha da6941852b275e55e344277dee026996b61cae9e

deadlock: more solid role change observer (#6415) (#6431) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Jay

commit sha 858c11dcb85e07bdf27bf8f170beda80e4f6f134

raftstore: speed up conf change (#6421) (#6430)

view details

Neil Shen

commit sha 68b3d36f9f9f8b5eb347465e80ae02c98b135e4e

Bump v3.0.9 (#6428) Signed-off-by: Neil Shen <overvenus@gmail.com>

view details

Brian Anderson

commit sha bc34121387805d4cfcf4e151a882a5190c87baf9

Only warn on low file descriptors

view details

push time in a day

push eventbrson/tikv

Brian Anderson

commit sha 9e21827302de0b74065fb8ab8d57be34d61fba0d

raftstore: Remove unused functions Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha a9bdcc0d589c894c90e7a229e902e79c5b984b7c

Add more notes

view details

push time in a day

push eventbrson/tikv

Brian Anderson

commit sha aa013a59daffc243537ab74c5f8694d46d73d8e7

storage: Use RocksWriteBatch Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha 1d6bf9ad10c5a8ddada2d5372c57a3fc6246aa3a

Add notes for running tidb-server

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha d0176f96bff543c82fe4ce23ab0bfc5f30cec0d9

Fix tidb arg parsing harder

view details

push time in a day

push eventbrson/tikv

Brian Anderson

commit sha 013bd2bd43fd9aecddd65a1e42a0445c46a7b300

*: rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha c075824335ca683330587e774aa1f58a60e17e30

Fix tidb arg parsing

view details

push time in a day

push eventbrson/tikv

Lei Zhao

commit sha e71c034fbea027fa2b545ee7b3319157ac5e3d45

txn: add for_update_ts to lock info (#6671) Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>

view details

Yilin Chen

commit sha 778635c5109cf1090961aad567592c6330c69e47

cop: avoid handling requests multiple times (#6677) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

zihe.liu

commit sha 33f4932fdc1038ae1a62579dc2d77acdc46e6d05

copr: add vectorized truncate_real (#6561) Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>

view details

Lonng

commit sha da6e4ed73d3ddebead72575730402ed779c7dbf5

server: adjust log search end time to i64::MAX if end_time unset (#6686) Signed-off-by: Lonng <heng@lonng.org>

view details

Rustin

commit sha 70e9297eff95652792eb2f303f1b046da31037ad

engine_traits: rename cfdefs and delete engine cf (#6682) Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>

view details

Andy Lok

commit sha 079a806e549f25dbf86b75bdc5087f667a713476

copr: implement collation aware Vec-SlowHashAggr (#6652) Signed-off-by: Dian Luo <andylokandy@hotmail.com>

view details

Aylei

commit sha d75c838288408717695fcf8d1dd7aa9bb8a6b945

scripts: fix make docker (#6694) Signed-off-by: Aylei <rayingecho@gmail.com>

view details

MyonKeminta

commit sha 34af9ce7d4eb3f23056001ddfbfd1e73c0f22e16

cdc: Implement Endpoint and enable it in cmd/server (#6650) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

view details

kennytm

commit sha d0d8a8db82b6b4f8d4799cb49caf4fb46d5b2f5d

tikv_util: fix s3 writer always creating zeroes (#6675) Signed-off-by: kennytm <kennytm@gmail.com>

view details

zihe.liu

commit sha 53f8c96644d241f7c9d25b85d5e38f7d80a28c34

copr: add non-vectorized truncate_uint (#6557) Signed-off-by: ZiheLiu <ziheliu1024@gmail.com>

view details

Brian Anderson

commit sha 09e46791b603a49911d3ec598211679a779c01d1

Merge remote-tracking branch 'origin/master' into engine-traits-writebatch-3

view details

push time in a day

push eventbrson/tikv

Brian Anderson

commit sha 219270416e5310a3dcdc40b7b7706ca1689d1e39

server: Fix debug tests Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha fd274a19691f2d95cd1924886f9c724888d0751a

raftstore: Fix test build Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha 5fcc68ef68d554ab2fb4b5bbf23e04250d5657b1

Update commands

view details

push time in a day

push eventbrson/beast

Brian Anderson

commit sha 06e699b60822ed260198a2739206cf6f0341785b

Add notes about how to run servers

view details

Brian Anderson

commit sha 8a201925165b0c665436790678cee3fdc363655f

Update Makefile to use gvm

view details

push time in a day

push eventbrson/tikv

Brian Anderson

commit sha 77d75a609684fbac0f5fa1b0c828ac5b3f8940dd

engine_panic: fix build Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 9f5f066049a2ff0fffd8356350ee1cfedfef06a6

server: Replace WriteBatch with RocksWriteBatch in debug mod Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 3 days

push eventbrson/brson.github.com

Brian Anderson

commit sha b8443a9296cd736a2a579bef3a25759c3c8d06c6

.

view details

push time in 3 days

create barnchbrson/tikv

branch : engine-traits-writebatch-3

created branch time in 3 days

push eventbrson/my-rust-lists

Brian Anderson

commit sha b04090aad1f68fcf7bf5df84267352f9bce8f83b

.

view details

push time in 5 days

pull request commenttikv/tikv

Migrate to abstract TablePropertiesCollection types

All comments addressed.

brson

comment created time in 6 days

push eventbrson/tikv

Brian Anderson

commit sha 52b609f0a36b04486c29227033ba448306cf2fed

engine_traits: Remove typaram from UserCollectedProperties::get Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

issue commenttikv/tikv

Engine abstraction tracking issue

IOLimiter no longer exists, replaced by async-speed-limit in 965e8bfbca1aa1043a4785a419972bbe9d5c957c

brson

comment created time in 6 days

push eventbrson/tikv

Brian Anderson

commit sha 4e4184b6a6fbd4f11945a0163cda22e170ab39e3

engine_rocks: Remove allow(unused) from table_properties Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha d271c902246a6f61513cc53f45e475b785199c66

engine_panic: Fix type names in table_properties Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

push eventbrson/tikv

Yilin Chen

commit sha f5b7dc8c9321b13274fced3aaa2b6801a715f2ae

*: add stack size and max task number limit to unified read pool (#6597) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Yilin Chen

commit sha d2af249c4ca6c55b110b0c34461b0afe6b6bf581

*: unify read pools by default (#6593)

view details

Iosmanthus Teng

commit sha 36dab75da84ec57374d364a4a4af9146ec31df07

copr: Fix fuzz error in `codec::Duration` (#6636) Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

view details

Nick Cameron

commit sha aa786e1c3cd20260ce3258779438b29afbd933fc

*: fix some test errors on AMD and/or modern Linux kernels (#6497) Signed-off-by: Nick Cameron <nick@ncameron.org>

view details

5kbpers

commit sha 03f2dbe132f4c48d5e9dda460d62bf2ed269eb10

raftstore: add cmd observer (#6602) Signed-off-by: 5kbpers <tangminghua@pingcap.com>

view details

Nick Cameron

commit sha 5019e61d0c8e1966f6b649894ad17ba128068a1e

Make fuzzing work. (#6626) Signed-off-by: Nick Cameron <nrc@ncameron.org>

view details

Pinglei Guo

commit sha 882c7d37a49cdc4926cc534e087dbb08f88edc7d

copr: Add vectorized left and right (#6499) Signed-off-by: at15 <at15@outlook.com>

view details

Nick Cameron

commit sha 901eecaa7f4ec08b650004528b7e0a751fc806d2

Revert "*: fix some test errors on AMD and/or modern Linux kernels (#6643) Signed-off-by: Nick Cameron <nrc@ncameron.org>

view details

MyonKeminta

commit sha a6f9cd01a73b30806e23b4aa18c93017f5f69c7e

gc_worker & service/kv: Implement Non-streaming physical_scan_lock (#6631) Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

view details

Qinxuan Chen

commit sha 4761287587c9dcbcec1d86257a9c9ef1eab50f74

Replace the fork version with upstream murmur3 (#6559)

view details

Pengcheng Xu

commit sha 66d3b534987a2bb0a83b7c4ce23fa02ceb095a26

copr: Add vectorize day_of_week (#6645) Signed-off-by: Poytr1 <pooytr1@gmail.com>

view details

Jay

commit sha faa49ac0d22b7c1063ea3bac1f40a9ac33d0386b

apply/yield: remove unnecessary log (#6654) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

3pointer

commit sha 40534f59c015710247cfdd4f6db41b9d38305da2

backup: break one key scan when met delete version (#6655) Signed-off-by: luancheng <luancheng@pingcap.com>

view details

Neil Shen

commit sha a3588deb1746a670b062d7dc3494fc770ee974e8

*: reduce duplicate into_other (#6616) Signed-off-by: Neil Shen <overvenus@gmail.com>

view details

Jay

commit sha 271fe98872de2c7d491821dafbf5cf92cf34a571

tests: make test quick and stable (#6653) - Adjust make file to run integration tests first - Fix backup test that always timeout - Check lock result to avoid double panic - Disable transport stats for tests to save CPU Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

Yilin Chen

commit sha 58ed7e14a6f1a39c0ae50260547d78648b5f60c8

cop: allow light tasks to run when the semaphore has no permits available (#6582) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Brian Anderson

commit sha 37d87b220545925face9cc5235690ed2796313bd

engine_rocks: Fix type parameter names Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 65ded0f01efbd135742fa6e338882240bf97624f

Merge remote-tracking branch 'origin/master' into engine-traits-table-props-2

view details

push time in 6 days

issue commenttikv/tikv

Engine abstraction tracking issue

Per my comment on https://github.com/tikv/tikv/pull/6661#issuecomment-589486398, it looks like after @Rustin-Liu's migration of the MetricsFlusher there will still be more work to be done on it.

MetricsFlusher needs to be implemented in the engine_traits crate so that it can be instantiated with two different engines (vs. being a trait that is implemented in each engine). Doing so will require refactoring the implementation and abstracting out some of the calls it makes, as well as the lists of metrics it uses.

brson

comment created time in 6 days

issue commenttikv/tikv

Engine abstraction tracking issue

Thanks @Rustin-Liu !

brson

comment created time in 6 days

pull request commenttikv/tikv

engine_rocks,engine_traits: abstract rocks util

Beyond that though, there is an additional issue that needs to be fixed at some point, but I think is fair to not do in this PR:

The MetricsFlusher is parameterized over two databases, and ultimately those two databases need to be allowed to be two different types of databases.

That tells me that this is implemented at the wrong level of abstraction: instead of MetricsFlusher being a trait that is implemented by each database, MetricsFlusher really wants to be a concrete type that is implemented in engine_traits itself.

To do that will probably require a good bit of refactoring, and maybe adding some new abstractions to the engines.

I think let's not try to do that now.

Rustin-Liu

comment created time in 6 days

push eventtikv/fail-rs

Brian Anderson

commit sha e75d98a426ea49eb99a685db8247299d2ae4254c

Make new clippy happy (#49) These tests now trigger the "needless-doctest-main" lint. Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 6 days

PR merged tikv/fail-rs

Make new clippy happy

These tests now trigger the "needless-doctest-main" lint.

+4 -7

1 comment

1 changed file

brson

pr closed time in 6 days

Pull request review commenttikv/tikv

Migrate to abstract TablePropertiesCollection types

 pub trait TablePropertiesExt: CFHandleExt {     } } -pub trait TablePropertiesCollection {}+pub trait TablePropertiesCollection<I, PKey, P, UCP>+where+    I: TablePropertiesCollectionIter<PKey, P, UCP>,+    PKey: TablePropertiesKey,+    P: TableProperties<UCP>,+    UCP: UserCollectedProperties,+{+    fn iter(&self) -> I;++    fn len(&self) -> usize;++    fn is_empty(&self) -> bool {+        self.len() == 0+    }+}++pub trait TablePropertiesCollectionIter<PKey, P, UCP>: Iterator<Item = (PKey, P)>+where+    PKey: TablePropertiesKey,+    P: TableProperties<UCP>,+    UCP: UserCollectedProperties,+{+}++pub trait TablePropertiesKey: Deref<Target = str> {}++pub trait TableProperties<UCP>+where+    UCP: UserCollectedProperties,+{+    fn num_entries(&self) -> u64;++    fn user_collected_properties(&self) -> UCP;+}++pub trait UserCollectedProperties {+    fn get<Q: AsRef<[u8]>>(&self, index: Q) -> Option<&[u8]>;

I agree. I'll remove it.

brson

comment created time in 6 days

Pull request review commenttikv/tikv

Migrate to abstract TablePropertiesCollection types

 // Copyright 2019 TiKV Project Authors. Licensed under Apache-2.0. +#![allow(unused)]

Good catch. This was just during development.

brson

comment created time in 6 days

push eventbrson/bloop

Brian Anderson

commit sha eac972b4d9937b1cf0d8d1506481daefaf764ae9

Add temporary mir

view details

Brian Anderson

commit sha dc4ae1b0075bc76f9b1a8f84a5d2eb7e764bccdf

Connect mir to jit

view details

Brian Anderson

commit sha 55b6294a0eae3dc036d42b7b030e5c1524a89de5

.

view details

Brian Anderson

commit sha fc4b6f7637b5427b2def034407610c889103888a

Remove floats

view details

Brian Anderson

commit sha 8eadf01188104560b91bb162e712b7c0b6581ad0

Rename Uint to Int32

view details

Brian Anderson

commit sha c00705a4f5f5c80ccd8e1abe882170ba60e2bc33

I32 -> Int32

view details

Brian Anderson

commit sha e08dfb04dd58437ddf61a3c4130126f5d02a01bc

Add i32 literals

view details

Brian Anderson

commit sha 251ad5cf90aefabc6ca95ed87d2ad7a666e91a48

.

view details

Brian Anderson

commit sha 3ab8b7b91f6f9d5364613d0aabba61ecd9e81488

Add a salsa dep

view details

Brian Anderson

commit sha 9e4e474b594ab26ced09ee8f38415568a03df6f0

Update chalk dep

view details

push time in 7 days

push eventbrson/tikv

push time in 8 days

pull request commenttikv/tikv

Migrate to abstract TablePropertiesCollection types

Looks like this requires some rework to merge with master. I'll fix it tomorrow.

brson

comment created time in 8 days

pull request commenttikv/fail-rs

Make new clippy happy

Commit is signed off now.

brson

comment created time in 8 days

push eventbrson/fail-rs

Brian Anderson

commit sha e6f3fe0b15dff4d599d2d4728089c0e95291ec98

Make new clippy happy These tests now trigger the "needless-doctest-main" lint. Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 8 days

push eventbrson/tikv

Brian Anderson

commit sha 24438e475cd994e4fbc9b808bbe8d4fbc9fb680e

engine_*: Remove unneeded typedefs Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha c8104662a02f57c161f2535bd8b750e2c44152bf

engine_traits: some syntactic changes Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 5f87bfa0addcb90558b30038247261b4f4e2ebb0

Merge remote-tracking branch 'origin/master' into engine-traits-table-props-2

view details

push time in 8 days

push eventbrson/tikv

Brian Anderson

commit sha 3de8d2ffcabef09578d032410b9b81effe560aa4

engine_rocks: Fix typo Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 8 days

pull request commenttikv/tikv

Migrate to abstract TablePropertiesCollection types

Updated. I've made all suggested changes. Thanks for the review @kennytm .

brson

comment created time in 8 days

Pull request review commenttikv/tikv

Migrate to abstract TablePropertiesCollection types

 pub trait TablePropertiesExt: CFHandleExt {     } } -pub trait TablePropertiesCollection {}+pub trait TablePropertiesCollection<I, PKey, P, UCP>+where+    I: TablePropertiesCollectionIter<PKey, P, UCP>,+    PKey: TablePropertiesKey,+    P: TableProperties<UCP>,+    UCP: UserCollectedProperties,+{+    fn iter(&self) -> I;++    fn len(&self) -> usize;++    fn is_empty(&self) -> bool {+        self.len() == 0+    }+}++pub trait TablePropertiesCollectionIter<PKey, P, UCP>+where+    Self: Iterator<Item = (PKey, P)>,+    PKey: TablePropertiesKey,+    P: TableProperties<UCP>,+    UCP: UserCollectedProperties,+{+}++pub trait TablePropertiesKey+where+    Self: Deref<Target = str>,+{+}

Mostly for stylistic consistency with nearby types that contain lots of where clauses.

brson

comment created time in 8 days

push eventbrson/tikv

Yilin Chen

commit sha f5b7dc8c9321b13274fced3aaa2b6801a715f2ae

*: add stack size and max task number limit to unified read pool (#6597) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Yilin Chen

commit sha d2af249c4ca6c55b110b0c34461b0afe6b6bf581

*: unify read pools by default (#6593)

view details

Iosmanthus Teng

commit sha 36dab75da84ec57374d364a4a4af9146ec31df07

copr: Fix fuzz error in `codec::Duration` (#6636) Signed-off-by: Iosmanthus Teng <myosmanthustree@gmail.com>

view details

Nick Cameron

commit sha aa786e1c3cd20260ce3258779438b29afbd933fc

*: fix some test errors on AMD and/or modern Linux kernels (#6497) Signed-off-by: Nick Cameron <nick@ncameron.org>

view details

5kbpers

commit sha 03f2dbe132f4c48d5e9dda460d62bf2ed269eb10

raftstore: add cmd observer (#6602) Signed-off-by: 5kbpers <tangminghua@pingcap.com>

view details

Nick Cameron

commit sha 5019e61d0c8e1966f6b649894ad17ba128068a1e

Make fuzzing work. (#6626) Signed-off-by: Nick Cameron <nrc@ncameron.org>

view details

Pinglei Guo

commit sha 882c7d37a49cdc4926cc534e087dbb08f88edc7d

copr: Add vectorized left and right (#6499) Signed-off-by: at15 <at15@outlook.com>

view details

Brian Anderson

commit sha 7531ea30f6a47220dbd530661e9ba807eab409a9

Merge branch 'master' into engine-traits-table-props-2

view details

push time in 8 days

push eventbrson/tikv

Brian Anderson

commit sha 7ad70a5a0653b92025dd90c38d3337aea191bd33

engine_*: Remove unneeded typedefs Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

Brian Anderson

commit sha 5b0f7f13dbe1df9eb74f255c90a7b7fa8504f070

engine_traits: some syntactic changes Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 8 days

PR opened tikv/tikv

Reviewers
Migrate to abstract TablePropertiesCollection types

<!-- Thank you for contributing to TiKV!

If you haven't already, please read TiKV's CONTRIBUTING document.

If you're unsure about anything, just ask; somebody should be along to answer within a day or two. -->

What have you changed?

This patch adds TablePropertiesCollection and its related types to engine_traits, implements them for rocksdb, and migrates tikv to use the abstract versions.

This build on new reference-counted types in rust-rocksdb. The design implies that future implementations must also be reference counted.

After this patch, the engine crate no longer exports TablePropertiesCollection types.

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

cargo check --all, limited unit testing

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

no

Does this PR affect tidb-ansible?

no

Refer to a related PR or issue link (optional)

https://github.com/tikv/tikv/issues/6402

Benchmark result if necessary (optional)

Any examples? (optional)

+345 -127

0 comment

20 changed files

pr created time in 11 days

push eventbrson/tikv

Yilin Chen

commit sha 359b6b778bccf7fbc8e16450e28657aec2775ace

add unified read pool configs to config template (#6585) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

Andy Lok

commit sha ff6fda3f68d159c53bd9fb0d871ebd970778ac77

copr: Refine collation comparison (#6589) Signed-off-by: Dian Luo <andylokandy@hotmail.com>

view details

mahjonp

commit sha 8e4abec35d5279620ddf0de72697ffb78d0864b4

Makefile: add a doc test rule and fix a failed doc test case (#6551) Signed-off-by: mahjonp <junpeng.man@gmail.com>

view details

Rustin

commit sha 8fa0e059e14c3a1433fcb581452f9ea0a14a72ce

engine_traits: fix typo (#6590) Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>

view details

NingLin-P

commit sha f98a32e4a092ad800aa5648919698b113b22c93d

config: skip some rocksdb config (#6599) Signed-off-by: linning <linningde25@gmail.com>

view details

庄天翼

commit sha 551e30524c0ce9559c8c8f298e2dd51641b9ad24

copr: Support collation aware like (#6592) Signed-off-by: TennyZhuang <zty0826@gmail.com>

view details

Yixuan Zhao

commit sha 7996a223a221d6200dfb5993f577257ff66b0ff3

readme: update build job badge url (#6595)

view details

Yilin Chen

commit sha f20f6303ff79d1696aeff9adfec77842236c9c03

*: add metrics for unified read pool (#6534) Signed-off-by: Yilin Chen <sticnarf@gmail.com>

view details

gengliqi

commit sha 524870e5415449fba3f3c61f943fcf6ea487569a

raftstore: change the region merge flow path to fix some bugs (#6481) Signed-off-by: Liqi Geng <gengliqiii@gmail.com>

view details

Fullstop000

commit sha c26ac6025d9d6779d429ce4907fd2a6f54fb0302

copr: introduce Binary Json (#6388) Signed-off-by: Fullstop000 <fullstop1005@gmail.com>

view details

mwish

commit sha 30db88d69907b308337f07768bf85b26ff2cc346

Server: adding binary_path to store for tikv (#6601) Signed-off-by: mapleFU <1506118561@qq.com>

view details

Andy Lok

commit sha ac9d4913557d7c96cad982c6e772c4e2e792b168

copr: implement macro match_template_collator (#6606) Signed-off-by: Dian Luo <andylokandy@hotmail.com>

view details

SIGSEGV

commit sha 37b675cc4be03dae3b3d20599747917e76d88004

metrics: add grafana and alertmanager scripts (#6433) Signed-off-by: lucklove <gnu.crazier@gmail.com>

view details

Neil Shen

commit sha f31863a5551976188bb60bad9a594f67a5166500

raftstore: move raftstore to components (#6583) * raftstore: move raftstore to components Signed-off-by: Neil Shen <overvenus@gmail.com> * fix prost build Signed-off-by: Neil Shen <overvenus@gmail.com> Co-authored-by: NingLin-P <linning@pingcap.com>

view details

qupeng

commit sha abe56a3534762081bbfa1010917c8fc8d595f947

raftstore: fix a panic in read index queue (#6609) Signed-off-by: qupeng <qupeng@pingcap.com>

view details

gengliqi

commit sha e4807144f495d7d514501ef2d8852c5d4c67cf37

raftstore: set wait_merge_state to none after resuming pending state (#6615) Signed-off-by: Liqi Geng <gengliqiii@gmail.com>

view details

Jay

commit sha 8c3f41a99ed163d731a3a55415b0fa0b0b5f3c5b

fix test target (#6619) Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

gengliqi

commit sha a7af9469d4af92b409ddf75cadcbbdd356c9a144

raftstore: learner load merge target & fix a merge network recovery bug (#6598) Signed-off-by: Liqi Geng <gengliqiii@gmail.com> Signed-off-by: Jay Lee <BusyJayLee@gmail.com>

view details

pingcap-github-bot

commit sha b0241e858f36f689c53856b67f0f6fe9b93bea63

rust-rocksdb: Add reference-counted TablePropertiesCollection bindings (#6550) Signed-off-by: sre-bot <sre-bot@pingcap.com>

view details

Brian Anderson

commit sha 2cbb26edf6ea94e7c4bc4eaa157478848fd5b572

Merge remote-tracking branch 'origin/master' into engine-traits-table-props-2

view details

push time in 11 days

Pull request review commenttikv/fail-rs

fail: check condition only when its failpoint is open

 fn set( #[cfg(feature = "failpoints")] macro_rules! fail_point {     ($name:expr) => {{-        $crate::eval($name, |_| {-            panic!("Return is not supported for the fail point \"{}\"", $name);-        });+        $crate::eval(+            $name,+            |_| {+                panic!("Return is not supported for the fail point \"{}\"", $name);+            },+            || true,+        );     }};     ($name:expr, $e:expr) => {{-        if let Some(res) = $crate::eval($name, $e) {+        if let Some(res) = $crate::eval($name, $e, || true) {             return res;         }     }};     ($name:expr, $cond:expr, $e:expr) => {{-        if $cond {-            fail_point!($name, $e);+        if let Some(res) = $crate::eval($name, $e, || $cond) {

If true then we better add a test case that captures the expected behavior.

@gengliqi can you try adding a test case that shares mutable references between the two expressions and seeing if they worked previously but don't work after this patch?

gengliqi

comment created time in 11 days

pull request commenttikv/fail-rs

fail: check condition only when its failpoint is open

Here's a patch to fix CI: https://github.com/tikv/fail-rs/pull/49

gengliqi

comment created time in 11 days

PR opened tikv/fail-rs

Reviewers
Make new clippy happy

These tests now trigger the "needless-doctest-main" lint.

+4 -7

0 comment

1 changed file

pr created time in 11 days

create barnchbrson/fail-rs

branch : doctest-main

created branch time in 11 days

create barnchbrson/tikv

branch : engine-traits-writebatch-2

created branch time in 11 days

pull request commenttikv/tikv

rust-rocksdb: Add reference-counted TablePropertiesCollection bindings

/merge

sre-bot

comment created time in 11 days

push eventbrson/tikv

Brian Anderson

commit sha 6de7b4e1f6bf8622f1579393a1ce2cca38d7cf9d

engine_*: fixes from merge Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 11 days

fork brson/coconut-report

Aimee's lovely report

fork in 11 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 78d9d5dab79ccf5fa8080d602c414b31ef032c03

.

view details

push time in 12 days

push eventbrson/rust-anthology

Brian Anderson

commit sha bd86777262ee44775a8af272c8ddf61e9a474911

.

view details

push time in 12 days

push eventbrson/my-rust-lists

Brian Anderson

commit sha d0314b32bc8de5506c6532247e33ce1975fffabf

.

view details

push time in 12 days

push eventbrson/bloop

Brian Anderson

commit sha 837522a864f9b7c71085e2cf350f81c1c16a13a7

Parse 'let'

view details

Brian Anderson

commit sha 16dc5de97f26b260d3d48020e52ba60e5aedb902

.

view details

push time in 12 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 76f92d030c4575bc9903ee0ef474acd10b38ea95

.

view details

push time in 13 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 3117f2cc2f5fce3bbcb53dda53fe9a1f580388ce

.

view details

push time in 14 days

push eventbrson/brson.github.com

Brian Anderson

commit sha d200cad4975ff9b1ef95f2e7ef7e69db152a62b1

.

view details

push time in 14 days

create barnchbrson/tikv

branch : engine-traits-table-props-2

created branch time in 14 days

pull request commenttikv/tikv

rust-rocksdb: Add reference-counted TablePropertiesCollection bindings

/merge

sre-bot

comment created time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha c9ad93b624d51213fde06f30caef350f2c10c5e3

.

view details

Brian Anderson

commit sha f55d4b86f64bfedd78024af3bcbc5d9320844f89

Add feed to index.html

view details

Brian Anderson

commit sha e2a619eeff77aa5d081e8cfdeb352ad362a33ba9

untabify

view details

push time in 15 days

pull request commenttikv/tikv

rust-rocksdb: Add reference-counted TablePropertiesCollection bindings

/merge

sre-bot

comment created time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 9f6616db6bdadb860e2b603fa2e926d2c963ed3b

Add atom feed

view details

push time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha f84fb7a3de6987fcc1f5f15bcae66f320f9d12a6

.

view details

push time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 324db36b604670f833e7b7c2e9f067a20d368bef

.

view details

push time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 2427a3fb21b9189132c42328397e63a046c4ab77

.

view details

push time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 09159d40b17f0bd4103e7fb348c847e4b6581ee9

.

view details

Brian Anderson

commit sha 1c87d6ef4e75759b52e7b653a90c038cec74cd05

.

view details

push time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha b87d6df70085f7f85015081078617255e66dbe06

.

view details

Brian Anderson

commit sha d439b63562522c9c12fc2fe287f67077c1c9662a

.

view details

Brian Anderson

commit sha 11059efe86b8aa95214e54ceec1d24064e8e270e

.

view details

Brian Anderson

commit sha 6558eb2ce282d050ba3625a68fc22bfabcada595

.

view details

push time in 15 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 0f6404449fe0b9ac9af6ef46476b6e0778573b6f

Add a container around nav/main

view details

Brian Anderson

commit sha a4231ba73b9596d73a3cf874cd7aa3da0a294fc1

cleanup

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 0aa5075ca0ccbd3360ed05186b006275e06f14eb

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha a855708bfd373cb1a085cdf333f9ebb3d821b14b

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 6a69d7f0cf87883fe2e19ba91b41b8aa73aadf0c

remove @imports from css

view details

Brian Anderson

commit sha d30f7cef9f24bc9e3c86750454d2736db59021c0

Add home navigation

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha f2a5bc5f93f1f229144406972312b98f3056ffeb

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 89e3f5bad8534cfeff6ce6b7e172871d9a25f126

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 1a8b2e510761d526acb717d1d881f9f6dfbfd462

.

view details

Brian Anderson

commit sha d4d51510779f5b7126417c97c1d8d2771091c5c2

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 955fffa709d445fbbb31e4f8d4bff2b36d4c9116

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha abdb10b7b3946a90cc049fba1f23c311cd89c329

color tweaking

view details

Brian Anderson

commit sha 8986001b8ef7728a241cd8ac6c328084a52a1ec5

.

view details

Brian Anderson

commit sha fe3405616c061a942c03fec6c031a4979f0b8dd5

.

view details

push time in 16 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 75b2923e13c7d7d033e91dd374752c6ed50068b1

Put all colors in their own css

view details

Brian Anderson

commit sha b99d61a46f4a1d8be0ce437c4c5bb604b4559224

more style

view details

push time in 17 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 6d41edc17db7fe40c3798d12dca0f735eb6e1e1c

.

view details

push time in 17 days

push eventbrson/brson.github.com

Brian Anderson

commit sha 59b5a29ea83c73f5c1ac0570dfcf15e4049e7ae3

Update blog index style

view details

Brian Anderson

commit sha db40ec512c48290b14d22bd70844a912b0184bb6

Move stylesheets to css dir

view details

Brian Anderson

commit sha 6cfe84b00523e4b85151cdba71b4a94270ccd296

Fix markup

view details

Brian Anderson

commit sha 1243a3375dde09e837a5abeacb8216f8b7660297

.

view details

Brian Anderson

commit sha e372298ea56ba5a16f47b645c922d7bbff5faccd

Use consistent style on my resume

view details

push time in 17 days

push eventtikv/tikv

Brian Anderson

commit sha 95bd752a26550930ce0d444e8073a4214824d6b1

Add an engine template project - engine_panic (#6383) * engine_panic: Add engine_panic project Signed-off-by: Brian Anderson <andersrb@gmail.com> * engine_panic: Add module structure Signed-off-by: Brian Anderson <andersrb@gmail.com> * engine_panic: Fill in types Signed-off-by: Brian Anderson <andersrb@gmail.com> * engine_panic: Fix Iterator defs Signed-off-by: Brian Anderson <andersrb@gmail.com> * engine_panic: rustfmt Signed-off-by: Brian Anderson <andersrb@gmail.com> * engine_panic: Fixes from merge Signed-off-by: Brian Anderson <andersrb@gmail.com>

view details

push time in 17 days

PR merged tikv/tikv

Reviewers
Add an engine template project - engine_panic C: RocksDB S: LGT1

What have you changed?

This adds the engine_panic crate. It is a template from which other engine_traits implementations can be built, by first copying engine_panic into a new crate. Begining an engine this way eliminates hours of defining types, and organizes the crate in a way that is consistent with the existing crates.

I created this after attempting to implement a new engine and discovering that it took many hours just to organize the types correctly.

What is the type of the changes?

  • Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?

cargo check

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Does this PR affect tidb-ansible?

<!-- If there is a configuration or metrics change, please file a PR in tidb-ansible, and add the PR number here. -->

Refer to a related PR or issue link (optional)

https://github.com/tikv/tikv/issues/4184

Benchmark result if necessary (optional)

Any examples? (optional)

+697 -21

5 comments

16 changed files

brson

pr closed time in 17 days

push eventbrson/brson.github.com

Brian Anderson

commit sha ce69b3ca13075647234a632f658fd7eed12613d2

Reduce html duplication

view details

Brian Anderson

commit sha 83719b5d1cef28b7c7d9c3060cd53dc5a5e92183

Overhaul style

view details

Brian Anderson

commit sha 08bb1d7c3a6170297932ea6423285647ba47af62

.

view details

push time in 17 days

push eventbrson/brson.github.com

Brian Anderson

commit sha a046a19cb8e7ce6f97a1c454d2c255e2232b7463

.

view details

push time in 17 days

more