profile
viewpoint
Brendan Zabarauskas brendanzab @yeslogic Melbourne, Australia http://voyager3.tumblr.com I'm a poly-paradigm developer, primarily interested in how how type systems can be used as a tool for thought. I generate worlds in my spare time!

brendanzab/codespan 160

Utilities for dealing with source code locations and pretty diagnostic formatting

brendanzab/approx 63

Approximate floating point equality comparisons and assertions

brendanzab/algebra 54

Abstract algebra for Rust (still very much a WIP!)

brendanzab/color-rs 43

A library that provides types and conversions for working with various color formats.

brendanzab/chronicle 34

An event sourced CQRS framework for Rust

brendanzab/bullet-rs 8

Bindings and wrapper for the Bullet physics C API.

brendanzab/elm-stlc 7

Bidirectional type checker for the simply typed lambda calculus

brendanzab/Derelict3 2

A collection of dynamic D bindings to C libraries, useful for multimedia and game development.

brendanzab/efl-rs 2

Servo-specific wrapper for the relevant components of the Enlightenment Foundation Libraries.

brendanzab/gfx-rs 2

A lightweight graphics device manager for Rust

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha ff35da01e37bf99232fcb6334918402b1d4b9985

Add some accessor methods to file structs

view details

push time in an hour

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 4c5a52bef610f43fb34b936464f51f9e04af2902

Copy some tests over from codespan

view details

push time in an hour

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha f59f6549cfc59333b6f1d86e3457703aa4c8b389

Add documentation to Line methods

view details

push time in an hour

PR opened brendanzab/codespan

Add SimpleFile and SimpleFiles structs

This adds the SimpleFile and SimpleFiles structures to the codespan_reporting crate to get people started with their programming languages. It also inverts the dependency between codespan and codespan_reporting. That way users of codespan_reporting no longer have to depend on codespan if they don’t want to.

+262 -127

0 comment

12 changed files

pr created time in 2 hours

create barnchbrendanzab/codespan

branch : simple-files

created branch time in 2 hours

startedmroman42/mikrokosmos

started time in 3 hours

startedRuddle/oxidator

started time in 3 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 6a01e8c0be4b3bd719d7358c434cf6d994e8a8d7

WIP: experiment with line data structures

view details

push time in 5 hours

create barnchbrendanzab/codespan

branch : experiments/mark-group

created branch time in 5 hours

create barnchbrendanzab/codespan

branch : experiments/line-rendering

created branch time in 5 hours

delete branch brendanzab/codespan

delete branch : line-rendering-experiments

delete time in 5 hours

Pull request review commentbrendanzab/codespan

Diagnostic API cleanups

+---+source: codespan-reporting/tests/term.rs+expression: TEST_DATA.emit_no_color(&TEST_CONFIG)+---+bug: 

Not sure about this output - seems rather challenging to do anything useful if there is no title? 😬

brendanzab

comment created time in 5 hours

delete branch brendanzab/codespan

delete branch : component-trait

delete time in 5 hours

create barnchbrendanzab/codespan

branch : multiline-label-messages

created branch time in 5 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha a2e464e87bf278976c003eff3a5ce33f9c3bc6b3

Diagnostic API cleanups

view details

push time in 5 hours

starteduwplse/ornamental-search

started time in 6 hours

startedRustSec/cargo-lock

started time in 6 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha ee76ff7b3173a1e61f0fcbb8201c39442d7bf945

Diagnostic API cleanups

view details

push time in 6 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 73f2a8cda5ed440882d656c3f4f0cfd2724c404b

Diagnostic API cleanups

view details

push time in 7 hours

Pull request review commentbrendanzab/codespan

Diagnostic API cleanups

 pub fn emit<Source: AsRef<str>>(     files: &Files<Source>,     diagnostic: &Diagnostic, ) -> io::Result<()> {-    use self::views::{RichDiagnostic, ShortDiagnostic};+    use std::collections::BTreeMap;++    use self::views::MarkStyle;+    use self::views::{Header, NewLine, Note, SourceSnippet};++    // Emit the title+    //+    // ```text+    // error[E0001]: unexpected type in `+` application+    // ```+    if let Some(title) = &diagnostic.title {+        Header::new(diagnostic.severity, title).emit(writer, config)?;+        NewLine::new().emit(writer, config)?;+    }++    // Group labels by file++    let mut label_groups = BTreeMap::new(); -    match config.display_style {-        DisplayStyle::Rich => RichDiagnostic::new(diagnostic).emit(files, writer, config),-        DisplayStyle::Short => ShortDiagnostic::new(diagnostic).emit(files, writer, config),+    for label in &diagnostic.labels {+        let mark_style = match label.style {+            LabelStyle::Primary => MarkStyle::Primary(diagnostic.severity),+            LabelStyle::Secondary => MarkStyle::Secondary,+        };+        label_groups+            .entry(label.file_id)+            .or_insert(vec![])

Tbh I've always been a tad suspicious of using Default for stuff like monoidal identities… kind of would prefer to leave it explicit. 😅

brendanzab

comment created time in 7 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 931d019e98edd3917a5f90937ed3bfccbefbab85

Don’t highlight underlined source with mark color This should make it easier to implement grouped labels in the future, as we won’t have to deal with overlapping colours in the source - only overlapping underlines!

view details

Brendan Zabarauskas

commit sha 4151d40d26159c00d78d1ab6b335ad21cd26dab8

Merge pull request #168 from brendanzab/remove-source-highlighting Don’t highlight underlined source with mark color

view details

Brendan Zabarauskas

commit sha 0bc1d6f8939782185e0453c2cbd53c405c30526b

Diagnostic API cleanups

view details

push time in 7 hours

delete branch brendanzab/codespan

delete branch : remove-source-highlighting

delete time in 7 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 931d019e98edd3917a5f90937ed3bfccbefbab85

Don’t highlight underlined source with mark color This should make it easier to implement grouped labels in the future, as we won’t have to deal with overlapping colours in the source - only overlapping underlines!

view details

Brendan Zabarauskas

commit sha 4151d40d26159c00d78d1ab6b335ad21cd26dab8

Merge pull request #168 from brendanzab/remove-source-highlighting Don’t highlight underlined source with mark color

view details

push time in 7 hours

PR merged brendanzab/codespan

Reviewers
Don’t highlight underlined source with mark color

This should make it easier to implement grouped labels in the future (see #100), as we won’t have to deal with overlapping colours in the source - only overlapping underlines!

+46 -69

5 comments

4 changed files

brendanzab

pr closed time in 7 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha a980eda9550b4196243b4b8ae82d97dbbc895850

Allow for custom line numbers

view details

Brendan Zabarauskas

commit sha 25fcd1bfc00f3e7246fda5dbf8314b5532690f9e

Merge pull request #167 from brendanzab/line-number Allow custom line numbers

view details

Brendan Zabarauskas

commit sha 1712132f4e6fc9b7d6534e4fdcf2d102d70eaa6e

Diagnostic API cleanups

view details

Brendan Zabarauskas

commit sha 26897d3115ed1b9680fd671d4461d0bafc04ce25

WIP: experiment with line data structures

view details

push time in 7 hours

pull request commentbrendanzab/codespan

Don’t highlight underlined source with mark color

Yeah, I could always make it so that the primary highlight takes precedence, but yeah, I'd rather just simplify the code more \in an attempt to make my life easier 😅

brendanzab

comment created time in 7 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 25fcd1bfc00f3e7246fda5dbf8314b5532690f9e

Merge pull request #167 from brendanzab/line-number Allow custom line numbers

view details

Brendan Zabarauskas

commit sha 1712132f4e6fc9b7d6534e4fdcf2d102d70eaa6e

Diagnostic API cleanups

view details

push time in 7 hours

pull request commentbrendanzab/codespan

Don’t highlight underlined source with mark color

A more involved example:

Before: Screen Shot 2020-02-26 at 4 25 26 pm

After: Screen Shot 2020-02-26 at 4 25 05 pm

brendanzab

comment created time in 7 hours

pull request commentbrendanzab/codespan

Don’t highlight underlined source with mark color

Sure!

Before: Screen Shot 2020-02-26 at 4 20 27 pm

After: Screen Shot 2020-02-26 at 4 20 03 pm

brendanzab

comment created time in 7 hours

PR opened brendanzab/codespan

Don’t highlight underlined source with mark color

This should make it easier to implement grouped labels in the future (see #100), as we won’t have to deal with overlapping colours in the source - only overlapping underlines!

+46 -69

0 comment

4 changed files

pr created time in 8 hours

create barnchbrendanzab/codespan

branch : remove-source-highlighting

created branch time in 8 hours

issue closedbrendanzab/codespan

Allow setting custom line numbers

This is a bit of an edge case ... In C there is a #line macro that allows setting the current line number, it looks like this:

void f();
int main() {
    #line 1
    return f();
}
<stdin>:1:12: error: returning 'void' from a function with incompatible result type
      'int'

Note how the error message says the error occurs on line 1, not line 4.

Currently, it looks like the lines in a file are calculated once and can't be modified. Would it be possible to make the line numbers configurable?

This has the unfortunate complication that there's no longer a 1-1 mapping between the line numbers displayed to the user and the lines in a file: in my example above, there are 2 lines with line number 1. However, this corresponds pretty closely to the current difference between LineIndex (internal) and LineNumber (user-facing) so I don't forsee it being a giant deal.

closed time in 8 hours

jyn514

delete branch brendanzab/codespan

delete branch : line-number

delete time in 8 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 5fb7a7327c19678eb68279be212438cd400fbe70

Use Files::line_index where possible

view details

Brendan Zabarauskas

commit sha a980eda9550b4196243b4b8ae82d97dbbc895850

Allow for custom line numbers

view details

Brendan Zabarauskas

commit sha 25fcd1bfc00f3e7246fda5dbf8314b5532690f9e

Merge pull request #167 from brendanzab/line-number Allow custom line numbers

view details

push time in 8 hours

PR merged brendanzab/codespan

Reviewers
Allow custom line numbers

Closes #108.

+45 -34

1 comment

4 changed files

brendanzab

pr closed time in 8 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha a980eda9550b4196243b4b8ae82d97dbbc895850

Allow for custom line numbers

view details

Brendan Zabarauskas

commit sha c6de891ea618d0a52630a997120b6a03656c9d83

Diagnostic API cleanups

view details

Brendan Zabarauskas

commit sha 018a95c8fd89888023663ebab60fafe0c5e2a17b

Create intermediate ‘mark’ data structures

view details

Brendan Zabarauskas

commit sha 174a77bc1aac50fdba566b3f1874712e2d35f2f2

Add tests for labeless diagnostics

view details

Brendan Zabarauskas

commit sha 4c278534c0d3869fe90acdea39788afe0cb06601

Add with_message builder method to labels

view details

push time in 11 hours

PR opened brendanzab/codespan

Reviewers
Allow custom line numbers

Closes #108.

+45 -34

0 comment

4 changed files

pr created time in 11 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha a980eda9550b4196243b4b8ae82d97dbbc895850

Allow for custom line numbers

view details

push time in 11 hours

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 5fb7a7327c19678eb68279be212438cd400fbe70

Use Files::line_index where possible

view details

Brendan Zabarauskas

commit sha 5cf6d9db3612de4b8c631affddffef93588a6f3f

Allow custom line numbers

view details

push time in 12 hours

issue commentbrendanzab/gl-rs

Yank breaking versions with "*" deps

In that case I'm guessing the entire gl_generator ^0.0.1 series should be yanked up to and including gl_generator 0.0.28, seeing as they also depend on * versions of xml-rs and libc?

kornelski

comment created time in a day

pull request commentbrendanzab/gl-rs

Update documentation, dependencies, and fix warnings

Sorry for the really late merging too - I'm using the new github notification beta which is helping a bunch keep on top of this kind of thing. Thanks for your patience!

Bzomak

comment created time in a day

push eventbrendanzab/gl-rs

Robert Horswell

commit sha 0c2ff1cfad8cfc5fd5f750c15d29ed40a922771a

Update READMEs and documentation This updates the crate versions, removes the outdated and partial changelogs, fixes some typos, and ensures consistency between the READMEs and the documentation.

view details

Robert Horswell

commit sha 12a3871f3449d8276a45f6833a65e4b300493a8e

Increase OpenGL version to 4.6 This bumps the OpenGL version in the build scripts from 4.5 to 4.6

view details

Robert Horswell

commit sha c925c04af858ccd056dae2ea8b9092a30d2913bd

Cargo fmt

view details

Robert Horswell

commit sha f54736bbca87c048093721b95c0d9044941c50a0

Adjust dependencies Sets dependencies to the lastest minor version. Bumping webidl from 0.8 to 0.9 required changes in webgl_registry/registry.rs.

view details

Robert Horswell

commit sha dbc850d4bf384ca3ed0983edd23e5085df408585

Fix deprecated try! warnings Converts the try! macro to the ? operator.

view details

Robert Horswell

commit sha 7b299e99235221a99821710ef43e279672fb062b

Fix "type alias is never used warnings" Adds #[allow(dead_code)] to the generated code.

view details

Robert Horswell

commit sha 9427142c1f23708142051de44c141d502026f386

Fix deprecated use of `trim_right` warning. Converts trim_right() to trim_end(). `trim_end()` became stable in Rust v1.30.0 and `trim_right` was deprecated in Rust v1.33.0.

view details

Robert Horswell

commit sha 6810f0a71972997a993a0572664bd6a2768c35c2

Fix use of deprecated item 'std::mem::uninitialized' warnings Converts `std::mem::uninitialized()` to `std::mem::MaybeUninit::uninit().assume_init()`. `std::mem::MaybeUninit` was made stable in Rust v1.36.0 and `std::mem::uninitialized()` will be deprecated in Rust v1.39.0.

view details

Robert Horswell

commit sha 0ba080b65966d2b6bd176fec07811ad6379a04fa

Update glutin dev-dependency to v0.23 Uses the structure from the [glutin window example](https://github.com/rust-windowing/glutin/blob/f071c722f725143d80638f1c5c12a76d9d8e1be8/glutin_examples/examples/window.rs)

view details

Robert Horswell

commit sha d142f6e6e85d33faae71da0d4e1ce2fc322c457d

Cargo fmt

view details

Brendan Zabarauskas

commit sha 4977c775b15481339f169786fb98c945953797d9

Merge pull request #504 from Bzomak/master Update documentation, dependencies, and fix warnings

view details

push time in a day

PR merged brendanzab/gl-rs

Update documentation, dependencies, and fix warnings

I've removed the changelogs from the READMEs, as they were outdated and incomplete. I'm open to creating CHANGELOG.md files for the crates if required, but I haven't had the motivation to go trawling through all the commit history... Other than this, commit https://github.com/brendanzab/gl-rs/commit/0c2ff1cfad8cfc5fd5f750c15d29ed40a922771a fixes #489.

Commit https://github.com/brendanzab/gl-rs/commit/f54736bbca87c048093721b95c0d9044941c50a0 should fix #488.

Some of the fixed warnings are only shown in beta and nightly. Fixing them increases the MSRV, but as Travis only tests the stable, beta and nightly channels, I assume that this isn't a problem?

+302 -317

2 comments

31 changed files

Bzomak

pr closed time in a day

PR closed brendanzab/gl-rs

Update webidl requirement from 0.8 to 0.9 dependencies

Updates the requirements on webidl to permit the latest version. <details> <summary>Changelog</summary>

Sourced from webidl's changelog.

0.9.0

  • Update lalrpop to 0.17.0
  • Fix some new clippy warnings by removing useless Boxing

0.8.0

  • Update lalrpop to 0.16.0 to reduce package size.

0.7.0

  • Fixed bug where integer literals outside the range of i64 could not be represented (#15

0.6.0

  • Fixed bug where the generated parser would still be in the source directory (#13)
  • Add back support for parsing implements statement for backwards compatibility with older WebIDLs
  • Add back support for parsing legacycaller in special operations for backwards compatibility with older WebIDLs
  • Update lalrpop to 0.15.1. Version 0.15.0 cannot be used as it breaks with usage of include!
  • Remove unnecessary Parser struct, since it does not do anything. Instead of doing
let parser = Parser::new();
let result = parser.parse_string(...);

You can now simply do

let result = parse_string(...);

0.5.0

  • Reduced package size by excluding mozilla_webidls.zip and upgrading lalrpop to 0.14.0 (#12) </details> <details> <summary>Commits</summary>

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will not automatically merge this PR because this dependency is pre-1.0.0.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in a day

issue closedbrendanzab/gl-rs

Outdated Readmes

Currently readmes state to use versions 0.5 and 0.6. Crate readmes are also missing up-to-date changelog.

closed time in a day

Shadlock0133

pull request commentbrendanzab/gl-rs

Update documentation, dependencies, and fix warnings

Thanks a bunch, this looks great!

Bzomak

comment created time in a day

delete branch brendanzab/codespan

delete branch : simplify-border-components

delete time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha c0974e41f6f1528b9a7a597d3ab9403d5b723c5a

WIP: experiment with line data structures

view details

push time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 5fb7a7327c19678eb68279be212438cd400fbe70

Use Files::line_index where possible

view details

Brendan Zabarauskas

commit sha 229218b24b3f22440729a82c3091bbe771c701d5

Diagnostic API cleanups

view details

Brendan Zabarauskas

commit sha d6c1f250c1f81c7846d61ede2397c62ae955e57e

Create intermediate ‘mark’ data structures

view details

Brendan Zabarauskas

commit sha abd67f28e611c55ed9523d3a60b1a7e31bd9a80b

Add tests for labeless diagnostics

view details

Brendan Zabarauskas

commit sha afa2cde93c12e086810807edc0ebfd1152bb64b9

Add with_message builder method to labels

view details

Brendan Zabarauskas

commit sha 30c0d56cbd7361f0e0918f416914390830307aa7

WIP: experiment with line data structures

view details

push time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 5fb7a7327c19678eb68279be212438cd400fbe70

Use Files::line_index where possible

view details

Brendan Zabarauskas

commit sha 229218b24b3f22440729a82c3091bbe771c701d5

Diagnostic API cleanups

view details

Brendan Zabarauskas

commit sha d6c1f250c1f81c7846d61ede2397c62ae955e57e

Create intermediate ‘mark’ data structures

view details

Brendan Zabarauskas

commit sha abd67f28e611c55ed9523d3a60b1a7e31bd9a80b

Add tests for labeless diagnostics

view details

Brendan Zabarauskas

commit sha afa2cde93c12e086810807edc0ebfd1152bb64b9

Add with_message builder method to labels

view details

push time in a day

startedmatthewhammer/cleansheets

started time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha c90f9626c209e422884f59a88e107f0fcf984112

WIP: experiment with line data structures

view details

push time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 7d9077f3a5e358e855c0b47351486f676b5c1a9e

WIP: experiment with line data structures

view details

push time in a day

delete branch brendanzab/codespan

delete branch : line-rendering-experiements

delete time in a day

create barnchbrendanzab/codespan

branch : line-rendering-experiments

created branch time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha fae2df31a7d1e422868e0bc4956efc6c787792d8

WIP: experiment with line data structures

view details

push time in a day

create barnchbrendanzab/codespan

branch : line-number

created branch time in a day

create barnchbrendanzab/codespan

branch : line-rendering-experiements

created branch time in a day

issue commentbrendanzab/codespan

Allow setting custom line numbers

Wondering if we could have a Files::line_number method:

pub trait Files {
    ⋮
    /// The line number of the line at the given line index.
    fn line_number(&self, id: Self::FileId, line_index: usize) -> Option<usize>;
    ⋮
}
jyn514

comment created time in a day

pull request commentbrendanzab/codespan

Create Files trait

Ahh, sorry, wouldn't have merged if you were that worried! I'm definitely happy if we alter the Files API, or the Line struct before we publish 0.9 in a way that would support it.

brendanzab

comment created time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 02259330a5bb7e3d281b664a12240dcb31bc1b36

Add with_message builder method to labels

view details

push time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 3b6eeeda70835d37b8ccec619d2065c4dbdb8a49

Add tests for labeless diagnostics

view details

push time in a day

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 473b300527131fa90ee71caa2501a0c4906c96cf

Diagnostic API cleanups

view details

Brendan Zabarauskas

commit sha d1a3bf45abdf125d710205a412aaeeb43ab137a1

Create intermediate ‘mark’ data structures

view details

push time in a day

startedTyberiusPrime/nested_intervals

started time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 1a68b22d497a8e3b4996b9c25f86e90929258089

Create Files trait

view details

Brendan Zabarauskas

commit sha 9e0792757d318de5659b76d962e8226f3a6ab229

Merge pull request #164 from brendanzab/files-trait Create Files trait

view details

Brendan Zabarauskas

commit sha 1606a7abb84414d94d54db7566c8ec4ea2e1cdd2

Diagnostic API cleanups

view details

push time in 2 days

delete branch brendanzab/codespan

delete branch : files-trait

delete time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 1a68b22d497a8e3b4996b9c25f86e90929258089

Create Files trait

view details

Brendan Zabarauskas

commit sha 9e0792757d318de5659b76d962e8226f3a6ab229

Merge pull request #164 from brendanzab/files-trait Create Files trait

view details

push time in 2 days

PR merged brendanzab/codespan

Create Files trait

This will allow clients of codespan-reporting to implement their own file databases. This is important if we want to allow users to work with frameworks like Salsa, or have domain-specific concerns with regard to file handling.

Closes #79.

+297 -250

2 comments

13 changed files

brendanzab

pr closed time in 2 days

issue closedbrendanzab/codespan

Custom databases (Salsa support)

It would be nice to be able to define custom Files-style databases depending on the needs of a project.

  • People might want to use something like Salsa to manage their source files.
  • When starting off building a language, a 'SingleFile' database (that only took a single file) might be a better solution than #56.
  • Others might want to use a more compact span representation than the one used currently. For example compressing it, as is done in rustc.

The language-reporting fork defines ReportingSpan and ReportingFiles traits which might be useful for inspiration.

closed time in 2 days

brendanzab

pull request commentbrendanzab/codespan

Create Files trait

So yeah, this doesn't actually fix #157, but I think I'll merge it nonetheless, as it's still helpful!

brendanzab

comment created time in 2 days

issue commentbrendanzab/codespan

Group labels originating from the same file into a single snippet

This seems like it could be a helpful library: https://crates.io/crates/nested_intervals - or at least thinking about this stuff in terms of interval sets... 🤔

brendanzab

comment created time in 2 days

startedtravisbrown/sized

started time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha edae138b51b75fcaaf6b8f295bc980308e20167a

Remove title struct

view details

push time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha ef3475d1567e6f0445172639da57bd28d2694c81

Diagnostic API cleanups

view details

push time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha b7eb601982b4e195500b1f76adb91ac36c1bf1bc

Don’t allocate when measuring line numbers

view details

Brendan Zabarauskas

commit sha f1ff1dc96a9554602edbfea0a91af4f7d6e3546c

Release v0.8.0 Closes #163.

view details

Brendan Zabarauskas

commit sha 4d59841b02db62d1c8432bf24c9915a74680ff9e

Merge pull request #165 from brendanzab/bump-version Release v0.8.0

view details

Brendan Zabarauskas

commit sha 965f53e32bd85a7a52f03f82148b39b0066a539b

Avoid allocating strings when replacing tabs

view details

Brendan Zabarauskas

commit sha 01ec3e44fc6d1629e7ac718b76fd92ce6a96608b

Merge pull request #166 from brendanzab/reduce-reallocations Avoid string allocations when printing source snippets

view details

Brendan Zabarauskas

commit sha 9a01a1ff85d46a86ff3ac0c9134cdb12eb4e3879

Diagnostic API cleanups

view details

push time in 2 days

startedbodil/vgtk

started time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha b7eb601982b4e195500b1f76adb91ac36c1bf1bc

Don’t allocate when measuring line numbers

view details

Brendan Zabarauskas

commit sha f1ff1dc96a9554602edbfea0a91af4f7d6e3546c

Release v0.8.0 Closes #163.

view details

Brendan Zabarauskas

commit sha 4d59841b02db62d1c8432bf24c9915a74680ff9e

Merge pull request #165 from brendanzab/bump-version Release v0.8.0

view details

Brendan Zabarauskas

commit sha 965f53e32bd85a7a52f03f82148b39b0066a539b

Avoid allocating strings when replacing tabs

view details

Brendan Zabarauskas

commit sha 01ec3e44fc6d1629e7ac718b76fd92ce6a96608b

Merge pull request #166 from brendanzab/reduce-reallocations Avoid string allocations when printing source snippets

view details

Brendan Zabarauskas

commit sha 1a68b22d497a8e3b4996b9c25f86e90929258089

Create Files trait

view details

push time in 2 days

delete branch brendanzab/codespan

delete branch : reduce-reallocations

delete time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha b7eb601982b4e195500b1f76adb91ac36c1bf1bc

Don’t allocate when measuring line numbers

view details

Brendan Zabarauskas

commit sha 965f53e32bd85a7a52f03f82148b39b0066a539b

Avoid allocating strings when replacing tabs

view details

Brendan Zabarauskas

commit sha 01ec3e44fc6d1629e7ac718b76fd92ce6a96608b

Merge pull request #166 from brendanzab/reduce-reallocations Avoid string allocations when printing source snippets

view details

push time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 965f53e32bd85a7a52f03f82148b39b0066a539b

Avoid allocating strings when replacing tabs

view details

push time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha 23fae6b65daadc60cffa18506fa285897eea6592

Avoid allocating strings when replacing tabs

view details

push time in 2 days

create barnchbrendanzab/codespan

branch : reduce-reallocations

created branch time in 2 days

issue commentbrendanzab/codespan

Release new version of codespan-lsp

Oooh, tower-lsp looks pretty neat too! ❤️

ebkalderon

comment created time in 2 days

startedebkalderon/tower-lsp

started time in 2 days

issue commentbrendanzab/codespan

Release new version of codespan-lsp

Thanks for the nudge! Should be on crates.io now!

ebkalderon

comment created time in 2 days

delete branch brendanzab/codespan

delete branch : bump-version

delete time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha f1ff1dc96a9554602edbfea0a91af4f7d6e3546c

Release v0.8.0 Closes #163.

view details

Brendan Zabarauskas

commit sha 4d59841b02db62d1c8432bf24c9915a74680ff9e

Merge pull request #165 from brendanzab/bump-version Release v0.8.0

view details

push time in 2 days

PR merged brendanzab/codespan

Release v0.8.0

Closes #163.

+6 -6

0 comment

3 changed files

brendanzab

pr closed time in 2 days

issue closedbrendanzab/codespan

Release new version of codespan-lsp

The lsp-types crate has been recently bumped to 0.70.2, but the latest codespan-lsp 0.7.0 is apparently still stuck on version 0.68. This means that users of codespan-lsp do not have access to the latest features of the specification and LSP library authors mindful of codespan-lsp cannot upgrade their dependency on lsp-types to 0.70.X without breaking downstream code that relies both crates.

Because of this, it would be great if there could be a new release of codespan-lsp 0.8.0 to Crates.io, so the two crate ecosystems do not diverge too far.

CC @brendanzab @Marwes

closed time in 2 days

ebkalderon

issue commentbrendanzab/codespan

Allow setting custom line numbers

@Marwes would this help you out with macro support on Gluon?

jyn514

comment created time in 2 days

PR opened brendanzab/codespan

Release v0.8.0

Closes #163.

+6 -6

0 comment

3 changed files

pr created time in 2 days

create barnchbrendanzab/codespan

branch : bump-version

created branch time in 2 days

pull request commentbrendanzab/codespan

Create Files trait

I'm not sure if this API would support people who wanted custom line-numbers - see #157.

brendanzab

comment created time in 2 days

PR opened brendanzab/codespan

Create Files trait

This will allow clients of codespan-reporting to implement their own file databases. This is important if we want to allow users to work with frameworks like Salsa, or have domain-specific concerns with regard to file handling.

Closes #79.

+298 -250

0 comment

13 changed files

pr created time in 2 days

push eventbrendanzab/codespan

Brendan Zabarauskas

commit sha c06bedc0245d163eac3c7ab651571bcce851c604

Create Files trait

view details

push time in 2 days

create barnchbrendanzab/codespan

branch : files-trait

created branch time in 2 days

delete branch brendanzab/codespan

delete branch : traits

delete time in 2 days

startedtosrevive/ShrineTextMode

started time in 2 days

more