profile
viewpoint
Cody Boyko boykoc Toronto, Canada boykoc.github.io I'm a developer always looking to learn new things.

boykoc/flashcards 2

React native flashcard application for Udacity nanodegree.

boykoc/boykoc.github.io 1

Personal site

boykoc/dribbble-clone-tutorial 1

Result of a Rails tutorial creating a dribbble like site

boykoc/a11yproject.com 0

Making #A11Y tips and tricks easier to digest and leveraging the community into the cloud.

boykoc/azure-docs 0

Open source documentation of Microsoft Azure

boykoc/blog 0

Rails blog tutorial.

boykoc/bowati 0

Canada US boarder wait times using Canada Open Data.

boykoc/CaesarCipher 0

Basic Caesar cipher encoder/decoder.

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 25774110f1806a58c9cd8862a82b9bf927a7d318

Task: Implement scheming groups.

view details

Bianca Sayan

commit sha 55eab21b38d5c480b7410712326fc7d436113b6c

Task: Add get_group helper. In certain areas (like the groups tab for a package), the extras for a group aren't passed into the template. Create a get_group helper to be able to access group extras in those cases.

view details

Bianca Sayan

commit sha 0683a5e03890539f1a7e3ff655c648bcf763cd0b

Task: Add group templates to codebase.

view details

Bianca Sayan

commit sha dd6855112f0385229c7e6bab63bc81a57f33f03b

Task: Update group form elements to fix layout issues. Groups form missing a row div wrapper. As well, upload snippet missing a wrapper.

view details

Bianca Sayan

commit sha 38531e0da484d89f6be3347b210ce4a171f39e82

Task: Add more group templates to codebase.

view details

Bianca Sayan

commit sha b29955582df8cd27718ddefb3fedc9164c3ea8ec

Task: Update group templates to be bilingual.

view details

Cody Boyko

commit sha 622def924b32637a5019b98de055b51748faa7f2

Update get_group doc block.

view details

Cody Boyko

commit sha c2c03f03024ca37af5f2aee02ee8551358031cc8

Merge pull request #160 from bianca/fluent_groups Fluent groups

view details

push time in 9 hours

PR merged ongov/ckanext-ontario_theme

Fluent groups

This PR consists of 6 commits to implement fluent groups, including:

  • groups schema
  • addition of a get_group helper (to account for areas where group extras aren't passed into the template)
  • layout fixes to the group form
  • changes to group templates to handle bilingual values
+202 -4

0 comment

10 changed files

bianca

pr closed time in 9 hours

PullRequestReviewEvent

push eventbianca/ckanext-ontario_theme

Cody Boyko

commit sha 622def924b32637a5019b98de055b51748faa7f2

Update get_group doc block.

view details

push time in 10 hours

PR closed ongov/ckanext-ontario_theme

Groups to fluent collections

This PR consists of 8 commits to make the following changes:

  • Implement groups in scheming
  • Implement fluent/bilingual groups
  • Update templates for fluent groups
  • Add scheming group form formatting
  • Change group type for the site from "group" to "collection"
  • Change templates to use "collection" label for groups
  • Update translations to use "collection" for groups
  • Add routes to assure consistent /collections pattern

Add scheming_groups to ckan.plugins in the ini file when including this PR.

+335 -20

1 comment

20 changed files

bianca

pr closed time in 10 hours

pull request commentongov/ckanext-ontario_theme

Groups to fluent collections

Out of date - replaced by PR #160

bianca

comment created time in 10 hours

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha c8003e521984569a283b6b54550a33947546d27d

Task: Add new fields for organizations. Update organization schema for 2 new fields to help more easily categorize the organization and the datasets assigned to them (e.g. Provincial Ministry dataset). Index and these new fields to enable faceting. These new fields are extras and are not included by default in the package dict passed into `before_index()`. To get this I'm getting the org and accessing the values that way. This is done in other core extensions. Facet the new fields for dataset search page. Easiest way was to break them out of the facet loop to get the proper choices passed in.

view details

Cody Boyko

commit sha baec08ae89a9ae09ae1d98aed633c7b5141419dd

Task: Add new facets to orgs and groups.

view details

Cody Boyko

commit sha 83fcb0da7d9a52b2e6aee4bbf920055baa035dc6

Task: Add org fields to dataset search results. Add new organization fields to the search result lists for datasets, orgs and groups. The format of the new fields are "Organization (Jurisdiction Category)". Update styles to bring the new fields up under the dataset title. While in styles I changed the dataset link colour to blue to match other link styles.

view details

Cody Boyko

commit sha b7d061b17ea1499d53275da5d1611bb76e778053

Merge pull request #162 from ongov/agency-datasets Task: Allow identifying agencies and their datasets.

view details

push time in 10 hours

PR merged ongov/ckanext-ontario_theme

Task: Allow identifying agencies and their datasets.

Add new fields to Organization to help identify it more easily and it's assigned datasets.

Organization Jurisdiction will help in future federation efforts and category will help distinguish the types/level of organization within the jurisdiction.

A jurisdiction and category should be combined to create a single organization (e.g. Canada (Federal Ministry) or an ontario agency could be Agency Name (Provincial Agency). All datasets for these organizations can be assigned to them. These fields are displayed on the UI to help users quickly identify where the data comes from. These fields are also indexed to help faceting against them.

+341 -145

0 comment

12 changed files

boykoc

pr closed time in 10 hours

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha e5cb64f79371a3cb6e243582939a5c6bb2c77caa

Bug: Organization selection still using display_name. Displaying organization name needs to use get_translated on the title because organizations is fluenty now.

view details

Bianca Sayan

commit sha a09917573e59f11cfd1849109f2f1b75568daa20

Bug: Organization facet still using display_name. Change organization facet to use get_translated on title.

view details

Cody Boyko

commit sha 0f866d88599e3c5ad7e64cf038228212ab22abbc

Merge pull request #161 from bianca/fix_organization_display_name Fix organization display name

view details

push time in 10 hours

PR merged ongov/ckanext-ontario_theme

Fix organization display name

This PR consists of 2 commits to fix cases where display_name is still being used to display an organization's name (instead of get_translated).

+2 -1

0 comment

2 changed files

bianca

pr closed time in 10 hours

PullRequestReviewEvent

PR opened ongov/ckanext-ontario_theme

Task: Allow identifying agencies and their datasets.

Add new fields to Organization to help identify it more easily and it's assigned datasets.

Organization Jurisdiction will help in future federation efforts and category will help distinguish the types/level of organization within the jurisdiction.

A jurisdiction and category should be combined to create a single organization (e.g. Canada (Federal Ministry) or an ontario agency could be Agency Name (Provincial Agency). All datasets for these organizations can be assigned to them. These fields are displayed on the UI to help users quickly identify where the data comes from. These fields are also indexed to help faceting against them.

+341 -145

0 comment

12 changed files

pr created time in a day

create barnchongov/ckanext-ontario_theme

branch : agency-datasets

created branch time in a day

push eventboykoc/boykoc.github.io

Cody Boyko

commit sha 4dfed0c87b4672ab9830649de01f00e25f815c9a

Update 2019-10-21-ckan-283-database-diagram.markdown

view details

push time in 7 days

pull request commentckan/ckanext-fluent

Task: Add basic test setup.

Please see updated README in PR for running instructions.

boykoc

comment created time in 11 days

push eventboykoc/ckanext-fluent

Boyko

commit sha 36e4d50508cbec73521cda87360dfbbbbb1cabea

Task: Add first real test and test schema. Add first real test for the fluent_core_translated_output() validator that sets the title_translated field and ensures the default english value is returned for the title field. Add a test schema based on the scheming ckan_dataset.json schema. It is exepcted that this schema will be modified/updated over time based on new tests. Update test.ini to cleanup schemas and use new test dataset schema.

view details

push time in 11 days

push eventboykoc/ckanext-fluent

Boyko

commit sha cb69ffc006a8399a3f5a0712d66118fa8ba87b33

Improvement: Cleanup command formating.

view details

push time in 16 days

push eventboykoc/ckanext-fluent

Boyko

commit sha 6f2452852e7bba93c920952cefe0469f9d4900cf

Improvement: Fix broken link format in readme.

view details

push time in 16 days

push eventboykoc/ckanext-fluent

Boyko

commit sha 258748295d3cc6f14f212819eb6db58e1c0da5ac

Improvement: Switch to pytest and pytest-ckan. To follow along with ckanext-scheming, move tests to use pytest. Using pytest-ckan, this allows us to write newer pytests and have work in CKAN 2.8 and 2.9. Tests are not expected to work for older versions of CKAN installations. At the time of making this commit this test setup was run against CKAN 2.8 and CKAN 2.9 both running python 2.7. They have not yet been tested against python 3. [x] Update readme with pytest run instructions [x] Update test.ini with with schemas and extra settings to get the tests running (kept getting errors on missing various sections) [x] Remove legacy nosetest in test_fluent.py [x] Add test requirements to install pytest and pytest-ckan

view details

push time in 16 days

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 75d841c44f6212dc00668b4dc42ed9f02846e792

WIP: Overwrite tag_name_validator to allow apostrophes. French tags with apostrophes won't be accepted by current validators. A validator that accepts these french tags is needed.

view details

Bianca Sayan

commit sha ab5fdde962d9f2a2103777be72b514b376294e3a

Task: Create separate validators file. Create separate validators file, as future features will include more validators.

view details

Bianca Sayan

commit sha b6bc54c75f8c7dad5bf8e17d73b3af977822f9b8

Task: Add specific tag validator messages and strip. Add specific tag validator messages for commas and consecutive spaces. Also, strip the value.

view details

Bianca Sayan

commit sha 31c6ce02a04344644e88084a167524edc75968c9

Task: Move general validator imports outside of function. Move general imports outside of specific function.

view details

Bianca Sayan

commit sha 6720ceb8611233ae89caf8f7f31515039afe5425

Bug: Missing import of Invalid. Missing import of Invalid.

view details

Bianca Sayan

commit sha a72196aefe2e1b8f6ef0a8652f45f03c09bb3a35

Bug: Fix apostrophe modification. No need to escape the first apostrophe in the regular expression. As well, that apostrophe throws an error when printed in the console, so it should be removed from the invalid message.

view details

Bianca Sayan

commit sha bfdaa55e1d9feb1969535a13b6b65f3f09bf7cf6

Task: Add separator replacement to tag validator. Some keywords submitted have had separators that throw an error in the tag validator. These separators aren't desirable. Add a component to the validator that replaces undesirable separators with a space.

view details

Bianca Sayan

commit sha d60d45863e5d10eecd3bc7d1ec8a68da5e1d2ebb

Merge branch 'master' of github.com:ongov/ckanext-ontario_theme into add_tag_validator_with_apostrophes

view details

Bianca Sayan

commit sha ce128be31ce1881fde70caf6c0097ea036dd1323

Bug: Include validator in existing get_validators config. Recent merge created two get_validators functions in plugin.py. Merge these two.

view details

Bianca Sayan

commit sha 6195f97b1892607093737ed8a328a87333e226df

Task: Remove unnecessary imports. These imports are only needed in validators.py

view details

Bianca Sayan

commit sha 748cc67bfa16132cab2172439d1c195ff238894c

Task: Cleanup and addition of comments.

view details

Bianca Sayan

commit sha f6468b0a51e124bb691c14d1dc877b276cf96943

Task: Cleanup and addition of comments.

view details

Bianca Sayan

commit sha bcff28857a5f93d48da6428504171860682801db

Merge branch 'add_tag_validator_with_apostrophes' of github.com:bianca/ckanext-ontario_theme into add_tag_validator_with_apostrophes

view details

Bianca Sayan

commit sha cc5c8d949079cea5c134b353ea8715aff2578a9d

Task: Pass value as is to raise an invalid error. Invalid errors borrowed from Government of Canada ckan passes value as a tuple, but it looks to be in error.

view details

Bianca Sayan

commit sha 57b9ab3e083be18327c94e2eeb751f935e7a828d

Task: Fix validator message encoding. Validator message encoding was partially ascii. Fixed to unicode to be able to include apostrophe.

view details

Cody Boyko

commit sha a5939ed2e0aa4008351bcc57f9be85e49495a751

Merge pull request #156 from bianca/add_tag_validator_with_apostrophes Add tag validator with apostrophes

view details

push time in 16 days

PR merged ongov/ckanext-ontario_theme

Add tag validator with apostrophes

This PR consists of 8 commits to create an ontario_theme-specific tag validator.

The changes that deviate from ckan core are:

  • stripping tags
  • allowing for two types of apostrophes for tags ('`) (necessary for french tags)
  • throwing an error for double spaces
  • throwing an error for commas
  • replacing non-space separators with spaces
+42 -1

0 comment

4 changed files

bianca

pr closed time in 16 days

PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha f3c0316d93a9f4c18d77e2882fe2b7ac4c948f13

Task: Add Apache License 2.0 to licences.

view details

Cody Boyko

commit sha bcd4fd6e81934884c021125cae80073df365fa74

Merge pull request #159 from bianca/add_apache_licence Task: Add Apache License 2.0 to licences.

view details

push time in 16 days

PR merged ongov/ckanext-ontario_theme

Task: Add Apache License 2.0 to licences.

This PR consists of one commit to make one change: add Apache LIcense 2.0 to the list of licences.

+27 -0

0 comment

1 changed file

bianca

pr closed time in 16 days

PullRequestReviewEvent

pull request commentckan/ckanext-fluent

Task: Add basic test setup.

I'm thinking we can try unit tests as able or test indirectly with actions and good assertions.

boykoc

comment created time in 21 days

PR opened ckan/ckanext-fluent

Task: Add basic test setup.

As per issue #21, tests are needed. This hopefully lays the ground work to backfill tests for existing functionality and give contributors a place to add tests for new features and changes.

+64 -0

0 comment

5 changed files

pr created time in 21 days

create barnchboykoc/ckanext-fluent

branch : setup-tests

created branch time in 21 days

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 8af23218d5e3259ec5ed3a1a8ef9ce2b5c776bb2

Task: Add same-schema type. Add ability to assign a record type and the options for either algorithm or dataset.

view details

Bianca Sayan

commit sha f98ac87da8e705497007929226d52ea2a5209a33

Task: Add read.html to codebase.

view details

Bianca Sayan

commit sha ef863072d3d69e6ceb7e403b2e27e228e7291a59

Task: Add alogirthms identifier to UI. Add UI element that identifies algorithm record.

view details

Bianca Sayan

commit sha 04450bfcc2c0085b9aa174e1779418065c0f433d

Task: Add algorithm identifier to dataset list. Add algorithm identifier to dataset list.

view details

Bianca Sayan

commit sha c27eb19e21632d5aa3eca069636bf47f9846ee41

Task: Add link for AI group about page.

view details

Bianca Sayan

commit sha c980898b0c6fa3b8c4a9ff1c025411ebc679aeb9

Merge branch 'master' of github.com:ongov/ckanext-ontario_theme into ai_assets

view details

Bianca Sayan

commit sha a4ed896afdc95b31417aa9725d7d677af7899469

Task: Add french translation for AI messages.

view details

Bianca Sayan

commit sha 0648f0710644055ae762cfd75cfeb58e90fd6ec8

Bug: label style missing from internal css.

view details

Bianca Sayan

commit sha 1ef93bec7825e7de4e90860a10c56453954d1a76

Bug: Missing french link.

view details

Bianca Sayan

commit sha afa8cdfdf3ce75638887069091f500b091881313

Task: Change collections path to groups in content.

view details

Bianca Sayan

commit sha 34bc256d410b24517907fb486ec1b099f2f94a08

Task: Move asset type field down in form.

view details

Bianca Sayan

commit sha d06bf54f41a7224a5fb3d5fe1e80837d8d564c48

Task: Exempt asset type from displaying in package additional info table.

view details

Bianca Sayan

commit sha 4cc4befb16b05aab49e21223044aa3010d3f064f

Task: Reorder asset_type validators. Reorder asset type validators so that the default value is set before other validators are run.

view details

Cody Boyko

commit sha 7e0dc727f3a49d4a8951363eefe5fc7ed4a2ca9b

Merge pull request #157 from bianca/ai_assets Ai assets

view details

push time in 23 days

PR merged ongov/ckanext-ontario_theme

Ai assets

This PR consists of 9 commits to introduce AI assets to the catalogue, which consists of:

  • a new package field to differentiate between types of assets
  • a label in the datasets search page for AI assets
  • a banner on dataset pages noting that the record is an AI asset

Note: The link to the AI assets group assumes that the collections pull request has already been merged into the codebase.

+164 -2

1 comment

10 changed files

bianca

pr closed time in 23 days

pull request commentongov/ckanext-ontario_theme

Ai assets

Changes previously discussed included, tests pass. LGTM.

bianca

comment created time in 23 days

PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha aa84c8aeb460fe31a791bcff19c95c88f22023a0

Improvement: Add tracking setup instructions to readme.

view details

Cody Boyko

commit sha 7194490426958658a334a47c18985965b545bf67

Merge pull request #158 from ongov/tracking-readme-update Improvement: Add tracking setup instructions to readme.

view details

push time in a month

create barnchongov/ckanext-ontario_theme

branch : tracking-readme-update

created branch time in a month

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha f97e7d7f68057b5575446d9e9b5d3bb169ac4528

Improvement: Allow autocompletion of keywords in web form. Copy keywords to the tags field when saving a dataset. Update schema's with new validator to do the above. Remove old tags templates and facet.

view details

Cody Boyko

commit sha d3091e4a8284f2652e2f008f318e9709ecfced74

Task: Add test coverage. Test to ensure keywords are copied to tags and can be retrieved as desired with tag_autocomplete. Fix search index issue for test_helpers, search index wasn't cleared before running the tests and the new validator test added new keywords that pollutated the helper test.

view details

Cody Boyko

commit sha 42e2fe0c74a8e3471f339bac75ee71a74dd04e29

Merge pull request #154 from ongov/tags-autocomplete Improvement: Allow autocompletion of keywords in web form.

view details

push time in a month

PR merged ongov/ckanext-ontario_theme

Improvement: Allow autocompletion of keywords in web form. enhancement

After moving to Fluent's keywords instead of tags, which allowed for multilingual tag support, the tags autocomplete functionality no longer worked.

This is because the default endpoint for tags autocomplete lookup goes to tags, which was not being used/populated and there isn't another suitable endpoint to use.

This PR addresses this by copying keywords to the tags field when saving a dataset.

Other approaches considered became too cumbersome or resulted in too much overhead/customization for desired outcome.

+144 -12

0 comment

8 changed files

boykoc

pr closed time in a month

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha d3091e4a8284f2652e2f008f318e9709ecfced74

Task: Add test coverage. Test to ensure keywords are copied to tags and can be retrieved as desired with tag_autocomplete. Fix search index issue for test_helpers, search index wasn't cleared before running the tests and the new validator test added new keywords that pollutated the helper test.

view details

push time in a month

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 83f0c7a69faf545a2227d66853f490d89482ef2a

Task: Update colors for accessible contrast. Site colours updated to assure accessible contrast.

view details

Bianca Sayan

commit sha 7b6ecb06aaa6e35a48ee27e0afceb2ede941321b

Improvement: Use bs sr-only class instead of redundant class accessibly-hidden. Bootstrap already has an equivalent of accessibly-hidden. Add styles to sr-only to assure it doesn't throw a contrast error.

view details

Bianca Sayan

commit sha b3631229bce670f07131e17c520ecd9198eaf402

Task: Add search_input_button block to codebase.

view details

Bianca Sayan

commit sha 6478af945b70491948d0f88567c4ca650ba59f1b

Task: Use sr-only and aria-label more consistently. Since sr-only is available, use sr-only (for where aria-label is unsupported) and aria-label.

view details

Bianca Sayan

commit sha 3c57142296d7d83e244368079ea8d2251f6877b9

Task: Homepage accessibility updates. Changes to assure accessibility: colour contrast and correct heading order.

view details

Cody Boyko

commit sha f17e434a1f2e7f2def91c3acb2d63199372f65ef

Merge pull request #150 from bianca/accessibility_repair Accessibility repair

view details

push time in a month

PR merged ongov/ckanext-ontario_theme

Accessibility repair

This PR consists of 5 commits to make the following changes:

  • update colours to accessible colours from the ontario.ca design system
  • shift to use of bootstrap's sr-only class for screen-reader-only text
  • addition of aria-label and aria-hidden to some buttons that use icons
  • update homepage with correct header order and consistent colour contrasting

To do in a future PR:

  • headings order needs to be reviewed on other pages
  • potentially review all icon buttons in order to add accessible labels
+354 -245

0 comment

19 changed files

bianca

pr closed time in a month

Pull request review commentongov/ckanext-ontario_theme

Accessibility repair

 {% ckan_extends %} +{% block search_input_button %}+<span class="input-group-btn">+  <button class="btn btn-default btn-lg" type="submit" value="search" aria-label="{{ _('Search') }}">

Similar to search.html and menu in header.html

bianca

comment created time in a month

Pull request review commentongov/ckanext-ontario_theme

Accessibility repair

   <form class="module-content search-form" method="get" action="{% url_for controller='package', action='search' %}">     <div class="search-input form-group search-giant">       <input aria-label="{% block header_site_search_label %}{{ _('Search datasets') }}{% endblock %}" id="field-main-search" type="text" class="form-control" name="q" value="" autocomplete="off" placeholder="{% block search_placeholder %}{{ placeholder }}{% endblock %}" />-      <button type="submit">-        <i class="fa fa-search"></i>+      <button type="submit" aria-label="{{ _('Search') }}">

This is a bit duplicative but manual testing with assistive technology would help see a bit more. adding the aria-label while using an inner element as the descriptive text may cause "search" to be read / identified twice.

bianca

comment created time in a month

Pull request review commentongov/ckanext-ontario_theme

Accessibility repair

           <div class="field">             <label for="field-sitewide-search">{% block header_site_search_label %}{{ _('Search Datasets') }}{% endblock %}</label>             <input id="field-sitewide-search" type="text" class="form-control" name="q" placeholder="{{ _('Search') }}" />-            <button class="btn-search" type="submit"><i class="fa fa-search"></i><span>Submit Search</span></button>+            <button class="btn-search" type="submit" aria-label="{{ _('Submit Search') }}"><i class="fa fa-search" aria-hidden="true"></i><span class="sr-only">{{ _('Submit Search') }}</span></button>

Caution on this. aria-hidden true removes this element and child elements for assistive technology. Adding a child element with sr-only implies it's intended for screen readers.

bianca

comment created time in a month

Pull request review commentongov/ckanext-ontario_theme

Accessibility repair

   left: 0px;   position: relative; }-.accessibly-hidden,+.sr-only,

Is this needed to be added here?

bianca

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 0f6402a608f5f495321f052735afcc262b006ad4

Add new geographic breakdown options to a package. Add missing geographic breakdowns: Province, Wildlife Management Unit, Forest Management Unit, County, District, and Forward Sortation Area.

view details

Cody Boyko

commit sha 0a29681fdd7baa63a78013ac1fc871bfb1d305a8

Merge pull request #151 from bianca/add_geographic_breakdowns Task: Add new geographic breakdown options to a package.

view details

push time in a month

PR merged ongov/ckanext-ontario_theme

Add new geographic breakdown options to a package.

This PR consists of 1 commit to make 1 change: Add missing geographic breakdowns: Province, Wildlife Management Unit, Forest Management Unit, County, District, and Forward Sortation Area. These are all geographic breakdowns of existing datasets in the catalogue.

+84 -0

0 comment

2 changed files

bianca

pr closed time in a month

Pull request review commentongov/ckanext-ontario_theme

Add new geographic breakdown options to a package.

             "en": "Municipality",             "fr": "Municipalité"           }+        },+        {+          "value": "province",+          "label": {+            "en": "Province",+            "fr": "Province"+          }+        },+        {+          "value": "wmu",+          "label": {+            "en": "Wildlife Management Unit",+            "fr": "Unités de gestion de la faune"+          }+        },+        {+          "value": "fmu",+          "label": {+            "en": "Forest Management Unit",+            "fr": "Unités de gestion forestière"+          }+        },+        {+          "value": "county",+          "label": {+            "en": "County",+            "fr": "Comté"+          }+        },+        {+          "value": "district",+          "label": {+            "en": "District",+            "fr": "District"+          }+        },+        {+          "value": "fsa",+          "label": {+            "en": "Forward Sortation Area",+            "fr": "régions de tri d’acheminement"

Ideally would be title case like the rest of them.

bianca

comment created time in a month

PullRequestReviewEvent

Pull request review commentongov/ckanext-ontario_theme

Add new geographic breakdown options to a package.

             "en": "Municipality",             "fr": "Municipalité"           }+        },+        {+          "value": "province",+          "label": {+            "en": "Province",+            "fr": "Province"+          }+        },+        {+          "value": "wmu",+          "label": {+            "en": "Wildlife Management Unit",+            "fr": "Unités de gestion de la faune"+          }+        },+        {+          "value": "fmu",+          "label": {+            "en": "Forest Management Unit",+            "fr": "Unités de gestion forestière"+          }+        },+        {+          "value": "county",+          "label": {+            "en": "County",+            "fr": "Comté"+          }+        },+        {+          "value": "district",+          "label": {+            "en": "District",+            "fr": "District"+          }+        },+        {+          "value": "fsa",

Keep in mind, it will be this value, not the label, that is displayed in the API. e.g. geographic_granularity: "fsa",. I'd suggest in future going for clarity/self documenting values vs. short.

bianca

comment created time in a month

PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha e92573355d357317b1949b25bbdd6435d28ff211

Task: Add Crown Land Use Policy Atlas Terms of Use. Add Crown Land use Policy Atlas Terms of Use to list of licences.

view details

Cody Boyko

commit sha 13d413ba25140e93404c4b283127f5ac703459c3

Merge pull request #145 from bianca/add_crown_use_policy_atlas_licence Task: Add Crown Land Use Policy Atlas Terms of Use.

view details

push time in a month

PR merged ongov/ckanext-ontario_theme

Task: Add Crown Land Use Policy Atlas Terms of Use.

Add Crown Land use Policy Atlas Terms of Use to list of licences.

+27 -0

0 comment

1 changed file

bianca

pr closed time in a month

PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha c03466a53564ee2b501f477c03a3dc160dfcc72a

Task: Add french GA Tag. Add french tag for ministries and datasets to enable a french version of the GA dashboard.

view details

Bianca Sayan

commit sha 25fbee19949a8e401a0075a0c2b09892e7b41bde

Improvement: get_translated_lang should use get_translated. Using get_translated in get_translated_lang removes duplicated code.

view details

Bianca Sayan

commit sha b369112d7b882c7f404d28bbdc080c80ec5e4199

Task: Remove un-needed i18n lib. Now that get_translated_lang is using get_translated, i18n references aren't needed.

view details

Cody Boyko

commit sha 765806aa0965d295ffd7bf7ca7f1b2982037f0da

Merge pull request #143 from bianca/add_french_ga_tags Improvement: Add french ga tags

view details

push time in a month

PR merged ongov/ckanext-ontario_theme

Add french ga tags

This PR consists of 2 commits to:

  • add a get_translated function that takes a specified language
  • use that function to create ministry-name-fr and dataset-name-fr attributes for GA use on organization and dataset pages
+12 -3

0 comment

3 changed files

bianca

pr closed time in a month

PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 19c42cac437697bbec52bc26f034a2cb5f2c3dd8

Task: Add classes for GA use. Add classes to popular, recent, and category links on the homepage to track use on GA.

view details

Cody Boyko

commit sha f5ab63b01a5c999ac074641bd8f8bcd8dddc336a

Merge pull request #153 from bianca/homepage_ga_hooks Improvement: Add classes for GA use to track homepage traffic

view details

push time in a month

PR merged ongov/ckanext-ontario_theme

Add classes for GA use to track homepage traffic

This PR consists of 1 commit to add 3 classes to links in the homepage to track the use of those categories of links.

+3 -3

0 comment

3 changed files

bianca

pr closed time in a month

PullRequestReviewEvent

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha 82e65e777353f5ab8b4df632abc8e3f73998d967

Task: Add test coverage. Test to ensure keywords are copied to tags and can be retrieved as desired with tag_autocomplete. Fix search index issue for test_helpers.

view details

push time in a month

PR opened ongov/ckanext-ontario_theme

Improvement: Allow autocompletion of keywords in web form.

After moving to Fluent's keywords instead of tags, which allowed for multilingual tag support, the tags autocomplete functionality no longer worked.

This is because the default endpoint for tags autocomplete lookup goes to tags, which was not being used/populated and there isn't another suitable endpoint to use.

This PR addresses this by copying keywords to the tags field when saving a dataset.

Other approaches considered became too cumbersome or resulted in too much overhead/customization for desired outcome.

+50 -12

0 comment

6 changed files

pr created time in 2 months

create barnchongov/ckanext-ontario_theme

branch : tags-autocomplete

created branch time in 2 months

Pull request review commentckan/ckan

Improvement: Add text to mobile nav button.

   {% endif %} {% endblock %}   <div class="container">     <div class="navbar-right">-      <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse">+      <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse" aria-expanded="false">+        <span class="sr-only">Toggle navigation</span>

Done.

boykoc

comment created time in 2 months

PullRequestReviewEvent

push eventboykoc/ckan

Cody Boyko

commit sha 3c3c7ff6e9feb98197531650e21ed7c4a115cf64

Add translation.

view details

push time in 2 months

pull request commentckan/ckan

Improvement: Add text to mobile nav button.

Good call, will do when I get back.

On Tue., Aug. 25, 2020, 9:10 a.m. Adrià Mercader notifications@github.com wrote:

@amercader commented on this pull request.

In ckan/templates/header.html https://github.com/ckan/ckan/pull/5555#discussion_r476435610:

@@ -66,7 +66,8 @@ {% endif %} {% endblock %} <div class="container"> <div class="navbar-right">

  •  <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse">
    
  •  <button data-target="#main-navigation-toggle" data-toggle="collapse" class="navbar-toggle collapsed" type="button" aria-label="expand or collapse" aria-expanded="false">
    
  •    <span class="sr-only">Toggle navigation</span>
    

This should be translated

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ckan/ckan/pull/5555#pullrequestreview-474464154, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGMI3KIM2UXMKNBGAOQIPLSCOZ4TANCNFSM4QHSP4MQ .

boykoc

comment created time in 2 months

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha 2d97e138b901953e4c08a3b3b8db879383cef5f6

Task: Cleanup tests. Schema's have changed alot since some of these tests were written and they weren't updated with the schemas. At start, Ran 12 tests, FAILED (errors=14). Errors: AttributeError: 'OntarioThemePlugin' object has no attribute 'create_package_schema' SchemingException: preset 'fluent_core_translated' not defined IOError: [Errno 2] No such file or directory: '/home/cody/ckan/lib/default/src/ckan/ckanext/ckanext-ontario_theme/ckanext/ontario_theme/tests/../licences.json' Exception: Cannot unload plugin `ontario_theme` Remove IDataSetForm from plugin as this is no longer used (or could have set to inherit=True or create empty method). Add config settings to test.ini to fix the SchemingException. Change licences.json path to new path. Update package dict for test_create_dataset.py. Remove obsolete tests for test_create_dataset.py. Update package dict for test_helpers.py. Update package dict for test_resource_upload.py. Update package dict for test_updated_dataset.py. Remove obsolete tests for test_update_dataset.py. At end, Ran 18 tests, OK

view details

Cody Boyko

commit sha 0c882e0eeec1208cca6e61ccb54ee92fd23ed823

Merge pull request #146 from ongov/fix-tests Task: Cleanup tests.

view details

push time in 2 months

PR merged ongov/ckanext-ontario_theme

Task: Cleanup tests.

TL;DR: Tests were failing. Schema's had changed alot since some of these tests were written and they weren't updated with the schemas.

At start, Ran 12 tests, FAILED (errors=14).

Errors:

  • AttributeError: 'OntarioThemePlugin' object has no attribute 'create_package_schema'
  • SchemingException: preset 'fluent_core_translated' not defined
  • IOError: [Errno 2] No such file or directory: '/home/cody/ckan/lib/default/src/ckan/ckanext/ckanext-ontario_theme/ckanext/ontario_theme/tests/../licences.json'
  • Exception: Cannot unload plugin ontario_theme

Changes:

Remove IDataSetForm from plugin as this is no longer used (or could have set to inherit=True or create empty method). Add config settings to test.ini to fix the SchemingException, load things in differently than before and update README. Change licences.json path to new path.

Update package dict for test_create_dataset.py. Remove obsolete tests for test_create_dataset.py.

Update package dict for test_helpers.py.

Update package dict for test_resource_upload.py.

Update package dict for test_updated_dataset.py. Remove obsolete tests for test_update_dataset.py.

At end, Ran 18 tests, OK

+308 -225

0 comment

7 changed files

boykoc

pr closed time in 2 months

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha cc56042359099a9373be3d0da987262359518136

Improvement: Remove link placeholder text. Remove link placeholder text for update_frequency help text. Currently there's nothing in the guidebook to link to.

view details

Cody Boyko

commit sha 5bd8ffa47295be9cf8124d4fc6e99eb9376c1ebb

Merge pull request #144 from ongov/schema-update-frequecy Improvement: Remove link placeholder text.

view details

push time in 2 months

PR merged ongov/ckanext-ontario_theme

Improvement: Remove link placeholder text.

Remove link placeholder text for update_frequency help text. Currently there's nothing in the guidebook to link to.

+2 -2

0 comment

2 changed files

boykoc

pr closed time in 2 months

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha 0c78898b7a1b34d9671e776c009e6d985f7931d8

Improvement: Add content id for skip nav link on home page.

view details

Cody Boyko

commit sha e29fc8875a6130eedfe3b4e9025ba144ae45a4c6

Improvement: Remove old h1. This was used as the h1 for all pages originally however, it doens't make as much sense anymore and most pages have and can have a proper h1 and other headings can start following a proper hierarchy.

view details

Cody Boyko

commit sha 9eb8458647bb3ab02e48952f9a75e46730a581a7

Improvement: Add original h1 back.

view details

Cody Boyko

commit sha a0386c08c6c97995077d910069a42cd6d4c0e36c

Improvement: Turn weclome h1 to h2 to follow better structure. h1 is accessibly hidden. The symmantic structure follows h1 (only 1), h2s, h3s, h4s. The visual structure is also appropriate has it has higher level elements visually larger/more distinguished than lower level elements.

view details

Cody Boyko

commit sha 22195e536302f6ff71b824d4869c22ac0c1f32c4

Improvement: Add screenreader text to nav button. Follow bootstrap 3 docs https://getbootstrap.com/docs/3.3/components/#navbar. To do this I had to add the entire template but added to CKAN core to hopefully get it in the future.

view details

Cody Boyko

commit sha b911186a2f7bbaa1840d45a356dd042248724b10

Improvement: Fix color contrast issues on home page. Bit of a hot-fix for a few color contrast issues with the new home page, including: - sky-blue background and white text (darkened the background) - yellow with white text (made text black) - yellow button with white text (made text black) - yellow lables with white text (made text black)

view details

Cody Boyko

commit sha 0bcc393e0c9d56526bf9b05130f5212dd5f09927

Improvement: Add more descriptive alt text. Use title/heading for feature content blocks to help provide more detailed alt text.

view details

Cody Boyko

commit sha cec6bb58bde543694e89abb7bcc4f636a1303648

Improvement: Fix alignment for survey banner.

view details

Cody Boyko

commit sha c027a8faec880fa0013b09745f288754e2a7f6de

Merge pull request #148 from ongov/a11y-updates Improvement: A11y updates

view details

push time in 2 months

PR merged ongov/ckanext-ontario_theme

Improvement: A11y updates

Applying various accessibility updates to help improve the accessibility of the website for users. Main focus at this point is the new home page. Future updates are planned.

  • [x] Skip to content link
  • [x] Heading order/hierarchy
  • [x] Colour contrast
  • [x] Add alt text to feature images
  • [x] Screen Reader text to nav button
+283 -239

0 comment

14 changed files

boykoc

pr closed time in 2 months

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha 22195e536302f6ff71b824d4869c22ac0c1f32c4

Improvement: Add screenreader text to nav button. Follow bootstrap 3 docs https://getbootstrap.com/docs/3.3/components/#navbar. To do this I had to add the entire template but added to CKAN core to hopefully get it in the future.

view details

Cody Boyko

commit sha b911186a2f7bbaa1840d45a356dd042248724b10

Improvement: Fix color contrast issues on home page. Bit of a hot-fix for a few color contrast issues with the new home page, including: - sky-blue background and white text (darkened the background) - yellow with white text (made text black) - yellow button with white text (made text black) - yellow lables with white text (made text black)

view details

Cody Boyko

commit sha 0bcc393e0c9d56526bf9b05130f5212dd5f09927

Improvement: Add more descriptive alt text. Use title/heading for feature content blocks to help provide more detailed alt text.

view details

Cody Boyko

commit sha cec6bb58bde543694e89abb7bcc4f636a1303648

Improvement: Fix alignment for survey banner.

view details

push time in 2 months

PR opened ckan/ckan

Improvement: Add text to mobile nav button.

Add aria attribute and accessible screen reader text to the mobile nav button as per BootStrap 3 docs. https://getbootstrap.com/docs/3.3/components/#navbar

Fixes #

Proposed fixes:

Make mobile nav button more accessible. Backport to 2.8 would be nice.

Features:

  • [ ] includes tests covering changes
  • [ ] includes updated documentation
  • [ ] includes user-visible changes
  • [ ] includes API changes
  • [x] includes bugfix for possible backport

Please [X] all the boxes above that apply

+2 -1

0 comment

1 changed file

pr created time in 2 months

push eventboykoc/ckan

Cody Boyko

commit sha 7d2a1e3b71c4957dfce9073f795be73d0305c613

Improvement: Add text to mobile nav button. Add aria attribute and accessible screen reader text to the mobile nav button as per BootStrap 3 docs. https://getbootstrap.com/docs/3.3/components/#navbar

view details

push time in 2 months

push eventongov/ckanext-ontario_theme

Cody Boyko

commit sha a0386c08c6c97995077d910069a42cd6d4c0e36c

Improvement: Turn weclome h1 to h2 to follow better structure. h1 is accessibly hidden. The symmantic structure follows h1 (only 1), h2s, h3s, h4s. The visual structure is also appropriate has it has higher level elements visually larger/more distinguished than lower level elements.

view details

push time in 2 months

PR opened ongov/ckanext-ontario_theme

Improvement: A11y updates

Applying various accessibility updates to help improve the accessibility of the website for users. Main focus at this point is the new home page. Future updates are planned.

+27 -15

0 comment

7 changed files

pr created time in 2 months

create barnchongov/ckanext-ontario_theme

branch : a11y-updates

created branch time in 2 months

Pull request review commentckan/ckan

Accessibility enhancement

  {% block content %}   <div class="homepage layout-{{ homepage_style }}">-    <div class="container">+    <div id="content" class="container">

@Zharktas including you for your input and not sure if you'd get notified on a close PR?

bblwq

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentckan/ckan

Accessibility enhancement

  {% block content %}   <div class="homepage layout-{{ homepage_style }}">-    <div class="container">+    <div id="content" class="container">

This is good for the home page. It seems for most other pages this is already set in page.html.

One thing that seems to be missing is making the skip link keyboard accessible. Right now it seems that you can't navigate to it and click on it. It looks like the current way it's being hidden is an old way of just using display:none;..

Would be good to switch this to Bootstraps built in handling of this as outline here..

As is, it'll pass an automated test but not a manual one.

bblwq

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentckan/ckan

Accessibility enhancement

  {% block content %}   <div class="homepage layout-{{ homepage_style }}">-    <div class="container">+    <div id="content" class="container">

Any reason why this was added here when there is already an id="content" in the page.html? https://github.com/ckan/ckan/blob/0e3f501e9fe36289cee4fc59647db80feb0e2f97/ckan/templates/page.html#L21

But this div doesn't seem to get rendered (at least not in 2.8). If it's supposed to be here, maybe we should remove that other id. But would be nice to know why it wasn't working to start with.

bblwq

comment created time in 2 months

PullRequestReviewEvent

PR opened ongov/ckanext-ontario_theme

Task: Cleanup tests.

TL;DR: Tests were failing. Schema's had changed alot since some of these tests were written and they weren't updated with the schemas.

At start, Ran 12 tests, FAILED (errors=14).

Errors:

  • AttributeError: 'OntarioThemePlugin' object has no attribute 'create_package_schema'
  • SchemingException: preset 'fluent_core_translated' not defined
  • IOError: [Errno 2] No such file or directory: '/home/cody/ckan/lib/default/src/ckan/ckanext/ckanext-ontario_theme/ckanext/ontario_theme/tests/../licences.json'
  • Exception: Cannot unload plugin ontario_theme

Changes:

Remove IDataSetForm from plugin as this is no longer used (or could have set to inherit=True or create empty method). Add config settings to test.ini to fix the SchemingException, load things in differently than before and update README. Change licences.json path to new path.

Update package dict for test_create_dataset.py. Remove obsolete tests for test_create_dataset.py.

Update package dict for test_helpers.py.

Update package dict for test_resource_upload.py.

Update package dict for test_updated_dataset.py. Remove obsolete tests for test_update_dataset.py.

At end, Ran 18 tests, OK

+308 -225

0 comment

7 changed files

pr created time in 3 months

create barnchongov/ckanext-ontario_theme

branch : fix-tests

created branch time in 3 months

PR opened ongov/ckanext-ontario_theme

Improvement: Remove link placeholder text.

Remove link placeholder text for update_frequency help text. Currently there's nothing in the guidebook to link to.

+2 -2

0 comment

2 changed files

pr created time in 3 months

create barnchongov/ckanext-ontario_theme

branch : schema-update-frequecy

created branch time in 3 months

push eventbianca/ckanext-ontario_theme

Cody Boyko

commit sha cf83b8798b3475729f1c9d0c44cd66e1f2c6b170

Bug: Fix a few bugs. Compare resource formats in same case. Apply license_id field_name update. Update image path.

view details

Bianca Sayan

commit sha be0a9672ef0e6441a6ed86529734598236f5f2ba

Task: New Ontario Data Catalogue Homepage. New Ontario data catalogue homepage, sans translations.

view details

Bianca Sayan

commit sha c2c621a06fa2673face0ce4885df3e9e91f6474e

Bug: Categories iterator was incorrect. Categories iterator didn't iterate through all the categories.

view details

Bianca Sayan

commit sha 7e01f2ff0b9133a1d32871fdbc7b8e73174a569b

Task: Add responsive classes. Add responsive classes to homepage for dataset lists on homepage.

view details

Bianca Sayan

commit sha ae9bfae5192377dc4b4c2740b90fede4909cae4b

Task: Refactor homepage for internal site. Style internal/colby site and refactor to account for internal site.

view details

Cody Boyko

commit sha f397044191372fec939922f23d84570e71dc2c94

Merge pull request #137 from ongov/bug-revisions Bug: Fix a few bugs.

view details

Bianca Sayan

commit sha 3f755d8fcab817ae36f973fd4553eff7e50ee5db

Bug: Resource_search not reliable query. Resource_search not a reliable query. Order_by only works in one direction and doesn't seem to work for extra fields. The helper was switched to use the package current_as_of field.

view details

Bianca Sayan

commit sha 75c65b98bbcadf3c559b6c6f15667962b75bfbbe

Task: Add french and fix CSS. Add french translation for homepage and about page and fix CSS issues.

view details

Cody Boyko

commit sha 8fbd86a046f87ebf78ae8b987229720bc445bc55

Merge branch 'master' into new_homepage

view details

Bianca Sayan

commit sha e20b022b9a7770c54a3b83fc03342c2d9dc76821

Bug: Text updates post-QA review. Text, CSS, and translation updates as a result of QA review.

view details

Bianca Sayan

commit sha 9773d72a3e7a1118974caffe9174eddf0b8315f5

Merge branch 'new_homepage' of github.com:bianca/ckanext-ontario_theme into new_homepage

view details

Bianca Sayan

commit sha 643d47acd80b4c90c7c2412cf89b75ad72b2009e

Bug: Keywords with commas cannot be used. CKAN doesn't allow keywords with commas. The preferred solution is to display categories on the homepage with commas but link to comma-less keywords.

view details

Cody Boyko

commit sha fa009fd5e23e9a797c365db1c405f5496da2bd82

Merge pull request #139 from bianca/new_homepage Improvement: New homepage

view details

Bianca Sayan

commit sha 2667a61e9a5f85da7216309fd875ea358181c43e

Task: Update covid image. Update covid feature image on homepage

view details

Cody Boyko

commit sha 4f939bbf1faf725fb45ae0be376f297907ca7878

Merge pull request #142 from bianca/update_covid_feature_image Task: Update covid image.

view details

Cody Boyko

commit sha 4114316521631b1d12334549506dad9644f09eae

Merge branch 'master' into groups_to_fluent_collections

view details

push time in 3 months

Pull request review commentongov/ckanext-ontario_theme

WIP: Add french ga tags

 def get_license(license_id):     '''     return Package.get_license_register().get(license_id) +def get_translated_lang(data_dict, field, specified_language):+    site_language = i18n.get_lang()

This doesn't seem to be needed. Could also drop line 11 above as well.

bianca

comment created time in 3 months

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha 2667a61e9a5f85da7216309fd875ea358181c43e

Task: Update covid image. Update covid feature image on homepage

view details

Cody Boyko

commit sha 4f939bbf1faf725fb45ae0be376f297907ca7878

Merge pull request #142 from bianca/update_covid_feature_image Task: Update covid image.

view details

push time in 3 months

PR merged ongov/ckanext-ontario_theme

Task: Update covid image.

This PR consists of one commit to make one change: Update covid feature image on homepage. It just replaces the existing image.

+0 -0

0 comment

1 changed file

bianca

pr closed time in 3 months

push eventongov/ckanext-ontario_theme

Bianca Sayan

commit sha be0a9672ef0e6441a6ed86529734598236f5f2ba

Task: New Ontario Data Catalogue Homepage. New Ontario data catalogue homepage, sans translations.

view details

Bianca Sayan

commit sha c2c621a06fa2673face0ce4885df3e9e91f6474e

Bug: Categories iterator was incorrect. Categories iterator didn't iterate through all the categories.

view details

Bianca Sayan

commit sha 7e01f2ff0b9133a1d32871fdbc7b8e73174a569b

Task: Add responsive classes. Add responsive classes to homepage for dataset lists on homepage.

view details

Bianca Sayan

commit sha ae9bfae5192377dc4b4c2740b90fede4909cae4b

Task: Refactor homepage for internal site. Style internal/colby site and refactor to account for internal site.

view details

Bianca Sayan

commit sha 3f755d8fcab817ae36f973fd4553eff7e50ee5db

Bug: Resource_search not reliable query. Resource_search not a reliable query. Order_by only works in one direction and doesn't seem to work for extra fields. The helper was switched to use the package current_as_of field.

view details

Bianca Sayan

commit sha 75c65b98bbcadf3c559b6c6f15667962b75bfbbe

Task: Add french and fix CSS. Add french translation for homepage and about page and fix CSS issues.

view details

Cody Boyko

commit sha 8fbd86a046f87ebf78ae8b987229720bc445bc55

Merge branch 'master' into new_homepage

view details

Bianca Sayan

commit sha e20b022b9a7770c54a3b83fc03342c2d9dc76821

Bug: Text updates post-QA review. Text, CSS, and translation updates as a result of QA review.

view details

Bianca Sayan

commit sha 9773d72a3e7a1118974caffe9174eddf0b8315f5

Merge branch 'new_homepage' of github.com:bianca/ckanext-ontario_theme into new_homepage

view details

Bianca Sayan

commit sha 643d47acd80b4c90c7c2412cf89b75ad72b2009e

Bug: Keywords with commas cannot be used. CKAN doesn't allow keywords with commas. The preferred solution is to display categories on the homepage with commas but link to comma-less keywords.

view details

Cody Boyko

commit sha fa009fd5e23e9a797c365db1c405f5496da2bd82

Merge pull request #139 from bianca/new_homepage Improvement: New homepage

view details

push time in 3 months

PR merged ongov/ckanext-ontario_theme

New homepage enhancement

This PR consists of 4 commits to apply styles and html changes for both the external and internal homepages, as well as some colour changes across the sites.

+5076 -2624

0 comment

46 changed files

bianca

pr closed time in 3 months

issue commentckan/ckanext-fluent

Using Fluent with Organizations and Groups

Here is a basic PR that might help as an example of adding organizations in with scheming and fluent. It does a little extra modification to some templates but the PR message helps explain.

I agree, seeing your schema and extension would help troubleshoot what's causing the issue.

ryangermann-gov-on-ca

comment created time in 3 months

more