Please complete the information below:

Where is the problem?

Key Existence vs. Value Existence

What is the problem?

1 and 3 are both valid keys and values. Use an unambiguous example, such as a vec with string values. Ideally show what the expression evaluates to in order to be even clearer.

Please don't change anything below this point.

• Build ID: HHVM=HHVM-4.66.1:HSL=v4.41.0:2020-07-30T01:47:13+0000:b67cd08f26815fb47005e18801470032bf2307e2
• Page requested: /hack/built-in-types/arrays
• Page requested at: Sat, 01 Aug 2020 02:55:57 +0000
• Controller: GuidePageController

I am using Emscripten to compile Oniguruma as part of vscode-oniguruma. Presumably because the resulting JS could be used on either Node or the web, it is compiled with -s ENVIRONMENT=shell. It currently has this unfortunate workaround to rewrite the code generated by Emscripten:

https://github.com/microsoft/vscode-oniguruma/blob/bb4b078835b548e14c783bfe922700eda21b1ea3/scripts/remove-print.js#L11.

On the web, we have the problem where a global print() function is defined, which triggers the "print this page" behavior in a web browser! As you can imagine, this a pretty terrible side-effect when trying to log a message. It would be nice if we could remove that workaround.

/cc @alexdima

I have requested the same change to the TOML extension: https://github.com/bungcip/better-toml/issues/29.

If you want to use the Kotlin extension as an example, here are the relevant bits:

• https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/syntaxes/codeblock.json
• https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/package.json#L68-L77

I fixed a number of bugs and have cleaned up the code in my repo:

https://github.com/bolinfest/monaco-tm

I can run the Webpack config in dev mode just fine and see things working. Unfortunately, I get all sorts of garbage errors when I try to run Webpack in prod, which is unfortunate, as it would be nice to create a prod version so I can publish a demo to GitHub pages. I've already sunk more time in trying to debug Webpack than I care to, so if you're a Webpack expert and would like me to publish to GitHub pages, I would gladly take help in fixing up my Webpack config to make this possible.

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Bumps websocket-extensions from 0.1.3 to 0.1.4. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md">websocket-extensions's changelog</a>.</em></p> <blockquote> <h3>0.1.4 / 2020-06-02</h3> <ul> <li>Remove a ReDoS vulnerability in the header parser (CVE-2020-7662, reported by Robert McLaughlin)</li> <li>Change license from MIT to Apache 2.0</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/faye/websocket-extensions-node/commit/8efd0cd6e35faf9bb9cb08759be1e27082177d43"><code>8efd0cd</code></a> Bump version to 0.1.4</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/3dad4ad44a8c5f74d4f8f4efd3f9d6e0b5df3051"><code>3dad4ad</code></a> Remove ReDoS vulnerability in the Sec-WebSocket-Extensions header parser</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/4a76c75efb1c5d6a2f60550e9501757458d19533"><code>4a76c75</code></a> Add Node versions 13 and 14 on Travis</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/44a677a9c0631daed0b0f4a4b68c095b624183b8"><code>44a677a</code></a> Formatting change: {...} should have spaces inside the braces</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/f6c50aba0c20ff45b0f87cea33babec1217ec3f5"><code>f6c50ab</code></a> Let npm reformat package.json</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/2d211f3705d52d9efb4f01daf5a253adf828592e"><code>2d211f3</code></a> Change markdown formatting of docs.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/0b620834cc1e1f2eace1d55ab17f71d90d88271d"><code>0b62083</code></a> Update Travis target versions.</li> <li><a href="https://github.com/faye/websocket-extensions-node/commit/729a4653073fa8dd020561113513bfa2e2119415"><code>729a465</code></a> Switch license to Apache 2.0.</li> <li>See full diff in <a href="https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

I feel like pidpath() should return Result<PathBuf, String> since a path is not required to be UTF8, no?

Hmm, sorry, I think I also had an old version of the rust-analyzer extension installed (I may have built it from source and given it a different name) because I was also seeing issues about the rust-analyzer.extendSelection command being missing, which was removed earlier this year: https://github.com/rust-analyzer/rust-analyzer/commit/13eddd7c499388e956e47aae6a7210e43eb40d55.

Now that I removed that extension from VS Code, things appear to be working as intended!

I'm running rust-analyzer nightly right now (6824cf4) in VS Code 1.47.1 and it is giving me Syntax Error: attributes are not allowed on IF_EXPR on this code:

#[cfg(unix)]
if let Some(raw_os_error) = error_from_execv.raw_os_error() {

https://github.com/slackhq/vscode-hack/pull/100 is the fix.

Fix indent?

I have requested the same change to the TOML extension: https://github.com/bungcip/better-toml/issues/29.

If you want to use the Kotlin extension as an example, here are the relevant bits:

• https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/syntaxes/codeblock.json
• https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/package.json#L68-L77

I have requested the same change to the TOML extension: https://github.com/bungcip/better-toml/issues/29.

If you want to use the Kotlin extension as an example, here are the relevant bits:

• https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/syntaxes/codeblock.json
• https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/package.json#L68-L77

https://github.com/bungcip/better-toml/issues/10 added support for "front matter" syntax highlighting in Markdown files. I'm not that familiar with it, but I see it is some sort of metadata format that must appear at the start of a file: https://jekyllrb.com/docs/front-matter/.

For the rest of us, I think the more interesting injection into the Markdown grammar would be for fenced code blocks. This is what makes it possible to write a triple-backtick followed by a programming language and get it syntax-highlighted properly like so:

```js
function example() {
  return "This would be highlighted as JavaScript in a Markdown file.";
}
```

Unfortunately, this does not work with the TOML extension today:

```toml
key = "This is not syntax highlighted as TOML in a Markdown file in VS Code today."
```

Here are examples of how other VS Code extensions provide this functionality:

• Haskell https://github.com/JustusAdam/language-haskell/blob/c71c5d06452ec63c525cd6de27a16689302af5c5/syntaxes/codeblock-haskell.json
• Kotlin https://github.com/mathiasfrohlich/vscode-kotlin/blob/090fe4cd054d6142d7eaefdb69c12d4b063a089e/syntaxes/codeblock.json

The Haskell example has some extra checks beyond the Kotlin one (with the begin/while bits), though I haven't worked out what edge cases those are trying to address. I think porting the Kotlin example (include the additional entry in the grammars list in the package.json) would probably work well enough for now, though.

In resolveParsedThemeRules(), the default foreground/background are set to black/white:

https://github.com/microsoft/vscode-textmate/blob/57770e0233f626eeb11f9e3543ff64870b083613/src/theme.ts#L183-L184

which is appropriate for a light theme like this one:

https://github.com/microsoft/vscode/blob/a716714a88891cad69c0753fb95923870df295f5/extensions/theme-defaults/themes/light_defaults.json#L5-L6

but I don't believe it's appropriate for a dark theme:

https://github.com/microsoft/vscode/blob/a716714a88891cad69c0753fb95923870df295f5/extensions/theme-defaults/themes/dark_defaults.json#L5-L6

Can some sort of dummy value (with an empty scope?) be used to workaround this in the IRawTheme?

I figured out a workaround, which is to include an entry without a specific scope in IRawTheme.settings. For example, taking the values of editor.foreground and editor.background from https://github.com/microsoft/vscode/blob/a716714a88891cad69c0753fb95923870df295f5/extensions/theme-defaults/themes/dark_defaults.json#L5-L6, the appropriate entry to add would be:

    {
      settings: {
        foreground: '#D4D4D4',
        background: '#1E1E1E',
      },
    },

I can understand why these files are generated, though on a personal note, it's a bit challenging because every other VS Code extension has these files vendored in, which makes them much easier to scrape from GitHub for things like https://github.com/bolinfest/monaco-tm.

Hmm, or are these generated as of:

https://github.com/JustusAdam/language-haskell/commit/1c5b9c453dca60a43403f76ebf914e431a9f8a98

The file ./syntaxes/cabal.json does not exist:

https://github.com/JustusAdam/language-haskell/blob/c71c5d06452ec63c525cd6de27a16689302af5c5/package.json#L139

The file syntaxes/literateHaskell.json does not exist:

https://github.com/JustusAdam/language-haskell/blob/c71c5d06452ec63c525cd6de27a16689302af5c5/package.json#L154

In resolveParsedThemeRules(), the default foreground/background are set to black/white:

https://github.com/microsoft/vscode-textmate/blob/57770e0233f626eeb11f9e3543ff64870b083613/src/theme.ts#L183-L184

which is appropriate for a light theme like this one:

https://github.com/microsoft/vscode/blob/a716714a88891cad69c0753fb95923870df295f5/extensions/theme-defaults/themes/light_defaults.json#L5-L6

but I don't believe it's appropriate for a dark theme:

https://github.com/microsoft/vscode/blob/a716714a88891cad69c0753fb95923870df295f5/extensions/theme-defaults/themes/dark_defaults.json#L5-L6

Can some sort of dummy value (with an empty scope?) be used to workaround this in the IRawTheme?