push eventboaz0/koku
commit sha 219b70f1cabcf5f64454132f1cd6daa80d9517c3
upgrade pip to latest during build
commit sha ba1cdfb7e193492e6ab0bdc111f2830d95eed53e
Update README pipenv install fails until you export LDFLAGS and CPPFLAGS
commit sha 5494cfb7741b06eed5f0e632b831c6a26ece0289
adding missing migrations (#1150)
commit sha 63cdd89e77659c905ec319ef9cd349fa1b4b456f
Merge branch 'master' into nbon12-patch-documentation-1
commit sha e707851c78eae96c76882aac4ab7f334a37826b9
remove greater than zero constraint on markup_cost (#1151) * remove greater than zero constraint on markup_cost * convert Decimal value to string * fix to_internal_value to return if value is none
commit sha 6498ba5852f9cff28b8355dd4cdddaabc90e962c
Apply suggestions from code review Co-Authored-By: Andrew Berglund <[email protected]>
commit sha cd90355537287ea1550fe3f1eb49bdf98632ce27
Merge branch 'master' into nbon12-patch-documentation-1
commit sha 71bdccebd60b0c9fb48ab0a285d728b2673883d7
Azure Downloader: Support multiple exports in a subscription (#1147) Checking storage account and resource group to get correct export for a given subscription.
commit sha 5b5e528103bdae37b28db5c9dbd6e49843ea06e3
add pgadmin
commit sha 6108181d5cecc866a91c16898f1878add3315f32
Merge branch 'master' into pgadmin
commit sha 149830bcf3101d36c1937eb49d389ef60873c2ba
set default value for pgadmin required environment variables
commit sha 4a840818a9e01d1b601a0aa9a7340afdd6925d15
Merge branch 'pgadmin' of https://github.com/project-koku/koku into pgadmin
commit sha 513b41aaa29dc4e34043cd80ceed939fd76119a5
Merge branch 'master' into nbon12-patch-documentation-1
commit sha ea33bb31e585db963b2e4617d246e511baaf1db2
Merge pull request #1153 from project-koku/nbon12-patch-documentation-1 Update README
commit sha ea6f3e6ce972dcbb76102f0669edbb49bdabe256
add .example at end of pgadmin_servers.json
commit sha ec1bd6663b1f04123b95552e7adbbe4837a2c0b8
add pgadmin_servers.json to gitignore
commit sha 6c67de30d98fcc568c053ab72dd00aa8044c67b6
Merge branch 'master' into pgadmin
commit sha 1d7a6fe49c5ddded2c61a078015ffa8fed9d75d3
pipfile hash update (#1157)
commit sha 942d3c1901c5de7a97760e3997ee21c926d00438
Merge branch 'master' into pgadmin
commit sha 6ee93c458911e9c71ecbdf11c8572352a2dee2ad
Merge pull request #1156 from project-koku/pgadmin add pgadmin
push time in a day
push eventboaz0/koku-ui
commit sha e9783c993b6edcae815cef8ce59028cadfd64cbd
Changed notation for Azure to reflect "virtual Machines" instance of Computer (EC2) Instances"
commit sha 6810edfad36ee03acf10cea7967090361874767f
Changed notation for Azure to reflect "virtual Machines" instance of Computer (EC2) Instances"
commit sha cb467d2a08c6769cfe976e5def7c12399cbcc6b9
Merge pull request #1082 from ddonahue007/compute_ec2_instance-1078 Changed notation for Azure to reflect "virtual Machines" instance of …
commit sha e6aa8e908b22d60d5ba9980f2cff919c8cdeea5b
Azure usage values Fixes https://github.com/project-koku/koku-ui/issues/1080
commit sha 1e36263e74c54aa806526ecf60469740a69bc639
Merge pull request #1084 from dlabrecq/1080-usage-values Azure usage values
push time in a day
Pull request review commentpatternfly/patternfly-react
fix(PaginationTableDemo): add Spinner and empty state to demo
class ComplexPaginationTableDemo extends React.Component { } render() {- const { loading } = this.state;+ const { loading, res } = this.state;+ if (res.length === 0) {+ const rows = [{+ heightAuto: true,+ cells: [+ {+ props: { colSpan: 8 },+ title: (+ <Bullseye>+ <EmptyState variant={EmptyStateVariant.small}>+ <EmptyStateIcon icon={SearchIcon} />+ <Title headingLevel="h2" size="lg">+ No results found+ </Title>+ <EmptyStateBody>+ No results match the filter criteria. Remove all filters or clear all filters to show results.+ </EmptyStateBody>+ </EmptyState>+ </Bullseye>+ )+ },+ ]+ }]
we should probably add a filter to the table and if a filter is set show empty state.
comment created time in 2 days
PR closed patternfly/patternfly-react
What:
closes #3184
pr closed time in 2 days
pull request commentpatternfly/patternfly-react
docs(table): add empty state and spinner to pagination table demo
closing this in favor of #3294
comment created time in 2 days
PR closed patternfly/patternfly-react
What:
closes #3116
I added the triggers prop to modify the trigger option passed to TippsyJS.
Please notice that if you set isVisible this props is irrelevant since you are the one who manages when to display the popover and thus you will have to implement those triggers or catch those events and mutate the state that determines whether to display or hide the popover.
//cc @jotak
pr closed time in 2 days
pull request commentpatternfly/patternfly-react
feat(popover): allow to set popover trigger
Sure, let me open a follow up ticket for that.
comment created time in 2 days
pull request commentpatternfly/patternfly-react
fix(flex): in breakpointMods set breakpoint as optional and add enums
@rebeccaalpert I didn't know that you're not going to use enums.
What should I use instead? Because if I am using literal types, passing a string will show a typescript error unless I will use the as keyword.
comment created time in 6 days
Pull request review commentpatternfly/patternfly-react
import * as React from 'react'; import styles from '@patternfly/react-styles/css/components/Nav/nav'; import { css } from '@patternfly/react-styles';+import { NavVariants } from './NavVariants';
You imported NavVariants but you're not using it.
comment created time in 6 days
push eventboaz0/patternfly-react
commit sha 3efa4e33658ce69e64ecb74d4365536856bbfb85
fix(catalog-view-extension): check for sass changes (#3271)
commit sha cd26ae05d5b25a1d084f938c5502e5bbee298e07
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha c0a63bc68879aa447b3d99a57d94f217e15777c9
chore(table): fix types for table transforms (#3203) * fix(table): fix table types so transforms/formatters work with strictFunctionTypes tsconfig setting apply types to demos for table update tests * [cleanup] remove unused import
commit sha 7b33bec7a86166891a9e390f78aa7b11533381eb
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 482dafe0d22566baa784ca3c6c2f119a8b2f6e58
PF4: fix(README.md): provides URL location of workspace (#3254) * update README.md * update readme.md
commit sha ee6e739e2f73e550a01a6eec6b8f8fdfef5805d2
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha e74587f74e58e1bb10213d497be34fba1938dc2d
fix(catalog-view-extension): Remove unused dev dependencies from package.json (#3275) Remove unused dev dependencies from package.json
push time in 6 days
push eventboaz0/koku-ui
commit sha c65bdb37dd618779359a18cef9cd18ae07627801
fix(basename): Include second pathName only for sources settings
commit sha 9a51163e77264790dd3e956828a29a6c8ba39e23
Merge pull request #1074 from karelhala/align-basename Include second pathName only for sources settings
commit sha b2f01fb88c3fd8adb2cda515cdff223e6f205fca
fix(costmodels): details page sources tab fit and finish Signed-off-by: Boaz Shuster <[email protected]>
commit sha 86ee615649745e2fb095dabe38538f28ad3b95c6
Update PatternFly packages to use latest milestone release Fixes https://github.com/project-koku/koku-ui/issues/1073
commit sha e69ef9115329fbd5178b320051554140eaaf08d7
Merge pull request #1076 from dlabrecq/patternfly-update Update PatternFly packages
commit sha 3438fd188dce606d58591285c6e464efbfb80e3e
Merge pull request #1065 from boaz0/closes_1059 fix(costmodels): details page sources tab fit and finish
push time in 6 days
push eventboaz0/patternfly-react
commit sha 00af50d897a305949bac33a213bd199b59ab7802
feat(textinput): support passing a ref Signed-off-by: Boaz Shuster <[email protected]>
push time in 7 days
push eventboaz0/patternfly-react
commit sha 2ae470a222ddf2df319a99d3b5508b8b55935744
Align sass file with css example file for properties panel (#3236)
commit sha cb998e1f9aa2f1810f29d091db58c443aeacfcd7
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 5991033126ff429172fcaa345806bd5a59671ef3
fix(optionmenu): remove the i element around selected item svg (#3238) Signed-off-by: Boaz Shuster <[email protected]>
commit sha 036a552b1ef848d14f12100eb105489735edbcda
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 2034af919de2a3bfa5e89fa4a0b87cb7f69f466c
chore(table): add types, examples, and demo for onRowClick (#3265) * chore(table): add types, examples, and demo for onRowClick provide type for onRowClick handler add onRowClick example to docs add onRowClick test for table add on row click demo in react-integration clean up customRowWrapper demo/example only fire onRowClick when it is provided by user * [cleanup] add type for onRowClick
commit sha 0185bc561157fd5657d34b73125dccb0e6d01ed5
build(package.json): Upgrade react-bootstrap to fix React deprecated lifecycle method warnings (#3249) * build(package.json): Upgrade react-bootstrap to fix React lifecycle method warnings Fix #3010 * Update snapshots
commit sha f24a41037d5f7443e2f1ddb02faa9967c237d89c
chore(demo-app-ts): increase the strict checks as much as possible for react-integration (#3222)
commit sha 29d89d9e5944fe6394d02ee856a2fb5f07e63962
chore(release): releasing packages [ci skip] - [email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 7 days
pull request commentproject-koku/koku-ui
fix(costmodels): details page sources tab fit and finish
//ping @dlabrecq - read for your review :raised_hands:
comment created time in 8 days
push eventboaz0/koku-ui
commit sha b2f01fb88c3fd8adb2cda515cdff223e6f205fca
fix(costmodels): details page sources tab fit and finish Signed-off-by: Boaz Shuster <[email protected]>
push time in 8 days
pull request commentpatternfly/patternfly-react
fix(button): support setting tab index unless not button and disabled
Thanks @redallen !
comment created time in 8 days
issue commentproject-koku/koku-ui
Refreshing details page navigates to Cost Management Overview
Hi @dchorvat1 I see. This is going to be addressed in https://github.com/RedHatInsights/insights-chrome/pull/434
comment created time in 9 days
issue closedproject-koku/koku-ui
Refreshing details page navigates to Cost Management Overview
Describe the bug After refreshing the page in any of the details (OCP, OCP on AWS, Cloud), the UI takes us to the Overview.
To Reproduce Steps to reproduce the behavior:
- Log in, navigate to Cost Management
- Click on Cloud details
- Refresh the page
- See error
Expected behavior After the refresh, we don't get to overview
Desktop (please complete the following information):
- OS: Rhel
- Browser Chrome
Additional context If we navigate back to a details page and refresh again, we don't get to overview completely, but the side navigation shows "Overview" as the selected item.
Tested on CI Beta
closed time in 9 days
dchorvat1
issue commentproject-koku/koku-ui
Refreshing details page navigates to Cost Management Overview
fixed in https://github.com/project-koku/koku-ui/pull/1074
//cc @dchorvat1 feel free to test.
comment created time in 9 days
pull request commentpatternfly/patternfly-react
fix(button): support setting tab index unless not button and disabled
It seems like a problem with the memory size causes pf4 docs build to fail.
In addition, I can build the docs successfully on my machine and can't reproduce it on my machine.
@redallen can you look at it?
@patternfly/react-docs: failed Building static HTML for pages - 70.042s @patternfly/react-docs: error Building static HTML failed @patternfly/react-docs: 1 | function _defineProperty(obj, key, value) { @patternfly/react-docs: > 2 | if (key in obj) { @patternfly/react-docs: | ^ @patternfly/react-docs: 3 | Object.defineProperty(obj, key, { @patternfly/react-docs: 4 | value: value, @patternfly/react-docs: 5 | enumerable: true, @patternfly/react-docs: @patternfly/react-docs: WebpackError: Call retries were exceeded
comment created time in 9 days
push eventboaz0/patternfly-react
commit sha e43cb4c1f924d822bcf84bdb4e5323a079171255
fix(Table): Add opt out of disable header on empty table (#3242) Add a property called disableHeaderOnEmptyState default value false. When set to true will disable header based on row props being empty when set to false (default) no disable state changes will occur. fix #3241
commit sha 98323be9154aeb2af7989751ff6979a752ec210a
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 2b32924c4c62e9615d0127216274829c3a829f9b
Revert "fix(Table): Add opt out of disable header on empty table (#3242)" (#3243) This reverts commit e43cb4c1f924d822bcf84bdb4e5323a079171255.
commit sha b4e9b532c56216759b7fdf21b84c224ca2247a94
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 419a90703520f84f93e2b53b31284f814c462ce3
Revert isTableEmpty (#3246) * Revert isTableEmpty * update snapshot
commit sha e1fcdfc31e8bc598b4b58bc9d3657e958dabb203
chore(package): Bump @patternfly/patternfly versions to 2.40.3 (#3247)
commit sha f72bd3f43df5532f81dfda4433535e72c45dfc1d
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 0d4a347e51ab7a35a0280271eaf4e21a469936e7
chore(package): Bump @patternfly/patternfly versions to 2.40.4 (#3251)
commit sha 0be35f9cb116c6096adcd1d3a4664040e65150e1
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 70f2a0a86fb2c9ea37021291bdb3b25d1217508a
chore(package): Bump @patternfly/patternfly versions to 2.40.6 (#3256)
commit sha 2c8ea980315c9274c1e468109d027f9d331886cf
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha e8277df720564c5a28eff40f9e2ae0c17520412b
fix(button): support setting tab index unless not button and disabled Signed-off-by: Boaz Shuster <[email protected]>
push time in 9 days
issue commentpatternfly/patternfly-react
ping @seanforyou23
comment created time in 9 days
push eventproject-koku/koku-ui
commit sha c65bdb37dd618779359a18cef9cd18ae07627801
fix(basename): Include second pathName only for sources settings
commit sha 9a51163e77264790dd3e956828a29a6c8ba39e23
Merge pull request #1074 from karelhala/align-basename Include second pathName only for sources settings
push time in 10 days
PR merged project-koku/koku-ui
Fixes
If you refresh page on /cost-management/aws it will include aws as part of basename url and once user clicks on ocp in navigation path will be /cost-management/aws/ocp this is because basename calculation tries to include second part of pathName all the time. On other hand sources settings require this second part to be present.
It's a bit hacky writing consts in the path calculation, but this is quick and dirty solution, once sources will be in specific bundle (hopefully in 2 weeks) this hacky work around can be removed and basename can be only
<BrowserRouter basename=`${release}${pathName[0]}/` />
pr closed time in 10 days
PR opened patternfly/patternfly-react
What:
closes #3244 closes #3248
- Set breakpoint as optional in breakpointMd
- Add FlexModifiers and FlexItemModifiers
- Update examples
pr created time in 10 days
push eventboaz0/patternfly-react
commit sha ef450621ee51ab08407e7ce7fb475037a7f2ad94
fix(flex): in breakpointMods set breakpoint as optional and add enums Signed-off-by: Boaz Shuster <[email protected]>
push time in 10 days
push eventboaz0/patternfly-react
commit sha 2735c04fa85514fc91b3fef80be7a12a83ab0cb0
fix(flex): in breakpointMods set breakpoint as optional and add enums Signed-off-by: Boaz Shuster <[email protected]>
push time in 10 days
push eventboaz0/patternfly-react
commit sha 70f2a0a86fb2c9ea37021291bdb3b25d1217508a
chore(package): Bump @patternfly/patternfly versions to 2.40.6 (#3256)
commit sha 2c8ea980315c9274c1e468109d027f9d331886cf
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 10 days
push eventboaz0/patternfly-react
commit sha e43cb4c1f924d822bcf84bdb4e5323a079171255
fix(Table): Add opt out of disable header on empty table (#3242) Add a property called disableHeaderOnEmptyState default value false. When set to true will disable header based on row props being empty when set to false (default) no disable state changes will occur. fix #3241
commit sha 98323be9154aeb2af7989751ff6979a752ec210a
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 2b32924c4c62e9615d0127216274829c3a829f9b
Revert "fix(Table): Add opt out of disable header on empty table (#3242)" (#3243) This reverts commit e43cb4c1f924d822bcf84bdb4e5323a079171255.
commit sha b4e9b532c56216759b7fdf21b84c224ca2247a94
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 419a90703520f84f93e2b53b31284f814c462ce3
Revert isTableEmpty (#3246) * Revert isTableEmpty * update snapshot
commit sha e1fcdfc31e8bc598b4b58bc9d3657e958dabb203
chore(package): Bump @patternfly/patternfly versions to 2.40.3 (#3247)
commit sha f72bd3f43df5532f81dfda4433535e72c45dfc1d
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 0d4a347e51ab7a35a0280271eaf4e21a469936e7
chore(package): Bump @patternfly/patternfly versions to 2.40.4 (#3251)
commit sha 0be35f9cb116c6096adcd1d3a4664040e65150e1
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 12 days
issue openedproject-koku/koku
Cost models - filter cost model by description too
User Story
As user, I want to filter cost models by description so that cost models that contains specific information in the description will be shown.
Impacts
API, UI
Role
Assumptions
API Details
| API | Detail |
|---|---|
| Method | GET |
| Path | /api/v1/costmodels/ |
| Body | |
| Response | cost models filtered by sub string |
UI Details
Acceptance Criteria
- [ ] passing a description parameter that will filter cost models that contains it in their descriptions. I assume the length of that parameter should not be more than 25 characters. I guess that the description may contain spaces, quotes, double quotes and etc.
created time in 13 days
issue commentproject-koku/koku
Cost models API - sorting cost models
@adberglund @maskarb - feel free to update the ticket in case I missed something. Thanks.
comment created time in 13 days
issue openedproject-koku/koku
Cost models API - sorting cost models
User Story
As user, I want to sort cost models by name, number of sources assigned or last modified so that cost models that most recent or have the most sources will be shown first.
Impacts
API & UI
Role
Assumptions
API Details
| API | Detail |
|---|---|
| Method | GET |
| Path | /api/v1/cost-models/ |
| Body | |
| Response | sorted cost model list by name/last-modified/sources |
UI Details
Acceptance Criteria
- [ ] passing sort-by (name, sources, updated) and sort-direction (asc/desc) parameters
- [ ] sorting information (by and direction) have to be shown in the response body.
created time in 13 days
pull request commentproject-koku/koku-ui
fix(costmodels): details page sources tab fit and finish
I am adding @chargio to this conversation too.
comment created time in 13 days
pull request commentproject-koku/koku-ui
fix(costmodels): details page sources tab fit and finish
//ping @dlabrecq @nlcwong please review this.
comment created time in 13 days
issue commentproject-koku/koku-ui
Refreshing details page navigates to Cost Management Overview
Yes, I do notice this odd thing. My guess it's related to moving from hybrid. I will look at it tomorrow.
Thanks.
comment created time in 13 days
PR opened patternfly/patternfly-react
What:
closes #3208
//cc @petli-openshift
pr created time in 14 days
issue commentpatternfly/patternfly-react
PF4 Button does not pass through tabIndex prop
@petli-openshift is there a reason you want to set tab index to -1 and still enable the button. We set the tab index to -1 only when the button is disabled or the component is not a button.
comment created time in 14 days
issue commentpatternfly/patternfly-react
PF4 Wizard throws warning about 'appendTo' prop
thank you for noticing
comment created time in 14 days
PR opened patternfly/patternfly-react
What:
closes #3237
//cc @keithjgrant
pr created time in 14 days
PR opened patternfly/patternfly-react
What:
closes #3229
//cc @mcoker
pr created time in 14 days
push eventboaz0/patternfly-react
commit sha 73ec92eb58bf714a87d2541ad8acb838376ccb35
fix(virtualized): fix regressions from #2761 (#3228)
commit sha aac73ee6cf9e3a46bad76d2839746a6320e1bc16
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 43c4e1029bd0df9ac22df83ebb1424693adc9753
fix(table): bind isTableEmpty function (#3225)
commit sha 269a6f0b2a17621be576becc2a63cabbfe3222a1
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 15 days
PR opened project-koku/koku-ui
closes #1070
In regard to the text copied to the clipboard, I couldn't reproduce this and I'm using Firefox. Maybe you're using a different browser?
Thanks.
pr created time in 16 days
issue closedproject-koku/koku-ui
Add source modal has incomplete commands for crontab
Describe the bug Add source modal has incomplete commands for crontab
To Reproduce Steps to reproduce the behavior:
- Go to 'Add a source'
- Click through setting up ocp provider
- See Configure data collection screen
- Commands on this step are missing some items
Expected behavior
crontab -u <username> -e
*/45 * * * * /path/to/ocp_usage.sh --collect --e OCP_CLUSTER_ID=<YOUR_OCP_IDENTIFIER>
Screenshots
Desktop (please complete the following information):
- OS: Fedora
- Browser: Chrome
- Version: 77
Additional context Seeing this issue on CI beta
closed time in 17 days
lcouzens
issue commentproject-koku/koku-ui
Add source modal has incomplete commands for crontab
@lcouzens closing this in favor of #1070
comment created time in 17 days
issue openedproject-koku/koku-ui
Add source modal contrab: set cluster id in the instructions
Describe the bug This is a follow up by https://github.com/project-koku/koku-ui/issues/1052#issuecomment-546365804
To Reproduce Steps to reproduce the behavior:
- Go to 'Sources' > 'Cost management'
- Click on 'Add a source'
- Create a new OpenShift source
- Fill the information till you get to the configuration part
Expected behavior Cluster id should replace the <YOUR_OCP_IDENTIFIER> and copy the crontab command should be similar to the text.
Screenshots
created time in 17 days
push eventboaz0/koku-ui
commit sha b518c65a4bae42a5ba6757dec9b31349ff1010de
fix(navigation): use history push only for user actions
commit sha fd39f1d6d765686a7863c6ccb46541659ba1ca60
Merge pull request #1069 from karelhala/history-push-only-action fix(navigation): use history push only for user actions
push time in 17 days
push eventboaz0/patternfly-react
commit sha 672047a11c6aba41a26d87d7d3914783fdbf9dc0
Bump @patternfly/patternfly versions to 2.40.2 (#3204) * chore(package): Bump @patternfly/patternfly versions to 2.40.2 * update overflow menu * OverflowMenuDropdownItem: added isShared prop back DropdownItems read from isShared and from context to conditionally render. * OverflowMenuDropdownItem: added prop description * OverflowMenuDropdownItem - isShared defaults to false
commit sha bb3132571ea797ffa9e77f6ff3007543c6000735
PF4: (virtualized-extension) jest tests for VirtualizedTable (#2761) * [WIP] jest tests for VirtualizedTable * add(virtualized table tests): tests are now running, resolving TS errors with any type for now * add yarn.lock * Delete package-lock.json * fix table tests and make rows prop optional * resolving conflict in yarn.lock * addressing PR feedback * removing react-virtualized dependency from root * resolving merge conflicts and trying to fix snapshots * updates snapshots * updates snapshot test * Update VirtualizedTable.test.tsx * updates package.json and yarn.lock * update package.json and rerun yarn install * Delete package-lock.json
commit sha 1022897f9d5b15357247026aff2da63704f1cbea
chore(DataToolbar): add unit and integration tests (#3201)
commit sha a30b8c0341e4f06d41e34c97950b060899f22c38
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 725af730447f60a734fbbf0b1494644b1fe39f43
docs(Table Filter Demo) (#3127) * feat(FilterTableDemo): add demo of filterable table * feat(FilterTable demo): update name search input to clear after selecting filter update select tests for select fix * feat(FilterTable demo): remove old example code * feat(FilterTable demo): update snapshot with rebase * feat(FilterTable demo): add pr feedback, rebase master, update snapshots * feat(FilterTable demo): add empty state when filters return no rows * feat(FilterTable demo): add responsive toggle, remove width limits * feat(FilterTable demo): add docs note to mention DataToolbar component
commit sha 776855d3752b83e66cbae3375e8822d84cf88e0e
fix snapshot (#3216)
commit sha cf773a68f39cff935da08bccce59139c5bb56046
docs(Release Notes): Update release notes 2019.9 (#3215) * docs(Release Notes): Update release notes 2019.9 #3214 * update for comments * update for comments * update for comments * move charts and table out of components section
commit sha 377ac47241108e331fa1b9c91024225237d2c848
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 17 days
push eventboaz0/patternfly-react
commit sha 1a287c379e058340c72b495e655c000f3ec690b4
feat(textinput): support passing a ref Signed-off-by: Boaz Shuster <[email protected]>
push time in 19 days
push eventboaz0/patternfly-react
commit sha 92a0a80b79064bc6869bbfe7d82ccc96f0100c1b
feat(textinput): support passing a ref Signed-off-by: Boaz Shuster <[email protected]>
push time in 19 days
Pull request review commentpatternfly/patternfly-react
feat(popover): allow to set popover trigger
test('popover passes along values to tippy.js', () => { ); expect(view).toMatchSnapshot(); });++test('popover with custom triggers', () => {
Yeah sure! I added a test into its spec to make sure that setting a focus trigger will display the popover. :man_technologist:
comment created time in 19 days
Pull request review commentpatternfly/patternfly-react
feat(popover): allow to set popover trigger
export interface PopoverProps { * Instead, the consumer is responsible for closing the popover themselves by adding a callback listener for the shouldClose prop. */ isVisible?: boolean;+ /** The events which cause the popover to show. **/+ triggers?: Triggers[];
Good idea!
comment created time in 19 days
push eventboaz0/patternfly-react
commit sha 9ee3ce4d31189211ccd37eeddcd22ce3062dce4f
feat(popover): allow to set popover trigger Signed-off-by: Boaz Shuster <[email protected]>
push time in 19 days
push eventboaz0/patternfly-react
commit sha 1d656adbcd1e2fe6fe56e27c990e4bdb4457e888
surround ouia check with a try catch (#3178)
commit sha 56ee9f7f116b879aaf4b2e95cde52cdab615306d
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 6dda90afa452704900eb02ed0b61d133d07c1133
fix(Select): add plain modifier to toggle button (#3140) #3128
commit sha ca4dff78431cabf402c86b04746486e4665104ff
fix(Select): display typeahead filtered options (#3158) - set onFilter to null to run the default filter - pass 'this.onClick' to inputs to avoid reseting options Signed-off-by: Boaz Shuster <[email protected]>
commit sha 14995c7a4b3e8722660250f9d9ba0e4bfd6f039e
chore(package): Bump @patternfly/patternfly versions to 2.37.0 (#3181)
commit sha 3e5e06e0d053fd5d8b6722be509b719d0f3fd3d0
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 92971d3843ab6395a6c2c554c6932ba800c34776
feat(Divider): add divider component (#3125) * feat(divider): add divider component * feat(divider): add tests * feat(divider): update tests * fix(divider): update tests * fix(divider): updates * fix(divider): updates based on review * fix(divider): push more updates * fix(divider): rebase yarn * fix(divider): push updates * fix(divider): update based on titani comments * fix(divider): update spelling
commit sha 1f0defabae1900a21bae91ec9bef5dc16f3050a0
feat(BulkSelect demo): add bulk select demo with table and toolbar (#3082) * feat(BulkSelect demo): add bulk select demo with table and toolbar * feat(BulkSelect demo): update checkbox to toggle all and none selection * feat(BulkSelect demo): change menu toggle to 'any or none' from 'all or none' * feat(BulkSelect demo): add another pagination indicator at top, cleaned up checkbox event handling s * feat(BulkSelect demo): move label out of checkbox * feat(BulkSelect demo): update with pr feedback * feat(BulkSelect demo): remove unused import
commit sha e77c61361e7c3e475c2ea585d6c001f754b68faf
fix(DataToolbar): implement changes to match PF-Core (#3144) * fix(DataToolbar): implement structural and interaction changes to match PF-Core * update documentation in examples, input group styles, and clarify DataToolbarContent state names * change some wording in example documentation * make prop descriptions sentence case * fix some unintented quirks in filter example * fix documentation to accommodate theming * fix expandable content id generation * fix expanded state in stacked example * move isToggleManaged out of DataToolbar.tsx state * more small styling updates * add pf-m-toggle-group-container to examples and hide chip containers whenever there are no chips to display * remove right-align in example
commit sha f96bda86c31cd150d25ca82a4778ce0efac88ce6
Custom row wrapper example for table (#3160) * custom row wrapper * feat(example): fix console errors for table examples, add row wrapper example remove unused imports from examples improve type for rowProps ensure rowwrapper example works in typescript clear some lint errors
commit sha 5089eb90c9a6cb6bd179e5fc5bfdca90c0304712
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 2da4c48f37dfa36a5b54d11125bc446e619134f4
docs(Select): update prop description for selctions (#3183) #3106
commit sha 17d280a4a7c9209abc16dbd62be3e82ee596a7ef
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha d61ae9d1a6e346ef5b45b3851fd6750ec2a044c9
feat(TextArea): Add a prop to allow limiting the resize orientation o… (#3180) * feat(TextArea): Add a prop to allow limiting the resize orientation of the TextAres #2839 * update jesttest
commit sha 3e98180fcc4d421b8732fe0c390f56610e92b81f
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 20a981b6aff0bbf3ff04d5b016f67bf76545f3cd
feat(react-catalog-view-extension): Added catalog view extension and three components (#3145) * feat(Extension/Catalog Item Header): Added new extension and catalog item header component * feat(CatalogTile): Added support for catalog tile New implementation relies on PF4 card, with some extra stuff (styles, text truncation) laid on top. * feat(VerticalTab): Added support for vertical tabs, including tests * Removed less support * Add variables to sass * Added support for classnames back in and minor spacing fix * Minor update to featured catalog tile styling (Per Michael Celedonia) * feat(PropertiesSidePanel): Provide a path to pf4 for this extension with same props for easy migrati Only change from pf3 to pf4 are the fonts as we no longer support the core os look and feel of grey uppercase titles and font sizes. 3159 * add catalogview to docs * add catalogview to docs * add react-core as a dependency * Update version and snapshot changes from Zack's updates * cache new extension in CI * Update images * Update catalog tile sass and sass naming * Remove catalog tile snapshot with timestamp * Fix name * Adjust image naming * Fixed type * fix md files and example dir structure * fix scss extension file * remove old sass dir * fix css import * Add sideEffects to package.json * feat(FilterSidePanel): Create FilterSidePanel for catalog-view-extensions Provide a migration path from pf3-pf4 for FilterSidePanel without changing the API and with minor style changes re #3159 * Add updated lock file * Updated PF version to remove linter error
commit sha df491ae45065b4e63341fbc193de8474013fe37b
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 22b3a6d8cb44de03738ffceeaf63a23dcd521388
Add issue template (#2804) * Update issue templates I would like to add an issue template for our contributors. * Update PatternFly template I've updated the PatternFly issue template * Updated styling for the PF template * Updated Zack's changes * Add Codesandbox link * Update codesandbox link
push time in 19 days
push eventproject-koku/koku-ui
commit sha b518c65a4bae42a5ba6757dec9b31349ff1010de
fix(navigation): use history push only for user actions
commit sha fd39f1d6d765686a7863c6ccb46541659ba1ca60
Merge pull request #1069 from karelhala/history-push-only-action fix(navigation): use history push only for user actions
push time in 20 days
PR merged project-koku/koku-ui
This will enable custom app navigation trough insights.chrome.appNavClick({id: 'cost-management-sources', secondaryNav: true}) and not triggering redirect.
pr closed time in 20 days
pull request commentproject-koku/koku-ui
fix(navigation): use history push only for user actions
I see now. Thanks.
comment created time in 20 days
pull request commentproject-koku/koku-ui
fix(navigation): use history push only for user actions
@karelhala I was testing it but I am still redirected to the overview page.
comment created time in 20 days
issue commentpatternfly/patternfly-react
Docs: update PaginationToolbar demo to include empty state and spinner
@mcarrano https://patternfly-react.surge.sh/patternfly-4/documentation/react/demos/paginationtable
comment created time in 21 days
push eventboaz0/koku-ui
commit sha 3c2c24967ed1a3d68ecd4a34e4f9675c5816ef2d
fix(costmodels): price list tab fit and finish Signed-off-by: Boaz Shuster <[email protected]>
commit sha da2259c9d8e1c8e07d931e86c4e5d8b2ed1c8caf
fix(costmodels): markup tab in details page - fit and finish Signed-off-by: Boaz Shuster <[email protected]>
commit sha b66434dc99c0197b140ff6d14c9c54ff118bfb57
Merge pull request #1063 from boaz0/closes_1056 fix(costmodels): price list tab fit and finish
commit sha 6b4c4f54c7d9d1d9b346fe21582f8a8d7c0ebc75
Merge pull request #1064 from boaz0/closes_1057 fix(costmodels): markup tab in details page - fit and finish
commit sha b6b63b5df7607850354be133d65bd68e30e03e40
fix(onboarding): incomplete commands for contrab Signed-off-by: Boaz Shuster <[email protected]>
commit sha 03f69d0971d8ad2a0a2b7e54fdfce643b6a0fe1d
Switch path from hybrid to cost-management Fixes https://github.com/project-koku/koku-ui/issues/1066
commit sha 94494502fabe85e5229666ab5b2e8745d84e963e
Merge pull request #1067 from dlabrecq/1066-hybrid-path Switch path from hybrid to cost-management
commit sha 817db50a79b65a2fa7621204a17a28a94057bbe2
Merge pull request #1068 from boaz0/closes_1052 fix(onboarding): incomplete commands for contrab
push time in 21 days
PR opened patternfly/patternfly-react
What:
closes #3116
I added the triggers prop to modify the trigger option passed to TippsyJS.
Please notice that if you set isVisible this props is irrelevant since you are the one who manages when to display the popover and thus you will have to implement those triggers or catch those events and mutate the state that determines whether to display or hide the popover.
//cc @jotak
pr created time in 21 days
push eventboaz0/patternfly-react
commit sha d6da7d3ae1bf1e4bff6623607da03f9872f006ef
feat(popover): allow to set popover trigger Signed-off-by: Boaz Shuster <[email protected]>
push time in 21 days
push eventboaz0/patternfly-react
commit sha 7522b53d0d7136c2fe23a47af0e5f79955534129
feat(popover): allow to set popover trigger Signed-off-by: Boaz Shuster <[email protected]>
push time in 21 days
pull request commentpatternfly/patternfly-react
fix(Select): set onFilter to null to run the default filter
Thank you all :cat:
comment created time in 21 days
issue openedpatternfly/patternfly-react
Docs: update PaginationToolbar demo to include empty state and spinner
Add to the pagination toolbar demo spinner instead of just displaying the "Loading" text. In addition, add the empty state component in case no data is shown.
created time in 21 days
create barnchboaz0/patternfly-react
branch : closes_bug_with_datalist_check
created branch time in 21 days
create barnchboaz0/patternfly-react
branch : update_demo_pagination_toolbar
created branch time in 21 days
push eventboaz0/patternfly-react
commit sha 9c341c871bf5cf0f495672024e7ec87579261ff5
react followup (#3164) * react followup * bump yarn.lock * bump versions * update pf3 snapshots
commit sha 570e79cebec116811be31b63ede7f2563ab8bc35
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha dbff0f181a2bd6fd763fb6769e8f9ef49281178d
Fix warnings about use of deprecated lifecycle methods (#3098) The above fixes where done automatically with: $ npx react-codemod rename-unsafe-lifecycles
commit sha b89f1d3b2357b1ed9c2a872cef600aff86adad60
fix(copytoclipboard): wrap pre inside the expand element (#3169) Signed-off-by: Boaz Shuster <[email protected]>
commit sha 27837bd7fa16aaa94aa3ccec49915c95e47d46e5
chore(release): releasing packages [ci skip] - [email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 375b6880d8737c9b71afc19199fcfb984fea5e70
chore(emptyState): remove debug message from tests (#3161) Signed-off-by: Boaz Shuster <[email protected]>
commit sha c68175187138fc0777cd256bf688ef3afe889881
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 22 days
PR opened project-koku/koku-ui
closes #1052
@lcouzens & @dayleparker can you confirm?
Thanks.
pr created time in 22 days
pull request commentproject-koku/koku-ui
Switch path from hybrid to cost-management
@ryelo - I can't navigate to settings. It redirects me to overview page.
comment created time in 22 days
delete branch boaz0/patternfly-react
delete branch : remove_debug_from_empty_state_test
delete time in 23 days
pull request commentpatternfly/patternfly-react
fix(copytoclipboard): wrap pre inside the expand element
Thank you all!
comment created time in 23 days
issue commentpatternfly/patternfly-react
fix(tab): fix and document forwardRef type of Tab
@SpyTec is this still happening in the new release?
comment created time in 23 days
PR opened patternfly/patternfly-react
What:
closes #3163
//cc @christiemolloy @jessiehuff @jenny-s51
pr created time in 24 days
PR opened patternfly/patternfly-react
What:
closes #3153
- I had to update the tests because of enzyme snapshot (TextInput -> ForwardRef)
- I added an example for react-hook-form. I am not sure we should have it.
- I added
withInnerRefto the helpers directory. This will make it easier to add support torefin other component.
//cc @kmcfaul @ia3andy
pr created time in 24 days
push eventboaz0/patternfly-react
commit sha 6e89ebe31cfffabe216c494e57974322f4dda497
fix(table): set height auto modifier on table row (#3133) Signed-off-by: Boaz Shuster <[email protected]> Co-authored-by: Jenny Shandelman <[email protected]>
commit sha 8500ed5f28325d8317d8570b43effdca5878adf3
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 07de08db5166406bd79d2d3e68d37c14e575f28c
fix(OUIA): Use consumer context if specified (#3149)
commit sha 3a965e4399ad6e9780b44e4778a796afdf50b6c0
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
commit sha 93c843b735d0c352524bc181c3890ce095fd951a
feat(docs): use gatsby-theme-patternfly-org (#3146) * replace '## (.*)\njs title=' in md files * chore(docs): replaced spaces with dashes in MD files where js title=Title with spaces * examples are rendering * Add ## Examples for table of contents * add example titles * bump plugin * fix(docs): created example folders for all components & updated scss to css. Fixed Wizard examples not rendering and typo in Input Group Basic example * added title with withOuia and hiddenPages to gatsby-config * Moved experimental docs into examples directories * fix build in patternfly-react * fix theme * Update component titles * Update titles in layout, experimental, etc * Missed one file * Switch and Text update * fix copyStyles for submodule in submodule * don't let gatsby use eslint * bump theme version * fix PageLayout demos * fix icons page * bump versions * bump yarn.lock * Refactor chart docs for new theme * chore(docs): fixed hyphenated titles and converted scss to css for layouts and topology * charts titles, remove sass * Chart content consistency * bump theme * fix script syntax * tweak upload script * Remove missing prop components * Update ChartBullet.md * use good gatsby+react version
commit sha 5447bb9686f8d760750ae6f7065b9960bbc889d8
chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
push time in 25 days
issue openedpatternfly/patternfly-react
Select: Typeahead (multi/single) doesn't filter options
The problem is the follwoing: When typing in the input box the options that are relative to what I'm entering are not shown.
For example, go to https://patternfly-react.surge.sh/patternfly-4/documentation/react/components/select and scroll down to the Typeahead example. Then click on the input box, you will see option menu. Type "A" but the options "New Jersey", "New Mexico", "New York" and etc are still shown even though they don't have A in them.
//cc @dlabaj @dlabrecq
created time in 25 days
PR opened patternfly/patternfly-react
What:
small nitpick - removing unnecessary debug log in the empty state tests (that I added and forgot to remove :scream: )
pr created time in a month
create barnchboaz0/patternfly-react
branch : remove_debug_from_empty_state_test
created branch time in a month
push eventboaz0/patternfly-react
commit sha 749c38d51c90c2aaf9fee1de242b2f29f1ffd05c
fix(Select): display typeahead filtered options - set onFilter to null to run the default filter - pass 'this.onClick' to inputs to avoid reseting options Signed-off-by: Boaz Shuster <[email protected]>
push time in a month
push eventboaz0/patternfly-react
commit sha 58710aff4706fcb2b34d720b3ebfe83e99192f22
fix(Select): display typeahead filtered options - set onFilter to null to run the default filter - pass 'this.onClick' to inputs to avoid reseting options Signed-off-by: Boaz Shuster <[email protected]>
push time in a month
pull request commentpatternfly/patternfly-react
fix(Select): set onFilter to null to run the default filter
@dlabrecq good catch. I think I fixed it here too - I just passed this.onClick to the input box and that worked
comment created time in a month