profile
viewpoint

bancorprotocol/contracts-solidity 649

Bancor Protocol Contracts

bancorprotocol/contracts_eos 103

Bancor Protocol Contracts for EOS

bancorprotocol/gov-contracts 1

Bancor Governance contracts

barakman/Relay 1

Synchronize (relay messages) between a Slack channel and a Telegram room

barakman/Spline 1

Cubic Spline Interpolation

bancorprotocol/airhodl 0

AirHodl (extending https://github.com/bancorprotocol/contracts)

bancorprotocol/openzeppelin-test-environment 0

One-line setup for blazing-fast smart contracts tests

Pull request review commentbancorprotocol/contracts-solidity

Add static-pool

+// SPDX-License-Identifier: SEE LICENSE IN LICENSE+pragma solidity 0.6.12;++import "../standard-pool/StandardPoolConverter.sol";++/**+ * @dev This contract is a specialized version of the converter, which is

missing dedicated comment

barakman

comment created time in 5 days

create barnchbancorprotocol/contracts-solidity

branch : 0.6.30

created branch time in 5 days

delete branch bancorprotocol/contracts-solidity

delete branch : 0.6.30

delete time in 5 days

push eventbancorprotocol/docs

Avi Kaner

commit sha 28edb641aace05e01b6c40b77aadf64980b5a8b5

GitBook: [master] one page modified

view details

push time in 6 days

push eventbancorprotocol/docs

Avi Kaner

commit sha 43e747df6097588a1f0c8e0e4a0b5e7020611390

GitBook: [master] one page modified

view details

push time in 6 days

push eventbancorprotocol/docs

Avi Kaner

commit sha 4314d24f616b19c5bc0ed98a5a04754f9a80f582

GitBook: [master] one page modified

view details

push time in 6 days

push eventbancorprotocol/contracts-solidity

yudilevi

commit sha 23b5ebad9ed86bf19b072cd9e077146a4b344900

removed liquidity protection store/stats from the registry in the test deployment script

view details

push time in 8 days

created tagbancorprotocol/contracts-solidity

tagv0.6.29

Bancor Protocol Contracts

created time in 8 days

push eventbancorprotocol/contracts-solidity

yudilevi

commit sha d570c150cccf34591f34e385b15a0fc21e71a7c1

0.6.29

view details

push time in 8 days

delete branch bancorprotocol/contracts-solidity

delete branch : 0.6.29

delete time in 8 days

push eventbancorprotocol/contracts-solidity

Leonid Beder

commit sha 88479f5fedb81acb5ab4332f6206d860914f6171

Prepare for integration with LM contracts

view details

Leonid Beder

commit sha d76210dc9320433b0555941d88de1116a0f8c7e3

Merge pull request #513 from bancorprotocol/integration Prepare for integration with LM contracts

view details

barakman

commit sha ecbcd621a1309741f62729a306a544d49eff3fcf

Add liquidity-protection statistics contract.

view details

barakman

commit sha 4af8090ab20e1671ceeb7a4c81bc721807943312

Migration infrastructure.

view details

barakman

commit sha 06e8bed7b367adf2fded1bb0d4d092b3671620ff

Migration infrastructure.

view details

barakman

commit sha 243d8467cc0d294b3652ae9da35f5e2490de1177

Improve stats_migration.js.

view details

barakman

commit sha 55c05fde16d9473f8a7e857a5f52945691ef85ad

Fix stats_migration.js.

view details

barakman

commit sha e09875f9d1617ccfb596f3c69f7f950b296d4764

Fix function `LiquidityProtection.removeLiquidity`.

view details

barakman

commit sha ceec3469b7a975eda9acf206b6a77568bedce5c7

Add provider pool tokens.

view details

barakman

commit sha 3541d95654f24375758158d9e7148770ab8b28f2

Fix previous commit.

view details

barakman

commit sha fa66b06911916682593cec131ed586516f9837cc

Extend documentation.

view details

barakman

commit sha a08aee0eb496649099ff7bca62298f27c40a66dc

Pretty cosmetic.

view details

barakman

commit sha 9eb92cc68eb97bd34f41fd5882dec2c3984f8f86

Seed provider pools.

view details

barakman

commit sha 3ea87f98277fcfd97922c1f6b217a1f9f099f915

Add LiquidityProtectionStats.js.

view details

barakman

commit sha 67c6a5850eea05a8444d289114b4b05148bbb99c

Add getter functions.

view details

barakman

commit sha 133a847cbfb1a5f8073a7f8f8d32ed5bba6f1994

Improve documentation.

view details

barakman

commit sha df3f11e5d46c9118fd138014ff7a11aad851f68e

Fix coding conventions.

view details

barakman

commit sha 9390d27ce5fd80839052cd75108879585e571fcf

Improve documentation.

view details

barakman

commit sha f4dde2f301f7973bf6f24c9f6b0136d36e7da041

Improve documentation.

view details

barakman

commit sha 7b52cd5366a830a88709247c85b6f887a230a358

Add LiquidityProtection interface.

view details

push time in 8 days

push eventbancorprotocol/contracts-solidity

yudilevi

commit sha 3019ac1e6541650883a9d7902920b558dae91651

updated changelog

view details

push time in 8 days

PR opened bancorprotocol/contracts-solidity

0.6.29
+2288 -436

0 comment

41 changed files

pr created time in 8 days

delete branch bancorprotocol/contracts-solidity

delete branch : minor_fix_in_stats_contract

delete time in 8 days

push eventbancorprotocol/contracts-solidity

barakman

commit sha 72c21c876d9b04a5ce8a8bdb4edad9e13665694b

Remove the `Utils` functionality from the `LiquidityProtectionStats` contract.

view details

Yudi Levi

commit sha 393d8add83f641d05a9f375dba864f738a98f6fc

Merge pull request #520 from bancorprotocol/minor_fix_in_stats_contract Remove the `Utils` functionality from the `LiquidityProtectionStats` contract

view details

push time in 8 days

Pull request review commentbancorprotocol/contracts-solidity

Seed provider pools

 contract LiquidityProtectionStats is ILiquidityProtectionStats, AccessControl, U         IERC20Token[] calldata reserves,         uint256[] calldata amounts     ) external seederOnly {-        uint256 length = tokens.length;+        uint256 length = providers.length;         for (uint256 i = 0; i < length; i++) {             _totalProviderAmounts[providers[i]][tokens[i]][reserves[i]] = amounts[i];+        }+    }++    /**+     * @dev seeds the list of pools per liquidity provider+     * can only be executed only by a seeder+     *+     * @param providers liquidity provider addresses+     * @param tokens    pool token addresses+     */+    function seedProviderPools(+        address[] calldata providers,+        IDSToken[] calldata tokens

tokens -> pools

barakman

comment created time in 10 days

delete branch bancorprotocol/contracts-solidity

delete branch : fix_totalProviderAmounts

delete time in 11 days

push eventbancorprotocol/contracts-solidity

barakman

commit sha 524b7e41bdabbf1c0b062352ade523247fd53f94

Prettify stats_verification.js.

view details

barakman

commit sha b3a5bcc48cd2defcacdbfcb12446b53ccd151df5

Move role-renouncing to a separate script.

view details

barakman

commit sha c516069338c0fe5b7d30293c04b0dbcfa67eed39

Change the `totalProviderAmount` table from `poolToken, reserveToken, provider` to `provider, poolToken, reserveToken`.

view details

barakman

commit sha 232a1a4b28e19871d370e152db1f4e32adaaa77d

Prettify LiquidityProtectionStats.sol.

view details

barakman

commit sha fd7872677a8cf3c3892c58b441aa68cab64fff14

Fix stats_conclusion.js.

view details

Yudi Levi

commit sha 6d041cf68d9b1c6a2cf90c878e336d5a855ac88b

Merge pull request #518 from bancorprotocol/fix_totalProviderAmounts Fix total provider amounts

view details

push time in 11 days

PR merged bancorprotocol/contracts-solidity

Fix total provider amounts
  1. Move role-renouncing to a separate script.
  2. Change the totalProviderAmount table from poolToken, reserveToken, provider to provider, poolToken, reserveToken.
+142 -38

0 comment

6 changed files

barakman

pr closed time in 11 days

delete branch bancorprotocol/contracts-solidity

delete branch : integration

delete time in 12 days

push eventbancorprotocol/contracts-solidity

Leonid Beder

commit sha 3766995a835178b4b98a6c707456147d9da3e673

Remove OZ conflicts + refactor

view details

Leonid Beder

commit sha 616560bcec7d87e8f09ace19bc01510d3cb69e68

Merge branch 'liquidity_protection_statistics' into integration

view details

Leonid Beder

commit sha 509eaaf94ab8f3db656ed306cd7579655bb66028

Refactor

view details

Leonid Beder

commit sha f80e583586b86234fdb8ecfb883ad21ac4499409

Fix tests

view details

Leonid Beder

commit sha 99085a876041ce98ede21bdaa84aa9ba371eaa37

Add LP notifications

view details

Leonid Beder

commit sha 0aadf05ef481a5c25a93b133090fffdeecafe461

Update eslint

view details

Leonid Beder

commit sha 2471174859c741c798ea20987d0cedb996aee828

Merge branch '0.6.29' into integration # Conflicts: # solidity/contracts/liquidity-protection/LiquidityProtection.sol # solidity/contracts/liquidity-protection/LiquidityProtectionStats.sol # solidity/test/LiquidityProtection.js

view details

Leonid Beder

commit sha cb8de4346e594fc5c28ff0704c82d11d30813efe

Trigger onRemovingLiquidity before the actual liquidity is removed

view details

Leonid Beder

commit sha 2fe25c79b73fe32043219dbcfbd68224691dc2bb

Merge pull request #516 from bancorprotocol/integration LP notifications and preparation for integration

view details

push time in 12 days

PR merged bancorprotocol/contracts-solidity

Reviewers
LP notifications and preparation for integration

This PR contains the following changes:

  1. Making the project integrable with other projects.
  2. Replace internal SafeMath with OZ and rename Math to MathEx in order to prevent conflict with the LM repo.
  3. Add LP notifications.
  4. Missing formatting (for some reason).
+527 -313

0 comment

25 changed files

lbeder

pr closed time in 12 days

push eventbancorprotocol/contracts-solidity

Leonid Beder

commit sha cb8de4346e594fc5c28ff0704c82d11d30813efe

Trigger onRemovingLiquidity before the actual liquidity is removed

view details

push time in 12 days

Pull request review commentbancorprotocol/contracts-solidity

LP notifications and preparation for integration

 contract LiquidityProtection is ILiquidityProtection, TokenHandler, Utils, Owned             );         } +        // notify event subscribers+        if (address(eventsSubscriber) != address(0)) {

Hmmm... it'd be cleaner to move it before the liquidity is removed, although it won't affect the current implementation

lbeder

comment created time in 12 days

Pull request review commentbancorprotocol/contracts-solidity

LP notifications and preparation for integration

 contract LiquidityProtection is ILiquidityProtection, TokenHandler, Utils, Owned         uint256 _poolAmount,         uint256 _reserveAmount     ) internal returns (uint256) {+        // notify event subscribers+        if (address(eventsSubscriber) != address(0)) {

It doesn't, since its major goal is to only "sync" the previous state

lbeder

comment created time in 12 days

Pull request review commentbancorprotocol/contracts-solidity

LP notifications and preparation for integration

 contract LiquidityProtection is ILiquidityProtection, TokenHandler, Utils, Owned         uint256 _poolAmount,         uint256 _reserveAmount     ) internal returns (uint256) {+        // notify event subscribers+        if (address(eventsSubscriber) != address(0)) {

called before provider pool is set - does it not need to know the provider has liquidity in that pool at this point?

lbeder

comment created time in 12 days

Pull request review commentbancorprotocol/contracts-solidity

LP notifications and preparation for integration

 contract LiquidityProtection is ILiquidityProtection, TokenHandler, Utils, Owned             );         } +        // notify event subscribers+        if (address(eventsSubscriber) != address(0)) {

called after removing liquidity (but before stats are updated) - intentional?

lbeder

comment created time in 12 days

push eventbancorprotocol/contracts-solidity

barakman

commit sha dd69a44b18250412cf29dee61264882d3bb62cd0

Revert "Revert "Prettify all files affected in this PR."" This reverts commit 7bb2a2506f4f5e4ea34e98f8fd0d441cd28b14a8.

view details

barakman

commit sha 78603a98d60c75d19f545257185e160a67e84cf5

Cosmetic (fix some private variable names).

view details

barakman

commit sha 313cea61f994542096afbc233bc76a090a02eb8e

Switch to OZ's SafeMath.

view details

barakman

commit sha ed968777ed211c11313db21208bd29e23237591b

Improve coding.

view details

barakman

commit sha d90c9d2103653657eb445b2477fd6c36edbec6bd

Reduce byte-code size.

view details

Yudi Levi

commit sha 149a0a8c77a4348413e2f041bda00069859caaac

Merge pull request #515 from bancorprotocol/liquidity_protection_statistics Liquidity Protection Statistics

view details

Leonid Beder

commit sha 2471174859c741c798ea20987d0cedb996aee828

Merge branch '0.6.29' into integration # Conflicts: # solidity/contracts/liquidity-protection/LiquidityProtection.sol # solidity/contracts/liquidity-protection/LiquidityProtectionStats.sol # solidity/test/LiquidityProtection.js

view details

push time in 12 days

more