profile
viewpoint

bantic/acts-as-rated 2

git svn clone of acts-as-rated

bantic/all-html 2

Insipred by http://all-html.net/

bantic/backbone-koans-done 2

A set of jasmine powered koans for learning Backbone.js.

bantic/aws-s3 1

AWS-S3 is a Ruby implementation of Amazon's S3 REST API

bantic/bookkeeper 1

automatically add books to your NYPL request queue

bantic/bootstrap 1

HTML, CSS, and JS toolkit from Twitter

bantic/chatty 1

command-line contact and emailer for gmail

bantic/chess-engine 1

A Chess Engine in Ruby

issue closedVestorly/torii

Popup not working in Edge

Using Edge on Windows 10, torii seems to have problems when using the auth popup.

I'm seeing an instant remote could not open or was closed error then the popup opens full screen, it's possible to go through the flow in the new window but Edge will warn about the window being closed and doesn't seem to communicate back to the app.

The only other mention of issues in Edge I can find is a comment on a closed issue here https://github.com/Vestorly/torii/issues/63#issuecomment-278135077

closed time in 20 hours

kevinansfield

startedalbertz/grub-fuse

started time in a day

startedsignalapp/Signal-iOS

started time in 2 days

startedDimillian/RedditOS

started time in 2 days

PR opened Addepar/ember-table

Use scrollLeft to detect when scroll indicators should appear

If the table element has a negative margin-left style, the left scroll indicator will always show, even when scrolled all the way to the left. This negative margin trick is commonly used in conjunction with border-spacing and an overflow element in order to eliminate leading whitespace in the leftmost column of a table (border-spacing cannot be overridden at a cell level).

By examining scrollLeft instead of the bounding box positions of the table & overflow elements, the same effect is achieved without making any assumptions about the relative positions of elements.

+55 -47

0 comment

2 changed files

pr created time in 3 days

pull request commentAddepar/ember-table

Add selectionMatchFunction option

@mixonic I have not yet done that and it fell off my radar. I'll try to carve out some time to get back to that this week.

kpfefferle

comment created time in 5 days

issue commentAddepar/ember-table

clarify license terms?

@mixonic Thank you ++ The FOSS license nerd in me is now happy :bow: <plug> FWIW I had found this in a license scan with https://github.com/nexB/scancode-toolkit </plug>

pombredanne

comment created time in 5 days

issue closedAddepar/ember-table

clarify license terms?

The license here is MIT https://github.com/Addepar/ember-table/blob/70d09600c0032f19cad1f62c050cde2d993e8365/package.json#L8 And here this is more or less a truncated BSD-3-Clause https://github.com/Addepar/ember-table/blob/70d09600c0032f19cad1f62c050cde2d993e8365/LICENSE.md (See https://opensource.org/licenses/BSD-3-Clause )

It would be great if there could be a bit more clarity in the licenses and a standard license text. Thanks!

closed time in 5 days

pombredanne

issue commentAddepar/ember-table

clarify license terms?

Resolved by https://github.com/Addepar/ember-table/pull/850 in our 3.0-beta branch.

pombredanne

comment created time in 5 days

issue closedAddepar/ember-table

3.0-beta branch is missing commit for 3.0.0-4

The 3.0-beta branch is missing the update to package.json for the version.

closed time in 5 days

mixonic

issue commentAddepar/ember-table

3.0-beta branch is missing commit for 3.0.0-4

Fixed https://github.com/Addepar/ember-table/commits/3.0-beta

mixonic

comment created time in 5 days

push eventAddepar/ember-table

Alex Navasardyan

commit sha 9fae16aa93318eb2a8a3647951904072ebf9a79d

3.0.0-4

view details

push time in 5 days

push eventAddepar/ember-table

Matthew Beale

commit sha 769a8404b1fe36afe2f6f19b0552182f95e7d3ba

Repair license file, correct metadata (#850) The LICENSE.md file was corrupted during an Ember version update in: * https://github.com/Addepar/ember-table/commit/48939919044baa2c71f360b1be13915c472360d9#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1d Additionally the `package.json` has been out of date, claiming MIT license, since the original change to BSD-3 in: * https://github.com/Addepar/ember-table/commit/e7ce9930fef36ffc32940ebf1d46fc76dcbe11bf#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1d This corrects those errors, with re-approval from Addepar legal on 2021-01-10.

view details

push time in 5 days

PR merged Addepar/ember-table

Reviewers
Repair license file, correct metadata 3.0

The LICENSE.md file was corrupted during an Ember version update in:

  • https://github.com/Addepar/ember-table/commit/48939919044baa2c71f360b1be13915c472360d9#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1d

Additionally the package.json has been out of date, claiming MIT license, since the original change to BSD-3 in:

  • https://github.com/Addepar/ember-table/commit/e7ce9930fef36ffc32940ebf1d46fc76dcbe11bf#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1d

This corrects those errors, with re-approval from Addepar legal on 2021-01-10.

Fixes https://github.com/Addepar/ember-table/issues/836

+5 -2

0 comment

2 changed files

mixonic

pr closed time in 5 days

PR opened Addepar/ember-table

Minimize CPs for ember-tr

Rebase of https://github.com/Addepar/ember-table/pull/691 onto 3.0-beta

+63 -82

0 comment

5 changed files

pr created time in 5 days

pull request commentAddepar/ember-table

avoid sendAction when possible

The non-1.13 branch of this code is likely what should land into the 3.0-beta branch before the final 3.0 is cut. I'm not sure this will end up as the PR, but flagged it 3.0 regardless since it should be addressed by then.

juanazam

comment created time in 5 days

pull request commentAddepar/ember-table

Deprecations/send action

I flagged this as 3.0 since we should certainly resolve the concern, however I think the non-1.13 branch of https://github.com/Addepar/ember-table/pull/825 is probably closer to the final patch.

billybonks

comment created time in 5 days

issue openedAddepar/ember-table

3.0-beta branch is missing commit for 3.0.0-4

The 3.0-beta branch is missing the update to package.json for the version.

created time in 5 days

PR opened Addepar/ember-table

Repair license file, correct metadata

The LICENSE.md file was corrupted during an Ember version update in:

  • https://github.com/Addepar/ember-table/commit/48939919044baa2c71f360b1be13915c472360d9#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1d

Additionally the package.json has been out of date, claiming MIT license, since the original change to BSD-3 in:

  • https://github.com/Addepar/ember-table/commit/e7ce9930fef36ffc32940ebf1d46fc76dcbe11bf#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1d

This corrects those errors, with re-approval from Addepar legal on 2021-01-10.

Fixes https://github.com/Addepar/ember-table/issues/836

+5 -2

0 comment

2 changed files

pr created time in 5 days

issue commentAddepar/ember-table

clarify license terms?

Agreed, it looks like in https://github.com/Addepar/ember-table/commit/48939919044baa2c71f360b1be13915c472360d9#diff-4673a3aba01813b595de187a7a6e9e63a3491d55821606fecd9f13a10c188a1dL1 there was a fat-finger which removed a pretty critical line of text from the license. I'll confirm with Addepar legal (as the copyright holders).

pombredanne

comment created time in 6 days

delete branch Addepar/ember-table

delete branch : bantic/fix-v2-floating-deps-tests

delete time in 6 days

push eventAddepar/ember-table

NullVoxPopuli

commit sha 44bb447ad4091d914587b6d4ce4efb0e96516c6f

Ember 2.4+ does not need the assign polyfill (#848)

view details

push time in 6 days

pull request commentAddepar/ember-table

Ember 2.4+ does not need the assign polyfill

The only use of assign in Ember Table is Object.assign. So, I'm really not even sure what this dependency is doing. Certainly on our supported browsers it is doing nothing. Merging this.

NullVoxPopuli

comment created time in 6 days

pull request commentAddepar/ember-table

[CI] run tests against Firefox

Closing this as stale in favor of https://github.com/Addepar/ember-table/pull/831

jelhan

comment created time in 6 days

PR closed Addepar/ember-table

[tests] Fix "Floating Dependencies" tests

Pin whatwg-fetch dependency to '3.3.1'.

This fixes an error fetch is not defined - maybe your browser targets are not covering everything you need? that shows up when running the tests for the floating dependencies stage.

That error comes from ember-fetch, see ember-cli/ember-fetch#547

+30 -6

1 comment

2 changed files

bantic

pr closed time in 6 days

pull request commentAddepar/ember-table

[tests] Fix "Floating Dependencies" tests

Closing in favor of 3.0-beta https://github.com/Addepar/ember-table/pull/831

bantic

comment created time in 6 days

PR closed Addepar/ember-table

Add 2.12 to the travis suite

It was missing

+1 -0

1 comment

1 changed file

mixonic

pr closed time in 6 days

pull request commentAddepar/ember-table

Add 2.12 to the travis suite

Closing in favor of 3.0-beta https://github.com/Addepar/ember-table/pull/831

mixonic

comment created time in 6 days

more