apaleslimghost ( Kara Brightwell )

fork apaleslimghost/doom-emacs

An Emacs framework for the stubborn martian hacker

hlissner/doom-emacs apaleslimghost/doom-emacs

fork in 14 hours

create barnchapaleslimghost/fledgling

branch : main

created branch time in 2 days

created repositoryapaleslimghost/fledgling

created time in 2 days

issue openedjorgebucaran/fish-nvm

always installs latest version

no matter what version i ask for, nvm ignores it and installs 14.7. i installed it with Fundle. am i doing something wrong?

~ ⟩ nvm use 10
fetching https://nodejs.org/dist/v14.7.0/node-v14.7.0-darwin-x64
#########                                                    7.9%^C⏎

~ ⟩ nvm use 10.22.0
fetching https://nodejs.org/dist/v14.7.0/node-v14.7.0-darwin-x64
#########                                                    7.9%^C⏎

~ ⟩ nvm use dubnium
fetching https://nodejs.org/dist/v14.7.0/node-v14.7.0-darwin-x64
#########                                                    7.7%^C⏎

~ ⟩ echo 10.22.0 > .nvmrc

~ ⟩ nvm
fetching https://nodejs.org/dist/v14.7.0/node-v14.7.0-darwin-x64
#########                                                    7.7%^C

created time in 3 days

Pull request review commentFinancial-Times/n-heroku-tools

chore(scripts): update script generator and readme template

+# n-heroku-tools (nht) [![CircleCI](https://circleci.com/gh/Financial-Times/n-heroku-tools.svg?style=svg&circle-token=33bcf2eb98fe2e875cc66de93d7e4a50369c952d)](https://circleci.com/gh/Financial-Times/n-heroku-tools)

maybe rename this file so it's clearer it's a template?

antonsamper

comment created time in 5 days

Pull request review commentFinancial-Times/x-dash

work-in-progress: x-live-blog-wrapper

+// TODO: parsing posts will not be needed when we use v2 route on next-live-events-api+const parsePost = (event) => {+	const post = JSON.parse(event.data);++	if (!post || !post.mid || !post.textrendered) {+		return;+	}++	const textElement = document.createElement('div');+	textElement.innerHTML = post.textrendered;++	const titleElement = textElement.querySelector('p strong');+	const breakingNewsElement = textElement.querySelector('img[src*="breaking_news.gif"]');+	const isBreakingNews = Boolean(breakingNewsElement);++	if (isBreakingNews) {+		textElement.removeChild(breakingNewsElement.parentNode);+	}++	textElement.removeChild(titleElement.parentNode);++	const content = textElement.innerHTML.trim();+	const title = titleElement.textContent;+	const publishedTimestamp = (new Date(Number(post.emb) * 1000)).toISOString();++	return {+		postId: post.mid,+		author: post.authordisplayname,+		publishedTimestamp,+		isBreakingNews,+		isKeyEvent: Boolean(post.keytext),+		title,+		content+	};+};++const dispatchLiveUpdateEvent = (eventType, data) => {+	// consumer app will need to consume this event after the component is rendered. therefore,+	// we defer dispatching of this event.+	window.setTimeout(() => document.dispatchEvent(new CustomEvent(eventType, { detail: data })), 0);

please don't dispatch global events from x-dash components. if this component is used in ft-app, they way it renders article pages means up to 3 instances of this component could be on the page at once, because of preloaded swipe panes. it looks like you should be able to use x-interaction for this use case though?

tbergmen

comment created time in 5 days

Pull request review commentFinancial-Times/x-dash

work-in-progress: x-live-blog-wrapper

+import { h, Fragment } from '@financial-times/x-engine';+import { LiveBlogWrapper } from "./LiveBlogWrapper";+import { Serialiser, HydrationData } from '@financial-times/x-interaction';+import { listenToLiveBlogEvents } from './LiveEventListener';++const HydratedLiveBlogWrapper = (props) => {+	const serialiser = new Serialiser();++	return (+		<Fragment>+			<LiveBlogWrapper {...props} serialiser={serialiser} />+			<HydrationData serialiser={serialiser} />+		</Fragment>

i'd originally intended that using the serialiser would be left for the consuming app, since you might want to reuse the same serialiser for multiple components to reduce the output, and you might have particular requirements for where the HydrationData gets output

also i don't know if we need to think coordinating this with the various Page Kit components that output server data; x-interaction predates Page Kit and the hydration stuff hasn't been used in production yet

happy to chat further about this! 🙂

tbergmen

comment created time in 5 days

issue openedorogene/orogene

pain point: no control over version resolution

for projects like internal design systems that are distributed as multiple modules, being able to control which versions are used is very important. you don't want different components to be able to load e.g. different versions of the buttons component they both depend on, from a visual consistency and a CSS size point of view.

we're currently solving this by using both Bower (so we can force single installed versions) and NPM, which isn't ideal. being able to use a single tool for dependencies would simplify our workflow. this probably goes hand-in-hand with #22 because you might want different resolution strategies for different package sets

created time in 6 days

Pull request review commentFinancial-Times/n-gage

Remove deploy hashed assets deploy step

 module.exports = { 	files: { 		allow: [ 			'dotfiles/.stylelintrc',+			'dotfiles/.editorconfig',

🤔 weird this wasn't needed before

nickcolley

comment created time in 12 days

issue openedFinancial-Times/athloi

readme does not explain "cross-dependencies" or "topological order"

these terms are quite jargony and confusing to a newcomer
this also means the readme doesn't adequately explain how to set up your monorepo to work with athloi (i.e. using file: version specifiers in the package.json)

created time in 12 days

push eventFinancial-Times/nori

dependabot[bot]

commit sha fb22e09431d41fd27839013a4b919eb11854b65e

Bump lodash from 4.17.14 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19) Signed-off-by: dependabot[bot] <[email protected]>