profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/aodhgan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

pooltogether/loot-box-subgraph 2

Subgraph for Loot Box

aodhgan/beacon-schematic 0

Schematic of the Ethereum 2.0 Beacon Chain specification

aodhgan/code423n4.com 0

code423n4.com source code

aodhgan/defender-docs 0

Security Management to Protect the Open Economy

aodhgan/endaoment 0

🍶An Interest Earning, Money Streaming, DeFi Enabled DAO

aodhgan/go-ethereum 0

Official Go implementation of the Ethereum protocol

pooltogether/pooltogether-prizestrategy-upkeep 0

Contracts that provide automation of prize pool award functions

push eventpooltogether/uniform-random-number

Aodhgan

commit sha 2c69969affc20a458af92b876a697d0bacada102

update publish hooks

view details

push time in 2 days

push eventpooltogether/uniform-random-number

Aodhgan

commit sha 77b7733499edf5ac1572014c4df062d64325119d

no variable

view details

push time in 2 days

push eventpooltogether/uniform-random-number

dependabot[bot]

commit sha cf7b2c9422db73274f0f3f2878eae1796135aba6

Bump kind-of from 6.0.2 to 6.0.3 Bumps [kind-of](https://github.com/jonschlinkert/kind-of) from 6.0.2 to 6.0.3. - [Release notes](https://github.com/jonschlinkert/kind-of/releases) - [Changelog](https://github.com/jonschlinkert/kind-of/blob/master/CHANGELOG.md) - [Commits](https://github.com/jonschlinkert/kind-of/compare/6.0.2...6.0.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

aodhgan

commit sha 789a8f1e12d16a7feb7d28ee651934a80d8d9889

Merge pull request #3 from pooltogether/dependabot/npm_and_yarn/kind-of-6.0.3 Bump kind-of from 6.0.2 to 6.0.3

view details

push time in 2 days

PR merged pooltogether/uniform-random-number

Bump kind-of from 6.0.2 to 6.0.3 dependencies

Bumps kind-of from 6.0.2 to 6.0.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/jonschlinkert/kind-of/blob/master/CHANGELOG.md">kind-of's changelog</a>.</em></p> <blockquote> <h2>[6.0.3] - 2020-01-16</h2> <ul> <li>Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/31">#31</a> for issue <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/30">#30</a></li> </ul> <h2>[6.0.0] - 2017-10-13</h2> <ul> <li>refactor code to be more performant</li> <li>refactor benchmarks</li> </ul> <h2>[5.1.0] - 2017-10-13</h2> <p><strong>Added</strong></p> <ul> <li>Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/15">#15</a> from aretecode/patch-1</li> <li>adds support and tests for string & array iterators</li> </ul> <p><strong>Changed</strong></p> <ul> <li>updates benchmarks</li> </ul> <h2>[5.0.2] - 2017-08-02</h2> <ul> <li>Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/14">#14</a> from struct78/master</li> <li>Added <code>undefined</code> check</li> </ul> <h2>[5.0.0] - 2017-06-21</h2> <ul> <li>Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/12">#12</a> from aretecode/iterator</li> <li>Set Iterator + Map Iterator</li> <li>streamline <code>isbuffer</code>, minor edits</li> </ul> <h2>[4.0.0] - 2017-05-19</h2> <ul> <li>Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/8">#8</a> from tunnckoCore/master</li> <li>update deps</li> </ul> <h2>[3.2.2] - 2017-05-16</h2> <ul> <li>fix version</li> </ul> <h2>[3.2.1] - 2017-05-16</h2> <ul> <li>add browserify</li> </ul> <h2>[3.2.0] - 2017-04-25</h2> <ul> <li>Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/10">#10</a> from ksheedlo/unrequire-buffer</li> <li>add <code>promise</code> support and tests</li> <li>Remove unnecessary <code>Buffer</code> check</li> </ul> </tr></table> ... (truncated) </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/jonschlinkert/kind-of/commit/abab085d65f7ee978011da8f135291892fcd97db"><code>abab085</code></a> 6.0.3</li> <li><a href="https://github.com/jonschlinkert/kind-of/commit/a18459cd92a793987ceec2cdf7dfee90d7961d92"><code>a18459c</code></a> run verb to generate README documentation</li> <li><a href="https://github.com/jonschlinkert/kind-of/commit/dc6bea5c4eb25f56d2e3d27f194824667784ed21"><code>dc6bea5</code></a> only need to check <code>typeof val.constructor</code></li> <li><a href="https://github.com/jonschlinkert/kind-of/commit/1df992ce6d5a1292048e5fe9c52c5382f941ee0b"><code>1df992c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/jonschlinkert/kind-of/issues/31">#31</a> from xiaofen9/master</li> <li><a href="https://github.com/jonschlinkert/kind-of/commit/975c13a7cfaf25d811475823824af3a9c04b0ba8"><code>975c13a</code></a> fix type checking vul in ctorName</li> <li><a href="https://github.com/jonschlinkert/kind-of/commit/4da96c0047906d22a4d6964a668d3abaca122e50"><code>4da96c0</code></a> Delete FUNDING.yml</li> <li><a href="https://github.com/jonschlinkert/kind-of/commit/28266f233a3ac50c004b58a1a7116f506928997b"><code>28266f2</code></a> Create FUNDING.yml</li> <li>See full diff in <a href="https://github.com/jonschlinkert/kind-of/compare/6.0.2...6.0.3">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~doowb">doowb</a>, a new releaser for kind-of since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

push eventpooltogether/uniform-random-number

dependabot[bot]

commit sha 3d5b7eef4c9f6ba54d7032b786f142a3edfd8a9d

Bump lodash from 4.17.11 to 4.17.14 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14) Signed-off-by: dependabot[bot] <support@github.com>

view details

aodhgan

commit sha 58a2469a36cf87438061860803f091cd7e0f2c13

Merge pull request #2 from pooltogether/dependabot/npm_and_yarn/lodash-4.17.14 Bump lodash from 4.17.11 to 4.17.14

view details

push time in 2 days

PR merged pooltogether/uniform-random-number

Bump lodash from 4.17.11 to 4.17.14 dependencies

Bumps lodash from 4.17.11 to 4.17.14. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

PR opened pooltogether/uniform-random-number

Upgrade to solc8

Also upgrades to hardhat from truffle

+313 -115

0 comment

16 changed files

pr created time in 2 days

create barnchpooltogether/uniform-random-number

branch : upgrade-to-solc8

created branch time in 2 days

created tagpooltogether/uniform-random-number

tagv1.0.0

Eliminates modulo bias for Solidity smart contracts.

created time in 4 days

push eventpooltogether/pooltogether-contracts-template

Aodhgan

commit sha 382151984c1701e3554e9b18a6b45b0899cf6b19

add solcover file

view details

push time in 5 days

push eventpooltogether/pooltogether-subgraph-v3

Aodhgan

commit sha 87b25f371ffdbb07972448c16eb6f8b9445e969f

added BSC endpoint and deployed

view details

push time in 5 days

delete branch pooltogether/pooltogether-generic-registry

delete branch : test_fail

delete time in 7 days

delete branch pooltogether/pooltogether-generic-registry

delete branch : pool-1351-addressregistry-contains-should-be-a

delete time in 7 days

delete branch pooltogether/pooltogether-generic-registry

delete branch : rename_contract_to_address

delete time in 7 days

push eventpooltogether/pooltogether-generic-registry

Aodhgan

commit sha 0aac928d368444ed23602bbd0667e2fa4a6c9b14

view

view details

aodhgan

commit sha 9e006d792dd27e9be3e5913ec4da8c769162e3cc

Merge pull request #4 from pooltogether/pool-1351-addressregistry-contains-should-be-a contains() is view

view details

push time in 7 days

Pull request review commentpooltogether/swappable-yield-source

[WIP] Swappable Yield Source

+// SPDX-License-Identifier: GPL-3.0++pragma solidity ^0.7.6;++import "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol";+import "@openzeppelin/contracts-upgradeable/token/ERC20/ERC20Upgradeable.sol";+import "@openzeppelin/contracts-upgradeable/token/ERC20/IERC20Upgradeable.sol";+import "@openzeppelin/contracts-upgradeable/token/ERC20/SafeERC20Upgradeable.sol";+import "@openzeppelin/contracts-upgradeable/utils/ReentrancyGuardUpgradeable.sol";+import "@pooltogether/fixed-point/contracts/FixedPoint.sol";+import "@pooltogether/yield-source-interface/contracts/IYieldSource.sol";++import "./access/AssetManager.sol";++/// @title Swappable yield source contract to allow a PoolTogether prize pool to swap between different yield sources.+/// @dev This contract adheres to the PoolTogether yield source interface.+/// @dev This contract inherits AssetManager which extends OwnableUpgradable.+/// @notice Swappable yield source for a PoolTogether prize pool that generates yield by depositing into the specified yield source.+contract SwappableYieldSource is ERC20Upgradeable, IYieldSource, AssetManager, ReentrancyGuardUpgradeable {+  using SafeMathUpgradeable for uint256;+  using SafeERC20Upgradeable for IERC20Upgradeable;++  /// @notice Emitted when the swappable yield source is initialized.+  event SwappableYieldSourceInitialized(+    IYieldSource indexed yieldSource,+    uint8 decimals,+    string symbol,+    string name,+    address indexed owner+  );++  /// @notice Emitted when a yield source has been successfuly set.+  event SwappableYieldSourceSet(+    address indexed yieldSource+  );++  /// @notice Emitted when funds are successfully transferred from specified yield source.+  event FundsTransferred(+    address indexed yieldSource,+    uint256 amount+  );++  /// @notice Emitted when yield source has been successfuly swapped.+  event YieldSourceSwapped(+    address indexed previousYieldSource,+    address indexed yieldSource+  );++  /// @notice Emitted when ERC20 tokens other than yield source's tokens are withdrawn from the swappable yield source.+  event TransferredERC20(+    address indexed from,+    address indexed to,+    uint256 amount,+    IERC20Upgradeable indexed token+  );++  /// @notice Yield source interface.+  IYieldSource public yieldSource;++  /// @notice Mock Initializer to initialize implementations used by minimal proxies.+  function freeze() public initializer {+    //no-op+  }++  /// @notice Hack to determine if address passed is an actual yield source.+  /// @param _yieldSource Yield source address to check.+  function _requireYieldSource(IYieldSource _yieldSource) internal view {+    (bool succeeded,) = address(_yieldSource).staticcall(abi.encode(_yieldSource.depositToken.selector));+    require(succeeded, "SwappableYieldSource/invalid-yield-source");+  }++  /// @notice Initializes the swappable yield source with the yieldSource address provided.+  /// @param _yieldSource Address of yield source used to initialize this swappable yield source.+  /// @param _decimals Number of decimals the shares (inherited ERC20) will have.  Same as underlying asset to ensure same ExchangeRates.+  /// @param _symbol Token symbol for the underlying ERC20 shares (eg: swsDAI).+  /// @param _name Token name for the underlying ERC20 shares (eg: PoolTogether Swappable Yield Source DAI).+  /// @param _owner Swappable yield source owner.+  /// @return true if operation is successful.+  function initialize(+    IYieldSource _yieldSource,+    uint8 _decimals,+    string calldata _symbol,+    string calldata _name,+    address _owner+  ) public initializer returns (bool) {+    yieldSource = _yieldSource;++    _requireYieldSource(_yieldSource);++    __Ownable_init();+    transferOwnership(_owner);++    __ERC20_init(_name, _symbol);+    require(_decimals > 0, "SwappableYieldSource/decimals-gt-zero");

Does it matter since the decimals here are solely for internal accounting and in your above example (cToken to aToken) they would have a different balances[address => uint256] entry so it wouldn't affect the tokenToShares() and sharesToToken()?

@asselstine

PierrickGT

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentpooltogether/swappable-yield-source

[WIP] Swappable Yield Source

+// SPDX-License-Identifier: GPL-3.0++pragma solidity ^0.7.6;++import "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol";+import "@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol";++/**+*  @title Abstract ownable contract with additional assetManager role+ * @notice Contract module based on Ownable which provides a basic access control mechanism, where+ * there is an account (an asset manager) that can be granted exclusive access to+ * specific functions.+ *+ * The asset manager account needs to be set using {setAssetManager}.+ *+ * This module is used through inheritance. It will make available the modifier+ * `onlyAssetManager`, which can be applied to your functions to restrict their use to+ * the asset manager.+ */+abstract contract AssetManager is ContextUpgradeable, OwnableUpgradeable {

Likely a repo similar to https://github.com/pooltogether/pooltogether-generic-registry where it can be imported into other projects as an npm package. Would say doesn't need to be done for this PR, but more afterwards as a small project.

PierrickGT

comment created time in 7 days

PullRequestReviewEvent

push eventpooltogether/pooltogether-contracts-template

Aodhgan

commit sha ab229345a0c7a99ebd7919e9816c6055d6ab8e5f

more tests

view details

push time in 7 days

push eventpooltogether/pooltogether-contracts-template

Aodhgan

commit sha 65f3be92566c4fe2f66ce9c0822cdad42a1da88f

remove build from package

view details

push time in 8 days

delete branch pooltogether/pooltogether-subgraph-v3

delete branch : revert-52-pool-1342-subgraph-issue-prize-not-showing-all

delete time in 9 days

delete branch pooltogether/pooltogether-subgraph-v3

delete branch : rebase-changes

delete time in 9 days

delete branch pooltogether/pooltogether-subgraph-v3

delete branch : pool-1342-subgraph-issue-prize-not-showing-all

delete time in 9 days

created tagpooltogether/pooltogether-subgraph-v3

tagv3.4.3-alpha.1

Subgraph currently hosted on The Graph network for reading existing PoolTogether smart contract data.

created time in 9 days

PR closed pooltogether/pooltogether-subgraph-v3

V3.4.0

or v.3.4.1 due to npm packaging error

+144 -490

1 comment

14 changed files

aodhgan

pr closed time in 9 days

create barnchpooltogether/pooltogether-subgraph-v3

branch : v3_4_3

created branch time in 9 days

delete branch pooltogether/pooltogether-subgraph-v3

delete branch : v3_4_0

delete time in 9 days

push eventpooltogether/pooltogether-subgraph-v3

Aodhgan

commit sha da7829e0606279d17368e084b46cfb2012b2c038

v3.4.3 addresses

view details

push time in 9 days