profile
viewpoint

andyklimczak/djangocms-light-gallery 5

DjangoCMS plugin for Light Gallery 1.4.0

andyklimczak/cfg 1

dot files and game autoexecs

andyklimczak/ember-countdown 1

Ember-cli addon for countdownjs

andyklimczak/2d-tiled 0

phaser tutorial reference

andyklimczak/4chan-API 0

Documentation for 4chan's read-only JSON API.

andyklimczak/action_mailer_matchers 0

ActionMailerMatchers provides rspec matchers to test Rails' common ActionMailer functionality.

andyklimczak/Advent-of-Code-2017 0

http://adventofcode.com/

startedmeilisearch/MeiliSearch

started time in 12 hours

startedVGraupera/1on1-questions

started time in 2 days

startedthoradia/thoradia

started time in a month

startedTerryCavanagh/VVVVVV

started time in a month

startedairsonic/airsonic

started time in a month

startedtycrek/degoogle

started time in a month

startedRisk3sixty-Labs/geoapi

started time in 2 months

startedAtarity/deploy-your-own-saas

started time in 2 months

startedchubin/wttr.in

started time in 2 months

startedpaaatrick/playball

started time in 3 months

push eventandyklimczak/cfg

Andy Klimczak

commit sha 6048b61f892dfbb39f4993714f4d5f6b0cec3db5

stuff

view details

push time in 3 months

startedchanzuckerberg/sorbet-rails

started time in 4 months

startedhome-assistant/home-assistant

started time in 4 months

issue commentgenerative-music/generative.fm

Animate the playing status indicator when playing

Hi! I wanted to help on this issue and have a question.

Animating the playing indicator how? Not sure if you had something particular in mind, or if you just wanted a slow spin or something else

Thanks!

metalex9

comment created time in 4 months

startedbovarysme/fudge

started time in 4 months

startedmikker/passwordless

started time in 4 months

Pull request review commentchandevel/Clover

Super patch

 public void updateDrawState(@NonNull TextPaint ds) {         }     } +    public boolean getSpoilerState() {

this might be better named as isSpoilerVisible since it returns a boolean. get kinds makes it seem it will return an enum rather than a boolean

src

Adamantcheese

comment created time in 4 months

Pull request review commentchandevel/Clover

Super patch

 private void setupSaveLocationSetting(SettingsGroup media) {         updateSaveLocationSetting();     } +    private void updateThreadFolderSetting() {+        if (ChanSettings.saveBoardFolder.get()) {+            threadFolderSetting.setEnabled(true);+        } else if (!ChanSettings.saveBoardFolder.get()) {

I think you could convert this to just an else

Adamantcheese

comment created time in 4 months

Pull request review commentchandevel/Clover

Super patch

 public void setPagerItems(List<PostImage> images, int initialIndex) {         pager.setCurrentItem(initialIndex);     } -    public void setImageMode(PostImage postImage, MultiImageView.Mode mode) {-        ((ImageViewerAdapter) pager.getAdapter()).setMode(postImage, mode);+    public void setImageMode(PostImage postImage, MultiImageView.Mode mode, boolean center) {

if we're defaulting to true in most cases, and false is a special case, it might be helpful to create an overloaded method:

     public void setImageMode(PostImage postImage, MultiImageView.Mode mode) { 
         ((ImageViewerAdapter) pager.getAdapter()).setMode(postImage, mode, true); 
     } 

so you don't have to pass true each time

Adamantcheese

comment created time in 4 months

Pull request review commentchandevel/Clover

Super patch

 private void cleanupVideo(PlayerView videoView) {         videoView.getPlayer().release();     } +    public void toggleTransparency() {+        CustomScaleImageView imageView = findScaleImageView();+        GifImageView gifView = findGifImageView();+        if (imageView == null && gifView == null) return;+        boolean isImage = imageView != null && gifView == null;+        if (backgroundToggle) {

you might be able to remove this exterior conditional by doing a ternary first

backgroundColor = backgroundToggle ? Color.TRANSPARENT : Color.BACKGROUND_COLOR
if (isImage) {
    imageView.setTileBackgroundColor(backgroundColor);
} else {
    gifView.getDrawable().setColorFilter(backgroundColor, PorterDuff.Mode.DST_OVER);
}
backgroundToggle = !backgroundToggle
Adamantcheese

comment created time in 4 months

Pull request review commentchandevel/Clover

Super patch

 public CustomScaleImageView findScaleImageView() {         return bigImage;     } +    public GifImageView findGifImageView() {+        GifImageView gif = null;+        for (int i = 0; i < getChildCount(); i++) {+            if (getChildAt(i) instanceof GifImageView) {+                gif = (GifImageView) getChildAt(i);

do we want to break or just return here to stop iterating if we find one? or do we want to return the last one found?

Adamantcheese

comment created time in 4 months

Pull request review commentchandevel/Clover

Super patch

 private void showPostInfo(Post post) {             text.append("\nTripcode: ").append(post.tripcode);         } -        /*if (!TextUtils.isEmpty(post.countryName)) {-            text += "\nCountry: " + post.country + ", " + post.countryName;-        }*/+        if (post.httpIcons != null && !post.httpIcons.isEmpty()) {+            for (PostHttpIcon icon : post.httpIcons) {+                if (icon.url.toString().contains("troll")) {+                    text.append("\nTroll Country: ").append(icon.name);+                } else if (icon.url.toString().contains("country")) {+                    text.append("\nCountry: ").append(icon.name);+                } else {

might be good to explicitly call out the since4pass icon type instead of using an else. in case they ever add another icon, we won't show the since4pass instead

Adamantcheese

comment created time in 4 months

startedripienaar/free-for-dev

started time in 4 months

startedinternetarchive/openlibrary

started time in 4 months

startedleeoniya/uPlot

started time in 4 months

issue commentgenerative-music/generative.fm

Site down? No longer maintained?

Up for me with an SSL cert from amazon

rossvz

comment created time in 4 months

push eventandyklimczak/fishshell-theme-gnuykeaj

Andy Klimczak

commit sha cf7ce4af30c21647ac73889a5b773d48d2416c78

Update README.md

view details

push time in 4 months

startedjhollinger/occams-record

started time in 5 months

startedThreeDotsLabs/watermill

started time in 5 months

startedglamrock/data-brokers

started time in 5 months

startedinfosimples/anti_captcha

started time in 5 months

issue commentOSUOSC/website

Website is inaccessible

You could host the jekyll pages with github pages instead of using osu infrastructure/stallman2, and point opensource.osu.edu to the new domain (but where's the fun in that).

andyklimczak

comment created time in 5 months

issue commentOSUOSC/website

Website is inaccessible

I'm not 100% convinced the PR will solve the site being up or not, but it turned your travis build green.

Have an officer try this step, then we'll know for sure

andyklimczak

comment created time in 5 months

delete branch andyklimczak/website

delete branch : travis-bundler-fix

delete time in 5 months

issue commentOSUOSC/website

Website is inaccessible

I have a PR that fixes the travis build, which will allow the site to be properly deployed at least #293

andyklimczak

comment created time in 5 months

Pull request review commentOSUOSC/website

Fix travis build

 FROM ubuntu:16.04 -RUN apt-get update && apt-get install -y ruby-dev libffi-dev apache2 git build-essential libxml2-dev zlib1g-dev && gem install bundler+RUN apt-get update && apt-get install -y ruby-dev libffi-dev apache2 git build-essential libxml2-dev zlib1g-dev && gem install bundler -v '~> 1.11'

The docker image is unable to build with newer version of bundler (see here)

andyklimczak

comment created time in 5 months

pull request commentOSUOSC/website

Fix travis build

I'm not convinced this will solve the site being up or not, but it will turn your travis build green.

andyklimczak

comment created time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha aebcfa1b1dac359712b1017cfe90768f57704031

Fix travis build - Have docker image use same bundler version as defined in .gemspec

view details

push time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha 1c0118c2f3c050c352c470eddbdb7cdf66743723

Fix travis build - Have travis use bundler v1 - Before install stuff taken from [here](https://docs.travis-ci.com/user/languages/ruby/#bundler-20)

view details

push time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha e0dc347039474ccc6403f90499b30fd01bc8c05f

try

view details

push time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha 6ba8c2f719e64879a1551a42285f8e0961829423

Fix travis build - Have travis use bundler v1 - Before install stuff taken from [here](https://docs.travis-ci.com/user/languages/ruby/#bundler-20)

view details

push time in 5 months

Pull request review commentOSUOSC/website

Fix travis build

 services:   - docker +before_install:+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true+  - gem install bundler -v '< 2'

taken from here

andyklimczak

comment created time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha e440c99f2c94a35e2d534bbf9003b7b7ad364757

Fix travis build - Have travis use bundler v1 - Before install stuff taken from [here](https://docs.travis-ci.com/user/languages/ruby/#bundler-20)

view details

push time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha 2d3c018a175fddab0fd9c4540e9f398fd5cb9cde

Fix travis build - Have travis use bundler v1 - Before install stuff taken from [here](https://docs.travis-ci.com/user/languages/ruby/#bundler-20)

view details

push time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha 31aa6db685bd5d5b239b72f33e0220c333c112ca

Fix travis build - Have travis use bundler v1 - Before install stuff taken from [here](https://docs.travis-ci.com/user/languages/ruby/#bundler-20)

view details

push time in 5 months

PR opened OSUOSC/website

Fix travis build

Fixes #292

Changes proposed in the pull request:

  • Have travis use bundler v1

<!-- DON'T REMOVE THIS --> @OSUOSC/website-team <!------------------------>

+5 -1

0 comment

1 changed file

pr created time in 5 months

push eventandyklimczak/website

Andy Klimczak

commit sha 07346976638650cd3c0820f9728bfff0c5e332d8

Fix travis build - Have travis use bundler v1

view details

push time in 5 months

create barnchandyklimczak/website

branch : travis-bundler-fix

created branch time in 5 months

fork andyklimczak/website

:octocat: Website for The Open Source Club at the Ohio State University

https://opensource.osu.edu

fork in 5 months

issue commentOSUOSC/website

Website is inaccessible

I believe the Bundler 2 release is a part of the issue.

Is there a particular reason why Gemfile.lock is in the .gitignore?

andyklimczak

comment created time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 28a8d648328ac965d32b407c0aa21f1788d5c923

Fix `SystemStackError` when paranoid models have a circular `dependent: :destroy` - Previously, paranoid models with a circular `dependent: :destroy` would recursively try to delete eachother - Add a variable to check if the destroy callback has already been called for that model - Similar fix to rails/rails#18548

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 6127fb5aa3d7c3435a683272a4c9fa1a08ae2679

try

view details

push time in 5 months

pull request commentrubysherpas/paranoia

Fix `SystemStackError` when paranoid models have a circular `dependent: :destroy`

Dealt with travisci issues. Ready for review! 🎉

andyklimczak

comment created time in 5 months

Pull request review commentrubysherpas/paranoia

Fix `SystemStackError` when paranoid models have a circular `dependent: :destroy`

 sudo: false language: ruby-before_install: gem update --system+before_install:+   - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true+   - gem install bundler -v '< 2'

taken from here

andyklimczak

comment created time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 9cd15939c1b59f2cd59ba3196946b486f1db9052

Fix `SystemStackError` when paranoid models have a circular `dependent: :destroy` - Previously, paranoid models with a circular `dependent: :destroy` would recursively try to delete eachother - Add a variable to check if the destroy callback has already been called for that model - Similar fix to rails/rails#18548

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha a46430ea670bee46ca6a5e6611f68a5a414bc0a8

try

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 1bff29aa27384991a424b9492842ad12eee8bdda

try

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 3e3ca476ea85dd1a9402a9d9afba93d716a750c2

try

view details

push time in 5 months

Pull request review commentrubysherpas/paranoia

Fix `SystemStackError` when paranoid models have a circular `dependent: :destroy`

 sudo: false language: ruby-before_install: gem update --system+before_install:+  - gem update --system --conservative || (gem i "rubygems-update:~>2.7" --no-document && update_rubygems)+  - gem update bundler --conservative

issues explaining this: https://github.com/rubygems/rubygems/issues/2534

andyklimczak

comment created time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha a6cf53d19dd982568fd8b8029f7345205bfc3e72

different

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha d12e918a78b547898f87eaea79aad8314ec6581c

try

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 2913efb798ed740397ca00df9fb025054e348fd4

try

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 6cd85ece972ff8d4c05d40a03a8018f0c95c4c27

refomat

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 7dbb9455463601ceda9d208697d42de890ea55dd

reformat

view details

push time in 5 months

push eventandyklimczak/paranoia

Andy Klimczak

commit sha 8fd4790fbc01a4f8eb3a36120cfc139f6c901cfb

remove extras

view details

push time in 5 months

startedfirefly-iii/firefly-iii

started time in 5 months

startedEliteQuant/EliteQuant

started time in 5 months

more