profile
viewpoint
Adrian Mouat amouat @ContainerSolutions Edinburgh www.adrianmouat.com

amouat/diffxml 49

Diff and Patch XML files

amouat/dim 24

Distraction-free writing with Docker and Vim

amouat/dnmonster 20

Dockerised Node server for KevinGuadin's monsterids

amouat/example_app 8

Example python application using Docker rather than virtualenv for isolation

amouat/clair-with-wait 3

Clair Vulnerability Scanner with wait-for-it.sh in Dockerfile

amouat/Evolution-in-Clojure 3

Clojure version of Evolution from Land of Lisp

amouat/identiorca 3

Example App for illustrating Orchestration

amouat/cabot 1

HTTP Client for Rust

amouat/clair-analyse 1

Docker container with analyse-local-images installed for use with the Clair vulnerability scanner

amouat/decktape-docker 1

A Docker image for running Decktape

pull request commentContainerSolutions/trow

Update default.nix to allow nix-shell to function again

@imacg feel free to contribute anything you like to the nix stuff!

Unfortunately I don't really use it myself and I'm unsure who else is using it, but it's certainly a nice thing to have.

imacg

comment created time in 8 hours

delete branch ContainerSolutions/trow

delete branch : Spazzy757-patch-1

delete time in 17 hours

push eventContainerSolutions/trow

Brendan Kamp

commit sha ef85580e800fab9ffd7a9a3dc32b61d2af43d2b2

Update issue templates (#179) Added a feature request template to the issues templates

view details

push time in 17 hours

PR merged ContainerSolutions/trow

Update issue templates

Added a feature request template to the issues templates

+20 -0

1 comment

1 changed file

Spazzy757

pr closed time in 17 hours

PullRequestReviewEvent

push eventContainerSolutions/trow

Adrian Mouat

commit sha 7a28f594eb546eac62dadbce600fdb656536b333

Update issue templates

view details

push time in a day

delete branch ContainerSolutions/trow

delete branch : fs_user

delete time in a day

push eventContainerSolutions/trow

Adrian Mouat

commit sha 0bfc68be549ac7eac2afb3771c46e8d3dd98c421

Add troubleshooting entry when can't write to FS. (#178)

view details

push time in a day

create barnchContainerSolutions/trow

branch : fs_user

created branch time in a day

issue openedContainerSolutions/trow

"Resumption ignored, DHE_KE not offered" warning in logs

rustls has started spamming the logs with:

[2020-09-29T13:12:26Z WARN  rustls::server::hs] Resumption ignored, DHE_KE not offered

I'm not sure what's causing this or exactly what it means (PSK is Pre-shared Key, DHE_KE is I think Diffie Helman Key Exchange).

created time in a day

issue commentContainerSolutions/trow

manifest invalid error

Addressed error message in #176

foggy-glasses

comment created time in a day

delete branch ContainerSolutions/trow

delete branch : manifest_error

delete time in a day

push eventContainerSolutions/trow

Adrian Mouat

commit sha bc30e688ab40ccf87c283b4be7af1b0c4c7c445c

Improve error messages. (#176) - Should now get an internal error if server can't write to FS - Shouldn't have tonic status in route.rs, but it's there...

view details

push time in a day

PR merged ContainerSolutions/trow

Improve error messages.
  • Should now get an internal error if server can't write to FS
  • Shouldn't have tonic status in route.rs, but it's there...
+14 -4

0 comment

3 changed files

amouat

pr closed time in a day

issue commentContainerSolutions/trow

Helm chart: allow configuration with no user/pass

Yes, I think so. But either is fine as long as it's easy to change.

amouat

comment created time in a day

PR opened ContainerSolutions/trow

Improve error messages.
  • Should now get an internal error if server can't write to FS
  • Shouldn't have tonic status in route.rs, but it's there...
+14 -4

0 comment

3 changed files

pr created time in a day

create barnchContainerSolutions/trow

branch : manifest_error

created branch time in a day

issue commentContainerSolutions/trow

manifest invalid error

Ah, I think I see it.

I think you've been bit by a breaking change between 0.2 and 0.3. The error is actually occurring when Trow tries to write to the filesystem and it's hitting an error. It's being caused by these lines in your config:

      securityContext:             
        runAsUser: 999
        runAsGroup: 999
        fsGroup: 999

We changed the Trow user from 999 to 333333 as minor security improvement. You're using the 0.3 image which includes this change, but the kubernetes config still has the old values.

Could you check the server logs (should be something like `kubectl logs -n trow-test trow-pod) and share those? Hopefully there is a clearer error message there.

To fix the problem you'll need to:

  • update your k8s configs to use 333333 as the user everywhere
  • run chown -R 333333 /data on your data directory

The "manifest invalid" error message isn't accurate, so I'll change that, but I don't want to give away details of what's happening on the server end, so it will probably just be "server error" or something.

foggy-glasses

comment created time in 2 days

delete branch ContainerSolutions/trow

delete branch : timeouts

delete time in 2 days

push eventContainerSolutions/trow

Adrian Mouat

commit sha 4114d44f7034681acd82c9e9dd66484c1800a7f2

Increase timeouts. (#175) Wish I knew why this was needed, but tests are flaky otherwise.

view details

push time in 2 days

PR merged ContainerSolutions/trow

Increase timeouts.

Wish I knew why this was needed, but tests are flaky otherwise.

+4 -4

0 comment

4 changed files

amouat

pr closed time in 2 days

PR opened ContainerSolutions/trow

Increase timeouts.

Wish I knew why this was needed, but tests are flaky otherwise.

+4 -4

0 comment

4 changed files

pr created time in 2 days

push eventContainerSolutions/trow

Ian MacGuigan

commit sha a20227d05df7f4d6b30a14e661bb506199eb84a5

Update default.nix (#174) * Update Mozilla nix overlay to current master * Synchronize Rust nightly date with docker/Dockerfile.* * Pass path of protoc to trow-protobuf build script via PROTOC envvar

view details

push time in 2 days

PR merged ContainerSolutions/trow

Update default.nix to allow nix-shell to function again
  • Update Mozilla nix overlay to current master
  • Synchronize Rust nightly date with docker/Dockerfile.*
  • Pass path of protoc to trow-protobuf build script via PROTOC envvar
+5 -4

1 comment

1 changed file

imacg

pr closed time in 2 days

create barnchContainerSolutions/trow

branch : timeouts

created branch time in 2 days

push eventContainerSolutions/trow

Adrian Mouat

commit sha 27219633e72e2eeb03fed16d66f9b9939f6195f4

Up timeout for test.

view details

push time in 2 days

pull request commentContainerSolutions/trow

Update default.nix to allow nix-shell to function again

Wow. This is awesome, thanks. I was actually going to delete default.nix as I didn't think anyone used it anymore (@moredhel wrote it originally).

Let me figure out why this test is failing and I'll merge (I don't see how the test can have anything to do with your change so it's a bit weird).

imacg

comment created time in 2 days

PullRequestReviewEvent

issue commentContainerSolutions/trow

manifest invalid error

Thanks.

For the sake of the thread - the OP is experiencing issues uploading any image, not a given image.

Regarding the problem with the 0.3.0 tagged image, it sounds like an issue with how you are running Trow - could you share the YAML you used to deploy Trow?

Also, could you post the config for metallb, I have a feeling that might actually be the problem.

BTW Trow and several other images are "multi-arch", which means the version you get is dependant on the architecture of the machine you pull them on. So if you pull an image on your workstation, please be careful that you get the same architecture as the server. In most cases this won't be a problem as both will probably be x86_64 Linux, but it's possible you will find some images (not Trow) with windows OS builds that won't work on your cluster.

foggy-glasses

comment created time in 2 days

push eventContainerSolutions/trow

Adrian Mouat

commit sha 7e5105acc6f500d4f1d73af7c26ccdbee003ef47

Update rust version in Dockerfiles. And a minor typo that should be in a different commit. Sue me.

view details

push time in 2 days

issue commentContainerSolutions/trow

manifest invalid error

Sure, as long as there's nothing sensitive. I'm not sure if there's a file limit though.

foggy-glasses

comment created time in 6 days

issue commentContainerSolutions/trow

manifest invalid error

Could you give me a copy of the image to test with?

You might need to use docker save and upload it somewhere or send it to my e-mail (adrian.mouat at container-solutions.com)

foggy-glasses

comment created time in 6 days

issue commentContainerSolutions/trow

Helm chart: allow configuration with no user/pass

You can install from the Helm chart without providing username/pass? It didn't look possible to me - maybe it's just a docs issue.

amouat

comment created time in 7 days

issue commentContainerSolutions/trow

request canceled while waiting for connection

I can't recreate this problem. It should work - you're not doing anything unusual at the Trow level and I tried to recreate as much as I could (I haven't tried the nginx proxy).

The 401 error for http://clientlogin-yy http://clienttest.client.com.xx/v2/_catalog is correct - you'd need to authenticate and pass the token in the header for this to work.

I think the problem is either with nginx or some networking issue. You don't need any further networking changes.

foggy-glasses

comment created time in 7 days

PR opened ContainerSolutions/java-operator-sdk

Add Code of Conduct

We missed the code of conduct when adding the Contributor guidelines. Please take a look and make sure you're happy with this one.

+134 -0

0 comment

1 changed file

pr created time in 7 days

create barnchContainerSolutions/java-operator-sdk

branch : code-of-conduct

created branch time in 7 days

issue openedContainerSolutions/kubernetes-examples

Add PodPreset Example

We're missing an example for PodPreset.

It should be possible to use an example from the Kubernetes docs.

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 7 days

issue openedContainerSolutions/kubernetes-examples

Add PriorityClass Example

We're missing an example for PriorityClass.

It should be possible to use an example from the Kubernetes docs.

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 7 days

issue openedContainerSolutions/kubernetes-examples

Add PodDisruptionBudget Example

We're missing an example for PodDisruptionBudget.

It should be possible to use an example from the Kubernetes docs.

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 7 days

issue openedContainerSolutions/kubernetes-examples

Add AdmissionWebhook Examples

Add examples for ValidatingAdmissionWebhook and MutatingAdmissionWebhook.

It should be possible to use examples from the Kubernetes docs, but please make sure they work standalone.

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 7 days

issue openedContainerSolutions/kubernetes-examples

Add HorizontalPodAutoscalar Example

We're missing an example for HorizontalPodAutoscalar.

It should be possible to use an example from the Kubernetes docs.

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 7 days

issue commentContainerSolutions/kubernetes-examples

Identify resources still TODO

Added #17 and #18

ianmiell

comment created time in 8 days

issue openedContainerSolutions/kubernetes-examples

Add example for PersistentVolumeClaim

We're missing an example for PersistentVolumeClaim, but we do have one for PersistentVolumes. This example should probably go in the same directory.

It should be possible to use an example from the Kubernetes docs, but please make sure it works either standalone or with the existing PersistentVolume example.

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 8 days

issue openedContainerSolutions/kubernetes-examples

Add example for EndpointSlice

We're missing an example for EndpointSlices, but we do have one for Endpoints. This example could go in the same directory or a new one.

It should be possible to use the example from here: https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

If you want to pick up this issue, please first read the README.md and CONTRIBUTING.md. Make sure you follow the existing style and standards for other examples.

created time in 8 days

issue commentContainerSolutions/kubernetes-examples

Identify resources still TODO

Ok, I went through everything except Cluster API stuff.

There are some things that we cover in other directories that you might want to cross link e.g. IngressClass and the various Pod/ReplicaSet/Container things.

Anyway, as best as I can tell, the following is missing:

  • EndpointSlice
  • CSIDriver, CSINode, VolumeAttachment (I can't find much resources on these, I assume they're for setting up cluster specific volume types? https://kubernetes-csi.github.io/docs/csi-driver-object.html)
  • PersistentVolumeClaim (we do have PVs, but nothing about PVCs that I saw, could add to PV dir)
  • ControllerRevision & ControllerRevisionList (not sure what this is about or if it can be created by users)
  • CustomResourceDefinition
  • Event (I think this is created internally only and should be ignored)
  • HorizontalPodAutoscalar
  • ValidatingAdmissionWebhook
  • MutatingAdmissionWebhook
  • PodDisruptionBudget
  • PriorityClass
  • PodPreset

Above you mention creating empty folders for these. I'd actually recommend against that idea, as I think it will make it trickier to see what exists and what doesn't.

If it's ok with you, I'd like to take several of these resources and create independent issues for them, which can labelled good first issue and hacktoberfest.

ianmiell

comment created time in 8 days

PR opened ContainerSolutions/kubernetes-examples

Update e-mail.

Replace Adrian's e-mail with Ian's - Ian please check this is what you want, you can always leave it as is.

+1 -1

0 comment

1 changed file

pr created time in 8 days

push eventContainerSolutions/kubernetes-examples

Adrian Mouat

commit sha 2a5545e51cf4227d23f490ee98d86e246250a0c7

Update e-mail. Replace Adrian's e-mail with Ian's.

view details

push time in 8 days

PR opened ContainerSolutions/kubernetes-examples

Proposed code of conduct and contributing guidelines.

This PR is based on the Trow repo, modified for Kubernetes Examples.

We need this in place if we want to take advantage of hacktoberfest.

+184 -0

0 comment

2 changed files

pr created time in 8 days

create barnchContainerSolutions/kubernetes-examples

branch : contributing

created branch time in 8 days

issue commentContainerSolutions/trow

Integrations with Kubernetes Distros & Installers

If you want to work on any of these, please discuss here and then we can open a new issue for the specific platform.

amouat

comment created time in 9 days

delete branch ContainerSolutions/trow

delete branch : feature/126-metrics

delete time in 12 days

push eventContainerSolutions/trow

Eric Caleb

commit sha f68d3b6c32630a8c1b341f9e94ed36e6d752cc62

Feature/126 metrics (#132) Adds basic metric reporting to Trow

view details

push time in 12 days

PR merged ContainerSolutions/trow

Feature/126 metrics enhancement

#126

  • [x] Disk

  • [x] Number of requests?

    • [x] Blobs
    • [x] Manifests
  • [ ] Number stored:

    • [ ] Manifests
    • [ ] Blobs
    • [ ] Tags
+2394 -1893

1 comment

19 changed files

iamcaleberic

pr closed time in 12 days

issue closedContainerSolutions/trow

Create Metrics Endpoint

Should be compatible with prometheus.

Report on things like:

  • disk space
  • number of blobs, manifests, tags stored
  • number of requests served

closed time in 12 days

amouat

issue openedContainerSolutions/trow

Helm chart: allow configuration with no user/pass

The Helm chart currently asks for a user and password, but it should also be possible to configure with no user/password set at all.

created time in 13 days

MemberEvent

issue openedContainerSolutions/helm-convert

Move from Travis to GitHub Actions

The current build & distribution is created by Travis. This currently has some problems, not least requiring uploading a personal access token to Travis CI.

It would be better and easier to move to GitHub actions. The build part should be trivial and creating distribution binaries shouldn't be much harder. At the same time the docker builds could be fixed and moved to ghcr.

created time in 14 days

pull request commentContainerSolutions/trow

Feature/126 metrics

Sorry, there's a problem with Cargo.lock that needs fixed now. I think you just need to rebase and maybe run cargo update

iamcaleberic

comment created time in 16 days

PullRequestReviewEvent

issue closedContainerSolutions/trow

How to deploy an image with trow being protected with username/password

Hi @amouat ,

Hopefully an easy question but I couldnt find it in the docs; I was able to setup trow with basic username/password protection and we are able to push images to the registry. However, when I try to deploy them with kubectl, I get an unauthorized, which makes sense. I've tried to setup a secret for docker setup, which seem to work but I still fail to connect.

Is there any standard to make this work? greetz, Remco

closed time in 16 days

CreepDth

issue commentContainerSolutions/trow

How to deploy an image with trow being protected with username/password

Thanks.

I'm going to close this issue for the minute, but I'll take a note of the issue for improving our docs.

If you hit any problems, please open a new issue for that.

Good luck!

Adrian.

CreepDth

comment created time in 16 days

Pull request review commentContainerSolutions/trow

Feature/126 metrics

 mod interface_tests {         assert_eq!(resp.status(), StatusCode::BAD_REQUEST);     } +    async fn get_health(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/healthz", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let hr: HealthResponse = resp.json().await.unwrap();++        assert_eq!(hr.is_healthy, true);+    }++    async fn get_readiness(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/readiness", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let rr: ReadinessResponse = resp.json().await.unwrap();++        assert_eq!(rr.is_ready, true);+    }++    async fn get_metrics(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/metrics", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let body = resp.text().await.unwrap();++        assert!(body.contains("available_space"));+        assert!(body.contains("free_space"));+        assert!(body.contains("total_space"));++        assert!(!body.contains("total_manifest_requests{type=\"manifests\"} 0"));+        assert!(body.contains("total_manifest_requests{type=\"manifests\"} 6"));+        assert!(!body.contains("total_blob_requests{type=\"blobs\"} 0"));+        assert!(body.contains("total_blob_requests{type=\"blobs\"} 8"));++        get_manifest(&cl, "onename", "tag").await;+        let manifest_response = cl+            .get(&format!("{}/metrics", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        let manifest_body = manifest_response.text().await.unwrap();++        assert!(manifest_body.contains("total_manifest_requests{type=\"manifests\"} 7"));+        assert!(!manifest_body.contains("total_manifest_requests{type=\"manifests\"} 8"));

and this one

iamcaleberic

comment created time in 21 days

Pull request review commentContainerSolutions/trow

Feature/126 metrics

 mod interface_tests {         assert_eq!(resp.status(), StatusCode::BAD_REQUEST);     } +    async fn get_health(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/healthz", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let hr: HealthResponse = resp.json().await.unwrap();++        assert_eq!(hr.is_healthy, true);+    }++    async fn get_readiness(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/readiness", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let rr: ReadinessResponse = resp.json().await.unwrap();++        assert_eq!(rr.is_ready, true);+    }++    async fn get_metrics(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/metrics", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let body = resp.text().await.unwrap();++        assert!(body.contains("available_space"));+        assert!(body.contains("free_space"));+        assert!(body.contains("total_space"));++        assert!(!body.contains("total_manifest_requests{type=\"manifests\"} 0"));+        assert!(body.contains("total_manifest_requests{type=\"manifests\"} 6"));+        assert!(!body.contains("total_blob_requests{type=\"blobs\"} 0"));+        assert!(body.contains("total_blob_requests{type=\"blobs\"} 8"));++        get_manifest(&cl, "onename", "tag").await;+        let manifest_response = cl+            .get(&format!("{}/metrics", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        let manifest_body = manifest_response.text().await.unwrap();++        assert!(manifest_body.contains("total_manifest_requests{type=\"manifests\"} 7"));+        assert!(!manifest_body.contains("total_manifest_requests{type=\"manifests\"} 8"));++        get_non_existent_blob(&cl).await;+        let blob_response = cl+            .get(&format!("{}/metrics", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(blob_response.status(), StatusCode::OK);++        let blob_body = blob_response.text().await.unwrap();++        assert!(blob_body.contains("total_blob_requests{type=\"blobs\"} 9"));+        assert!(!blob_body.contains("total_blob_requests{type=\"blobs\"} 10"));

and this one

iamcaleberic

comment created time in 21 days

Pull request review commentContainerSolutions/trow

Feature/126 metrics

 mod interface_tests {         assert_eq!(resp.status(), StatusCode::BAD_REQUEST);     } +    async fn get_health(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/healthz", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let hr: HealthResponse = resp.json().await.unwrap();++        assert_eq!(hr.is_healthy, true);+    }++    async fn get_readiness(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/readiness", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let rr: ReadinessResponse = resp.json().await.unwrap();++        assert_eq!(rr.is_ready, true);+    }++    async fn get_metrics(cl: &reqwest::Client) {+        let resp = cl+            .get(&format!("{}/metrics", TROW_ADDRESS))+            .send()+            .await+            .unwrap();++        assert_eq!(resp.status(), StatusCode::OK);++        let body = resp.text().await.unwrap();++        assert!(body.contains("available_space"));+        assert!(body.contains("free_space"));+        assert!(body.contains("total_space"));++        assert!(!body.contains("total_manifest_requests{type=\"manifests\"} 0"));

Could you delete the asserts where you check something isn't a number, then verify it is a different number? They're just duplicating work - if something is 8, it can't be 0 by definition :)

iamcaleberic

comment created time in 21 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentContainerSolutions/trow

How to deploy an image with trow being protected with username/password

No problem.

Would you like to set-up a quick call to discuss some of this? Just drop an e-mail if so - you should be able to find my address on my profile.

Using persistent storage should be pretty simple and it's what we do in the standard install by default. Depending on your cluster, you should be able to do something like this: https://github.com/ContainerSolutions/trow/blob/master/install/base/stateful-set.yaml#L46-L53 which matches this https://github.com/ContainerSolutions/trow/blob/master/install/base/stateful-set.yaml#L29-L31

To be honest, I think you'd be better served by moving to the standard install and modifying it so that it works for your use case.

CreepDth

comment created time in 20 days

issue commentContainerSolutions/trow

How to deploy an image with trow being protected with username/password

You should be able to just follow the standard instructions: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

Did you remember to set imagePullSecrets on the pod? https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/#create-a-pod-that-uses-your-secret

We use this method internally, so it should definitely work. If you still have problems, could you post the YAML you're using?

CreepDth

comment created time in 22 days

issue commentContainerSolutions/trow

Helm install gives 404 Not Found

Great. I did see the same thing and wonder, apologies for not posting it earlier. I'll get the chart updated.

Thanks a lot for the report.

sab24

comment created time in a month

issue commentContainerSolutions/trow

Helm install gives 404 Not Found

Thanks for the report.

From looking at your output it doesn't seem than the ingress is forwarding to the pod correctly. I think there may be a mistake in the chart somewhere. I'll try to recreate this.

sab24

comment created time in a month

issue openedContainerSolutions/trow

Improve Install Docs

The current install docs are a bit all over the place:

  • The kustomize install instructions are under the install directory but the Helm instructions are under docs. I guess the best solution is to move the kustomize instructions but leave a placeholder in install pointing to the docs guide.
  • The Helm instructions could do with a bit more context and explanation, especially on TLS ingress and domain names. But some of this is already in the Kustomize instructions, so there might be a way to merge the two.

created time in a month

push eventContainerSolutions/trow

Adrian Mouat

commit sha d61d0a939e482bfadc2253f9bc38bdfc5e51d66a

Link Helm install properly. (#167)

view details

push time in a month

PR opened ContainerSolutions/trow

Link Helm install properly.
+22 -12

0 comment

3 changed files

pr created time in a month

create barnchContainerSolutions/trow

branch : install-docs

created branch time in a month

push eventContainerSolutions/trow

Adrian Mouat

commit sha 068ddb9ccb7ef4c9631c705c43af6492b2e89839

Use vendored version of openssl. Avoids builds problems.

view details

push time in a month

MemberEvent
MemberEvent

push eventContainerSolutions/terraform-mesos

Adrian Mouat

commit sha d2ba4901064af2340671af50c7b4a65cc2c3d4b4

Update README.md

view details

push time in a month

issue commentContainerSolutions/ImageWolf

Project status

Yes, that's the plan. Unfortunately it's taking a bit longer than I hoped. Trow is a working registry now, but still needs a couple of basic features before I want to move on tackling the ImageWolf stuff (which I normally refer to as "advanced distribution").

I'm considering archiving this repo.

luisdavim

comment created time in a month

issue commentContainerSolutions/ImageWolf

RSS feed support for clusters that don't allow inbound connections

Hi @luisdavim - apologies, I never saw this comment until now!

That's an interesting idea. It's not something I'd thought about before. I guess you're effectively changing a push webhook into a polling pull?

luisdavim

comment created time in a month

issue closedContainerSolutions/prometheus-swarm-discovery

Prometheus Native Docker Swarm integration

Dear community

The coming prometheus release, Prometheus 2.20, contains native support for Docker Swarm.

Please try it and provide us with your feedback. This is highly appreciated.

https://prometheus.io/docs/prometheus/2.20/configuration/configuration/#dockerswarm_sd_config

closed time in a month

roidelapluie

issue commentContainerSolutions/prometheus-swarm-discovery

Prometheus Native Docker Swarm integration

Thanks @roidelapluie. I'm archiving this project now and closing this issue. I'm a bit sad we never maintained it properly :(

roidelapluie

comment created time in a month

issue closedContainerSolutions/prometheus-swarm-discovery

Base image is a bit big

Looks like we've got 631MB, and that's very big and should be fairly easy to reduce. Just reporting i it here for the record, it's not critical at this stage.

closed time in a month

errordeveloper

issue commentContainerSolutions/prometheus-swarm-discovery

Base image is a bit big

This was closed by #8

errordeveloper

comment created time in a month

issue commentContainerSolutions/prometheus-swarm-discovery

Prometheus Native Docker Swarm integration

@prologic I'm sorry, I have no idea and the author of this repository left Container Solutions. You might have more luck on the prometheus slack or GitHub repo.

roidelapluie

comment created time in a month

pull request commentContainerSolutions/prometheus-swarm-discovery

Ignore exposed ports during explicit discovery mode

Hi @jhoglin . I work at Container Solutions and I'm currently going through all our open source projects.

I'd like to apologise that you never got a reply for this PR. This definitely isn't the experience we're aiming for with our projects :(

I'm about to archive this project as it's unmaintained and there is now native support in prometheus, but I'll merge your PR anyway. Thanks for your work!

jhoglin

comment created time in a month

push eventContainerSolutions/prometheus-swarm-discovery

Jonas Höglin

commit sha a378fe4ecd5f53009a4c6ec620379b7eaeb7c7ad

Update readme about discovery flag

view details

Jonas Höglin

commit sha 4e85bad0b9529d85c0e108c26f69c2aca0c26e3c

ignore exposed ports during explicit discovery

view details

Adrian Mouat

commit sha 35c3fe412aef2b30a21d36828142208b36a7ebb0

Merge pull request #10 from jhoglin/master Ignore exposed ports during explicit discovery mode

view details

push time in a month

PR merged ContainerSolutions/prometheus-swarm-discovery

Ignore exposed ports during explicit discovery mode

During explicit discovery mode only collect ports specified in label. This is helpful if your container expose some ports not serving metrics.

Explicit discovery already ignores all containers not labelled prometheus.scan=true, with this change you also need to explicitly label containers with the port to collect. prometheus.port=8080.

+10 -5

1 comment

2 changed files

jhoglin

pr closed time in a month

pull request commentContainerSolutions/prometheus-swarm-discovery

Remove dependencies while building in Dockerfile

I closed this via #8.

Again, apologies that there was no communication.

mion00

comment created time in a month

pull request commentContainerSolutions/prometheus-swarm-discovery

Reduce docker image size to ~14MB

Hi @ymatsiuk . I work at Container Solutions and I'm currently going through all our open source projects.

I'd like to apologise that you never got a reply. This definitely isn't the experience we're aiming for with our projects.

I'm about to archive this project as it's unmaintained and there is now native support, but I'll merge your PR. Thanks for your work!

ymatsiuk

comment created time in a month

push eventContainerSolutions/prometheus-swarm-discovery

Yurii Matsiuk

commit sha 290d94059d8257eb59b7b6c06b71ed8bc86cbb8a

Reduced image size to ~14MB

view details

Adrian Mouat

commit sha 35e8852c3c5d47e229333c3ba951a062d00a9b25

Merge pull request #8 from ymatsiuk/master Reduce docker image size to ~14MB

view details

push time in a month

PR merged ContainerSolutions/prometheus-swarm-discovery

Reduce docker image size to ~14MB

Use docker multi-stage build feature to reduce image size.

+11 -11

0 comment

1 changed file

ymatsiuk

pr closed time in a month

push eventContainerSolutions/prometheus-swarm-discovery

Carlo Mion

commit sha c6f1401327a23fb404525d012321e165e2ff7308

Fix task labels lookup

view details

Adrian Mouat

commit sha 4461149c56f08fcf3bf33f1fa448910324c561f2

Merge pull request #4 from mion00/fix_tasks_labels Fix task labels lookup

view details

push time in a month

PR merged ContainerSolutions/prometheus-swarm-discovery

Fix task labels lookup

According to #1, the task labels should be used in the target discovery, but the Task object does not have directly a Labels attribute.

+1 -1

1 comment

1 changed file

mion00

pr closed time in a month

pull request commentContainerSolutions/prometheus-swarm-discovery

Fix task labels lookup

Hi @mion00 . I'm currently going through all Container Solution's open source projects.

I'd like to apologise that you never got a reply. This definitely isn't the experience we're aiming for with our projects.

I'm about to archive this project as it's unmaintained and there is now native support, but I'll merge your PR. Thanks for your work!

mion00

comment created time in a month

push eventContainerSolutions/prometheus-swarm-discovery

Adrian Mouat

commit sha a9649badb5cb45f49a5f8655bda757154e015387

Add archival notice

view details

push time in a month

issue commentContainerSolutions/trow

How to configure wildcard certificate to be used?

Thanks, that would be appreciated.

CreepDth

comment created time in a month

more