Pull request review commentjenkinsci/jenkins
Switch from maven-jenkins-dev-plugin to upstream jetty-maven-plugin
There is a description of the [building and debugging process]. If you want simply to have the `jenkins.war` file as fast as possible without tests, run: - mvn clean package -pl war -am -DskipTests -Dspotbugs.skip+```sh+mvn -am -pl war,bom -DskipTests -Dspotbugs.skip clean install+``` The WAR file will be created in `war/target/jenkins.war`. After that you can start Jenkins using Java CLI ([guide]). If you want to debug this WAR file without using Maven plugins, You can just start the executable with [Remote Debug Flags] and then attach IDE Debugger to it. -To compile and launch a development instance, run:+To launch a development instance, after the above command run: - mvn hudson-dev:run+```sh+mvn -f war jetty:run
Does it matter?
I think it does, for two reasons.
First, we produce unneccessary confusion. I was confused by the fact that one of the two steps for starting up Jenkins uses -pl and the other uses -f. I tried to figure out why this is important, so I had to consult the Maven help:
-f,--file <arg> Force the use of an alternate POM file (or directory with pom.xml)
-pl,--projects <arg> Comma-delimited list of specified reactor projects to build instead
of all projects. A project can be specified by [groupId]:artifactId
or by its relative path
This did not reveal a compelling reason for using different flags for module selection.
Second (as you already mentioned above), -pl executes the module build in the context of a multimodule project and thus honours the current state of the parent pom. -f performs an isolated build of a module, using the installed (possibly outdated) version of the parent pom.
I do think that this difference will cause subtle problems to some less experienced users.
comment created time in 9 minutes
pull request commentjenkinsci/jenkins
Switch from maven-jenkins-dev-plugin to upstream jetty-maven-plugin
I successfully tested hot reload of property files from resource bundles, localized help files, jelly and groovy layouts.
The command I used was mvn -pl war jetty:run.
comment created time in 10 hours
Pull request review commentjenkinsci/jenkins
Switch from maven-jenkins-dev-plugin to upstream jetty-maven-plugin
There is a description of the [building and debugging process]. If you want simply to have the `jenkins.war` file as fast as possible without tests, run: - mvn clean package -pl war -am -DskipTests -Dspotbugs.skip+```sh+mvn -am -pl war,bom -DskipTests -Dspotbugs.skip clean install+``` The WAR file will be created in `war/target/jenkins.war`. After that you can start Jenkins using Java CLI ([guide]). If you want to debug this WAR file without using Maven plugins, You can just start the executable with [Remote Debug Flags] and then attach IDE Debugger to it. -To compile and launch a development instance, run:+To launch a development instance, after the above command run: - mvn hudson-dev:run+```sh+mvn -f war jetty:run
Is there a specific reason to use -f here?
This option exists to force Maven to use an alternative pom file instead of pom.xml. But here it is used to select the module. For this task, -pl is more appropriate.
comment created time in 10 hours
issue commentAdoptOpenJDK/openjdk-docker
Docker images for JRE/JDK 11.0.5 and JRE/JDK 8u232
@dinogun Thanks a lot. The images are indeed available.
comment created time in 5 days
issue commentansible/galaxy
Namespace request for hamburger-software
@chouseknecht Thank you. Everything works.
comment created time in 6 days
created taghamburger-software/ansible-role-vmware_ubuntu_cloud_image
Ansible role for creating virtual machines based on the Ubuntu Cloud Image in a vSphere environment.
created time in 7 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 1f8b6741b70667e194a5a5d4d1456c6e60c511da
Release v4.0.0 under new Galaxy namespace "hamburger_software"
push time in 7 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha bc36a650a3671d3d1d12ea290d5ef57bf0e06d7b
Ubuntu 19.10 is available on Galaxy
commit sha b4eeeb70c85411bc0b2b6b38f26f6aeb66de2d8a
Release v4.0.0 under new namespace "hamburger_software"
push time in 7 days
issue commentAdoptOpenJDK/openjdk-docker
Docker image for JRE/JDK 11.0.5
Note: Same is valid for the current JRE/JDK 8u232. A release is available for most platforms, but the Docker image is missing.
comment created time in 7 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 335ca091d2a6cf8cc59e05ecc25c1ad209a19f80
Update role description
push time in 8 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 94c1b4c5864920c31c63379cc4abfdf6be4dfb10
vmware_guest_facts was renamed to vmware_guest_info
push time in 8 days
issue openedAdoptOpenJDK/openjdk-docker
Docker image for JRE/JDK 11.0.5
Java 11.0.5 was released on 2019/10/15.
AdoptOpenJDK offers releases for almost all platforms, but there still is no corresponding Docker image.
The most recent image listed on https://github.com/docker-library/docs/blob/master/adoptopenjdk/README.md#supported-tags-and-respective-dockerfile-links is 11.0.4_11.
created time in 9 days
issue openedansible/galaxy
Namespace request for hamburger-software
Namespace Request
Github Org Link
https://github.com/hamburger-software
Admins
albers deBFM martin-hs
created time in 9 days
issue openedansible/galaxy
Add Ubuntu 19.10 Eoan Ermine platform
Feature Request
Ansible Galaxy does not support the current Ubuntu release 19.10:
These queries do not find any matches:
- https://galaxy.ansible.com/api/v1/platforms/?release__icontains=eoan
- https://galaxy.ansible.com/api/v1/platforms/?release__icontains=ermine
Please add it to the list of supported platforms.
created time in 9 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 7bccaa1b7cbb1ca560847d753e5d8e0bec57e963
Galaxy does not yet support Eoan Ermine I remove it to avoid Galaxy import errors. Check for Availability with https://galaxy.ansible.com/api/v1/platforms/?release__icontains=eoan https://galaxy.ansible.com/api/v1/platforms/?release__icontains=ermine
push time in 9 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 21701744db13d0efc79ff7c14a49ddeda01636fe
Remove Eoan Ermine from metadata because galaxy does not support it yet. This avoids import errors. Check for Availability with https://galaxy.ansible.com/api/v1/platforms/?release__icontains=eoan https://galaxy.ansible.com/api/v1/platforms/?release__icontains=ermine
push time in 9 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha c235083310cfd1a29cee8c4f42356e1e320471fd
Ubuntu 19.04 is called "disco dingo" on Galaxy. Strange. All other releases use one word names.
push time in 12 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha e387f373fc5c68bab063a457a542dd303894f8d7
Add link to vmware_deploy_ovf module
push time in 12 days
Pull request review commentjenkinsci/mailer-plugin
Add missing German localized message
Default\ user\ e-mail\ suffix=Standardendung f\u00FCr E-Mail-Adressen Sender\ E-mail\ Address=E-Mail-Adresse des Absenders System\ Admin\ E-mail\ Address=E-Mail-Adresse des Systemadministrators Jenkins\ URL=Jenkins URL+Use\ SMTP\ Authentication=SMTP Authentifizierung verwenden
Done.
comment created time in 14 days
push eventalbers/mailer-plugin
commit sha b33787c47a108eff7d4d1ab364afffc8a3520236
Add missing German localized message Signed-off-by: Harald Albers <[email protected]>
push time in 14 days
pull request commentjenkinsci/mailer-plugin
Add missing German localized message
@daniel-beck PTAL
comment created time in 14 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 9af446ea8da180f10a2a8255839022e088061688
tested platforms updated
push time in 14 days
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 144ed81d2e5bd7d95a851f53a4544d9364cf709a
[docs] The role cannot be used with Ansible 2.8.6.
push time in 14 days
delete branch albers/docker-cli
delete branch : completion-builder-build-options
delete time in 15 days
PR opened ansible/ansible
SUMMARY
#62513 introduced a regression, which was fixed by @Akasurde in #59614. Unfortunately, this commit was only included in the 2.9 branch.
As a result, the vmware_deploy_ovf module is broken in the current 2.8.6 release. Usage yields
AttributeError: 'NoneType' object has no attribute 'ovfManager'
This PR backports @Akasurde's fix to the 2.8 release branch.
@Akasurde PTAL
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
vmware_deploy_ovf
ADDITIONAL INFORMATION
The error occurs because self.si is no longer initialized in the constructor but still being used.
The fix changes usage of self.si to self.content, which is initialized in the parent constructor.
pr created time in 16 days
push eventalbers/ansible
commit sha 68347e9f228ba0a451bbccba5ac634222c45ca4e
VMware: Fix Service Content calls in vmware_deploy_ovf Signed-off-by: Abhijeet Kasurde <[email protected]>
push time in 16 days
pull request commentdocker/cli
fixes #1923 Update stack command docs --orchestrator
@nabeel-shakeel The build fails because you changed the expected help messages in the tests but the actual help message is still unchanged. To make the tests pass, you also need to change the message here.
comment created time in 19 days
startedthaJeztah/docker-shell
started time in a month
issue commenteclipse-ee4j/yasson
Custom JsonbAdapter/JsonbSerializer not working on "known root types"
I also came across this issue when migrating a webapp from Wildfly 17.0.1.Final to 18.0.0.Final. Thanks for tracking down the issue to this particular code change, @deBFM.
comment created time in a month
push eventalbers/mailer-plugin
commit sha 650b651c2b524ced5281f4116ab8026875d038e1
[FIXED JENKINS-58727] Warn only if no build result exists
commit sha 07742b3b88f3d1b4ff54d057d49cf49d7272c343
Merge pull request #69 from albers/JENKINS-58727 [JENKINS-58727] Warn only if no build result exists
push time in a month
push eventalbers/mailer-plugin
commit sha cb393fb257a6c88cee2770954f5466a0c7b7fa17
Add missing German localized message Signed-off-by: Harald Albers <[email protected]>
push time in a month
Pull request review commentdocker/cli
Contrib: Make bash completion faster for services
__docker_complete_nodes() { # output to the IDs or names of matching items. This setting takes # precedence over the environment setting. __docker_services() {- local fields='$2' # default: service name only- [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && fields='$1,$2' # ID & name+ local format='{{.Name}}' # default: service name only+ [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}} {{.Name}}' # ID & name if [ "$1" = "--id" ] ; then- fields='$1' # IDs only+ format='{{.ID}}' # IDs only shift elif [ "$1" = "--name" ] ; then- fields='$2' # names only+ format='{{.Name}}' # names only shift fi- __docker_q service ls "$@" | awk "NR>1 {print $fields}"++ __docker_q service ls --quiet --format "$format" "$@"
ping @artheus
comment created time in a month
PR opened docker/cli
#2116 added bash completion for just the subcommand.
This PR extends completion to its options.
builder build is just an alias to image build, and so is the completion.
pr created time in a month
create barnchalbers/docker-cli
branch : completion-builder-build-options
created branch time in a month
push eventdocker/cli
commit sha 86ae871e0a229d08e7d9746a35fa71f5305dd7d7
Add bash completion for `builder build` Signed-off-by: Trapier Marshall <[email protected]>
commit sha e3060aa27c876eee76904b45cb71700b13e05be8
Merge pull request #2116 from trapier/bash-completion-builder-build Add bash completion for `builder build`
push time in a month
PR merged docker/cli
- What I did
Add builder build to bash completion.
- How I did it
Add builder build to bash completion.
- How to verify it
Source and docker builder <tab><tab>
- Description for the changelog N/A
- A picture of a cute animal (not mandatory but encouraged)
Photo by David Clode on Unsplash.
pr closed time in a month
PR opened jenkinsci/mailer-plugin
Fixes JENKINS-58727
This PR restricts the previously misleading warning
No mail will be sent out, as 'XXX' does not have a result yet. Please make sure you set a proper result in case of pipeline/build scripts.
to situations where no build result was set at the point of this plugin's execution.
pr created time in a month
fork albers/mailer-plugin
This plugin allows you to configure email notifications for build results
https://plugins.jenkins.io/mailer
fork in a month
issue commentlavabit/robox
dns servers hardcoded in generic/ubuntu1804
@nvtkaszpir This worked, thanks a lot. But I still do not see why a box called "generic" should require such a hack.
comment created time in a month
issue commentlavabit/robox
dns servers hardcoded in generic/ubuntu1804
Our internal DNS servers add resolution for several internal domains, which obviously are not available on external DNS servers. Therefore I cannot use this box.
comment created time in a month
push eventhamburger-software/ansible-role-vmware_ubuntu_cloud_image
commit sha 5b480284acbd95a654cd5d6bd18fc9d47441539e
Minor documentation updates
push time in 2 months
Pull request review commentdocker/cli
Contrib: Make bash completion faster for services
__docker_complete_nodes() { # output to the IDs or names of matching items. This setting takes # precedence over the environment setting. __docker_services() {- local fields='$2' # default: service name only- [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && fields='$1,$2' # ID & name+ local format='{{.Name}}' # default: service name only+ [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}} {{.Name}}' # ID & name if [ "$1" = "--id" ] ; then- fields='$1' # IDs only+ format='{{.ID}}' # IDs only shift elif [ "$1" = "--name" ] ; then- fields='$2' # names only+ format='{{.Name}}' # names only shift fi- __docker_q service ls "$@" | awk "NR>1 {print $fields}"++ __docker_q service ls --quiet --format "$format" "$@"
Please fix indentation here.
comment created time in 2 months
Pull request review commentdocker/cli
Contrib: Make bash completion faster for services
__docker_complete_nodes() { # output to the IDs or names of matching items. This setting takes # precedence over the environment setting. __docker_services() {- local fields='$2' # default: service name only- [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && fields='$1,$2' # ID & name+ local format='{{.Name}}' # default: service name only+ [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}} {{.Name}}' # ID & name if [ "$1" = "--id" ] ; then- fields='$1' # IDs only+ format='{{.ID}}' # IDs only shift elif [ "$1" = "--name" ] ; then- fields='$2' # names only+ format='{{.Name}}' # names only shift fi- __docker_q service ls "$@" | awk "NR>1 {print $fields}"++ __docker_q service ls -q --format "$format" --filter "name=$1"
Because you dropped the "$@" here, the behavior does not mach the documentation any more. Additional arguments are no longer considered but break the function.
I suggest you change this line to
__docker_q service ls --quiet --format "$format" "$@"
and add --filter "name=$current" to the function call in __docker_complete_services.
This way, the responsibility for filtering services stays in __docker_complete_services (where it belongs) and __docker_services does not change its semantics.
comment created time in 2 months
Pull request review commentdocker/cli
Contrib: Make bash completion faster for services
__docker_complete_nodes() { # output to the IDs or names of matching items. This setting takes # precedence over the environment setting. __docker_services() {- local fields='$2' # default: service name only- [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && fields='$1,$2' # ID & name+ local format='{{.Name}}' # default: service name only+ [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}},{{.Name}}' # ID & name if [ "$1" = "--id" ] ; then- fields='$1' # IDs only+ format='{{.ID}}' # IDs only shift elif [ "$1" = "--name" ] ; then- fields='$2' # names only+ format='{{.Name}}' # names only shift fi- __docker_q service ls "$@" | awk "NR>1 {print $fields}"++ __docker_q service ls -q --format "$format" --filter "name=$1"
I did some testing and can confirm that while it does not change the output (in our examples), --quiet in fact positively impacts the performance. I did not expect this, thanks for pointing me to this.
comment created time in 2 months
Pull request review commentdocker/cli
Contrib: Make bash completion faster for services
__docker_complete_nodes() { # output to the IDs or names of matching items. This setting takes # precedence over the environment setting. __docker_services() {- local fields='$2' # default: service name only- [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && fields='$1,$2' # ID & name+ local format='{{.Name}}' # default: service name only+ [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}},{{.Name}}' # ID & name
This does not work as expected if you export DOCKER_COMPLETION_SHOW_SERVICE_IDS=yes.
You will get a list of id,name pairs. Please change like this:
[ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}} {{.Name}}' # ID & name
comment created time in 2 months
Pull request review commentdocker/cli
Contrib: Make bash completion faster for services
__docker_complete_nodes() { # output to the IDs or names of matching items. This setting takes # precedence over the environment setting. __docker_services() {- local fields='$2' # default: service name only- [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && fields='$1,$2' # ID & name+ local format='{{.Name}}' # default: service name only+ [ "${DOCKER_COMPLETION_SHOW_SERVICE_IDS}" = yes ] && format='{{.ID}},{{.Name}}' # ID & name if [ "$1" = "--id" ] ; then- fields='$1' # IDs only+ format='{{.ID}}' # IDs only shift elif [ "$1" = "--name" ] ; then- fields='$2' # names only+ format='{{.Name}}' # names only shift fi- __docker_q service ls "$@" | awk "NR>1 {print $fields}"++ __docker_q service ls -q --format "$format" --filter "name=$1"
--format takes precedence over -q, so -q can be removed.
comment created time in 2 months