:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

Ok let me take a closer look at this. As the caller, we cannot possibly know not to use %q everywhere and we’ll keep making mistakes.

As far as I know color printing on windows is fixed in master. Can you compile master and see if it works?

%q is by design.

Are you using windows?

I am running this application on VM with ubuntu 18.04. New to kubernates and follow all the steps explained in readme.md. Commands I used to run this application

sudo minikube start --vm-driver=none
sudo skaffold run

output:

WARN[0000] Could not get minikube docker env, falling back to local docker daemon: getting minikube env: running [minikube docker-env --shell none]
 - stdout: ""
 - stderr: "* 'none' driver does not support 'minikube docker-env' command\n"
 - cause: exit status 64 
Generating tags...
 - emailservice -> emailservice:latest
 - productcatalogservice -> productcatalogservice:latest
 - recommendationservice -> recommendationservice:latest
 - shippingservice -> shippingservice:latest
 - checkoutservice -> checkoutservice:latest
 - paymentservice -> paymentservice:latest
 - currencyservice -> currencyservice:latest
 - cartservice -> cartservice:latest
 - frontend -> frontend:latest
 - loadgenerator -> loadgenerator:latest
 - adservice -> adservice:latest
Some taggers failed. Rerun with -vdebug for errors.
Checking cache...
 - emailservice: Not found. Building
 - productcatalogservice: Not found. Building
 - recommendationservice: Not found. Building
 - shippingservice: Not found. Building
 - checkoutservice: Not found. Building
 - paymentservice: Not found. Building
 - currencyservice: Not found. Building
 - cartservice: Not found. Building
 - frontend: Not found. Building
 - loadgenerator: Not found. Building
 - adservice: Not found. Building
Found [minikube] context, using local docker daemon.
Building [emailservice]...
Building [productcatalogservice]...
Building [recommendationservice]...

***** Above services successfully built. Error comes when building shippingservice at running dep command

Building [shippingservice]...

Step 6/15 : RUN dep ensure --vendor-only -v
 ---> Running in 16962493b090
(1/20) Wrote golang.org/x/sync@master
(2/20) Wrote github.com/googleapis/gax-go@v2.0.5
(3/20) Failed to write cloud.google.com/go@v0.40.0
(4/20) Failed to write google.golang.org/grpc@v1.22.0
(5/20) Failed to write google.golang.org/api@master
(6/20) Failed to write contrib.go.opencensus.io/exporter/stackdriver@v0.5.0
(7/20) Failed to write google.golang.org/appengine@v1.6.1
(8/20) Failed to write golang.org/x/sys@master
(9/20) Failed to write contrib.go.opencensus.io/exporter/jaeger@v0.2.0
(10/20) Failed to write github.com/sirupsen/logrus@v1.4.2
(11/20) Failed to write go.opencensus.io@v0.16.0
(12/20) Failed to write github.com/google/pprof@master
(13/20) Failed to write github.com/konsorten/go-windows-terminal-sequences@v1.0.2
(14/20) Failed to write github.com/uber/jaeger-client-go@v2.21.1
(15/20) Failed to write golang.org/x/text@v0.3.2
(16/20) Failed to write golang.org/x/oauth2@master
(17/20) Failed to write github.com/golang/protobuf@v1.3.1
(18/20) Failed to write golang.org/x/net@master
(19/20) Failed to write git.apache.org/thrift.git (from github.com/apache/thrift)@master
grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export cloud.google.com/go: 
	(1) failed to list versions for https://code.googlesource.com/gocloud: fatal: unable to access 'https://code.googlesource.com/gocloud/': Could not resolve host: code.googlesource.com
: exit status 128

failed to build: couldn't build "shippingservice": unable to stream build output: The command '/bin/sh -c dep ensure --vendor-only -v' returned a non-zero code: 1

googled a lot about this error. Their solution is to remove all vendor and source files in $GOPATH directory because dep command has some issues related to its cache but they run dep commnad on a local machine. and i am running inside container. I think if I remove that container and their corresponding image then it should be work. Forgive me for poor english but help me to resolve this issue as i am stuck on it for 1 week.
I dont know what exactly the error is. Sometimes it run successfully 19 steps (of dep command) out of 20, sometimes only 4 and sometimes it gives error while running dep command at productcatalogservice. Is this error occurred due to internet connectivity issues? It seems it doesn't. I know its a silly question but due to error dynamic nature of occurring, it just comes in my mind.

Sounds like a minikube issue. We can’t give support at this level unfortunately.

Go convention for abbrs is to name this CPU

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

Client-go, and by extension, kubectl, has the ability to run configurable commands to interactively prompt a user to authenticate. This system is known as client-go credential plugins.

Kubectl will only run credential plugins when it believes its STDOUT is an interactive TTY. Since kubens invokes kubectl get namespaces in a subshell, by default it causes kubectl to bypass its credential plugins.

Since kubens uses the STDOUT of kubectl get namespaces we also can't blindly redirect its STDOUT to that of the parent process.

The solution to allow kubens to work correctly with credential plugins is two part:

1. Check if the get namespaces command will succeed, if so, run it like normal
2. If the get namespaces command will fail, then run it again, interactively, by redirecting its inputs and outputs to those of the parent process. After the user successfully authenticates then run the get namespaces command one final time without any output redirection

Sounds about right.

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

Issue:

When using commands like kubens and kubens newnamespace in a windows cmd terminal, the output is shown but the part that is supposed to represent the color setting is not being sent correctly to the terminal and is instead being rendered out as text.

Command Prompt Output

C:\Users\username>kubens
default
username
kube-node-lease
kube-public
kube-system

Command Prompt Screenshot

Steps to Reproduce:

• Use Windows 10 (Version is 10.0.18363.815 as reported by the command prompt)
• Open Command Prompt (normal or Admin)
• Run kubens

Expected Result

It appears it is trying to color the username namespace as green to represent which one is the default namespace.

This is already fixed (see recently closed issues) but I need to make a release available. Thanks.

I think I've set up correctly with 85a8638 using skaffold. Frontend shows error:

[2020-04-15 15:07:36 +0000] [6] [INFO] Starting gunicorn 20.0.4
[2020-04-15 15:07:36 +0000] [6] [INFO] Listening at: http://0.0.0.0:8080 (6)
[2020-04-15 15:07:36 +0000] [6] [INFO] Using worker: threads
[2020-04-15 15:07:36 +0000] [9] [INFO] Booting worker with pid: 9
[2020-04-15 15:07:52 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[2020-04-15 15:07:56 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:07:58 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:00 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=dfb8f3be-a1fb-4ff1-a48f-07dafa24a345&password=password
[2020-04-15 15:08:02 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=dfb8f3be-a1fb-4ff1-a48f-07dafa24a345&password=password
[2020-04-15 15:08:04 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=dfb8f3be-a1fb-4ff1-a48f-07dafa24a345&password=password
[2020-04-15 15:08:11 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=dfb8f3be-a1fb-4ff1-a48f-07dafa24a345&password=password
[2020-04-15 15:08:11 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:13 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/2544223503 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20ecc29350>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/2544223503 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20deead090>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee9c6d0>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee5c410>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20deead350>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20ecc29410>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/1523820362 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee8ff10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:20 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/1523820362 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee9c4d0>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:21 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/2544223503 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee66a10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:21 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/2544223503 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee9dad0>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:21 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20ee478f50>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:21 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20deead490>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:22 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/1523820362 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20ee492a90>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:22 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee5aa10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:23 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee9dd10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:24 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee9c750>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:25 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/2544223503 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20ecc49510>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:25 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/3646654731 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee66d50>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:25 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/1523820362 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20ee4923d0>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:27 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee74110>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:28 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/2544223503 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20deead650>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:28 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:28 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/6907390275 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20ecc5e750>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:28 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee74e10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:29 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/8338298020 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee5c810>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:30 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/8338298020 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee5c610>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:31 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20deeadc10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:31 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/1523820362 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee8fc10>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:31 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/6907390275 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee9c790>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:32 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee9cd50>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:32 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/2544223503 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee7c890>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:33 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/2544223503 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee66e50>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:34 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/1523820362 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee5a390>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:34 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/3646654731 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee78c90>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:34 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/8338298020 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20ee492e90>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:35 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/6907390275 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee81290>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:37 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/3646654731 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dfdccf10>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:37 +0000] [9] [ERROR] HTTPConnectionPool(host='transactionhistory', port=8080): Max retries exceeded with url: /transactions/8338298020 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20deead750>, 'Connection to transactionhistory timed out. (connect timeout=3)'))
[2020-04-15 15:08:37 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/2544223503 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20deeadc50>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:38 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/1523820362 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20ecc49b10>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:39 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/6907390275 (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f20dee5c5d0>: Failed to establish a new connection: [Errno 111] Connection refused'))
[2020-04-15 15:08:41 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/3646654731 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee66ed0>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:41 +0000] [9] [ERROR] HTTPConnectionPool(host='balancereader', port=8080): Max retries exceeded with url: /balances/8338298020 (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dedc71d0>, 'Connection to balancereader timed out. (connect timeout=3)'))
[2020-04-15 15:08:42 +0000] [9] [ERROR] HTTPConnectionPool(host='ledgerwriter', port=8080): Max retries exceeded with url: /transactions (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20deead3d0>, 'Connection to ledgerwriter timed out. (connect timeout=3)'))
[2020-04-15 15:08:42 +0000] [9] [ERROR] HTTPConnectionPool(host='ledgerwriter', port=8080): Max retries exceeded with url: /transactions (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f20dee7c150>, 'Connection to ledgerwriter timed out. (connect timeout=3)'))
[2020-04-15 15:08:45 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:45 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[2020-04-15 15:08:50 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[2020-04-15 15:08:52 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[2020-04-15 15:08:54 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:08:56 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[2020-04-15 15:08:58 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
[2020-04-15 15:08:59 +0000] [9] [ERROR] 404 Client Error: NOT FOUND for url: http://userservice:8080/login?username=b400e03a-7528-4ae1-9387-503593a26431&password=password
[2020-04-15 15:14:49 +0000] [9] [ERROR] Exception on /payment [POST]
Traceback (most recent call last):
  File "/env/lib/python3.7/site-packages/flask/app.py", line 2447, in wsgi_app
    response = self.full_dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1952, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1821, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/env/lib/python3.7/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1950, in full_dispatch_request
    rv = self.dispatch_request()
  File "/env/lib/python3.7/site-packages/flask/app.py", line 1936, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/vmagent/app/flask_server.py", line 139, in payment
    _submit_transaction(transaction_data)
  File "/home/vmagent/app/flask_server.py", line 212, in _submit_transaction
    raise UserWarning(resp.json().get('msg', ''))
  File "/env/lib/python3.7/site-packages/requests/models.py", line 898, in json
    return complexjson.loads(self.text, **kwargs)
  File "/opt/python3.7/lib/python3.7/json/__init__.py", line 348, in loads
    return _default_decoder.decode(s)
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/opt/python3.7/lib/python3.7/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

🤔 should we be patching existing services with defaults?

imagine I deployed a previous revision with default (512mib), then I go and update manually to 1GiB, then redeploy using button, now I get back 512Mib.

so I think we should omit this part of the change.

Ouch, I expected this would happen somewhere. Let me know if you need help.

Very much relevant. I don’t see a reason why it wouldn’t be.

Not sure why this logic is duplicated in go though (checked this other

PR: https://github.com/ahmetb/kubectx/pull/215/files )

Can you elaborate this please? Not sure if I understood.

When running kubens -h, the output shows kubectx instead of kubens in the usage examples:

$ kubens -h
USAGE:
  kubectx                    : list the namespaces in the current context
  kubectx <NAME>             : change the active namespace of current context
  kubectx -                  : switch to the previous namespace in this context
  kubectx -c, --current      : show the current namespace
  kubectx -h,--help          : show this message

This is on version 0.9.0 running on Ubuntu 20.04, obtained from the kubens_v0.9.0_linux_x86_64.tar.gz asset in the releases page.

#210 fixed this but not released yet.

Thanks! My use case for this was to keep Java services (which take longer to boot) around longer. That’s why per-Revision granularity would be most preferable to the majority of the audience for this knob. I guess I can live with the global CM setting as well, but it kinda defeats the purpose of having this feature in the first place.

Hi, some secrets are being loaded on startup, but I did not set the right permissions for the secret resources. I want to restart the revision/service/container so that it would try to get the secrets again.

App Engine Flexible has a way to "restart" it by deleting the instance. I wonder if Cloud Run has something similar, but I could not find it. Wondering if you guys have better luck figuring out how to do it.

There’s no instance management like that in Cloud Run. :) Deploy a new revision and switch traffic to the new one.

~/.kube is intentional. We have to keep using HOME to respect kubectl standards and backwards-compatibility.

Thanks I think we just fixed it on #220.

It’s usually preferable if the maintainer of the repo sends a PR as they get to decide on the name of the plugin and update it when it’s time.

For example https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/ requires awareness of the repo owner etc. Makes sense?

I am assuming you havent checked out the fzf integration we have.

I was trying to find out how to set up test environment with Cloud Run to be available for selected users, for example i have front end application deployed to CloudRun, how is it possible to restrict permissions? There is some information about logging in using curl and so on, but it all looks more like back-end authentication for specific routes, what about testing your app on mobile before releasing, google only mentions log in users sending requests with auth token headers and so on. P.S Maybe there is another better solution to deploy to test environment and have a whitelisted IP addresses?

Thanks

To some extent https://cloud.google.com/run/docs/authenticating/end-users but with future integration with Cloud IAP it will get better.

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

@Kyrremann would you consider using https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/ in the future?

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

Output on Windows showed the ANSI escape sequences. This uses the colorable writers to display the colored output.

Tested in PowerShell, PowerShell Core, and WSL.

Ah! Then let's go with your solution for now.

Ah! Then let's go with your solution for now.

That one’s fine but it doesn't make a functional difference. If you wanna fix just that, we can do it.

Also in the rest of the patch I see h3’s changed to h1’s, I'm not sure why a linter would do that. So changes like these aren't worth your time or mine. I'd say just abandon the PR. :)

/lifecycle frozen

/lifecycle frozen

Quite a few of these are actually malicious. Go code typically uses tab for indentation; not spaces, but markdown linter doesn't recognize that.

TBH this adds little value so I recommend we don't bother with this. Plus the project isn't very active. I don't want to accidentally break something with this.

Looks like a temporary issue, or an issue with your setup. Could not resolve host: github.com we can't do anything about this.

Hi,

Got a problem at the skaffold run when he try to build the cart service:

Building [cartservice]...
Sending build context to Docker daemon  273.9kB
Step 1/10 : FROM microsoft/dotnet:2.1-sdk-alpine as builder
2.1-sdk-alpine: Pulling from microsoft/dotnet
cbdbe7a5bc2a: Already exists 
d667ccf3befd: Pull complete 
bf7561de866c: Pull complete 
6308d68c72b9: Pull complete 
935bb86ac9ca: Pull complete 
Digest: sha256:6f5412227ca855221baf491a65397069b6f8cab64cdfad621c4ba31090e01632
Status: Downloaded newer image for microsoft/dotnet:2.1-sdk-alpine
 ---> 82c3a822b715
Step 2/10 : WORKDIR /app
 ---> Running in 1c6bc4145e7e
 ---> 05ac9b01379a
Step 3/10 : COPY . .
 ---> 8aab70a8a6bb
Step 4/10 : RUN dotnet restore &&     dotnet build &&     dotnet publish -c release -r linux-musl-x64 -o /cartservice
 ---> Running in a959d722e79f
  Restore completed in 10.8 sec for /app/cartservice.csproj.
Microsoft (R) Build Engine version 16.2.37902+b5aaefc9f for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 35.19 ms for /app/cartservice.csproj.
  cartservice -> /app/bin/Debug/netcoreapp2.1/cartservice.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:03.84
Microsoft (R) Build Engine version 16.2.37902+b5aaefc9f for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restore completed in 7.7 sec for /app/cartservice.csproj.
  cartservice -> /app/bin/release/netcoreapp2.1/linux-musl-x64/cartservice.dll
  cartservice -> /cartservice/
 ---> c41f7144fedc
Step 5/10 : FROM alpine:3.8
3.8: Pulling from library/alpine
486039affc0a: Pull complete 
Digest: sha256:2bb501e6173d9d006e56de5bce2720eb06396803300fe1687b58a7ff32bf4c14
Status: Downloaded newer image for alpine:3.8
 ---> c8bccc0af957
Step 6/10 : RUN GRPC_HEALTH_PROBE_VERSION=v0.2.0 &&     wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 &&     chmod +x /bin/grpc_health_probe
 ---> Running in 894cb6c4f1ad
 ---> fd1c5a2c8a1c
Step 7/10 : RUN apk add --no-cache     busybox-extras     libc6-compat     libunwind     libuuid     libgcc     libstdc++     libintl     icu
 ---> Running in 3f9584d7d285
fetch http://dl-cdn.alpinelinux.org/alpine/v3.8/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.8/community/x86_64/APKINDEX.tar.gz
(1/9) Installing busybox-extras (1.28.4-r3)
Executing busybox-extras-1.28.4-r3.post-install
(2/9) Installing libgcc (6.4.0-r9)
(3/9) Installing libstdc++ (6.4.0-r9)
(4/9) Installing icu-libs (60.2-r3)
(5/9) Installing icu (60.2-r3)
(6/9) Installing libc6-compat (1.1.19-r11)
(7/9) Installing libintl (0.19.8.1-r2)
(8/9) Installing libunwind (1.2.1-r1)
(9/9) Installing libuuid (2.32-r0)
Executing busybox-1.28.4-r3.trigger
OK: 37 MiB in 22 packages
 ---> 8d2651775bf2
Step 8/10 : WORKDIR /app
 ---> Running in 0aa3a555ee44
 ---> 8a0b47165e95
Step 9/10 : COPY --from=builder /cartservice .
 ---> f3bc29f10a1f
Step 10/10 : ENTRYPOINT ["./cartservice", "start"]
 ---> Running in 9d6b133ec78a
 ---> 5f202b779ab6
Successfully built 5f202b779ab6
Successfully tagged cartservice:v0.1.4-23-g05758f5
Building [frontend]...
Sending build context to Docker daemon  4.221MB
Step 1/16 : FROM golang:1.12-alpine as builder
 ---> 76bddfb5e55e
Step 2/16 : RUN apk add --no-cache ca-certificates git &&       wget -qO/go/bin/dep https://github.com/golang/dep/releases/download/v0.5.0/dep-linux-amd64 &&       chmod +x /go/bin/dep
 ---> Using cache
 ---> ab30cc542f67
Step 3/16 : ENV PROJECT github.com/GoogleCloudPlatform/microservices-demo/src/frontend
 ---> Running in 713c150aab32
 ---> a8e75309700e
Step 4/16 : WORKDIR /go/src/$PROJECT
 ---> Running in 3852e7b586ae
 ---> da62f67b6d17
Step 5/16 : COPY Gopkg.* ./
 ---> 4f8e5851d715
Step 6/16 : RUN dep ensure --vendor-only -v
 ---> Running in 4c0629d5d221
(1/22) Wrote contrib.go.opencensus.io/exporter/stackdriver@v0.5.0
(2/22) Wrote golang.org/x/oauth2@master
(3/22) Wrote github.com/pkg/errors@v0.8.1
(4/22) Wrote contrib.go.opencensus.io/exporter/jaeger@v0.2.0
(5/22) Wrote github.com/google/uuid@v1.1.1
(6/22) Wrote golang.org/x/net@master
(7/22) Wrote golang.org/x/sync@master
(8/22) Wrote google.golang.org/appengine@v1.6.1
(9/22) Wrote github.com/google/pprof@master
(10/22) Wrote github.com/gorilla/mux@v1.7.3
(11/22) Wrote google.golang.org/grpc@v1.22.0
(12/22) Failed to write github.com/googleapis/gax-go@v2.0.5
(13/22) Failed to write github.com/konsorten/go-windows-terminal-sequences@v1.0.2
(14/22) Failed to write github.com/sirupsen/logrus@v1.4.2
(15/22) Failed to write github.com/uber/jaeger-client-go@v2.21.1
(16/22) Failed to write go.opencensus.io@v0.16.0
(17/22) Failed to write golang.org/x/sys@master
(18/22) Failed to write github.com/golang/protobuf@v1.3.1
(19/22) Failed to write cloud.google.com/go@v0.40.0
(20/22) Failed to write golang.org/x/text@v0.3.2
(21/22) Failed to write google.golang.org/genproto@master
(22/22) Failed to write google.golang.org/api@master
grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/googleapis/gax-go: failed to fetch source for https://github.com/googleapis/gax-go: unable to get repository: Cloning into '/go/pkg/dep/sources/https---github.com-googleapis-gax--go'...
fatal: unable to access 'https://github.com/googleapis/gax-go/': Could not resolve host: github.com
: command failed: [git clone --recursive -v --progress https://github.com/googleapis/gax-go /go/pkg/dep/sources/https---github.com-googleapis-gax--go]: exit status 128
failed to build: couldn't build "frontend": unable to stream build output: The command '/bin/sh -c dep ensure --vendor-only -v' returned a non-zero code: 1
 π demo-skaffold master ❯ 

but a git clone without output path seems to work

git clone --recursive -v --progress https://github.com/googleapis/gax-go
Cloning into 'gax-go'...
POST git-upload-pack (142 bytes)
POST git-upload-pack (680 bytes)
remote: Enumerating objects: 45, done.
remote: Counting objects: 100% (45/45), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 345 (delta 18), reused 25 (delta 10), pack-reused 300
Receiving objects: 100% (345/345), 115.91 KiB | 2.23 MiB/s, done.
Resolving deltas: 100% (183/183), done.

Currently we probably are hammering the api during the 4 minute period non-stop as quick as the GetService returns. This might cause users to potentially hit a rate limit error (causing run-button to fail itself).

So adding a 2 second time period to cool things down. Since it corresponds to max 120 calls over 240 secs it should be ok for now.

cc: @jamesward

I say this because I don't want us to accidentally forget passing the streams around. There might be other streams that reference os.Std{err,out} (such as default log pkg log.Printf).

I have an alternative proposal, let's create a cmdutil.SetOutputStreams() method and just call os.Stderr = color.Error (+out) in func init() of both programs.

Thanks for fixing. What's the context here? Which API is taking longer?

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/score.yaml is not a straightforward version bump: could not find the old/new version spec in the diff

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/score.yaml is not a straightforward version bump: could not find the old/new version spec in the diff

hello, I would like to propose a file with egress rule to allow traffic: to a application pod in a namespace For sure, i have tested on my local lab many times. Please review it

Thank you Vinh

Your YAML is in pretty bad shape. Plus I need to know which CNI plugins you've tested this with. If it's not broadly supported it won't work for this repo.

I also don't understand what you mean by your sentences above, and most likely visitors won't either. Maybe mature this a bit more and open another PR?

Is it really just 2GiB disk and doesn’t resize?

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

cc: @corneliusweig I think this might be worth following up in prow repo. After LGTM removed the PR should’ve been removed from merge queue.

Hope you consider using https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/ in the future.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/preflight.yaml is not a straightforward version bump: changing old version ("0.9.31") with new version ("0.9.32") in the url (https://github.com/replicatedhq/troubleshoot/releases/download/v0.9.31/preflight_windows_amd64.zip) does not appear in the patch as https://github.com/replicatedhq/troubleshoot/releases/download/v0.9.32/preflight_windows_amd64.zip

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/support-bundle.yaml is not a straightforward version bump: changing old version ("0.9.31") with new version ("0.9.32") in the url (https://github.com/replicatedhq/troubleshoot/releases/download/v0.9.31/support-bundle_windows_amd64.zip) does not appear in the patch as https://github.com/replicatedhq/troubleshoot/releases/download/v0.9.32/support-bundle_windows_amd64.zip

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

https://krew.sigs.k8s.io/ is our home page.

For plugin development we have a guide that doesn't talk about Krew:

• https://krew.sigs.k8s.io/docs/developer-guide/develop/plugin-development/
• https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/
• https://krew.sigs.k8s.io/docs/developer-guide/develop/best-practices/

Most interesting stuff we're doing nowadays is allowing people host plugins on decentralized indexes (as opposed to krew-index repo we have right now); https://github.com/kubernetes-sigs/krew/issues/566

Another interesting point is that we have a fully automated plugin update model in krew-index where bots create PR for new plugin versions tagged + bots approve those PRs, see an example in action here: https://github.com/kubernetes-sigs/krew-index/pull/597

For more talking points PTAL https://speakerdeck.com/alp/making-kubectl-plugins-mainstream.

As a CTA I'd like to point out we have a #krew channel on Kubernetes Slack.

Thanks a lot for putting this together! I’ll be there live in Chat (let me know if you ever need me to join w/ audio, happy to help).

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/eksporter.yaml is not a straightforward version bump: changing old version ("1.1.0") with new version ("1.3.0") in the url (https://github.com/Kyrremann/kubectl-eksporter/releases/download/v1.2.0/eksporter.tar.gz) does not appear in the patch as https://github.com/Kyrremann/kubectl-eksporter/releases/download/v1.2.0/eksporter.tar.gz

I’d open a Knative/Serving issue is you are not able to get WS working on Knative.

/assign @corneliusweig

I recommend packaging bash for O(months). I’ll be reaching out to all packagers once Go version is ready for prime-time.

@cablespaghetti thanks. Make sure to package only bash-based implementations for now. Go version is not ready for prime-time.

/lgtm

Doesn't sound like a bad idea. Though, it might be a little too burdensome to refactor. We already have a receiptsmigration package that uses old way of doing things, I'm not sure how these two would work together.

What if we detected receiptsmigration and told v0.2.x users:

This version is not supported anymore. Please manually migrate:
1. Uninstall Krew: [[link]]
2. Reinstall Krew: [[link]]
3. Install current plugins: kubectl krew install [...]

instead of mechanically trying to migrate?

@cablespaghetti let's keep it out for now, then we can probably move depending on the situation. right now many other packagers (debian, alpine) live outside this repo.

What would the path forward for users on 0.2 look like if the receipts migration was removed from 0.X?

At this point 0.2 was a long time ago. We also promised to delete it 0.4 or 0.5. Now that these issues are arising 0.4 sounds like a good time :) @corneliusweig to decide.

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request seems to straightforward. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

Fixed in eb923ca if you'd like to double-check.

That being said, we recommend it strongly for portability,.

many users observe additional ~2 seconds latency on cold starts

You need actual data for this claim. Otherwise, I think it might hurt more than help, as many would assume there is always a 2 second overhead. That's not true: the infrastructure barely adds a few 100ms and a go binary will start without any issues under 1s.

@steren It's actually up-to-date I think? Any problem with this:

### Can I place my Cloud Run application inside a VPC network?

Currently no (see [here](#can-i-run-cloud-run-applications-on-a-private-ip));
however, you can make requests to other resources inside the VPC network using
the "VPC Access Connector" (see next question).

### How to connect IPs in a VPC network from Cloud Run?

Cloud Run now has beta support for "VPC Access Connector". This feature allows
Cloud Run applications to be able to connect private IPs in the VPC (but not the
other way).

/lgtm /approve

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/rbac-view.yaml is not a straightforward version bump: diff line 19 unrecognized for version bumps: [+ - from: LICENSE]

I think a simple solution would be to move the index migration before the receipts migration (just a hunch, haven't dug too deep into it).

Doing index migration first, then receipts migration can open a can of worms. If we can maintain the current order, that would be the best (if there's an easy solution). If not, we can consider ripping out the receipts migration for the upcoming 0.X version.

I meant to say func.py. I will edit.

All buildpacks support Procfile, but it is not required for languages other than Python

I think this is definitely worth documenting as well. We can assume everyone knows and have used buildpacks to curate the docs, but that will leave out a lot of the first-time users.

So I'm in general happy with the current state in Node, Go etc. However almost always any non-trivial user will have to use cmd line args to customize this and that, so it is important probably to say "there's a file called Procfile and this is how you can use it".

cc: @jamesward

believe the samples repo has it to support the Heroku builder.

if that's the case we should prob delete that file to avoid confusion for buildpack-samples audience.