profile
viewpoint
Ahmet Alp Balkan ahmetb Google Seattle, WA https://twitter.com/ahmetb Senior software engineer at Google Cloud, on cloud-native technologies: Kubernetes/GKE and Cloud Run.

issue commentahmetb/gen-crd-api-reference-docs

[wip] Add support for kubebuilder v2

I am not actually sure if k8s.io/gengo/parser package can read values of consts/vars. So this is actually not useful GroupVersion = schema.GroupVersion{Group: "kubeflow.org", Version: "v1"} But as you said the // +groupName=kubeflow.org comment is still there.

I most probably will not be able to find the time to fix this so I recommend you give it a try.

It seems like we need to implement this as a "fallback" to the existing logic. Maybe you can read all packages, create a map of packages:groupNames (we get groupVersion from pkg name, e.g. /v1) and if the //+ comment is missing, try to read it from that map, and if that's missing, too, fail.

Ahmet Alp Balkan | Developer Advocate | github:@ahmetb http://github.com/ahmetb | twitter:@ahmetb https://twitter.com/ahmetb

On Fri, Jan 17, 2020 at 5:19 PM Zhenghui Wang notifications@github.com wrote:

Is it possible to consider type comments instead of package comments? For kubebuilder v2, some type comments contains // +groupName=...

Let's be more crisp here. Does every single type that correspond to a CRD actually have this field? (We currently inherit groupName for all types from that.) We currently have 1:1 mapping between "Go packages : groupName".

Let's first make sure these two assumptions still hold true.

To correct my observation: the groupName comments appear in groupversion_info.go at package level.

Examples:

https://github.com/kubeflow/kubeflow/blob/master/components/notebook-controller/api/v1/groupversion_info.go

https://github.com/kubeflow/kubeflow/blob/master/components/profile-controller/api/v1/groupversion_info.go

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ahmetb/gen-crd-api-reference-docs/issues/15?email_source=notifications&email_token=AABG32JNHYZGFFRSGSVXWUTQ6JKLLA5CNFSM4IW6LJ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJJMZLI#issuecomment-575851693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG32PVJ2AHRBO7TWWLC73Q6JKLLANCNFSM4IW6LJ5Q .

xrmzju

comment created time in 2 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH+      # temporary fix+      # see https://github.com/actions/setup-go/issues/14+      run: |+        set -euo pipefail+        echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)"+        echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin"+    +    - name: Install dependencies+      run: go mod download+    +    - name: Install gox+      run: hack/install-gox.sh+      +    - name: Verify code quality+      run: |+        set -euo pipefail+        go mod tidy +        git diff --no-patch --exit-code+        hack/verify-code-patterns.sh+        hack/verify-boilerplate.sh+        hack/run-lint.sh+        +    - name: Unittest and coverage+      run: go test -short -coverprofile=coverage.txt -covermode=atomic ./...+        +    - name: Make binaries && verify krew installation+      run: hack/make-all.sh+        +    - name: Ensure kubectl installed+      run: hack/ensure-kubectl-installed.sh+        +    - name: Integration tests+      run: |+        set -euo pipefail+        hack/verify-installation.sh+        hack/run-integration-tests.sh+    +    - name: Receipts upgrade migrations

You don't need names for these, not only they aren't quite accurate, they're just repeating what's in the script name.

alonyb

comment created time in 2 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH+      # temporary fix+      # see https://github.com/actions/setup-go/issues/14+      run: |+        set -euo pipefail+        echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)"+        echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin"+    +    - name: Install dependencies+      run: go mod download+    +    - name: Install gox+      run: hack/install-gox.sh+      +    - name: Verify code quality+      run: |+        set -euo pipefail+        go mod tidy +        git diff --no-patch --exit-code+        hack/verify-code-patterns.sh+        hack/verify-boilerplate.sh+        hack/run-lint.sh+        +    - name: Unittest and coverage+      run: go test -short -coverprofile=coverage.txt -covermode=atomic ./...+        +    - name: Make binaries && verify krew installation+      run: hack/make-all.sh+        +    - name: Ensure kubectl installed+      run: hack/ensure-kubectl-installed.sh+        +    - name: Integration tests+      run: |+        set -euo pipefail+        hack/verify-installation.sh

again, consider separating into two different steps, as they do different things.

alonyb

comment created time in 2 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH+      # temporary fix+      # see https://github.com/actions/setup-go/issues/14+      run: |+        set -euo pipefail+        echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)"+        echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin"+    +    - name: Install dependencies+      run: go mod download+    +    - name: Install gox+      run: hack/install-gox.sh+      +    - name: Verify code quality+      run: |+        set -euo pipefail+        go mod tidy +        git diff --no-patch --exit-code+        hack/verify-code-patterns.sh+        hack/verify-boilerplate.sh+        hack/run-lint.sh+        +    - name: Unittest and coverage

call it "Run unit tests"

alonyb

comment created time in 2 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH+      # temporary fix+      # see https://github.com/actions/setup-go/issues/14+      run: |+        set -euo pipefail+        echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)"+        echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin"+    +    - name: Install dependencies+      run: go mod download+    +    - name: Install gox+      run: hack/install-gox.sh+      +    - name: Verify code quality

What if we just separated each of these commands to separate steps?

Because in this mode, I can't tell (from the output) which one is failing.

In travis we had that.

Since the script names are quite self descriptive, you don't even need to specify name: for most.

alonyb

comment created time in 3 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH

the name isn't reflecting what's happening below. It sounds more like "Add GOPATH/bin to PATH"

alonyb

comment created time in 3 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags

you can drop name: since there's only 1 job.

alonyb

comment created time in 3 hours

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]

I think we don't need this if we do push.tags ? Can you explain how it helps?

alonyb

comment created time in 3 hours

pull request commentkubernetes-sigs/krew

Migrate to GitHub workflows

We can remove Codecov altogether, I haven't been finding it super useful to be honest.

alonyb

comment created time in 3 hours

pull request commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

Rather than the hosting of the image, the problem is to keep the API between container <=> service stable.

Since we don't use :latest in the image (and it would be dangerous to do so) any time we update the tag, we need to go update 20 other repos.

rajatjindal

comment created time in 3 hours

pull request commentkubernetes-sigs/krew-index

Update preflight to v0.9.18

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

moonlight16

comment created time in 4 hours

pull request commentkubernetes-sigs/krew-index

Update support-bundle to v0.9.18

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

moonlight16

comment created time in 4 hours

pull request commentkubernetes-sigs/krew-index

Update preflight to v0.9.18

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

moonlight16

comment created time in 4 hours

issue closedahmetb/cloud-run-faq

Is it possible to limit external access ?

Hi,

Is there a way to create a security group to limit access to the container's network?

I would like to execute user-generated code and thus avoid serving as a proxy for any kind of abuse or attack.

Is there a kind of security group feature somewhere that will allow to apply network rules on my container ?

Thanks

closed time in 4 hours

mediarl

issue commentahmetb/cloud-run-faq

Is it possible to limit external access ?

Google Cloud doesn't have the notion of "security groups". But it uses IAM to restrict access to certain users or groups. Read https://cloud.google.com/run/docs/authenticating/overview.

mediarl

comment created time in 4 hours

pull request commentgohugoio/hugo

deps: Update github.com/alecthomas/chroma

You the real champion @ghislainbourgeois. I'm excited to see this in a release soon.

ghislainbourgeois

comment created time in 6 hours

issue commentalecthomas/chroma

Can we tag a release?

Thanks much!

ghislainbourgeois

comment created time in 6 hours

pull request commentGoogleCloudPlatform/golang-samples

[HOLD] run: grpc-server-streaming sample

Thanks, I should've noticed that earlier. :)

ahmetb

comment created time in 7 hours

push eventahmetb/golang-samples

Ahmet Alp Balkan

commit sha e500c70c68779ba163ca0969721caec8982c0c2e

run: grpc-server-streaming sample Primarily forked and simplified run/grpc-ping. Currently not associated to any tutorial but can be deployed easily from instructions. It will be referred in a blog post. When there's a tutorial, it can be used from there as well (by adding appropriate region tags). Please **HOLD MERGING** until I give greenlight. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 7 hours

pull request commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

@corneliusweig tbh this is the "polished" experience compared to what it was before, and I suspect it's unlikely to change dramatically. I thought about image coming from a personal repo, but I think even that's OK for now. We just need to keep it static, as it works pretty decently at the moment.

rajatjindal

comment created time in 7 hours

Pull request review commentahmetb/kubectx

Add krew-release-bot support

+name: release+on:+  push:+    tags:+    - 'v*.*.*'+jobs:+  release:+    runs-on: ubuntu-latest+    steps:+    - name: Checkout+      uses: actions/checkout@master+    - name: Create Release

I actually think you don’t need to create a release. Every tag is sort of implicitly is a release. And we don’t upload files etc. yet the download link would still work without a release.

What do you think? Would that work with the bot?

rajatjindal

comment created time in 8 hours

pull request commentkubernetes-sigs/krew

Show updated plugin manifests and available upgrades

Can I just say: I LOVEEEEE how small this PR is.

I have only 2 concerns atm:

  • when first ever “update” is done, does it print everything as new (ideally should not)
  • it seems like the indentation in the output isnt that useful if the plugin list is gonna just flow over to the next line. I wonder if we can do something like print max 4-5 on each line and just add \n\t after each 5?

I am on the fence about whether we should add integration tests for this? Probably not in this PR since it’s not critical functionality.

artmello

comment created time in 20 hours

issue commentGoogleCloudPlatform/microservices-demo

update loadgenerator to be able to connect to external IP (with HTTPS)

We prefer not to introduce any new code branches for maintenance reasons. Feel free to fork and adapt to your changes.

prune998

comment created time in a day

pull request commentkubernetes-sigs/krew-index

release new version v0.2.4 of deprecations

It seems like it's stuck in merge pool over 1 hour. Let's see if it'll fix itself, or I'll merge manually later.

krew-release-bot

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

new plugin: net-forward

Yeah I hope you can address a few things later on:

  • Right now your description is too long, also don't assume people read it.
  • Make sure -h/--help works and has examples
  • Make sure your repo has enough docs or examples that point users in the right direction.
  • Your repo name has a krew- prefix, which doesn't really make sense. Krew is the package manager, and you're developing a "kubectl" plugin.

/approve

antitree

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

release new version v0.2.4 of deprecations

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

krew-release-bot

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

release new version v0.2.3 of deprecations

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

krew-release-bot

comment created time in 2 days

pull request commentkubernetes-sigs/krew-index

release new version v0.2.1 of deprecations

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request seems to be a straightforward version bump. I'll go ahead and accept it. :+1: Cheers.

/lgtm /approve

krew-release-bot

comment created time in 2 days

issue commentkubernetes-sigs/krew

wsl support ( krew 0.3.3)

Tried with kubectl v1.17 and krew 0.3.3. Not reproducible. Feel free to add more details then I can reopen. /close /area platform/windows

yanivpaz1973

comment created time in 2 days

issue commentkubernetes-sigs/krew

wsl support ( krew 0.3.3)

Whats your kubectl version?

yanivpaz1973

comment created time in 2 days

Pull request review commentahmetb/kubectx

Add krew-release-bot support

+apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: ctx+spec:+  homepage: https://github.com/ahmetb/kubectx+  shortDescription: Switch between contexts in your kubeconfig+  version: {{ .TagName }}+  description: |+    Also known as "kubectx", a utility to switch between context entries in+    your kubeconfig file efficiently.+  caveats: |+    If fzf is installed on your machine, you can interactively choose+    between the entries using the arrow keys, or by fuzzy searching+    as you type.+    See https://github.com/ahmetb/kubectx for customization and details.+  platforms:+  - selector:+      matchExpressions:+      - key: os+        operator: In+        values:+        - darwin+        - linux+    {{addURIAndSha "https://github.com/ahmetb/kubectx/archive/{{ .TagName }}.tar.gz" .TagName }}+    bin: kubectx+    files:+    - from: kubectx-*/kubectx+      to: .+    - from: kubectx-*/LICENSE+      to: .

Please instal .editorconfig to add newlines to files. Otherwise the bot will not be able to auto-approve this due to diff here.

rajatjindal

comment created time in 2 days

pull request commentahmetb/kubectx

Add krew-release-bot support

I appreciate the work but can you only reduce this to krew release bot?

Sadly most github workflow steps you listed are buggy because of how bash works. Undefined variables, pipe errors, failed commands not terminating the shell etc.

I don’t have time to iterate on those so let’s just limit this to bot release.

rajatjindal

comment created time in 2 days

Pull request review commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

 Ideally, the `version` specified should match the release tag of the plugin. This helps users and maintainers to easily identify which version of the plugin they have installed. +### Automating the releasing of new version++You can use github actions to publish new release of your krew plugin. `krew-release-bot`+is a github action to automatically bump the version in `krew-index` repo. Refer to the [documentation here](https://github.com/rajatjindal/krew-release-bot) for details.

80 char line wraps pls :)

please capitalize as GitHub Actions.

rajatjindal

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

 Ideally, the `version` specified should match the release tag of the plugin. This helps users and maintainers to easily identify which version of the plugin they have installed. +### Automating the releasing of new version++You can use `github actions` to automate the release process. e.g. You can use+`go-releaser` (or equivalent for other languages) for creation of new release and +[`krew-release-bot`](https://github.com/rajatjindal/krew-release-bot) to bump the +version in `krew-index` repo. Refer to the [documentation here](https://github.com/rajatjindal/krew-release-bot#basic-setup) for an example.

No need for #target link. Just link to your repo home. It should be concise enough for someone to understand how it works in 60 seconds or so. :)

rajatjindal

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

 Ideally, the `version` specified should match the release tag of the plugin. This helps users and maintainers to easily identify which version of the plugin they have installed. +### Automating the releasing of new version++You can use `github actions` to automate the release process. e.g. You can use

No need for e.g. here. You aren’t giving an example.

rajatjindal

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

 Ideally, the `version` specified should match the release tag of the plugin. This helps users and maintainers to easily identify which version of the plugin they have installed. +### Automating the releasing of new version

Automate releasing new versions on krew-index

rajatjindal

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

 Ideally, the `version` specified should match the release tag of the plugin. This helps users and maintainers to easily identify which version of the plugin they have installed. +### Automating the releasing of new version++You can use `github actions` to automate the release process. e.g. You can use+`go-releaser` (or equivalent for other languages) for creation of new release and 

Don’t mention goreleaser it is not relevant here.

rajatjindal

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew

add documentation about automating release using krew-release-bot

 Ideally, the `version` specified should match the release tag of the plugin. This helps users and maintainers to easily identify which version of the plugin they have installed. +### Automating the releasing of new version++You can use `github actions` to automate the release process. e.g. You can use

Don’t put github actions in code font?

rajatjindal

comment created time in 3 days

pull request commentkubernetes-sigs/krew-index

Add plugin: kubeval

/close Kubeval is already popular outside krew and there doesn’t seem to be enough interest to pursue this. So I will close.

nlamirault

comment created time in 3 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.3"       +  platforms:+  - selector:+      matchLabels:+        os: linux+    uri: https://github.com/antitree/krew-net-forward/releases/download/v1.0.3/net-forward_v1.0.3.tar.gz+    sha256: "645adb05d9ad68ecc91d9034cb80b1e2fe4762864323c12de0f2bc5afe20baa0"+    bin: "net-forward"  +  shortDescription: "Setup a true forwarder from your local machine to any TCP service accessible from within the cluster."

From what I'm reading in the PR description this tool does this:

Make local endpoints available in the cluster

antitree

comment created time in 4 days

issue commentahmetb/gen-crd-api-reference-docs

[wip] Add support for kubebuilder v2

Is it possible to consider type comments instead of package comments? For kubebuilder v2, some type comments contains // +groupName=...

Let's be more crisp here. Does every single type that correspond to a CRD actually have this field? (We currently inherit groupName for all types from that.) We currently have 1:1 mapping between "Go packages : groupName".

Let's first make sure these two assumptions still hold true.

xrmzju

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

Migrate to GitHub workflow

+name: krew-index CI++on:+- push+- pull_request++jobs:+  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    env: +      KREW_VERSION: v0.3.3+      GO111MODULE: on+    steps:++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2++    - name: Install kubectl+      run: |+        sudo curl -fsSL -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.13.1/bin/linux/amd64/kubectl+        sudo chmod +x /usr/bin/kubectl++    - name: Install krew+      shell: bash+      run: |+        cd "$(mktemp -d)" &&+        curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/download/${KREW_VERSION}/krew.{tar.gz,yaml}" &&+        tar zxvf krew.tar.gz &&+        ./krew-linux_amd64 install --manifest=krew.yaml --archive=krew.tar.gz+        +    - name: Validate updated plugin manifests+      run: |+        set -u

I think we can keep shell: bash (I assume that is the default), and still set -euo pipefail instead of relying on Github to pull the rug under us in the future.

alonyb

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.3"       +  platforms:+  - selector:+      matchLabels:+        os: linux+    uri: https://github.com/antitree/krew-net-forward/releases/download/v1.0.3/net-forward_v1.0.3.tar.gz+    sha256: "645adb05d9ad68ecc91d9034cb80b1e2fe4762864323c12de0f2bc5afe20baa0"+    bin: "net-forward"  +  shortDescription: "Setup a true forwarder from your local machine to any TCP service accessible from within the cluster."

to me the problem with those two are:

Forward to arbitrary TCP services

isn't that what port-forward does? forward tcp traffic to services on a local port?

Like kubectl port-forward but to arbitrary services

ditto, "isn't this what port-forward is for"?

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH+      # temporary fix+      # see https://github.com/actions/setup-go/issues/14+      run: |+        echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)"+        echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin"+      shell: bash+    +    - name: Install gox+      run: |+        go mod download+        hack/install-gox.sh\++    - name: Install dependencies+      run: go mod tidy && git diff --no-patch --exit-code+      +    - name: Verify code quality+      run: |

+1 separating each script into a step (just like they were in .travis.yml) is much better than a single opaque script.

alonyb

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.3"       +  platforms:+  - selector:+      matchLabels:+        os: linux+    uri: https://github.com/antitree/krew-net-forward/releases/download/v1.0.3/net-forward_v1.0.3.tar.gz+    sha256: "645adb05d9ad68ecc91d9034cb80b1e2fe4762864323c12de0f2bc5afe20baa0"+    bin: "net-forward"  +  shortDescription: "Setup a true forwarder from your local machine to any TCP service accessible from within the cluster."

IMO neither of these really explain much.

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.3"       +  platforms:+  - selector:+      matchLabels:+        os: linux+    uri: https://github.com/antitree/krew-net-forward/releases/download/v1.0.3/net-forward_v1.0.3.tar.gz+    sha256: "645adb05d9ad68ecc91d9034cb80b1e2fe4762864323c12de0f2bc5afe20baa0"+    bin: "net-forward"  

This isnt really short :) Can you please make it half as short.

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.3"       +  platforms:+  - selector:+      matchLabels:+        os: linux+    uri: https://github.com/antitree/krew-net-forward/releases/download/v1.0.3/net-forward_v1.0.3.tar.gz+    sha256: "645adb05d9ad68ecc91d9034cb80b1e2fe4762864323c12de0f2bc5afe20baa0"+    bin: "net-forward"  +  shortDescription: "Setup a true forwarder from your local machine to any TCP service accessible from within the cluster."+  homepage: https://github.com/antitree/krew-net-forward+  caveats: |+    This plugin needs the alpine:socat image available to the node:

Ends with : ?

antitree

comment created time in 4 days

issue commentkubernetes-sigs/krew

Design a logo for Krew

I vote towards nr.3 above.

ahmetb

comment created time in 4 days

issue commentahmetb/gen-crd-api-reference-docs

[wip] Add support for kubebuilder v2

I encourage you to take a look at the source code.

We heavily rely on //+ comments for discovering certain things like apiGroups, optional fields etc.

If there's an alternative way we can discover these things, we can make code changes. The code is pretty straightforward, search for ExtractCommentTags ,//+ , // + etc.

Maybe there's an easy fix.

xrmzju

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

Migrate to GitHub workflow

+name: krew-index CI++on:+- push+- pull_request++jobs:+  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    env: +      KREW_VERSION: v0.3.3+      GO111MODULE: on+    steps:++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2++    - name: Install kubectl+      run: |+        sudo curl -fsSL -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.13.1/bin/linux/amd64/kubectl+        sudo chmod +x /usr/bin/kubectl++    - name: Install krew+      shell: bash+      run: |+        cd "$(mktemp -d)" &&+        curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/download/${KREW_VERSION}/krew.{tar.gz,yaml}" &&

similarly if this can't access ${KREW_VERSION} it will not fail.

I want to see set -euo pipefail everywhere more than a single command is executed, or there are pipes or there are variables in the run: block.

alonyb

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

Migrate to GitHub workflow

+name: krew-index CI++on:+- push+- pull_request++jobs:+  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    env: +      KREW_VERSION: v0.3.3+      GO111MODULE: on+    steps:++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2++    - name: Install kubectl+      run: |+        sudo curl -fsSL -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.13.1/bin/linux/amd64/kubectl

you need set -e. we discussed this before, only last command of a shell causes a shell failure. if curl fails here, this command will still succeed because you didn't do set -e or use &&.

alonyb

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

Migrate to GitHub workflow

+name: krew-index CI++on:+- push+- pull_request++jobs:+  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    env: +      KREW_VERSION: v0.3.3+      GO111MODULE: on+    steps:++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2++    - name: Install kubectl+      run: |+        sudo curl -fsSL -o /usr/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.13.1/bin/linux/amd64/kubectl+        sudo chmod +x /usr/bin/kubectl++    - name: Install krew+      shell: bash+      run: |+        cd "$(mktemp -d)" &&+        curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/download/${KREW_VERSION}/krew.{tar.gz,yaml}" &&+        tar zxvf krew.tar.gz &&+        ./krew-linux_amd64 install --manifest=krew.yaml --archive=krew.tar.gz+        +    - name: Validate updated plugin manifests+      run: |+        set -u

I honestly don't know why don't you just add set -euo pipefail which we discussed before.

Imagine git diff failed. This run shell will NOT fail, because git is not the last command in the pipe. No data will flow to xargs, so it will succeed, which will make us think everything worked.

alonyb

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

release new version v1.4.5 of advise-psp

/close

krew-release-bot

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

release new version v1.4.6 of advise-psp

This will be auto approved next time. but this time you changed file name. /lgtm /approve Thanks!

krew-release-bot

comment created time in 4 days

issue commentrajatjindal/krew-release-bot

maybe remove "without gomodules" examples

I think you need fewer examples, and more links to other examples. :)

ahmetb

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

release new version v1.4.6 of advise-psp

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request doesn't seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/advise-psp.yaml is not a straightforward version bump: diff line unrecognized for version bumps: [- Suggests PSPs based on the required capabilities of the currently running ]

krew-release-bot

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

release new version v1.4.5 of advise-psp

 kind: Plugin metadata:   name: advise-psp spec:-  version: v1.4.0+  version: v1.4.5   homepage: https://github.com/sysdiglabs/kube-psp-advisor   platforms:   - selector:       matchLabels:         os: darwin         arch: amd64-    uri: https://github.com/sysdiglabs/kube-psp-advisor/releases/download/1.4.0/kubectl-advise-psp_v1.4.0_darwin_amd64.tar.gz-    sha256: 55f852fd02b62ddbe59e8f1c00550d305201765beef900111c4c0819c85b64df +    uri: https://github.com/sysdiglabs/kube-psp-advisor/releases/download/v1.4.5/kube-psp-advisor_v1.4.5_darwin_amd64.tar.gz+    sha256: e00ad8ccb4aa2827562cb47cd956dcbb139632f28b870cd16ba6dd2209ee147f+    sha256: 55f852fd02b62ddbe59e8f1c00550d305201765beef900111c4c0819c85b64df

looks erroneous

krew-release-bot

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

release new version v0.0.34 of modify-secret

/lgtm /approve

krew-release-bot

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

new plugin: net-forward

I'm ok with the idea. Please sign cla and we'll work on reviews.

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++command: ./kubectl-net_forward

this should be causing failure. unknown field.

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++command: ./kubectl-net_forward+apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.2"       # required, must be in semver format, prefixed with "v"+  platforms:+  # specify installation script for linux +  - selector:             # a regular Kubernetes selector+      matchLabels:+        os: linux+    # url for downloading the package archive:+    uri: https://github.com/antitree/krew-tools/releases/download/0.0.2/krew-tools_v1.0.2.tar.gz+    # sha256sum of the above archive file:+    sha256: "2248c140613ce9a4796332744de6c37e82352929270bbd06b2ad6fde6e7c7f1c"+    # copy the used files out of the zip archive, defaults to `[{from: "*", to: "."}]`+    files:+      - from: "net-forward/*"+        to: "."+    bin: "kubectl-net_forward"  # path to the plugin executable after copying files above+  shortDescription: "Setup a true forwarder from your local machine to any TCP service accessible from within the cluster."+  homepage: https://github.com/antitree/krew-tools+  # (optional) use caveats field to show post-installation recommendations+  caveats: |+    This plugin needs the alpine:socat image available to the node:+  description: |     # should print nicely on standard 80 char wide terminals+    Deploy a socat listener that allows you to forward to any IP/Port that's +    accessible in the cluster. Similar to `kubectl port-forward` but without+    the requiring a kubernetes to connect to.+    +    Examples:+      kubectl net-forward+      kubectl net-forward -i kubernetes.default -p 443+      kubectl net-forward -n testnamespace -i 10.24.0.1 -p 443 -l 9999

consider adding these to your -h/--help message.

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++command: ./kubectl-net_forward+apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.2"       # required, must be in semver format, prefixed with "v"+  platforms:+  # specify installation script for linux +  - selector:             # a regular Kubernetes selector+      matchLabels:+        os: linux+    # url for downloading the package archive:+    uri: https://github.com/antitree/krew-tools/releases/download/0.0.2/krew-tools_v1.0.2.tar.gz+    # sha256sum of the above archive file:+    sha256: "2248c140613ce9a4796332744de6c37e82352929270bbd06b2ad6fde6e7c7f1c"+    # copy the used files out of the zip archive, defaults to `[{from: "*", to: "."}]`+    files:+      - from: "net-forward/*"+        to: "."+    bin: "kubectl-net_forward"  # path to the plugin executable after copying files above+  shortDescription: "Setup a true forwarder from your local machine to any TCP service accessible from within the cluster."+  homepage: https://github.com/antitree/krew-tools

I recommend finding a better name for your repo, like net-forward.

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++command: ./kubectl-net_forward+apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.2"       # required, must be in semver format, prefixed with "v"+  platforms:+  # specify installation script for linux +  - selector:             # a regular Kubernetes selector+      matchLabels:+        os: linux+    # url for downloading the package archive:+    uri: https://github.com/antitree/krew-tools/releases/download/0.0.2/krew-tools_v1.0.2.tar.gz+    # sha256sum of the above archive file:+    sha256: "2248c140613ce9a4796332744de6c37e82352929270bbd06b2ad6fde6e7c7f1c"+    # copy the used files out of the zip archive, defaults to `[{from: "*", to: "."}]`+    files:+      - from: "net-forward/*"

can you please also copy out the license?

antitree

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew-index

new plugin: net-forward

+# Licensed under the Apache License, Version 2.0 (the "License");+# you may not use this file except in compliance with the License.+# You may obtain a copy of the License at+#+#      http://www.apache.org/licenses/LICENSE-2.0+#+# Unless required by applicable law or agreed to in writing, software+# distributed under the License is distributed on an "AS IS" BASIS,+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+# See the License for the specific language governing permissions and+# limitations under the License.++command: ./kubectl-net_forward+apiVersion: krew.googlecontainertools.github.com/v1alpha2+kind: Plugin+metadata:+  name: net-forward+spec:+  version: "v1.0.2"       # required, must be in semver format, prefixed with "v"

can you please remove comments?

antitree

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

release new version v0.0.34 of modify-secret

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request doesn't seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/modify-secret.yaml is not a straightforward version bump: changing old version ("0.0.32") with new version ("0.0.34") in the url (https://github.com/rajatjindal/kubectl-modify-secret/releases/download/v0.0.32/darwin-amd64-v0.0.32.tar.gz) did not result in the new url (https://github.com/rajatjindal/kubectl-modify-secret/releases/download/v0.0.34/kubectl-modify-secret_v0.0.34_darwin_amd64.tar.gz), expected: https://github.com/rajatjindal/kubectl-modify-secret/releases/download/v0.0.34/darwin-amd64-v0.0.34.tar.gz

krew-release-bot

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

release new version v1.4.5 of advise-psp

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


This pull request doesn't seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/advise-psp.yaml is not a straightforward version bump: diff line unrecognized for version bumps: [- Suggests PSPs based on the required capabilities of the currently running ]

krew-release-bot

comment created time in 4 days

pull request commentGoogleCloudPlatform/golang-samples

[HOLD] run: grpc-server-streaming sample

I'm seeing a failure from:

license_test.go:71: run/grpc-server-streaming/pkg/api/v1/timeservice.pb.go: license header not present

this sounds a bit unreasonable since we're not supposed to edit autogenerated files. Similarly, other .pb.go files like https://github.com/GoogleCloudPlatform/golang-samples/blob/master/run/grpc-ping/pkg/api/v1/message.pb.go don't have a license header either?

ahmetb

comment created time in 4 days

Pull request review commentkubernetes-sigs/krew

Migrate to GitHub workflows

+name: Kubernetes-sigs/krew CI+on: +  push:+    branches: +      - '*'+    tags: +      - 'v*.*.*'+  pull_request:+    branches: +      - '*'+  release:+    types: [published, created, edited]++jobs:++  build:+    name: Build and Tags+    runs-on: ubuntu-latest+    steps:++    - name: Set up Go 1.13+      uses: actions/setup-go@v1+      with:+        go-version: 1.13+      id: go++    - name: Check out code into the Go module directory+      uses: actions/checkout@v2+    +    - name: Set GOPATH+      # temporary fix+      # see https://github.com/actions/setup-go/issues/14+      run: |+        echo "##[set-env name=GOPATH;]$(dirname $GITHUB_WORKSPACE)"+        echo "##[add-path]$(dirname $GITHUB_WORKSPACE)/bin"+      shell: bash+    +    - name: Install gox+      run: |+        go mod download+        hack/install-gox.sh\++    - name: Install dependencies+      run: go mod tidy && git diff --no-patch --exit-code+      +    - name: Verify code quality+      run: |

Yeah we can split all scripts into different steps[]. The fact that you have a && in the name suggests that they are different steps.

Bash carries out exit code of "last" command (in this case it would be the "only" command if we do 1 command per step).

But when it doesn't make sense to split multiple commands into two different steps, we should not shy away from using set -ex.

alonyb

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Add link to sample-cli-plugin in developer guide

lets keep it open. I'm thinking a major Developer Guide overhaul. Would be useful to incorporate there perhaps. /lifecycle frozen

chriskim06

comment created time in 4 days

issue commentGoogleCloudPlatform/microservices-demo

cartservice and loadgenerator crash at start

Is think this is related to the failing loadgenerator service?

most likely this is about the cloud provider you're using (what are you using?). run kubectl describe to see if there are any failure events there. on minikube etc, this is not supposed to work.

Nusserdt

comment created time in 4 days

MemberEvent

issue openedrikatz/kubepug

doesn't recognize CRDs

I see #9 was in v0.2.0 but when I just installed every single Istio and Knative CRD/objects showed as deprecated.

$ kubectl deprecations
MutatingWebhookConfiguration found in admissionregistration.k8s.io/v1beta1
	 ├─ MutatingWebhookConfiguration describes the configuration of and admission webhook that accept or reject and may change the object. Deprecated in v1.16, planned for removal in v1.19. Use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration instead.
		-> GLOBAL: istio-sidecar-injector
		-> GLOBAL: pod-ready.config.common-webhooks.networking.gke.io
		-> GLOBAL: webhook.eventing.knative.dev
		-> GLOBAL: webhook.serving.knative.dev

ValidatingWebhookConfiguration found in admissionregistration.k8s.io/v1beta1
	 ├─ ValidatingWebhookConfiguration describes the configuration of and admission webhook that accept or reject and object without changing it. Deprecated in v1.16, planned for removal in v1.19. Use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration instead.
		-> GLOBAL: istio-galley

Role found in rbac.authorization.k8s.io/v1beta1
	 ├─ Role is a namespaced, logical grouping of PolicyRules that can be referenced as a unit by a RoleBinding. Deprecated in v1.17 in favor of rbac.authorization.k8s.io/v1 Role, and will no longer be served in v1.20.
		-> Object: istio-ingress-sds namespace: gke-system
		-> Object: istio-ingressgateway-sds namespace: istio-system
		-> Object: system:controller:bootstrap-signer namespace: kube-public
		-> Object: cloud-provider namespace: kube-system
		-> Object: extension-apiserver-authentication-reader namespace: kube-system
		-> Object: gce:cloud-provider namespace: kube-system
		-> Object: system::leader-locking-kube-controller-manager namespace: kube-system
		-> Object: system::leader-locking-kube-scheduler namespace: kube-system
		-> Object: system:controller:bootstrap-signer namespace: kube-system
		-> Object: system:controller:cloud-provider namespace: kube-system
		-> Object: system:controller:token-cleaner namespace: kube-system
		-> Object: system:fluentd-gcp-scaler namespace: kube-system
		-> Object: system:pod-nanny namespace: kube-system

ClusterRole found in rbac.authorization.k8s.io/v1beta1
	 ├─ ClusterRole is a cluster level, logical grouping of PolicyRules that can be referenced as a unit by a RoleBinding or ClusterRoleBinding. Deprecated in v1.17 in favor of rbac.authorization.k8s.io/v1 ClusterRole, and will no longer be served in v1.20.
		-> GLOBAL: addressable-resolver
		-> GLOBAL: admin
		-> GLOBAL: broker-addressable-resolver
		-> GLOBAL: channel-addressable-resolver
		-> GLOBAL: channelable-manipulator
		-> GLOBAL: cloud-provider
		-> GLOBAL: cluster-admin
		-> GLOBAL: cluster-local-gateway-gke-system
		-> GLOBAL: cluster-local-gateway-istio-system
		-> GLOBAL: edit
		-> GLOBAL: eventing-broker-filter
		-> GLOBAL: eventing-broker-ingress
		-> GLOBAL: eventing-config-reader
		-> GLOBAL: eventing-sources-source-observer
		-> GLOBAL: gce:beta:kubelet-certificate-bootstrap
		-> GLOBAL: gce:beta:kubelet-certificate-rotation
		-> GLOBAL: gce:cloud-provider
		-> GLOBAL: imc-addressable-resolver
		-> GLOBAL: imc-channelable-manipulator
		-> GLOBAL: imc-controller
		-> GLOBAL: imc-dispatcher
		-> GLOBAL: istio-citadel-istio-system
		-> GLOBAL: istio-cleanup-secrets-istio-system
		-> GLOBAL: istio-galley-istio-system
		-> GLOBAL: istio-ingress-gke-system
		-> GLOBAL: istio-ingressgateway-istio-system
		-> GLOBAL: istio-init-gke-system
		-> GLOBAL: istio-init-istio-system
		-> GLOBAL: istio-mixer-istio-system
		-> GLOBAL: istio-pilot-gke-system
		-> GLOBAL: istio-pilot-istio-system
		-> GLOBAL: istio-reader
		-> GLOBAL: istio-security-post-install-istio-system
		-> GLOBAL: istio-sidecar-injector-istio-system
		-> GLOBAL: knative-eventing-controller
		-> GLOBAL: knative-eventing-namespaced-admin
		-> GLOBAL: knative-eventing-namespaced-edit
		-> GLOBAL: knative-eventing-namespaced-view
		-> GLOBAL: knative-eventing-source-controller
		-> GLOBAL: knative-eventing-sources-namespaced-admin
		-> GLOBAL: knative-eventing-webhook
		-> GLOBAL: knative-messaging-namespaced-admin
		-> GLOBAL: knative-serving-admin
		-> GLOBAL: knative-serving-cloudrun
		-> GLOBAL: knative-serving-core
		-> GLOBAL: knative-serving-istio
		-> GLOBAL: knative-serving-namespaced-admin
		-> GLOBAL: kubelet-api-admin
		-> GLOBAL: messaging-addressable-resolver
		-> GLOBAL: promsd-istio-system
		-> GLOBAL: read-updateinfo
		-> GLOBAL: service-addressable-resolver
		-> GLOBAL: serving-addressable-resolver
		-> GLOBAL: source-observer
		-> GLOBAL: stackdriver:fluentd-gcp
		-> GLOBAL: stackdriver:metadata-agent
		-> GLOBAL: system:aggregate-to-admin
		-> GLOBAL: system:aggregate-to-edit
		-> GLOBAL: system:aggregate-to-view
		-> GLOBAL: system:auth-delegator
		-> GLOBAL: system:aws-cloud-provider
		-> GLOBAL: system:basic-user
		-> GLOBAL: system:certificates.k8s.io:certificatesigningrequests:nodeclient
		-> GLOBAL: system:certificates.k8s.io:certificatesigningrequests:selfnodeclient
		-> GLOBAL: system:controller:attachdetach-controller
		-> GLOBAL: system:controller:certificate-controller
		-> GLOBAL: system:controller:clusterrole-aggregation-controller
		-> GLOBAL: system:controller:cronjob-controller
		-> GLOBAL: system:controller:daemon-set-controller
		-> GLOBAL: system:controller:deployment-controller
		-> GLOBAL: system:controller:disruption-controller
		-> GLOBAL: system:controller:endpoint-controller
		-> GLOBAL: system:controller:expand-controller
		-> GLOBAL: system:controller:generic-garbage-collector
		-> GLOBAL: system:controller:horizontal-pod-autoscaler
		-> GLOBAL: system:controller:job-controller
		-> GLOBAL: system:controller:namespace-controller
		-> GLOBAL: system:controller:node-controller
		-> GLOBAL: system:controller:persistent-volume-binder
		-> GLOBAL: system:controller:pod-garbage-collector
		-> GLOBAL: system:controller:pv-protection-controller
		-> GLOBAL: system:controller:pvc-protection-controller
		-> GLOBAL: system:controller:replicaset-controller
		-> GLOBAL: system:controller:replication-controller
		-> GLOBAL: system:controller:resourcequota-controller
		-> GLOBAL: system:controller:route-controller
		-> GLOBAL: system:controller:service-account-controller
		-> GLOBAL: system:controller:service-controller
		-> GLOBAL: system:controller:statefulset-controller
		-> GLOBAL: system:controller:ttl-controller
		-> GLOBAL: system:csi-external-attacher
		-> GLOBAL: system:csi-external-provisioner
		-> GLOBAL: system:discovery
		-> GLOBAL: system:heapster
		-> GLOBAL: system:kube-aggregator
		-> GLOBAL: system:kube-controller-manager
		-> GLOBAL: system:kube-dns
		-> GLOBAL: system:kube-dns-autoscaler
		-> GLOBAL: system:kube-scheduler
		-> GLOBAL: system:kubelet-api-admin
		-> GLOBAL: system:metrics-server
		-> GLOBAL: system:node
		-> GLOBAL: system:node-bootstrapper
		-> GLOBAL: system:node-problem-detector
		-> GLOBAL: system:node-proxier
		-> GLOBAL: system:persistent-volume-provisioner
		-> GLOBAL: system:public-info-viewer
		-> GLOBAL: system:volume-scheduler
		-> GLOBAL: view

PriorityClass found in scheduling.k8s.io/v1beta1
	 ├─ DEPRECATED - This group version of PriorityClass is deprecated by scheduling.k8s.io/v1/PriorityClass. PriorityClass defines mapping from a priority class name to the priority integer value. The value can be any valid integer.
		-> GLOBAL: system-cluster-critical
		-> GLOBAL: system-node-critical

ClusterRoleBinding found in rbac.authorization.k8s.io/v1beta1
	 ├─ ClusterRoleBinding references a ClusterRole, but not contain it.  It can reference a ClusterRole in the global namespace, and adds who information via Subject. Deprecated in v1.17 in favor of rbac.authorization.k8s.io/v1 ClusterRoleBinding, and will no longer be served in v1.20.
		-> GLOBAL: ahmet-is-admin
		-> GLOBAL: cluster-admin
		-> GLOBAL: cluster-admin-binding
		-> GLOBAL: cluster-autoscaler-updateinfo
		-> GLOBAL: cluster-local-gateway-gke-system
		-> GLOBAL: cluster-local-gateway-istio-system
		-> GLOBAL: event-exporter-rb
		-> GLOBAL: eventing-controller
		-> GLOBAL: eventing-controller-manipulator
		-> GLOBAL: eventing-controller-resolver
		-> GLOBAL: eventing-controller-source-observer
		-> GLOBAL: eventing-source-controller
		-> GLOBAL: eventing-source-controller-resolver
		-> GLOBAL: eventing-webhook
		-> GLOBAL: gce:beta:kubelet-certificate-bootstrap
		-> GLOBAL: gce:beta:kubelet-certificate-rotation
		-> GLOBAL: gce:cloud-provider
		-> GLOBAL: heapster-binding
		-> GLOBAL: imc-controller
		-> GLOBAL: imc-dispatcher
		-> GLOBAL: istio-citadel-istio-system
		-> GLOBAL: istio-cleanup-secrets-istio-system
		-> GLOBAL: istio-galley-admin-role-binding-istio-system
		-> GLOBAL: istio-ingress-gke-system
		-> GLOBAL: istio-ingressgateway-istio-system
		-> GLOBAL: istio-init-admin-role-binding-gke-system
		-> GLOBAL: istio-init-admin-role-binding-istio-system
		-> GLOBAL: istio-mixer-admin-role-binding-istio-system
		-> GLOBAL: istio-multi
		-> GLOBAL: istio-pilot-gke-system
		-> GLOBAL: istio-pilot-istio-system
		-> GLOBAL: istio-security-post-install-role-binding-istio-system
		-> GLOBAL: istio-sidecar-injector-admin-role-binding-istio-system
		-> GLOBAL: jeff-is-admin
		-> GLOBAL: knative-serving-controller-admin
		-> GLOBAL: kube-apiserver-kubelet-api-admin
		-> GLOBAL: kubelet-bootstrap
		-> GLOBAL: kubelet-bootstrap-certificate-bootstrap
		-> GLOBAL: kubelet-bootstrap-node-bootstrapper
		-> GLOBAL: kubelet-cluster-admin
		-> GLOBAL: metrics-server:system:auth-delegator
		-> GLOBAL: npd-binding
		-> GLOBAL: promsd-istio-system
		-> GLOBAL: stackdriver:fluentd-gcp
		-> GLOBAL: stackdriver:metadata-agent
		-> GLOBAL: sundar-is-admin
		-> GLOBAL: system:aws-cloud-provider
		-> GLOBAL: system:basic-user
		-> GLOBAL: system:controller:attachdetach-controller
		-> GLOBAL: system:controller:certificate-controller
		-> GLOBAL: system:controller:clusterrole-aggregation-controller
		-> GLOBAL: system:controller:cronjob-controller
		-> GLOBAL: system:controller:daemon-set-controller
		-> GLOBAL: system:controller:deployment-controller
		-> GLOBAL: system:controller:disruption-controller
		-> GLOBAL: system:controller:endpoint-controller
		-> GLOBAL: system:controller:expand-controller
		-> GLOBAL: system:controller:generic-garbage-collector
		-> GLOBAL: system:controller:horizontal-pod-autoscaler
		-> GLOBAL: system:controller:job-controller
		-> GLOBAL: system:controller:namespace-controller
		-> GLOBAL: system:controller:node-controller
		-> GLOBAL: system:controller:persistent-volume-binder
		-> GLOBAL: system:controller:pod-garbage-collector
		-> GLOBAL: system:controller:pv-protection-controller
		-> GLOBAL: system:controller:pvc-protection-controller
		-> GLOBAL: system:controller:replicaset-controller
		-> GLOBAL: system:controller:replication-controller
		-> GLOBAL: system:controller:resourcequota-controller
		-> GLOBAL: system:controller:route-controller
		-> GLOBAL: system:controller:service-account-controller
		-> GLOBAL: system:controller:service-controller
		-> GLOBAL: system:controller:statefulset-controller
		-> GLOBAL: system:controller:ttl-controller
		-> GLOBAL: system:discovery
		-> GLOBAL: system:kube-controller-manager
		-> GLOBAL: system:kube-dns
		-> GLOBAL: system:kube-dns-autoscaler
		-> GLOBAL: system:kube-scheduler
		-> GLOBAL: system:metrics-server
		-> GLOBAL: system:node
		-> GLOBAL: system:node-proxier
		-> GLOBAL: system:public-info-viewer
		-> GLOBAL: system:volume-scheduler

RoleBinding found in rbac.authorization.k8s.io/v1beta1
	 ├─ RoleBinding references a role, but does not contain it.  It can reference a Role in the same namespace or a ClusterRole in the global namespace. It adds who information via Subjects and namespace information by which namespace it exists in.  RoleBindings in a given namespace only have effect in that namespace. Deprecated in v1.17 in favor of rbac.authorization.k8s.io/v1 RoleBinding, and will no longer be served in v1.20.
		-> Object: eventing-broker-filter namespace: event-example
		-> Object: eventing-broker-ingress namespace: event-example
		-> Object: istio-ingress-sds namespace: gke-system
		-> Object: istio-ingressgateway-sds namespace: istio-system
		-> Object: eventing-broker-filter-event-example namespace: knative-eventing
		-> Object: eventing-broker-ingress-event-example namespace: knative-eventing
		-> Object: system:controller:bootstrap-signer namespace: kube-public
		-> Object: fluentd-gcp-scaler-binding namespace: kube-system
		-> Object: gce:cloud-provider namespace: kube-system
		-> Object: heapster-binding namespace: kube-system
		-> Object: metrics-server-auth-reader namespace: kube-system
		-> Object: system::extension-apiserver-authentication-reader namespace: kube-system
		-> Object: system::leader-locking-kube-controller-manager namespace: kube-system
		-> Object: system::leader-locking-kube-scheduler namespace: kube-system
		-> Object: system:controller:bootstrap-signer namespace: kube-system
		-> Object: system:controller:cloud-provider namespace: kube-system
		-> Object: system:controller:token-cleaner namespace: kube-system

CustomResourceDefinition found in apiextensions.k8s.io/v1beta1
	 ├─ CustomResourceDefinition represents a resource that should be exposed on the API server.  Its name MUST be in the format <.spec.name>.<.spec.group>. Deprecated in v1.16, planned for removal in v1.19. Use apiextensions.k8s.io/v1 CustomResourceDefinition instead.
		-> GLOBAL: adapters.config.istio.io
		-> GLOBAL: apikeys.config.istio.io
		-> GLOBAL: apiserversources.sources.eventing.knative.dev
		-> GLOBAL: attributemanifests.config.istio.io
		-> GLOBAL: authorizations.config.istio.io
		-> GLOBAL: backendconfigs.cloud.google.com
		-> GLOBAL: brokers.eventing.knative.dev
		-> GLOBAL: bypasses.config.istio.io
		-> GLOBAL: certificates.certmanager.k8s.io
		-> GLOBAL: certificates.networking.internal.knative.dev
		-> GLOBAL: challenges.certmanager.k8s.io
		-> GLOBAL: channels.messaging.knative.dev
		-> GLOBAL: checknothings.config.istio.io
		-> GLOBAL: circonuses.config.istio.io
		-> GLOBAL: cloudwatches.config.istio.io
		-> GLOBAL: clusteringresses.networking.internal.knative.dev
		-> GLOBAL: clusterissuers.certmanager.k8s.io
		-> GLOBAL: clusterrbacconfigs.rbac.istio.io
		-> GLOBAL: configurations.serving.knative.dev
		-> GLOBAL: containersources.sources.eventing.knative.dev
		-> GLOBAL: cronjobsources.sources.eventing.knative.dev
		-> GLOBAL: deniers.config.istio.io
		-> GLOBAL: destinationrules.networking.istio.io
		-> GLOBAL: dogstatsds.config.istio.io
		-> GLOBAL: domainmappings.domains.cloudrun.com
		-> GLOBAL: edges.config.istio.io
		-> GLOBAL: envoyfilters.networking.istio.io
		-> GLOBAL: eventtypes.eventing.knative.dev
		-> GLOBAL: fluentds.config.istio.io
		-> GLOBAL: gateways.networking.istio.io
		-> GLOBAL: handlers.config.istio.io
		-> GLOBAL: httpapispecbindings.config.istio.io
		-> GLOBAL: httpapispecs.config.istio.io
		-> GLOBAL: images.caching.internal.knative.dev
		-> GLOBAL: ingresses.networking.internal.knative.dev
		-> GLOBAL: inmemorychannels.messaging.knative.dev
		-> GLOBAL: instances.config.istio.io
		-> GLOBAL: issuers.certmanager.k8s.io
		-> GLOBAL: kubernetesenvs.config.istio.io
		-> GLOBAL: kuberneteses.config.istio.io
		-> GLOBAL: listcheckers.config.istio.io
		-> GLOBAL: listentries.config.istio.io
		-> GLOBAL: logentries.config.istio.io
		-> GLOBAL: managedcertificates.networking.gke.io
		-> GLOBAL: memquotas.config.istio.io
		-> GLOBAL: meshpolicies.authentication.istio.io
		-> GLOBAL: metrics.autoscaling.internal.knative.dev
		-> GLOBAL: metrics.config.istio.io
		-> GLOBAL: noops.config.istio.io
		-> GLOBAL: opas.config.istio.io
		-> GLOBAL: orders.certmanager.k8s.io
		-> GLOBAL: parallels.messaging.knative.dev
		-> GLOBAL: podautoscalers.autoscaling.internal.knative.dev
		-> GLOBAL: policies.authentication.istio.io
		-> GLOBAL: prometheuses.config.istio.io
		-> GLOBAL: quotas.config.istio.io
		-> GLOBAL: quotaspecbindings.config.istio.io
		-> GLOBAL: quotaspecs.config.istio.io
		-> GLOBAL: rbacconfigs.rbac.istio.io
		-> GLOBAL: rbacs.config.istio.io
		-> GLOBAL: redisquotas.config.istio.io
		-> GLOBAL: reportnothings.config.istio.io
		-> GLOBAL: revisions.serving.knative.dev
		-> GLOBAL: routes.serving.knative.dev
		-> GLOBAL: rules.config.istio.io
		-> GLOBAL: scalingpolicies.scalingpolicy.kope.io
		-> GLOBAL: sequences.messaging.knative.dev
		-> GLOBAL: serverlessservices.networking.internal.knative.dev
		-> GLOBAL: serviceentries.networking.istio.io
		-> GLOBAL: servicerolebindings.rbac.istio.io
		-> GLOBAL: serviceroles.rbac.istio.io
		-> GLOBAL: services.serving.knative.dev
		-> GLOBAL: sidecars.networking.istio.io
		-> GLOBAL: signalfxs.config.istio.io
		-> GLOBAL: solarwindses.config.istio.io
		-> GLOBAL: stackdrivers.config.istio.io
		-> GLOBAL: statsds.config.istio.io
		-> GLOBAL: stdios.config.istio.io
		-> GLOBAL: subscriptions.messaging.knative.dev
		-> GLOBAL: templates.config.istio.io
		-> GLOBAL: tracespans.config.istio.io
		-> GLOBAL: triggers.eventing.knative.dev
		-> GLOBAL: updateinfos.nodemanagement.gke.io
		-> GLOBAL: virtualservices.networking.istio.io
		-> GLOBAL: zipkins.config.istio.io

DaemonSet found in extensions/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: daemonset-hold-image namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1 namespace: kube-system
		-> Object: metadata-proxy-v0.1 namespace: kube-system
		-> Object: nvidia-gpu-device-plugin namespace: kube-system
		-> Object: prometheus-to-sd namespace: kube-system

Deployment found in extensions/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r-deployment namespace: default
		-> Object: grpc-ping-rc2jr-deployment namespace: default
		-> Object: hello-lbsxh-3-deployment namespace: default
		-> Object: hello-tdpmb-1-deployment namespace: default
		-> Object: hello-tjxhq-2-deployment namespace: default
		-> Object: nginx namespace: default
		-> Object: default-broker-filter namespace: event-example
		-> Object: default-broker-ingress namespace: event-example
		-> Object: cluster-local-gateway namespace: gke-system
		-> Object: istio-ingress namespace: gke-system
		-> Object: istio-pilot namespace: gke-system
		-> Object: istio-citadel namespace: istio-system
		-> Object: istio-galley namespace: istio-system
		-> Object: istio-ingressgateway namespace: istio-system
		-> Object: istio-pilot namespace: istio-system
		-> Object: istio-policy namespace: istio-system
		-> Object: istio-sidecar-injector namespace: istio-system
		-> Object: istio-telemetry namespace: istio-system
		-> Object: promsd namespace: istio-system
		-> Object: eventing-controller namespace: knative-eventing
		-> Object: eventing-webhook namespace: knative-eventing
		-> Object: imc-controller namespace: knative-eventing
		-> Object: imc-dispatcher namespace: knative-eventing
		-> Object: sources-controller namespace: knative-eventing
		-> Object: activator namespace: knative-serving
		-> Object: autoscaler namespace: knative-serving
		-> Object: controller namespace: knative-serving
		-> Object: webhook namespace: knative-serving
		-> Object: event-exporter-v0.2.5 namespace: kube-system
		-> Object: fluentd-gcp-scaler namespace: kube-system
		-> Object: heapster namespace: kube-system
		-> Object: kube-dns namespace: kube-system
		-> Object: kube-dns-autoscaler namespace: kube-system
		-> Object: l7-default-backend namespace: kube-system
		-> Object: metrics-server-v0.3.1 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level namespace: kube-system

ReplicaSet found in extensions/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r-deployment-54d688d777 namespace: default
		-> Object: grpc-ping-rc2jr-deployment-5f9c4fbf49 namespace: default
		-> Object: hello-lbsxh-3-deployment-6c867cf8dd namespace: default
		-> Object: hello-tdpmb-1-deployment-5fcc78b9ff namespace: default
		-> Object: hello-tjxhq-2-deployment-6d7b48d64c namespace: default
		-> Object: nginx-697b9dcc86 namespace: default
		-> Object: nginx-7c6cfbddbc namespace: default
		-> Object: default-broker-filter-9fbc5c667 namespace: event-example
		-> Object: default-broker-ingress-7948d9b8fc namespace: event-example
		-> Object: cluster-local-gateway-86db848cf5 namespace: gke-system
		-> Object: istio-ingress-5b4d9c44dd namespace: gke-system
		-> Object: istio-pilot-996485bd namespace: gke-system
		-> Object: istio-citadel-5448cbc9f8 namespace: istio-system
		-> Object: istio-citadel-5949896b4b namespace: istio-system
		-> Object: istio-citadel-5c88f4f47d namespace: istio-system
		-> Object: istio-galley-5bf8f944b7 namespace: istio-system
		-> Object: istio-ingressgateway-57449dd8bc namespace: istio-system
		-> Object: istio-ingressgateway-7c96766d85 namespace: istio-system
		-> Object: istio-ingressgateway-7f6db9967c namespace: istio-system
		-> Object: istio-pilot-56b86b87b6 namespace: istio-system
		-> Object: istio-pilot-56df8c9cf6 namespace: istio-system
		-> Object: istio-pilot-75654d4d9 namespace: istio-system
		-> Object: istio-policy-59dd46fb7d namespace: istio-system
		-> Object: istio-policy-68775985b8 namespace: istio-system
		-> Object: istio-policy-99fd7f7f5 namespace: istio-system
		-> Object: istio-sidecar-injector-5b5454d777 namespace: istio-system
		-> Object: istio-sidecar-injector-6cf9dc4549 namespace: istio-system
		-> Object: istio-sidecar-injector-bc79fc549 namespace: istio-system
		-> Object: istio-telemetry-5965f9d996 namespace: istio-system
		-> Object: istio-telemetry-699ffd959d namespace: istio-system
		-> Object: istio-telemetry-cdf9c6d7 namespace: istio-system
		-> Object: promsd-76f8d4cff8 namespace: istio-system
		-> Object: promsd-f876c8c55 namespace: istio-system
		-> Object: eventing-controller-7d75cd8598 namespace: knative-eventing
		-> Object: eventing-webhook-5cb89d8974 namespace: knative-eventing
		-> Object: imc-controller-654d689bc9 namespace: knative-eventing
		-> Object: imc-dispatcher-794f546c85 namespace: knative-eventing
		-> Object: sources-controller-67788d5b86 namespace: knative-eventing
		-> Object: activator-5477b7ff7 namespace: knative-serving
		-> Object: activator-6865899867 namespace: knative-serving
		-> Object: activator-74488ccb4c namespace: knative-serving
		-> Object: activator-7688586ccb namespace: knative-serving
		-> Object: autoscaler-5c56954884 namespace: knative-serving
		-> Object: autoscaler-7688987947 namespace: knative-serving
		-> Object: autoscaler-7c95566b65 namespace: knative-serving
		-> Object: autoscaler-85f5b489d7 namespace: knative-serving
		-> Object: controller-55bb588dbd namespace: knative-serving
		-> Object: controller-5ff95479f5 namespace: knative-serving
		-> Object: controller-78fd6cb64 namespace: knative-serving
		-> Object: controller-845759bc78 namespace: knative-serving
		-> Object: webhook-5dcf9dc6b5 namespace: knative-serving
		-> Object: webhook-64645549f6 namespace: knative-serving
		-> Object: webhook-759c4676bd namespace: knative-serving
		-> Object: webhook-77856f76fc namespace: knative-serving
		-> Object: event-exporter-v0.2.5-7d99d74cf8 namespace: kube-system
		-> Object: fluentd-gcp-scaler-54ccb89d5 namespace: kube-system
		-> Object: fluentd-gcp-scaler-55bdf597c namespace: kube-system
		-> Object: heapster-5f4c566b6d namespace: kube-system
		-> Object: heapster-64df54d744 namespace: kube-system
		-> Object: heapster-666fffdc58 namespace: kube-system
		-> Object: heapster-846cc4b8c6 namespace: kube-system
		-> Object: kube-dns-5877696fb4 namespace: kube-system
		-> Object: kube-dns-6987857fdb namespace: kube-system
		-> Object: kube-dns-autoscaler-85f8bdb54 namespace: kube-system
		-> Object: kube-dns-autoscaler-bb58c6784 namespace: kube-system
		-> Object: l7-default-backend-fd59995cd namespace: kube-system
		-> Object: metrics-server-v0.3.1-57c75779f namespace: kube-system
		-> Object: metrics-server-v0.3.1-c4cddd5f5 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-74d55f7669 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-8d8677c5d namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-bb9d8bb64 namespace: kube-system

ControllerRevision found in apps/v1beta2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: daemonset-hold-image-5668b66bcd namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-57756ccc47 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-595d677f66 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-5c8c4c9864 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-789d446b4c namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-864d84b477 namespace: kube-system
		-> Object: metadata-proxy-v0.1-5b4567fdff namespace: kube-system
		-> Object: metadata-proxy-v0.1-7d7b4bb744 namespace: kube-system
		-> Object: nvidia-gpu-device-plugin-64d8cbf474 namespace: kube-system
		-> Object: nvidia-gpu-device-plugin-65b49677fc namespace: kube-system
		-> Object: nvidia-gpu-device-plugin-6c79557f9b namespace: kube-system
		-> Object: prometheus-to-sd-5b58787fb5 namespace: kube-system
		-> Object: prometheus-to-sd-776c6cbcb namespace: kube-system
		-> Object: prometheus-to-sd-99cd5649b namespace: kube-system
		-> Object: prometheus-to-sd-9dd499d6d namespace: kube-system

DaemonSet found in apps/v1beta2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: daemonset-hold-image namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1 namespace: kube-system
		-> Object: metadata-proxy-v0.1 namespace: kube-system
		-> Object: nvidia-gpu-device-plugin namespace: kube-system
		-> Object: prometheus-to-sd namespace: kube-system

Deployment found in apps/v1beta2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r-deployment namespace: default
		-> Object: grpc-ping-rc2jr-deployment namespace: default
		-> Object: hello-lbsxh-3-deployment namespace: default
		-> Object: hello-tdpmb-1-deployment namespace: default
		-> Object: hello-tjxhq-2-deployment namespace: default
		-> Object: nginx namespace: default
		-> Object: default-broker-filter namespace: event-example
		-> Object: default-broker-ingress namespace: event-example
		-> Object: cluster-local-gateway namespace: gke-system
		-> Object: istio-ingress namespace: gke-system
		-> Object: istio-pilot namespace: gke-system
		-> Object: istio-citadel namespace: istio-system
		-> Object: istio-galley namespace: istio-system
		-> Object: istio-ingressgateway namespace: istio-system
		-> Object: istio-pilot namespace: istio-system
		-> Object: istio-policy namespace: istio-system
		-> Object: istio-sidecar-injector namespace: istio-system
		-> Object: istio-telemetry namespace: istio-system
		-> Object: promsd namespace: istio-system
		-> Object: eventing-controller namespace: knative-eventing
		-> Object: eventing-webhook namespace: knative-eventing
		-> Object: imc-controller namespace: knative-eventing
		-> Object: imc-dispatcher namespace: knative-eventing
		-> Object: sources-controller namespace: knative-eventing
		-> Object: activator namespace: knative-serving
		-> Object: autoscaler namespace: knative-serving
		-> Object: controller namespace: knative-serving
		-> Object: webhook namespace: knative-serving
		-> Object: event-exporter-v0.2.5 namespace: kube-system
		-> Object: fluentd-gcp-scaler namespace: kube-system
		-> Object: heapster namespace: kube-system
		-> Object: kube-dns namespace: kube-system
		-> Object: kube-dns-autoscaler namespace: kube-system
		-> Object: l7-default-backend namespace: kube-system
		-> Object: metrics-server-v0.3.1 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level namespace: kube-system

ReplicaSet found in apps/v1beta2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r-deployment-54d688d777 namespace: default
		-> Object: grpc-ping-rc2jr-deployment-5f9c4fbf49 namespace: default
		-> Object: hello-lbsxh-3-deployment-6c867cf8dd namespace: default
		-> Object: hello-tdpmb-1-deployment-5fcc78b9ff namespace: default
		-> Object: hello-tjxhq-2-deployment-6d7b48d64c namespace: default
		-> Object: nginx-697b9dcc86 namespace: default
		-> Object: nginx-7c6cfbddbc namespace: default
		-> Object: default-broker-filter-9fbc5c667 namespace: event-example
		-> Object: default-broker-ingress-7948d9b8fc namespace: event-example
		-> Object: cluster-local-gateway-86db848cf5 namespace: gke-system
		-> Object: istio-ingress-5b4d9c44dd namespace: gke-system
		-> Object: istio-pilot-996485bd namespace: gke-system
		-> Object: istio-citadel-5448cbc9f8 namespace: istio-system
		-> Object: istio-citadel-5949896b4b namespace: istio-system
		-> Object: istio-citadel-5c88f4f47d namespace: istio-system
		-> Object: istio-galley-5bf8f944b7 namespace: istio-system
		-> Object: istio-ingressgateway-57449dd8bc namespace: istio-system
		-> Object: istio-ingressgateway-7c96766d85 namespace: istio-system
		-> Object: istio-ingressgateway-7f6db9967c namespace: istio-system
		-> Object: istio-pilot-56b86b87b6 namespace: istio-system
		-> Object: istio-pilot-56df8c9cf6 namespace: istio-system
		-> Object: istio-pilot-75654d4d9 namespace: istio-system
		-> Object: istio-policy-59dd46fb7d namespace: istio-system
		-> Object: istio-policy-68775985b8 namespace: istio-system
		-> Object: istio-policy-99fd7f7f5 namespace: istio-system
		-> Object: istio-sidecar-injector-5b5454d777 namespace: istio-system
		-> Object: istio-sidecar-injector-6cf9dc4549 namespace: istio-system
		-> Object: istio-sidecar-injector-bc79fc549 namespace: istio-system
		-> Object: istio-telemetry-5965f9d996 namespace: istio-system
		-> Object: istio-telemetry-699ffd959d namespace: istio-system
		-> Object: istio-telemetry-cdf9c6d7 namespace: istio-system
		-> Object: promsd-76f8d4cff8 namespace: istio-system
		-> Object: promsd-f876c8c55 namespace: istio-system
		-> Object: eventing-controller-7d75cd8598 namespace: knative-eventing
		-> Object: eventing-webhook-5cb89d8974 namespace: knative-eventing
		-> Object: imc-controller-654d689bc9 namespace: knative-eventing
		-> Object: imc-dispatcher-794f546c85 namespace: knative-eventing
		-> Object: sources-controller-67788d5b86 namespace: knative-eventing
		-> Object: activator-5477b7ff7 namespace: knative-serving
		-> Object: activator-6865899867 namespace: knative-serving
		-> Object: activator-74488ccb4c namespace: knative-serving
		-> Object: activator-7688586ccb namespace: knative-serving
		-> Object: autoscaler-5c56954884 namespace: knative-serving
		-> Object: autoscaler-7688987947 namespace: knative-serving
		-> Object: autoscaler-7c95566b65 namespace: knative-serving
		-> Object: autoscaler-85f5b489d7 namespace: knative-serving
		-> Object: controller-55bb588dbd namespace: knative-serving
		-> Object: controller-5ff95479f5 namespace: knative-serving
		-> Object: controller-78fd6cb64 namespace: knative-serving
		-> Object: controller-845759bc78 namespace: knative-serving
		-> Object: webhook-5dcf9dc6b5 namespace: knative-serving
		-> Object: webhook-64645549f6 namespace: knative-serving
		-> Object: webhook-759c4676bd namespace: knative-serving
		-> Object: webhook-77856f76fc namespace: knative-serving
		-> Object: event-exporter-v0.2.5-7d99d74cf8 namespace: kube-system
		-> Object: fluentd-gcp-scaler-54ccb89d5 namespace: kube-system
		-> Object: fluentd-gcp-scaler-55bdf597c namespace: kube-system
		-> Object: heapster-5f4c566b6d namespace: kube-system
		-> Object: heapster-64df54d744 namespace: kube-system
		-> Object: heapster-666fffdc58 namespace: kube-system
		-> Object: heapster-846cc4b8c6 namespace: kube-system
		-> Object: kube-dns-5877696fb4 namespace: kube-system
		-> Object: kube-dns-6987857fdb namespace: kube-system
		-> Object: kube-dns-autoscaler-85f8bdb54 namespace: kube-system
		-> Object: kube-dns-autoscaler-bb58c6784 namespace: kube-system
		-> Object: l7-default-backend-fd59995cd namespace: kube-system
		-> Object: metrics-server-v0.3.1-57c75779f namespace: kube-system
		-> Object: metrics-server-v0.3.1-c4cddd5f5 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-74d55f7669 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-8d8677c5d namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-bb9d8bb64 namespace: kube-system

ControllerRevision found in apps/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: daemonset-hold-image-5668b66bcd namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-57756ccc47 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-595d677f66 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-5c8c4c9864 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-789d446b4c namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-864d84b477 namespace: kube-system
		-> Object: metadata-proxy-v0.1-5b4567fdff namespace: kube-system
		-> Object: metadata-proxy-v0.1-7d7b4bb744 namespace: kube-system
		-> Object: nvidia-gpu-device-plugin-64d8cbf474 namespace: kube-system
		-> Object: nvidia-gpu-device-plugin-65b49677fc namespace: kube-system
		-> Object: nvidia-gpu-device-plugin-6c79557f9b namespace: kube-system
		-> Object: prometheus-to-sd-5b58787fb5 namespace: kube-system
		-> Object: prometheus-to-sd-776c6cbcb namespace: kube-system
		-> Object: prometheus-to-sd-99cd5649b namespace: kube-system
		-> Object: prometheus-to-sd-9dd499d6d namespace: kube-system

Deployment found in apps/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r-deployment namespace: default
		-> Object: grpc-ping-rc2jr-deployment namespace: default
		-> Object: hello-lbsxh-3-deployment namespace: default
		-> Object: hello-tdpmb-1-deployment namespace: default
		-> Object: hello-tjxhq-2-deployment namespace: default
		-> Object: nginx namespace: default
		-> Object: default-broker-filter namespace: event-example
		-> Object: default-broker-ingress namespace: event-example
		-> Object: cluster-local-gateway namespace: gke-system
		-> Object: istio-ingress namespace: gke-system
		-> Object: istio-pilot namespace: gke-system
		-> Object: istio-citadel namespace: istio-system
		-> Object: istio-galley namespace: istio-system
		-> Object: istio-ingressgateway namespace: istio-system
		-> Object: istio-pilot namespace: istio-system
		-> Object: istio-policy namespace: istio-system
		-> Object: istio-sidecar-injector namespace: istio-system
		-> Object: istio-telemetry namespace: istio-system
		-> Object: promsd namespace: istio-system
		-> Object: eventing-controller namespace: knative-eventing
		-> Object: eventing-webhook namespace: knative-eventing
		-> Object: imc-controller namespace: knative-eventing
		-> Object: imc-dispatcher namespace: knative-eventing
		-> Object: sources-controller namespace: knative-eventing
		-> Object: activator namespace: knative-serving
		-> Object: autoscaler namespace: knative-serving
		-> Object: controller namespace: knative-serving
		-> Object: webhook namespace: knative-serving
		-> Object: event-exporter-v0.2.5 namespace: kube-system
		-> Object: fluentd-gcp-scaler namespace: kube-system
		-> Object: heapster namespace: kube-system
		-> Object: kube-dns namespace: kube-system
		-> Object: kube-dns-autoscaler namespace: kube-system
		-> Object: l7-default-backend namespace: kube-system
		-> Object: metrics-server-v0.3.1 namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level namespace: kube-system

Route found in serving.knative.dev/v1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Configuration found in serving.knative.dev/v1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Service found in serving.knative.dev/v1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Revision found in serving.knative.dev/v1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r namespace: default
		-> Object: grpc-ping-rc2jr namespace: default
		-> Object: hello-lbsxh-3 namespace: default
		-> Object: hello-tdpmb-1 namespace: default
		-> Object: hello-tjxhq-2 namespace: default

Service found in serving.knative.dev/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Revision found in serving.knative.dev/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r namespace: default
		-> Object: grpc-ping-rc2jr namespace: default
		-> Object: hello-lbsxh-3 namespace: default
		-> Object: hello-tdpmb-1 namespace: default
		-> Object: hello-tjxhq-2 namespace: default

Configuration found in serving.knative.dev/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Route found in serving.knative.dev/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Route found in serving.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Configuration found in serving.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Service found in serving.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

Revision found in serving.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r namespace: default
		-> Object: grpc-ping-rc2jr namespace: default
		-> Object: hello-lbsxh-3 namespace: default
		-> Object: hello-tdpmb-1 namespace: default
		-> Object: hello-tjxhq-2 namespace: default

MeshPolicy found in authentication.istio.io/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> GLOBAL: default

PodAutoscaler found in autoscaling.internal.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r namespace: default
		-> Object: grpc-ping-rc2jr namespace: default
		-> Object: hello-lbsxh-3 namespace: default
		-> Object: hello-tdpmb-1 namespace: default
		-> Object: hello-tjxhq-2 namespace: default

Metric found in autoscaling.internal.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r namespace: default
		-> Object: grpc-ping-rc2jr namespace: default
		-> Object: hello-lbsxh-3 namespace: default
		-> Object: hello-tdpmb-1 namespace: default
		-> Object: hello-tjxhq-2 namespace: default

Image found in caching.internal.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r-cache namespace: default
		-> Object: grpc-ping-rc2jr-cache namespace: default
		-> Object: hello-lbsxh-3-cache namespace: default
		-> Object: hello-tdpmb-1-cache namespace: default
		-> Object: hello-tjxhq-2-cache namespace: default
		-> Object: queue-proxy namespace: knative-serving

Broker found in eventing.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: default namespace: event-example

Trigger found in eventing.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: hello-consumer namespace: event-example

InMemoryChannel found in messaging.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: default-kne-ingress namespace: event-example
		-> Object: default-kne-trigger namespace: event-example

Subscription found in messaging.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: default-hello-consumer-e7e99d36-17aa-11ea-8e23-42010a800016 namespace: event-example
		-> Object: internal-ingress-default-a92403a9-17a7-11ea-8e23-42010a800016 namespace: event-example

Ingress found in networking.internal.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: hello namespace: default

ServerlessService found in networking.internal.knative.dev/v1alpha1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping-r7f8r namespace: default
		-> Object: grpc-ping-rc2jr namespace: default
		-> Object: hello-lbsxh-3 namespace: default
		-> Object: hello-tdpmb-1 namespace: default
		-> Object: hello-tjxhq-2 namespace: default

tracespan found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: stackdriver-span namespace: istio-system

handler found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: kubernetesenv namespace: istio-system

attributemanifest found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: istioproxy namespace: istio-system
		-> Object: kubernetes namespace: istio-system

kubernetes found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: attributes namespace: istio-system

rule found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: edgetosd namespace: istio-system
		-> Object: kubeattrgenrulerule namespace: istio-system
		-> Object: stackdriver-client namespace: istio-system
		-> Object: stackdriver-log namespace: istio-system
		-> Object: stackdriver-log-tcp namespace: istio-system
		-> Object: stackdriver-mixer namespace: istio-system
		-> Object: stackdriver-server namespace: istio-system
		-> Object: stackdriver-tcp-client namespace: istio-system
		-> Object: stackdriver-tcp-server namespace: istio-system
		-> Object: stackdriver-tracing-rule namespace: istio-system
		-> Object: tcpkubeattrgenrulerule namespace: istio-system

logentry found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: server-accesslog-stackdriver namespace: istio-system
		-> Object: server-tcp-accesslog-stackdriver namespace: istio-system

stackdriver found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: handler namespace: istio-system

metric found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: client-received-bytes-count namespace: istio-system
		-> Object: client-request-bytes namespace: istio-system
		-> Object: client-request-count namespace: istio-system
		-> Object: client-response-bytes namespace: istio-system
		-> Object: client-roundtrip-latencies namespace: istio-system
		-> Object: client-sent-bytes-count namespace: istio-system
		-> Object: mixer-request-count namespace: istio-system
		-> Object: mixer-request-latency namespace: istio-system
		-> Object: server-received-bytes-count namespace: istio-system
		-> Object: server-request-bytes namespace: istio-system
		-> Object: server-request-count namespace: istio-system
		-> Object: server-response-bytes namespace: istio-system
		-> Object: server-response-latencies namespace: istio-system
		-> Object: server-sent-bytes-count namespace: istio-system

edge found in config.istio.io/v1alpha2
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: default namespace: istio-system

Gateway found in networking.istio.io/v1alpha3
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: cluster-local-gateway namespace: knative-serving
		-> Object: gke-system-gateway namespace: knative-serving
		-> Object: knative-ingress-gateway namespace: knative-serving

VirtualService found in networking.istio.io/v1alpha3
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: grpc-ping namespace: default
		-> Object: grpc-ping-mesh namespace: default
		-> Object: hello namespace: default
		-> Object: hello-mesh namespace: default

DestinationRule found in networking.istio.io/v1alpha3
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: istio-policy namespace: istio-system
		-> Object: istio-telemetry namespace: istio-system

NodeMetrics found in metrics.k8s.io/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> GLOBAL: gke-gke-cluster-default-pool-ab457210-vbn1
		-> GLOBAL: gke-gke-cluster-default-pool-ab457210-z71m
		-> GLOBAL: gke-gke-cluster-default-pool-ab457210-37z1
		-> GLOBAL: gke-gke-cluster-default-pool-ab457210-dzg8
		-> GLOBAL: gke-gke-cluster-default-pool-ab457210-sh7q

PodMetrics found in metrics.k8s.io/v1beta1
	 ├─ API REMOVED FROM THE CURRENT VERSION AND SHOULD BE MIGRATED IMMEDIATELLY!!
		-> Object: fluentd-gcp-v3.1.1-ltxjb namespace: kube-system
		-> Object: grpc-ping-r7f8r-deployment-54d688d777-njswn namespace: default
		-> Object: event-exporter-v0.2.5-7d99d74cf8-pmxf6 namespace: kube-system
		-> Object: promsd-76f8d4cff8-6bzxk namespace: istio-system
		-> Object: kube-dns-autoscaler-85f8bdb54-tq8q6 namespace: kube-system
		-> Object: prometheus-to-sd-jt4zm namespace: kube-system
		-> Object: istio-ingress-5b4d9c44dd-z4tv7 namespace: gke-system
		-> Object: istio-sidecar-injector-6cf9dc4549-j6ktm namespace: istio-system
		-> Object: nginx-697b9dcc86-gmxfh namespace: default
		-> Object: grpc-ping-r7f8r-deployment-54d688d777-ghmd9 namespace: default
		-> Object: nginx-697b9dcc86-tm2dt namespace: default
		-> Object: fluentd-gcp-scaler-54ccb89d5-xsbnh namespace: kube-system
		-> Object: controller-55bb588dbd-ztjds namespace: knative-serving
		-> Object: prometheus-to-sd-msvsg namespace: kube-system
		-> Object: kube-proxy-gke-gke-cluster-default-pool-ab457210-37z1 namespace: kube-system
		-> Object: eventing-controller-7d75cd8598-wfs6w namespace: knative-eventing
		-> Object: kube-dns-5877696fb4-j4cdd namespace: kube-system
		-> Object: cluster-local-gateway-86db848cf5-pllhj namespace: gke-system
		-> Object: webhook-5dcf9dc6b5-5xkj8 namespace: knative-serving
		-> Object: daemonset-hold-image-8mqn7 namespace: kube-system
		-> Object: grpc-ping-r7f8r-deployment-54d688d777-sw5rj namespace: default
		-> Object: grpc-ping-r7f8r-deployment-54d688d777-hfbhn namespace: default
		-> Object: istio-galley-5bf8f944b7-dxrr7 namespace: istio-system
		-> Object: prometheus-to-sd-n96wf namespace: kube-system
		-> Object: istio-ingressgateway-57449dd8bc-tw6hf namespace: istio-system
		-> Object: eventing-webhook-5cb89d8974-4ztxb namespace: knative-eventing
		-> Object: imc-controller-654d689bc9-m5fgv namespace: knative-eventing
		-> Object: kube-proxy-gke-gke-cluster-default-pool-ab457210-sh7q namespace: kube-system
		-> Object: prometheus-to-sd-5cl6p namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-4plmf namespace: kube-system
		-> Object: stackdriver-metadata-agent-cluster-level-74d55f7669-xd6xh namespace: kube-system
		-> Object: daemonset-hold-image-hvkkk namespace: kube-system
		-> Object: istio-policy-59dd46fb7d-xnj6b namespace: istio-system
		-> Object: autoscaler-85f5b489d7-t55nt namespace: knative-serving
		-> Object: istio-pilot-56b86b87b6-hcj4d namespace: istio-system
		-> Object: kube-dns-5877696fb4-c4bnt namespace: kube-system
		-> Object: istio-citadel-5448cbc9f8-rjtm4 namespace: istio-system
		-> Object: istio-telemetry-699ffd959d-wd27n namespace: istio-system
		-> Object: nginx-697b9dcc86-gpvwh namespace: default
		-> Object: sources-controller-67788d5b86-j6jf8 namespace: knative-eventing
		-> Object: daemonset-hold-image-q6hpq namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-zk656 namespace: kube-system
		-> Object: imc-dispatcher-794f546c85-mz7d8 namespace: knative-eventing
		-> Object: activator-7688586ccb-gl9qx namespace: knative-serving
		-> Object: kube-proxy-gke-gke-cluster-default-pool-ab457210-dzg8 namespace: kube-system
		-> Object: prometheus-to-sd-psrt2 namespace: kube-system
		-> Object: fluentd-gcp-v3.1.1-9r62t namespace: kube-system
		-> Object: metrics-server-v0.3.1-57c75779f-vf72x namespace: kube-system
		-> Object: kube-proxy-gke-gke-cluster-default-pool-ab457210-vbn1 namespace: kube-system
		-> Object: heapster-846cc4b8c6-h9lr4 namespace: kube-system
		-> Object: kube-proxy-gke-gke-cluster-default-pool-ab457210-z71m namespace: kube-system
		-> Object: default-broker-ingress-7948d9b8fc-85rr6 namespace: event-example
		-> Object: fluentd-gcp-v3.1.1-6w9rl namespace: kube-system
		-> Object: daemonset-hold-image-d4vgx namespace: kube-system
		-> Object: daemonset-hold-image-qwvm7 namespace: kube-system
		-> Object: default-broker-filter-9fbc5c667-bwr2b namespace: event-example
		-> Object: istio-pilot-996485bd-m4cs4 namespace: gke-system
		-> Object: l7-default-backend-fd59995cd-gm7t2 namespace: kube-system

created time in 4 days

issue openedrikatz/kubepug

args[0] basename

Usage:
  /Users/ahmetb/.krew/bin/kubectl-deprecations [flags]

Examples:
/Users/ahmetb/.krew/bin/kubectl-deprecations

looks like this when installed via krew.

Consider doing something like

if filepath.Basename(args[0]) == "kubectl-deprecations" // or .exe
  show "kubectl deprecations"

created time in 4 days

issue openedrikatz/kubepug

don't write to current dir

Consider just creating a temp dir please.

created time in 4 days

pull request commentkubernetes-sigs/krew-index

Add kubepug (kubectl deprecations)

/lgtm /approve

rikatz

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

Add kubepug (kubectl deprecations)

Thanks. We'll go this way.

I still recommend these two strongly:

  1. Make sure your repo mentions krew installation method with the name here.
  2. When your plugin is executed with args[0]=/kubectl-deprecations , please adjust your -h/--help messages and usage strings to show this name, not 'pug', to not to confuse users installing this way.
rikatz

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Fixes typo

/lgtm /approve Thanks!

smoyer64

comment created time in 4 days

pull request commentkubernetes-sigs/krew-index

Add kubepug (kubectl deprecations)

I will keep the 'pug' name in the original problem

now I'm thinking we can keep krew name pug as well. Since it's unique enough I don't have a problem with it, just that the discoverability-by-name would be low. If you are ok with it as the author. We can keep it?

rikatz

comment created time in 4 days

pull request commentGoogleCloudPlatform/cloud-run-button

add github workflows for CI

Looks like the first build kicked off https://github.com/GoogleCloudPlatform/cloud-run-button/commit/0d1419d69a82454717a9799fc054b8c710509826/checks?check_suite_id=406604832

ahmetb

comment created time in 4 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 1d29a1aca9b479ba92f8636ae705583b1a6b3696

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 4 days

pull request commentGoogleCloudPlatform/cloud-run-button

add github workflows for CI

That would require bringing google secrets to GitHub which is not desirable. This should cover decent ground since it does a Docker Build. If that’s passing, cloudbuild is likely to pass (and vice versa).

ahmetb

comment created time in 4 days

pull request commentkubernetes-sigs/krew

Add link to sample-cli-plugin in developer guide

I think there are some changes we made to the sample-cli-plugin that aren’t merged still after such a long time. In that case we don’t need to link out until they’re merged.

chriskim06

comment created time in 5 days

push eventGoogleCloudPlatform/microservices-demo

Daniel Sanche

commit sha 53f25280949d2c41b2c31b11531a852f3a466b52

Fix double shebang in loadgen.sh (#284)

view details

push time in 5 days

PR merged GoogleCloudPlatform/microservices-demo

Fix double shebang in loadgen.sh cla: yes

Fixes double shebang in loadgen script. Running this script with sh instead of bash was causing ./loadgen.sh: 21: ./loadgen.sh: [[: not found to be printed on each run (but the service would still run successfully)

bug discovered here: https://github.com/GoogleCloudPlatform/microservices-demo/issues/283

+1 -2

0 comment

1 changed file

DanSanche

pr closed time in 5 days

issue commentGoogleCloudPlatform/microservices-demo

cartservice and loadgenerator crash at start

#!/bin/sh -eu on line 1 of the file, not the #!/bin/bash that comes on like 17. I can try to fix that soon

yes this sounds like the culprit.

Nusserdt

comment created time in 5 days

pull request commentGoogleCloudPlatform/cloud-run-button

add github workflows for CI

example: https://github.com/ahmetb/cloud-run-button/commit/ea60a56b49056e9328a1e4c973dbde54b4d12dec/checks?check_suite_id=405341392

ahmetb

comment created time in 5 days

pull request commentGoogleCloudPlatform/cloud-run-button

add github workflows for CI

Not sure why they're not running in this PR. Maybe it'll run after this one is merged. 🤷‍♂ They run on my fork.

ahmetb

comment created time in 5 days

PR opened GoogleCloudPlatform/cloud-run-button

add github workflows for CI

two jobs:

  • cloudshell_open: run tests, build an image (takes long b/c cloudshell base image is quite large)

  • redirector: run unit tests, build image

+33 -0

0 comment

1 changed file

pr created time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha ea60a56b49056e9328a1e4c973dbde54b4d12dec

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 898f631e324e20b15e11debf049ee021b169ca30

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 7cdae4f28c4e51f77529762fe52f71a185055e7a

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha a83f593e97ed6edf40fb960327bcd15e7cecfb28

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha a40d70a2e0e89d2f1fccbc9a84436d6a218119f5

add runs-on Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 361fef410c0915367e5568e45e98f32c5fe3575d

separate builds to jobs Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 1622b41fe49ba7061a125d491fa5dfa97fa11007

apparently docker is already included in gh machines Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

Ahmet Alp Balkan

commit sha 7eb5e3de1ac17d2d8d3ce06ff6ccfd23ade3a650

separate builds to jobs Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 766cef91fda29f454a70d296a631f7b3c475f063

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 427ce4e890f06746e592ba5c2f2c687ff57bac8c

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha 505447a6c82cea5b86d5937e7bfe98c7093c8390

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

push eventahmetb/cloud-run-button

Ahmet Alp Balkan

commit sha dc083d285e5051a4a85dd6506476d6b3b29bdff9

add github workflow Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>

view details

push time in 5 days

create barnchahmetb/cloud-run-button

branch : gh-wf

created branch time in 5 days

more