profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/adsteel/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

adsteel/hash_dot 63

Use dot syntax with Ruby hashes.

Mariana-Tek/engineering-ladder 7

Mariana Tek's Engineering Ladder

adsteel/composable_decorator 2

A simple, composable decorator for Rails models

adsteel/metex 2

Elixir weather utility

adsteel/redd 1

Redd is a batteries-included API wrapper for reddit.

adsteel/bindable 0

dependency injection for browser based javascript

adsteel/blitzy 0

a multi-node, distributed process, Elixir exercise

adsteel/C0elevation 0

Code for the website C0elevation.com.

adsteel/jas_vs_ams_comparison 0

JSON API Serializer vs Active Model Serializer Apples to Apples Benchmark Comparison

adsteel/kaizen 0

learning elixir and phoenix

release github/view_component

v2.34.0

released time in 9 days

release github/view_component

v2.33.0

released time in 16 days

release github/view_component

v2.32.0

released time in a month

PublicEvent

starteddwmkerr/hacker-laws

started time in a month

startedpublic-apis/public-apis

started time in a month

PR opened pusher/push-notifications-ruby

Bump rexml from 3.2.4 to 3.2.5

Bumps rexml from 3.2.4 to 3.2.5. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p> <blockquote> <h2>3.2.5 - 2021-04-05 {#version-3-2-5}</h2> <h3>Improvements</h3> <ul> <li> <p>Add more validations to XPath parser.</p> </li> <li> <p><code>require "rexml/document"</code> by default. [GitHub#36][Patch by Koichi ITO]</p> </li> <li> <p>Don't add <code>#dcloe</code> method to core classes globally. [GitHub#37][Patch by Akira Matsuda]</p> </li> <li> <p>Add more documentations. [Patch by Burdette Lamar]</p> </li> <li> <p>Added <code>REXML::Elements#parent</code>. [GitHub#52][Patch by Burdette Lamar]</p> </li> </ul> <h3>Fixes</h3> <ul> <li> <p>Fixed a bug that <code>REXML::DocType#clone</code> doesn't copy external ID information.</p> </li> <li> <p>Fixed round-trip vulnerability bugs. See also: <a href="https://www.ruby-lang.org/en/news/2021/04/05/xml-round-trip-vulnerability-in-rexml-cve-2021-28965/">https://www.ruby-lang.org/en/news/2021/04/05/xml-round-trip-vulnerability-in-rexml-cve-2021-28965/</a> [HackerOne#1104077][CVE-2021-28965][Reported by Juho Nurminen]</p> </li> </ul> <h3>Thanks</h3> <ul> <li> <p>Koichi ITO</p> </li> <li> <p>Akira Matsuda</p> </li> <li> <p>Burdette Lamar</p> </li> <li> <p>Juho Nurminen</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ruby/rexml/commit/a622645e980ea5b91ad7b4d6fec32d113f15df88"><code>a622645</code></a> Add 3.2.5 entry</li> <li><a href="https://github.com/ruby/rexml/commit/3c137eb119550874b2b3e27d12b733ca67033377"><code>3c137eb</code></a> Fix a parser bug that some data may be ignored before DOCTYPE</li> <li><a href="https://github.com/ruby/rexml/commit/9b311e59ae05749e082eb6bbefa1cb620d1a786e"><code>9b311e5</code></a> Fix a bug that invalid document declaration may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/f9d88e4948b4a43294c25dc0edb16815bd9d8618"><code>f9d88e4</code></a> Fix a bug that invalid document declaration may be generated</li> <li><a href="https://github.com/ruby/rexml/commit/f7bab8937513b1403cea5aff874cbf32fd5e8551"><code>f7bab89</code></a> Fix a bug that invalid element end may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/6a250d2cd1194c2be72becbdd9c3e770aa16e752"><code>6a250d2</code></a> Fix a bug that invalid element start may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/2fe62e29094d95921d7e19abbd2e26b23d78dc5b"><code>2fe62e2</code></a> Fix a bug that invalid notation declaration may be accepted</li> <li><a href="https://github.com/ruby/rexml/commit/a659c63e37414506dfb0d4655e031bb7a2e73fc8"><code>a659c63</code></a> Fix a bug that invalid notation declaration may be generated</li> <li><a href="https://github.com/ruby/rexml/commit/790dd113ce693ce831cbbc53f2f990a317643f75"><code>790dd11</code></a> Use ruby/setup-ruby (<a href="https://github-redirect.dependabot.com/ruby/rexml/issues/66">#66</a>)</li> <li><a href="https://github.com/ruby/rexml/commit/eda1b2007dd8751f381bf741f16c9e33c5d3e52a"><code>eda1b20</code></a> Clean up and enhance high-level RDoc (<a href="https://github-redirect.dependabot.com/ruby/rexml/issues/65">#65</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ruby/rexml/compare/v3.2.4...v3.2.5">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchpusher/push-notifications-ruby

branch : dependabot/bundler/rexml-3.2.5

created branch time in 2 months

startedstefankroes/ancestry

started time in 2 months

startedwhitequark/ast

started time in 2 months

startedadsteel/redd

started time in 3 months

issue closedpusher/push-notifications-ruby

[Feature request] Don't throw at config time

I integrated this gem into my app today, works great on local.

In my test pipeline (Heroku CI currently), my build fails because the initializer is receiving nil for the secret key and instance id:

Pusher::PushNotifications.configure do |config|
  config.instance_id = ENV['PUSHER_INSTANCE_ID']
  config.secret_key = ENV['PUSHER_SECRET_KEY']
end

That code throws if nothing is passed in:

      def instance_id=(instance_id)
        if instance_id.nil? || instance_id.delete(' ').empty?
          raise PushError, 'Invalid instance id'
        end
        @instance_id = instance_id
      end

Most ruby libraries I've interacted with don't throw at config/initialize time, they throw at runtime.

In this case I explicitly do not want to enter a valid pusher configuration to the test runner. This is a relatively easy fix for me as I can put in garbage env variables to the test runner or rescue the exception in the initializer.

But it's also going to force me to ensure every environment I ever spin up has some sort of beams credentials or else the entire app will fail to build/launch. In plenty of environments I don't need beams at all, it would be great if that exception could either be suppressed or if it didn't raise at all imho.

closed time in 3 months

msencenb

issue commentpusher/push-notifications-ruby

[Feature request] Don't throw at config time

But it's also going to force me to ensure every environment I ever spin up has some sort of beams credentials or else the entire app will fail to build/launch.

I mostly see this as a feature tbh, raising the exception as early as possible seems like a good idea. Since it's possible to insert fake credentials, I think it should be relatively easy to work around. I will close this as a wontfix, but please feel free to re-open this if you feel strongly about it (and if more people require this feature).

msencenb

comment created time in 3 months

issue closedpusher/push-notifications-ruby

Support Ruby 3.0

Using Ruby 3.0, Pusher::PushNotifications.publish fails:

> Pusher::PushNotifications.publish(interests: [])
ArgumentError: wrong number of arguments (given 1, expected 0; required keyword: interests)

closed time in 3 months

adsteel

issue commentpusher/push-notifications-ruby

Support Ruby 3.0

thanks again @jordansgrant, your PR has been merged and released as 2.0.1

adsteel

comment created time in 3 months

delete branch pusher/push-notifications-ruby

delete branch : fix_badges

delete time in 3 months

push eventpusher/push-notifications-ruby

Jon Elverkilde

commit sha e78e499273f7e70ccb2d95af46f04ae1f5f2596d

Fix badges

view details

Jon Elverkilde

commit sha 89b6437bc7da171f472b3c91dfc64a0cbb180e30

Merge pull request #25 from pusher/fix_badges Fix badges

view details

push time in 3 months

PR merged pusher/push-notifications-ruby

Fix badges

Description

Fix badges after migrating to GH actions. You can see the badges here https://github.com/pusher/push-notifications-ruby/tree/fix_badges#pusher-beams-ruby-server-sdk

CHANGELOG

  • [CHANGED] Fix badges after migrating to GH actions.
+1 -2

0 comment

1 changed file

elverkilde

pr closed time in 3 months

push eventpusher/push-notifications-ruby

Jon Elverkilde

commit sha e78e499273f7e70ccb2d95af46f04ae1f5f2596d

Fix badges

view details

push time in 3 months

Pull request review commentpusher/push-notifications-ruby

Fix badges

 # Pusher Beams Ruby Server SDK -[![Build Status](https://travis-ci.org/pusher/push-notifications-ruby.svg?branch=master)](https://travis-ci.org/pusher/push-notifications-ruby)-[![Coverage Status](https://coveralls.io/repos/github/pusher/push-notifications-ruby/badge.svg?branch=update-sdk)](https://coveralls.io/github/pusher/push-notifications-ruby?branch=update-sdk)+[![Test](https://github.com/pusher/push-notifications-ruby/actions/workflows/test.yml/badge.svg)](https://github.com/pusher/push-notifications-ruby/actions/workflows/test.yml) [![Coverage Status](https://coveralls.io/repos/github/pusher/push-notifications-ruby/badge.svg?branch=update-sdk)](https://coveralls.io/github/pusher/push-notifications-ruby?branch=update-sdk) [![Gem](https://img.shields.io/gem/v/pusher-push-notifications)(https://rubygems.org/gems/pusher-push-notifications)]

Yes! I just removed the branch param, assuming it defaults to the main branch

elverkilde

comment created time in 3 months

push eventpusher/push-notifications-ruby

Jon Elverkilde

commit sha 5497bf4e1dcc813fa6b3bcdc34c85bcad69851cb

Fix badges

view details

push time in 3 months

push eventpusher/push-notifications-ruby

Jon Elverkilde

commit sha 237d1e4862d08212878ea4cdac4bc1009b91b561

Fix badges

view details

push time in 3 months

created tagpusher/push-notifications-ruby

tag2.0.1

Pusher Beams Ruby Server SDK

created time in 3 months

release pusher/push-notifications-ruby

2.0.1

released time in 3 months

delete branch pusher/push-notifications-ruby

delete branch : hotfix_gemfile_lock

delete time in 3 months

push eventpusher/push-notifications-ruby

Jon Elverkilde

commit sha b6b717b41d0f60f0effc78ee5214da7a2eac26e2

Update Gemfile.lock after version bump

view details

Pusher CI

commit sha cbc2296952924d0e49e0c562910aa4d83dbe3681

Bump to version 2.0.1

view details

Jon Elverkilde

commit sha 41390c07f868f414b29933198c8279d5be9035dc

Merge pull request #24 from pusher/hotfix_gemfile_lock Fix Gemfile.lock

view details

push time in 3 months

PR merged pusher/push-notifications-ruby

Fix Gemfile.lock release-patch

Description

The lock file needs to be updated when the lib version is bumped, otherwise bundle install fails later. We could also let bundle handle it, but this works well (and is simpler atm).

CHANGELOG

  • [CHANGED] Update Gemfile lock on release.
+10 -3

0 comment

4 changed files

elverkilde

pr closed time in 3 months

Pull request review commentpusher/push-notifications-ruby

Fix badges

 # Pusher Beams Ruby Server SDK -[![Build Status](https://travis-ci.org/pusher/push-notifications-ruby.svg?branch=master)](https://travis-ci.org/pusher/push-notifications-ruby)-[![Coverage Status](https://coveralls.io/repos/github/pusher/push-notifications-ruby/badge.svg?branch=update-sdk)](https://coveralls.io/github/pusher/push-notifications-ruby?branch=update-sdk)+[![Test](https://github.com/pusher/push-notifications-ruby/actions/workflows/test.yml/badge.svg)](https://github.com/pusher/push-notifications-ruby/actions/workflows/test.yml) [![Coverage Status](https://coveralls.io/repos/github/pusher/push-notifications-ruby/badge.svg?branch=update-sdk)](https://coveralls.io/github/pusher/push-notifications-ruby?branch=update-sdk) [![Gem](https://img.shields.io/gem/v/pusher-push-notifications)(https://rubygems.org/gems/pusher-push-notifications)]
[![Test](https://github.com/pusher/push-notifications-ruby/actions/workflows/test.yml/badge.svg)](https://github.com/pusher/push-notifications-ruby/actions/workflows/test.yml) [![Coverage Status](https://coveralls.io/repos/github/pusher/push-notifications-ruby/badge.svg?branch=master)](https://coveralls.io/github/pusher/push-notifications-ruby?branch=master) [![Gem](https://img.shields.io/gem/v/pusher-push-notifications)(https://rubygems.org/gems/pusher-push-notifications)]

Shouldn't these be master branch?

elverkilde

comment created time in 3 months

PR opened pusher/push-notifications-ruby

Reviewers
Fix badges

Description

Fix badges after migrating to GH actions.

CHANGELOG

  • [CHANGED] Fix badges after migrating to GH actions.
+1 -2

0 comment

1 changed file

pr created time in 3 months