profile
viewpoint

Pull request review commenttektoncd/pipeline

Tag published images

 spec:       done        # Publish images and create release.yaml-      ko resolve --preserve-import-paths -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > /workspace/output/bucket/latest/release.yaml+      ko resolve --preserve-import-paths -t $(inputs.params.versionTag) -f /workspace/go/src/github.com/tektoncd/pipeline/config/ > /workspace/output/bucket/latest/release.yaml

Thank you for the reviews. I will submit another PR to remove the gcloud tagging.

adshmh

comment created time in 6 days

Pull request review commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

 func (c *changedFilesAgent) prChanges(pr *PullRequest) config.ChangedFilesProvid 		} 		c.RUnlock() -		// We need to query the changes from GitHub.-		changes, err := c.ghc.GetPullRequestChanges(-			string(pr.Repository.Owner.Login),-			string(pr.Repository.Name),-			int(pr.Number),-		)+		cloneRef := fmt.Sprintf("%s/%s", org, repo)+		r, err := c.gc.Clone(cloneRef) 		if err != nil {-			return nil, fmt.Errorf("error getting PR changes for #%d: %v", int(pr.Number), err)+			return nil, fmt.Errorf("error cloning repo %s: %v", cloneRef, err) 		}-		changedFiles = make([]string, 0, len(changes))-		for _, change := range changes {-			changedFiles = append(changedFiles, change.Filename)+		changedFiles, err = r.DiffThreeDot(string(pr.BaseRef.Name), string(pr.HeadRefOID))

Thank you for pointing this out. I did some tests with cloning a github repo and using three dot diff between master and a PR's headRefOID, and it seems that changes can be obtained this way. Could I be missing some cases? (alternatively, if that seems a better approach, I can simply add a call to CheckoutPullRequest before calling on the Diff method).

adshmh

comment created time in 12 days

Pull request review commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

 func (c *changedFilesAgent) prChanges(pr *PullRequest) config.ChangedFilesProvid 		} 		c.RUnlock() -		// We need to query the changes from GitHub.-		changes, err := c.ghc.GetPullRequestChanges(-			string(pr.Repository.Owner.Login),-			string(pr.Repository.Name),-			int(pr.Number),-		)+		cloneRef := fmt.Sprintf("%s/%s", org, repo)+		r, err := c.gc.Clone(cloneRef)

Thank you for the review. I will update the PR.

adshmh

comment created time in 12 days

PR opened tektoncd/pipeline

Tag published images

<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->

Changes

To make it easier to identify the installed version of tekton pipeline, built images are now individually tagged with the specified release. Partly addresses #1232.

This PR uses ko to tag the built images. Unfortunatelty, ko does not specify the image tag on the output (only specifies the digest). Therefore, what remains to be done is either: a) log an issue against ko to include the tags, or b) manually process the output of ko and append tags

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

+1 -1

0 comment

1 changed file

pr created time in 14 days

push eventadshmh/pipeline

Arash Deshmeh

commit sha 5487bbbed63b9a4939ec6d7c39d0254d130b4d84

Tag published images To make it easier to identify the installed version of tekton pipeline, built images are now individually tagged with the specified release. Partly addresses #1232. This PR uses ko to tag the built images. Unfortunatelty, ko does not specify the image tag on the output (only specifies the digest). Therefore, what remains to be done is either: a) log an issue against ko to include the tags, or b) manually process the output of ko and append tags Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 14 days

create barnchadshmh/pipeline

branch : 1232-releases-image-tags-include-version

created branch time in 14 days

pull request commentkubernetes/test-infra

Retire optional contexts removed from repos

I think we only want to do this when the tide configuration is set to not skip unknown contexts

Thank you for the review. I have updated the PR to retire removed contexts only when 'skip_unknown_contexts' is not set.

adshmh

comment created time in 20 days

push eventadshmh/test-infra

Petr Muller

commit sha 3349e02b6907eb70350121fc63456c25d5608063

github: Add UpdateRepo() method

view details

Petr Muller

commit sha 56ce7ad384b2e9e64cab1da7f073684da2e1ec20

peribolos: Add feature to update existing GitHub repos

view details

Petr Muller

commit sha 2828c7175f86bb3337bceb8dfa7aaf63c66ccab3

peribolos: Prevent unsupported API call to unarchive a repo

view details

Linus Arver

commit sha d37fa12b82eaf953491a67a6fb4314164d92de7e

promoter: bump image The images are now referenced from the official prod registry us.gcr.io/k8s-artifacts-prod, instead of the staging GCR. We have to use a regional GCR for now (US region) because the global redirect mirror is not set up yet. There are 2 other associated changes here: (1) the promoter manifests are now broken up into pairs "promoter-manifest.yaml" and "images.yaml" in the k8s.io repo, and so the `run_if_changed` field is updated accordingly; (2) the new `-thin-manifest-dir` flag is used, which only accepts the more secure "thin" promoter manifests where the credentials are separated from the image description.

view details

Jakub Pierewoj

commit sha 5ef15044442ca5f8af0122d0cdb64c6e5b8010d5

Enable logexporter in kubermark periodic tests It should work now, since the fix for using main cluster KUBECONFIG when calling dump-logs was merged.

view details

Petr Muller

commit sha 17b193b0e826819c14f95d792b1942e60d511d45

Make repo archival and publish subject to explicit allow parameter

view details

Petr Muller

commit sha 22f777b41a2b9edaccf8ec16988154083caf466a

peribolos: update all allowed repo properties Previously, when a not allowed change was encountered, it prevented the whole repo update, even if other (allowed) changes were requested. This commit makes peribolos just remove the forbidden change from the update request, so the remaining changes can be made.

view details

Ernest Wong

commit sha c5327a5b378407e3897dd4e9072eaee46d30b471

Add log dumping feature in Azure Deployer

view details

Hongkai Liu

commit sha bdb960d8a2e140da93cf5fb864e88d10fbb8701d

Isolate censoring logger from Secret Agent This allows for the logger with censoring to be imported without the context of secret agent.

view details

Amit Watve

commit sha 38afae0fb27e68df75530e8e75554096c75f66cc

[Gerrit] Modify lastUpdate to be per project instead of global.

view details

Amit Watve

commit sha 5c5464f27db8fb9aec5e84668fa97c62864eeadc

Remove pointers to maps.

view details

Cole Wagner

commit sha 973e13c1124725b5f82a854b3a27e988093084e2

Fix pj-on-kind.sh to work without JOB_CONFIG.

view details

Kubernetes Prow Robot

commit sha a1a5b03d5644aaf935fbb9aa833c94bfde013d30

Merge pull request #14916 from cjwagner/pj-on-kind-no-job-config Fix pj-on-kind.sh to work without JOB_CONFIG.

view details

Travis Clarke

commit sha da52344181dc98cab313a0fa4db7753accf206ac

Reduce "JobAgent.update" to one sort operation

view details

Kubernetes Prow Robot

commit sha e9f2eb5b498003936ad687e26fb2d3b7a930277b

Merge pull request #14897 from listx/master promoter: bump image

view details

Linus Arver

commit sha 86c5048bca197c7cd9514cbe5c0e8a5bb60aead4

pull-k8sio-cip: fix invocation This should have been done as part of https://github.com/kubernetes/test-infra/pull/14897.

view details

Kubernetes Prow Robot

commit sha 6c4d596890c3d460a9c7310aa64d8ca0f5091661

Merge pull request #14919 from listx/bump pull-k8sio-cip: fix invocation

view details

Lun-kai Hsu

commit sha 46ae109a5ffb15f86e05e8c49c965f376c0d7f26

alert on kubeflow periodic

view details

Adrian Ludwin

commit sha e956f074983aa9fcf2ece2c8d1b88f8fc6459440

Try to fix HNC trigger

view details

Stephen Augustus

commit sha f6450ce31a76af3f931137fd1d92e83dd54d5173

releng: Move prototype Kubernetes builds to test-infra-trusted cluster We missed this in a previous PR, but these prototype build jobs should run in the test-infra-trusted cluster so that they have credentials to execute GCB runs on the k8s-staging-release-test GCP project. Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

push time in 20 days

PR opened kubernetes/test-infra

Retire optional contexts removed from repos

status-reconciler now retires any optional contexts that are removed from repos, as these will otherwise block merges due to tide's skip-unknown-contexts being false by default.

Fixes #14705

+7 -3

0 comment

2 changed files

pr created time in 21 days

create barnchadshmh/test-infra

branch : 14705-retire-optional-removed-contexts

created branch time in 22 days

push eventadshmh/test-infra

Peter Rifel

commit sha c3aa4e89e06b719ea845ec3d7f83ac86a4e726ef

Update AMIs used by Kops periodic jobs

view details

Christoph Blecker

commit sha f6e04172672fac04aa2f0d2e5ddd1cbf95bdd74c

Add goose plugin

view details

Alvaro Aleman

commit sha b7e08fb7134bf6a536034a354eff16225756a04b

Config-{Forker,Rotator}: Use PresubmitsStatic() instead of directly accessing config

view details

Alvaro Aleman

commit sha 893a659c61670a89fca608aeb807ef6c01a3ec5c

Statusreconciler: Use PresubmitsStatic()

view details

Alvaro Aleman

commit sha 73ab64437f2b4ce3d8563d86ff0ab8b161ccd459

Testgrid configurator: Use PresubmitsStatic()

view details

Alvaro Aleman

commit sha dacf56e4686c5aeafa7fdb03de129f3b835b8154

Checkconfig: Use PresubmitsStatic

view details

Alvaro Aleman

commit sha 822140ac44eea191d7a663a1d91a0c31ec992951

Mkpj: Use PresubmitsStatic()

view details

Alvaro Aleman

commit sha a325c40bce47bbf40a85165bd98a3fb62d4e5586

Gerrit adapter: Use PresubmitsStatic()

view details

Alvaro Aleman

commit sha 18246a367a24f65d43b449a6f045838025bff0da

Extract presubmit validation

view details

Justin SB

commit sha 4198f2dfb0d0602a10d1de9488f132b22a256291

kops-verify-generated job Create a job that verifies that generated code/artifacts are up to date for kops PRs.

view details

Alvaro Aleman

commit sha 4b554160e85d8221b4946f3298c2b64ca403cbb3

Extract presubmit defaulting

view details

Alvaro Aleman

commit sha 5e09933d726b4c2e0505422dfd22cbe076a73668

Extract postsubmit defaulting

view details

Alvaro Aleman

commit sha be0670c3d63e18b40b52801d985595355918ff49

Extract periodics defaulting

view details

Cole Wagner

commit sha ade9d35b0719b804e33bf0f1b9285972132cbf30

Create an image to provide Prow autobump using the old bash scripts."

view details

Cole Wagner

commit sha e98b33c03fd1810902c888466dcde0415b11beef

Move experiment/prow-autobump to prow/cmd/autobump and build with bazel instead of cloudbuild.

view details

Matt Matejczyk

commit sha edc776c08afaab33642e096040860a69c57378a1

Use boskos for k8s.io/perf-tests presubmits Ref. https://github.com/kubernetes/perf-tests/issues/650

view details

Kubernetes Prow Robot

commit sha 0492f1d6ebc23b10ebe8a756e81fcbacf85ac92a

Merge pull request #14668 from cjwagner/back-to-the-bashics Add a simple generalized autobumper for Prow.

view details

Alvaro Aleman

commit sha f93c5a579a7acb35fea0584d531ec892af2e3042

Extract postsubmit validation

view details

Alvaro Aleman

commit sha 273c4f92ee8925ab15fd339480b46db7a0d652ec

Extract periodic validation

view details

Kubernetes Prow Robot

commit sha 0112de737ddd4d4e8505c298866593b2d87c12d4

Update prow to v20191009-0492f1d6e, and other images as necessary.

view details

push time in a month

Pull request review commentkubernetes/test-infra

Peribolos skip team repo if permissions invalid

 func configureTeamRepos(client teamRepoClient, githubTeams map[string]github.Tea  	actions := map[string]github.RepoPermissionLevel{} 	for wantRepo, wantPermission := range want {-		if havePermission, haveRepo := have[wantRepo]; haveRepo && havePermission == wantPermission {-			// nothing to do-			continue+		if havePermission, haveRepo := have[wantRepo]; haveRepo {+			if havePermission == github.None {

Thank you for the review. Since the 'have' items come from GitHub teams API, I thought only repos on which the team has some level of access will be listed, therefore 'none' in the above (should?) only refer to 'unparsable' case, otherwise the repo would not have been listed at all. Does that seem incorrect?

That line is an attempt to avoid updating permission levels according to 'want', if the existing permission, i.e. 'have', cannot be understood (as would be with 'Maintain' and 'Triage' levels).

Regarding the skip behaviour, do you mean it is preferable to just fail updating the team, rather than skipping the updating of its permission level on a repo?

adshmh

comment created time in a month

pull request commentkubernetes/test-infra

Peribolos skip team repo if permissions invalid

  • This is related to #14325. However, that issue is logged for when Peribolos is dumping the org structure. This PR is to prevent updating a team's repo if the existing permission level reported by GitHub API cannot be parsed (i.e. 'none' permission level)

  • Peribolos currently uses 'none' level in the org config file to remove repos from a team, i.e. cannot remove a repo from a team by not listing it in config. Therefore, dumping an org using Peribolos and then re-applying it will result in removal of repos with 'Triage' and 'Maintain' permission levels from the team. I have not modified that logic to avoid changing existing behaviour.

adshmh

comment created time in a month

PR opened kubernetes/test-infra

Peribolos skip team repo if permissions invalid

See #14325

Peribolos will now skip updating a repo for a team if the existing permission level for the team on the repo is 'none'. This is to avoid overwriting any of the team's repos if the existing permission level cannot be parsed, e.g. with new 'Triage' and 'Maintain' levels not yet exposed by GitHub API v3.

Signed-off-by: Arash Deshmeh adeshmeh@ca.ibm.com

+27 -3

0 comment

2 changed files

pr created time in a month

issue commentkubernetes/test-infra

Peribolos does not support new Github team repo permissions

This happens because GitHub API calls on ListTeamRepos returns false for all permission levels, i.e. push, pull, admin, when a team has the Maintainer role.

I couldn't find any v3 API calls that returns the beta new roles on a repository, but v4, i.e. graphql endpoint, does seem to report Maintainer or Triage levels

Peribolos does not currently use graphql endpoint, but perhaps it can be updated to do so. This could also mean fewer, ideally a single, calls to get the organisation structure, thus saving tokens.

I'd be happy to submit a patch if this sounds like a good approach.

coverprice

comment created time in a month

fork adshmh/pipeline

A K8s-native Pipeline resource.

https://tekton.dev

fork in a month

Pull request review commentkubernetes/test-infra

allow owners/github teams to override contexts

 func authorized(gc githubClient, log *logrus.Entry, org, repo, user string) bool 	return ok } +func authorizedTopLevelOwner(oc ownersClient, allowTopLevelOwners bool, log *logrus.Entry, org, repo, user string, pr *github.PullRequest) bool {+	if allowTopLevelOwners {+		owners, err := oc.LoadRepoOwners(org, repo, pr.Base.Ref)+		if err != nil {+			log.WithError(err).Warnf("cannot determine whether %s is a top level owner of %s/%s", user, org, repo)+			return false+		}++		if owners.TopLevelApprovers().Has(user) {

Thank you for catching that. Updated the PR.

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

allow owners/github teams to override contexts

 func authorized(gc githubClient, log *logrus.Entry, org, repo, user string) bool 	return ok } +func authorizedTopLevelOwner(oc ownersClient, allowTopLevelOwners bool, log *logrus.Entry, org, repo, user string, pr *github.PullRequest) bool {+	if allowTopLevelOwners {+		owners, err := oc.LoadRepoOwners(org, repo, pr.Base.Ref)+		if err != nil {+			log.WithError(err).Warnf("cannot determine whether %s is a top level owner of %s/%s", user, org, repo)+			return false+		}++		if owners.TopLevelApprovers().Has(user) {+			return true+		}+	}+	return false+}++func validateGitHubTeamSlugs(teamSlugs map[string][]string, org, repo string, githubTeams []github.Team) error {+	slugs := sets.NewString()+	for _, team := range githubTeams {+		slugs.Insert(team.Slug)+	}++	repoRef := fmt.Sprintf("%s/%s", org, repo)+	invalidSlugs := sets.NewString()+	for _, slug := range teamSlugs[repoRef] {+		if !slugs.Has(slug) {+			invalidSlugs.Insert(slug)

Thanks, updated the PR.

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

allow owners/github teams to override contexts

 func handle(oc overrideClient, log *logrus.Entry, e *github.GenericCommentEvent) 		return oc.CreateComment(org, repo, number, plugins.FormatResponseRaw(e.Body, e.HTMLURL, user, resp)) 	} +	if !authorized && !authorizedTopLevelOwner(oc, options.AllowTopLevelOwners, log, org, repo, user, pr) {+		resp := fmt.Sprintf("%s unauthorized: /override is restricted to repo administrators or top level code owners", user)

Thank you for the review. I have updated the PR.

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

allow owners/github teams to override contexts

 func authorized(gc githubClient, log *logrus.Entry, org, repo, user string) bool 	return ok } +func authorizedTopLevelOwner(oc ownersClient, allowTopLevelOwners bool, log *logrus.Entry, org, repo, user string, pr *github.PullRequest) bool {+	if allowTopLevelOwners {+		owners, err := oc.LoadRepoOwners(org, repo, pr.Base.Ref)+		if err != nil {+			log.WithError(err).Warnf("cannot determine whether %s is a top level owner of %s/%s", user, org, repo)+			return false+		}++		if owners.TopLevelApprovers().Has(user) {+			return true+		}+	}+	return false+}++func validateGitHubTeamSlugs(teamSlugs map[string][]string, org, repo string, githubTeams []github.Team) error {+	slugs := sets.NewString()+	for _, team := range githubTeams {+		slugs.Insert(team.Slug)+	}++	repoRef := fmt.Sprintf("%s/%s", org, repo)+	invalidSlugs := sets.NewString()+	for _, slug := range teamSlugs[repoRef] {+		if !slugs.Has(slug) {+			invalidSlugs.Insert(slug)+		}+	}+	if invalidSlugs.Len() > 0 {+		return fmt.Errorf("invalid team slug(s): %s", strings.Join(invalidSlugs.List(), ","))+	}+	return nil+}++func authorizedGitHubTeamMember(gc githubClient, log *logrus.Entry, teamSlugs map[string][]string, org, repo, user string) bool {+	repoRef := fmt.Sprintf("%s/%s", org, repo)+	teams, err := gc.ListTeams(org)+	if err != nil {+		log.WithError(err).Warnf("cannot get list of teams for org %s", org)+		return false+	}+	if err := validateGitHubTeamSlugs(teamSlugs, org, repo, teams); err != nil {

Thank you for the review. Yes, the validation only generates a warning to make sure an invalid team slug, e.g. a misspelling of a team's name, does not result in unexpected authorisation failure. I have updated the PR and added a test case to explicitly check for this.

adshmh

comment created time in a month

push eventadshmh/test-infra

Travis Clarke

commit sha 8dc8dcc48bf5c5e73196ad647693ea4e1aa6061e

frontend: deck config snippet implementation

view details

Travis Clarke

commit sha 6699060850f30f0b11f3069701eb86c6676285ed

backend: deck config snippet implementation

view details

Travis Clarke

commit sha 6c573ac3583cd8a79a1442afc706c6ee28f77159

deps: deck config snippet implementation

view details

Stephen Augustus

commit sha 7feee39850387e4ed9c0b1d8f54ea4d28f204532

capi: Add image pushing job for capz Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Patrick Ohly

commit sha 8a1c49f7a4d428f06c46e058d140bb61503ea956

kubernetes-csi: dind image bump

view details

Patrick Ohly

commit sha f3075e4edca560facf5447d15e051d92cc5d12cb

kubernetes-csi: clean up skipped branches Some of these branches have been removed from the repos and those that remain shouldn't be the target of a pull request, so we don't need to list them.

view details

Patrick Ohly

commit sha 16698a5e53ebfede197312419e9b141b9f92db63

kubernetes-csi: add dashboard annotations for all pull jobs The pull jobs for repos that get tested with multiple Kubernetes versions didn't have dashboard annotations. Those are preferred over explicitly configuring the dashboard.

view details

Patrick Ohly

commit sha 78da628e35469cdfa4a7226893b457e82eac9a2f

kubernetes-csi: avoid overriding Kubernetes version for single-Kubernetes repos The original intention was to let repos which only need to be tested against a single Kubernetes release choose that release themselves. The comment for `single_kubernetes_repos` still describes that behavior. https://github.com/kubernetes/test-infra/pull/13434 changed that so that 1.15 is used for all of these repos because of some issues with external-snapshotter. external-snapshotter now has 1.15 in its own prow.sh, so we don't need the override anymore in the test job and can revert to the original behavior.

view details

Patrick Ohly

commit sha 8dc06c2c5f4589ee6051a59dd86a2cb9cc955b29

kubernetes-csi: test snapshotter, resizer and liveness with different Kubernetes versions All are now part of all csi-driver-host-path deployments for Kubernetes 1.13 and later and their functionality may differ depending on the Kubernetes version. Therefore it makes sense to enable the full test matrix instead of testing with just one Kubernetes version.

view details

Patrick Ohly

commit sha 56b4e0d82f2777adef28383ffba58306ef07b2c0

testgrid: remove whitelisting of kubernetes-csi repos All of them are in testgrid now.

view details

Alvaro Aleman

commit sha c09cdf52d514221ac9d0564cceb2642d72d7d3a0

Tide: Use GetPresubmits

view details

Alvaro Aleman

commit sha 771f297f655cec52eb1ca131950ae86ad877b7ab

Tide: Re-Use subpools baseSha for contextPolicy

view details

Alvaro Aleman

commit sha 935f1483213e49b26bddbde688176f7c2bfd3885

Tide: De-Duplicate changes in batchChanges

view details

Alvaro Aleman

commit sha 64187ce6c2d32a88831e303534079d39e2affe3f

Tide: Don't shadow presubmits var in presubmityByPull

view details

Alvaro Aleman

commit sha 855db848b05cb256dbb5d07910508706d8892534

Avoid using a global for FakeInRepoConfig

view details

Justin SB

commit sha dae7c7ec9e4e3a850c140aaccf17d52f175e6bb9

kubetest: pass the cluster-tag to aws e2e This enables the correct tagging of volumes, as used by https://github.com/kubernetes/kubernetes/pull/83301

view details

Benjamin Elder

commit sha c59df6cd1a4d42c5753c32090e34916d08df45c2

bentheelder is oncall tomorrow, add to OWNERS

view details

Katharine Berry

commit sha 98327d480c33f2d0742a70599d9136e071bd3172

Don't try loading the remote config for runlocal. This can't possibly work - prow can't parse config prow has already parsed. Also, the /plugin-config endpoint is busted anyway.

view details

Katharine Berry

commit sha 96a1feb851f1c5b1bd1456e13c8acf5f8d17f32e

Force spyglass logs to soft wrap at end of line.

view details

Katharine Berry

commit sha e87b228f2d77834f7fa32d1d6d91c182a1454701

install the tool that makes this legible, I guess.

view details

push time in a month

Pull request review commentkubernetes/test-infra

allow owners/github teams to override contexts

 func authorized(gc githubClient, log *logrus.Entry, org, repo, user string) bool 	return ok } +func authorizedTopLevelOwner(oc ownersClient, allowTopLevelOwners bool, log *logrus.Entry, org, repo, user string, pr *github.PullRequest) bool {+	if allowTopLevelOwners {+		owners, err := oc.LoadRepoOwners(org, repo, pr.Base.Ref)+		if err != nil {+			log.WithError(err).Warnf("cannot determine whether %s is a top level owner of %s/%s", user, org, repo)+			return false+		}++		if owners.TopLevelApprovers().Has(user) {+			return true+		}+	}+	return false+}++func validateGitHubTeamSlugs(teamSlugs map[string][]string, org, repo string, githubTeams []github.Team) error {+	slugs := sets.NewString()+	for _, team := range githubTeams {+		slugs.Insert(team.Slug)+	}++	repoRef := fmt.Sprintf("%s/%s", org, repo)+	invalidSlugs := sets.NewString()+	for _, slug := range teamSlugs[repoRef] {+		if !slugs.Has(slug) {+			invalidSlugs.Insert(slug)+		}+	}+	if invalidSlugs.Len() > 0 {+		return fmt.Errorf("invalid team slug(s): %s", strings.Join(invalidSlugs.List(), ","))+	}+	return nil+}++func authorizedGitHubTeamMember(gc githubClient, log *logrus.Entry, teamSlugs map[string][]string, org, repo, user string) bool {+	repoRef := fmt.Sprintf("%s/%s", org, repo)+	teams, err := gc.ListTeams(org)

Thank you for the review. This was based on my interpretation of the comments on the issue that this was intended to allow override regardless of GitHub's teams' access to a repo, i.e. not necessarily follow GitHub teams' permissions on repositories. Could you please advise if only teams that manage a repo should be allowed to override?

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

 func (r *Repo) MergeCommitsExistBetween(target, head string) (bool, error) { 	} 	return len(b) != 0, nil }++// ThreeDotDiff does a three dot diff to get all the changes introduced by a+// commit/branch since it was last synced with the base branch.+// For more details, see:+// https://help.github.com/en/articles/about-comparing-branches-in-pull-requests+func (r *Repo) ThreeDotDiff(base, head string) ([]string, error) {

Thank you for the review. Yes, I think DiffThreeDot reads better as well.

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

 func retryCmd(l *logrus.Entry, dir, cmd string, arg ...string) ([]byte, error) {  func (r *Repo) Diff(head, sha string) (changes []string, err error) {

Thanks for the review. Updated the PR.

adshmh

comment created time in a month

push eventadshmh/test-infra

Katharine Berry

commit sha 7d8150288533d6ca182addeecb2c86a5dd078a37

don't pass --namespace to sinker

view details

Kubernetes Prow Robot

commit sha 4c871f02efffa9a6cd424644c0b0d1e8abe29907

Merge pull request #13944 from Katharine/unbreak-sinker Don't pass --namespace to sinker

view details

Linus Arver

commit sha 9d9216ae3a3eb9b067e2d1f66304c4585a586821

bump promoter images

view details

Haowei Cai

commit sha bba87db3c3cfae81ab5089fe5cf915f9b99ce793

remove CRD beta features from alpha jobs

view details

Miranda Christ

commit sha 4eb2b31e58c3938a66611379dbb8d557586a912a

Update GitHub OAuth docs

view details

Kubernetes Prow Robot

commit sha 93d008efd532653dfda076b09f6b8c3fd3496e50

Merge pull request #13946 from listx/bump bump promoter images

view details

Linus Arver

commit sha 3d8899a3bb8ff9a537aab4587b7fa32a0d8bd9fb

pull-k8sio-cip: add comment describing this job

view details

Linus Arver

commit sha 12b46b76425037f92a2ac1e23579aaf6f064163b

promoter: add e2e presubmit job

view details

Kubernetes Prow Robot

commit sha 6758a9c2679bf57883413f752c4fc1d68918b574

Merge pull request #13819 from mirandachrist/docs Update GitHub OAuth docs

view details

Kubernetes Prow Robot

commit sha 068e83ba2f8e9261c0af4cee598c70b92775945f

Merge pull request #13935 from krzyzacy/revert-plank-patch Revert #13908

view details

Steve Kuznetsov

commit sha 19349b8da524838f6a186553c18eaaeebe1a8286

Ping the on-call alias when sending alerts Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

view details

Kubernetes Prow Robot

commit sha cbe738ab76475b644206a62a74d01ecfcd13f937

Merge pull request #13949 from stevekuznetsov/skuznets/ping-oncall Ping the on-call alias when sending alerts

view details

Mateusz Szostok

commit sha bbbdb42d28e9b90393bc623c6dc937366f2fc667

Add e2e test pipeline for Service Catalog

view details

Aaron Crickenberger

commit sha 2dfc4d0765b9ac67447e374dddd40b0b5c9e9754

cherry-pick: metrics - upgrade py2 -> py3

view details

Aaron Crickenberger

commit sha 172dff48deb7f732878002ca92f0b00e1ad6568c

Update bigquery image to support python3 Specifically - update to ubuntu:18.04 so python3 == python3.6 (was 3.5 on 16.04) - drop python-yaml, we now use ruamel.yaml installed via pip - other arbitrary bumps to stay current that worked locally - pip installs - gcloud version - add a README.md

view details

Kubernetes Prow Robot

commit sha 95e572a5564a4ff4e285ed4a4bff38ef191a9765

Merge pull request #13912 from spiffxp/metrics-py3 metrics - upgrade py2 -> py3 (take 2)

view details

Kubernetes Prow Robot

commit sha 7a17c3a8dd48b4733c6c660ae8f24b982ec5d399

Merge pull request #13932 from chases2/move-config-tests Moving config_test.go to config/tests

view details

Aaron Crickenberger

commit sha a4b980951903143998c22094b95352bfb7b53f18

Bump image for metrics-bigquery job

view details

Erick Fejta

commit sha 8556bb9c60684521f0f8410e0207f27049068572

Update pypi requirements.txt

view details

Kubernetes Prow Robot

commit sha 30835d80214c523a85bfd61ef2a407c930a50205

Merge pull request #13955 from fejta/py Update pypi requirements.txt

view details

push time in a month

PR opened kubernetes/test-infra

allow owners/github teams to override contexts

Allow top level repo OWNERS and specified GitHub team(s) members to override contexts.

Fixes #14205

+391 -7

0 comment

10 changed files

pr created time in a month

push eventadshmh/test-infra

Arash Deshmeh

commit sha 7fd7e4bcf8f4123cacbea2a37b26ce0cea18f182

Consolidate warnings on unprotected branches BranchProtection config does not generate warning on every unprotected branch anymore to avoid spamming the log. Instead the warnings are aggregated for each affected repo. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha 20dbdb00b17b6cc6d3bdd791c6959334e1c1b998

Tide and Branchprotector warn once on unprotected branches Tide and BranchProtector generate warnings about repos with unprotected branches only once per repo. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 2 months

Pull request review commentkubernetes/test-infra

Warn only once on unprotected branches

 func main() { 	if err != nil { 		logrus.WithError(err).Fatalf("Failed to load --config-path=%s", o.config) 	}+	branchWarns, repoWarns := cfg.BranchProtectionWarnings()

Thank you for the review. Updated the PR.

adshmh

comment created time in 2 months

Pull request review commentkubernetes/test-infra

Warn only once on unprotected branches

 func TestConfig_GetBranchProtection(t *testing.T) { 		}) 	} }++func TestBranchProtectionWarnings(t *testing.T) {+	testCases := []struct {+		name                string+		config              Config+		expectedBranchWarns []string+		expectedRepoWarns   []string+	}{+		{+			name: "Repos with unprotected branches are added to the warning list",+			config: Config{+				ProwConfig: ProwConfig{+					BranchProtection: BranchProtection{+						Policy: Policy{+							RequiredStatusChecks: &ContextPolicy{+								Contexts: []string{"hello", "world"},+							},+						},+						AllowDisabledPolicies: true,+						Orgs: map[string]Org{+							"org1": {+								Repos: map[string]Repo{+									"repo1": {+										Branches: map[string]Branch{+											"branch1": {+												Policy{+													Protect: no,+												},+											},+										},+									},+									"repo2": {+										Branches: map[string]Branch{+											"branch1": {+												Policy{+													Protect: no,+												},+											},+										},+									},+								},+							},+						},+					},+				},+			},+			expectedBranchWarns: []string{"org1/repo1", "org1/repo2"},+		},+		{+			name: "Warn only once about repos with multiple unprotected branches",+			config: Config{+				ProwConfig: ProwConfig{+					BranchProtection: BranchProtection{+						Policy: Policy{+							RequiredStatusChecks: &ContextPolicy{+								Contexts: []string{"hello", "world"},+							},+						},+						AllowDisabledPolicies: true,+						Orgs: map[string]Org{+							"org1": {+								Repos: map[string]Repo{+									"repo1": {+										Branches: map[string]Branch{+											"branch1": {+												Policy{+													Protect: no,+												},+											},+											"branch2": {+												Policy{+													Protect: no,+												},+											},+										},+									},+									"repo2": {+										Branches: map[string]Branch{+											"branch1": {+												Policy{+													Protect: no,+												},+											},+										},+									},+								},+							},+						},+					},+				},+			},+			expectedBranchWarns: []string{"org1/repo1", "org1/repo2"},+		},+		{+			name: "Warning is generated for repos with disabled policies",+			config: Config{+				ProwConfig: ProwConfig{+					BranchProtection: BranchProtection{+						Policy: Policy{+							Protect: no,+							RequiredStatusChecks: &ContextPolicy{+								Contexts: []string{"hello", "world"},+							},+						},+						AllowDisabledPolicies: true,+						Orgs: map[string]Org{+							"org1": {+								Repos: map[string]Repo{+									"repo1": {+										Branches: map[string]Branch{+											"branch1": {+												Policy{+													Protect: yes,+												},+											},+										},+									},+									"repo2": {+										Branches: map[string]Branch{+											"branch1": {+												Policy{+													Protect: yes,+												},+											},+										},+									},+								},+							},+						},+					},+				},+			},+			expectedRepoWarns: []string{"org1/repo1", "org1/repo2"},+		},+	}++	for _, tc := range testCases {+		t.Run(tc.name, func(t *testing.T) {+			branchWarns, repoWarns := tc.config.BranchProtectionWarnings()+			t.Logf("DEBUG: %v", branchWarns)

Thanks. No, it wasn't. Fixed.

adshmh

comment created time in 2 months

push eventadshmh/test-infra

Hrishikesh Barman

commit sha 8cb0a57abd350ac4cdb06fe8fbfff6a292c4d5e3

Updated config-bootstrapper docs Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>

view details

Hrishikesh Barman

commit sha 3e36fffc0fd939bc2bf221de0780ce805e452db2

added requested changes and usage Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>

view details

Antonio Ojea

commit sha dc4d1de65d8538c6532443ad2f9ec6e5e7ad44c0

Set up kind jobs for 1.15 release

view details

Travis Clarke

commit sha beb83f5206f8ea53f053862890e89a576560bf0e

experiment/get_job_pods - upgrade py2 -> py3

view details

Travis Clarke

commit sha fc24268668fc58ba3b4bfba19a7648e0ab75cfa5

experiment/maintainence - upgrade py2 -> py3

view details

Davanum Srinivas

commit sha f3afdd1ff0b19f65fa3b04f08956e406c0024585

Remove additional processes for local-up-cluster Change-Id: Idb166465d7cabad662ba3d2f8d283dde531f0dc9

view details

Nikhita Raghunath

commit sha 5d731b5d34739315dcbb538580d0ef8bf4815dfa

retitle: enable allow_closed_issues option

view details

Arash Deshmeh

commit sha d43e10a91a75be4ddffc802588cd3e2e181b8a13

Add RepoPermissions to github User type The field permissions has been added to the github User type, thus included in the results returned from the ListCollaborators method. This is required by the branch protector to check the validity of the restrictions section of branch protection requests. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha aa4a6acf68fbec29b05e3c18869f701c811277ce

Add ListRepoTeams to GitHub client Add Permission field to Team and add the capability to return the list of teams with access to a repository from GitHub client. This is needed by branch protector to validate branch protection requests before sending them. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha 776308ab94ae3955768f63be9bf155b565354115

Validate branch protection requests for user/team authorization Branch protector verifies that any teams or collaborators specified in restrictions section of the branch protection request have either write or admin access to the repository. Requests with unauthorized collaborators or teams will be dropped before being submitted to github. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha c9d6dff90c756b496f4cc4d44d4eee3342e5cbfd

Use a feature flag for branchprotector request verification The feature to check whether a collaborator/team specified in the restrictions section is authorized for the target branch is now hidden behind a feature flag to avoid API token usage if the feature is not needed. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Sean Chase

commit sha 9d5b868d4cec8ca03116cfda8f8a7ec269ebe64d

Sharding Testgrid Config: sig-cl... sig-cli sig-cluster-lifecycle sig-instrumentation

view details

Nikhita Raghunath

commit sha fc17771552d42a516fb77b79bb2acb87c74192be

Add pull-kubernetes-{dependencies,verify} jobs for 1.16

view details

Martin André

commit sha 18ed0b9eb2ba3975b2d6059b6a21a63bb1d548a0

Only check for added owners Removing owners from the OWNERS file shouldn't flag them as untrusted. Nor should owners from the lines around ones that were edited in the patch. The verify-owners check should typically only flag added entries.

view details

Sen Lu

commit sha d0453f4fc1a1feb805186d8550c41c87ccdebc0c

Revert "Revert "Use patch instead of replace for prowjobs in plank"" This reverts commit c89268be382ab2557608c5c31438ec3e9b5aeb8f.

view details

Aaron Crickenberger

commit sha 459ecb9095747fb5e71661456af940e972897aca

swap periodic bazel jobs for postsubmits in sig-release boards There are postsubmit and periodic variants of bazel test and build jobs on sig-release dashboards. The postsubmits are currently in the -blocking and -all boards, and the periodics in -all. Jobs on release-blocking boards are expected to run at least every 3 hours. The postsubmits fail to meet this expectation since they tend to go quiet on the weekend when no commits are coming in. Reconcile to the following state for all but master - postsubmit bazel-foo goes to sig-release-1.y-all - periodic bazel-foo goes to sig-release-1.y-blocking, -all, google-unit For master: - postsubmit bazel-foo goes to google-unit - periodic bazel-foo goes to sig-release-master-blocking, -all, google-unit - bazel-foo-canary untouched, just field reordering I also adjusted the ordering of `name:` and `annotation:` fields for human readability

view details

Sen Lu

commit sha bd42e59c508ad4bc042eeae23705dfb2572068f3

update content type for patch method

view details

Hongkai Liu

commit sha 8c8767a6cb2c62b943cd256fe438113ccc8f9d21

Add more panels into ghproxy board

view details

Michelle Au

commit sha b1c1e9b72ea802ecccfb394ad0b5b06479228969

Disable csi-hostpath-v0 tests on alpha jobs and cleanup volume beta features

view details

John Howard

commit sha 8e84dc8a87cc37d0df6c0415bc285989d0ad9a4c

Update Istio testgrid configs

view details

push time in 2 months

Pull request review commentkubernetes/test-infra

Warn only once on unprotected branches

 func (c *Config) GetPolicy(org, repo, branch string, b Branch) (*Policy, error) 		old, policy.Protect = policy.Protect, old 		switch { 		case policy.defined() && c.BranchProtection.AllowDisabledPolicies:-			logrus.Warnf("%s/%s=%s defines a policy but has protect: false", org, repo, branch)+			unprotectedRepo = true 			policy = Policy{ 				Protect: policy.Protect, 			} 		case policy.defined():-			return nil, fmt.Errorf("%s/%s=%s defines a policy, which requires protect: true", org, repo, branch)+			return nil, false, fmt.Errorf("%s/%s=%s defines a policy, which requires protect: true", org, repo, branch) 		} 		policy.Protect = old 	}  	if !policy.defined() {-		return nil, nil+		return nil, false, nil+	}+	return &policy, unprotectedRepo, nil+}++// BranchProtectionWarnings returns two sets of strings:+// - The list of repos with unprotected branches,+// - The list of repos with disabled policies, i.e. Protect set to false,+//     because any branches not explicitly specified in the configuration will be unprotected.+func (c *Config) BranchProtectionWarnings() ([]string, []string) {+	branchWarns := sets.NewString()+	repoWarns := sets.NewString()+	for orgName, org := range c.BranchProtection.Orgs {+		for repoName, repo := range org.Repos {+			repoRef := fmt.Sprintf("%s/%s", orgName, repoName)+			repoPolicy := c.BranchProtection.GetOrg(orgName).GetRepo(repoName)+			if repoPolicy.Protect != nil && !*repoPolicy.Protect {+				if c.BranchProtection.AllowDisabledPolicies {+					repoWarns.Insert(repoRef)+				}+			}+			for branchName := range repo.Branches {+				b, err := repoPolicy.GetBranch(branchName)+				if err != nil {+					continue+				}+				_, unprotectedRepo, err := c.getBranchPolicy(orgName, repoName, branchName, *b)

Thanks for the review. Done.

adshmh

comment created time in 2 months

push eventadshmh/test-infra

Arash Deshmeh

commit sha cc44a8cc4574baf9fc54d66fcfae5dcd44773f36

Consolidate warnings on unprotected branches BranchProtection config does not generate warning on every unprotected branch anymore to avoid spamming the log. Instead the warnings are aggregated for each affected repo. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha ac91a40ac43535111c4b663d568cfb0ce47d3158

Tide and Branchprotector warn once on unprotected branches Tide and BranchProtector generate warnings about repos with unprotected branches only once per repo. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 3 months

fork adshmh/kube-state-metrics

Add-on agent to generate and expose cluster-level metrics.

fork in 3 months

Pull request review commentkubernetes/test-infra

branchprotector checks restrictions section user/team for authorisation

 func (p *protector) UpdateRepo(orgName string, repoName string, repo config.Repo 		} 	} +	var collaborators, teams []string+	if p.verifyRestrictions {+		collaborators, err = p.authorizedCollaborators(orgName, repoName)+		if err != nil {+			logrus.Infof("%s/%s: error getting list of collaborators: %v", orgName, repoName, err)+			return err+		}++		teams, err = p.authorizedTeams(orgName, repoName)+		if err != nil {+			logrus.Infof("%s/%s: error getting list of teams: %v", orgName, repoName, err)+			return err+		}+	}+ 	for bn, githubBranch := range branches { 		if branch, err := repo.GetBranch(bn); err != nil { 			return fmt.Errorf("get %s: %v", bn, err)-		} else if err = p.UpdateBranch(orgName, repoName, bn, *branch, githubBranch.Protected); err != nil {+		} else if err = p.UpdateBranch(orgName, repoName, bn, *branch, githubBranch.Protected, collaborators, teams); err != nil { 			return fmt.Errorf("update %s from protected=%t: %v", bn, githubBranch.Protected, err) 		} 	} 	return nil } +// authorizedCollaborators returns the list of Logins for users that are+// authorized to write to a repository.+func (p *protector) authorizedCollaborators(org, repo string) ([]string, error) {+	collaborators, err := p.client.ListCollaborators(org, repo)+	if err != nil {+		return nil, err+	}+	var authorized []string+	for _, c := range collaborators {+		if c.Permissions.Admin || c.Permissions.Push {+			authorized = append(authorized, c.Login)

Thanks. I have updated the PR. From reading the github API doc, it does not seem that Login field could include @, but perhaps this change makes it more straightforward to write the config file, i.e. use lower case and no @.

adshmh

comment created time in 3 months

Pull request review commentkubernetes/test-infra

branchprotector checks restrictions section user/team for authorisation

 func (c *client) CreateFork(owner, repo string) error { 	return err } +// ListRepoTeams gets a list of all the teams with access to a repository+// See https://developer.github.com/v3/repos/#list-teams+func (c *client) ListRepoTeams(org, repo string) ([]Team, error) {

Thanks for the review. ghproxy seems to include that path already: From the code (the very last line is teams under /repos/owner/repo):

https://github.com/kubernetes/test-infra/blob/43ccd36b7941c233db30ed510bf2511fbea98315/ghproxy/ghmetrics/ghpath.go#L30-L83

And from running ghproxy:

github_request_duration_bucket{path="/repos/:owner/:repo/teams",status="İ",token_hash="...",le="0.025"} 0
github_request_duration_bucket{path="/repos/:owner/:repo/teams",status="İ",token_hash="...",le="0.05"} 0
github_request_duration_bucket{path="/repos/:owner/:repo/teams",status="İ",token_hash="...",le="0.1"} 1
adshmh

comment created time in 3 months

push eventadshmh/test-infra

Cosmin Cojocar

commit sha ebe56e4d5e71fd586a6f60e0017647fc9c0b7e88

Make sure in the pipeline controller that the in-cluster and default cluster alias do not point to the same cluster when all contexts are allowed Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>

view details

Cosmin Cojocar

commit sha a8d2e8662a26c2681ebf644c0be5b85f044e3112

Make sure in the build controller that the in-cluster and default cluster alias do not point to the same cluster when all contexts are allowed Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>

view details

Cosmin Cojocar

commit sha 2950daecfe0365053ea709aed2b19da3ec8092b8

Remove alays the InClusterContext since the controller maps it to DefaultClusterAlias Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>

view details

Nikhita Raghunath

commit sha 8d591a23a55a28c8940be573f99ac71579da600d

Revert "Merge pull request #12402 from stevekuznetsov/skuznets/revert-owners-plugin-feature" This reverts commit 7972f39b11105ad9839d582006d7ee8d0fbd741d, reversing changes made to 034554bf43435d3eaab2d09b670778e030aa0699.

view details

Nikhita Raghunath

commit sha a5f17a57c68bfd3011f281ad3f269bc1c94b912b

verify-owners: don't at mention folks who aren't part of the org

view details

Nikhita Raghunath

commit sha 44c01277003657c5a84db14910207171b20d054e

repoowners: allow to ignore preconfigured blacklisted dirs

view details

Nikhita Raghunath

commit sha 337b8b4cdefaa5073a510ec04b3b5133f59be4e6

verify-owners: traverse using OwnersDirBlacklist

view details

Nikhita Raghunath

commit sha 270c5e3e933e59938ab5bae0c202a07d2e85954b

Update bazel

view details

Nikhita Raghunath

commit sha 2d56cf6d354c07841da7ff5bd0139c3bc4454f81

verify-owners: break early while looking for OWNERS_ALIASES changes

view details

Nikhita Raghunath

commit sha 170d6887904f42ad98a72bcafb9350bc7f806393

Improve Godoc for OwnersDirBlacklist

view details

Nikhita Raghunath

commit sha 071ea5ea0d306ce05cf44e13dfc1ef4312d68a68

verify-owners: don't check for trusted users if skipCollaborators is enabled

view details

Nikhita Raghunath

commit sha 7f27a3184a8ef331762222932444adfb6699e7e8

Return early when error is filepath.SkipDir

view details

Janek Łukaszewicz

commit sha 5efba3b96df33e83c21b677c636452e35378d128

Enable kube-proxy scrapping in gce5000. ref https://github.com/kubernetes/perf-tests/issues/615

view details

RainbowMango

commit sha 2fc6418d0287dab8342ab200f48317c492404c20

Add projects to Prow user list

view details

Katharine Berry

commit sha 26223f3f4f6dc5e8916487a58b66751431b63504

Add spyglass.scrollTo() API.

view details

Katharine Berry

commit sha 1d9d8bd2f49e4610b52b88d85f2288831f3dd05a

Add support for linking to log lines in the buildlog lens.

view details

Katharine Berry

commit sha f56bf6d3711816e548785c5c648be6a6211c7330

Make the spyglass README something usefully readable.

view details

Alvaro Aleman

commit sha 3718d95a58b9099de2e3ee247622bd5602a0dd86

Clean up pods whose ProwJob is in aborted state We do not care about the result anymore, so free the resources the Pod is occupying.

view details

Stephen Augustus

commit sha f9b2560fc974eb0300c088e74a6b6aa40245bc10

sig-release: Add/update jobs for building debs/rpms Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Beata Skiba

commit sha df178b4da44dc85eac15c0dba88f142a7ade9d59

Increase timeouts for VPA jobs

view details

push time in 3 months

more