profile
viewpoint

fork adshmh/eventing

Open source specification and implementation of Knative event binding and delivery

https://knative.dev/docs/eventing

fork in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

 func FromContextOrDefaults(ctx context.Context) *Config { 		return cfg 	} 	defaults, _ := NewDefaultsFromMap(map[string]string{})+	featureFlags, _ := NewFeatureFlagsFromMap(map[string]string{}) 	return &Config{-		Defaults: defaults,+		Defaults:     defaults,+		FeatureFlags: featureFlags,

Thanks a lot for working on this, I've been wondering why we used the configStore for pipelineruns and not for taskruns too. My main questions on this is whether we really need the extra module, or if we could just use the existing one and add extra flags to it?

Thank you for the detailed review. Please let me know if the following sounds correct. I'd be happy to update the PR if needed to merge the two sets of options.

I have implemented the draft this way mainly because the feature-flags and config-defaults are different config maps. Modules using the config store are only minimally affected by this: they use config store the same way, i.e. by passing the context, just specify the flags under FeatureFlags "option group" as Defaults and FeatureFlags are both structs under the same config module.

If combining the two sets is preferred, please let me know and I will update the PR.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

 func TestReconcile_ExplicitDefaultSA(t *testing.T) { 	} } +func TestReconcile_FeatureFlags(t *testing.T) {+	taskWithEnvVar := tb.Task("test-task-with-env-var",

Thank you for the review. Fixed.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

 func getRunName(tr *v1beta1.TaskRun) string { 	return strings.Join([]string{tr.Namespace, tr.Name}, "/") } +func ensureConfigurationConfigMapsExist(d *test.Data) {+	var defaultsExists, featureFlagsExists bool+	for _, cm := range d.ConfigMaps {+		if cm.Name == config.GetDefaultsConfigName() {+			defaultsExists = true+		}+		if cm.Name == config.GetFeatureFlagsConfigName() {+			featureFlagsExists = true+		}+	}+	if !defaultsExists {+		d.ConfigMaps = append(d.ConfigMaps, &corev1.ConfigMap{+			ObjectMeta: metav1.ObjectMeta{Name: config.GetDefaultsConfigName(), Namespace: system.GetNamespace()},+			Data:       map[string]string{},+		})+	}+	if !featureFlagsExists {+		d.ConfigMaps = append(d.ConfigMaps, &corev1.ConfigMap{+			ObjectMeta: metav1.ObjectMeta{Name: config.GetFeatureFlagsConfigName(), Namespace: system.GetNamespace()},+			Data:       map[string]string{},+		})+	}+}+ // getTaskRunController returns an instance of the TaskRun controller/reconciler that has been seeded with // d, where d represents the state of the system (existing resources) needed for the test.-func getTaskRunController(t *testing.T, d test.Data) (test.Assets, func()) {+func getTaskRunController(t *testing.T, d test.Data) (test.Assets, func(), chan<- struct{}) { 	//unregisterMetrics() 	ctx, _ := ttesting.SetupFakeContext(t) 	ctx, cancel := context.WithCancel(ctx) 	cloudEventClientBehaviour := cloudevent.FakeClientBehaviour{ 		SendSuccessfully: true, 	} 	ctx = cloudevent.WithClient(ctx, &cloudEventClientBehaviour)+	ensureConfigurationConfigMapsExist(&d) 	c, _ := test.SeedTestData(t, ctx, d) 	configMapWatcher := configmap.NewInformedWatcher(c.Kube, system.GetNamespace())++	controller := NewController(namespace, images)(ctx, configMapWatcher)++	stopCh := make(chan struct{})+	if err := configMapWatcher.Start(stopCh); err != nil {+		t.Fatalf("error starting configmap watcher: %v", err)+	}+ 	return test.Assets{-		Controller: NewController(namespace, images)(ctx, configMapWatcher),+		Controller: controller, 		Clients:    c,-	}, cancel+	}, cancel, stopCh

Thank you for the review. Fixed. I will take a look and submit a PR if there is a way to avoid dealing with the channel altogether, i.e. letting SetupFakeContext handle it.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

+# Copyright 2019 The Tekton Authors

Thank you for the review. Fixed.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

+# Copyright 2019 The Tekton Authors

Thank you for the review. Fixed.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

+# Copyright 2019 The Tekton Authors

Thank you for the review. Fixed.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

+/*+Copyright 2019 The Tekton Authors

Thank you for the review. Fixed.

adshmh

comment created time in 3 days

Pull request review commenttektoncd/pipeline

Introduce config map watcher for feature flags

+/*+Copyright 2019 The Tekton Authors

Thank you for the review. Fixed.

The other question I have is about the existing config store. The testing methods for the pipelinerun controller do not support having configmaps as test data to seed. I think this probably means that we had less coverage there. Would it make sense to add the same feature there? (possibly in a different PR)

Sure. I will review the pipelinerun controller code and submit a PR to cover this.

adshmh

comment created time in 3 days

push eventadshmh/pipeline

Jonas Pettersson

commit sha f8a61efc1e7718311f306c4d73b27eb00c72b514

Improve TaskRun workspaces documentation This commit contains similar changes for the TaskRun section as what was done for the PipelineRun section in https://github.com/tektoncd/pipeline/pull/2521 - We did not provide a full example of a TaskRun definition under "Examples of `TaskRun` definition using `Workspaces`" This commit add a full example of a TaskRun definition. - Examples of how to use different volume sources already exists under "Specifying `VolumeSources` in `Workspaces`", add a link to that section instead of having the same examples under the TaskRun section. - A few broken links in the table-of-contents are fixed. /kind documentation

view details

Vincent Demeester

commit sha 078f08168b2cc3f60ccf7c4acc63c666350eb6b0

Run tekton containers as nonroot 🐰 This changes a slew of containers that Tekton runs to use non-root base images. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

view details

Scott

commit sha 17fec6c9f6b4578a1fff5923b81cb00e10f39a14

Fix a typo, "space names" -> "namespaces" Task results are useful for storing "ephemeral namespaces" rather than "ephemeral space names".

view details

Divyansh42

commit sha ebae092269ed9146bdc0487204addbf8a214df3c

Add replacement for cluster resource in "v1alpha1 to v1beta1 migration" docs This is part of providing documentation for alternative to pipeline resource. As we have now kubeconfig-creator task in the catalog as the replacement for cluster resource, Added the same in the "v1alpha1 to v1beta1 migration" docs. Ref: #1369 Signed-off-by: Divyansh42 <diagrawa@redhat.com>

view details

Alan Greene

commit sha 2fde1e007dfede21645b68a2684b8248b9e7bcc4

Fix 'Edit this page' and 'Create an issue' links on the website Add a cascading page property to the frontmatter of docs/README.md that will apply to all child pages displayed in the pipeline section of the docs on the website. This ensures the 'Edit this page' and 'Create an issue' links in the sidebar point to the pipeline repo instead of the website repo.

view details

Jonas Pettersson

commit sha 6e241310c21f8763b3b587b4232b5fbde651fa7e

Improve documentation about guarding Task execution using Conditions As noted in #2635, it is not very clear what a Condition is in the context of a Pipeline. And it is not clear how they work or what happens after. This commit use the concept with "Guards" to explain how to guard Task execution within a Pipeline using Condition resources. An example showing the flow when a Condition is not successfully evaluated is also added. /kind documentation

view details

Jonas Pettersson

commit sha f316eaec706370e80527c9a88557f8c08ccbabac

Various documentation fixes I see `Task` - `TaskRun`, and `Pipeline` - `PipelineRun` as _pairs_, so I move `PipelineResource` to the bottom of the table. /kind misc

view details

Jonas Pettersson

commit sha 3554a30d98889f6d6560df064b15023a2cb52630

Improve Pod template documentation The `hostNetwork` field was added to Pod template in #2325 but not documented in the [Pod template](https://github.com/tektoncd/pipeline/blob/master/docs/podtemplates.md) documentation. It is added in this commit. Also: - Clarify that the Pod template is for both `TaskRun` and `PipelineRun`. - Fixing broken links in the documentation - Removing `hostNetwork` from the `TaskRun` documentation, since it is a special case, but document it in the Pod template documentation. /kind documentation

view details

Andrea Frittoli

commit sha af95a2d87adcf15225be26ac7d7ea48330ff633f

Fix helm chart for deprecated extensions/v1beta1 As of k8s 1.16 extensions/v1beta1 is deprecated, so the deployment in the test helm chart should be fixed accordingly. Since the chart is pulled from master, temporary let the test pass until this is merged, then we can enforce back the check.

view details

Christie Wilson

commit sha fd1b000396029c9db9e8ffbe6698e8af1c6910c5

Provide more guidance on not using PipelineResources 🚧 This commit makes some updates to the migration guide: - The section on how the inputs/outputs PipelineResources spec has changed is now at the end of the guide, since it's a bit confusing to tell ppl to try to migrate away from them and have the new syntax for these front and center at the same time - There is now an example of how you can make a Pipeline that does the equivalent of what you used to get with a Task that used image and git resources

view details

Andrea Frittoli

commit sha 18056719200277fa7e014d0046dfcdf9e3a29d4c

Sync the pipelinerun status from the informers When we reconcile a pipelinerun, we should ensure that the pipelinerun status is always in sync with the actual list of taskruns that can be provided by the taskrun informer. The only way to filter taskruns is by labels tekton.dev/pipelinerun. In case an orphaned taskrun is found, we can use the other labels on the taskrun to reconstruct the missing entry in the pipelinerun status, whether it's a missing taskrun or a missing condition check.

view details

Vincent Demeester

commit sha a87139b816d81a4f0833170fcf9015f217b3f352

Update nop, gsutil and shell images - Bump to latest for tianon/true and gcr.io/distroless/base:debug - Bump to 293.0.0 for google/cloud-sdk This witch from debian based to alpine based for `google/cloud-sdk` (`-slim` tag). This is mainly to be *on-par* with the rest of the images (that are based on `distroless` which tends to be based on apline (or `scratch`) Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

view details

Andrea Frittoli

commit sha cc2ca6aad5ba9b141a9d32d629437af8a025281c

The deployments v1 the selector is mandatory Our test helm chart is missing the mandatory spec.selector field, adding it to re-enable the test to pass.

view details

pengli

commit sha 332a5c711dca1018600b1376c64775984f1793fe

Find first error step based on "FinishAt" and "StartAt" Fix issue: #2415 Introduce `StartAt` for the sorting when `FinishedAt` are exactly the same. Since the goal is to find the first failed step, the StartAt and FinishedAt are most simple and directly solution. Moreover, adopt a higher resolution format for `StartAt` to make it more accurately.

view details

Scott

commit sha 69088aa36260e5f38a6c008c6bb6deda9a0e9848

Document git ssh symlink requirement When relying on creds-init to generate git ssh credentials a user will need to symlink from /tekton/home/.ssh to /root/.ssh if they're issuing `git` commands in a Step's script or image. This commit documents the need to symlink in auth.md.

view details

Andrea Frittoli

commit sha 25f9ec70b0eab0112b7a3119115bcc9291aa26fe

Re-enable the helm chart test The helm chart test was disabled in https://github.com/tektoncd/pipeline/pull/2652 to solve an issue with the helm chart. Re-enable the test now.

view details

Justin Kulikauskas

commit sha e83aa5ffcaed07ee176135b957f7934f40837a11

Improve formatting of Docker Desktop instructions

view details

Andrea Frittoli

commit sha a6081f167c5b1461a197ab98e93103f405247f19

Move events to a common package Move both events.go and the cloudevents module under a new module reconciler.events. We want to the controllers to be able to emit both kubernetes events and cloudevents, so this change is in preparation to creating a common event interface to be used by controllers. Partially addresses #2082

view details

Jonas Pettersson

commit sha fc24674a2e65a724a183e2b8f01314bb7f17d629

Add variable expansion for params in Projected Volume fields A [projected volume](https://kubernetes.io/docs/concepts/storage/volumes/#projected) can mount/project files from `Secrets`, `ConfigMaps` and `ServiceAccountTokens`. Is is good if the end user can choose the name of `Secrets`, `ConfigMaps` and the audience of `ServiceAccountTokens`. With this commit, the task author can use `params` for `secret.name`, `configmap.name` and `serviceaccounttoken.audience` in a Projected Volume. See examples of use cases in #2597 Fixes #2597

view details

Arash Deshmeh

commit sha 76b39ec3c98a622bedc402890cc38c383acbe041

Add feature flags to config store Feature flags configuration is now tracked by the config store. This allows watching for the corresponding config map changes, removing the need to call kubernetes API to get the feature flags config map every time a pod is created. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 3 days

Pull request review commentkubernetes/test-infra

Comment accordingly if /test all cant run any jobs

 func FilterPresubmits(honorOkToTest bool, gitHubClient GitHubClient, body string 	return pjutil.FilterPresubmits(filter, changes, branch, presubmits, logger) } -func availablePresubmits(githubClient GitHubClient, body, org, repo, branch string, number int, presubmits []config.Presubmit, logger *logrus.Entry) ([]string, error) {+// availablePresubmits returns 2 sets of presubmits:+// 1. presubmits that can be run with '/test all' command.+// 2. presubmits that can be run with their trigger, e.g. '/test job'+func availablePresubmits(githubClient GitHubClient, body, org, repo, branch string, number int, presubmits []config.Presubmit, logger *logrus.Entry) ([]string, []string, error) { 	changes := config.NewGitHubDeferredChangedFilesProvider(githubClient, org, repo, number)-	all := func(p config.Presubmit) (bool, bool, bool) {-		return true, true, true++	runWithTestAll, err := pjutil.FilterPresubmits(pjutil.TestAllFilter(), changes, branch, presubmits, logger)+	if err != nil {+		return nil, nil, err+	}++	var triggerFilters []pjutil.Filter+	for _, ps := range presubmits {+		triggerFilters = append(triggerFilters, pjutil.CommandFilter(ps.RerunCommand)) 	}-	toTest, err := pjutil.FilterPresubmits(all, changes, branch, presubmits, logger)+	runWithTrigger, err := pjutil.FilterPresubmits(pjutil.AggregateFilter(triggerFilters), changes, branch, presubmits, logger) 	if err != nil {-		return nil, err+		return nil, nil, err+	}++	var runWithTestAllNames []string+	for _, ps := range runWithTestAll {+		runWithTestAllNames = append(runWithTestAllNames, ps.Name) 	}-	var available []string-	for _, pre := range toTest {-		available = append(available, pre.RerunCommand)+	var runWithTriggerNames []string+	for _, ps := range runWithTrigger {

Thank you for the review. Yes, this currently works by listing each individual presubmit that can be run. The exclusion you are referring to is currently done by commeting "Use /test all to run all jobs." if the two lists are the same, e.g.:

The following commands are available to trigger jobs:

    /test presubmit-1
    /test presubmit-2


Use /test all to run all jobs.

Otherwise, jobs will be listed individually under /test all, e.g.:

The following commands are available to trigger jobs:

    /test presubmit-1
    /test presubmit-2

Use /test all to run the following jobs:

    presubmit-1

Please let me know if this needs changing and I will update the PR.

adshmh

comment created time in 4 days

Pull request review commentkubernetes/test-infra

Comment accordingly if /test all cant run any jobs

 func FilterPresubmits(honorOkToTest bool, gitHubClient GitHubClient, body string 	return pjutil.FilterPresubmits(filter, changes, branch, presubmits, logger) } -func availablePresubmits(githubClient GitHubClient, body, org, repo, branch string, number int, presubmits []config.Presubmit, logger *logrus.Entry) ([]string, error) {+// availablePresubmits returns 2 sets of presubmits:+// 1. presubmits that can be run with '/test all' command.+// 2. presubmits that can be run with their trigger, e.g. '/test job'+func availablePresubmits(githubClient GitHubClient, body, org, repo, branch string, number int, presubmits []config.Presubmit, logger *logrus.Entry) ([]string, []string, error) { 	changes := config.NewGitHubDeferredChangedFilesProvider(githubClient, org, repo, number)-	all := func(p config.Presubmit) (bool, bool, bool) {-		return true, true, true++	runWithTestAll, err := pjutil.FilterPresubmits(pjutil.TestAllFilter(), changes, branch, presubmits, logger)+	if err != nil {+		return nil, nil, err+	}++	var triggerFilters []pjutil.Filter+	for _, ps := range presubmits {

Thank you for the review. I reviewed the code again and it seems FilterPresubmits already excludes those by calling ShouldRun on each presubmit job. I have updated the PR and added a test case to make sure this is covered.

adshmh

comment created time in 4 days

Pull request review commentkubernetes/test-infra

trigger jobs when PR is switched from draft to normal

 func TestHandlePullRequest(t *testing.T) { 			} else if !tc.ShouldComment && len(g.IssueCommentsAdded) > 0 { 				t.Errorf("Expected no comments to github, but got %d", len(g.IssueCommentsAdded)) 			}+			if tc.jobToAbort != nil {+				pj, err := fakeProwJobClient.ProwV1().ProwJobs("namespace").Get(tc.jobToAbort.Name, metav1.GetOptions{})+				if err != nil {+					t.Fatalf("failed to get prowjob: %v", err)+				}++				if pj.Status.State != prowapi.AbortedState {

Thank you for the review. Done.

adshmh

comment created time in 4 days

Pull request review commentkubernetes/test-infra

trigger jobs when PR is switched from draft to normal

 func TestHandlePullRequest(t *testing.T) { 			prAction:    github.PullRequestActionLabeled, 			ShouldBuild: false, 		},+		{+			name: "Abort jobs if PR is closed",

Thank you for the review.

adshmh

comment created time in 4 days

push eventadshmh/test-infra

Ed Bartosh

commit sha 9243cef3ba11435a1edb3905402adaa1b236815e

add metadata to cos beta images COS beta images have /tmp mounted with 'noexec' mount option. This makes it impossible for run_remote to execute binaries from its workspace. This results in failed kubelet tests, e.g. ci-kubernetes-node-kubelet-benchmark and ci-kubernetes-node-kubelet-conformance test suites fail with "failed to run command './ginkgo': Permission denied" error Adding metadata pointing to cloud-init(gci-init.yaml) should solve this as cloud-init remounts /tmp with 'exec' mount option.

view details

Aaron Crickenberger

commit sha 20667d4edca342c85c8953e24daf7a2c0d715449

Move kind release-blocking jobs to k8s-infra-prow-build Greenhouse is up and running over there now Just moving the master jobs for now to confirm everything looks as expected

view details

Aaron Crickenberger

commit sha 1c9077cdc67a840b605be757cbe6cdc36e939e2c

disable node logging by default for kubetest bash provider now that we're running e2e tests in k8s-infra-prow-build we can see the cost of resources, and it turns out k/k's cluster/kube-up.sh logs to stackdriver by default, which costs more then the cluster under test the thing is, most component and node logs end up in a ci job's artifacts directory, and community members haven't ever been able to access logs in stackdriver anyway... so these logs are redundant there may be humans who rely on kube-up.sh's default behavior of always logging, so instead we default to explicitly disabling logging here in kubetest, with an option to enable it if we discover there's some job that really needs this option convention for flag parsing and naming was copied from kops deployer

view details

Kubernetes Prow Robot

commit sha d037efb9e1f934fad55079da4dedb90b75eb342d

Merge pull request #17664 from spiffxp/mv-kind-release-blocking-to-k8s-infra Move kind release-blocking jobs to k8s-infra-prow-build

view details

Kubernetes Prow Robot

commit sha df033881204905399df13107c82cc6ce634769e4

Merge pull request #17656 from bart0sh/PR0002-add-metadata-cos-beta-images add metadata to cos beta images

view details

Kubernetes Prow Robot

commit sha 95b3c725f8611ed26b4d2079ac8d71d3cb99cd94

Merge pull request #17662 from spiffxp/disable-kubeup-node-logging disable node logging by default for kubetest bash provider

view details

Ed Bartosh

commit sha 874f5ec45b51cd3ebf8fdc35467182d3d66b68a0

roll cos-stable-73 -> cos-stable-81 in image-config This should fix ci-kubernetes-node-kubelet Summary API test failure: [91mTimed out after 60.001s. I0520 06:49:56.332] Expected I0520 06:49:56.332] <string>: Summary I0520 06:49:56.332] to match fields: { I0520 06:49:56.332] [.Pods: I0520 06:49:56.332] missing expected element summary-test-1998::stats-busybox-1, .Pods: I0520 06:49:56.333] missing expected element summary-test-1998::stats-busybox-0] I0520 06:49:56.333] }

view details

Kubernetes Prow Robot

commit sha 1c6f1a7980b94f19b0787e04d4a8acc8837361cc

Merge pull request #17666 from bart0sh/PR0003-use-cos-stable-81-12871-103-0-in-image-config roll cos-stable-73 -> cos-stable-81 in image-config

view details

Aaron Crickenberger

commit sha f3275a2cbc4de45378f019db9a9a94ceacbd6f04

Run triage every 2h It looks like the job is now staying under 100m with the last fix so let's get more frequent updates

view details

Kubernetes Prow Robot

commit sha 2905fd2ccc595b43fc8333ff828302ba2d71d21f

Merge pull request #17668 from spiffxp/triage-every-2h Run triage every 2h

view details

Aaron Crickenberger

commit sha 1a215b7f29ff38a5154f93de52e3de6a879e9221

Migrate kind release-branch blocking jobs to k8s-infra-prow-build

view details

Aaron Crickenberger

commit sha 7de3edcf120082d12f8758582232c72935fc55b9

Migrate kind release-blocking ga-only job to k8s-infra-prow-build

view details

Antonio Ojea

commit sha 23c396a5140e7b2329f7df5eacef22be3a0dfb75

enable nfs on IPv6 kind canary job

view details

Kubernetes Prow Robot

commit sha 0952907d173f7bebbf11662f4c3ef5f412bbd756

Merge pull request #17675 from aojea/nfsv6 enable nfs on IPv6 kind canary job

view details

Kubernetes Prow Robot

commit sha e95c8bca2d6c6a085570527ebaf1a6d69f02e8ea

Update prow to v20200520-e1124f454, and other images as necessary.

view details

Kubernetes Prow Robot

commit sha 100609e548a3cca9f007557727ed83dee0992b14

Merge pull request #17639 from k8s-ci-robot/autobump Update prow to v20200519-5f26eecd5, and other images as necessary.

view details

Kubernetes Prow Robot

commit sha 8354d070bc75fa21d678bd9c1985e546bfd12c10

Merge pull request #17673 from spiffxp/mv-kind-release-branch-ci-jobs Migrate kind release-branch blocking jobs to k8s-infra-prow-build

view details

Kubernetes Prow Robot

commit sha 824d40aaa4d0caac3e2ab359ff9739fdf65ec91a

Merge pull request #17674 from spiffxp/mv-kind-ga-only-ci-job Migrate kind release-blocking ga-only job to k8s-infra-prow-build

view details

Arash Deshmeh

commit sha 97de06ec1724c8b0613907220231aa52ce7f3d8b

Trigger jobs when draft PR is changed to normal Trigger plugins now triggers presubmits when a trusted PR is changed from draft to normal. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha 48c529b98261a228c0fa90daa86152e0fc37d2d7

Refactor trigger: remove redundancy on reopened PR Refactored trigger plugin to remove redundancy in the case of reopened PR: using existing identical functionality in "buildAllIfTrusted". Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 4 days

Pull request review commentkubernetes/test-infra

trigger jobs when PR is switched from draft to normal

 func abortAllJobs(c Client, pr *github.PullRequest) error { 		if job.Complete() { 			continue 		}+		job.SetComplete()

Thank you for catching that. Fixed (It seems I was using an old CRD for prowjobs, which required completionTime on Aborted state).

adshmh

comment created time in 4 days

push eventadshmh/test-infra

Ed Bartosh

commit sha 44ffc6959370a2da61aee0d9d65336cce6783344

Update cos-stable images to the latest cos lts versions e2e node tests fail to find cos-stable images with this error: Error 400: Invalid value for field 'resource.disks[0].initializeParams.sourceImage': 'projects/cos-cloud/global/images/cos-stable-73-11647-510-0'. The referenced image resource cannot be found., invalid Currently 73 and 77 cos milestones provide only LTS versions, so replaced cos-stable-[73,77]* -> cos-[73,77]* Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>

view details

Mateusz Szostok

commit sha c3c7503337f58780cad011f851ef094ea11d91e3

Add ServiceCatalog tests against latest k8s version

view details

Cecile Robert-Michon

commit sha 2157890afacb01f3a890668ea9b01696758c9799

Add pull-cluster-api-provider-azure-apidiff

view details

Jeff Grafton

commit sha 9fddb22d22b1990765cf46b346c1ceeaad457634

Configure Prow plugins for kubernetes-sigs/boskos

view details

Kubernetes Prow Robot

commit sha 124b570ad97791abbfb1cb58ee3a56f091417286

Merge pull request #17602 from CecileRobertMichon/capz-apidiff Add pull-cluster-api-provider-azure-apidiff

view details

Aaron Crickenberger

commit sha cda33e764e96537e4e0fd13ef3219f3ccc9cb0af

triage: bail on certain global clusters after 30s triage works by clustering test failures in two stages: - locally: create clusters of test failures for each unique test - globally: merge each test's clusters into a global set of clusters The clustering/merging is done by computing edit distance between the failure text of each test failure or failure cluster and accepting the first pair that has an edit distance of 10% of their combined length. This can add up in the worst case, where edit distance is going to be computed for every existing cluster before creating a new cluster. We've arbitrarily handled it thus far by: - truncating failure text to ~200k~ 10k chars - bailing out on local clustering after 60s per unique test This PR adds: - bailing out on global clustering of pathological / low value clusters after 30s - more logging to see where clustering is working vs. not

view details

Jeff Grafton

commit sha de65e97e5af44bf9b338bd2ad26b4e69946e0d29

Add presubmit and postsubmit jobs for kubernetes-sigs/boskos

view details

Kubernetes Prow Robot

commit sha 1fcf814d0181ffa94f89398ce4de06f71487d982

Merge pull request #17643 from spiffxp/bail-on-triage triage: bail on certain global clusters after 30s

view details

Kubernetes Prow Robot

commit sha ee40e19f967c626a7e7ed574709f58c6774be53a

Merge pull request #17617 from bart0sh/PR0001-update-cos-stable-images Update cos-stable images to the latest versions

view details

Kubernetes Prow Robot

commit sha 8547d0b27801b1d6032721faa3d1e3a4bfe723c6

Merge pull request #17622 from mszostok/test-sc-againt-k8s-matrix Add ServiceCatalog tests against latest k8s version

view details

Chao Dai

commit sha 17b339a4c553b4bb9d467f8da457501e1fbfa1e2

Touch gubernator test image dockerfile to make it rebuild

view details

Ernest Wong

commit sha 8a2276cd5a85be19c7be22c1fcde0d03221b65ed

CAPZ: add storage-related periodic jobs

view details

Ernest Wong

commit sha b7eaad04a43cef6ac52175ea01ebfdc0f4fd4896

Address PR comment

view details

Ed Bartosh

commit sha 9243cef3ba11435a1edb3905402adaa1b236815e

add metadata to cos beta images COS beta images have /tmp mounted with 'noexec' mount option. This makes it impossible for run_remote to execute binaries from its workspace. This results in failed kubelet tests, e.g. ci-kubernetes-node-kubelet-benchmark and ci-kubernetes-node-kubelet-conformance test suites fail with "failed to run command './ginkgo': Permission denied" error Adding metadata pointing to cloud-init(gci-init.yaml) should solve this as cloud-init remounts /tmp with 'exec' mount option.

view details

Kubernetes Prow Robot

commit sha 098b536b1bf33445daa756c1c828d0bb716acd2b

Merge pull request #17654 from chaodaiG/kick_gubernator_image Touch gubernator test image dockerfile to make it rebuild

view details

Chao Dai

commit sha 4401a170c129e2bb57e178d194325c53878e0352

Update image for gubernator presubmit test

view details

Kubernetes Prow Robot

commit sha b388514e5cd54336b5e6eed7d8dd3942b3b11691

Merge pull request #17657 from chaodaiG/fix_gub Update image for gubernator presubmit test

view details

Chi Zhang

commit sha b806c0496c9ad5448679be3e877ecb7041ee8b73

do not warning on ghproxy for mkpj

view details

Kubernetes Prow Robot

commit sha e1124f45498dc889d97261baf05eb6666853523d

Merge pull request #17646 from chizhg/mkpj-no-github-warning Do not warning on ghproxy for mkpj

view details

Ernest Wong

commit sha 30ecd5754e682d9bcf6afe1b26e544d75c40d122

Remove USE_CI_ARTIFACTS env var

view details

push time in 4 days

pull request commentkubernetes/test-infra

trigger jobs when PR is switched from draft to normal

/cc cjwagner

adshmh

comment created time in 5 days

PR opened kubernetes/test-infra

trigger jobs when PR is switched from draft to normal

Trigger jobs when a draft PR is changed to normal. Closes #17627.

+75 -17

0 comment

2 changed files

pr created time in 5 days

PR opened kubernetes/test-infra

Comment accordingly if /test all cant run any jobs

If no jobs can be run with /test all command, the trigger plugin responds accordingly in the help comment. Closes #17580

+157 -30

0 comment

2 changed files

pr created time in 6 days

push eventadshmh/pipeline

Dalton Hubble

commit sha f843899a11d5d09b29fac750f72f4a7e4882f615

Change TimeoutHandler to respect namespace scoping * Pass `--namespace` value to taskrun and pipelinerun NewController to facilitate namespace-scoped behaviors * Change TimeoutHandler `CheckTimeouts` to timeout taskrun/pipelinerun's in the scoped namespace or all namespaces (default if unset) Related: https://github.com/tektoncd/pipeline/issues/2603

view details

Dalton Hubble

commit sha 5c047b19d83958662fd14d408aa6b7affed878f5

Update TestTimeoutHandler from v1alpha1 to v1beta1

view details

Arash Deshmeh

commit sha 24cb71c4e0cdc53303091593c72cb8d434fd111d

Add feature flags to config store Feature flags configuration is now tracked by the config store. This allows watching for the corresponding config map changes, removing the need to call kubernetes API to get the feature flags config map every time a pod is created. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha dd6ff213cfb3b76a65d9d5eb8773c24edf456624

Use configmap watcher for feature flags config Taskrun reconciler now uses a configmap watcher for `feature-flags` configmap to remove the need for an extra Kubernetes API call to get the configmap's value every time a pod is being created. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 7 days

push eventadshmh/pipeline

Arash Deshmeh

commit sha 19e2cf05b6b3f020fbb4b6e6d3c3da7992df3a12

Use configmap watcher for feature flags config Taskrun reconciler now uses a configmap watcher for `feature-flags` configmap to remove the need for an extra Kubernetes API call to get the configmap's value every time a pod is being created. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 8 days

PR opened tektoncd/pipeline

Introduce config map watcher for feature flags

Changes

Taskrun reconciler now uses a configmap watcher for feature-flags configmap to remove the need for an extra Kubernetes API call to get the configmap's value every time a pod is being created. Fixes #2117.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

+623 -121

0 comment

14 changed files

pr created time in 8 days

create barnchadshmh/pipeline

branch : 2117-config-map-watcher-for-feature-flags

created branch time in 8 days

pull request commentkubernetes/test-infra

Add DecorateAllJobs option to job config

/hold

Want to add something to https://github.com/kubernetes/test-infra/blob/master/prow/ANNOUNCEMENTS.md#new-features noting that people can control whether jobs decorate by default with the decorate_all_jobs setting?

Thank you for the reminder. Done.

adshmh

comment created time in 12 days

issue commentkubernetes/test-infra

Bot feedback on `/test all` confusing when `/test all` does not trigger any jobs

I will take a look and submit a PR to fix it.

petr-muller

comment created time in 12 days

push eventadshmh/test-infra

Antoni Zawodny

commit sha 4e58c74bdefd808e3cd4302794c06aa171cd5b20

Bump up timeout value for ci-build-and-push-k8s-at-golang-tip

view details

Janek Łukaszewicz

commit sha fb16c005f3731bca7ceb4a7ad212a966cf49fe86

Use ALLOWED_SLOW_API_CALLS experiment in some jobs. This follows step 2 of https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/docs/experiments.md

view details

Arash Deshmeh

commit sha 5d162bceccffaaa87f1759345baf840d119db37b

Gerrit controller respects Report on prowjobs Gerrit controller now respects the `Report` field on prowjobs by not adding comments to Gerrit regarding jobs that have this field set to false. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha a3212b13e35069ef7f6e7af3bd7236f0f2e9fb80

Use table driven unit tests in Gerrit controller Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha b3b0bf5355c5321c690e9d831579e58a5bee76e0

Validate Gerrit label on jobs which skip reporting It is now a config error to configure gerrit report label to a non-empty string for jobs which skip reporting, i.e. have `skip_report` field set. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Davanum Srinivas

commit sha 868d7f0db061964bc26c74e946296cd0789ffeb0

Add dockerless verify script to pull-kubernetes-typecheck Signed-off-by: Davanum Srinivas <davanum@gmail.com>

view details

Kubernetes Prow Robot

commit sha 8ac9dbfab055bd86d86d05551683c86d1b6b620d

Merge pull request #17529 from tosi3k/bump-up-timeout Bump up timeout value for ci-build-and-push-k8s-at-golang-tip

view details

Kubernetes Prow Robot

commit sha e3448f235c492b863acc72e22f92d6e658c4c3e0

Merge pull request #17514 from oxddr/exp-allow-slow-api-calls Use CL2_ALLOWED_SLOW_API_CALLS experiment in some CI jobs

view details

Janek Łukaszewicz

commit sha 83666adf14d68b9b3999d9747ac85f8247fef103

Set CL2_ENABLE_DNS_PROGRAMMING in some scalability CI jobs.

view details

Kubernetes Prow Robot

commit sha d230e9d49f7367a203d4cf767281b69fec2dbbf9

Merge pull request #17557 from oxddr/exp-enable-dns-prog-lat Set CL2_ENABLE_DNS_PROGRAMMING in some scalability CI jobs.

view details

Arash Deshmeh

commit sha d2da6d49e874ddcf9bce88085e4f3701adf35954

ListTeamRepos ignore repos with invalid permission GitHub client's ListTeamRepos now ignores any repos with an invalid permission level, i.e. 'none', for the team. This allows Peribolos to avoid listing repos with permissions it cannot parse, e.g. 'Maintain' and 'Triage' that are not currently exposed by the GitHub API V3. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Kubernetes Prow Robot

commit sha adbd0fb62aa96c4e313ba4fce67e7df45c846812

Merge pull request #17569 from adshmh/14325-Peribolos-skip-teams-repos-with-invalid-permissions ListTeamRepos ignore repos with invalid permission

view details

Kubernetes Prow Robot

commit sha a3310cc378d1a8ee443338af4fbe9e2f2f1c4b89

Update prow to v20200508-256505fcf, and other images as necessary.

view details

Kubernetes Prow Robot

commit sha cdd819cd6196ca753210545b24a75663bbfd99e7

Merge pull request #17561 from k8s-ci-robot/autobump Update prow to v20200508-256505fcf, and other images as necessary.

view details

Jing Xu

commit sha e138ab63a4daabdd8b8334c50c26cd059522fa8b

add configuration file for testing windows csi job This is a configuration file for testing windows csi job. Currently it is a poc and test a personal repo

view details

Kubernetes Prow Robot

commit sha 084ff4b12de879b322d6f9aa682afc68df7bab86

Merge pull request #17570 from jingxu97/May/csi add configuration file for testing windows csi job

view details

Jing Xu

commit sha fbb93fa7ac345e64c384d1ad57a58d87430e3981

Modify configuration for csi windows testing job Change the repo to upstream

view details

Kubernetes Prow Robot

commit sha 74d0887a79f797b31b17ed51651b7960dab58890

Merge pull request #17572 from jingxu97/May/csi Modify configuration for csi windows testing job

view details

Kubernetes Prow Robot

commit sha 7ab5bdec015fd06031bb89d51df076dd98499f74

Merge pull request #17566 from dims/docker-less-verify-script-to-pull-kubernetes-typecheck Add dockerless verify script to pull-kubernetes-typecheck

view details

istio-testing

commit sha e99b0b0989c9f244fabcc4b834bc7194ff1e5fa6

Update TestGrid for istio

view details

push time in 12 days

Pull request review commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

 func (c *Controller) takeAction(sp subpool, batchPending, successes, pendings, m 	return Wait, nil, nil } -// changedFilesAgent queries and caches the names of files changed by PRs.-// Cache entries expire if they are not used during a sync loop.-type changedFilesAgent struct {-	ghc         githubClient-	changeCache map[changeCacheKey][]string-	// nextChangeCache caches file change info that is relevant this sync for use next sync.-	// This becomes the new changeCache when prune() is called at the end of each sync.-	nextChangeCache map[changeCacheKey][]string-	sync.RWMutex+type gitRepo interface {+	DiffThreeDot(string, string) ([]string, error)+	Config(string, string) error+	Checkout(string) error+	Merge(string) (bool, error)+	Clean() error } -type changeCacheKey struct {+type repoCacheKey struct { 	org, repo string-	number    int-	sha       string } -// prChanges gets the files changed by the PR, either from the cache or by-// querying GitHub.-func (c *changedFilesAgent) prChanges(pr *PullRequest) config.ChangedFilesProvider {-	return func() ([]string, error) {-		cacheKey := changeCacheKey{-			org:    string(pr.Repository.Owner.Login),-			repo:   string(pr.Repository.Name),-			number: int(pr.Number),-			sha:    string(pr.HeadRefOID),-		}--		c.RLock()-		changedFiles, ok := c.changeCache[cacheKey]-		if ok {-			c.RUnlock()-			c.Lock()-			c.nextChangeCache[cacheKey] = changedFiles-			c.Unlock()-			return changedFiles, nil-		}-		if changedFiles, ok = c.nextChangeCache[cacheKey]; ok {-			c.RUnlock()-			return changedFiles, nil-		}-		c.RUnlock()--		// We need to query the changes from GitHub.-		changes, err := c.ghc.GetPullRequestChanges(-			string(pr.Repository.Owner.Login),-			string(pr.Repository.Name),-			int(pr.Number),+type repoCache interface {+	getRepo(string, string) (gitRepo, error)+	// getRepoCopy provides a copy of the repo, which can be used by clients that+	// may perform destrcutive operations on the repo, e.g. Clean.+	getRepoCopy(string, string) (gitRepo, error)+	// prune deletes the repo cache, forcing the fetch of any updates from+	// remote repositories.+	prune()+}++// repoCacher serves a cache of cloned git repos. This is needed to:+// 1. Avoid calling ClientFor which does a git fetch for updating the repo. With+//    repoCacher, this update is done only once per sync iteration for each repo.+// 2. Provide a "throw-away" copy of a cloned repo, which is needed by tide as+//    it has to delete a repo if it cannot be restored following a failed merge+//    test.+type repoCacher struct {+	cf git.ClientFactory++	// repoCache caches cloned repos during this sync.+	// This cache is destroyed when prune is called at the end of each sync.+	repoCache map[repoCacheKey]gitRepo+	sync.RWMutex+	copyGitClient git.ClientFactory+}++func (c *repoCacher) getCopyClient() (git.ClientFactory, error) {+	if c.copyGitClient == nil {

Thank you for the review. This is needed because Tide method pickBatch destroys the repo:

https://github.com/kubernetes/test-infra/blob/cdd819cd6196ca753210545b24a75663bbfd99e7/prow/tide/tide.go#L965-L969

The copyGitClient uses the "main" client factory's cache directory as its source, so it can provide any number of "throw-away" copies of the repo.

adshmh

comment created time in 14 days

issue commentkubernetes/test-infra

Peribolos does not support new Github team repo permissions

/remove-lifecycle stale

coverprice

comment created time in 14 days

pull request commentkubernetes/test-infra

ListTeamRepos ignore repos with invalid permission

This was already reviewed once in #14677, but it got closed as I missed a review comment. I could not reopen it. /cc @cblecker All previous review comments have been addressed.

adshmh

comment created time in 14 days

PR opened kubernetes/test-infra

ListTeamRepos ignore repos with invalid permission

GitHub client's ListTeamRepos now ignores any repos with an invalid permission level, i.e. 'none', for the team. This allows Peribolos to avoid listing repos with permissions it cannot parse, e.g. 'Maintain' and 'Triage' that are not currently exposed by the GitHub API V3. Fixes #14325

+32 -1

0 comment

2 changed files

pr created time in 14 days

Pull request review commentkubernetes/test-infra

Peribolos skip team repo if permissions invalid

 func (c *client) ListTeamRepos(id int) ([]Repo, error) { 			return &[]Repo{} 		}, 		func(obj interface{}) {-			repos = append(repos, *(obj.(*[]Repo))...)+			for _, repo := range *obj.(*[]Repo) {

Thank you for the review, and sorry I missed this bit that was pending me. I could not reopen the PR, so I will create a new one.

adshmh

comment created time in 14 days

pull request commentkubernetes/test-infra

Peribolos skip team repo if permissions invalid

/reopen

adshmh

comment created time in 14 days

push eventadshmh/test-infra

Travis Clarke

commit sha b51124120fc7b3fa8a71f08dddfc48df9f67c9ae

Cherrypicker: option to add labels to created PRs

view details

Sen Lu

commit sha cce4af124b0063551702f7b64550d06d059ab4be

don't error out if retry passes on gerrit review

view details

Kubernetes Prow Robot

commit sha 30fdac3c3a68b9f49f6e0e35edd28704d007eaa2

Merge pull request #17029 from krzyzacy/no-more-409 Don't error out if retry passes on gerrit review

view details

Kubernetes Prow Robot

commit sha 28188a571fed06605e30a16eede475f7e5b0a559

Merge pull request #17026 from listx/bump-promoter bump promoter

view details

Kubernetes Prow Robot

commit sha 3f549bab2e10c817260ce3a823f9754dd09d085f

Merge pull request #16959 from marosset/remove-gcr-windows-1909-release-informing Removing gce-windows-2019-1.18 job from 1.18 release informing dashboard

view details

Kubernetes Prow Robot

commit sha df1fa793784c1096f3fe211576ec1df80020a4bd

Merge pull request #16100 from zhanw15/master update URL to correct one

view details

Sen Lu

commit sha 304ed83a19a1ddea0e071436f41a11e8f55c8c10

add a test case on bad review label

view details

Kubernetes Prow Robot

commit sha ab008788a9f614a4ff702d07c13992d5a53a8692

Merge pull request #17013 from justaugustus/k-r-blockades releng: Loosen blockade regex on kubernetes/release repo

view details

Jakub Przychodzeń

commit sha 91802f07459facb1b3d81a565ffda8d89a43ca22

Enable Chaos Monkey for ClusterLoader2 presubmit

view details

Maxime Guyot

commit sha 48dfbdef36aa3f86261743e0d93d5d995c58d4e4

Add decorate to pull-kubespray-yamllint job

view details

Kubernetes Prow Robot

commit sha ccdcc25ea473b9af8bd4ef8cd28bd3c6b138ae06

Merge pull request #16813 from alexeldeib/ace/reAks kubetest: re-merge aks deployer

view details

Kubernetes Prow Robot

commit sha bf7dc93463585c886f6f32230d547a691016de6f

Merge pull request #17031 from jprzychodzen/cl2-presubmit Enable Chaos Monkey for ClusterLoader2 presubmit

view details

Yang Lu

commit sha 196c21b05b12ea6417122588b5ffa19f4c6859b2

Fix the iis load test job definition

view details

Kubernetes Prow Robot

commit sha 6fcea704cb94ab3c25dc58ab6d79d02ffd704f0d

Merge pull request #16935 from sbueringer/pr-add-capi-conformance-to-test-grid Add CAPO conformance tests to CAPO testgrid

view details

Ernest Wong

commit sha ca74c8a937d067a4f4a6e5cf1f3cc33b274abfb1

Azure: Install Azure CLI

view details

Kubernetes Prow Robot

commit sha 038e0a9bd1223139d63a95f8d5434f19b775f729

Merge pull request #17035 from YangLu1031/master Fix the iis load test job definition

view details

Ernest Wong

commit sha d34c91dc4992361846eff0c235804eea58eea8f1

Azure: skip [Slow] test cases in ci-kubernetes-e2e-aks-engine-azure-master-windows-containerd

view details

Kubernetes Prow Robot

commit sha 731ceaf01fc4da4054016ebc90f8f141f4cd8588

Merge pull request #17036 from chewong/fix-windows-regex Azure: skip [Slow] test cases

view details

Ernest Wong

commit sha c9861f237ad705641f11edec808db5a37014d9d8

Modify aks-engine API model for autoscaling job

view details

Kubernetes Prow Robot

commit sha 2b0141de08ee151ad79c7b416b42eabeb1a44076

Merge pull request #16995 from fejta/baz Use bazel 2.2.0

view details

push time in 14 days

fork adshmh/triggers

Event triggering with Tekton!

fork in 15 days

pull request commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

@adshmh Would you mind rebasing your PR? There are some merge conflicts.

Thanks for the reminder. Done.

adshmh

comment created time in 15 days

push eventadshmh/test-infra

Travis Clarke

commit sha b51124120fc7b3fa8a71f08dddfc48df9f67c9ae

Cherrypicker: option to add labels to created PRs

view details

Sen Lu

commit sha cce4af124b0063551702f7b64550d06d059ab4be

don't error out if retry passes on gerrit review

view details

Kubernetes Prow Robot

commit sha 30fdac3c3a68b9f49f6e0e35edd28704d007eaa2

Merge pull request #17029 from krzyzacy/no-more-409 Don't error out if retry passes on gerrit review

view details

Kubernetes Prow Robot

commit sha 28188a571fed06605e30a16eede475f7e5b0a559

Merge pull request #17026 from listx/bump-promoter bump promoter

view details

Kubernetes Prow Robot

commit sha 3f549bab2e10c817260ce3a823f9754dd09d085f

Merge pull request #16959 from marosset/remove-gcr-windows-1909-release-informing Removing gce-windows-2019-1.18 job from 1.18 release informing dashboard

view details

Kubernetes Prow Robot

commit sha df1fa793784c1096f3fe211576ec1df80020a4bd

Merge pull request #16100 from zhanw15/master update URL to correct one

view details

Sen Lu

commit sha 304ed83a19a1ddea0e071436f41a11e8f55c8c10

add a test case on bad review label

view details

Kubernetes Prow Robot

commit sha ab008788a9f614a4ff702d07c13992d5a53a8692

Merge pull request #17013 from justaugustus/k-r-blockades releng: Loosen blockade regex on kubernetes/release repo

view details

Jakub Przychodzeń

commit sha 91802f07459facb1b3d81a565ffda8d89a43ca22

Enable Chaos Monkey for ClusterLoader2 presubmit

view details

Maxime Guyot

commit sha 48dfbdef36aa3f86261743e0d93d5d995c58d4e4

Add decorate to pull-kubespray-yamllint job

view details

Kubernetes Prow Robot

commit sha ccdcc25ea473b9af8bd4ef8cd28bd3c6b138ae06

Merge pull request #16813 from alexeldeib/ace/reAks kubetest: re-merge aks deployer

view details

Kubernetes Prow Robot

commit sha bf7dc93463585c886f6f32230d547a691016de6f

Merge pull request #17031 from jprzychodzen/cl2-presubmit Enable Chaos Monkey for ClusterLoader2 presubmit

view details

Yang Lu

commit sha 196c21b05b12ea6417122588b5ffa19f4c6859b2

Fix the iis load test job definition

view details

Kubernetes Prow Robot

commit sha 6fcea704cb94ab3c25dc58ab6d79d02ffd704f0d

Merge pull request #16935 from sbueringer/pr-add-capi-conformance-to-test-grid Add CAPO conformance tests to CAPO testgrid

view details

Ernest Wong

commit sha ca74c8a937d067a4f4a6e5cf1f3cc33b274abfb1

Azure: Install Azure CLI

view details

Kubernetes Prow Robot

commit sha 038e0a9bd1223139d63a95f8d5434f19b775f729

Merge pull request #17035 from YangLu1031/master Fix the iis load test job definition

view details

Ernest Wong

commit sha d34c91dc4992361846eff0c235804eea58eea8f1

Azure: skip [Slow] test cases in ci-kubernetes-e2e-aks-engine-azure-master-windows-containerd

view details

Kubernetes Prow Robot

commit sha 731ceaf01fc4da4054016ebc90f8f141f4cd8588

Merge pull request #17036 from chewong/fix-windows-regex Azure: skip [Slow] test cases

view details

Ernest Wong

commit sha c9861f237ad705641f11edec808db5a37014d9d8

Modify aks-engine API model for autoscaling job

view details

Kubernetes Prow Robot

commit sha 2b0141de08ee151ad79c7b416b42eabeb1a44076

Merge pull request #16995 from fejta/baz Use bazel 2.2.0

view details

push time in 15 days

Pull request review commentkubernetes/test-infra

Add DecorateAllJobs option to job config

 func NewGitHubDeferredChangedFilesProvider(client githubClient, org, repo string type UtilityConfig struct { 	// Decorate determines if we decorate the PodSpec or not 	Decorate bool `json:"decorate,omitempty"`+	// Undecorated determines if the job should not be decorated. Overrides+	// other decorate options.+	Undecorated bool `json:"undecorated,omitempty"`

Thank you for the review. Fixed.

adshmh

comment created time in 16 days

push eventadshmh/test-infra

Arash Deshmeh

commit sha 5d3daa56b1c8dca420978c67247cd7ab90ecbfba

Add DecorateAllJobs option to job config Add a configuration option to allow all jobs to be decorated by-default. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 16 days

push eventadshmh/test-infra

Jeffrey Sica

commit sha 24b10332721c32f4a01b7fd496a1b0d6ffbb946f

add prod GCP dashboards

view details

Matthias Bertschy

commit sha b1d2f6639fbb8f22fafb4d80fc687fb47ff74fd3

Allow kettle build to use sandbox

view details

Sean Chase

commit sha 63ca15c2330b6ada9555f6118985301b6089a1f2

Add 'Configurator' to Prow Images

view details

Ernest Wong

commit sha 04169ae45805428e2bfb66fe70cdbc62d54bf2dc

Azure: enforce strict JSON when parsing API model

view details

Cole Wagner

commit sha e7dc89e7218acb9e6b171a07f34fede35f4c339f

Make individual Tide pool alert expose pool labels.

view details

Sascha Grunert

commit sha 7125ecf283ca00968e7a15cab2f00e34d5e30305

Add non dry run flag to horologium Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Maxime Guyot

commit sha c6e20538692839fa35fde1e1df893e33d6ab1b71

Add Miouge1 as an approver for config/jobs/kubernetes-sigs/kubespray

view details

Stephen Augustus

commit sha 1c8f972a75f653ae64cefa59aec393137f99c155

releng: Split out building for debian-{base,iptables} and pause images Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Alvaro Aleman

commit sha f5dda9a977e8e270f6a54b8eedfe2ba4680fbd84

Validate pre- and postsubmits have no overlapping context

view details

Alvaro Aleman

commit sha 2dfa64db26b5af1c29a6b1e443579e021216c9cb

Add unittests for pre- and postsubmit validation

view details

Alvaro Aleman

commit sha 74deae5dd38a9640e0f5df94b12f2cb36af8da6d

Check reporting on both pre- and postsubmits

view details

Alvaro Aleman

commit sha 4558332de37bcf511ff8962f3555af1c9800f34f

Add tests to allow overlapping context on different branches

view details

Alex Pavel

commit sha e41dc79cb73ab1efd1fda7ce58f90a6d066e20c5

Revert "Merge pull request #17466 from AlexNPavel/revert-cherrypick-bz" This reverts commit fdbbc1f61a254b30ae6254a2d2d4c6b5024121f3, reversing changes made to be2a8a9bc9fc4c35261c663ea17ea987a05e7374.

view details

Andrew Sy Kim

commit sha aa667f7a4419f3451110515363c2175e9e792b5e

allow running IPVS presubmits on any branch Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>

view details

Kubernetes Prow Robot

commit sha cbd7dedb5d2813e5c108d83911a74cb4660987fd

Merge pull request #17480 from andrewsykim/ipvs-presubmit allow running IPVS presubmits on any branch

view details

Ernest Wong

commit sha d49aca922ed4d723cb8fc11086f55197d9acb643

Azure: add ENABLE_TOPOLOGY env var to various jobs

view details

Kubernetes Prow Robot

commit sha 2d585cde18c28fe624ba35b0f05fdf5881da4c4c

Merge pull request #17476 from justaugustus/k8s-base-images releng: Split out building for debian-{base,iptables} and pause images

view details

Kubernetes Prow Robot

commit sha e3ae9873e811c36fee5bcb4f5d6597186b73f613

Merge pull request #17478 from alvaroaleman/validate-duplicate-contexts Job validation: Check for duplicate contexts

view details

Cory Cross

commit sha 25ab68b2a0b83b3cb315cae7831007a6ba5c6a29

Clarify tiny bit of documentation for Prow

view details

Kubernetes Prow Robot

commit sha 950b8e4133513521e606cf18dab08f63113aafb0

Update prow to v20200501-e3ae9873e, and other images as necessary.

view details

push time in 16 days

Pull request review commentkubernetes/test-infra

Make Gerrit reporter respect report field on prow jobs

 func TestProcessChange(t *testing.T) { 				t.Errorf("tc %s - BaseSHA should be abc, got %s", tc.name, prowjobs[0].Spec.Refs.BaseSHA) 			} 		}+		if tc.shouldSkipReport {+			if gc.reviews > 0 {+				t.Errorf("tc %s - expected no comments, got: %d", tc.name, gc.reviews)

Thank you for the reviews. Fixed.

adshmh

comment created time in 16 days

Pull request review commentkubernetes/test-infra

Make Gerrit reporter respect report field on prow jobs

 func TestProcessChange(t *testing.T) { 			}, 		} -		testInstance := "https://gerrit" 		fakeProwJobClient := prowfake.NewSimpleClientset() 		fakeLastSync := client.LastSyncState{testInstance: map[string]time.Time{}}  		for _, tc := range testcases { 			fakeLastSync[testInstance][tc.change.Project] = timeNow.Add(-time.Minute) 		} +		gc := &fgc{}

Thank you for the review. Fixed.

adshmh

comment created time in 16 days

Pull request review commentkubernetes/test-infra

Make Gerrit reporter respect report field on prow jobs

 func (c *Controller) ProcessChange(instance string, change client.ChangeInfo) er 		return fmt.Errorf("failed to get SHA from base branch: %v", err) 	} -	triggeredJobs := []string{}+	type triggeredJob struct {+		name   string+		report bool+	}+	triggeredJobs := []triggeredJob{}

Thank you for the review. Fixed.

adshmh

comment created time in 16 days

Pull request review commentkubernetes/test-infra

Make Gerrit reporter respect report field on prow jobs

 func validateTriggering(job Presubmit) error { 	return nil } -func validateReporting(r Reporter) error {+func validateReporting(j JobBase, r Reporter) error { 	if !r.SkipReport && r.Context == "" { 		return errors.New("job is set to report but has no context configured") 	}+	if !r.SkipReport {

Thank you for the reviews. I have updated the PR to allow skip_report only if the Gerrit report label is set to empty or is omitted. I think the ignoring of skip_report was caused by the following:

https://github.com/kubernetes/test-infra/blob/b5246a13a917f003450af87d15a94ff2dbc711f1/prow/gerrit/adapter/adapter.go#L307-L309

Crier will not run any reporters for a job which has skip_report set: https://github.com/kubernetes/test-infra/blob/b5246a13a917f003450af87d15a94ff2dbc711f1/prow/crier/controller.go#L254-L258

adshmh

comment created time in 16 days

push eventadshmh/test-infra

Jeffrey Sica

commit sha 24b10332721c32f4a01b7fd496a1b0d6ffbb946f

add prod GCP dashboards

view details

Matthias Bertschy

commit sha b1d2f6639fbb8f22fafb4d80fc687fb47ff74fd3

Allow kettle build to use sandbox

view details

Sean Chase

commit sha 63ca15c2330b6ada9555f6118985301b6089a1f2

Add 'Configurator' to Prow Images

view details

Ernest Wong

commit sha 04169ae45805428e2bfb66fe70cdbc62d54bf2dc

Azure: enforce strict JSON when parsing API model

view details

Cole Wagner

commit sha e7dc89e7218acb9e6b171a07f34fede35f4c339f

Make individual Tide pool alert expose pool labels.

view details

Sascha Grunert

commit sha 7125ecf283ca00968e7a15cab2f00e34d5e30305

Add non dry run flag to horologium Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Maxime Guyot

commit sha c6e20538692839fa35fde1e1df893e33d6ab1b71

Add Miouge1 as an approver for config/jobs/kubernetes-sigs/kubespray

view details

Alex Pavel

commit sha e41dc79cb73ab1efd1fda7ce58f90a6d066e20c5

Revert "Merge pull request #17466 from AlexNPavel/revert-cherrypick-bz" This reverts commit fdbbc1f61a254b30ae6254a2d2d4c6b5024121f3, reversing changes made to be2a8a9bc9fc4c35261c663ea17ea987a05e7374.

view details

Cory Cross

commit sha 25ab68b2a0b83b3cb315cae7831007a6ba5c6a29

Clarify tiny bit of documentation for Prow

view details

Alex Pavel

commit sha 519688c6bf4b95392faef030f22c99a769e3be48

bugzilla: Fix bugs

view details

Justin Santa Barbara

commit sha 96f7e871f075e61f4bce656519c59754dc2c0d81

Get external IPs from more sources v4.ifconfig.co seems to be down, so add another source into the mix (running on cloudflare workers)

view details

Carlos Panato

commit sha a720a233232361e446c560400e7bbb9762bee218

cluster-api-provider-do: enable prow plugins and milestone applier

view details

Stephen Augustus

commit sha ea941e7861c9a9df1e675936cb41554cbad58aff

releng: Fix args for debian-{base,iptables} and pause image builds Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Kubernetes Prow Robot

commit sha 852170f682340a1711341bd01f46d14bd527570c

Merge pull request #17495 from cpanato/enable-plugins-cluster-api-do cluster-api-provider-do: enable prow plugins and milestone applier

view details

Ciprian Hacman

commit sha 40f8c30aeae6f42207960accf3c7a56b401ecc6b

Skip affinity tests because they fail for some CNI plugins

view details

Kubernetes Prow Robot

commit sha 768e7b3d2fb112c94f59fe953734cef78f40ec24

Merge pull request #17500 from hakman/grid-skip-affinity Kops - Skip affinity tests because they fail for some CNI plugins

view details

Mateusz Matejczyk

commit sha c0f581a4e90249e267c8c0cd81e08b31d9473a47

Re-run golang tip full scale test

view details

Kubernetes Prow Robot

commit sha 150e7bce09580cbf41d189ada3fa6877c8f903a0

Merge pull request #17501 from mm4tt/golang_full_2 Re-run golang tip full scale test

view details

Kubernetes Prow Robot

commit sha 73498cc10555a6629e081bacc5429e11872b9c27

Merge pull request #17267 from jeefy/SDCICD-268 SDCICD-268: Add prod GCP dashboards

view details

Mateusz Matejczyk

commit sha ff42863688a07ede76dfd85a1a1c5032290e0e10

Bump throughput for golang ci tests from 40 to 50 Bump controllers' qps settings to make it possible (and to give headroom for future speed ups)

view details

push time in 16 days

pull request commenttektoncd/pipeline

Include conditions TaskRuns in PipelineRun status

/cc @danielhelfand

adshmh

comment created time in 17 days

PR opened tektoncd/pipeline

Include conditions TaskRuns in PipelineRun status

<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->

Changes

<!-- Describe your changes here- ideally you can get that description straight from your descriptive commit message(s)! --> The pipelinerun status now includes taskruns that are created for conditions. Closes #2438

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The PipelineRun status now includes TaskRuns created for conditions.
+96 -21

0 comment

2 changed files

pr created time in 17 days

fork adshmh/serving

Kubernetes-based, scale-to-zero, request-driven compute

https://knative.dev/docs/serving/

fork in 20 days

Pull request review commentkubernetes/test-infra

Reply to pr for failed postsubmit jobs

 func createRefs(pe github.PushEvent) prowapi.Refs { 	} } +func getPullRequests(c githubClient, pe github.PushEvent) ([]github.PullRequest, error) {+	org := pe.Repo.Owner.Login+	repo := pe.Repo.Name+	for _, commit := range pe.Commits {+		if commit.ID == "" {+			continue+		}+		pulls, err := c.ListCommitPullRequests(org, repo, commit.ID)+		if err != nil {+			return nil, err+		}+		if len(pulls) > 0 {+			return pulls, nil+		}+	}+	return nil, nil+}+ func handlePE(c Client, pe github.PushEvent) error { 	if pe.Deleted || pe.After == "0000000000000000000000000000000000000000" { 		// we should not trigger jobs for a branch deletion 		return nil 	}+	// TODO: it seems there is a bug in GH API, which returns an empty list of+	// PRs for all commits listed by the push event. Waiting for 1 second seems+	// to successfully work around this.+	time.Sleep(1 * time.Second)

I have logged a bug with GitHub support team. Based on their feedback, they confirm this can happen but have not promised a fix. They agree the workaround I have used could work, but cannot guarantee that. The GH support ticket is titled "bug in endpoint for listing commit PRs", if further follow up on it is needed.

adshmh

comment created time in 21 days

push eventadshmh/test-infra

Stephen Augustus

commit sha 1c8f972a75f653ae64cefa59aec393137f99c155

releng: Split out building for debian-{base,iptables} and pause images Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Alvaro Aleman

commit sha f5dda9a977e8e270f6a54b8eedfe2ba4680fbd84

Validate pre- and postsubmits have no overlapping context

view details

Alvaro Aleman

commit sha 2dfa64db26b5af1c29a6b1e443579e021216c9cb

Add unittests for pre- and postsubmit validation

view details

Alvaro Aleman

commit sha 74deae5dd38a9640e0f5df94b12f2cb36af8da6d

Check reporting on both pre- and postsubmits

view details

Alvaro Aleman

commit sha 4558332de37bcf511ff8962f3555af1c9800f34f

Add tests to allow overlapping context on different branches

view details

Andrew Sy Kim

commit sha aa667f7a4419f3451110515363c2175e9e792b5e

allow running IPVS presubmits on any branch Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>

view details

Kubernetes Prow Robot

commit sha cbd7dedb5d2813e5c108d83911a74cb4660987fd

Merge pull request #17480 from andrewsykim/ipvs-presubmit allow running IPVS presubmits on any branch

view details

Ernest Wong

commit sha d49aca922ed4d723cb8fc11086f55197d9acb643

Azure: add ENABLE_TOPOLOGY env var to various jobs

view details

Kubernetes Prow Robot

commit sha 2d585cde18c28fe624ba35b0f05fdf5881da4c4c

Merge pull request #17476 from justaugustus/k8s-base-images releng: Split out building for debian-{base,iptables} and pause images

view details

Kubernetes Prow Robot

commit sha e3ae9873e811c36fee5bcb4f5d6597186b73f613

Merge pull request #17478 from alvaroaleman/validate-duplicate-contexts Job validation: Check for duplicate contexts

view details

Kubernetes Prow Robot

commit sha 950b8e4133513521e606cf18dab08f63113aafb0

Update prow to v20200501-e3ae9873e, and other images as necessary.

view details

Kubernetes Prow Robot

commit sha e6124e6338ba03a1dc1189fe0a73ce8327ea9860

Merge pull request #17472 from k8s-ci-robot/autobump Update prow to v20200501-e3ae9873e, and other images as necessary.

view details

Stephen Augustus

commit sha 5bc0475f9fd80239a52f431221508a914b450090

releng: Build pause image in k8s-staging-kubernetes Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Aaron Crickenberger

commit sha 8c4a934f10394965b282d40d55443e2973ee00e2

Migrate an e2e job to k8s-infra-prow-build I chose an e2e job that is relatively close to the default e2e job but is not release-blocking Also this job should _not_ have ever been setting latest-green.txt, that was probably copy-pasta leftover from when I originally created this job

view details

Kubernetes Prow Robot

commit sha c07e15c4ad89ad5b9a6b395650fdb28d5f5ab1fa

Merge pull request #17486 from spiffxp/try-using-k8s-infra-prow-build Migrate an e2e job to k8s-infra-prow-build

view details

Aaron Crickenberger

commit sha 85ffcbf2483f8d7a7f4cdc8ec5adf10a241f76c1

Use k8s-infra-prow-build-trusted for an image-pushing job

view details

Kubernetes Prow Robot

commit sha 878534c0ca8a98a0e2c74e3dd63e8ebd669e6d03

Merge pull request #17487 from spiffxp/try-using-k8s-infra-prow-build-trusted Use k8s-infra-prow-build-trusted for an image-pushing job

view details

Kubernetes Prow Robot

commit sha d8f6191056c54e603db055efb6b993dfdeb39bf9

Merge pull request #17481 from chewong/azure-disk-az Azure: add ENABLE_TOPOLOGY env var to various jobs

view details

Aaron Crickenberger

commit sha c7857d008fac30e696d1332fb32dad72c8ea1658

Move some release-blocking/informing jobs to k8s-infra-prow-builds None of these expect greenhouse, use a non-gce-project pool,or are currently failing release-blocking-master: - https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-alpha-features - https://testgrid.k8s.io/sig-release-master-blocking#gce-cos-master-reboot - https://testgrid.k8s.io/sig-release-master-blocking#skew-cluster-latest-kubectl-stable1-gce - https://testgrid.k8s.io/sig-release-master-blocking#Conformance%20-%20GCE%20-%20master - https://testgrid.k8s.io/sig-release-master-blocking#node-kubelet-master - https://testgrid.k8s.io/sig-release-master-blocking#integration-master - https://testgrid.k8s.io/sig-release-master-blocking#verify-master release-informing-master: - https://testgrid.k8s.io/sig-release-master-informing#gce-cos-master-serial - https://testgrid.k8s.io/sig-release-master-informing#gce-cos-master-slow - https://testgrid.k8s.io/sig-release-master-informing#node-kubelet-features

view details

Kubernetes Prow Robot

commit sha 02f56117e8bd6a3f2671c5a2636852cf795249f1

Merge pull request #17488 from spiffxp/migrate-more-e2e-jobs Move some release-blocking/informing jobs to k8s-infra-prow-builds

view details

push time in 23 days

push eventadshmh/test-infra

Scott Lee

commit sha c2255e406f0001284d1c22cd28c6749171747d8e

Add link checker to presubmits

view details

Scott Lee

commit sha efd66d0ad6ff6d3808ff248d031dec8a64e49f26

Use another image

view details

Scott Lee

commit sha ea0c4563cf9ada705d8cf94efc8e2cfd50f63842

Make test non-blocking

view details

Scott Lee

commit sha c286b99851716014674235b04d0285c4ab49c9a3

Make test optional

view details

Scott Lee

commit sha d9e15c1c8bbd9d58acff9164cea98aff8dbd025c

Remove docker io

view details

Benjamin Elder

commit sha 7d0548b26df649098f57bcc56c1dcf7bf80d52ea

set --github-token-path in tide and hook

view details

Bart Smykla

commit sha 529f283e6d6c0b2bfb64b6aee518fcada280c865

Added push job for k8s.io infra-tools Signed-off-by: Bart Smykla <bsmykla@vmware.com>

view details

jetstack-bot

commit sha 7c659892262d4ac33a332daf17cb353139e71823

Update TestGrid for jetstack

view details

Davanum Srinivas

commit sha 7445539dde9a21926b37b15759e66016c10100ff

Option to exclude verify-generated-files-remake script Also add another job to run this script. Signed-off-by: Davanum Srinivas <davanum@gmail.com>

view details

Kubernetes Prow Robot

commit sha be2a8a9bc9fc4c35261c663ea17ea987a05e7374

Merge pull request #17454 from dims/option-to-exclude-verify-generated-files-remake New CI job for running the verify-generated-files-remake script

view details

Petr Muller

commit sha 60b6a414049e0c9ea45ddd5d95f150f4263c5acf

peribolos: get full repo details lazily Previously peribolos, with `--fix-repos` was enabled, called `GetRepo` for all repos in an org. This is wasteful when those repos are not even considered to be updated, so this was fixed to only get full repo details when peribolos consider a specific configured repo for be created or updated.

view details

Alex Pavel

commit sha 31706e8f9db99825d60a4798fdf0b1240b70aa33

Revert "Merge pull request #17455 from stevekuznetsov/skuznets/cherry-pick-on-create" This reverts commit b9c4a4731900d9df85cbbc3baecfba484e6615c4, reversing changes made to 16f3dc84e0243c729af20bbf63a117753b490b08.

view details

Alex Pavel

commit sha 6c04bf87da833d5864c750c3c2f9fa0f19dfa98d

Revert "Merge pull request #17381 from AlexNPavel/cherrypick-bz" This reverts commit 2f01869b9803d34326dde7cd097b5b1cfb0283ac, reversing changes made to 9534e9b639177cc0be543d41db5b73fc8e40df1f.

view details

Kubernetes Prow Robot

commit sha fdbbc1f61a254b30ae6254a2d2d4c6b5024121f3

Merge pull request #17466 from AlexNPavel/revert-cherrypick-bz Revert cherrypick bz

view details

Travis Clarke

commit sha 0df2b9f12c18d744b6ba095eb0fddca58722ec70

Cherrypicker: assign issue on cherrypick error

view details

Alvaro Aleman

commit sha b0a3fd902349f8ebadd7014c23e67d18cd50829c

ValidateTideContextPolicy check: cope with non org/repo formatted repos

view details

Kubernetes Prow Robot

commit sha 7e24a745f70f55907119751ce0d4ffc3bfd19621

Merge pull request #17469 from alvaroaleman/fix ValidateTideContextPolicy check: cope with non org/repo formatted repos

view details

google-oss-robot

commit sha 91fd697ac76414f87480d1cbb82a39e84ebc0a4e

Update TestGrid for GoogleCloudPlatform

view details

Kubernetes Prow Robot

commit sha 4a8815f2517e715c3350f681d488a62f13f44f03

Merge pull request #17449 from bartsmykla/infra-tools-push-job Added push job for k8s.io infra-tools

view details

Kubernetes Prow Robot

commit sha 5a41f0b405ff8d42c2399dab4699bf14e7aa62c7

Update prow to v20200430-fdbbc1f61, and other images as necessary.

view details

push time in 24 days

Pull request review commentkubernetes/test-infra

Add DecorateAllJobs option to job config

 func mergeJobConfigs(a, b JobConfig) (JobConfig, error) { }  func setPresubmitDecorationDefaults(c *Config, ps *Presubmit, repo string) {-	if ps.Decorate {+	if c.DecorateAllJobs || ps.Decorate {

Thank you for the detailed review. I have added an Undecorated option to allow opting out of default behavior and define undecorated jobs.

adshmh

comment created time in 24 days

pull request commentkubernetes/test-infra

Add DecorateAllJobs option to job config

You also need to update decorationRequested in prow/config/config.go

Thank you for the review. Fixed.

adshmh

comment created time in 24 days

push eventadshmh/test-infra

Arash Deshmeh

commit sha 3e2f749c1171650d5f351b5e28906e66b891d3bf

Add DecorateAllJobs option to job config Add a configuration option to allow all jobs to be decorated by-default. Also add a configuration option to allow jobs to opt out of this if set. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 24 days

push eventadshmh/test-infra

zhan wang

commit sha 528d2e2de355cf4f2956021e730742d63b3a0958

update URL to correct one Signed-off-by: zhan wang <zhanw15@gmail.com>

view details

Andrew Jackura

commit sha 6e296054e77e872acf39c205cb8c06c464a3e5e3

Add new osconfig dashboard

view details

Peter Rifel

commit sha 181e6d2d19ad2d13878d46ddc1db02a32581d744

Enable merge commit blocker plugin on the Kops repo

view details

Julian V. Modesto

commit sha a0e096223ec0727650495490c67df60e2c04198a

Add .resources for smd benchmark jobs

view details

Alvaro Aleman

commit sha a9442a80132263ce972b9b5112362ede281bbf5a

Remove references to prowjobs/status subresource We do not activate the status subresource in our CRD definitions, nor do we have any code that interacts with it.

view details

Davanum Srinivas

commit sha 8fb3394bfad37a7f7414f68bd47fa47336666d11

clean up unused references to stale coreos images Please see https://coreos.com/os/eol/ - End-of-life announcement for CoreOS Container Linux - image-config-1.*.yaml is not used in any jobs - remove commented out coreos images, we can always peek at git history if we need them - cross checked logs of the following jobs to make sure that the images are not loaded/used. The node e2e test just skips over them. * ci-cri-containerd-node-e2e-benchmark * ci-kubernetes-node-kubelet-benchmark * ci-kubernetes-node-kubelet-conformance Signed-off-by: Davanum Srinivas <davanum@gmail.com>

view details

Davanum Srinivas

commit sha e5ef784e74eb55f85328c2e6c6b8225ca2436155

Remove --hyperkube and KUBE_BUILD_HYPERKUBE references follow up from change in k/k where we removed hyperkube, we should fix up the jobs and scripts to remove any references. Signed-off-by: Davanum Srinivas <davanum@gmail.com>

view details

Arash Deshmeh

commit sha b3cf2e13c744fc10cde248d1969b20e509047ab9

Merge PR with base branch before checking OWNERS The verify-owners plugin now merges a PR with its base branch before validating the OWNERS file(s). This is to cover the scenario in which the error (e.g. a missing owners alias) has been fixed through a separate PR, but the plugin would still report an invalid OWNERS file, because it only performs a checkout on the PR rather than merging it with the base branch. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Jim Angel

commit sha 0c8cff802ebe2af6a0e929e9e404c51cc9e63064

switch to merge (default) method

view details

Stefan Bueringer

commit sha 65336ff6ba3de881bcba2759e5a466d42d6b64ea

add CAPO conformance tests to CAPO testgrid

view details

vitt-bagal

commit sha 9c592e2b4e6c71735f35d0628172a249a5267893

add image push job for CSI packages

view details

marosset

commit sha ad9fde24d9e541ad1af54db804e439a594856bb2

Removing gce-windows-2019-1.18 job from 1.18 release informing dashboard

view details

vitt-bagal

commit sha 3b839d26632ba4b4996e47731ca618a2116a69e3

added comment

view details

Chao Dai

commit sha 36b2c8b70ab9cc2329ddd50f9a7ccd34a3b32fef

Spyglass display flakes

view details

Stefan Bueringer

commit sha c6af130cf96d04acc403cdeac24196658d9e7b8c

tide: skip unknown context in kubernetes-sigs/cluster-api-provider-openstack

view details

Antonio Ojea

commit sha 80952f36db50ff1094671fe3545b307fa6e4a915

Add IPVS presubmit job based on pull-kubernetes-e2e-gce

view details

Chao Dai

commit sha b4eb0fcb7f22180034033792db1edb90a77a3cf6

Add unit tests and add UI

view details

Chao Dai

commit sha 8c8ac8c4f378ebcb77bdc5e9b0518fd172c6d2e4

Restore lenses, and copy/paste FakeArtifact into lens_test.go

view details

Erick Fejta

commit sha d6ce0903754e5df6a786023b963339823f475d1d

Use bazel 2.2.0

view details

Chao Dai

commit sha 9861037970200d0a1023f7ae2be3dac251ce5981

Update gofmt, bazel, and deps using bazel

view details

push time in 24 days

issue commentkubernetes/test-infra

Expose "Changed Files" Through Downward API to (Pre|Post)submit Jobs

/remove-lifecycle stale I have submitted #13731 and #12751 for this issue.

midnightconman

comment created time in a month

Pull request review commentkubernetes/test-infra

Expose PR's changed files to (Pre|Post)Submit jobs through downward api

 func EnvForSpec(spec JobSpec) (map[string]string, error) {  	env[pullNumberEnv] = strconv.Itoa(spec.Refs.Pulls[0].Number) 	env[pullPullShaEnv] = spec.Refs.Pulls[0].SHA++	if changes := envFromPullChangedFiles(spec.Refs.Pulls); changes != "" {

Thank you for the review. This is pending #13731 (to use git client in Tide). But I have updated the PR to address this, i.e. add reference to pull requests' changed files in batch jobs.

adshmh

comment created time in a month

push eventadshmh/test-infra

Arash Deshmeh

commit sha af05ab3cd9290a26b673a56551a7684d522641de

Add PR's ChangedFiles to downward API The downward API now exposes the list of files changed by a PR, obtained from ProwJobSpec, to PreSubmit, PostSubmit, and Batch jobs. This is done through both the spec environment variable and a new environment variable, named `PULL_CHANGED_FILES`. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in a month

push eventadshmh/test-infra

Kubernetes Prow Robot

commit sha 9acb847eda8a4fc7878723b636c5f26c771f10f1

Merge pull request #16819 from neolit123/kubeadm-windows kubeadm/windows: increase test timeout to 180m

view details

Carlos Panato

commit sha 39d2fff36c8298a1185716b50923ed62a3534f30

releng: enable code thaw for 1.18

view details

Kubernetes Prow Robot

commit sha 673b1adb50bcbd486bc668ec5780d0a7ee5d9eae

Merge pull request #16783 from stevekuznetsov/skuznets/user-agent-response ghproxy: record the user agent on cache response metrics

view details

Carlos Panato

commit sha e23a91bf37e0b65bfaf474587cf983cc087589ac

releng: Update milestoneappliers for 1.19

view details

Adelina Tuvenie

commit sha 915b3e45c2c33984c9bb8335922663ab2e8bd073

Enable log collection for all K8s windows jobs.

view details

Kubernetes Prow Robot

commit sha a1ffb887047875fcbf4979718c972b1693e08b8c

Merge pull request #16820 from adelina-t/patch-46 Enable log collection for all K8s windows jobs.

view details

Marko Mudrinić

commit sha fd4c24a41ad46ceb6ab4108e6300ca13337a8766

Remove andrewsykim from owners

view details

Michelle Shepardson

commit sha 4de0711af19262b88bb1a9defb5ab1588c17cc45

Add section on link template options.

view details

Kubernetes Prow Robot

commit sha b47df9e347776f6d903db0828a46c6e0cf4d38ab

Merge pull request #16763 from cjwagner/ghproxy-for-erbdy Improve ghProxy docs and make Prow warn if ghproxy isn't being used.

view details

Kubernetes Prow Robot

commit sha 6d91ffe6eceb2d055ce2860bfe909d5f995c351f

Merge pull request #16821 from cpanato/code-thaw-118 releng: enable code thaw and milestone applier for 1.18 / 1.19

view details

Alvaro Aleman

commit sha 24424864aa6ac25e52baf27eadf05fae9cc9c935

Allow using deck outside of GCP with an anonymous gcs client

view details

Kubernetes Prow Robot

commit sha 2c1ca73bccdc436e3a7beb4f7db38fb7034e690c

Merge pull request #16805 from bparees/bugtemplate fix up openshift bug template

view details

Ben Parees

commit sha ce23f9ba5de0e8ffbee228254434c69ca5f09974

add sample description to e2e-aws-4.4 job

view details

Kubernetes Prow Robot

commit sha 37fd3e44d2a523314f0705270bc51e2fe2462f3d

Merge pull request #16292 from lubinsz/pr_arm64_containerd Publishing the test results of arm64 conformance test with containerd

view details

Stephen Augustus

commit sha b52502f0f854636ebe989d1fffad3598b2ff4ace

releng: Remove bazel version markers Bazel version markers appear to be unused. In general, we should opt to use the version markers produced from the ci-kubernetes-build* jobs instead, so we stop publishing the bazel ones. Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Kubernetes Prow Robot

commit sha 5ebca0eba27719473d1ecb2ad13bcc24101d1b85

Merge pull request #16823 from xmudrii/remove-andrewsykim-owners Remove andrewsykim from owners

view details

Kubernetes Prow Robot

commit sha c1f3f988a249a24b743aa74ca7a1e4229e7cc22a

Merge pull request #15612 from justaugustus/dedupe-bazel-jobs releng: Remove bazel version markers

view details

Cecile Robert-Michon

commit sha 99e0d1246e2dd4af163a02d2dadf5a04e86a08a9

Add cluster-api-provider-azure v0.5 milestone to plugins

view details

Kubernetes Prow Robot

commit sha 190894183088b279f6ef4af17dab4c0ff05066bc

Merge pull request #16825 from alvaroaleman/deck-no-auth Allow using deck outside of GCP with an anonymous gcs client

view details

Cecile Robert-Michon

commit sha 930bcad2672dede2b649bb668e3aaf3dc711aacb

[cluster-api-provider-azure] Add regex for release tag image pushing

view details

push time in a month

PR opened kubernetes/test-infra

Leave a comment on PRs that fail to merge by tide

Tide now leaves a comment on any PR that fails to merge for any reason. Existing comments on the PR are checked to avoid spamming the PR with merge failure comments.

+267 -18

0 comment

2 changed files

pr created time in a month

create barnchadshmh/test-infra

branch : tide-leave-comment-on-failed-to-merge-PRs

created branch time in a month

Pull request review commentkubernetes/test-infra

Reply to pr for failed postsubmit jobs

 func createRefs(pe github.PushEvent) prowapi.Refs { 	} } +func getPullRequests(c githubClient, pe github.PushEvent) ([]github.PullRequest, error) {+	org := pe.Repo.Owner.Login+	repo := pe.Repo.Name+	for _, commit := range pe.Commits {+		if commit.ID == "" {+			continue+		}+		pulls, err := c.ListCommitPullRequests(org, repo, commit.ID)+		if err != nil {+			return nil, err+		}+		if len(pulls) > 0 {+			return pulls, nil+		}+	}+	return nil, nil+}+ func handlePE(c Client, pe github.PushEvent) error { 	if pe.Deleted || pe.After == "0000000000000000000000000000000000000000" { 		// we should not trigger jobs for a branch deletion 		return nil 	}+	// TODO: it seems there is a bug in GH API, which returns an empty list of+	// PRs for all commits listed by the push event. Waiting for 1 second seems+	// to successfully work around this.+	time.Sleep(1 * time.Second)

Thanks for the review. I reported this to GitHub support and asked for confirmation and a work-around about the same time I submitted the PR (about 2 weeks ago). They have not confirmed yet, but based on their responses it does seem to be a bug.

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

Reply to pr for failed postsubmit jobs

 type FakeClient struct { 	Column             string 	OrgRepoIssueLabels map[string][]github.Label 	OrgProjects        map[string][]github.Project++	// PullRequests associated with a commit+	CommitPullRequests map[string][]github.PullRequest

Thank you for the review. Fixed.

adshmh

comment created time in a month

Pull request review commentkubernetes/test-infra

Reply to pr for failed postsubmit jobs

 func (o *options) genJobSpec(conf *config.Config, name string) (config.JobBase, 		} 		for _, p := range ps { 			if p.Name == o.jobName {-				return p.JobBase, pjutil.PostsubmitSpec(p, prowapi.Refs{-					Org:     org,-					Repo:    repo,-					BaseRef: o.baseRef,-					BaseSHA: o.baseSha,-				})+				return p.JobBase, pjutil.PostsubmitSpec(p, o.createRefs(org, repo))

Thank you for the review. Fixed.

adshmh

comment created time in a month

push eventadshmh/test-infra

Alvaro Aleman

commit sha a9442a80132263ce972b9b5112362ede281bbf5a

Remove references to prowjobs/status subresource We do not activate the status subresource in our CRD definitions, nor do we have any code that interacts with it.

view details

Maxime Guyot

commit sha 0f23ad74125600da42464c93a69f2cff1f6c6d1b

Add activate Kubespray yamllint CI job and use Kubespray image

view details

Alvaro Aleman

commit sha 2c5e67b5d84b22d49589f617e567fae44edcfbed

Add bazel target to build gcsweb image

view details

Alvaro Aleman

commit sha a4c66030566bcad7ac372369631897b728cd3f5d

Remove obsolet build assets

view details

Alvaro Aleman

commit sha 9869e954c17745015af0ca90489c3e203d1c3cdc

Publish gcsweb

view details

Arash Deshmeh

commit sha 3ee7bb08f2f81bb09eed0af5193e16a3d319bf91

List available presubmit jobs by trigger plugin The trigger plugin now lists all presubmit jobs available for a PR and adds them as a comment to the PR in response to '/test ?' command. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha 63aa6bd7213f23938a9f8435971813ac0369b233

Use Run in trigger plugin's unit tests Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha b42a0c1095ac78f627ebc0f870b602ff7bbaa938

Respond w/help to invalid trigger plugin command The trigger plugin now responds to an invalid command with a help message. More specifically, the following scenarios are covered: - /test without any targets - /restest with trailing words - /test with an unrecognized target Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Pavithra Ramesh

commit sha 970ae6cf0f1859db96e65ff02d2300ce97e54ad7

ALlow image push for k8s dns(kubedns, node-cache)

view details

Alvaro Aleman

commit sha 8602af75f1790185a8d885097313b743fc7524ee

Tide: Don't create retests for unfinished or successful batch jobs

view details

W. Trevor King

commit sha 8f92c55bd00f52150daf6edeac1faad704ced475

prow/plugins/config: Add DependentBugTargetReleases [1] shows the Bugzilla plugin complaining on a 4.2.z backport where the parent 4.3 bug targets 4.3.0 instead of the expected 4.3.z. By adding a new slice config, admins can explicitly say that 4.2 bugs should depend on 4.3 bugs which target either 4.3.0 or 4.3.z. For backwards compatability with existing configurations, the singular dependent_bug_target_release is appended to the plural slice if the string is not already included. [1]: https://github.com/openshift/kubecsr/pull/17#issuecomment-609981202

view details

prameshj

commit sha d2ef1873efc23a877c951b78b08f89bf11a73141

Use serviceAccountName instead of creds mount.

view details

Aaron Crickenberger

commit sha c9918d81942c8bb012507cb2b22991fe72e62f64

labels: add k/k8s.io manually-created labels reordered existing labels to be alphabetic by name I had to manually edit the wg/resource-management removal date for some reason, to change +0000 to UTC

view details

Linus Arver

commit sha 5e237bfc2db6638264327848e547942581cb441c

Revert "ci-k8sio-backup: remove job" This reverts commit a6a2655421e0ea7d03fddd5ed8e08dee62056406. The backup job has received some optimizations in https://github.com/kubernetes/k8s.io/pull/677, In addition, the k8s-artifacts-prod-bak GCR has been manually pre-populated with all ~30K images in k8s-artifacts-prod for all ASIA, EU, and US regions, which will result in jobs taking just minutes to run (as subsequent runs are mostly NOP runs). For more discussion on the backup job, please see https://docs.google.com/document/d/11eiosJvm2xEVUhPRU3-luANxxTPL5FqQdJXVrLPImyQ/edit?usp=sharing.

view details

Linus Arver

commit sha 081901e463f8518a0bb2e7df00c514da4fc5c7a2

ci-k8sio-backup: use workload identity See https://github.com/kubernetes/k8s.io/pull/718 for binding the KSA to the k8s-infra-gcr-promoter@k8s-artifacts-prod-bak.iam.gserviceaccount.com account referenced in this PR.

view details

Kubernetes Prow Robot

commit sha dc0f81256fa08c8fac03f79abbae8dc8b8e6edf5

Merge pull request #17072 from alvaroaleman/gcsweb-image Build gcsweb image

view details

Ernest Wong

commit sha 95510d0c93e74b445088823ce76af72acfb00249

Azure: promote windows PR jobs for Azure Disk and Azure File CSI Driver

view details

Kubernetes Prow Robot

commit sha 0abd6e9d1ee5acb2603e69ee668053f6064b64e1

Merge pull request #16926 from adshmh/16765-prow-command-to-list-possible-tests-on-PR prow command to list possible tests on PR

view details

Nikhita Raghunath

commit sha 2a83789f5a7564d1222269c7b8062b0476ea6e65

Update k/community OWNERS to leads

view details

Nikhita Raghunath

commit sha 29e18379857d6404a59ed557f59fa33d2844ea0f

Update k/org OWNERS to GitHub Admin team

view details

push time in a month

PR opened tektoncd/pipeline

PR upload validates comment file extension

<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->

Changes

pullrequest upload now validates the extension of each comment file: the only valid extensions are none and .json. This allows the upload to fail if a .json comment file cannot be parsed, rather than posting all the contents as the comment. Fixes #2168

<!-- Describe your changes here- ideally you can get that description straight from your descriptive commit message(s)! -->

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Comment files under a PullRequest need to have either:

- no extension: for comment files that contain comment as plain text

- .json extension: for comment files in JSON format
+92 -2

0 comment

2 changed files

pr created time in a month

pull request commentkubernetes/test-infra

Reply to pr for failed postsubmit jobs

/cc @cblecker

adshmh

comment created time in a month

pull request commentkubernetes/test-infra

Expose PR's changed files to (Pre|Post)Submit jobs through downward api

/remove-lifecycle rotten

adshmh

comment created time in a month

issue commenttektoncd/pipeline

Improve debuggability of PullRequest PipelineResource

@bobcatfish if there are other validations that would be helpful, I can submit a PR. So far, the secrets field and the uploaded status are covered.

bobcatfish

comment created time in a month

push eventadshmh/test-infra

Arash Deshmeh

commit sha 660b7fdc060b874203b7add3d096e4f9d90452e1

Retest doesn't have to be on the last line to work The /retest command now works, as expected, if ther are lines with other comments/commands following it: #17218 Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in a month

PR opened kubernetes/test-infra

Retest doesn't have to be on the last line to work

The /retest command now works, as expected, if ther are lines with other comments/commands following it. Fixes #17218

Signed-off-by: Arash Deshmeh adeshmeh@ca.ibm.com

+20 -3

0 comment

2 changed files

pr created time in a month

create barnchadshmh/test-infra

branch : 17218-fix-retest-command

created branch time in a month

issue commentkubernetes/test-infra

/retest command doesn't work if it's not the last line of PR comment

Yes, my tests show the same. Will submit a PR to fix it.

chaodaiG

comment created time in a month

fork adshmh/plumbing

This repo holds configuration for infrastructure used across the tektoncd org 🏗️

fork in a month

pull request commenttektoncd/pipeline

Verify status fields before uploading PullRequest

/retest

adshmh

comment created time in a month

pull request commenttektoncd/pipeline

Verify status fields before uploading PullRequest

/retest

adshmh

comment created time in a month

PR opened tektoncd/pipeline

Verify status fields before uploading PullRequest

<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->

Changes

The pullrequest pipeline resource now verifies the statuses before uploading them. As specified in #1818, this is to improve the debuggability of pullrequest resources, by preventing a silent failure e.g. if there has been a change in the fields' names of a status object.

<!-- Describe your changes here- ideally you can get that description straight from your descriptive commit message(s)! -->

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

The statuses on a pullrequest pipeline output resource will be validated before attempting to upload them. The validations currently done are:
- `Label` field needs a value
- `State` field needs a value
+58 -0

0 comment

2 changed files

pr created time in a month

create barnchadshmh/pipeline

branch : 1818-validate-PR-status

created branch time in a month

pull request commenttektoncd/pipeline

Validate PullRequest resource secrets fields

Failing tests changed without any code changes. Look like a flake. Trying one more time. /retest

adshmh

comment created time in a month

pull request commenttektoncd/pipeline

Validate PullRequest resource secrets fields

/retest

adshmh

comment created time in a month

Pull request review commenttektoncd/pipeline

Validate PullRequest resource secrets fields

 func validateURL(u, path string) *apis.FieldError { 	} 	return nil }++func validatePullRequest(s *PipelineResourceSpec) *apis.FieldError {+	if s.Type != PipelineResourceTypePullRequest {

Thank you for the review. Fixed.

adshmh

comment created time in a month

push eventadshmh/pipeline

Arash Deshmeh

commit sha 9fca352ec0394f25172782a4209c90498e49a18a

Validate PullRequest resource secrets fields A PullRequest type pipeline resource is now validated: an unrecognised 'fieldName' in secrets will trigger an error. Part of work on #1818 As stated in #1818, this will help improve the debuggability of the PullRequst pipeline resource, as the validatiob will cause a failure in response to invalid input as early as possible. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in a month

PR opened tektoncd/pipeline

Validate PullRequest resource secrets fields

<!-- 🎉🎉🎉 Thank you for the PR!!! 🎉🎉🎉 -->

Changes

A PullRequest type pipeline resource is now validated: an unrecognised 'fieldName' in secrets will trigger an error.

<!-- Describe your changes here- ideally you can get that description straight from your descriptive commit message(s)! --> As stated in #1818, this will help improve the debuggability of the PullRequst pipeline resource, as the validatiob will cause a failure in response to invalid input as early as possible.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Specifying a value other than `authToken` in the `fieldName` field of `secrets` in a PullRequest resource will cause a validation failure, preventing the PullRequest resource from being created. 
+38 -0

0 comment

2 changed files

pr created time in a month

push eventadshmh/pipeline

Arash Deshmeh

commit sha e08c92c9d4bdf92f104ebe61a1a545dbaffc39fd

Validate PullRequest resource secrets fields A PullRequest type pipeline resource is now validated: an unrecognised 'fieldName' in secrets will trigger an error. Part of work on #1818 As stated in #1818, this will help improve the debuggability of the PullRequst pipeline resource, as the validatiob will cause a failure in response to invalid input as early as possible. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in a month

pull request commentkubernetes/test-infra

Retire optional contexts removed from repos

/remove-lifecycle rotten

adshmh

comment created time in 2 months

push eventadshmh/test-infra

andyzhangx

commit sha 06f25b807b9629baa906e334b661fd098bae6ecc

test: change test region due to quota issue

view details

Kubernetes Prow Robot

commit sha a63558e27332d246866157fab53c02b3160e9e3c

Merge pull request #16564 from andyzhangx/change-region test: change test region due to quota issue

view details

andyzhangx

commit sha 28b6127f70f261cd195452353a3e9db988fc9d0d

test: change some test regions due to quota issue

view details

Alvaro Aleman

commit sha e11e8bd10e95f0ca3d23dc1e332b7791be4cdce5

Properly namespace criers RBAC

view details

Kubernetes Prow Robot

commit sha d4a86565d1e03d95588097c2f49fbe920e76109d

Merge pull request #16565 from andyzhangx/azure-region test: change some test regions due to quota issue

view details

Kubernetes Prow Robot

commit sha 72c7996cbc069783c7466aac177a31fa45676902

Merge pull request #16554 from aramase/install-deps install deps for e2e in secrets-store-csi-driver

view details

hasheddan

commit sha 517c73530bec278ecd0a8e4049cd42138881cf2f

Add windows-containerd-1-18 test to google-windows dashboard Signed-off-by: hasheddan <georgedanielmangum@gmail.com>

view details

Kubernetes Prow Robot

commit sha f373f5322e4d90de8241d3a6b11e33d151b481a2

Merge pull request #16549 from hasheddan/wind Remove gce-windows-2019-containerd-master from release informing

view details

Ernest Wong

commit sha 31bc7880e1e64c9d2cd56d1c3c617d6098261063

Azure: add a presubmit job for Azure Disk CSI driver migration feature

view details

Roman Yepishev

commit sha 40e5e5f6efa6fba81c523bb896036e0cda400b94

Register gcr.io helper for docker before the build This allows build dependencies to be sourced from gcr.io registries that require authentication.

view details

Kubernetes Prow Robot

commit sha 0c4f6ea47875dc66d7a50be498dff54f61631758

Update prow to v20200228-0cf55751f, and other images as necessary.

view details

Roman Yepishev

commit sha 80d66188f1933cd7e3d70af82cd01b1f5107f906

Put gcloud auth configure-docker behind a flag

view details

Kubernetes Prow Robot

commit sha c921a880e4040b3f4358f6ef3ae5d806ec0e3284

Merge pull request #16533 from k8s-ci-robot/autobump Update prow to v20200228-0cf55751f, and other images as necessary.

view details

Kubernetes Prow Robot

commit sha bd87a79d5e565ec12597baffc82d2a84880e519d

Merge pull request #16529 from alvaroaleman/boskos-retry-on-conflict Boskos: Retry on conflict

view details

Kubernetes Prow Robot

commit sha ca9526d747fd5d2866ba6a13956c82e7a6bd3c8a

Merge pull request #16570 from roman-yepishev/docker-auth-scenarios Register gcr.io helper for docker before the build

view details

Kubernetes Prow Robot

commit sha 1a752157125f123b6e98480355ffbfdb72420bbc

Merge pull request #16476 from fejta/tide Try to warn about not using secret json files

view details

Ernest Wong

commit sha 8fa45865b2c05606806b5a627dc99a81b1105b5b

Azure: add a windows periodic job that runs [Serial] test cases

view details

Kubernetes Prow Robot

commit sha 0c410f2ff57ba9e5e92dba33308d9ff434371a1b

Merge pull request #16574 from chewong/windows-serial-jobs Azure: add a windows periodic job that runs [Serial] test cases

view details

Erick Fejta

commit sha 8061d4843a3e95bb9e11cc98cfe786b9a6026ff0

Allow resultstore exporter to just export specific buckets. This is necessary because it will attempt to write a field to the finished.json, and it may not have authorization to do that for all buckets in the config.

view details

Andy Zhang

commit sha a92b351f312cc04367d3c5563c37e1de1fce1e5a

Revert "test: change some test regions due to quota issue"

view details

push time in 2 months

pull request commentkubernetes/test-infra

Use git client in tide to get the list of files changed by each PR

@stevekuznetsov @matthyx @alvaroaleman @cjwagner I would appreciate another round of reivew. All your comments and required changes have been addressed.

adshmh

comment created time in 2 months

push eventadshmh/test-infra

Arash Deshmeh

commit sha d84b106ea0016ccddb4071e92bed91d304516931

Add PR refs to postsubmit jobs in trigger plugin For postsubmit jobs triggered by a PR, the trigger plugin now adds refs identifying the PR. This allows the github reporter to post the status of the postsubmit job by adding comments to the PR. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

Arash Deshmeh

commit sha b430c63db82b5e71a4d43b7aecaf6e4098c40059

Add PR ref to postsubmit jobs in mkpj command The mkpj command now includes a reference to PR in the generated postsubmit job specs. Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>

view details

push time in 2 months

push eventadshmh/test-infra

Julian V. Modesto

commit sha a0e096223ec0727650495490c67df60e2c04198a

Add .resources for smd benchmark jobs

view details

Artyom Lukianov

commit sha a654b4d9dba40641f7fa3aa3e5ae3889e07ef238

Advance KIND version to 0.7.0 This PR advance KIND stable version under the kubetest to 0.7.0 and adapt the kubetest code to changes under the KIND code. Signed-off-by: Artyom Lukianov <alukiano@redhat.com>

view details

charles-edouard.breteche

commit sha b74420373ebe3524b418e8ce874d76b322f09e83

update pipeline package

view details

Gyuho Lee

commit sha 422b933ddd01922f64d9e292e20cfc936448893d

go.mod: pin latest aws-k8s-tester + aws-sdk-go Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

view details

Gyuho Lee

commit sha 1624379cf8b5f2591eca9190ad6c5a02992ee462

kubetest2/kubetest2-eks: remove unnecessary sync calls Now, "ValidateAndSetDefaults" calls "Sync" automatic. Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

view details

Renmin Gu

commit sha 2d0e97ec139edd56eacf73a18d716adb817770ca

add presubmit, remove postsubmit

view details

Oleg Bulatov

commit sha 894bbde454cadd30607140053416cba85400daab

Preserve formatting in failures output

view details

Steve Kuznetsov

commit sha 9494d532950e8c43a80530c854e07a020202535f

deck: use prow/github instead of go-github in oauth handlers There was no real reason to be using the older, separate client in deck's handlers and it meant that new tooling to track client usage in logs and metrics was not supported for these calls. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

view details

Bob Killen

commit sha 4803ba2e53ba874cb2b2fb0e471b16ebb6a4a6d8

Enable blockade for design-proposals

view details

Cole Wagner

commit sha 0edf346e0a14e129a832ce3134baec744bc96b2e

Make status-reconciler use ghproxy.

view details

Anish Ramasekar

commit sha 2173e73dc9c45f0fae4ae66fa03f6ebb32a49efa

add presubmit build job for csi-secrets-store

view details

Chao Dai

commit sha 512987baa21e05044ddce746aaaef25a6a7bfb4a

Don't fail kubetest with leaked firewall rules The leaked firewall rules are bad, but since they are already cleaned up by kubetest before exit. Print a warning instead of failing kubetest

view details

Kubernetes Prow Robot

commit sha c311b09df4323525700c640dc2de701836a6b7d9

Merge pull request #17138 from cjwagner/ghproxy-for-reconciler Make status-reconciler use ghproxy.

view details

Erick Fejta

commit sha 86d9b895e6e6103c58513077155f6f7d0fc0ca91

Postsubmits must vote non-negatively

view details

Kubernetes Prow Robot

commit sha 953efeddb1e31093237b92a0bb1fea38e50d1a3a

Merge pull request #17140 from chaodaiG/ignore_leaked Don't fail kubetest with leaked firewall rules

view details

Kubernetes Prow Robot

commit sha 8bf6ff7df47304967325400e02020861923e873f

Merge pull request #17078 from eddycharly/master Update pipeline to v.011.0 (v1beta1)

view details

Kubernetes Prow Robot

commit sha dfa851b805ee4923dc16fc53ec9fc695eee0fe39

Merge pull request #17139 from aramase/add-build-test add presubmit build job for csi-secrets-store

view details

Aaron Crickenberger

commit sha 1b8d73a97e2f5bc8f6378c8101a8059af982f282

replace links to gubernator.k8s.io with prow.k8s.io for things that comment in github

view details

Kubernetes Prow Robot

commit sha 276784856e1843ec45db72e3bbaae79e94157783

Merge pull request #17120 from gyuho/eks go.mod: pin latest aws-k8s-tester + aws-sdk-go

view details

Kubernetes Prow Robot

commit sha 80b2a8d65ae0dc146701d9a15ff2673f8fbc9e94

Merge pull request #17143 from spiffxp/rm-gubernator-link replace links to gubernator.k8s.io with prow.k8s.io

view details

push time in 2 months

more