profile
viewpoint
Andy Bursavich abursavich MZ San Francisco, CA Doing server software and infrastructure things; Go-preferring polyglot; Ex-Google SWE-SRE

abursavich/nett 37

Package nett steals from the standard library's net package and provides a dialer with a pluggable host resolver.

abursavich/arc 4

Package arc implements an adaptive replacement cache.

abursavich/fenwick 2

Package fenwick provides an implementation of a Fenwick Tree or Binary Indexed Tree which provides efficient manipulation and calculation of prefix sums on a table of values.

abursavich/dynamictls 1

DynamicTLS reconfigures TLS on filesystem changes.

abursavich/grpcprom 1

Package grpcprom provides Prometheus instrumentation for gRPC servers.

abursavich/common 0

Go libraries shared across Prometheus components and libraries.

abursavich/controller-runtime 0

Repo for the controller-runtime subproject of kubebuilder (sig-apimachinery)

abursavich/coredns 0

CoreDNS is a DNS server that chains plugins

abursavich/elasticsearch_exporter 0

Elasticsearch stats exporter for Prometheus

push eventabursavich/zapr

Andy Bursavich

commit sha e8241ca86303223a7a73993cc913042712403675

Extract prometheus to zaprprom

view details

Andy Bursavich

commit sha 1df8dce1b4a12dc27e52c4935b0aa4cfbc3c0b23

Clarify Underlying interface method

view details

Andy Bursavich

commit sha d6fc1b3c2a7caf5ce8bb0a5224cf77b32be3c018

Update dependencies

view details

Andy Bursavich

commit sha 2e76638ee228c5bf23dc1ca498a6341cc9fa5713

Move encoder types to separate files

view details

push time in 2 days

push eventabursavich/zapr

Andy Bursavich

commit sha e8241ca86303223a7a73993cc913042712403675

Extract prometheus to zaprprom

view details

Andy Bursavich

commit sha 1df8dce1b4a12dc27e52c4935b0aa4cfbc3c0b23

Clarify Underlying interface method

view details

Andy Bursavich

commit sha d6fc1b3c2a7caf5ce8bb0a5224cf77b32be3c018

Update dependencies

view details

Andy Bursavich

commit sha 2e76638ee228c5bf23dc1ca498a6341cc9fa5713

Move encoder types to separate files

view details

push time in 2 days

push eventabursavich/zapr

Andy Bursavich

commit sha 689057b6628ba93ea50996e997144f579665cb4d

Clarify Underlying interface method

view details

Andy Bursavich

commit sha 600de70e2a62150c89d025e6cd1d192463642774

Update dependencies

view details

push time in 2 days

push eventabursavich/zapr

Andy Bursavich

commit sha 846bd5c8ac0591c4114fd547abfe45b784f67647

Extract prometheus to zaprprom

view details

push time in 2 days

create barnchabursavich/zapr

branch : reorg

created branch time in 2 days

push eventabursavich/zapr

Andy Bursavich

commit sha 4796516fb2b54022ab2098059a33be0cd7af152d

README: update badges

view details

push time in 18 days

push eventabursavich/dynamictls

Andy Bursavich

commit sha 02c9897eff83cd743b25c4c0633d2189152f25d3

README: update badge styles

view details

push time in 18 days

PR closed kubernetes/kubernetes

Reviewers
apiextensions: allow metadata description cncf-cla: yes kind/bug needs-ok-to-test priority/awaiting-more-evidence release-note-none sig/api-machinery size/S

What type of PR is this?

/kind bug

What this PR does / why we need it:

When restricting any specification of metadata fields, the existing validation also restricts any description of the metadata itself, for which there doesn't seem to be any reason. While controller-tools has been updated to drop its metadata field specifications, it leaves any metadata description, which then causes validation to fail. The current workaround is to remove any documentation on Go struct metadata fields for custom resources, which is not ideal for users (e.g. Prometheus).

Which issue(s) this PR fixes:

N/A

Relates to https://github.com/kubernetes/kubernetes/issues/74620, https://github.com/kubernetes/kubernetes/pull/77653, https://github.com/kubernetes-sigs/controller-tools/issues/216, and https://github.com/kubernetes-sigs/controller-tools/pull/266

Special notes for your reviewer:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/bb44066fbeaa571fb824c164742c37a289cbd608/keps/sig-api-machinery/20190425-structural-openapi.md
- [Other]: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#specifying-a-structural-schema
+12 -0

13 comments

2 changed files

abursavich

pr closed time in 23 days

pull request commentkubernetes/kubernetes

apiextensions: allow metadata description

The current workaround is to remove any documentation on Go struct metadata fields for custom resources, which is not ideal for users

Given the metadata descriptions published for users come from the in-tree metadata definition, can you give more details about why omitting them here is problematic?

Go structs field comments are a form of documentation and are used in other forms of generated type documentation (e.g godoc and markdown). It's unfortunate that they lose information to appease the machinery. However, based on your feedback it seems like the issue is with controller-tools for including the comment/description in the CRD.

abursavich

comment created time in 23 days

issue closedmachinezone/configmapsecrets

Allow for running in namespaces other than kube-system

Thanks for writing this, it perfectly solves the conundrum of how to manage secrets within alertmanager without having to put all of your config in a secret.

I tried to install this in a namespace other than kube-system, and it fails because it seems to be trying to create a leader election configMap in kube-system.

Could you please allow installation of this into a namespace other than kube-system? Simplest method might just be to use an env variable like POD_NAMESPACE that defaults to kube-system, and then let people configure it themselves at installation time using the downward API?

closed time in a month

Niksko

issue commentmachinezone/configmapsecrets

Allow for running in namespaces other than kube-system

Closed with https://github.com/machinezone/configmapsecrets/commit/3ef11dbb71eda905f40deef0e9be025ce22bb4a4 and cut release v0.4.0.

Niksko

comment created time in a month

created tagmachinezone/configmapsecrets

tagv0.4.0

A Kubernetes controller to manage configs with a mix of secret and non-secret data

created time in a month

release machinezone/configmapsecrets

v0.4.0

released time in a month

push eventmachinezone/configmapsecrets

Andy Bursavich

commit sha 5725a3b6a37a717cf5135a7c610629f6b171862b

manifest: update image from v0.3.0 to v0.4.0

view details

push time in a month

push eventmachinezone/configmapsecrets

Andy Bursavich

commit sha 3ef11dbb71eda905f40deef0e9be025ce22bb4a4

add leader-election-namespace flag to override default behavior

view details

push time in a month

push eventmachinezone/configmapsecrets

Andy Bursavich

commit sha 25287870f2edf5234cd05b08cbfc516233c03331

use bursavich.dev/zapr

view details

Andy Bursavich

commit sha a292f457c3f916f5b0d055a4724e9515ee06e292

update dependencies

view details

push time in a month

issue commentmachinezone/configmapsecrets

Allow for running in namespaces other than kube-system

If you run the controller in "local" mode (--all-namespaces=false) with leader election enabled (--enable-leader-election), then it will only watch objects in its own namespace which it will use for leader election.

If you run the controller in "global" mode (--all-namespaces) with leadership election enabled (--enable-leader-election), then it will watch objects in all namespace and use the kube-system namespace for leader election.

The theory behind forcing kube-system in "global" mode is to prevent "global" controllers installed in multiple namespaces from thrashing, but perhaps this is too paternalistic. If you're trusted to grant RBAC access to the whole cluster, you should probably be trusted not to run multiple "global" controllers with different leader election configs. I'll think about adding more knobs for controlling leadership election.

In the meantime, you can run in "local" mode or disable leader election (using only 1 replica) in "global" mode.

Niksko

comment created time in a month

pull request commentprometheus/prometheus

Invert service discovery dependencies

This change upgraded github.com/prometheus/common from v0.11.1 to v0.13.0. It required changes that were in v0.13.0. HTTP/2 was disabled in v0.12.0.

abursavich

comment created time in a month

pull request commentkubernetes/kubernetes

apiextensions: allow metadata description

ping, @sttts

abursavich

comment created time in a month

fork abursavich/glb-director

GitHub Load Balancer Director and supporting tooling.

fork in a month

push eventabursavich/zapr

Andy Bursavich

commit sha 26ccbd0b6473556efe0a5c43f687fadc2168b138

Remove default Metrics

view details

push time in a month

push eventabursavich/zapr

Andy Bursavich

commit sha c20f5cc883db771485db029bfaf7ac3b00bdd4b6

Allow registration of other encoders as flag values

view details

push time in a month

startedblushft/go-diagrams

started time in a month

push eventabursavich/zapr

Andy Bursavich

commit sha 3bf941ab29981d2848b68b8b9c7a56b9fd803e06

Allow other metrics implementations

view details

push time in a month

push eventabursavich/zapr

Andy Bursavich

commit sha 0afef3e4030e1cdde23e620b9b3d32b35dad9a9c

Initial commit

view details

push time in a month

create barnchabursavich/zapr

branch : master

created branch time in a month

created repositoryabursavich/zapr

created time in a month

issue commentgolang/go

proposal: cmd/go: 'go install' should install executables in module mode outside a module

I'm just gonna withdraw my comments and step out of the way of progress. Leave it like it is in tip :)

jayconrod

comment created time in a month

issue commentgolang/go

proposal: cmd/go: 'go install' should install executables in module mode outside a module

I think it's important to keep go install pkg for module-local packages, particularly since replace directives are going to be ignored with @version... If you really want to drop the consistency hammer, go get should require an explicit @version to add or update a package in module-aware mode.

jayconrod

comment created time in a month

delete branch abursavich/dynamictls

delete branch : travisci

delete time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha a50e7d1b7f339b59797fe6f43e1753b04c3540bc

travis: add go install hacks for goveralls and golangci-lint

view details

push time in a month

create barnchabursavich/dynamictls

branch : travisci

created branch time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha 3f604cd573e25857c90bec7c7911770ee388040f

travis: upgrade golangci-lint from v1.28.3 to v1.31.0

view details

push time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha 3e2f63a72eb520a71aa035e6581377f0551e0615

travis: upgrade golangci-lint to latest

view details

push time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha c73bb9f47ba88e2dc3e01fea1311e0af9251e723

travis: upgrade golangci-lint from v1.28.3 to v1.31.0

view details

push time in a month

pull request commentkubernetes/kubernetes

apiextensions: allow metadata description

ping, @sttts

abursavich

comment created time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha e0eccb42f941c239c2aec1918c566bda72475a0b

travis: update install of goveralls After go 1.16.x is oldstable and go 1.17.x is stable, this can be replaced with `go install github.com/mattn/goveralls@latest` (or pin a specific version).

view details

push time in a month

issue commentgolang/go

proposal: cmd/go: 'go install' should install executables in module mode outside a module

@jayconrod

Moving conversation over from #40728, my only sticking point is that I agree with you here: https://github.com/golang/go/issues/30515#issuecomment-469371090 :100:

When called from inside a module, the current behavior in tip is great when referring to a module-local package path, but when referring to a non-local package path go install package should behave the same as go install package@live, so as to be consistent with other module-related commands.

jayconrod

comment created time in a month

issue commentgolang/go

proposal: cmd/go: default to & improve -mod=readonly

Maybe I should take my comments to CL 243077, but we're here for now.

I am a big proponent of differentiating get and install. However, I think there's an orthogonal discussion about whether certain commands should:

  1. modify go.mod
  2. fallback to the network

I think install should not modify go.mod and it should fallback to the network. If trying to install a command not in the current module, go install package should behave the same as go install package@version. This would make it symmetric with the familiar behavior of get.

rsc

comment created time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha f36cbb35d1bc49b81aaabd693e5425eea002d6db

travis: update install of goveralls In module-aware mode, `go install` will require or add the installed module in the current go.mod. A change in tip sets `--mod=readonly` as default for `go install` which causes `go install github.com/mattn/goveralls` to fail. After go 1.16.x is oldstable and go 1.17.x is stable, this can be replaced with `go install github.com/mattn/goveralls@latest` (or pin a specific version).

view details

push time in a month

issue commentgolang/go

proposal: cmd/go: default to & improve -mod=readonly

Out of interest, if you are running tip, why would you delay switching to this approach until after 1.16 (I assume you meant 1.16, as opposed to 1.17)?

With TravisCI the same before_script commands run against each environment (e.g. go version) you're using. I'm running against oldstable (the previous minor release), stable (the current release), and tip. Since go install pkg@version is new in go 1.16, I'll wait until go 1.15.x ages out, oldstable is 1.16.x, and stable is 1.17.x.

rsc

comment created time in a month

issue commentgolang/go

proposal: cmd/go: default to & improve -mod=readonly

I'm aware that there are workarounds. By "break" I don't mean to imply it's irreparable. My tests run against the previous minor release, the current release, and tip. I'll probably use GO111MODULE=off go install pkg and won't switch to go install pkg@version until after go 1.17 is released.

I understand the reason for this change and the behavior of the go tool is well documented in tip. However, as a longtime go user running tests against tip, minimally sophisticated enough to find the breaking change in the go tool, I'm here to tell you it's not intuitive that using go install to install a command would ever edit the go.mod.

Side note: Appending a version to switch to "global" mode isn't intuitive or consistent with other go commands either.

rsc

comment created time in a month

issue commentgolang/go

proposal: cmd/go: default to & improve -mod=readonly

Proposal feedback: My tests running against tip broke and I bisected to find dbde566219336e84360b4a38da10b5f63b19021e as the culprit.

TravisCI lets you specify before_script commands to run before your script/tests, which it executes with your repo as the working directory. One of my before_script commands is go install github.com/mattn/goveralls, which is used to push my coverage profile to coveralls.io but it isn't used by my module.

The new behavior (cannot find module providing package github.com/mattn/goveralls) is surprising. Admittedly, the old behavior of go install modifying your go.mod is also surprising.

I expect this will break a non-trivial number of users.

rsc

comment created time in a month

created tagabursavich/dynamictls

tagv0.2.0

DynamicTLS reconfigures TLS on filesystem changes.

created time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha 547f6b18e424d0876286248d2e74a6b5ef4e763d

migrate to vanity url

view details

push time in a month

delete tag abursavich/dynamictls

delete tag : v0.2.0

delete time in a month

created tagabursavich/dynamictls

tagv0.2.0

DynamicTLS reconfigures TLS on filesystem changes.

created time in a month

push eventabursavich/dynamictls

push time in a month

push eventabursavich/dynamictls

Andy Bursavich

commit sha 12896865a8f918f04d04b2f7dcfebc5b8ad089f6

internal/tlstest: update constraints

view details

Andy Bursavich

commit sha 845be3874f15bb610acefe08d33107bfe6b737aa

internal/tlstest: allow optional key instead of curve

view details

Andy Bursavich

commit sha aeee2560b66604dc9b1356695c27aeba6cc919ce

*: update dependencies

view details

Andy Bursavich

commit sha 440b2b85c3704ee91bb205382633ce56a27501bf

migrate to vanity url

view details

push time in a month

fork abursavich/go-import-redirector

HTTP server for a custom 'go get' domain

fork in a month

issue openedsirupsen/logrus

Add module casing change workaround to README

I've been bitten by this several times and it's always maddening, but it can be fixed with a module replace directive:

replace github.com/Sirupsen/logrus => github.com/sirupsen/logrus v1.6.0

It would be helpful to users if this hack was called out in the README.

created time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 01807a3fd04a40ab9733607f96c9d9444b9c7e30

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha ac17cba5c3d6b5c97458e4aa8b6a93843736da6c

wsheaders: Add package

view details

Andy Bursavich

commit sha df499a1a152a10e0245cfb041688e84af0bf8946

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 943daa34f770687f4c7d1f2daede1a4bbcb41836

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha e68215ab9dd0feac25d5ec38321b393e51352a55

httpheaders: Add package

view details

Andy Bursavich

commit sha f6a177e5a1e5fef65cbced6a6b38319ae1a2603e

wsheaders: Add package

view details

Andy Bursavich

commit sha e1a528e8efb6f8f2274f1e6a490f8e6fe84bc095

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha c705757eecf09b2451d7680d006ba9bf42d43708

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 606e9206174f2be19e44434baf026fae20627c4c

wsheaders: Add package

view details

Andy Bursavich

commit sha 8808d30dc0511ac063bdc16d2dc852cc752cbb93

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 740476c5afcbd1400363582b247fa416bd351f7b

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 99a67e76682852ecf23c4175cf19e268c615e518

wsheaders: Add package

view details

Andy Bursavich

commit sha c4d92586ebe1acfc8e746411d6faa32d5aae0442

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 8ecd5574b7d5fdedbe14cc4b84c94b3cf1c15fb4

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha a16977c5757ca3a0c09b40573215246844cb9651

wsheaders: Add package

view details

Andy Bursavich

commit sha 5fd6bb7fd39163f21599ade42e901150267d857f

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 16d7dc7d86b32250678b508d15ef77760bc96cbc

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 063599fbcc0837adf5e661035b7cf45a0a9db3b4

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 56182c543180f658021cf2e22a3c3b5e726ded95

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 2da2886cfc1ce029901a0b4d9e7228fe850e46b8

httpheaders: Add package

view details

Andy Bursavich

commit sha dbb973c54f1f93abc59ed1b26c806a4ae2bf4681

wsheaders: Add package

view details

Andy Bursavich

commit sha 8279c384761d842a6dcb811a041a05771a422e50

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha c7dca3ed45f8305367b663dfd551f8267035f770

wsheaders: Add Extensions

view details

push time in 2 months

pull request commentkubernetes/kubernetes

apiextensions: allow metadata description

ping

abursavich

comment created time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 3d95dda4c4fbf232f04723494edb4d0d9cf2ec4d

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 747fa7e04c28d287e2c8ecf6f4ff71923a898a01

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 000c7fe952a8ceae486ad522b851aa3e1b4867c5

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha a50fa818269422035ddac172ba7329356b921721

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 0e33c818025926574dfefd23cc0a909be339c7c3

httpheaders: Add package

view details

Andy Bursavich

commit sha d008573b00f0a8b9acc7bc2e96a7321e1b5de949

wsheaders: Add package

view details

Andy Bursavich

commit sha 200e919bb75c0e69f180e37820f6e70493881f71

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 2e881da22b339977c7af5f84526fa4325c2e3ac3

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 1255f8c6e4cc6a8ef651befeb6d8e13b20a1e90b

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 273438f555bf6487eee321ebf9a84ce10e24566c

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 6fdcefb5b14557d9c79fc947e43c3caf782cef4d

httpheaders: Add package

view details

Andy Bursavich

commit sha 4494347c09ac0175f09e51a40d170025c3b1bafb

wsheaders: Add package

view details

Andy Bursavich

commit sha d70e6aa5ce7af0695b87f7cebba7bbb2417fe930

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha ea6e18b75061fa219476f43c89554053e6fc1c47

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 6df41f0e6ff54199d4dea5290cda17c4e2acbbdd

httpheaders: Add package

view details

Andy Bursavich

commit sha 2cad11cfafdd5b6196c6b4dd7af59a741871aec9

wsheaders: Add package

view details

Andy Bursavich

commit sha df6ed4958086a5a24ecb19a4fc93fe4e3d059b22

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha a354984802fc3b0a93f4dbb5602bc6e36dc213f7

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 0baca481d25f03a0925c8ce93c32c82eeffa2593

httpheaders: Add package

view details

Andy Bursavich

commit sha 3ac8db7595baa9c49d59b215ac5e7d8aabbc1243

wsheaders: Add package

view details

Andy Bursavich

commit sha 4b21e2fc9dc8045ad83a5fb4988549f8bb78c11b

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha c661a15a4c665a8492215f8170c38ae3b6c8cc25

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 02acebb70366c50c8641c128824df9b1d7fc4aae

httpheaders: Add package

view details

Andy Bursavich

commit sha 6b2227676459f2668abe936e21d60fb878a8ace4

wsheaders: Add package

view details

Andy Bursavich

commit sha 63c286bded04b79d9353704b5dfb108048b2050a

wsheaders: Add Protocols

view details

Andy Bursavich

commit sha 4e524c4eb6a817ab8c98ecd48686e0a44754ef1d

wsheaders: Add Extensions

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha ee886fb31fb3499c1bde4f516342409b77369365

*: Reorganize various headers packages into httpheaders and wsheaders foo

view details

Andy Bursavich

commit sha d9e540acb9aef8e6222afb471fd416b359772b42

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 36f3dc37e8268cc6b6ee16881e8a96cf7540d3f8

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha 428c801d8774d5cddef550ce1e40039d5560d8c4

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha d51e1a824ee6b0d3dbeecfeadde65b6ed9b5a23a

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha 91415a90885357fa5a26bac915811ebdfc03f0f3

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 485e3f6e46556150a6ffc64564f3bdb84ad6fb59

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha 74ec4aa2c0d03a6c1d6d51e3e180fa9056d48300

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 04d2e0e261f23e2410de8187d97417bf2f534a14

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha c28ba669885ee7f3b1d96d0ccd5c87b0e3e53900

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 2f8b3dc2b847be615dd7b18b8492647112816b97

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha 2c63454046bb39139618ca68616b5d35700f3061

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 0f2a5d123c5c5d153e1e8069be4aeb1ce9966690

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha 621fa981135efd72fb379546d3e3ab3010d8080d

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha ee56fc8df38d5a1dc78f959296b916b476cad4cb

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha c0b8d0905fa141b7fcea146169c92c9916e679b6

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 143124db4e9cdb63b2fcbd108ddbecaff44a6690

headers: Add package

view details

Andy Bursavich

commit sha 720b65915a6af9f5b911b035a307986128aeb2dd

extensions: Add package

view details

Andy Bursavich

commit sha 8d6966952bb9c8aa3f14823a5a5f39c3c3bb080a

websocket: Use extensions package

view details

Andy Bursavich

commit sha b09f4a12272d80041dfdf7ac48bea772f487b48e

subprotocols: Add package

view details

Andy Bursavich

commit sha 28e76a10304e77d6348a6a87109b600462f75b41

websocket: Use subprotocols package

view details

Andy Bursavich

commit sha 28086c1aa29bc8cd07ed725e65b803f88f03a232

websocket: Use headers package

view details

Andy Bursavich

commit sha f515faf9da85a92d6688209abac20e7bdf3b630c

*: Reorganize various headers packages into httpheaders and wsheaders

view details

Andy Bursavich

commit sha c6f050fc1b143c91440ea0b3a7e019fc22eba436

httpheaders: Add tests

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 4cc187f5cfd93a625f05433d035fa94359848825

Reorganize headers packages

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 1c236b21409e0d5869a7e9034bbb50dd0637bf50

Use headers package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 39eb8e4a08d414c032584311439899c27eab4a73

Use subprotocols package

view details

Andy Bursavich

commit sha 11a2247f5a64b403222a92e50e395260917e569b

Use headers package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 3e3fdea2421fcd403d32d1650e0b3f98a5577c04

Use subprotocols package

view details

Andy Bursavich

commit sha 8ecd95ff1a39abb9cd29c17e6a501b3044b34c78

Use headers package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 6da0e92dac7f9a4897bc2e825832ddeb37045805

Add subprotocols package

view details

Andy Bursavich

commit sha b43cf62d5813d6bdfff831495173e4fa3a7ea072

Use subprotocols package

view details

Andy Bursavich

commit sha 7623e67ba4bcca5065a3ce51e5ea8ac4f0bab135

Use headers package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 29d22be771273c25f47264b6913e4c5eaed661f7

Add headers package

view details

Andy Bursavich

commit sha 425501f94bfd3d35ec3449f9466f8f93ea15c079

Add extensions package

view details

Andy Bursavich

commit sha 90a780d453a9d464d47dd1afa2016ba0b5c735f2

Use extensions package

view details

push time in 2 months

create barnchabursavich/websocket

branch : headers

created branch time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 07805bed8d65e76255d036f991d98143f06fd9c2

Add headers package

view details

Andy Bursavich

commit sha 224e2bbde7efd2e7fa00622b0689d0f6b7f753c6

Add extensions package

view details

Andy Bursavich

commit sha 7e19db5282633d81f7e17adc9046824785b71167

Use extensions package

view details

Andy Bursavich

commit sha feefc4ebef3ab50842295a751ee6e85531636355

Add subprotocols package

view details

Andy Bursavich

commit sha a5841ace6c76c53583cb493477bd6abc0f3eb95c

Use subprotocols package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 8c16c8b0cf1d58ed0e72bf4b46517840e4ea9b87

Extract common functions from extensions to headers package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 959eded674452061ee12357bce89cdb268ba8d29

Use extensions package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 87a8132c55b3866a2f549c45d71845d042ecb1cd

Add extensions package

view details

Andy Bursavich

commit sha 8844d63f3bdead79fa2a74875f33652b831b921d

Use extensions package

view details

push time in 2 months

push eventabursavich/websocket

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha b56fdc463da02592c7bbc889b79d1134f89df114

Use extensions package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha c7d1f86a11bf290c9afb17c0581ec1c1597dff0d

Use extensions package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 6aea1f4c4f4d81c0bc744d7b9941a1cae3c97a05

Use extensions package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 8fd8c2025754ba18fa42f8ee8e6cb24b5bcbc3c4

Add extensions package

view details

Andy Bursavich

commit sha 12d4ac10b877f6ed68915bf8ffa68707dbfb84a1

Use extensions package

view details

push time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha d809544c3b34305660ac0e49155751f3aaf0c8dc

Clone options See: https://staticcheck.io/docs/checks#SA4001

view details

push time in 2 months

pull request commentnhooyr/websocket

Make compression negotiation more more lenient

The RFCs allow for some strange formatting of the extensions. For instance, the parameter values may be quoted (e.g. server_max_window_bits="15"). I went ahead and implemented full parsing in a different branch. It's not necessary to fix the specific issue I ran into, but it's here if you're interested: https://github.com/abursavich/websocket/compare/compression...abursavich:extensions

abursavich

comment created time in 2 months

push eventabursavich/websocket

Andy Bursavich

commit sha 981771fa5a51b1ff91cf27c69c4be3cf43daaf3b

Add extensions package

view details

Andy Bursavich

commit sha 336fba9cdae66569d84586f9bae0f461b56f4a64

Use extensions package

view details

push time in 2 months

PR opened nhooyr/websocket

Reviewers
Clone options

opts = &*opts is a no-op.

See: https://staticcheck.io/docs/checks#SA4001

+24 -16

0 comment

2 changed files

pr created time in 2 months

create barnchabursavich/websocket

branch : options

created branch time in 2 months

more