profile
viewpoint
Bogdan Chadkin TrySound @realadvisor https://twitter.com/IAmTrySound Frontend-man! Love to Rollup and React. Gonna treeshake the world!

bvaughn/react-virtualized 20195

React components for efficiently rendering large lists and tabular data

bvaughn/js-search 1554

JS Search is an efficient, client-side search library for JavaScript and JSON objects

andreypopp/react-derivable 124

React bindings for derivable state computation library

ben-eb/postcss-svgo 85

DEPRECATED, see https://github.com/cssnano/cssnano | Optimise inline SVG with PostCSS.

ben-eb/postcss-zindex 77

DEPRECATED, see https://github.com/cssnano/cssnano | Reduce z-index values with PostCSS.

ben-eb/postcss-discard-comments 75

DEPRECATED, see https://github.com/cssnano/cssnano | Discard comments in your CSS files with PostCSS.

ben-eb/postcss-merge-rules 72

DEPRECATED (see https://github.com/cssnano/cssnano/tree/master/packages/postcss-merge-rules). Merge CSS rules with PostCSS.

ben-eb/css-values 58

Validate CSS property value pairs.

ben-eb/postcss-discard-duplicates 57

DEPRECATED, see https://github.com/cssnano/cssnano | Discard duplicate rules in your CSS files with PostCSS.

pull request commentmicromark/micromark

Replace browserify with rollup

Afaik browserify cannot handle es modules without transpilation. Rollup supports only es modules out of the box. Migrating to esm will allow to scope hoist utilities, constants etc and make them mangleable. Browserify will probably not be able to show such reduction.

Ps: Im on vacation for the next two weeks. Cannot rebase.

TrySound

comment created time in 21 hours

pull request commentbholloway/resolve-url-loader

[v4] upgrade postcss

Yeah, probably v4 can be released with just adjust loader upgrade and then v5 with new schema utils and postcss.

TrySound

comment created time in a day

pull request commentbholloway/resolve-url-loader

[v4] upgrade loader utils

Btw the new schema-utils requires node>=10.13. Though im on vacation. Cannot upgrade.

TrySound

comment created time in a day

push eventTrySound/emotion

Mateusz Burzyński

commit sha 3b2983917e68468153e54f4aeb802224c22a43d0

Upgrade Preconstruct

view details

Mateusz Burzyński

commit sha 5a73355ef3bf982bdbf01fa166c3bb5ee33f30a3

Downgrade Preconstruct to 1.1.29

view details

Mateusz Burzyński

commit sha 3abcf673d6d2ea8d802602dde1d5af33af75ac4c

`@types/jest` has been moved from the dependencies to the optional peer dependencies (#2043)

view details

Mateusz Burzyński

commit sha 6e157aa198ac32d326d1aa1a921f459d880a8428

Remove missing key error from production environments (#2042)

view details

Bogdan Chadkin

commit sha e004dc37270d6faf66e5a0568367a36c4e31cc83

Upgrade chalk and escape-string-regexp jest uses the new version of chalk without escape-string-regexp

view details

push time in 3 days

push eventrealadvisor/rgm

Bogdan Chadkin

commit sha fb1b87302f096604a31a59a0d503925cc442182f

Export more types

view details

Bogdan Chadkin

commit sha 5ecd07ab5f7575f9b84b89fd2d4b27e7f012e5bc

v0.1.3

view details

push time in 5 days

created tagrealadvisor/rgm

tagv0.1.3

Tiny (1kb less) but very powerful React Google Map

created time in 5 days

push eventrealadvisor/rgm

Bogdan Chadkin

commit sha 028915adf66f2235361507cd2a00daf7f9a58514

v0.1.2

view details

push time in 5 days

created tagrealadvisor/rgm

tagv0.1.2

Tiny (1kb less) but very powerful React Google Map

created time in 5 days

pull request commentcssinjs/jss

correct umd build fixes #1329

There are two changes in current pr

  1. convert all node_modules from commonjs to es modules
  2. import commonjs versions of babel helpers which has to be also converted to es modules

The second case is rather pointless and does not solve anything. The first case solves the issue with untranspiled "object-assign" package a dependency of prop-types.

sscaff1

comment created time in 6 days

issue closedfacebook/flow

upgraded

upgraded

Originally posted by @joe198 in https://github.com/facebook/facebook-android-sdk/pull/832#issuecomment-708694896

closed time in 6 days

joe198

pull request commentvercel/next.js

Auto enable React's new JSX transform on 17.x

Hi @Timer React just backported the new jsx transform to v0.14, v15 and v16. Is there a way to use enforce the new transform? https://github.com/facebook/react/releases/tag/0.14.10 https://github.com/facebook/react/releases/tag/v15.7.0 https://github.com/facebook/react/releases/tag/v16.14.0

Timer

comment created time in 7 days

pull request commentmicromark/micromark

Replace browserify with rollup

Here's per format sizes Browserify: 13602 b Rollup esm: 13585 b Rollup cjs: 13594 b Rollup umd: 13685 b

TrySound

comment created time in 7 days

PR opened emotion-js/emotion

Upgrade chalk and escape-string-regexp

<!-- Thanks for your interest in the project. I appreciate bugs filed and PRs submitted!

Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file).

Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file).

If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request

Please fill out the information below to expedite the review and (hopefully) merge of your pull request! -->

<!-- What changes are being made? (What feature/bug is being fixed here?) --> What:

Upgraded chalk and escape-string-regexp

<!-- Why are these changes necessary? --> Why:

Jest uses the new version of chalk and packages are duplicated in node_modules

<!-- How were these changes implemented? --> How:

yarn upgrade-interactive --latest

<!-- Have you done all of these things? --> Checklist: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->

  • [ ] Documentation
  • [ ] Tests
  • [ ] Code complete
  • [x] Changeset <!-- This is necessary if your changes should release any packages. Run yarn changeset to create a changeset -->

<!-- feel free to add additional comments -->

+25 -3

0 comment

5 changed files

pr created time in 7 days

push eventTrySound/emotion

Bogdan Chadkin

commit sha 99337dbbcccc3f35f0cc4f086d49d6e520c3fa18

Upgrade chalk and escape-string-regexp jest uses the new version of chalk without escape-string-regexp

view details

push time in 7 days

create barnchTrySound/emotion

branch : upgrade_sindres_packages

created branch time in 7 days

fork TrySound/emotion

👩‍🎤 CSS-in-JS library designed for high performance style composition

https://emotion.sh/

fork in 7 days

PullRequestReviewEvent

pull request commentjson5/json5

Migrate to named exports and provide node esm support

esm.js is used only for building proper exports in dist/index.mjs because generating exports from commonjs is not reliable and may change with rollup upgrade. I do not suggest to remove dist/index.mjs.

"module" is bundler specific field. "exports" is node specific way to support es modules natively. Probably only webpack 5 support them yet. https://nodejs.org/api/packages.html#packages_conditional_exports

Here's example https://unpkg.com/browse/nanoid@3.1.12/package.json

"browser" field should not just point to umd. Bundlers prefer "browser" field over over "module" when specified as a string. This makes "module" field useless in this case. See the correct use case for "browser" field https://github.com/visgl/react-map-gl/blob/master/package.json#L17-L25

TrySound

comment created time in 8 days

PullRequestReviewEvent

push eventTrySound/micromark

Bogdan Chadkin

commit sha daed70d8d857191d71990bea994918ea75151697

use const binding

view details

push time in 9 days

push eventTrySound/micromark

Bogdan Chadkin

commit sha 7d46ebdf427459e83fee5bde34458417439eac54

Fix lint

view details

push time in 9 days

pull request commentmicromark/micromark

Replace browserify with rollup

tinify is a set of optimisations around browserify + two passes of uglify. Btw I copy pasted it and passed to terser. Rollup does all optimisations out of the box.

TrySound

comment created time in 9 days

push eventTrySound/micromark

Bogdan Chadkin

commit sha f911c5b3be83b2a0f1763d22ec6870480575cd82

Down rollup versions and fix prettier command

view details

push time in 9 days

pull request commentmicromark/micromark

Replace browserify with rollup

Ah, and now it's in esm format, not cjs or umd.

TrySound

comment created time in 9 days

pull request commentmicromark/micromark

Replace browserify with rollup

Ah, I see. You are right. I though main points to lib/index.js. Well, then I guess rollup just produces more optimal code then.

TrySound

comment created time in 9 days

pull request commentmicromark/micromark

Replace browserify with rollup

lib was the input to browserify, not dist. So the size is grown a bit because of commonjs but we will achieve more optimisation after migrating to esm.

TrySound

comment created time in 9 days

issue commentjson5/json5

ESM `module` export differs from `main` export

Well, yeah, we can keep both until next major. AFAIK this may not work with newer rollup version. Safer to have separate entry point with explicit (not generated) exports. I reverted breaking changes here https://github.com/json5/json5/pull/241

lygstate

comment created time in 9 days

push eventTrySound/json5

Bogdan Chadkin

commit sha 81eaec97945a626688f76cd4778c064d230a5ca7

Save default export to avoid breaking changes

view details

Bogdan Chadkin

commit sha 9ce2c7f8644c44ceb11c58ce7c804ee082fb6709

Revert node bump

view details

push time in 9 days

pull request commentmicromark/micromark

Replace browserify with rollup

The reduction comes from stripped debug I guess. It was not stripped with browserify in configuration.

TrySound

comment created time in 9 days

pull request commentmicromark/micromark

Replace browserify with rollup

Actually I saw the same with browserify. Looks like something else prints code. Will check.

TrySound

comment created time in 9 days

issue commentjson5/json5

ESM `module` export differs from `main` export

It won't work with webpack 4 which supports only "module" field. Do you have any objections to use named exports instead? https://github.com/json5/json5/pull/241/files

I can migrate whole source to esm in the next PR if you want.

lygstate

comment created time in 9 days

PR opened micromark/micromark

Replace browserify with rollup

Browserify: 13602 b Rollup: 13585 b

Rollup is the best bundler to deal with es modules. In this diff I setup it before migrating sources to esm. Achieved size is the same.

The config will be reused to produce cjs/esm entry points.

<!-- Read the contributing guidelines.

We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it's up to you to convince us to land it.

If this fixes an open issue, link to it in the following way: Closes GH-123.

New features and bug fixes should come with tests.

P.S. have you seen our support and contributing docs? https://github.com/micromark/.github/blob/main/support.md https://github.com/micromark/.github/blob/main/contributing.md -->

+48 -3

0 comment

2 changed files

pr created time in 9 days

create barnchTrySound/micromark

branch : rollup

created branch time in 9 days

delete branch TrySound/micromark

delete branch : esm-test

delete time in 9 days

issue commentjson5/json5

json5 distrubte "module": "dist/index.mjs", hurt webpack

The issue is using the library in commonjs code which is bundled by webpack

// webpack resolves json5 with module field out of the box which lead to this usage
const json5 = require('json5').default

Though this does not work in node which does not have "default" field.

lygstate

comment created time in 9 days

issue commentapostrophecms/sanitize-html

load error: Cannot assign to read only property 'exports'

I'm aware this project is commonjs only and requires plugin to work with rollup. Bundling would lead to bloated bundles when some of dependencies are also used by the app. This is why bundling is not a solution.

gsar

comment created time in 9 days

issue commentbabel/babel

Babel 8 Release Plan

Hi, I found cases like <> ></> are not errors in flow. Could you please clarify if it's also forbidden? https://flow.org/try/#0JYWwDg9gTgLgBAKjgQwM5wEoFNkGN4BmUEIcA5FDvmQNwBQduEAdqvAMImTNbPwC8cABQBKOPwB8cAN504cSjACuUZnAA8UieoD0EugF8gA This lint errors fails there https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unescaped-entities.md

nicolo-ribaudo

comment created time in 9 days

PullRequestReviewEvent

Pull request review commentmicromark/micromark

Migrate tests to esm

+module.exports = require('character-entities')

I hope node team will backport stabilized json modules to node 12

TrySound

comment created time in 9 days

PullRequestReviewEvent

push eventTrySound/micromark

Bogdan Chadkin

commit sha df0c9e9aa4edcf51b1f6403c06a381be969e92af

Add flag to test-coverage

view details

push time in 9 days

PullRequestReviewEvent

Pull request review commentmicromark/micromark

Migrate tests to esm

 language: node_js node_js:-  - lts/dubnium

Erbium tests are passed :)

TrySound

comment created time in 9 days

push eventTrySound/micromark

Bogdan Chadkin

commit sha 2670fe53e1b0574ae7c6592cb78b014e4d8a7a60

Avoid using cjs to run in node 10

view details

push time in 9 days

Pull request review commentmicromark/micromark

Migrate tests to esm

 language: node_js node_js:-  - lts/dubnium

Erbium is passed.

dubnium works with --experimental-modules flag though .cjs extension is not supported when importing from .mjs. Anyway this should not affect node 10 users if you stick with es5. We just should not add .cjs proxies.

TrySound

comment created time in 9 days

PullRequestReviewEvent

push eventTrySound/micromark

Bogdan Chadkin

commit sha b6b069c197ad734cb5bb15a20d4b079139ec0446

Add mjs extension

view details

push time in 9 days

push eventTrySound/micromark

Bogdan Chadkin

commit sha 08c9538daa5706c2a4ffc9505399fbbd5f223c10

Fixes

view details

push time in 9 days

Pull request review commentmicromark/micromark

Migrate tests to esm

     "generate-size": "browserify . -p tinyify -s micromark -o micromark.min.js; gzip-size micromark.min.js; gzip-size --raw micromark.min.js",     "generate": "npm run generate-constant-typings && npm run generate-expressions && npm run generate-dist && npm run generate-size",     "format": "remark . -qfo && prettier . -w --loglevel warn && xo --fix",-    "pretest-fuzz": "patch-package --patch-dir script/patches; node script/generate-fixtures",-    "test-fuzz": "timeout 15m jsfuzz test/fuzz.js test/fixtures --rss-limit-mb 300 --timeout 300",-    "test-api": "node test",-    "test-coverage": "nyc --reporter lcov tape test/index.js",+    "pretest-fuzz": "patch-package --patch-dir script/patches; node script/generate-fixtures.mjs",+    "test-fuzz": "timeout 15m NODE_OPTIONS='-r esm' jsfuzz test/fuzz.js test/fixtures --rss-limit-mb 300 --timeout 300",+    "test-api": "node test/index.mjs",+    "test-coverage": "nyc --reporter lcov node test/index.mjs",     "test-types": "dtslint .",     "test": "npm run generate && npm run format && npm run test-coverage && npm run test-types"   },

It's probably the latest eslint behaviour

TrySound

comment created time in 9 days

Pull request review commentmicromark/micromark

Migrate tests to esm

+module.exports = require('character-entities')

https://nodejs.org/api/esm.html#esm_experimental_json_modules

TrySound

comment created time in 9 days

PullRequestReviewEvent

pull request commentluin/ioredis

Replace lodash.defaults with native Object.assign

Friendly ping @luin

TrySound

comment created time in 9 days

pull request commentnylas/nylas-nodejs

Avoid commonjs and circular dependencies

Friendly ping @Gerdie

TrySound

comment created time in 9 days

pull request commentchimurai/http-proxy-middleware

refactor: avoid using lodash where possible

Some tests errored with unhandled rejection when I debugged code. Promise should be returned there. Nothing need to return explicitly with async await btw.

TrySound

comment created time in 10 days

pull request commentchimurai/http-proxy-middleware

refactor: avoid using lodash where possible

Hi @@chimurai is this good to go?

TrySound

comment created time in 10 days

push eventTrySound/http-proxy-middleware

chimurai

commit sha f94b119ba4d5e59a6a9cd7eeb65906a7e874686c

ci(github-actions): lint and test (#466)

view details

chimurai

commit sha 5deee3f2862f2aaf5954768aeed2bf86310182ca

chore(deps): update devDependencies (#462)

view details

chimurai

commit sha c8cd3ced13314a401f1e41a01687cce5c280823f

chore(deps): upgrade mockttp (#467)

view details

chimurai

commit sha 3120f701f9b91ca0d6f32e1de5f1aaaa65520011

chore(deps): update dev dependencies

view details

chimurai

commit sha d5f4c2c665e4b4ab4fced917a69b66a718bb61a2

chore(deps): lodash 4.17.20

view details

chimurai

commit sha f212a047ef45898ce6053b622cada4b0617b9ddf

chore(package): v1.0.6

view details

Bogdan Chadkin

commit sha fa45902a3756d1d5f18866e4ed0ca65dae871fe2

Merge branch 'master' into avoid-lodash

view details

push time in 10 days

push eventTrySound/micromark

Bogdan Chadkin

commit sha bc22d3f7f0df3703416ebc43cf4f0c9bfa1d6037

Drop dubnium from travis

view details

push time in 10 days

pull request commentmicromark/micromark

Migrate tests to esm

Alright, I migrated tests to mjs extension. Though json modules do not work yet in esm so I added proxy .cjs modules to fix this. Fuzz tests does not work with native modules, I used "esm" to make it work.

Also looks like native esm does not work in node 10. Can I drop it?

TrySound

comment created time in 10 days

push eventTrySound/micromark

Bogdan Chadkin

commit sha eb0da9b29558b135480b14b6f105dfa83b87dd40

Migrate tests to mjs extension

view details

push time in 10 days

pull request commentmicromark/micromark

Migrate tests to esm

I'm not sure I follow this comment, if this affects only the tests, and source is not modified how would it impact the bundle size?

I migrated sources to esm locally

I'm cautious a lot of project are still on CJS, this sounds like it would drop CJS support entirely.

I meant only everything in this particular repository. I'm not gonna give up on commonjs users. Both cjs and esm will be distributed.

Would tools like: https://github.com/developit/microbundle, https://github.com/mikeal/limbo, or https://github.com/pikapkg/snowpack help here?

I'm gonna use rollup which is a base for all these tools.

TrySound

comment created time in 10 days

pull request commentmicromark/micromark

Migrate tests to esm

Btw native esm requires all index and extensions to be specified. So node test will not work. node test/index.mjs will.

TrySound

comment created time in 10 days

pull request commentmicromark/micromark

Migrate tests to esm

I mean it may take a couple of days to migrate everything. A bit easier than renaming.

TrySound

comment created time in 10 days

pull request commentmicromark/micromark

Migrate tests to esm

We can make it work later when everything will be migrated to esm. type: module would allow us to avoid mjs extension in source code. Is this ok for you?

TrySound

comment created time in 10 days

push eventTrySound/micromark

Titus Wormer

commit sha bf40f63bdd6841b31b896319233a42e130a879ce

Fix crash on EOL in html text declaration

view details

Titus Wormer

commit sha 6512f4f9d4f97375c562bec1711737d4fa6551a8

Fix crash on EOL in html text instruction

view details

Titus Wormer

commit sha 48d1ea4f8045cc86e523ced3a38efcca07a2f590

Fix hang in NUL-only string

view details

Titus Wormer

commit sha 8c0725b0bafe1270f9e2a5aeff0b23c5d4b62e36

Refactor to improve garbage collection

view details

Titus Wormer

commit sha 57647f2929b8a8fa9b742a7ddfd51e5f05d81b23

Add fuzzing tests Closes GH-18. Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>

view details

Titus Wormer

commit sha f5bc6ecb6c7f8861dc820f7eb984b9e2d2847512

2.10.0

view details

Titus Wormer

commit sha c66b51104a4fe6f29ee11f16808b21e4052832c3

Fix scripts

view details

Titus Wormer

commit sha a438145c46df5791f804ae9352e553737fa32a37

2.10.1

view details

Bogdan Chadkin

commit sha b2e9bf8304775fb38ec3f1e7cd85a477d35e6729

Migrate tests to esm I migrated sources to esm locally and output size with rollup is almost the same as with browserify. In this diff I only migrated tests to es modules and run them with the help of "esm" package. Later when everything will be migrated we can try to use native node support.

view details

Bogdan Chadkin

commit sha d84d2612179072b746cb96a07aea1b4c9b1558db

Add esm to fuzz tests

view details

push time in 10 days

CommitCommentEvent

PR opened micromark/micromark

Migrate tests to esm

I migrated sources to esm locally and output size with rollup is almost the same as with browserify.

In this diff I only migrated tests to es modules and run them with the help of "esm" package. Later when everything will be migrated we can try to use native node support.

<!-- Read the contributing guidelines.

We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it's up to you to convince us to land it.

If this fixes an open issue, link to it in the following way: Closes GH-123.

New features and bug fixes should come with tests.

P.S. have you seen our support and contributing docs? https://github.com/micromark/.github/blob/main/support.md https://github.com/micromark/.github/blob/main/contributing.md -->

+131 -204

0 comment

45 changed files

pr created time in 10 days

create barnchTrySound/micromark

branch : esm-test

created branch time in 10 days

fork TrySound/micromark

the smallest commonmark compliant markdown parser that exists; new basis for @unifiedjs (hundreds of projects w/ billions of downloads for dealing w/ content)

https://unifiedjs.com

fork in 10 days

pull request commentshellscape/webpack-plugin-serve

refactor: replace read-pkg-up with escalade

I enforced only squash commits at my work.

TrySound

comment created time in 10 days

pull request commentshellscape/webpack-plugin-serve

refactor: replace read-pkg-up with escalade

@bebraw Done

TrySound

comment created time in 10 days

push eventshellscape/webpack-plugin-serve

Bogdan Chadkin

commit sha a673c8cb2c54eb8513926b2907411d4d5fb6a0db

refactor: replace read-pkg-up with escalade Ref https://packagephobia.com/result?p=read-pkg-up read-pkg-up is quite big package with many dependencies. It solves cases not necessary for this project like pretty json errors and normalisation of package.json data. In this diff I replaced it with dependency-free escalade and parsed json with native JSON.parse. This will let users to have faster installation and less bloated node_modules.

view details

push time in 10 days

issue commentapostrophecms/sanitize-html

load error: Cannot assign to read only property 'exports'

As I already said works fine for me with basic setup. Webpack supports well interop between esm and cjs.

import sanitizeHtml from 'sanitize-html'
console.log(sanitizeHtml('<div>hello</div>'))
module.exports = {
  mode: 'production',
  entry: './index.js',
}
gsar

comment created time in 10 days

issue commentapostrophecms/sanitize-html

load error: Cannot assign to read only property 'exports'

@arcreative We would appreciate if you give us reproducible example. Bundling again is fast fix but not proper solution. Either webpack cannot handle something or some dependency incorrectly export stuff.

gsar

comment created time in 11 days

push eventshellscape/webpack-plugin-serve

Bogdan Chadkin

commit sha e4af01e0102449dd80d9bfe67196bea7a5c48210

Ignore missing and broken package.json cases

view details

push time in 11 days

push eventshellscape/webpack-plugin-serve

Bogdan Chadkin

commit sha aeda52965b683745b943ef051cf2ea4741ce878e

Remove tmp dirs

view details

push time in 11 days

push eventshellscape/webpack-plugin-serve

Bogdan Chadkin

commit sha 9d8a8b529e2764582a64558410552210998ac316

Remove logs

view details

push time in 11 days

push eventshellscape/webpack-plugin-serve

shellscape

commit sha bdc3fb4e06c4a0df13acedab607154193ad680d1

chore: npm audit fix

view details

shellscape

commit sha a381e104617ba94371ab5c21830795a8fe60ffa0

chore: bump nvmrc version

view details

shellscape

commit sha 6a919ef4f645d651fa959dcc60b62a4540b135d7

chore(release): 1.1.0

view details

Bogdan Chadkin

commit sha bda73692fc2d2b4012d45884c3104da081a8b30a

refactor: replace joi with superstruct (#188) * Replace joi with superstruct Joi has a poor documentation and hard to find changelog in issues. In this diff I migrated to suggested by @shellscape "superstruct" which does not have dependencies and simpler to extend. * Remove log

view details

Bogdan Chadkin

commit sha e52e137317f7dfa912e82e7c5faae83f76e9e4af

refactor: replace read-pkg-up with escalade Ref https://packagephobia.com/result?p=read-pkg-up read-pkg-up is quite big package with many dependencies. It solves cases not necessary for this project like pretty json errors and normalisation of package.json data. In this diff I replaced it with dependency-free escalade and parsed json with native JSON.parse. This will let users to have faster installation and less bloated node_modules.

view details

Bogdan Chadkin

commit sha dfc31801f784020619d943d5f08802a40e28fa7d

Fix escalade usage and tweak tests

view details

Bogdan Chadkin

commit sha 272ad3cf8fc9fb7afb3bca12db2ee0ca093e75ab

use arrow

view details

Bogdan Chadkin

commit sha 6680e2bcf89385a720225e74271c359fb7cb2ba5

Add test for empty package.json

view details

Bogdan Chadkin

commit sha 19569893b0dac63f834121f9bd5c861cc9e1e2e5

Update snapshot

view details

push time in 11 days

Pull request review commentshellscape/webpack-plugin-serve

feat: Add support for refreshing hmr on failure (work in progress)

 module.exports = {       compress: [boolean().allow(null)],       headers: object().allow(null),       historyFallback: [boolean(), object()],-      hmr: boolean(),+      hmr: [boolean(), 'refresh-on-failure'],

Should be union([boolean(), literal('refresh-on-failure')]) with superstuct.

bebraw

comment created time in 11 days

PullRequestReviewEvent

issue commentjson5/json5

json5 distrubte e "module": "dist/index.mjs", hurt webpack

Check this https://github.com/json5/json5/pull/241

lygstate

comment created time in 11 days

PR opened json5/json5

Migrate to named exports and provide node esm support

In this diff I added new entry point to compile es modules with named exports to solve this problem (https://github.com/json5/json5/issues/240).

It's a breaking change so we can drop legacy node support (newer versions of rollup and many other tools requires this) and add native node es modules support.

+21 -8

0 comment

5 changed files

pr created time in 11 days

create barnchTrySound/json5

branch : named-exports

created branch time in 11 days

fork TrySound/json5

JSON5 — JSON for humans

http://json5.org/

fork in 11 days

pull request commentmjmlio/mjml

Add mjml-preset-core package

You are right. I added deduplication logic to registerDependencies. registerComponent does not allow duplication. The point of this change is getting rid from global configuration so we could allow running mjml with different presets. This can be useful with custom components.

TrySound

comment created time in 11 days

push eventTrySound/mjml

Bogdan Chadkin

commit sha 3570530df78eb922341e3f18ff2f2398d8069bac

Deduplicate dependencies arrays

view details

push time in 11 days

issue commentjson5/json5

json5 distrubte e "module": "dist/index.mjs", hurt webpack

In this particular case technically these are named exports. There is no "primary" thing here and combining into single object does not solve any problem. If you will need single object use special syntax import * as JSON5 from 'json5'. https://github.com/json5/json5/blob/master/lib/index.js#L4-L7

lygstate

comment created time in 11 days

issue commentjson5/json5

json5 distrubte e "module": "dist/index.mjs", hurt webpack

Using named exports would solve all problems.

lygstate

comment created time in 11 days

push eventTrySound/mjml

Bogdan Chadkin

commit sha 765d9d509a682cf886dc4accd1ee0f8618012cd6

Fix lint

view details

push time in 11 days

push eventTrySound/mjml

Bogdan Chadkin

commit sha 9b7b2efe5a2db01d0a6635479142f81e12afb93f

Add mjml-preset-core package This is similar take to https://github.com/mjmlio/mjml/pull/1950 but preset is distributed as an object with components array and dependencies tree instead of register function. This allows us to pass this preset to mjml2html and maybe eventually get rid from globally mutated state.

view details

push time in 11 days

pull request commentmjmlio/mjml

Add mjml-preset-core package

сс @kmcb777 @iRyusa @DRoet

TrySound

comment created time in 11 days

PR closed mjmlio/mjml

Add mjml-preset package

Ref https://github.com/mjmlio/mjml/issues/1947#issuecomment-647006838

The new package includes all components and validations extracted from main mjml package.

Now mjml-cli can be migrated into mjml package to reduce complexity a little bit.

mjml-preset has registerPreset function which modifies global objects by calling registerComponent and registerDependencies. Though there might be a better and less side effectful way to define presets.

+146 -96

5 comments

6 changed files

TrySound

pr closed time in 11 days

PR opened mjmlio/mjml

Add mjml-preset-core package

This is similar take to https://github.com/mjmlio/mjml/pull/1950 but preset is distributed as an object with components array and dependencies tree instead of register function. This allows us to pass this preset to mjml2html and maybe eventually get rid from globally mutated state.

+166 -97

0 comment

8 changed files

pr created time in 11 days

create barnchTrySound/mjml

branch : mjml-preset-core

created branch time in 11 days

pull request commentmjmlio/mjml

Move js-beautify and html-minifier to cli

сс @kmcb777 @iRyusa @DRoet

TrySound

comment created time in 12 days

PR opened mjmlio/mjml

Move js-beautify and html-minifier to cli

Ref https://github.com/mjmlio/mjml/issues/1947

  • minify outlook conditionals unconditionally like merging
  • moved js-beautify and html-minifier to cli
  • deprecated "minify" and "beautify" options in mjml-core
+47 -17

0 comment

3 changed files

pr created time in 12 days

create barnchTrySound/mjml

branch : cli-dependencies

created branch time in 12 days

pull request commentAutomattic/juice

Upgrade commander

cc @jrit

TrySound

comment created time in 12 days

PR opened Automattic/juice

Upgrade commander

Ref https://github.com/tj/commander.js/releases/tag/v6.0.0

+14 -8

0 comment

3 changed files

pr created time in 12 days

push eventTrySound/juice

Jarrett Widman

commit sha 56e8fbc2854080626dee2cbf69008fe261fe6474

Merge pull request #367 from TrySound/upgrade-commander Upgrade commander

view details

Bogdan Chadkin

commit sha 3ec34d343d48bc839d0a2bc7e221c7fa5420af73

Upgrade web-resource-inliner Very small package now https://packagephobia.com/result?p=web-resource-inliner@5.0.0 Requires node 10+

view details

Bogdan Chadkin

commit sha 335ed19698a28ee2d65d8f7d1b577ee1db8ba0d8

Publish only necessary files in package To prevent publishing wrong files.

view details

Jarrett Widman

commit sha ef3a266dc6477efcb509f2e76c298e96869c45da

Merge pull request #369 from TrySound/published-files Publish only necessary files in package

view details

Jarrett Widman

commit sha 5d89c6e0899d5ec1a27bd6789e2d9202238f10d8

Merge pull request #368 from TrySound/upgrade-web-resource-inliner Upgrade web-resource-inliner

view details

Jarrett Widman

commit sha a62805199cdd4ea666c81ea5977a9839bf05ddd3

v7.0.0

view details

Jarrett Widman

commit sha 8614de551ba82a75da680026f6d2146da188ffb8

fix mistake in changelog

view details

Bogdan Chadkin

commit sha db9c391e7bb7da5c09317e42f777b5cdc1edd91a

Upgrade commander Ref https://github.com/tj/commander.js/releases/tag/v6.0.0

view details

push time in 12 days

PR opened jrit/web-resource-inliner

Upgrade htmlparser2

Ref https://github.com/fb55/htmlparser2/releases/tag/v5.0.0

cc @jrit

+25 -24

0 comment

2 changed files

pr created time in 12 days

more