profile
viewpoint

TLadd/apollo-typed-components 2

Generate typescript or flow Query and Mutation Components from queries.graphql files

hasithad/hackreal 0

Hackathon project

TLadd/ant-design 0

🌈 A UI Design Language and React UI library

TLadd/apollo-babel-types-fail 0

Example repo for error using apollo-cli to generate flow-types if you have a newer version of @babel/types installed

TLadd/apollo-client 0

:rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server

TLadd/apollo-tooling 0

✏️ Tooling for development and production Apollo workflows

TLadd/axios 0

Promise based HTTP client for the browser and node.js

TLadd/berry 0

📦🐈 The active development trunk for Yarn 2 ⚒

TLadd/create-react-app 0

Set up a modern web app by running one command.

issue commentprisma/prisma

Do not change order of columns in schema file based on DB column order

Yeah, we've been running into this too where multiple developers working on the same project will have a column or two in a different order and the introspection diff moves things around.

SharadKumar

comment created time in 3 days

issue commentprebid/Prebid.js

Force refresh userId

Closed by https://github.com/prebid/Prebid.js/pull/5819

TLadd

comment created time in 18 days

issue closedprebid/Prebid.js

Force refresh userId

Type of issue

Feature Request <!-- Is this a bug, feature request, question, etc.? Note if this is a documentation issue, please open a ticket here instead: https://github.com/prebid/prebid.github.io -->

Description

<!-- Describe the issue --> I would like for there to be a way to force refresh userId values. Currently, if I update a stored userId value in a cookie or localStorage, that new value will get pulled in on future page loads, but not the current one. The old value remains since submodules only get initialized once, which is when these values are read.

The use cases I have where this would be useful all boil down to being able to provide a better id sometime after the initial page load. For instance, after a user logs in, I can get a better identifier than was previously stored and I want to start using it in bids without refreshing the page.

I would propose something along these lines:

interface RefreshUserIdsOptions {
  // When performing the refresh, should it take the stored value, or force overriding it.
  // If the new value was written to the cookie/localStorage, it wouldn't be necessary to call `getId`.
  // True if you want to override the stored value and call `getId`.
  overrideStoredValue: boolean,
}

pbjs.refreshUserIds(options: RefreshUserIdsOptions)
pbjs.refreshUserId(name: string, options: RefreshUserIdsOptions)

closed time in 18 days

TLadd

push eventTLadd/Prebid.js

Neelanjan Sen

commit sha 16fabf4cb78daaa16ac16c3ea6c0def06fa8df9b

Appnexus: Add omid support (#5821) * basic implementation complete * add unit tests * remove redundant field tags[].video.frameworks

view details

Ben Anderson

commit sha f907ee6f4312c889bc41b22bd7b44026c7b40302

new userId module - neustar's fabrick (#5802) * submitting userId module for neustar's fabrick - https://www.home.neustar/fabrick * fixing 'gulp test' errors * fixing another test issue (related to ie) * removing another (last) repeat * - expose full user id config (including storage) to user id modules (#5803 - removing TODO from test * - updates to test Co-authored-by: Anderson, Ben <Ben.Anderson@team.neustar>

view details

René Baudisch

commit sha c57bab724b683bbe0efc9dd8de87ad8db332c946

Integrate option to pass clickThrough urls to renderAd method (#5796) * adding options to renderAd method * adding replaceClickThrough method to utils * implemented replaceClickThrough method in render ad to enable ssps adding url param clickthrough for publisher side counting * update to cover some validation and unit tests as requested by harpere * adding unit test for clickthrough implementation;

view details

Hugo Duthil

commit sha ba1a35c56405d1d1ee4a901ba173cba32578652c

Add credentials and explicit options to CriteoIdSystem (#5822) Co-authored-by: Hugo Duthil <h.duthil@criteo.com>

view details

guiann

commit sha e082c83adce4fd198fa0c8d4be6d1fe6caf7cb29

AdYouLike bidAdapter - Add information in bid request (#5828) * Remove useless bidderCode in bid response * send all the available sizes in the bid request * Use the banner sizes if given * avoid compatibility issue with old bid format * ad iframe and publisher domain paramters to bid requests * add publisher domain info in ad request * add a check in unit tests for publisherDomain * encode uri components Co-authored-by: Guillaume <guiandouard@gmail.com>

view details

Matt Kendall

commit sha 84e7121f2b025d049eb5da39f31755feb94a5591

4.11.0 release

view details

Matt Kendall

commit sha 752bd2713d746543b8e66d572459e8b6c1b43089

4.12.0-pre

view details

Renzo Toscani

commit sha 7d2709523afafad9e3ca91c2bd9477006df9f971

IDx user id submodule (#5826) * add idx user id * Update modules/idxIdSystem.js to match new SubmoduleConfig param Co-authored-by: Scott <smenzer@gmail.com> Co-authored-by: Scott <smenzer@gmail.com>

view details

liranbaruch

commit sha ab4f80a9f129614f9d23c4fc2c0a686dde58ab44

Adding Test mode for the IronSource bidder (#5831) * Change ironsource to be lower case all over code * Add test mode to the IronSource bidder

view details

Gena

commit sha 32495f9b91f3e0eb29fc8c8fc2ea226ec9c9bedd

Adtelligent: Add new alias (#5825)

view details

hamper

commit sha 844999459c5ee0ec2836a6056f2ed07071d8089e

Add vuukle adapter (#5773) * add vuukle adapter * add readme * doc: add email

view details

tadam75

commit sha b6bfbef1db6c4533a0a40cf61490d47022df2b37

Handling video outstream in smartadserver adapter. (#5739) * Handling video outstream in smartadserver adapter. * Fixing the outstream example with the queue handler. Co-authored-by: tadam <tadam@smartadserver.com>

view details

Jakub Dlouhý

commit sha e39a812bb7c151b7ffeb835034bf055d041ba2d1

add stroeerCoreBidAdapter (#5830) * add stroeerCoreBidAdapter * test correction * refactroring * add gvl id to spec Co-authored-by: Jakub Dlouhý <jakub.dlouhy@ibillboard.com> Co-authored-by: karel koule <koulekarel@gmail.com> Co-authored-by: Lukáš Havrlant <lukas.havrlant@gmail.com>

view details

Niksok

commit sha ad41a193d05957f42eac56dd8b6772c328647cbd

Added the ability to send multiple bids in one ad request for mediaforce bid adapter (#5834) * Added the ability to send multiple bids in one ad request for mediaforce bid adapter * Fixes after review for mediaforce bid adapter

view details

Thomas Ladd

commit sha 79ce53a6cffef26058323ca19c4c3e126a97a2f1

Merge branch 'master' into force-refresh-user-id

view details

push time in 18 days

push eventTLadd/prebid.github.io

Thomas Ladd

commit sha 4a6566d21bea783369460af8a15b1f52637324e6

Remove `=> undefined` from refreshUserIds title

view details

push time in 23 days

pull request commentprebid/Prebid.js

Force refresh userId

@Fawke Merged in master and opened a docs PR https://github.com/prebid/prebid.github.io/pull/2402

Re the zeotap test changes: So the history here is that the zeotap tests were modified to mock cookie storage in https://github.com/prebid/Prebid.js/pull/5758 because the tests were sporadically (but fairly regularly) failing in the Edge browsers. Prior to merging in #5758 to this branch, I dug into what was going on in these tests and discovered that the failures were related to the zeotap tests setting an expiration on the cookie. I was logging document.cookie at various points in the test and saw the cookie of interest disappearing at inconsistent points. None of the other userId submodules do this and removing the expiration seems to have fixed the flakey tests (they haven't failed since).

So then the question becomes if we want to continue mocking cookies in these tests when we have another fix available. Expressed my thoughts here; the tldr is that I think mocking cookies is asking for trouble and diminishes the value of the tests. This restores the zeotap tests to being consistent with the other userId submodule tests but does run in direct opposition to https://github.com/prebid/Prebid.js/issues/5762.

TLadd

comment created time in 24 days

PR opened prebid/prebid.github.io

Docs for refreshUserIds publisher api method

Relates to https://github.com/prebid/Prebid.js/pull/5819

Screen Shot 2020-10-07 at 8 58 26 AM

+25 -0

0 comment

2 changed files

pr created time in 24 days

create barnchTLadd/prebid.github.io

branch : trl/refresh-user-ids-docs

created branch time in 24 days

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 5ec24de2c3f43e53420a0b94b58d9f71329bc3ee

Merge remote-tracking branch 'origin' into force-refresh-user-id.

view details

push time in 24 days

fork TLadd/prebid.github.io

Repo that controls Prebid.org website

http://prebid.org

fork in 24 days

push eventTLadd/Prebid.js

Robert Ray Martinez III

commit sha b5cf481ec8ba56c43915b78b1a67c6717bf4c676

remove digitrust from rubicon bid adapter (#5798)

view details

Maxime Lequain

commit sha ca22a45991077d4dc5fa87582568b3eb94236982

add native preset handling and automatic price macro replacement (#5807) Co-authored-by: Maxime Lequain <maxime.lequain@adotmob.com>

view details

Robert Ray Martinez III

commit sha 664ec3bbc72d06d20e3f0cdc581cb386ef89ca23

fix some video request params (#5799)

view details

Scott

commit sha aa1e5e3b1f9025c97d18a633c147c91af15e9b6e

expose full user id config (including storage) to user id modules (#5803) * expose full user id config (including storage) to user id modules, rather than just the params object * update docs to `SubmoduleConfig` * more doc fixes * missed one doc

view details

Baptiste HAUDEGAND

commit sha ea498f97d0a0f874d1df5e32c50f868600ada2d8

Fix timeToFirstByte unit test (#5820) * Debug timeToFirstByte unit test * review

view details

bretg

commit sha 8982e0904fde99454f4c10985ea46d019b683e5c

rubicon: adding pubcid support (#5824) * rubicon: adding pubcid support * adding to orderedParams * removed eids filter so all eids will be supported * fix eids test * fixed eids assertions Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com>

view details

Thomas Ladd

commit sha 97aa0afa70d2ea050334432b8a4a7fb9291cdf70

Merge remote-tracking branch 'origin' into force-refresh-user-id

view details

push time in 24 days

push eventTLadd/Prebid.js

Robert Ray Martinez III

commit sha b5cf481ec8ba56c43915b78b1a67c6717bf4c676

remove digitrust from rubicon bid adapter (#5798)

view details

Maxime Lequain

commit sha ca22a45991077d4dc5fa87582568b3eb94236982

add native preset handling and automatic price macro replacement (#5807) Co-authored-by: Maxime Lequain <maxime.lequain@adotmob.com>

view details

Robert Ray Martinez III

commit sha 664ec3bbc72d06d20e3f0cdc581cb386ef89ca23

fix some video request params (#5799)

view details

Scott

commit sha aa1e5e3b1f9025c97d18a633c147c91af15e9b6e

expose full user id config (including storage) to user id modules (#5803) * expose full user id config (including storage) to user id modules, rather than just the params object * update docs to `SubmoduleConfig` * more doc fixes * missed one doc

view details

Baptiste HAUDEGAND

commit sha ea498f97d0a0f874d1df5e32c50f868600ada2d8

Fix timeToFirstByte unit test (#5820) * Debug timeToFirstByte unit test * review

view details

bretg

commit sha 8982e0904fde99454f4c10985ea46d019b683e5c

rubicon: adding pubcid support (#5824) * rubicon: adding pubcid support * adding to orderedParams * removed eids filter so all eids will be supported * fix eids test * fixed eids assertions Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com>

view details

push time in 24 days

PR opened recombee/node-api-client

Update response-error.js docs

Correct descriptions for request and statusCode fields.

+2 -2

0 comment

1 changed file

pr created time in 25 days

push eventTLadd/node-api-client

Thomas Ladd

commit sha 7fc05eec00b64c904db32e7b4d904dff2575f7f5

Update response-error.js Correct descriptions for request and statusCode fields.

view details

push time in 25 days

fork TLadd/node-api-client

Node.js client for easy use of the Recombee recommendation API

fork in 25 days

pull request commentprebid/Prebid.js

Added global function for refreshing user id's

@smenzer Yep, sure enough, the same failures were happening on master before that PR that mocked writing to cookies: https://app.circleci.com/pipelines/github/prebid/Prebid.js/2130/workflows/efbe4e02-8090-41ea-a517-adef33a6410a/jobs/9900.

I've created https://github.com/prebid/Prebid.js/pull/5819 that merged the latest master and removes the mocking, as it is no longer necessary after removing the expiration time on the cookie. I'm generally of the philosophy that mocking should be avoided unless they make tests easier to write/maintain and don't diminish the value of the test significantly. In this case, the tests aren't easier to write and assuming cookies work in the tests, I think that does provide some value to the tests. There are a lot things that can go wrong with cookies. Trying to write a unit test suite for cookie storage that covers every possible thing that could go wrong within Prebid would be really hard. Even if you did have such a suite, mocks can be set incorrectly and behave differently than reality. Part of the reason to bother running these tests in multiple browsers I assume is to catch browser-specific behavior, which you don't get when mocking browser API's.

Just my 2 cents on the matter; as I said in #5819, I can easily go back to the mocking solution if that's preferred.

coryhammon1

comment created time in a month

PR opened prebid/Prebid.js

Force refresh user

Continuation of #5758

Type of change

  • [ ] Bugfix
  • [ x] Feature
  • [ ] New bidder adapter
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • [ ] Other

Description of change

Added a global function to refresh user id's after initialization on page load. This seems to be the simplest way to get this functionality without adding more complexity into the user id module itself. Essentially, the function triggers a reinitialization of all user id modules, so if there were any changes to the stored values after page load, those new values will be included in the any bid requests.

In addition, I removed the mocking of storage from the zeotap test. I was running into test failures because the original PR branch was not based off of the current master. I ended up digging into the sporadically failing tests in Edge before it being pointed out that it had been fixed by mocking storage in https://github.com/prebid/Prebid.js/pull/5758. It looks like removing the expiration time also resolves the issue and IMO is preferable, so I left it as is. Can go back to the mocking situation if that's the direction y'all want to go.

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • [ ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

  • A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

#5683

+233 -66

0 comment

3 changed files

pr created time in a month

push eventTLadd/Prebid.js

Harshad Mane

commit sha 1704572233d736fef19f6f92a2c5162ec07eb19f

PubMatic BidAdapter: pass auctionId as default value for wiid param (#5744) * added support for pubcommon, digitrust, id5id * added support for IdentityLink * changed the source for id5 * added unit test cases * changed source param for identityLink * pass auctionId as default value for wiid param in pubmatic adpater external call

view details

Anthony Lauzon

commit sha 30a069ccd46ff2acf51d2794ab2c1adace0d7e88

Audigent HaloID User Id System Module (#5524) * audigentRtdProvider * fix line error * fix tests * deep equal test fix * conditionally set data in html5 local storage, add markdown readme * add integration test instructions to audigent readme * halo id update * add halo id to userid hpt example, submoduleparams check * haloId submodule update * remove script tag from haloid submodule * add eid tests * update docs * merge upstream master * name update * url update, name update * eid test update * remove getIds * remove unused import * style update * remove erroneous chars * remove comments * fix updated tests * fix id count check placement * style update * style update in eids.js * trailing space fix * documentation update

view details

TheMediaGrid

commit sha 7da0521e53c087fadd9982d02a757be89ccbbb89

Fix typo in TheMediaGrid Bid Adapter (#5589) * Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter

view details

Hugo Duthil

commit sha 183ff52bd62f53bda4b5f6929bcf4be94207a026

Check localstorage availability before accessing it (#5616) * Check localstorage availability before accessint it * Fix UTest for IE11 * Restore window.localStorage property descriptor after each test Co-authored-by: Hugo Duthil <h.duthil@criteo.com>

view details

Mirko Feddern

commit sha f61be0c11dff0de23c2cdc5527940eb9cda9e187

Add Supply Supply Chain Object Module support for Yieldlab Adapter (#5521) * Add Supply Chain Support for Yieldlab Adapter * Add minor changes based on PR comments * Make createSchainString method leaner (additional input from PR review)

view details

bjorn-lw

commit sha cb733da7ff1aa25938266408bcc55a46ba3b4cfd

Livewrapped support for video (#5724) * Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * modified how gdpr is being passed * Added support for Publisher Common ID Module * Corrections for ttr in analytics * ANalytics updates * Auction start time stamp changed * Detect recovered ad blocked requests Make it possible to pass dynamic parameters to adapter * Collect info on ad units receiving any valid bid * Support for ID5 Pass metadata from adapter * Typo in test + eids on wrong level * Fix for Prebid 3.0 * Fix get referer * http -> https in tests * Native support * Read sizes from mediatype.banner * Revert accidental commit * Support native data collection + minor refactorings * Set analytics endpoint * Support for app parameters * Fix issue where adunits with bids were not counted on reload * Send debug info from adapter to external debugger * SChain support * Send GDPR data in analytics request * video support Video support

view details

yuvalgg

commit sha 04ea60324e3750c442fb98ed2f0d665b3c2969e9

Intentiq id value change (#5746) * Intent iq id to use plain id string * getId from http resp as a string instead of as a json object * getId from http resp as a string instead of as a json object

view details

Mehmet Can Kurt

commit sha 298139f0ad4c81f85164a8e97f7b2c0b4a993ef4

add quantcast ID submodule (#5727) * add quantcast ID submodule * use setCookie in test * add comment for consent signals

view details

Neelanjan Sen

commit sha bce32dcd59f6130fcffaa7d603e66f04a953ac0b

upgrade ci resource (#5725)

view details

Robert Ray Martinez III

commit sha 140a67cc8dc3d6a8edfec7566bb1ba4f714074db

Rubicon analytics v2 (#5698) * temp check in * add * dev almost done * add rule name to payload * update rubi analytics tests * add functionality to mock gpt * revert analyticsAdapter update * minor cleanup * handle edge cases more gracefully * logic for when cookies not enabled new param `channel` tests * use timeToRespond if available on bidResponse * Updating with review comments

view details

Dan

commit sha fd9a0d4cf2a1dfffca231dd8a6c17835bb5d49a1

Add gdpr support to ablida bid adapter (#5741) * add onBidWon function, add bidder adapter version to bid requests * add support for native * use triggerPxel instead of ajax, because ajax was called 3 times with native * add gdpr consent to bid requests * update tests

view details

adxpremium

commit sha a3aa5f4d14e983385741e0610722435bb01a33a1

added onBidWon event (#5679) * added onBidWon event * luponmedia onBidWon event + test * luponmedia onbidwon event + unit test * luponmedia onbidwon event + test * luponmedia onbidwon + unit testing * luponmedia onbidwon event + unit tests * luponmedia onbidwon event ajax * package-log revert

view details

Danny Khatib

commit sha 94520501afcd82282a8c7832a3c7946012f9b870

mapping spotx dealid to bid object (#5745) Co-authored-by: Danny Khatib <dk2020@Dannys-MacBook-Pro.local>

view details

Robert Ray Martinez III

commit sha bfb182a47cd2cce1fb7fbfe73513090786515b02

fix broken unit tests for zeotap (#5758)

view details

Neelanjan Sen

commit sha a2c6128ab1905188801bbefb8a9ee66bc8b84ce7

Add guideline to check for GVL ID (#5757)

view details

Monis Qadri

commit sha 172980b2f1efcc4dc73adad618ca6061f23b96b2

Added instream BID_WON tracking (#5481) Co-authored-by: monis.q <monis.q@media.net>

view details

gpolaert

commit sha db225e90acbeed41fc519ae040b501391acc2ed7

feat: add getEvents method to the public API (#5703)

view details

robertrmartinez

commit sha 5911c6eedfee71e7868a62df279d1b3f2b3c2903

Prebid 4.8.0 Release

view details

robertrmartinez

commit sha cd4d0d84cc7913985b3503d49e3da08c615ac845

Increment pre version

view details

方思敏

commit sha 89d829fd672bd5da74e438a87b2e7cbd8680b342

【MediaGoBidderAdapter】notify server if the page is secure and check match size (#5753) * notify server if the page is secure * remove undefined initial Co-authored-by: fangsimin@baidu.com <fangsimin@baidu.com>

view details

push time in a month

push eventTLadd/Prebid.js

Aleksandr Štšepelin

commit sha 1df6a22650037fdfb4606e8296dc86e56441b5fb

cointrafficBidAdapter: added support responding in different currencies (#5800) * New adapter "Cointraffic" added * removed mobile detection * The sizes property has been updated, added supportedMediaTypes. * feat: added support responding in different currencies * change: module description

view details

Monis Qadri

commit sha 303ccaee3e190b3bea50a50b8eb75460e9922818

Send proper slot info in case of adUnitPath (#5810) - using `getGptSlotInfoForAdUnitCode` to get `divId` in case of `adUnitPath` - added test case for visibility via `adUnitPath` Co-authored-by: monis.q <monis.q@media.net>

view details

mmoschovas

commit sha c1c6aaad95c51761aa00c21c0b6d733c31c76bb9

Update to rubiconBidAdapter to include criteoId support (#5806)

view details

jsnellbaker

commit sha 804ff2fadff746d98e3484051852c65fb5769b7f

appnexus bid adapter: criteo back to tpuids (#5808)

view details

yuvalgg

commit sha 907a9c7bac5f3f400d68ee7e980356d879f5d0d3

Intentiq id add validation (#5797) * Add validity check to ignore not-available response * Added tests * Added error log

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 8df0ef44c18c90a227b1bc6ef57a069ea82a8a24

Remove zeotapIdPlus expiration on cookie in test because it caused it to intermittently fail

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 8b1975246b672628e3d2f410cf8a0b80c8ba55f7

Remove zeotapIdPlus expiration on cookie in test because it caused it to intermittently fail

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 902cf672d36c616ae2a505065c91879448762d8e

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 8161c0d016e49d248ce88022ac0f7fd2f76db2ae

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 85508114d3ea00bc93236fa8f67021528155e6d4

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha f2c067b7be0dddf0f307e609149c54705622c2f0

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha a74d6fb5ae9ed703bcb48070a94ca479350b8b66

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 448222799c7aa7b0f5bbed68b94ec30ed0780b0c

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha c77fb74b344b236d27b00ba4a0401c1f68301bd1

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 1a524a48a157c9472121c5eb453aa050deed5afa

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 037a155969f039b6929e01e6bc92df632f2cba13

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha a67765d1d58ab1ad7960d94cc9691585ee087cbe

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 829f0b924107d02f1d81ed9222a2b2d688af6c2e

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha afcdcc44ec7bc3c73e6245076c2502d96f815b02

Debug console.logs for failing tests.

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 8d543085f37c27f2aaa2ac46982279c1745f8588

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha d84503475ceb0851e71627f188af29e791bab9f6

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 2f97ae93b7dc27c40139cc05fbdf61e2d96714a9

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 724d795450767866c40f4dc72fb66ef87303b13c

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha ce2e7a37ca17d87c066e4b83ad1815390e2ea40b

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 4b2eac0904c57a78c4d55f087879ba3044920f71

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 73332b050268dbfa06dd2c3c0e3081e22dc77521

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha d94297f0f5cd7a156b8188a0131e6979679d7f95

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha 4418db7d7f4811217de2be118d366d568eed4531

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha f5ef5785c333164d1eb4bf754ce89ae5683b8454

Debug console.logs for failing tests

view details

push time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha ec06b2b2b13489502a05cf773be3618a0d4ebb0f

Test callback in refreshUserIds test

view details

push time in a month

pull request commentprebid/Prebid.js

Added global function for refreshing user id's

tests feel a bit light, can we add some about which submodules get refreshed based on what you pass in, etc.?

@TLadd could you add a test (or edit one of the existing ones) to cover the refreshUserIds() callback, please? once that's done I'll merge. thanks!

Added that here: https://github.com/prebid/Prebid.js/pull/5815

coryhammon1

comment created time in a month

PR opened prebid/Prebid.js

Test callback in refreshUserIds test

Test requested for https://github.com/prebid/Prebid.js/pull/5752#issuecomment-701960881

+3 -1

0 comment

1 changed file

pr created time in a month

push eventTLadd/Prebid.js

Thomas Ladd

commit sha b5070ebf73dbd416ba2cc9a32cf19cf860dda1da

Test callback in refreshUserIds test

view details

push time in a month

fork TLadd/Prebid.js

Setup and manage header bidding advertising partners without writing code or confusing line items. Prebid.js is open source and free.

http://prebid.org

fork in a month

Pull request review commentprebid/Prebid.js

Added global function for refreshing user id's

 function getUserIdsAsEids() {   return createEidsArray(getCombinedSubmoduleIds(initializedSubmodules)); } +/**+* This function will be exposed in the global-name-space so that userIds can be refreshed after initialization.+* @param {String[]} submoduleNames submodules to be refreshed+*/+function refreshUserIds(submoduleNames) {

Would we want submoduleNames to be optional, with it defaulting to refreshing all submodules? I brought up passing in the submodule names because my particular use case only requires refreshing one or two userId modules, but refreshing all might still be a useful default? If we do end up making submoduleNames optional, I would suggest making the argument to refreshUserIds an object so it would be easy to pass additional arguments down the line in a non-breaking way.

Note this is mostly a question. It may be the case we want to keep it the way it is with submoduleNames being required.

coryhammon1

comment created time in a month

PullRequestReviewEvent

Pull request review commentprebid/Prebid.js

Added global function for refreshing user id's

 function getUserIdsAsEids() {   return createEidsArray(getCombinedSubmoduleIds(initializedSubmodules)); } +/**+* This function will be exposed in the global-name-space so that userIds can be refreshed after initialization.+* @param {String[]} submoduleNames submodules to be refreshed+*/+function refreshUserIds(submoduleNames) {+  if (!utils.isArray(submoduleNames)) {+    return;+  }++  if (!initializedSubmodules) {+    utils.logWarn(`${MODULE_NAME} - refresh called before submodule initialization`);

I would have expected this method to initialize the submodule if it has not already been initialized. Otherwise you might end up with race conditions where you need to wait for a first bid to occur before you can call this method.

So I would expect this not to return early here. Instead of iterating over initializedSubmodules below, I would iterate over userIdModules and filter by the name.

coryhammon1

comment created time in a month

PullRequestReviewEvent

issue openedgraphql-nexus/nexus-plugin-prisma

Specifying AND/OR in filtering config for `t.crud` warning and incorrect type

If I specify something like this:

    t.crud.sites({
      filtering: {
        AND: true,
        OR: true,
        domain: true,
        createdAt: true,
        updatedAt: true,
      },
    });

TypeScript says this is fine, but I get warnings from nexus when I generate stating:

Your GraphQL `Query` object definition is projecting a relational field `sites`. On it, you are declaring that clients be able to filter by Prisma `Site` model field `AND`. However, your Prisma model `Site` model has no such field `AND`
Your GraphQL `Query` object definition is projecting a relational field `sites`. On it, you are declaring that clients be able to filter by Prisma `Site` model field `OR`. However, your Prisma model `Site` model has no such field `OR`

The output type looks like this:

input QuerySitesWhereInput {
  AND: [SiteWhereInput!]
  createdAt: DateTimeFilter
  domain: StringNullableFilter
  OR: [SiteWhereInput!]
  updatedAt: DateTimeFilter
}

So the AND/OR make it into the schema, but I would expect them to be of type QuerySitesWhereInput instead of SiteWhereInput. If I'm looking to exclude certain fields from filtering, I would expect them to be excluded when combining multiple filters as well.

So I believe the correct behavior would be when specifying AND/OR for filtering in t.crud:

  • Do not emit a warning
  • The type for AND/OR should be [${name-of-input-contained-within}!]

created time in a month

issue openedgraphql-nexus/nexus-plugin-prisma

CRUD list with connection-style result and arguments

I want to be able to combine the power of CRUD's configuration to automatically add filtering and ordering arguments based on my schema with the a pagination style more similar to what t.connectionField from @nexus/schema produces. With t.crud's output, I miss not having PageInfo to let the client know if there are additional results or getting a total count depending on the particular case. I also prefer t.connectionField's opaque string after param that is consistent across connections vs the one t.crud generates based on the schema. t.crud's is more flexible surely, but requires more knowledge on the client.

Anyways, the point is not really the merits of one pagination strategy vs another, but I think rather that it would be helpful if the pagination strategy (arguments accepted when using t.crud and type of the result) were customizable.

I was able to futz around and figure out a way to get largely what I want in a not-so-ideal way:

const Query = objectType({
  name: "Query",
  definition(t) {
    t.crud.sites({
      ordering: {
        createdAt: true,
        domain: true,
        updatedAt: true,
      },
      filtering: {
        domain: true,
        createdAt: true,
        updatedAt: true,
      },
    });
  },
});

const sitesQueryField = queryField((t) => {
  t.connectionField("sites", {
    type: Site,
    disableBackwardPagination: true,
    additionalArgs: {
      orderBy: arg({ type: "QuerySitesOrderByInput" }),
      where: arg({ type: "QuerySitesWhereInput" }),
    },
    async nodes(_root, args, ctx) {
      return ctx.prisma.site.findMany({
        ...convertRelayToPrismaPaginationArgsIdCursor({
          first: args.first,
          after: args.after,
        }),
        orderBy: stripNull(args.orderBy || { createdAt: "desc" as const }),
        where: args.where ? stripNull(args.where) : undefined,
      });
    },
    cursorFromNode(node) {
      return `cursor:${node.id}`;
    },
  });
});

So in the above, I'm basically using t.crud to generate the ordering and filtering parameters for me, and then overwriting the query with t.connectionField and adding where and orderBy parameters with the same type as those generated from t.crud. Definitely feels like something that coincidentally happens to work vs a pattern that would be encouraged.

I think this might be related to https://github.com/graphql-nexus/nexus-plugin-prisma/issues/716. My end goal is nearly the opposite, but the solution of being able to customize t.crud's pagination further could be the same.

created time in a month

issue openedtesting-library/cypress-testing-library

Feature Request: respect `includeShadowDom` cypress option

<!-- HI! PLEASE STOP TO READ THIS!! If your issue is regarding one of the query APIs (getByText, getByLabelText, etc), then please file it on the https://github.com/kentcdodds/dom-testing-library repository instead. If you file it here it will be closed. Thanks :)

Thanks for your interest in the project. I appreciate bugs filed and PRs submitted! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file).

Please fill out this template with all the relevant information so we can understand what's going on and fix the issue.

I'll probably ask you to submit the fix (after giving some direction). If you've never done that before, that's great! Check this free short video tutorial to learn how: http://kcd.im/pull-request -->

  • cypress-testing-library version: 7.0.0
  • node version: v12.16.2
  • npm (or yarn) version: yarn 1.22.5

Problem description:

Cypress recently released shadow DOM support and it is no longer experimental. They also recently let you specify an includeShadowDom option on describe and it blocks. This is very convenient if your entire test operates within the shadow DOM. Ideally, cypress-testing-library would respect this option and this would work even when something is inside a shadow DOM:

it ("works", { includeShadowDOM: true }, () => {
  cy.findByLabelText(<label>)
  cy.findByTestId(<testId>)
});

At the moment, it is necessary to get inside the shadow DOM first and then use cypress-testing-library functions, so you are forced to do something like this instead:

cy.get("#root-of-shadow-dom").shadow().findByLabelText(<label>)
cy.get("#root-of-shadow-dom").shadow().findByTestId(<testId>)

Suggested solution: After reading through https://github.com/testing-library/dom-testing-library/issues/413, it looks like the current recommendation for testing within a shadow DOM with testing library is to use this package that wraps around dom-testing-library and replaces querySelectorAll with a version that traverses shadow DOMs. So in theory, a cypress package could be created that wraps around test-library__dom, but that wouldn't quite work since it needs to either include the shadow DOM or not based on the includeShadowDom option from Cypress.

So to me, it feels like the best solution would be to add a similar includeShadowDom option to the dom-testing-library functions the same as cypress did and pass it on through. Obviously shadow DOM support was proposed once before and it was decided not to build it in, but perhaps that should be reconsidered as shadow DOM becomes more common and testing frameworks like cypress add official support for it. if we want to go this route, assume I should open an issue in dom-testing-library but wanted to open an issue here first since it relates specifically to Cypress.

created time in a month

pull request commentprebid/Prebid.js

Added global function for refreshing user id's

To address @smenzer's points, that refresh flag would need to be passed down into initSubmodules and then have that force it go down the getId path regardless of if there is a non-expired stored value or not. I agree this is necessary since the refresh doesn't do a whole lot of good if just keeps the stored values around.

I would also like if there were a way to only refresh specific submodules. In my particular case, the effect of being logged in only effects a handful of submodules, so it would be better for me to trigger just the ones I know will benefit from the new information instead of having to update them all. I think two reasonable ways to do this would be:

  • a refreshUserId method that takes a submodule name
  • an option like refreshUserIds({ submodules: string[] }).

I would probably prefer refreshUserIds({ submodules: string[] }) since it keeps it to one global api method and also makes it easy to filter down to one or multiple submodules.

coryhammon1

comment created time in a month

issue commentprebid/Prebid.js

Force refresh userId

@jdwieland8282 Yep, that's correct. The goal is to be able to refresh a userId value that gets sent with bids without having to refresh the page.

Right now, it is technically possible to overwrite a user id value by directly accessing the cookie or key in localStorage dictated by the config. However, this will only be reflected in bids after a page reload, since the submodules are only initialized once on load, at which point the values are either read from the cookie/localStorage or getId is called. Assuming getId would also return the same value, then clearing the cookie/key would also have the same effect. In either case, a page reload is necessary to get the value into memory and sent along with bids.

So I'm hoping for a function that I can call to trigger reinitializing the userId value(s). In my proposed API, I suggested an overrideStoredValue option. If overrideStoredValue were passed as false, it would presume that the cookie/localstorage value was already overwritten with the updated value. Thinking about it a little more, I would probably prefer just passing the value in directly if it can be known ahead of time without calling getId. If a value isn't passed, then getId would just be called and replace the existing value.

For my particular need (and I imagine most), it would actually be fine to just re-run getId and not pass in an updated value directly, so I would be fine completely foregoing these options altogether too.

TLadd

comment created time in 2 months

issue openedprebid/Prebid.js

Force refresh userId

Type of issue

Feature Request <!-- Is this a bug, feature request, question, etc.? Note if this is a documentation issue, please open a ticket here instead: https://github.com/prebid/prebid.github.io -->

Description

<!-- Describe the issue --> I would like for there to be a way to force refresh userId values. Currently, if I update a stored userId value in a cookie or localStorage, that new value will get pulled in on future page loads, but not the current one. The old value remains since submodules only get initialized once, which is when these values are read.

The use cases I have where this would be useful all boil down to being able to provide a better id sometime after the initial page load. For instance, after a user logs in, I can get a better identifier than was previously stored and I want to start using it in bids without refreshing the page.

I would propose something along these lines:

interface RefreshUserIdsOptions {
  // When performing the refresh, should it take the stored value, or force overriding it.
  // If the new value was written to the cookie/localStorage, it wouldn't be necessary to call `getId`.
  // True if you want to override the stored value and call `getId`.
  overrideStoredValue: boolean,
}

pbjs.refreshUserIds(options: RefreshUserIdsOptions)
pbjs.refreshUserId(name: string, options: RefreshUserIdsOptions)

created time in 2 months

push eventTLadd/react-spectrum

Devon Govett

commit sha 2ac2592bd255db5240e437093db978d84c8ae2b5

[SSR] Removed call of requestAnimationFrame outside of function (#975)

view details

Mateusz Burzyński

commit sha a91720deb4a60b522f9b7045164ff472c2f94f8c

Introduce useCheckboxGroup & useCheckboxGroupState hooks (#868)

view details

Devon Govett

commit sha 7e495dde8d767308687d0d7fa292d2767501a831

Add SSRProvider to ensure consistent ids between server and client (#992) Co-authored-by: Danni <drobinson@livefyre.com>

view details

Ron Derksen

commit sha c18a45ce4811b987f3d0bc891a2f95a087e515a4

change linkProps generic type to HTMLElement (#1000)

view details

Devon Govett

commit sha 6cd2137c9af032110fda23594d9dff00ed241e86

Fix remaining SSR tests (#994) * Fix issue with useOverlayPosition accessing document.body * Add shim for useLayoutEffect in SSR * Add missing provider and label to ListBox and Picker ssr tests * Avoid layout in virtualizer if requestAnimationFrame is not available * Move RadioGroup name generation into aria instead of stately and make safe for SSR * Fix weird issue with flex in SSR tests in case-insensitive file systems * Add SSR tests to CI * lint * Fix issues with media queries and flex feature test in SSR Co-authored-by: Danni <drobinson@livefyre.com>

view details

Chung Wu

commit sha 701cf941043d443bd4f649b54970a1770532ff85

A few tweaks and fixes to slider: (#955) * A few tweaks and fixes to slider: * state needs to know which thumbs are editable, so that it can block edits to uneditable thumbs by track-dragging * make track-dragging less fragile. Previously, it only handles drag events on itself, not its children; you are expected to place the track DOM by itself, with no children, so that the drag events on the track element and the thumb elements don't conflict. Now, we keep track of whether we are dragging by track; if so, the thumb drag events won't do anything. This makes how you structure your DOM less strict; you can put the trackProps on an element by itself, or on the container of the thumbs. The Story*Slider components have been updated to show the different variations. * Removed unnecessary computeOffsetToValue() * Add / fix some slider tests * Move thumb editable tracking into refs * useDrag1D() ensures when descendant is dragged, ancestor is not dragged useSlider now no longer needs to do the equivalent tracking itself

view details

Devon Govett

commit sha de800ea3b224ac8d0684ca5dbc61590268e6733f

Add Spectrum CheckboxGroup component (#1003) * Add Spectrum CheckboxGroup component * Rename checkboxGroupProps to groupProps to match ARIA role * Improve handling of individual checkbox props within a group * lint * Add docs for Spectrum CheckboxGroup * Hide docs from prod build that are not yet released * Add docs for useCheckboxGroup * review updates * Apply suggestions from code review Co-authored-by: Danni <drobinson@livefyre.com> Co-authored-by: Danni <drobinson@livefyre.com>

view details

Chang Wang

commit sha ba11044e2d3f1632af1fd35c677497f813e140c4

DialogTrigger in popover should accept function as 2nd child (#997) * DialogTrigger in popover should accept function as 2nd child * story and test closing popover * make separate story for popover with function child * Update story name Co-authored-by: Danni <darobins@adobe.com> Co-authored-by: Danni <drobinson@livefyre.com>

view details

Devon Govett

commit sha b52f67477fc1da98003171a5a128ee6d3f8af0a9

Building a button blog part 2 (#1011)

view details

Thomas Ladd

commit sha 4f285089f4c09277ae70dd520fbc3a32b0a13d36

Merge branch 'main' into trl/specify-overlay-root

view details

push time in 2 months

push eventTLadd/react-spectrum

Thomas Ladd

commit sha 407eb5e22e1456609ed5caa03f334ff7b7b7b1f5

Add getContainerRootElement prop to OverlayContainer

view details

push time in 2 months

push eventTLadd/react-spectrum

Thomas Ladd

commit sha 5e3c19c881b546cac09c34aabf5f9219f7bd1e06

Add getContainerRootElement prop to OverlayContainer

view details

push time in 2 months

push eventTLadd/react-spectrum

Devon Govett

commit sha 2ac2592bd255db5240e437093db978d84c8ae2b5

[SSR] Removed call of requestAnimationFrame outside of function (#975)

view details

Mateusz Burzyński

commit sha a91720deb4a60b522f9b7045164ff472c2f94f8c

Introduce useCheckboxGroup & useCheckboxGroupState hooks (#868)

view details

Devon Govett

commit sha 7e495dde8d767308687d0d7fa292d2767501a831

Add SSRProvider to ensure consistent ids between server and client (#992) Co-authored-by: Danni <drobinson@livefyre.com>

view details

Ron Derksen

commit sha c18a45ce4811b987f3d0bc891a2f95a087e515a4

change linkProps generic type to HTMLElement (#1000)

view details

Devon Govett

commit sha 6cd2137c9af032110fda23594d9dff00ed241e86

Fix remaining SSR tests (#994) * Fix issue with useOverlayPosition accessing document.body * Add shim for useLayoutEffect in SSR * Add missing provider and label to ListBox and Picker ssr tests * Avoid layout in virtualizer if requestAnimationFrame is not available * Move RadioGroup name generation into aria instead of stately and make safe for SSR * Fix weird issue with flex in SSR tests in case-insensitive file systems * Add SSR tests to CI * lint * Fix issues with media queries and flex feature test in SSR Co-authored-by: Danni <drobinson@livefyre.com>

view details

Chung Wu

commit sha 701cf941043d443bd4f649b54970a1770532ff85

A few tweaks and fixes to slider: (#955) * A few tweaks and fixes to slider: * state needs to know which thumbs are editable, so that it can block edits to uneditable thumbs by track-dragging * make track-dragging less fragile. Previously, it only handles drag events on itself, not its children; you are expected to place the track DOM by itself, with no children, so that the drag events on the track element and the thumb elements don't conflict. Now, we keep track of whether we are dragging by track; if so, the thumb drag events won't do anything. This makes how you structure your DOM less strict; you can put the trackProps on an element by itself, or on the container of the thumbs. The Story*Slider components have been updated to show the different variations. * Removed unnecessary computeOffsetToValue() * Add / fix some slider tests * Move thumb editable tracking into refs * useDrag1D() ensures when descendant is dragged, ancestor is not dragged useSlider now no longer needs to do the equivalent tracking itself

view details

Thomas Ladd

commit sha 03a79071cf0a950965997a4170fd6092848970a4

Merge branch 'main' into trl/specify-overlay-root

view details

push time in 2 months

PR opened adobe/react-spectrum

Reviewers
Add getContainerRootElement prop to OverlayContainer

Closes https://github.com/adobe/react-spectrum/issues/991

✅ Pull Request Checklist:

  • [X] Included link to corresponding React Spectrum GitHub Issue.
  • [ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • [ ] Filled out test instructions.
  • [ ] Updated documentation (if it already exists for this component).
  • [ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

<!--- Include instructions to test this pull request -->

🧢 Your Project:

<!--- Company/project for pull request -->

Opening as a WIP for https://github.com/adobe/react-spectrum/issues/991. Wasn't sure if this (adding a data attribute) and using .closest was what you had in mind for checking if a container is nested inside another.

An alternative approach I thought about was trying to add a ref to the modal context that gets attached to the OverlayContainerDOM div. I think that could work too. It would require searching up the parent context chain to see if it is inside any of those containers.

Also expect that getContainerRootElement is not the best name still. Wanted to get some feedback before continuing down any path. Thanks!

+17 -4

0 comment

1 changed file

pr created time in 2 months

push eventTLadd/react-spectrum

Thomas Ladd

commit sha bace46153d45bac4b31a02b1f8d2f6fabe2bf526

Add getContainerRootElement prop to OverlayContainer

view details

push time in 2 months

issue commentadobe/react-spectrum

Allow specifying selector for OverlayContainer

The only requirement is that the container must not be inside another container because we add aria-hidden to the parent container when an overlay opens which would also hide the child if its inside.

Good point. I had actually done this myself since I put the OverlayProvider around the whole app and my custom root node was within that OverlayProvider. So yeah, I think an error would definitely be a good idea to catch this. Trying to think exactly how would one would go about doing that. Is it equivalent to saying that ModalProvider's cannot be nested? If it is, then it would be easy to check if useModalProvider returns null or not in OverlayProvider.

TLadd

comment created time in 2 months

push eventTLadd/react-spectrum

Thomas Ladd

commit sha c78824a5dcbc51a5206e02a0940eb83aebea7a49

Add parentSelector prop to OverlayContainer

view details

push time in 2 months

issue openedadobe/react-spectrum

Allow specifying selector for OverlayContainer

<!--- Thanks for filing an issue 😄! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have asked the same thing before! -->

🙋 Feature Request

<!--- Provide a general summary of the feature here --> I want to be able to control where OverlayContainer renders the modals. Currently, ReactDOM.createPortal is called with document.body without the option to override it.

🤔 Expected Behavior

Allow passing in the createPortal container argument as a prop.

😯 Current Behavior

There is no way to override the container argument.

💁 Possible Solution

I think something like this should work?

interface OverlayContainerProps extends ModalProviderProps {
  containerSelector?: () => HTMLElement
}

export function OverlayContainer(props: OverlayContainerProps): React.ReactPortal {
  let {containerSelector = () => document.body, ...rest} = props;
  let contents = <OverlayProvider {...rest} />;
  return ReactDOM.createPortal(contents, containerSelector());
}

I'm not sure if any of the other hooks are making any assumptions about where the modals are rendered and would also need modification. For my particular use case, just this change seems to work.

Happy to contribute if this is okay!

🔦 Context

I'm adding a modal to an application within the shadow DOM. As such, I need to be able to also render the modal within that same shadow DOM for it to render correctly. In order to have the modal render where I want it, I need to pass something like document.querySelector("#shoadw-app-root").shadowRoot.querySelector("#react-aria-overlay-root") to createPortal

💻 Examples

<!-- Examples help us understand the requested feature better. Include design mocks here if possible. -->

🧢 Your Company/Team

<!--- Which product team is this feature for? (i.e. Adobe/Photoshop) -->

🎁 Tracking Ticket (optional)

<!--- Link to the ticket in your system, if publicly available -->

created time in 2 months

create barnchTLadd/react-spectrum

branch : trl/specify-overlay-root

created branch time in 2 months

pull request commentvercel/swr

Type fetcher function arguments based on array key (#331)

I would have thought the as const was necessary for TypeScript to infer the correct type for the arguments tuple. By default, TypeScript sees something like

let args = ["hello", 42]

and infers a type of (string | number)[]. It does this because arrays are mutable and it allows me to call .push or .remove to mutate the items in the array. When I instead do

let args = ["hello", 42] as const

The as const tells TypeScript to make it a type error to mutate the array and thus it is safe to assign the tuple type readonly ["hello", 42] to args.

I looked into what react-query was doing and noticed https://github.com/tannerlinsley/react-query/blob/master/types/index.d.ts#L202. I don't really understand why, but this apparently forces TypeScript to infer the tuple when the array is passed as the argument directly (not assigned to a variable first). I copied that same type over and it works, except for the case when the key is a function where as const is still necessary.

TLadd

comment created time in 2 months

push eventTLadd/swr

Thomas Ladd

commit sha ff35450dca861f3041e58a0d0f7368bc864aa18e

Modify types to automatically infer tuple in most cases

view details

push time in 2 months

fork TLadd/react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.

https://react-spectrum.adobe.com

fork in 2 months

issue commenthashicorp/next-mdx-enhanced

Upcoming breaking change in next.js@9.5.2 ("disallow re-export all exports")

Perhaps a simple solution could be adding an option to the plugin that allows passing in which layouts need to export getStaticProps and/or getServerProps? Something like

{
  layoutPath: "layouts",
  defaultLayout: true,
  fileExtensions: ["mdx"],
  remarkPlugins: [],
  rehypePlugins: [],
  layoutExports: {
    layout1: ["getStaticProps"],
    layout2: ["getServerProps"]
  },
  extendFrontMatter: {
    process: (mdxContent, frontMatter) => {},
    phase: "prebuild|loader|both",
  },
}

Obviously being able to detect it automatically would be the ideal. But this could be done quickly and get the plugin working with latest version of next.js again.

stephanschubert

comment created time in 2 months

fork TLadd/mercury-parser

📜 Extract meaningful content from the chaos of a web page

https://mercury.postlight.com/web-parser/

fork in 3 months

more