profile
viewpoint

push eventStefanSchoof/espresso

StefanSchoof

commit sha 5ed882366fb528025fbb5d991997c001e0120b05

use func preview

view details

push time in 21 hours

push eventStefanSchoof/espresso

StefanSchoof

commit sha 713169bfa02968e9b30fc16d67c744b2d33209c8

use the new terraform trim function (#178)

view details

StefanSchoof

commit sha 62264fb279cc62fd4c3afb00e687754634e1fe6f

Merge remote-tracking branch 'origin/master' into funcnode12

view details

push time in a day

create barnchStefanSchoof/espresso

branch : funcnode12

created branch time in a day

delete branch StefanSchoof/espresso

delete branch : terraformtrim

delete time in 5 days

push eventStefanSchoof/espresso

StefanSchoof

commit sha 713169bfa02968e9b30fc16d67c744b2d33209c8

use the new terraform trim function (#178)

view details

push time in 5 days

create barnchStefanSchoof/espresso

branch : terraformtrim

created branch time in 5 days

issue commentAzure/azure-functions-nodejs-worker

Node.js v12 support

@johnpapa It was announced two hours ago: https://github.com/Azure/app-service-announcements/issues/216

JamieMagee

comment created time in 5 days

issue commentaspnet/AspNetCore.Docs

Poweshell Snipet to download and install dotnet-hosting

You are right this was simple. With fresh start I got:

Invoke-WebRequest -Uri https://download.visualstudio.microsoft.com/download/pr/32b71802-0b4d-4064-a7e6-083b5155d3b1/080cf60a5c06be4ed27e2eac6c693f2f/dotnet-hosting-3.0.1-win.exe -OutFile dotnet-hosting-3.0.1-win.exe
Start-Process -FilePath ./dotnet-hosting-3.0.1-win.exe -Wait -ArgumentList /passive
net stop was /y
net start w3svc

Thanks for your help and sorry to bother you with this.

StefanSchoof

comment created time in 11 days

issue commentaspnet/AspNetCore.Docs

Poweshell Snipet to download and install dotnet-hosting

I have this script:

Invoke-WebRequest -Uri https://download.visualstudio.microsoft.com/download/pr/32b71802-0b4d-4064-a7e6-083b5155d3b1/080cf60a5c06be4ed27e2eac6c693f2f/dotnet-hosting-3.0.1-win.exe -OutFile dotnet-hosting-3.0.1-win.exe
./dotnet-hosting-3.0.1-win.exe /passive
#Start-Sleep -Seconds 300
net stop was /y
net start w3svc

And if I do not have the Start-Sleep in there the net stop was /y will executed right after the installation starts and not wait until the installer has finished.

StefanSchoof

comment created time in 11 days

issue commentaspnet/AspNetCore.Docs

Poweshell Snipet to download and install dotnet-hosting

Thanks, for the quick reply and to clearly that there is no support for a official script. I am on azure and like to use the Custom Script Extension, but simple say, write your own script it is not what I expect in the highly automation focus world. And I a little disappointed that the installer does not wait. This are unnecessary barriers. (I understand your point of view, but I needed to express my dissatisfaction)

StefanSchoof

comment created time in 12 days

issue openedaspnet/AspNetCore.Docs

Poweshell Snipet to download and install dotnet-hosting

In this documentation is only the way to download and install the dotnet-hosting with many manual step explained. Is there any Powershell snippet that download and installs a dotnet hosting on a windows server? Trying this is seems unnecessary hard. The real download URL is hidden on a webpage, the installer is not waiting until the installation is finished. I assumed there would be an easier way, but the documentation mention no. So is there really no easy way to automate the dotnet-hosting installation?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

created time in 12 days

issue commentterraform-providers/terraform-provider-azurerm

Add option to enable "Allow access to Azure service"

I assume this works the same as in the mssql Firewall with 0.0.0.0. https://www.terraform.io/docs/providers/azurerm/r/sql_firewall_rule.html:

NOTE: The Azure feature Allow access to Azure services can be enabled by setting start_ip_address and end_ip_address to 0.0.0.0 which (is documented in the Azure API Docs).

I think if this is true, the same block should be added to the mysql documentation

goluzdravi-penzioner

comment created time in 13 days

pull request commentterraform-providers/terraform-provider-azurerm

provider: being more descriptive with the resource provider error

@tombuildsstuff Great, this should be reduce the problems people running in this problem.

Have you seen that I also tried to include all missing providers in the error message: https://github.com/hashicorp/go-azure-helpers/pull/46? So a user can request all missing providers to register by an admin in one step.

tombuildsstuff

comment created time in 16 days

pull request commenthashicorp/go-azure-helpers

report all errors in resource providers registration

It should now work also in the non error case and I also make it work with the old go version

StefanSchoof

comment created time in 16 days

delete branch StefanSchoof/terraform-provider-azurerm

delete branch : resouceproviderserror

delete time in 18 days

issue commenthashicorp/terraform

trim* functions are not available in 0.12.16

The release tag page still mentions this for 0.12.16: https://github.com/hashicorp/terraform/releases/tag/v0.12.16

golonzovsky

comment created time in 18 days

push eventStefanSchoof/go-azure-helpers

StefanSchoof

commit sha b8abf3c1073598fcfa9d6ffdae53c5f26ebd89f2

append error only if failedProviders are not empty

view details

push time in 19 days

pull request commenthashicorp/go-azure-helpers

report all errors in resource providers registration

I just realized, this is not working for the non error case. Will try to fix it.

StefanSchoof

comment created time in 19 days

Pull request review commentterraform-providers/terraform-provider-azurerm

Add mention of skip_provider_registration in resource provider registration error

 func providerConfigure(p *schema.Provider) schema.ConfigureFunc {  				err := ensureResourceProvidersAreRegistered(ctx, *client.Resource.ProvidersClient, availableResourceProviders, requiredResourceProviders) 				if err != nil {-					return nil, fmt.Errorf("Error ensuring Resource Providers are registered: %s", err)+					return nil, fmt.Errorf("Error ensuring Resource Providers are registered. If not other possible consider using the skip_provider_registration option https://www.terraform.io/docs/providers/azurerm/index.html#skip_provider_registration: %s", err)

Thanks, that sounds good. I changed it

StefanSchoof

comment created time in 19 days

push eventStefanSchoof/terraform-provider-azurerm

StefanSchoof

commit sha 6e61863e0d840810e9769c0db122316acb14851f

Rephrase skip_provider_registration mention

view details

push time in 19 days

pull request commenthashicorp/go-azure-helpers

report all errors in resource providers registration

I tried this with go 1.13 (same as terraform-provider-azurerm). Should I make this 1.11 compatible or should the version bumped to 1.13?

StefanSchoof

comment created time in 19 days

PR opened hashicorp/go-azure-helpers

report all errors in resource providers registration

Collect all errors in resource provider registration. My first go code. So expect go beginners mistakes.

Resolves #45

+8 -2

0 comment

1 changed file

pr created time in 19 days

create barnchStefanSchoof/terraform-provider-azurerm

branch : resouceproviderserror

created branch time in 20 days

create barnchStefanSchoof/go-azure-helpers

branch : ProviderError

created branch time in 20 days

fork StefanSchoof/go-azure-helpers

This repository contains various helpers and wrappers for working with Azure and the Azure SDK for Go.

fork in 20 days

issue openedhashicorp/go-azure-helpers

Resource provider RegisterForSubscription returns only last error

If RegisterForSubscription fails for multiple provider only the last error is returned:

https://github.com/hashicorp/go-azure-helpers/blob/6e061044db42917eeaecea091acb19e5d917122e/resourceproviders/registration.go#L40-L48

It should return all error and/or all providers that fail to register.

If someone have not enough permission to enable those provider it would be very helpful to have a error message with all resource provider that are unable to register.

Related: https://github.com/terraform-providers/terraform-provider-azurerm/issues/4799

created time in 24 days

issue commentmozilla/multi-account-containers

"Always open in <container>" should respect URL path

For things like http://example.com/test1 and http://example.com/test2 you can use the Containerise addon to configure this. (found in https://github.com/mozilla/multi-account-containers/issues/473#issuecomment-524319820)

mkurz

comment created time in 25 days

PR closed graphql-dotnet/server

[WIP] add azure function sample

Taken from https://github.com/tpeczek/Demo.Azure.Functions.GraphQL

I started adding the azure function sample. Currently I had changed anything. But I got a few questions:

  • In the README is a link asking for donations. Do you like to keep this or should this removed?
  • Also is there a LICENSE file with the MIT License. Keep it or remove it since there is a MIT License at the top of this project.
  • Should this sample keep at its own or should it integrated into the main sln?
  • Keep the Demo.Azure.Functions.GraphQL namespace or simlar to others samples (Samples.AzureFunction)

Resolves #232

+795 -0

2 comments

19 changed files

StefanSchoof

pr closed time in a month

pull request commentgraphql-dotnet/server

[WIP] add azure function sample

Will open a new PR in the examples project. Can take some time until I get to it.

StefanSchoof

comment created time in a month

issue commentterraform-providers/terraform-provider-azurerm

azurerm_app_service: mark app_settings as sensitive

@PSanetra You may expieriens the bug #3129 (at least I did), when working with keyvault Uris.

PSanetra

comment created time in a month

issue commentAzure/azure-iot-sdk-node

Client using MQTT transport eventually hangs

I expired the same or a similar issue. But since some time my connection problems are gone. I do not know what solved it (package update, ps updates, network provider changes, azure changes, ...) but the connection feels stable now.

chrisahardie

comment created time in a month

issue commentterraform-providers/terraform-provider-azurerm

azurerm_app_service: mark app_settings as sensitive

Yes, you can use manged service identity and then a appsetting in the format @Microsoft.KeyVault(SecretUri=https://myvault.vault.azure.net/secrets/mysecret/ec96f02080254f109c51a1f14cdb1931), see https://docs.microsoft.com/en-us/azure/app-service/app-service-key-vault-references

PSanetra

comment created time in a month

issue openedterraform-providers/terraform-provider-azurerm

Improve Error message for failed Provider Register

<!--- Please keep this note for the community --->

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

<!--- Thank you for keeping this note for the community --->

Description

If terraform is currently in a subscription without all resources providers regiserd, it tries to register these. This can fail if the user has not enough permissions. The error message is:

Error: Error ensuring Resource Providers are registered: Cannot register provider Microsoft.Kusto with Azure Resource Manager: resources.ProvidersClient#Register: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403
Code="AuthorizationFailed" Message="The client 'xxxx@yyy' with object id '<id>' does not have authorization to perform action 'Microsoft.Kusto/register/action' over scope '/subscriptions/<id>' or
the scope is invalid. If access was recently granted, please refresh your credentials.".

  on main.tf line 1, in provider "azurerm":
   1: provider "azurerm" {

This message is not very helpful. If you run in this kind of problem you have two options:

  • set skip_provider_registration to true
  • let someone with permissions enable all needed providers.

So the error should mention the skip_provider_registration option and also list all needed but not activated resource providers and only the first causing an error. So I can ask a person with higher rights to enable them all.

If someone new to terraform and only got access to a limited subscription, this may one of the first errors he encounters, so the message should be very helpful.

New or Affected Resource(s)

n/a

Potential Terraform Configuration

<!--- Information about code formatting: https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code --->

n/a

References

<!--- Information about referencing Github Issues: https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests

Are there any other GitHub issues (open or closed) or pull requests that should be linked here? Vendor blog posts or documentation? For example:

  • https://azure.microsoft.com/en-us/roadmap/virtual-network-service-endpoint-for-azure-cosmos-db/ --->

  • The check is done in https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/azurerm/required_resource_providers.go

created time in a month

delete branch StefanSchoof/espresso

delete branch : tagpull

delete time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha d0dc44cb4561ab36da91e41a467643c7f3f99727

pull image by generic tag name (#175)

view details

push time in a month

PR merged StefanSchoof/espresso

pull image by generic tag name

To prevent restart if image is unchanged

+3 -2

0 comment

2 changed files

StefanSchoof

pr closed time in a month

PR opened StefanSchoof/espresso

pull image by generic tag name

To prevent restart if image is unchanged

+3 -2

0 comment

2 changed files

pr created time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha f1cb631842400285c29e93433267dbe4e7802f0a

pull image by generic tag name

view details

push time in a month

create barnchStefanSchoof/espresso

branch : tagpull

created branch time in a month

delete branch StefanSchoof/espresso

delete branch : terraformupdate

delete time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha fae22a605afde4cbe5e88d36a5f5cfbcb111f77b

terraform update (#174)

view details

push time in a month

PR opened StefanSchoof/espresso

terraform update
+1 -1

0 comment

1 changed file

pr created time in a month

create barnchStefanSchoof/espresso

branch : terraformupdate

created branch time in a month

delete branch StefanSchoof/espresso

delete branch : http2

delete time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 4837dbf2b65e6b9c44b9294b62f5f116bdd0bcac

enable http2 (#173)

view details

push time in a month

PR merged StefanSchoof/espresso

enable http2
+2 -1

0 comment

2 changed files

StefanSchoof

pr closed time in a month

issue openedMicrosoftDocs/vsts-docs

Explain yaml Queuing policies

Even when yaml does not support Queuing policies, it should in this documentation explain how the Queuing policy behavior of multi stage yaml is.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

created time in a month

PR opened StefanSchoof/espresso

enable http2
+2 -1

0 comment

2 changed files

pr created time in a month

create barnchStefanSchoof/espresso

branch : http2

created branch time in a month

pull request commentterraform-providers/terraform-provider-azurerm

azurerm_app_service: mark app_settings as sensitive

I added a comment to the issue, where I disagree that doing so is a good idea.

aqche

comment created time in a month

issue commentterraform-providers/terraform-provider-azurerm

azurerm_app_service: mark app_settings as sensitive

I disagree.

Sensitive app settings belong into a key vault. And making this senetive, makes people think that the information is protected and make it harder to see changes of not senetive data.

PSanetra

comment created time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 64933c78c58ac0763060db6abe434d0b5490e773

write version to log

view details

push time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha bb519ada1a01522150a52532e39e591dab7fb048

Install current docker cli for bake

view details

push time in a month

create barnchStefanSchoof/espresso

branch : baketest

created branch time in a month

PR opened graphql-dotnet/server

[WIP] add azure function sample

Taken from https://github.com/tpeczek/Demo.Azure.Functions.GraphQL

I started adding the azure function sample. Currently I had changed anything. But I got a few questions:

  • In the README is a link asking for donations. Do you like to keep this or should this removed?
  • Also is there a LICENSE file with the MIT License. Keep it or remove it since there is a MIT License at the top of this project.
  • Should this sample keep at its own or should it integrated into the main sln?
  • Keep the Demo.Azure.Functions.GraphQL namespace or simlar to others samples (Samples.AzureFunction)

Resolves #232

+795 -0

0 comment

19 changed files

pr created time in a month

create barnchStefanSchoof/server

branch : functionsample

created branch time in a month

fork StefanSchoof/server

ASP.NET Core Server + WebSockets Transport

fork in a month

delete branch StefanSchoof/espresso

delete branch : patternarray

delete time in a month

delete branch StefanSchoof/espresso

delete branch : typescriptfunction

delete time in a month

delete branch StefanSchoof/espresso

delete branch : e2emodules

delete time in a month

delete branch StefanSchoof/espresso

delete branch : iotdevice

delete time in a month

delete branch StefanSchoof/espresso

delete branch : pool

delete time in a month

delete branch StefanSchoof/espresso

delete branch : greenkeeper/default/jest-junit-9.0.0

delete time in a month

PR merged StefanSchoof/espresso

Update jest-junit in group default to the latest version 🚀 greenkeeper

The dependency jest-junit was updated from 8.0.0 to 9.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: jsonp License: Apache-2.0

<details> <summary>Release Notes for v9.0.0</summary>

<p>Ability to generate unique filenames for junit.xml by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=12693088" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/andrcuns">@andrcuns</a> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="510565300" data-permission-text="Issue title is private" data-url="https://github.com/jest-community/jest-junit/issues/108" data-hovercard-type="pull_request" data-hovercard-url="/jest-community/jest-junit/pull/108/hovercard" href="https://urls.greenkeeper.io/jest-community/jest-junit/pull/108">#108</a></p> </details>

<details> <summary>Commits</summary> <p>The new version differs by 6 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/jest-community/jest-junit/commit/1ee5b29a3f42c441a0a93ce793732b869329e06c"><code>1ee5b29</code></a> <code>Merge pull request #109 from palmerj3/v9.0.0</code></li> <li><a href="https://urls.greenkeeper.io/jest-community/jest-junit/commit/9cc91c259c0429f3ca94205ce57649d7f5be020c"><code>9cc91c2</code></a> <code>v9.0.0</code></li> <li><a href="https://urls.greenkeeper.io/jest-community/jest-junit/commit/414ddbbae75c15b6ee99f0d86233395ef6642cbb"><code>414ddbb</code></a> <code>Merge pull request #108 from andrcuns/uniq_xml_name</code></li> <li><a href="https://urls.greenkeeper.io/jest-community/jest-junit/commit/325abedd8aa6575858c0bdfdf0bb865eb365ac70"><code>325abed</code></a> <code>Add separate option to generate unique file names for xml report files</code></li> <li><a href="https://urls.greenkeeper.io/jest-community/jest-junit/commit/32ba516998920059273cf235fdfdc0f4a7f23692"><code>32ba516</code></a> <code>Remove unsupported node versions, update readme</code></li> <li><a href="https://urls.greenkeeper.io/jest-community/jest-junit/commit/2a60ded9510c630723eda168d89aba3d4251c3a8"><code>2a60ded</code></a> <code>Generate unique xml file by default</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/jest-community/jest-junit/compare/43a8de69c53a5be1610af38b282b96a91dd610cf...1ee5b29a3f42c441a0a93ce793732b869329e06c">full diff</a></p> </details>


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+41 -62

0 comment

8 changed files

greenkeeper[bot]

pr closed time in a month

push eventStefanSchoof/espresso

greenkeeper[bot]

commit sha 89402f0339f5d1c0ecd2f0ca7a04a372ab3cb01c

Update jest-junit in group default to the latest version 🚀 (#169) * fix(package): update jest-junit to version 9.0.0 * chore(package): update jest-junit to version 9.0.0 * fix(package): update jest-junit to version 9.0.0 * chore(package): update jest-junit to version 9.0.0 * chore(package): update lockfile web/package-lock.json * chore(package): update lockfile node/package-lock.json * chore(package): update lockfile func/package-lock.json * chore(package): update lockfile e2etest/package-lock.json

view details

push time in a month

delete branch StefanSchoof/espresso

delete branch : node12

delete time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha b006e7408c3ee036e20f7741860bd0cb733fd24c

upgrade node to node12 (#172)

view details

push time in a month

PR merged StefanSchoof/espresso

upgrade node to node12
+7 -6

0 comment

3 changed files

StefanSchoof

pr closed time in a month

PR opened StefanSchoof/espresso

upgrade node to node12
+7 -6

0 comment

3 changed files

pr created time in a month

create barnchStefanSchoof/espresso

branch : node12

created branch time in a month

delete branch StefanSchoof/espresso

delete branch : ubuntu1804

delete time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 1357cefc014aa45f84b37e36f5d601aa9bcafd27

Use ubuntu 18.04 pipeline images (#171)

view details

push time in a month

PR opened StefanSchoof/espresso

Use ubuntu 18.04 pipeline images
+21 -10

0 comment

7 changed files

pr created time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 8e9abac36abd58efbfaad5033a15c9a9bc5f4f9e

set default image

view details

push time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha db3b6afba8fdc3e57e8826a1ecf12528e9b1d8fc

fix image name

view details

push time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 7b88d7776daf814caaa1bff49f34104c3c00efe3

set right parameter

view details

push time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha a0abf15e9a5091787f203f42edfe5222239c3a4d

try empty value

view details

push time in a month

delete branch StefanSchoof/espresso

delete branch : nofixednodeversion

delete time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 7f7d266a21c2705f1eaa49cda3f380fc88362f67

set node version to latest of 10 (#170)

view details

push time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha 34e05d9afc634dd0930353b63adf1accf7025e2f

split vmImage pool name

view details

push time in a month

create barnchStefanSchoof/espresso

branch : nofixednodeversion

created branch time in a month

push eventStefanSchoof/espresso

StefanSchoof

commit sha da8db412ecd7b1dc0aa5d8548de0cd117b6007f2

use vmImage

view details

push time in a month

create barnchStefanSchoof/espresso

branch : ubuntu1804

created branch time in 2 months

issue commentgraphql-dotnet/server

Azure Functions Support

@tpeczek Is it fine for you if I create a PR to add your https://github.com/tpeczek/Demo.Azure.Functions.GraphQL sample to the official sample projects?

StefanSchoof

comment created time in 2 months

delete branch StefanSchoof/espresso

delete branch : npmupdate

delete time in 2 months

push eventStefanSchoof/espresso

StefanSchoof

commit sha ef2159d803bb63594a03730ecdc7d3d6f40af2f2

npm update (#168) Closes #156

view details

push time in 2 months

PR closed StefanSchoof/espresso

Update @types/selenium-webdriver in group default to the latest version 🚀 greenkeeper

The devDependency @types/selenium-webdriver was updated from 3.0.16 to 4.0.2.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: types License: MIT

Find out more about this release.


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+4 -4

3 comments

2 changed files

greenkeeper[bot]

pr closed time in 2 months

PR merged StefanSchoof/espresso

npm update

Resolves #156

+9875 -7646

0 comment

8 changed files

StefanSchoof

pr closed time in 2 months

PR opened StefanSchoof/espresso

npm update

Resolves #156

+9875 -7646

0 comment

8 changed files

pr created time in 2 months

create barnchStefanSchoof/espresso

branch : npmupdate

created branch time in 2 months

Pull request review commentterraform-providers/terraform-provider-azurerm

Added Terraform Azure Partner ID

 func setUserAgent(client *autorest.Client, tfVersion, partnerID string) { 		client.UserAgent = fmt.Sprintf("%s %s", client.UserAgent, azureAgent) 	} +	// only one pid can be interpreted currently+	//  hence, send partner Id if present 	if partnerID != "" { 		client.UserAgent = fmt.Sprintf("%s pid-%s", client.UserAgent, partnerID)+	} else {+		// otherwise, if pid is not present in config files, send Terraform GUID+		terraformGUID := "222c6c49-1b0a-5959-a213-6608f9eb8820"+		client.UserAgent = fmt.Sprintf("%s pid-%s", client.UserAgent, terraformGUID)

Why not use only a single Sprintf after the if else (with a local variable), to eliminate the code duplication?

echuvyrov

comment created time in 2 months

more