profile
viewpoint

RolandasRazma/RRFPSBar 703

Show FPS Bar instead of StatusBar on iOS

RolandasRazma/RRAutoLayout 249

iOS6 AutoLayout backport to iOS5

RolandasRazma/RRConstraintsPlugin 204

Xcode plugin for better constraints based layout workflow

RolandasRazma/Heredox 32

http://itunes.apple.com/WebObjects/MZStore.woa/wa/viewSoftware?id=555104623&mt=8

RolandasRazma/RRiOS7Backport 14

libRRiOS7Backport is an effort to backport parts of iOS7 to iOS6/iOS5

RolandasRazma/RRMetaballs 14

Metaballs (aka Blobs) and Marching Squares implementation

RolandasRazma/at-brute 6

AT commands brute-forcer

RolandasRazma/RRContainerView 6

iOS6 "Container View" backport to iOS5

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

issue commentapollographql/apollo-ios

[Bug] 0.27.1 introduced an bug when two queries are sent one after another

this sounds like completion handler overwritten somewhere without cancelling and new call created without canceling old one

MaximillionMai

comment created time in 4 days

issue commentapollographql/apollo-ios

Cache write on watcher dependent key can cancel server fetch

considering https://github.com/apollographql/apollo-ios/pull/1156 was merged is this still open issue?

flobories

comment created time in 5 days

Pull request review commentapollographql/apollo-ios

Allow to clear the cache synchronously

 public final class InMemoryNormalizedCache: NormalizedCache {    public func clear(callbackQueue: DispatchQueue?,

IMO we should make handler non optional here, otherwise its easy to miss that its asynchronous operation

gsabran

comment created time in 5 days

Pull request review commentapollographql/apollo-ios

Do not cancel server fetch of watcher on dependent key update

 public final class GraphQLQueryWatcher<Query: GraphQLQuery>: Cancellable, Apollo     guard let dependentKeys = dependentKeys else { return }      if !dependentKeys.isDisjoint(with: changedKeys) {-      fetch(cachePolicy: .returnCacheDataElseFetch)+      // First, attempt to reload the query from the cache directly, in order not to interrupt any in-flight server-side fetch.+      store.load(query: query) { [weak self] result in+        guard let self = self else { return }++        switch result {+        case .success:+          self.callbackQueue.async {+            self.resultHandler(result)+          }+        case .failure:+          // If the cache fetch is not successful, for instance if the data is missing, refresh from the server.+          self.fetch(cachePolicy: .fetchIgnoringCacheData)

is .fetchIgnoringCacheData correct here? it was .returnCacheDataElseFetch before. Can we get into some fetch cycle here? fetch(cachePolicy: CachePolicy) -> Fail -> fetch(cachePolicy: CachePolicy) -> Fail -> ...

flobories

comment created time in 7 days

Pull request review commentapollographql/apollo-ios

Do not cancel server fetch of watcher on dependent key update

 public final class GraphQLQueryWatcher<Query: GraphQLQuery>: Cancellable, Apollo     guard let dependentKeys = dependentKeys else { return }      if !dependentKeys.isDisjoint(with: changedKeys) {-      fetch(cachePolicy: .returnCacheDataElseFetch)+      // First, attempt to reload the query from the cache directly, in order not to interrupt any in-flight server-side fetch.+      store.load(query: query) { [weak self] result in+        guard let self = self else { return }++        switch result {+        case .success:+          self.callbackQueue.async {

isn't this retain cycle? self.callbackQueue -> self.resultHandler

flobories

comment created time in 7 days

push eventgetfiit/lottie-ios

Rapsssito

commit sha 16fe16c6c19d2eb4899a4021a5eadf58ee45077d

Contiguous Arrays

view details

Rapsssito

commit sha f580eff1ace5f09f45c722a2cfe1c02d27b99677

Removed prints

view details

Benzi

commit sha beab7b65198d7528c409b749836bf9d45b9df6fb

Fix LRUAnimationCache to evict cached items This bug fix ensures that items stored in `cacheMap` are also removed when an entry from `lruList` is removed.

view details

Anders Hasselqvist

commit sha 3e8d71af2fd91f49dcf3665febf223f1f6b0a832

waitingToPlayAimation -> waitingToPlayAnimation

view details

Joris Bodin

commit sha fb596a114e067f9808191c4214478a23585e2308

Improve readme for SPM

view details

liulichao

commit sha d26a398e43ace72dd23e8315a280fc4be25709da

Fix method :-animationMovedToWindow judgment logic

view details

Jason Knight

commit sha 902b836aa4cb20d331a4dc541ce830db9951fbd7

Put CATransaction completion listener inside the begin/end block.

view details

Jason Knight

commit sha 5ea3aeda7c153076f3ebc6788cee3a893452316a

Fix stop not working by putting in CATransaction.flush in stop

view details

Marcio

commit sha 658f872a9ba2215966fe497ed875bb52c2dbc595

Fix matching parent's animation if it's not a simple CABasicAnimation

view details

TheInkedEngineer

commit sha c333dfeeecbc74d039bb56908660aa4a7939af5a

[Fix] Missing spacing inside braces Just a minor fix for people with Swift OCD.

view details

Brandon Withrow

commit sha ef3c43641c4f18c7e41a99e008a648366e1f111e

Merge pull request #1149 from liulichao123/master Fix method :-animationMovedToWindow judgment logic

view details

Brandon Withrow

commit sha 23571b5e67a692d95ed7b90044d6d695fedcbfd0

Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 86d9126e717cc2b83775d0a2de81340c07f94cf7

Merge pull request #1185 from airbnb/btw/TextLayerParagraphPosition Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 05d969640ea092b946c3047ba85ff24b9f58657d

Merge pull request #1118 from Rapsssito/refactor-array refactor: Keyframe<T> Contiguous Arrays

view details

Brandon Withrow

commit sha da8ecb86fc841cc900a7c06a86ee9d86342b009a

Merge pull request #1119 from BenziAhamed/patch-1 Fix LRUAnimationCache to evict cached items

view details

Brandon Withrow

commit sha 1b9acaba0ac4da3726e8dcc44f82b498f2e237a6

Merge pull request #1145 from nevil/typo-fix waitingToPlayAimation -> waitingToPlayAnimation

view details

Brandon Withrow

commit sha 01bf9b2a8d7631ae379c0abba2ca959eb7635acc

Merge pull request #1157 from 7jason/master Fix AnimationView.Stop()

view details

Brandon Withrow

commit sha 1bececc2ca8f8b43a4f02435b67c1878bcca147f

Merge pull request #1147 from JorisBodin/master Improve readme for SPM

view details

Brandon Withrow

commit sha f3b12bac69c2f38ed32e65b5ebd936cf06236599

Merge pull request #1163 from marciogranzotto/marcio/fix-scale-animation Fix matching parent's animation if it's not a simple CABasicAnimation

view details

Brandon Withrow

commit sha b4502eb36d2a95db179605b611e0dc7074ff6f7f

Merge pull request #1165 from TheInkedEngineer/patch-1 [Fix] Missing spacing inside braces

view details

push time in a month

push eventgetfiit/lottie-ios

Rapsssito

commit sha 16fe16c6c19d2eb4899a4021a5eadf58ee45077d

Contiguous Arrays

view details

Rapsssito

commit sha f580eff1ace5f09f45c722a2cfe1c02d27b99677

Removed prints

view details

Benzi

commit sha beab7b65198d7528c409b749836bf9d45b9df6fb

Fix LRUAnimationCache to evict cached items This bug fix ensures that items stored in `cacheMap` are also removed when an entry from `lruList` is removed.

view details

Anders Hasselqvist

commit sha 3e8d71af2fd91f49dcf3665febf223f1f6b0a832

waitingToPlayAimation -> waitingToPlayAnimation

view details

Joris Bodin

commit sha fb596a114e067f9808191c4214478a23585e2308

Improve readme for SPM

view details

liulichao

commit sha d26a398e43ace72dd23e8315a280fc4be25709da

Fix method :-animationMovedToWindow judgment logic

view details

Jason Knight

commit sha 902b836aa4cb20d331a4dc541ce830db9951fbd7

Put CATransaction completion listener inside the begin/end block.

view details

Jason Knight

commit sha 5ea3aeda7c153076f3ebc6788cee3a893452316a

Fix stop not working by putting in CATransaction.flush in stop

view details

Marcio

commit sha 658f872a9ba2215966fe497ed875bb52c2dbc595

Fix matching parent's animation if it's not a simple CABasicAnimation

view details

TheInkedEngineer

commit sha c333dfeeecbc74d039bb56908660aa4a7939af5a

[Fix] Missing spacing inside braces Just a minor fix for people with Swift OCD.

view details

Brandon Withrow

commit sha ef3c43641c4f18c7e41a99e008a648366e1f111e

Merge pull request #1149 from liulichao123/master Fix method :-animationMovedToWindow judgment logic

view details

Brandon Withrow

commit sha 23571b5e67a692d95ed7b90044d6d695fedcbfd0

Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 86d9126e717cc2b83775d0a2de81340c07f94cf7

Merge pull request #1185 from airbnb/btw/TextLayerParagraphPosition Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 05d969640ea092b946c3047ba85ff24b9f58657d

Merge pull request #1118 from Rapsssito/refactor-array refactor: Keyframe<T> Contiguous Arrays

view details

Brandon Withrow

commit sha da8ecb86fc841cc900a7c06a86ee9d86342b009a

Merge pull request #1119 from BenziAhamed/patch-1 Fix LRUAnimationCache to evict cached items

view details

Brandon Withrow

commit sha 1b9acaba0ac4da3726e8dcc44f82b498f2e237a6

Merge pull request #1145 from nevil/typo-fix waitingToPlayAimation -> waitingToPlayAnimation

view details

Brandon Withrow

commit sha 01bf9b2a8d7631ae379c0abba2ca959eb7635acc

Merge pull request #1157 from 7jason/master Fix AnimationView.Stop()

view details

Brandon Withrow

commit sha 1bececc2ca8f8b43a4f02435b67c1878bcca147f

Merge pull request #1147 from JorisBodin/master Improve readme for SPM

view details

Brandon Withrow

commit sha f3b12bac69c2f38ed32e65b5ebd936cf06236599

Merge pull request #1163 from marciogranzotto/marcio/fix-scale-animation Fix matching parent's animation if it's not a simple CABasicAnimation

view details

Brandon Withrow

commit sha b4502eb36d2a95db179605b611e0dc7074ff6f7f

Merge pull request #1165 from TheInkedEngineer/patch-1 [Fix] Missing spacing inside braces

view details

push time in a month

push eventgetfiit/lottie-ios

Rapsssito

commit sha 16fe16c6c19d2eb4899a4021a5eadf58ee45077d

Contiguous Arrays

view details

Rapsssito

commit sha f580eff1ace5f09f45c722a2cfe1c02d27b99677

Removed prints

view details

Benzi

commit sha beab7b65198d7528c409b749836bf9d45b9df6fb

Fix LRUAnimationCache to evict cached items This bug fix ensures that items stored in `cacheMap` are also removed when an entry from `lruList` is removed.

view details

Anders Hasselqvist

commit sha 3e8d71af2fd91f49dcf3665febf223f1f6b0a832

waitingToPlayAimation -> waitingToPlayAnimation

view details

Joris Bodin

commit sha fb596a114e067f9808191c4214478a23585e2308

Improve readme for SPM

view details

liulichao

commit sha d26a398e43ace72dd23e8315a280fc4be25709da

Fix method :-animationMovedToWindow judgment logic

view details

Jason Knight

commit sha 902b836aa4cb20d331a4dc541ce830db9951fbd7

Put CATransaction completion listener inside the begin/end block.

view details

Jason Knight

commit sha 5ea3aeda7c153076f3ebc6788cee3a893452316a

Fix stop not working by putting in CATransaction.flush in stop

view details

Marcio

commit sha 658f872a9ba2215966fe497ed875bb52c2dbc595

Fix matching parent's animation if it's not a simple CABasicAnimation

view details

TheInkedEngineer

commit sha c333dfeeecbc74d039bb56908660aa4a7939af5a

[Fix] Missing spacing inside braces Just a minor fix for people with Swift OCD.

view details

Brandon Withrow

commit sha ef3c43641c4f18c7e41a99e008a648366e1f111e

Merge pull request #1149 from liulichao123/master Fix method :-animationMovedToWindow judgment logic

view details

Brandon Withrow

commit sha 23571b5e67a692d95ed7b90044d6d695fedcbfd0

Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 86d9126e717cc2b83775d0a2de81340c07f94cf7

Merge pull request #1185 from airbnb/btw/TextLayerParagraphPosition Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 05d969640ea092b946c3047ba85ff24b9f58657d

Merge pull request #1118 from Rapsssito/refactor-array refactor: Keyframe<T> Contiguous Arrays

view details

Brandon Withrow

commit sha da8ecb86fc841cc900a7c06a86ee9d86342b009a

Merge pull request #1119 from BenziAhamed/patch-1 Fix LRUAnimationCache to evict cached items

view details

Brandon Withrow

commit sha 1b9acaba0ac4da3726e8dcc44f82b498f2e237a6

Merge pull request #1145 from nevil/typo-fix waitingToPlayAimation -> waitingToPlayAnimation

view details

Brandon Withrow

commit sha 01bf9b2a8d7631ae379c0abba2ca959eb7635acc

Merge pull request #1157 from 7jason/master Fix AnimationView.Stop()

view details

Brandon Withrow

commit sha 1bececc2ca8f8b43a4f02435b67c1878bcca147f

Merge pull request #1147 from JorisBodin/master Improve readme for SPM

view details

Brandon Withrow

commit sha f3b12bac69c2f38ed32e65b5ebd936cf06236599

Merge pull request #1163 from marciogranzotto/marcio/fix-scale-animation Fix matching parent's animation if it's not a simple CABasicAnimation

view details

Brandon Withrow

commit sha b4502eb36d2a95db179605b611e0dc7074ff6f7f

Merge pull request #1165 from TheInkedEngineer/patch-1 [Fix] Missing spacing inside braces

view details

push time in a month

push eventgetfiit/lottie-ios

Rapsssito

commit sha 16fe16c6c19d2eb4899a4021a5eadf58ee45077d

Contiguous Arrays

view details

Rapsssito

commit sha f580eff1ace5f09f45c722a2cfe1c02d27b99677

Removed prints

view details

Benzi

commit sha beab7b65198d7528c409b749836bf9d45b9df6fb

Fix LRUAnimationCache to evict cached items This bug fix ensures that items stored in `cacheMap` are also removed when an entry from `lruList` is removed.

view details

Anders Hasselqvist

commit sha 3e8d71af2fd91f49dcf3665febf223f1f6b0a832

waitingToPlayAimation -> waitingToPlayAnimation

view details

Joris Bodin

commit sha fb596a114e067f9808191c4214478a23585e2308

Improve readme for SPM

view details

liulichao

commit sha d26a398e43ace72dd23e8315a280fc4be25709da

Fix method :-animationMovedToWindow judgment logic

view details

Jason Knight

commit sha 902b836aa4cb20d331a4dc541ce830db9951fbd7

Put CATransaction completion listener inside the begin/end block.

view details

Jason Knight

commit sha 5ea3aeda7c153076f3ebc6788cee3a893452316a

Fix stop not working by putting in CATransaction.flush in stop

view details

Marcio

commit sha 658f872a9ba2215966fe497ed875bb52c2dbc595

Fix matching parent's animation if it's not a simple CABasicAnimation

view details

TheInkedEngineer

commit sha c333dfeeecbc74d039bb56908660aa4a7939af5a

[Fix] Missing spacing inside braces Just a minor fix for people with Swift OCD.

view details

Brandon Withrow

commit sha ef3c43641c4f18c7e41a99e008a648366e1f111e

Merge pull request #1149 from liulichao123/master Fix method :-animationMovedToWindow judgment logic

view details

Brandon Withrow

commit sha 23571b5e67a692d95ed7b90044d6d695fedcbfd0

Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 86d9126e717cc2b83775d0a2de81340c07f94cf7

Merge pull request #1185 from airbnb/btw/TextLayerParagraphPosition Fixedbug with paragraph text layer positions

view details

Brandon Withrow

commit sha 05d969640ea092b946c3047ba85ff24b9f58657d

Merge pull request #1118 from Rapsssito/refactor-array refactor: Keyframe<T> Contiguous Arrays

view details

Brandon Withrow

commit sha da8ecb86fc841cc900a7c06a86ee9d86342b009a

Merge pull request #1119 from BenziAhamed/patch-1 Fix LRUAnimationCache to evict cached items

view details

Brandon Withrow

commit sha 1b9acaba0ac4da3726e8dcc44f82b498f2e237a6

Merge pull request #1145 from nevil/typo-fix waitingToPlayAimation -> waitingToPlayAnimation

view details

Brandon Withrow

commit sha 01bf9b2a8d7631ae379c0abba2ca959eb7635acc

Merge pull request #1157 from 7jason/master Fix AnimationView.Stop()

view details

Brandon Withrow

commit sha 1bececc2ca8f8b43a4f02435b67c1878bcca147f

Merge pull request #1147 from JorisBodin/master Improve readme for SPM

view details

Brandon Withrow

commit sha f3b12bac69c2f38ed32e65b5ebd936cf06236599

Merge pull request #1163 from marciogranzotto/marcio/fix-scale-animation Fix matching parent's animation if it's not a simple CABasicAnimation

view details

Brandon Withrow

commit sha b4502eb36d2a95db179605b611e0dc7074ff6f7f

Merge pull request #1165 from TheInkedEngineer/patch-1 [Fix] Missing spacing inside braces

view details

push time in a month

startedSwiftDocOrg/DocTest

started time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

sorry I'm not that familiar with codebase to give credible opinion

flobories

comment created time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

your last scenario is what I was describing, where canceling from cache hides server fetch cancelation and "user of the library" never even knows that his request was canceled and restarted.

Implementation as it stands in this PR will lead to bugs where: You have watcher on object You start "fetch A" for that object You start mutation on server and fetching same object, update it in cache (from mutation) If your "fetch A" returns later than mutation, your object in cache will be reverted to "incorrect" one (as your fetch started before mutation). It will go "old object" -> "new object" (mutation) -> "old object" ("fetch A" returns)

this requires weird internet condition, but this kind of race conditions impossible to find when you need to fix

flobories

comment created time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

a) watcher = GraphQLQueryWatcher(...) { result: Result<GraphQLResult<Data>, Error> print(result) } watcher.fetch() // First A watcher.fetch() // Fetch B watcher.cancel()

Fetch B is canceled and return error as "canceled" Fetch A will succeed after some time (if this PR accepted) and will return data

b) that's a good question "what is expected behaviour?". Reading code above my first thought would be "oh, so both fetched will go in parallel and "cancel" will cancel them both at the same time" (as there no way to specify witch one to cancel) second thought would be behaviour we have now, where second fetch "replaces" first one

flobories

comment created time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha bb6b3de3fb11fab9adf10b0678767f0f0263340f

no need for cancel as its "one shot" operation

view details

push time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

the problem is that watcher = GraphQLQueryWatcher() watcher.fetch() watcher.fetch() watcher.cancel()

will have one success and one cancelation callback, and that might lead to very confusing results unless you know whole system

flobories

comment created time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha ec49c6e1394f1406a0d034b2b6e6cdd8146beb6e

no need for cancel as its "one shot" operation

view details

push time in a month

pull request commentapollographql/apollo-ios

cancel networkTask before starting new one

ok, fair point. Whenever I see something reassigned without cleanup red light comes on :)

RolandasRazma

comment created time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

thinking about both cases above I think better way is to figure out solution where canceling fetch won't call resultHandler when it's done from cache updates, or maybe not call resultHandler at all for cancelations? - what are we gaining there?.

flobories

comment created time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

also this introduces bit uncertainty in GraphQLQueryWatcher.cancel() - what are we canceling?

flobories

comment created time in a month

pull request commentapollographql/apollo-ios

Cancel watcher fetch only if new fetch includes server

hmm, not sure if this is correct solution. Wouldn't it be better to change signature to fetch(cachePolicy: CachePolicy, cancelInFlight: Bool = true) and do fetch(cachePolicy: CachePolicy, cancelInFlight: false) from cache updates?

flobories

comment created time in a month

create barnchgetfiit/apollo-ios

branch : fiit

created branch time in a month

delete branch getfiit/apollo-ios

delete branch : fiit

delete time in a month

push eventgetfiit/apollo-ios

Renovate Bot

commit sha ffe111dc947206df9a9a55216086d5e100dd0910

Update dependency gatsby-theme-apollo-docs to v4.1.4

view details

Renovate Bot

commit sha 0811e0f6df42b5fe12836741a7bbb03f632201c6

Update dependency gatsby to v2.20.12

view details

Vitali Tatarintev

commit sha 4a25e08a32233faee1f03388443b3a29bd8bebaf

Fix typo in the loadLaunchDetails() function Fixes the typo in the guard clause

view details

Ellen Shapiro

commit sha f59cdde3fc6438451794c8a8372131f678776ef9

Merge pull request #1123 from ck3g/patch-1 Fix a typo in the guard clause

view details

Eugene Kwong

commit sha 16227371190079177b9ba10e0c7aa367610bb3f2

Add ability to set the SSLTrustValidator for websocket

view details

Eugene Kwong

commit sha 40bde03d8c4a7132f06ecc22630d0d6f71192b28

Replaced `didSet` with `get` and `set`

view details

Ellen Shapiro

commit sha 92fbaea277cb6d032662d4607f558b1c0897661d

Merge pull request #1124 from scorebet/add/websocket-security Add ability to set the SSLTrustValidator for websocket

view details

Vitali Tatarintev

commit sha f9f502cda0a723cd0a934602899db71fb550ce8b

Don't compare a boolean value to true Comparing boolean values inside `if` statement to `true` is usually redundant.

view details

Vitali Tatarintev

commit sha 242ec3a4b0cdf6526ddc8da2de40016b2d403bcf

Add instructions for an import statement

view details

Rolandas Razma

commit sha eea186dfd7f358057a75c6cb0c3b65c4fe3c694a

improove HTTPNetworkTransportRetryDelegate.networkTransport(_:receivedError:for:,response:retryHandler:) to enable returning custom error

view details

Rolandas Razma

commit sha a508062d1152a9ed03087b38b1f85f55f5432aeb

update docs

view details

Rolandas Razma

commit sha 9fed2a3b14afc50ae242d1ead2d613689c6493ef

updated code example

view details

Ellen Shapiro

commit sha 7c8d3a9394c6132dace1160fa85804a853fba88d

Merge pull request #1126 from ck3g/patch-2 Don't compare a boolean value to true

view details

Ellen Shapiro

commit sha c5a548ba6d7f4ec5762f6477e504a3f4808a717c

Merge pull request #1127 from ck3g/patch-3 Add instructions to import KeychainSwift

view details

Rolandas Razma

commit sha 60cb840554c1a0fe8ec269b9cb48fbee43b7db3c

updated note

view details

Rolandas Razma

commit sha 6d33ee1f15f745dd5fed6f34f7f048d47c91b7b9

added test for returning different errors

view details

Vitali Tatarintev

commit sha d2a4bd8ef005d446807f1f6439ab5a99c0988a7a

Add a missing import of DetailUISetupPanel Adds a missing import for collapsed DetailUISetupPanel section

view details

Vitali Tatarintev

commit sha 2c31b5b8602e2fa4dd1d02aeb49ba9b56d744d78

Add instructions to import KeychainSwift

view details

Vitali Tatarintev

commit sha 45fc848b20f74bca6aa7fcb0a9c923f326c536d6

Update instructions to add cancelTrip method

view details

Ellen Shapiro

commit sha 9cf04fce0ee28e7b77b961e5fc8a818c39dfdd76

Merge pull request #1134 from ck3g/patch-4 Add a missing import of DetailUISetupPanel

view details

push time in a month

Pull request review commentapollographql/apollo-ios

cancel networkTask before starting new one

 private final class FetchQueryOperation<Query: GraphQLQuery>: AsynchronousOperat   }    func fetchFromNetwork() {+    networkTask?.cancel()     networkTask = client?.send(operation: query,                                shouldPublishResultToStore: true,-                               context: context) { result in+                               context: context) { [weak self] result in+      guard let self = self else {+        return+      }

but don't you create circular retain here? FetchQueryOperation -> client -> FetchQueryOperation

RolandasRazma

comment created time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 4115bbef76fa12ece6f9500a67181978dd3c1735

weak self

view details

push time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha cadaa7d83eaf57bee98f4ee440cb7d6968c8cca5

split tests into 2

view details

push time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 4609c4505fcbaa160860f74d5f5521f9ac652e08

weak self

view details

push time in a month

pull request commentapollographql/apollo-ios

cancel networkTask before starting new one

also added weak to not retain client

RolandasRazma

comment created time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 262e2e37018727d3788a9847f419a4b8867a19dd

weak self

view details

push time in a month

issue openedapollographql/apollo-ios

ThreadSanitizer complains about GraphQLQueryWatcher.fetch(cachePolicy:)

almost sure its same problem as https://github.com/apollographql/apollo-ios/issues/1146

Screenshot 2020-04-11 at 17 25 13

created time in a month

issue openedapollographql/apollo-ios

ThreadSanitizer complains about ApolloClient.cacheKeyForObject

probably connected to https://github.com/apollographql/apollo-ios/issues/1147

Screenshot-2020-04-11-at-17 05 35

created time in a month

PR opened apollographql/apollo-ios

cancel networkTask before starting new one

fixes https://github.com/apollographql/apollo-ios/issues/1146

+1 -0

0 comment

1 changed file

pr created time in a month

PR opened getfiit/apollo-ios

cancel networkTask before starting new one

fixes https://github.com/apollographql/apollo-ios/issues/1146

+1 -0

0 comment

1 changed file

pr created time in a month

create barnchgetfiit/apollo-ios

branch : cancel_networkTask

created branch time in a month

issue commentapollographql/apollo-ios

ThreadSanitizer complains about FetchQueryOperation.cancel()

looks like adding that cancel solves issue, will create PR

RolandasRazma

comment created time in a month

issue commentapollographql/apollo-ios

ThreadSanitizer complains about FetchQueryOperation.cancel()

looking at possible cool prints:

https://github.com/apollographql/apollo-ios/blob/cadc61bb443530ad45f2ba6a4008817342fca47e/Sources/Apollo/ApolloClient.swift#L284

don't you need to cancel networkTask before setting new one?

RolandasRazma

comment created time in a month

issue openedapollographql/apollo-ios

ThreadSanitizer complains about FetchQueryOperation.cancel()

sometimes ThreadSanitizer complains about FetchQueryOperation.cancel(). Probably worth looking into:

Screenshot-2020-04-11-at-12 35 53

stepping up the stack it comes to:

Screenshot 2020-04-11 at 12 43 09

and I have feeling we were already discussing it at some point but can't recall where

btw, what's the best way reporting ThreadSanitizer errors?

created time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 274fd1582b61c2540c319f594e778b798fa6d304

cleanup tests

view details

push time in a month

Pull request review commentapollographql/apollo-ios

improve HTTPNetworkTransportRetryDelegate to enable returning custom error

 class HTTPTransportTests: XCTestCase {     self.wait(for: [expectation], timeout: 10)   }   +  func testRetryDelegateReturnsCorrectError() throws {

There is "retry" test already (StarWarsServerTests:28, HTTPTransportTests:412). The only test that was needed is returning correct error.

RolandasRazma

comment created time in a month

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha e19078e6abdd026fd93e791d4f595b4f768f92a8

cleanup tests

view details

push time in a month

pull request commentapollographql/apollo-ios

improve HTTPNetworkTransportRetryDelegate to enable returning custom error

Can you please add a test validating that your feature request is working the way you think it should - that is, on a retry, you get the correct error?

added test. Not rly in style you doing, so let me know if you want me to change it

RolandasRazma

comment created time in 2 months

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 6d33ee1f15f745dd5fed6f34f7f048d47c91b7b9

added test for returning different errors

view details

push time in 2 months

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 60cb840554c1a0fe8ec269b9cb48fbee43b7db3c

updated note

view details

push time in 2 months

Pull request review commentapollographql/apollo-ios

improve HTTPNetworkTransportRetryDelegate to enable returning custom error

 public protocol HTTPNetworkTransportRetryDelegate: HTTPNetworkTransportDelegate   ///   - request: The URLRequest which generated the error   ///   - response: [Optional] Any response received when the error was generated   ///   - retryHandler: A closure indicating whether the operation should be retried. Asyncrhonous to allow for re-authentication or other async operations to complete.+  @available(*, deprecated, message: "Use networkTransport(_:receivedError:for:,response:continueHandler:) instead")   func networkTransport(_ networkTransport: HTTPNetworkTransport,                         receivedError error: Error,                         for request: URLRequest,                         response: URLResponse?,                         retryHandler: @escaping (_ shouldRetry: Bool) -> Void)+  +  /// Called when an error has been received after a request has been sent to the server to see if an operation should be retried or not.+  /// NOTE: Don't just call the `retryHandler` with `true` all the time, or you can potentially wind up in an infinite loop of errors

done

RolandasRazma

comment created time in 2 months

Pull request review commentapollographql/apollo-ios

improve HTTPNetworkTransportRetryDelegate to enable returning custom error

 public protocol HTTPNetworkTransportRetryDelegate: HTTPNetworkTransportDelegate   ///   - request: The URLRequest which generated the error   ///   - response: [Optional] Any response received when the error was generated   ///   - retryHandler: A closure indicating whether the operation should be retried. Asyncrhonous to allow for re-authentication or other async operations to complete.+  @available(*, deprecated, message: "Use networkTransport(_:receivedError:for:,response:continueHandler:) instead")

hmm, I don't see deprecation warning unless I implement method in my delegate. Or I'm missing something?

RolandasRazma

comment created time in 2 months

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha 9fed2a3b14afc50ae242d1ead2d613689c6493ef

updated code example

view details

push time in 2 months

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha a508062d1152a9ed03087b38b1f85f55f5432aeb

update docs

view details

push time in 2 months

PR opened apollographql/apollo-ios

improove HTTPNetworkTransportRetryDelegate to enable returning custom error

solves use case described in https://github.com/apollographql/apollo-ios/issues/1121 where delegate might want to return different error depending on logic

+63 -15

0 comment

3 changed files

pr created time in 2 months

create barnchgetfiit/apollo-ios

branch : issues_1121

created branch time in 2 months

issue commentapollographql/apollo-ios

returning different error in -[HTTPNetworkTransportRetryDelegate networkTransport:receivedError:for:response:retryHandler]

updated ticket with code samples, maybe will be easier to understand

RolandasRazma

comment created time in 2 months

issue commentapollographql/apollo-ios

returning different error in -[HTTPNetworkTransportRetryDelegate networkTransport:receivedError:for:response:retryHandler]

no, because my token update fails I know that there is no point in retrying, in delegate say "don't retry" - everything works correctly. Except that logically I have different error (from token update) and not from apollo, but I have no way of propagating it up the chain

RolandasRazma

comment created time in 2 months

issue openedapollographql/apollo-ios

returning different error in -[HTTPNetworkTransportRetryDelegate networkTransport:receivedError:for:response:retryHandler]

The problem I'm facing: doing apolloClient.fetch() request fails for reason Y (getting 401 to delegate) trying to update token token update fails for reason X request fails and callback in apolloClient.fetch() see error Y, where real error is X

What I would like to do is to modify (add new one and deprecate existing one) -[HTTPNetworkTransportRetryDelegate networkTransport:receivedError:for:response:retryHandler] where you could return different error if you don't want to retry request

does that make sense @designatednerd or maybe there is better way to do that?

created time in 2 months

PR closed apollographql/apollo-ios

add request to GraphQLHTTPResponseError for easier debugging

Was trying to trace some problems with auth and it was very useful to see what we actually send to server (headers in particular)

+18 -8

4 comments

3 changed files

RolandasRazma

pr closed time in 2 months

pull request commentapollographql/apollo-ios

add request to GraphQLHTTPResponseError for easier debugging

I think you can close it as its limited use, I personally can't use it from delegate but that's more of architectural limitation than Apollo problem

RolandasRazma

comment created time in 2 months

pull request commentapollographql/apollo-ios

add request to GraphQLHTTPResponseError for easier debugging

thought you will say so :)

RolandasRazma

comment created time in 2 months

PR opened apollographql/apollo-ios

add request to GraphQLHTTPResponseError for easier debugging

Was trying to trace some problems with auth and it was very useful to see what we actually send to server (headers in particular)

+18 -8

0 comment

3 changed files

pr created time in 2 months

push eventgetfiit/apollo-ios

Rolandas Razma

commit sha acd42b120e88af5a4440b13f6fbddad0a2753c3f

add request to GraphQLHTTPResponseError for easier debugging

view details

Rolandas Razma

commit sha a3c4ad85ac45bce02da3f6da990a420ba505b88b

Merge pull request #1 from getfiit/add_request_to_error add request to GraphQLHTTPResponseError for easier debugging

view details

push time in 2 months

create barnchgetfiit/apollo-ios

branch : add_request_to_error

created branch time in 2 months

create barnchgetfiit/apollo-ios

branch : fiit

created branch time in 2 months

push eventgetfiit/stripe-ios

Rolandas Razma

commit sha f6fd41a80918a71839556f1507da80e4d2a39c3b

update callback signature

view details

push time in 2 months

create barnchgetfiit/stripe-ios

branch : fiit

created branch time in 2 months

PR opened airbnb/lottie-ios

fix text not being updated if textProvider is set after animation

fix text not being updated if textProvider is set after animation. This doesn't fix case where text change - you will need to set new (or same) provider again

+19 -4

0 comment

4 changed files

pr created time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha 2211ad5fbbc817e073568044af15a219911c3fcb

update layer if textProvider changed

view details

Rolandas Razma

commit sha 18197de52c2f95b3b1395e03c15b5d95912400b9

Merge branch 'layerTextProvider' into fiit

view details

push time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha 2211ad5fbbc817e073568044af15a219911c3fcb

update layer if textProvider changed

view details

push time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha ea9c1fa8aadc809a071bbcfe817b09f4bc4413e3

pass layerTextProvider same as layerImageProvider

view details

Rolandas Razma

commit sha 032b7b4ee5967f5e6c6af9639342e4f78af08162

Merge pull request #4 from getfiit/layerTextProvider pass layerTextProvider same as layerImageProvider

view details

push time in 2 months

create barnchgetfiit/lottie-ios

branch : layerTextProvider

created branch time in 2 months

issue commentairbnb/lottie-ios

Edit text when animation is loaded

class TextProvider: AnimationTextProvider {
	
	...
	
    // MARK: - AnimationTextProvider
    
    func textFor(keypathName: String, sourceText: String) -> String {
       if name1 == keypathName {
              return text1
       }
       else if name2 == keypathName {
              return text2
       }
       else if name3 == keypathName {
              return text3
       }
       else if name4 == keypathName {
              return text4
       }
       
       return sourceTextelf.sourceText
    }
    
}
KamilGrotowski

comment created time in 2 months

issue commentairbnb/lottie-ios

Edit text when animation is loaded

you can edit as many layers as you want. Everything is handled by AnimationTextProvider protocol

KamilGrotowski

comment created time in 2 months

issue commentairbnb/lottie-ios

Edit text when animation is loaded

class TextProvider: AnimationTextProvider {
    let keypathName: String
    let sourceText: String
    
    init(keypathName: String, sourceText: String) {
        self.keypathName = keypathName
        self.sourceText = sourceText
    }
    
    // MARK: - AnimationTextProvider
    
    func textFor(keypathName: String, sourceText: String) -> String {
        guard keypathName == self.keypathName else { return sourceText }
        
        return self.sourceText
    }
    
}

animationView.textProvider = TextProvider(keypathName: "main_text", sourceText: "your text")

Text is cached and will be requested only once. As far as I can say the only way to update it is to set animation again. (animationView.animation ...)

KamilGrotowski

comment created time in 2 months

PR opened airbnb/lottie-ios

expose value providers
+13 -3

0 comment

2 changed files

pr created time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha a90a86da94c8aaaf0ac47dddb953d1c4b09bfc77

expose value providers

view details

Rolandas Razma

commit sha 9fe1565486403c8ccc7551d7c91b9dc117b86820

Merge branch 'expose_value_providers' into fiit # Conflicts: # lottie-swift/src/Private/LayerContainers/AnimationContainer.swift # lottie-swift/src/Public/Animation/AnimationView.swift

view details

push time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha a90a86da94c8aaaf0ac47dddb953d1c4b09bfc77

expose value providers

view details

push time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha 1ecdb5488bc2dc295f7092788b8df988770ee5da

expose value providers

view details

push time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha 74e76cefe1d0ff5c2025e806a803f6c6bd4a3ccd

expose value providers

view details

Rolandas Razma

commit sha ff0516ed790fb78b55d0147b8d46b269690ae0a2

Merge pull request #3 from getfiit/epose_value_providers expose value providers

view details

push time in 2 months

delete branch getfiit/lottie-ios

delete branch : epose_value_providers

delete time in 2 months

PR merged getfiit/lottie-ios

expose value providers
+13 -3

0 comment

2 changed files

RolandasRazma

pr closed time in 2 months

PR opened getfiit/lottie-ios

expose value providers
+13 -3

0 comment

2 changed files

pr created time in 2 months

create barnchgetfiit/lottie-ios

branch : expose_value_providers

created branch time in 2 months

create barnchgetfiit/lottie-ios

branch : epose_value_providers

created branch time in 2 months

PR opened airbnb/lottie-ios

Update Vectors.swift

make properties public make Vector3D immutable (same as Vector1D)

+4 -4

0 comment

1 changed file

pr created time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha beaacbec0c060a786b6114804a4bcf3758312d5b

Update Vectors.swift make properties public make Vector3D immutable (same as Vector1D)

view details

Rolandas Razma

commit sha 5102dbfe462aaecacde0405bf747e40e3664e18b

Merge pull request #2 from getfiit/update_access_for_vectors Update Vectors.swift

view details

push time in 2 months

PR merged getfiit/lottie-ios

Update Vectors.swift

make properties public make Vector3D immutable (same as Vector1D)

+4 -4

0 comment

1 changed file

RolandasRazma

pr closed time in 2 months

PR opened getfiit/lottie-ios

Update Vectors.swift

make properties public make Vector3D immutable (same as Vector1D)

+4 -4

0 comment

1 changed file

pr created time in 2 months

create barnchgetfiit/lottie-ios

branch : update_access_for_vectors

created branch time in 2 months

push eventgetfiit/lottie-ios

Rolandas Razma

commit sha a619f3b88989e015c4ef0b451913fe8a8119e01c

fix keypath traversal

view details

Rolandas Razma

commit sha d5cf20b1a844398377129863235009805e05d194

Merge pull request #1 from getfiit/fix-keypath-traversal fix keypath traversal

view details

push time in 2 months

PR opened getfiit/lottie-ios

fix keypath traversal
+5 -6

0 comment

1 changed file

pr created time in 2 months

create barnchgetfiit/lottie-ios

branch : fiit

created branch time in 2 months

pull request commentairbnb/lottie-ios

fix keypath traversal

if this PR is correct, wonder about https://github.com/airbnb/lottie-ios/blob/master/lottie-swift/src/Private/Utility/Extensions/AnimationKeypathExtension.swift#L75 - that looks wrong as well

RolandasRazma

comment created time in 2 months

more