profile
viewpoint

pull request commentapollographql/apollo-ios

Introducing delegate if there is GraphQL errors

maybe it's me, but I like to code defensively 🤷‍♂

kimdv

comment created time in 3 days

pull request commentapollographql/apollo-ios

Introducing delegate if there is GraphQL errors

I am. I'm thinking about case where server say "token invalid", I update token, and server say "still invalid". Correct thing to do is to give up, but I don't know that I already tried to update token

kimdv

comment created time in 3 days

pull request commentapollographql/apollo-ios

Introducing delegate if there is GraphQL errors

how do you know if failure after retrying? if request fails and you call retryHandler(true) and it fails again I don't see how to know that you should just give up

kimdv

comment created time in 3 days

issue commenttrivago/Heimdallr.swift

Keep refresh token if the server does not return a new one on token refresh

we have this workaround in place

public class TokenServiceStore: OAuthAccessTokenStore {
    
    private let tokenKeychainStore: OAuthAccessTokenKeychainStore
    
    public init(service: String) {
        tokenKeychainStore = OAuthAccessTokenKeychainStore(service: service)
    }
    
    public func storeAccessToken(_ accessToken: OAuthAccessToken?) {
        if let accessToken = accessToken, accessToken.refreshToken == nil, let oldRefreshToken = retrieveAccessToken()?.refreshToken {
            tokenKeychainStore.storeAccessToken(OAuthAccessToken(accessToken: accessToken.accessToken, tokenType: accessToken.tokenType, expiresAt: accessToken.expiresAt, refreshToken: oldRefreshToken))
        } else {
            tokenKeychainStore.storeAccessToken(accessToken)
        }
    }
    
    public func retrieveAccessToken() -> OAuthAccessToken? {
        return tokenKeychainStore.retrieveAccessToken()
    }
    
}

let heimdallr: Heimdallr = Heimdallr(..., accessTokenStore: TokenServiceStore(service: ...), ...)
poislagarde

comment created time in 5 days

startedSwipeCellKit/SwipeCellKit

started time in 13 days

issue openedReactiveX/RxSwift

Crash on runtime if SPM is used

If I use SPM for Rx* it fails to create ReplaySubject on runtime with EXC_BAD_ACCESS. It does work if I use CocoPods

import UIKit
import RxSwift

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
    
    private let modelSubject = ReplaySubject<Bool>.create(bufferSize: 1)
    
    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        return true
    }
    
}

RxSwift/RxCocoa/RxBlocking/RxTest version/commit

RxSwift 5.0.1

Platform/Environment

  • [x] iOS
  • [ ] macOS
  • [ ] tvOS
  • [ ] watchOS
  • [ ] playgrounds

How easy is to reproduce? (chances of successful reproduce after running the self contained code)

  • [x] easy, 100% repro

Xcode version:

11.2 beta (11B41)

Installation method:

  • [x] SPM
  • [ ] CocoaPods
  • [ ] Carthage
  • [ ] Git submodules

I have multiple versions of Xcode installed: (so we can know if this is a potential cause of your issue)

  • [ ] yes (which ones)
  • [x] no

Screenshot 2019-10-27 at 09 03 08

Screenshot 2019-10-27 at 09 03 00

Screenshot 2019-10-27 at 09 04 10

created time in 21 days

startedxmartlabs/XLPagerTabStrip

started time in 22 days

issue openedmalcommac/SwiftDate

Probably not a bug but bit unexpected

Probably not a bug but bit unexpected

SwiftDate.defaultRegion = .local

let now = Date()
        
print(
    (now.addingTimeInterval(3600) - now).in(.hour) == 1,
    (now.addingTimeInterval(3600) - now) == 1.hours
)

will output true, false

created time in 25 days

issue commentCosmo/BinaryKit

I'm sure I'm doing something wrong

actually this no longer works on master, works on 3.0.1 tag

RolandasRazma

comment created time in 25 days

issue openedCosmo/BinaryKit

I'm sure I'm doing something wrong

I'm sure I'm doing something wrong, could you point me right direction please? Im trying to read signed value but not sure how to correctly read negative one.

I added category to accomplish this

extension Binary {
    
    mutating func readSignedBits(quantitiy: Int) throws -> Int {
        
        if try readBit() == 1 {
            let bit = try readBits(quantitiy: quantitiy - 1)

            // this works
            return -(bit ^ Int(UInt8.max)) - 1
            
            // and this works
            // let bitsReversed = String(String(bit, radix: 2).map({ $0 == "1" ? "0" : "1" }))
            // return -Int(bitsReversed, radix: 2)! - 1
        } else {
            return try readBits(quantitiy: quantitiy - 1)
        }
        
    }
    
}

but it doesn't "feel" right

created time in a month

issue commentmalcommac/SwiftDate

RelativeFormatters don't work with Swift Package Manager

I was more thinking about app "Build Phase" "Run Script" that you have to add manually as a workaround

drewdeponte

comment created time in a month

issue commentmalcommac/SwiftDate

RelativeFormatters don't work with Swift Package Manager

would some kindof "Run script" phase would help as a temp fix?

drewdeponte

comment created time in a month

release getfiit/SwiftRichString

3.0.4

released time in a month

created taggetfiit/SwiftRichString

tag3.0.4

Elegant & painless Attributed Strings in Swift

created time in a month

push eventgetfiit/SwiftRichString

Rolandas Razma

commit sha 63f340fc776aa819c3a77c46faaadffab1fb102c

allow setting nil to styledText

view details

Rolandas Razma

commit sha 028ad9b386044febe924a4048f07f77566aa99f7

Merge pull request #1 from getfiit/styledText_fix_nil allow setting nil to styledText

view details

push time in a month

create barnchgetfiit/SwiftRichString

branch : styledText_fix_nil

created branch time in a month

issue commentmalcommac/SwiftDate

RelativeFormatters don't work with Swift Package Manager

at least it should not crash :) ATM it crashing in suitableFlavour localeData.flavours[Flavour.long.rawValue].

drewdeponte

comment created time in a month

created tagRolandasRazma/Cifaddrs

tag1.0.3

C module map for ifaddrs

created time in a month

release RolandasRazma/Cifaddrs

1.0.3

released time in a month

push eventRolandasRazma/Cifaddrs

Rolandas Razma

commit sha 6faceb085a7b6b3909c71409bafb312457645338

Update Package.swift add swift-tools-version

view details

push time in a month

fork RolandasRazma/Cifaddrs

C module map for ifaddrs

fork in a month

PR opened pebble8888/ed25519swift

Swift PM support

Thank you so much for this lib.

I added Swift PM support (after merging you will need to add new tag 1.2.1 for it to start working)

+88 -40

0 comment

10 changed files

pr created time in 2 months

push eventRolandasRazma/ed25519swift

Rolandas Razma

commit sha 06a7b6e77c722a66ac5b7c831e8de7da1d891ea8

Swift Package

view details

push time in 2 months

created tagRolandasRazma/ed25519swift

tag1.2.1

ed25199 implementation by pure swift

created time in 2 months

push eventRolandasRazma/ed25519swift

Rolandas Razma

commit sha 0d099f28df8932f438eedb1cc76d0c29bc086dfa

Swift Package

view details

push time in 2 months

push eventRolandasRazma/ed25519swift

Rolandas Razma

commit sha 4632e836d64353de1b1151cf1718c9de42bca7ef

Swift Package

view details

push time in 2 months

fork RolandasRazma/ed25519swift

ed25199 implementation by pure swift

fork in 2 months

issue openedp2/OAuth2

Use of unresolved identifier 'OAuth2Authorizer/OAuth2CustomAuthorizer' on WatchOS

Added to WatchOS target using swift PM, but getting "Use of unresolved identifier 'OAuth2Authorizer'/OAuth2CustomAuthorizer" error

/OAuth2/Sources/Flows/OAuth2.swift:80:16: Use of unresolved identifier 'OAuth2Authorizer' /OAuth2/Sources/Flows/OAuth2PasswordGrant.swift:70:61: Use of unresolved identifier 'OAuth2CustomAuthorizer'

created time in 2 months

pull request commentapollographql/apollo-ios

use queue in InMemoryNormalizedCache to avoid race conditions

should we keep this open until it can be addressed properly so other people would know about problem?

RolandasRazma

comment created time in 2 months

issue commenttrivago/Heimdallr.swift

Support for Swift Package Manager ?

any update on this? With Xcode 11 SwiftPM is build in and would be nice to use it

mackoj

comment created time in 2 months

pull request commentapollographql/apollo-ios

use queue in InMemoryNormalizedCache to avoid race conditions

I guess decision has to be made who is responsible for locking properly. "Store" or its users. There is already locking mechanism in Apollo itself, so adding another one on store does look like redundant. On the other hand, if to look from separation point, there might be several different "stores" and some of them might not even require locking

RolandasRazma

comment created time in 2 months

issue commentmalcommac/SwiftRichString

linkURL issue with UITextView

@jeremy6462 I'm not sure you should close it. Only maintainers can say if it's a bug or feature. Your thinking process looks legit even if library not designed to be used like that

jeremy6462

comment created time in 2 months

issue commentmalcommac/SwiftRichString

linkURL issue with UITextView

with your example it generates { NSLink = "SwiftRichString.URLRepresentable.url(test://)"; } with is clearly invalid link. So I guess the questions is: are you using Lin correctly or is it a bug :)

jeremy6462

comment created time in 2 months

issue commentmalcommac/SwiftRichString

linkURL issue with UITextView

interestingly enough if you replace your textView.attributedText = with textView.attributedText = "<a>Test</a>".set(style: StyleGroup(["a": style])) it does work

jeremy6462

comment created time in 2 months

issue commentmalcommac/SwiftRichString

linkURL issue with UITextView

your class needs to conform to UITextViewDelegate. (class MyVc: UITextViewDelegate {}) Simply adding method is not enough

jeremy6462

comment created time in 2 months

issue commentstripe/stripe-ios

STPShippingAddressViewController country field

for #1 you can set paymentContext.prefilledInformation with country you want

odedharth

comment created time in 3 months

more