maybe it's me, but I like to code defensively 🤷‍♂

I am. I'm thinking about case where server say "token invalid", I update token, and server say "still invalid". Correct thing to do is to give up, but I don't know that I already tried to update token

how do you know if failure after retrying? if request fails and you call retryHandler(true) and it fails again I don't see how to know that you should just give up

we have this workaround in place

public class TokenServiceStore: OAuthAccessTokenStore {
    
    private let tokenKeychainStore: OAuthAccessTokenKeychainStore
    
    public init(service: String) {
        tokenKeychainStore = OAuthAccessTokenKeychainStore(service: service)
    }
    
    public func storeAccessToken(_ accessToken: OAuthAccessToken?) {
        if let accessToken = accessToken, accessToken.refreshToken == nil, let oldRefreshToken = retrieveAccessToken()?.refreshToken {
            tokenKeychainStore.storeAccessToken(OAuthAccessToken(accessToken: accessToken.accessToken, tokenType: accessToken.tokenType, expiresAt: accessToken.expiresAt, refreshToken: oldRefreshToken))
        } else {
            tokenKeychainStore.storeAccessToken(accessToken)
        }
    }
    
    public func retrieveAccessToken() -> OAuthAccessToken? {
        return tokenKeychainStore.retrieveAccessToken()
    }
    
}

let heimdallr: Heimdallr = Heimdallr(..., accessTokenStore: TokenServiceStore(service: ...), ...)

If I use SPM for Rx* it fails to create ReplaySubject on runtime with EXC_BAD_ACCESS. It does work if I use CocoPods

import UIKit
import RxSwift

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
    
    private let modelSubject = ReplaySubject<Bool>.create(bufferSize: 1)
    
    func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
        return true
    }
    
}

RxSwift/RxCocoa/RxBlocking/RxTest version/commit

RxSwift 5.0.1

Platform/Environment

• [x] iOS
• [ ] macOS
• [ ] tvOS
• [ ] watchOS
• [ ] playgrounds

How easy is to reproduce? (chances of successful reproduce after running the self contained code)

• [x] easy, 100% repro

Xcode version:

11.2 beta (11B41)

Installation method:

• [x] SPM
• [ ] CocoaPods
• [ ] Carthage
• [ ] Git submodules

I have multiple versions of Xcode installed: (so we can know if this is a potential cause of your issue)

• [ ] yes (which ones)
• [x] no

Probably not a bug but bit unexpected

SwiftDate.defaultRegion = .local

let now = Date()
        
print(
    (now.addingTimeInterval(3600) - now).in(.hour) == 1,
    (now.addingTimeInterval(3600) - now) == 1.hours
)

will output true, false

actually this no longer works on master, works on 3.0.1 tag

I'm sure I'm doing something wrong, could you point me right direction please? Im trying to read signed value but not sure how to correctly read negative one.

I added category to accomplish this

extension Binary {
    
    mutating func readSignedBits(quantitiy: Int) throws -> Int {
        
        if try readBit() == 1 {
            let bit = try readBits(quantitiy: quantitiy - 1)

            // this works
            return -(bit ^ Int(UInt8.max)) - 1
            
            // and this works
            // let bitsReversed = String(String(bit, radix: 2).map({ $0 == "1" ? "0" : "1" }))
            // return -Int(bitsReversed, radix: 2)! - 1
        } else {
            return try readBits(quantitiy: quantitiy - 1)
        }
        
    }
    
}

but it doesn't "feel" right

I was more thinking about app "Build Phase" "Run Script" that you have to add manually as a workaround

would some kindof "Run script" phase would help as a temp fix?

at least it should not crash :) ATM it crashing in suitableFlavour localeData.flavours[Flavour.long.rawValue].

Thank you so much for this lib.

I added Swift PM support (after merging you will need to add new tag 1.2.1 for it to start working)

Added to WatchOS target using swift PM, but getting "Use of unresolved identifier 'OAuth2Authorizer'/OAuth2CustomAuthorizer" error

/OAuth2/Sources/Flows/OAuth2.swift:80:16: Use of unresolved identifier 'OAuth2Authorizer' /OAuth2/Sources/Flows/OAuth2PasswordGrant.swift:70:61: Use of unresolved identifier 'OAuth2CustomAuthorizer'

should we keep this open until it can be addressed properly so other people would know about problem?

any update on this? With Xcode 11 SwiftPM is build in and would be nice to use it

I guess decision has to be made who is responsible for locking properly. "Store" or its users. There is already locking mechanism in Apollo itself, so adding another one on store does look like redundant. On the other hand, if to look from separation point, there might be several different "stores" and some of them might not even require locking

@jeremy6462 I'm not sure you should close it. Only maintainers can say if it's a bug or feature. Your thinking process looks legit even if library not designed to be used like that

with your example it generates { NSLink = "SwiftRichString.URLRepresentable.url(test://)"; } with is clearly invalid link. So I guess the questions is: are you using Lin correctly or is it a bug :)

interestingly enough if you replace your textView.attributedText = with textView.attributedText = "<a>Test</a>".set(style: StyleGroup(["a": style])) it does work

your class needs to conform to UITextViewDelegate. (class MyVc: UITextViewDelegate {}) Simply adding method is not enough

for #1 you can set paymentContext.prefilledInformation with country you want