profile
viewpoint
Jesse Katsumata Naturalclar @react-native-community Chiba, Japan https://naturalclar.dev Engineer @CureApp Member of @react-native-community and @reason-react-native. Maintaining Japanese Translation of @gatsbyjs

moxci/moxci 32

Tool to notify circleci artifact to pull requests and/or slack channel

Naturalclar/battleship-node 3

A Simple Battleship Game made with Node.js

Naturalclar/blog.naturalclar.dev 1

Naturalclar's blog

Naturalclar/2048 0

A small clone of 1024 (https://play.google.com/store/apps/details?id=com.veewo.a1024)

Naturalclar/amplify-js 0

A declarative JavaScript library for application development using cloud services.

Naturalclar/apsl-react-native-button 0

A React Native button component customizable via props

Naturalclar/art 0

React Native module that allows you to draw vector graphics.

Naturalclar/asdf-alp 0

alp plugin for asdf version manager

Naturalclar/asdf-cue 0

CUE plugin for asdf version manager

pull request commentNaturalclar/expo-typescript-starter

chore(deps-dev): bump metro-react-native-babel-preset from 0.58.0 to 0.62.0

Artifact can be viewed here: : https://441-170030551-gh.circle-artifacts.com/0/storybook-static/index.html

dependabot-preview[bot]

comment created time in a day

delete branch Naturalclar/scaffdog

delete branch : docs/fixGrammar

delete time in 2 days

PR opened Naturalclar/react-native-sketchbook

demo: reg-suit

demo for reg-suit

+2 -3

0 comment

1 changed file

pr created time in 4 days

create barnchNaturalclar/react-native-sketchbook

branch : demo/reg-suit

created branch time in 4 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 5f9f7498c736ef94ac874d11d349afa993261e93

feat: add sample pages

view details

push time in 4 days

push eventNaturalclar/Recoil

Pocket7878

commit sha 5ca385ade41e67d237b0d02a326ea8a90b3ff335

fix: Fix rollup.config.js to handling CommonJS, ESM, ESM for Browser, UMD correctly. (#433) Summary: FIX issue from previous PR: https://github.com/facebookexperimental/Recoil/pull/413 Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/433 Reviewed By: drarmstr Differential Revision: D22419761 Pulled By: mondaychen fbshipit-source-id: c9f86304dfc33abd755db249ea9b3d2c30d16ff8

view details

Dave McCabe

commit sha 856c561e989ae5b89c4b137fed87fe2c9ae0921f

Move dependencies out of TreeState Summary: [Unrevert with fix for performance problems, which can be found at `selector_OLD` in `cacheKeyFromDepValues`] Move node dependencies out of TreeState so that they can be updated without a React render -- and likewise for validated atom values. This means that we never have to re-render in response to a read. This both improves performance and is important for CM.- * Update tests to test the selector implementation in actual use. * As discussed before Christian will take it from here on the new selector implementation. It is commented out because otherwise Flow would not pass. * Drive-by fix of some tests that counted renders instead of commits. * Drive-by fix of MLHub tests that relied on effects being executed but didn't wait for them to be executed. I don't know why these tests worked before. (heads-up suchanl) Reviewed By: drarmstr Differential Revision: D22450204 fbshipit-source-id: 95d5275143d7fbbb44a988b48a687f7346a877b6

view details

Douglas Armstrong

commit sha 4537ac086f0fcff423f5fc40ae779f30d839952b

Fix relative imports for Recoil_traverseDepGraph.js Summary: The open source `yarn flow` is failing because relative type imports were not used in `Recoil_traverseDepGraph.js` from D21878175 (https://github.com/facebookexperimental/recoil/commit/a1613c401abfc7e2a775128ea6295c6dab26fc3e) Reviewed By: aaronabramov Differential Revision: D22441232 fbshipit-source-id: d8dceceb779a729b844a9acf022fd4a41d980916

view details

Mark

commit sha 53abe57f4b2feae569b82c0f7a2ace933d6d3cf1

fix wrong variable name that may cause confusion (#453) Summary: Since Graph using Upstream Node dependencies, key should be name downstream Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/453 Reviewed By: davidmccabe Differential Revision: D22443319 Pulled By: drarmstr fbshipit-source-id: 961550e7577354e0840e1605823ae37ec4564e5b

view details

Jesse Katsumata

commit sha 403450afebea3665c7e64dcca9a8dd83611a0e6e

chore: modify flowconfig to fix ci fail (#450) Summary: Modified flowconfig since the CI was failing Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/450 Reviewed By: mondaychen Differential Revision: D22447384 Pulled By: drarmstr fbshipit-source-id: c9e4ab0890a298656dc9c0810478f197fca484ee

view details

Daniel Sainati

commit sha 3fd5278acfc12c54a26a73fdad7571e52492e220

add codes to suppressions in www Summary: This updates `www` suppressions to use error codes. This diff was generated by running ``` ~/fbsource/fbcode/flow/tool update-suppressions ~/www --bin ~/fbsource/fbcode/flow/facebook/flowd hg status -n --rev master | xargs -P 20 -n 1000 prettier --write --require-pragma hg status -n --rev master | xargs grep -P -l '@(partially-)?generated' | xargs hg revert -r master hg status -n --rev master | xargs grep -P -l 'lightSyntaxTransform' | xargs hg revert -r master flow --json | jq -r '.errors[] | .message[] | .loc.source' | sort -u | xargs hg revert -r master arc rebuild hg st -n | xargs -n 500 hg commit -m "[Flow][Codemod] add codes to suppressions in www" ``` on top of D22399626 bypass-lint allow_many_files drop-conflicts Reviewed By: pieterv Differential Revision: D22462399 fbshipit-source-id: 95296632f9c33320685339978078fecc2016dd33

view details

Douglas Armstrong

commit sha 68f5de43cf73ef52ffe24aceea91f85bab002cb9

Parameterize atomFamily effects (#449) Summary: Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/449 Allow parameterization of atom effects with `atomFamily()`, similar to default values. Reviewed By: csantos42 Differential Revision: D22299613 fbshipit-source-id: b1981ad511b1438a0063f7f650cd30c4c7866373

view details

Douglas Armstrong

commit sha f7cc45fc1d98e492db6fa71961c2409ce47ece97

Async Atom effect initialization (#448) Summary: Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/448 Explore async atoms by adding subset of functionality to initialize an atom via a Promise with an atom effect. This follows the semantics in [RFC Async Atoms](https://fb.quip.com/TUAhAfJI1CfJ). If an atom is initialized to a pending async value, then set to a new value before the promise resolves, the resolved async value is ignored. If the promise is rejected, then the atom will enter an error state and throw as appropriate during render. Reviewed By: csantos42 Differential Revision: D22271167 fbshipit-source-id: 735a6a21882759d68eb70980abb64d10e532921a

view details

Douglas Armstrong

commit sha 04ad727353b4c6a6f1de60a6c792441fc3cafe7a

Allow an initialized async value to be aborted (#465) Summary: Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/465 Allow initialization of an atom to an async value to be aborted by resolving the promise to `DefaultValue`. Reviewed By: csantos42 Differential Revision: D22351007 fbshipit-source-id: d76a26e1be221595e3d2775bb94457547a7caa08

view details

Daniel Sainati

commit sha 5068281efbcd12a6ff3759eb005f12a5e5da90aa

final round of adding codes to suppressions in www Summary: This updates `www` suppressions to use error codes. This diff was generated by running ``` ~/fbsource/fbcode/flow/tool update-suppressions ~/www --bin ~/fbsource/fbcode/flow/facebook/flowd hg status -n --rev master | xargs -P 20 -n 1000 prettier --write --require-pragma hg status -n --rev master | xargs grep -P -l '@(partially-)?generated' | xargs hg revert -r master hg status -n --rev master | xargs grep -P -l 'lightSyntaxTransform' | xargs hg revert -r master flow --json | jq -r '.errors[] | .message[] | .loc.source' | sort -u | xargs hg revert -r master arc rebuild ``` on top of D22399626 bypass-lint allow_many_files drop-conflicts Reviewed By: pieterv Differential Revision: D22508761 fbshipit-source-id: 95ed7c57a6c6f0e09327a299b443993fc6539184

view details

Ryan Price

commit sha 7630dbe6b46d6f391ff379e5b0a31195c82162a1

Save dependencies changes as we go Summary: Save dependencies to the store during selector evaluation to avoid blowups in certain poorly-characterized cases. Reviewed By: drarmstr Differential Revision: D22520863 fbshipit-source-id: c586896f5c7ea27a17e7914a1d7701b2b4340454

view details

Jaen Saul

commit sha 892ce995dab8e1e26a27ca0c94f33234102a9ac6

Recoil: Refactor Array.reduce anti-pattern Summary: `reduce()`-ing on non-scalar types is an antipattern, because it is (in this instance and also typically): * O(n^2) in the number of elements (since it copies the object on each iteration). * Less readable than the alternative of just using `for-of`. Reviewed By: drarmstr Differential Revision: D21823231 fbshipit-source-id: d45990b5fa1ab2d398098c966eb9bf3ce195efa4

view details

Dave McCabe

commit sha f6f87655c75192849a8fca4d37194a68732af96c

Faster hooks Summary: Currently the most common Recoil hooks are implemented in terms of the more complex and deprecated `useInterface` hook, in order to reduce code redundancy. This imposes a large performance penalty on the common case. In particular, the slow speed of these hooks is blocking Proton from using Recoil in a large number of components. This diff reduces the time taken by `useRecoilState` from an average of 17 microseconds to 2 microseconds, as compared with around 1 microsecond for `useState` by itself. The downside is some code semi-duplication between these hooks and `useInterface`, but hopefully this condition is short-lived. Reviewed By: drarmstr Differential Revision: D22543064 fbshipit-source-id: 52d50c2ad8f8ec2ec12d66a9de12073905ad3f81

view details

Douglas Armstrong

commit sha d175211c70a888cd60df2d79be09ab2b5ad6239b

Recoil transactions should create a new TreeState version (#463) Summary: Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/463 Recoil tracks state versions and updates each version with a batch commit. The version is important for tracking async resolutions and concurrent mode. Going to a previous `Snapshot` with `useGotoRecoilSnapshot()` would revert to the previous `TreeState` versions, which is good. However, going to a mutated snapshot for atomic transactions did not update the `TreeState` version. Also, going to a previous snapshot would then simply increment the version with subsequent state changes and conflict with that other previous version. This diff fixes that by using a new version for each batch commit, `Snapshot` mutation, or fresh `Snapshot` construction. The state version can be exposed as a `Snapshot` ID for equality checks. This allows dev tools to check if we are going to a previous Snapshot with `useGotoRecoilSnapshot()`. (cc maxijb) Reviewed By: davidmccabe Differential Revision: D22447073 fbshipit-source-id: cfa3e5c8f3bc6bef8c8c7592a7adf33394715cf3

view details

Christian Santos

commit sha 1546774188238a273d27d9c8afc205c3ccc17e7f

Fix TS lint error and improve typing of DefaultValue (#492) Summary: `DefaultValue` was defined as an empty class, which means it was behaving as `{}`, so it was allowing almost any type to be assigned to it. This PR introduces a private tag to solve the issue. Also, this PR introduces a minor change to `SnapshotID` to conform with tslint fixes https://github.com/facebookexperimental/Recoil/issues/487 Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/492 Reviewed By: drarmstr Differential Revision: D22673551 Pulled By: csantos42 fbshipit-source-id: c19b323379bef19296bbee5642889ad8875246c2

view details

Behnam Mohammadi

commit sha fe2dadc0fbff82624ff25e9afabd965011c4029a

Add eslint command on lint-staged (#402) Summary: I think, we need `eslint --fix` after `prettier --write` in `lint-staged` Pull Request resolved: https://github.com/facebookexperimental/Recoil/pull/402 Reviewed By: drarmstr Differential Revision: D22380637 Pulled By: mondaychen fbshipit-source-id: ac01a6ae565298abcb47919ecfb943b95502a22a

view details

generatedunixname89002005287564

commit sha 0d8f0b1fc142db7432b53dc17b6f109694014b6a

html/js/recoil/oss/recoil_values Differential Revision: D22723082 fbshipit-source-id: 4c8f7f41e4bbd149cc0bd84ab60aeb3538b8c654

view details

generatedunixname89002005287564

commit sha 3f4b1891af823efc24d169405bfcfb2fc73917ba

html/js/recoil/oss/util Differential Revision: D22722803 fbshipit-source-id: 2ef2a9e23d5da0bc96207e2267851d54485751d5

view details

Douglas Armstrong

commit sha b4afe4fb7232d8c92a44c857a662ef921d85b05b

Revert D22722803: html/js/recoil/oss/util Differential Revision: D22722803 (https://github.com/facebookexperimental/recoil/commit/3f4b1891af823efc24d169405bfcfb2fc73917ba) Original commit changeset: 2ef2a9e23d5d fbshipit-source-id: a1b24ee34ab6f68d49860dfb519a609e94e38b17

view details

Douglas Armstrong

commit sha b3f462fa4d04b010ef815dd4bc1a300f70f5e072

Revert D22723082: html/js/recoil/oss/recoil_values Differential Revision: D22723082 (https://github.com/facebookexperimental/recoil/commit/0d8f0b1fc142db7432b53dc17b6f109694014b6a) Original commit changeset: 4c8f7f41e4bb fbshipit-source-id: 474f24a195f7e38c854c50ced60001fbcd602976

view details

push time in 4 days

pull request commentreact-native-community/segmented-control

Fix spacing issue on android

this change has been published in v2.1.1 :tada:

thomaschaaf

comment created time in 4 days

release react-native-community/segmented-control

v2.1.1

released time in 4 days

push eventreact-native-community/segmented-control

Jesse Katsumata

commit sha 298b87828a1d8d7a2fd5179bcb3ed607c6e24465

2.1.1

view details

push time in 4 days

create barnchreact-native-community/segmented-control

branch : 2.1.1

created branch time in 4 days

created tagreact-native-community/segmented-control

tagv2.1.1

React Native SegmentedControl library

created time in 4 days

issue commentreact-native-community/segmented-control

RNCSegmentedControl was not found ?!

For expo users, please make sure that you are using expo sdk 38 or above. For expo users using expo 37 or below, please use the SegmentedControlIOS component from react-native. For non-expo users, please make sure you run npx pod-install after installing this package.

mertct11

comment created time in 4 days

delete branch react-native-community/segmented-control

delete branch : bumpConfig

delete time in 4 days

push eventreact-native-community/segmented-control

Jesse Katsumata

commit sha 85dc46a9a48b2a6dc83e92eb4d2b849c0398eb51

bump @expo/webpack-config (#117)

view details

push time in 4 days

PR merged react-native-community/segmented-control

bump @expo/webpack-config

Overview

bump @expo/webpack-config to address security alert

Test Plan

web example works <!-- Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! Increase test coverage whenever possible. -->

+699 -552

0 comment

2 changed files

Naturalclar

pr closed time in 4 days

push eventreact-native-community/segmented-control

Thomas Schaaf

commit sha 0af4fbc428121185b23ce26ae8d028918269d89f

Fix spacing issue on android (#114)

view details

push time in 4 days

issue closedreact-native-community/segmented-control

Android version cut off when last element is selected

Bug report

Summary

It seems like the right side is cut off on android since version 1.6.0 if the last item is selected.

Version 2.0.0

First Item: Screenshot 2020-05-30 19 27 43

Last Item: Screenshot 2020-05-30 19 06 08


Version 1.5.0

Screenshot 2020-05-30 19 21 25

Environment info

Library version: 1.60, 1.6.1 & 2.0.0

Steps to reproduce

Install in emulator or on device. Compare it with version 1.4.0 and there is it pretty.

Reproducible sample code

<View style={{margin: 10}}>
        <SegmentedControl
          style={{margin: 10}}
          selectedIndex={1}
          values={['Photos', 'Settings']}
        />
      </View>

closed time in 4 days

thomaschaaf

PR opened react-native-community/segmented-control

bump @expo/webpack-config

Overview

bump @expo/webpack-config to address security alert

Test Plan

web example works <!-- Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos! Increase test coverage whenever possible. -->

+699 -552

0 comment

2 changed files

pr created time in 4 days

push eventreact-native-community/segmented-control

Jesse Katsumata

commit sha 8222bf2c97ec87bcf911964f8d304e4c5035fb7a

bump @expo/webpack-config

view details

push time in 4 days

create barnchreact-native-community/segmented-control

branch : bumpConfig

created branch time in 4 days

push eventreact-native-community/react-native-picker

Alejandro Toledo Martinez

commit sha cf1bf19ba1a3229ac9c3cb2918cd61bec6383ef8

fix: Fix for Safari iOS labels not rendering (#120) Co-authored-by: Alejandro Toledo <alex@pixelspace.com>

view details

push time in 4 days

PR merged react-native-community/react-native-picker

fix: Fix for Safari iOS labels not rendering

Summary

As described in issue #113 the labels in Safari iOS are not displayed. The reason is that in PickerItem.js (line 23) the Option component is adding the label prop but unfortunately Safari iOS doesn't render the label. It appears to need the textContent of the option to properly render the label.

So by adding the label as textContent the Safari case gets solved as well as for other browsers that don't support the label property.

 <Option style={{color}} testID={testID} value={value} label={label}>
      {label}
    </Option>

The label is still passed as prop since the label values would default to textContent https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option#Browser_compatibility

  • [x ] I have tested this on a device and a simulator
+5 -1

0 comment

1 changed file

toledoal

pr closed time in 4 days

Pull request review commentreact-native-community/react-native-picker

React-Native-MacOS Support

+/**+ * Copyright (c) Facebook, Inc. and its affiliates.+ *+ * This source code is licensed under the MIT license found in the+ * LICENSE file in the root directory of this source tree.+ */++#import "RNCPicker.h"++#import <React/RCTConvert.h>+#import <React/RCTUtils.h>+++@interface RNCPicker() <NSComboBoxDataSource, NSComboBoxDelegate>+@end++@implementation RNCPicker++- (instancetype)initWithFrame:(CGRect)frame+{+    if ((self = [super initWithFrame:frame pullsDown:false])) {+        _color = [NSColor blackColor];+        _font  = [NSFont systemFontOfSize:21];+        _selectedIndex = NSNotFound;+        _textAlign     = NSTextAlignmentCenter;+        //self.dataSource = self;+        //self.delegate =  self;+        //self.completes = true;+        [self selectItemAtIndex:0];+        [[self menu] setFont:_font];+        self.pullsDown = false;+        [self setAction:@selector(mySelector:)];+        [self setTarget:self];++    }+    return self;+  /*if ((self = [super initWithFrame:frame])) {+    _color = [UIColor blackColor];+    _font = [UIFont systemFontOfSize:21]; // TODO: selected title default should be 23.5+    _selectedIndex = NSNotFound;+    _textAlign = NSTextAlignmentCenter;+    self.delegate = self;+    self.dataSource = self;+    [self selectRow:0 inComponent:0 animated:YES]; // Workaround for missing selection indicator lines (see https://stackoverflow.com/questions/39564660/uipickerview-selection-indicator-not-visible-in-ios10)+  }+  return self;*/+}+++//RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder)++- (void)setItems:(NSArray<NSDictionary *> *)items+{+    _items = [items copy];+    /*NSDictionary *attributes = [NSDictionary+    dictionaryWithObjectsAndKeys:+    color, NSForegroundColorAttributeName,+    font,+    NSFontAttributeName, textAlign, NSParagraphStyleAttributeName, nil];*/

same as comment above

bralax

comment created time in 4 days

Pull request review commentreact-native-community/react-native-picker

React-Native-MacOS Support

+/**+ * Copyright (c) Facebook, Inc. and its affiliates.+ *+ * This source code is licensed under the MIT license found in the+ * LICENSE file in the root directory of this source tree.+ */++#import "RNCPicker.h"++#import <React/RCTConvert.h>+#import <React/RCTUtils.h>+++@interface RNCPicker() <NSComboBoxDataSource, NSComboBoxDelegate>+@end++@implementation RNCPicker++- (instancetype)initWithFrame:(CGRect)frame+{+    if ((self = [super initWithFrame:frame pullsDown:false])) {+        _color = [NSColor blackColor];+        _font  = [NSFont systemFontOfSize:21];+        _selectedIndex = NSNotFound;+        _textAlign     = NSTextAlignmentCenter;+        //self.dataSource = self;+        //self.delegate =  self;+        //self.completes = true;+        [self selectItemAtIndex:0];+        [[self menu] setFont:_font];+        self.pullsDown = false;+        [self setAction:@selector(mySelector:)];+        [self setTarget:self];++    }+    return self;+  /*if ((self = [super initWithFrame:frame])) {+    _color = [UIColor blackColor];+    _font = [UIFont systemFontOfSize:21]; // TODO: selected title default should be 23.5+    _selectedIndex = NSNotFound;+    _textAlign = NSTextAlignmentCenter;+    self.delegate = self;+    self.dataSource = self;+    [self selectRow:0 inComponent:0 animated:YES]; // Workaround for missing selection indicator lines (see https://stackoverflow.com/questions/39564660/uipickerview-selection-indicator-not-visible-in-ios10)+  }+  return self;*/+}+++//RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder)++- (void)setItems:(NSArray<NSDictionary *> *)items+{+    _items = [items copy];+    /*NSDictionary *attributes = [NSDictionary+    dictionaryWithObjectsAndKeys:+    color, NSForegroundColorAttributeName,+    font,+    NSFontAttributeName, textAlign, NSParagraphStyleAttributeName, nil];*/+    NSMutableParagraphStyle *paragraphStyle = [[NSMutableParagraphStyle alloc] init];+    [paragraphStyle setAlignment:_textAlign];+    +    [paragraphStyle setHeadIndent:0];+    [self removeAllItems];+    NSInteger index = 0;+    for (id item in _items) {+        [self addItemWithTitle:item[@"label"]];+        NSColor *color = [RCTConvert NSColor:item[@"textColor"]] ?: _color;+        NSMenuItem * row = [self itemArray][index];+        NSDictionary *attributes = [NSDictionary dictionaryWithObjectsAndKeys:+                                    color, NSForegroundColorAttributeName, _font, NSFontAttributeName, paragraphStyle, NSParagraphStyleAttributeName ,nil];+        NSAttributedString *as = [[NSAttributedString alloc]+                    initWithString:[row title]+                    attributes:attributes];+        [row setAttributedTitle:as];+        index++;+    }+    [self setNeedsLayout:true];++}+++- (void)setSelectedIndex:(NSInteger)selectedIndex+{+  if (_selectedIndex != selectedIndex) {+    //BOOL animated = _selectedIndex != NSNotFound; // Don't animate the initial value+    _selectedIndex = selectedIndex;+    dispatch_async(dispatch_get_main_queue(), ^{+        [self setSelectedIndex:selectedIndex];+    });+  }+}++++/*- (NSInteger)pickerView:(__unused UIPickerView *)pickerView+numberOfRowsInComponent:(__unused NSInteger)component+{+  return _items.count;+}++ +#pragma mark - UIPickerViewDelegate methods++- (NSString *)pickerView:(__unused UIPickerView *)pickerView+             titleForRow:(NSInteger)row+            forComponent:(__unused NSInteger)component+{+  return [RCTConvert NSString:_items[row][@"label"]];+}++- (CGFloat)pickerView:(__unused UIPickerView *)pickerView rowHeightForComponent:(NSInteger)__unused component {+  return _font.pointSize + 19;+}++- (UIView *)pickerView:(UIPickerView *)pickerView+            viewForRow:(NSInteger)row+          forComponent:(NSInteger)component+           reusingView:(UILabel *)label+{+  if (!label) {+    label = [[UILabel alloc] initWithFrame:(CGRect){+      CGPointZero,+      {+        [pickerView rowSizeForComponent:component].width,+        [pickerView rowSizeForComponent:component].height,+      }+    }];+  }++  label.font = _font;++  label.textColor = [RCTConvert UIColor:_items[row][@"textColor"]] ?: _color;++  label.textAlignment = _textAlign;+  label.text = [self pickerView:pickerView titleForRow:row forComponent:component];+  return label;+}++- (void)pickerView:(__unused UIPickerView *)pickerView+      didSelectRow:(NSInteger)row inComponent:(__unused NSInteger)component+{+  _selectedIndex = row;+  if (_onChange && _items.count > (NSUInteger)row) {+    _onChange(@{+      @"newIndex": @(row),+      @"newValue": RCTNullIfNil(_items[row][@"value"]),+    });+  }+}+*/

same as comment above

bralax

comment created time in 4 days

Pull request review commentreact-native-community/react-native-picker

React-Native-MacOS Support

+/**+ * Copyright (c) Facebook, Inc. and its affiliates.+ *+ * This source code is licensed under the MIT license found in the+ * LICENSE file in the root directory of this source tree.+ */++#import "RNCPicker.h"++#import <React/RCTConvert.h>+#import <React/RCTUtils.h>+++@interface RNCPicker() <NSComboBoxDataSource, NSComboBoxDelegate>+@end++@implementation RNCPicker++- (instancetype)initWithFrame:(CGRect)frame+{+    if ((self = [super initWithFrame:frame pullsDown:false])) {+        _color = [NSColor blackColor];+        _font  = [NSFont systemFontOfSize:21];+        _selectedIndex = NSNotFound;+        _textAlign     = NSTextAlignmentCenter;+        //self.dataSource = self;+        //self.delegate =  self;+        //self.completes = true;+        [self selectItemAtIndex:0];+        [[self menu] setFont:_font];+        self.pullsDown = false;+        [self setAction:@selector(mySelector:)];+        [self setTarget:self];++    }+    return self;+  /*if ((self = [super initWithFrame:frame])) {+    _color = [UIColor blackColor];+    _font = [UIFont systemFontOfSize:21]; // TODO: selected title default should be 23.5+    _selectedIndex = NSNotFound;+    _textAlign = NSTextAlignmentCenter;+    self.delegate = self;+    self.dataSource = self;+    [self selectRow:0 inComponent:0 animated:YES]; // Workaround for missing selection indicator lines (see https://stackoverflow.com/questions/39564660/uipickerview-selection-indicator-not-visible-in-ios10)+  }+  return self;*/

if there a reason for this comment to be here? if so, could you add a comment in the code :+1:

bralax

comment created time in 4 days

push eventreact-native-community/progress-view

Tatiana Kapos

commit sha 5138d1906939444f23261accc03b3190a4b21729

Added Windows Tests (#40)

view details

push time in 4 days

PR merged react-native-community/progress-view

Added Windows Tests

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect -->

Summary

Added Windows tests to ProgressView

  • Since circleCI has issues with windows, used Github actions to create the windows tests.
  • Test simply makes sure each progressbar can be found, will time out and fail if the progressbar does not render and will tell you the specific progress bar it failed at.

image

Checklist

<!-- Check completed item, when applicable, via: [X] -->

  • [x] I have tested this on a device and a simulator
  • [x] I added the documentation in README.md
  • [ ] I mentioned this change in CHANGELOG.md
  • [ ] I updated the typed files (TS and Flow)
  • [x] I added a sample use of the API in the example project (example/App.js)
+4290 -223

1 comment

14 changed files

TatianaKapos

pr closed time in 4 days

delete branch Naturalclar/react-native-sketchbook

delete branch : feat/addInputComponent

delete time in 4 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 89060264ca44dd488c420791f6f557f5423b8663

feat: add Input Component (#35)

view details

push time in 4 days

delete branch Naturalclar/react-native-sketchbook

delete branch : bump/storybook

delete time in 4 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 234fb9038e5cb2e0ff5e89b79657aedea81e341c

bump: storybook (#34)

view details

push time in 4 days

PR merged Naturalclar/react-native-sketchbook

bump: storybook

bump storybook to latest rc version

+215 -661

2 comments

2 changed files

Naturalclar

pr closed time in 4 days

PR opened Naturalclar/react-native-sketchbook

feat: add Input Component

add SingleLineInput Component

+220 -0

0 comment

5 changed files

pr created time in 4 days

create barnchNaturalclar/react-native-sketchbook

branch : feat/addInputComponent

created branch time in 4 days

PR opened Naturalclar/react-native-sketchbook

bump: storybook

bump storybook to latest rc version

+215 -661

0 comment

2 changed files

pr created time in 4 days

create barnchNaturalclar/react-native-sketchbook

branch : bump/storybook

created branch time in 4 days

PR opened storybookjs/storybook

Reviewers
bump react-syntax-highlighter to 13.2.1

Issue:

What I did

bumped react-syntax-highlighter to 13.2.1 to address security alert for prismjs.

it's a change in major version, but the only breaking change is dracula theme being changed to darcula

https://github.com/react-syntax-highlighter/react-syntax-highlighter/releases

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

n/a <!--

Everybody: Please submit all PRs to the next branch unless they are specific to current release. Storybook maintainers cherry-pick bug and documentation fixes into the master branch as part of the release process, so you shouldn't need to worry about this.

Maintainers: Please tag your pull request with at least one of the following: ["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

-->

+42 -2

0 comment

2 changed files

pr created time in 4 days

create barnchNaturalclar/storybook

branch : chore/updateReactSyntaxHighlighter

created branch time in 4 days

push eventNaturalclar/storybook

Max Belsky

commit sha 5729baa143fd1f811aebb2af4fa123f76b2caf8d

Replace document.execCommand with navigator.clipboard

view details

domyen

commit sha 0fd8c11eb10df64df596becc87fa663e78ddf739

make boolean control more descriptive

view details

Max Belsky

commit sha fa94c752da3c5659de21c1fc0d480017d289af57

Replace magic numbers with constants

view details

domyen

commit sha df1bf21d8c64c898383188a7cf964b9d452f62d1

improve Boolean layout so that the buttons have similar widths

view details

domyen

commit sha 34964488b054d33347dfda0a73a1bbf44594877a

resize error message in Controls addon in the addon panel

view details

domyen

commit sha 9f8fa39e28dd0a636a64f44308912b76a64ed73a

Improve Boolean control focus state

view details

Michael Shilman

commit sha 6460520f5291a7f83ec426195fb0ae03b2b99307

ArgsTable: Refactor no controls warning & add stories

view details

Michael Shilman

commit sha a10e86489cd5eef9f9b680d72cf0644aa0c02b03

ArgsTable: Fix missing export

view details

Michael Shilman

commit sha 51b15819e2ba21f33e2f32afe7eb8b1efb3783d2

ArgsTable: Fix story styling & misc warnings

view details

Michael Shilman

commit sha cd88b919de51b0845546bfe033809cb35eb9ffe6

ArgsTable: Subdue deselected text in Boolean control

view details

Matus Backor

commit sha 08849a7b249b396c5ba0317470b5baef00645ca1

Allow gradient in story preview background

view details

Michael Shilman

commit sha bba5841cd7efc27a41d7bce7d449361530f368bf

Merge branch 'next' into 8342-dynamic-source

view details

Michael Shilman

commit sha b7fe4878c90ed2ad55d49038ed89039efd648819

Fix deepscan

view details

Michael Shilman

commit sha 57b0d5b8686d062f0256a0462d1e69c8adf871b0

Doc blocks: Fix Description story

view details

Michael Shilman

commit sha 9027827cdcf6937404776f9484c68cbeb74fad91

Merge pull request #11263 from storybookjs/11211-argstable-design-refresh ArgsTable: Updated Boolean control

view details

Norbert de Langen

commit sha e439a48a6e8120252efee56ad38b06a170baaeda

copy versions from previous ref object & drop error when switching versions

view details

Norbert de Langen

commit sha 91a766ef9f2702cdc11678be3232c6a4fbeaa2e2

Merge branch 'next' into fix/allow-refs-versions-in-config

view details

Norbert de Langen

commit sha 9dc3489bd09e7a2196008670f0e4678e7aed26b1

FIX versions

view details

Norbert de Langen

commit sha fc66dee02ad360945a9bd21124819954dc6e795e

ADD story

view details

Norbert de Langen

commit sha abca0fd38030850d653d0e4e36a3782afb1543ff

FIX versions

view details

push time in 4 days

fork Naturalclar/react-native-syntax-highlighter

a syntax highlighter for react native using https://github.com/conorhastings/react-syntax-highlighter under the hood

fork in 4 days

startedconorhastings/react-native-syntax-highlighter

started time in 4 days

delete branch Naturalclar/react-native-sketchbook

delete branch : demo/reg-suit

delete time in 4 days

issue commentreact-native-community/clipboard

Yarn can't find the package

@anya-ks I think this may have been a temporal problem due to npm being down. could you check if it can be installed now?

anya-ks

comment created time in 5 days

delete branch Naturalclar/react-native

delete branch : chore/useEs6ImportScrollView

delete time in 5 days

PR opened Naturalclar/react-native-sketchbook

demo: reg-suit

demo for reg-suit

+2 -3

0 comment

1 changed file

pr created time in 5 days

create barnchNaturalclar/react-native-sketchbook

branch : demo/reg-suit

created branch time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : test/push

delete time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : chore/changePropsToChecked

delete time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : feat/defaultLayoutForStorybook

delete time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 5fe22d80659b8a3a669f8d4a1d7468c4f32e6d17

chore: add default layout for stories (#32)

view details

push time in 5 days

PR merged Naturalclar/react-native-sketchbook

chore: add default layout for stories

add default layout for stories so there are no paddings

+6 -5

2 comments

1 changed file

Naturalclar

pr closed time in 5 days

PR opened Naturalclar/react-native-sketchbook

chore: add default layout for stories

add default layout for stories so there are no paddings

+6 -5

0 comment

1 changed file

pr created time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : reg/demo

delete time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : feat/biggerButton

delete time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha c87703daf2cbfe2d6f39231281c68a77b8203777

demo

view details

push time in 5 days

PR opened Naturalclar/react-native-sketchbook

demo/reg-suit

demo reg-suit

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchNaturalclar/react-native-sketchbook

branch : reg/demo

created branch time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 9c8f8c10af99d18bf80372b0efd029520d8be9c3

fix: work around for detached HEAD state (#30)

view details

Jesse Katsumata

commit sha 2ab02c41da5d65a7420b5b8b94d1149bd5808a19

Merge branch 'master' of https://github.com/Naturalclar/react-native-sketchbook into feat/biggerButton

view details

push time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : fix/action

delete time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 9c8f8c10af99d18bf80372b0efd029520d8be9c3

fix: work around for detached HEAD state (#30)

view details

push time in 5 days

PR merged Naturalclar/react-native-sketchbook

fix: work around for detached HEAD state

adds ref to master to avoid detached HEAD state on github action

+8 -1

2 comments

1 changed file

Naturalclar

pr closed time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha e5dd455cdc3e758ebd6bfdc30b0dfdf10f9a35aa

fix: change trigger to push

view details

push time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 10ebf9f6b2bea0431d24e37b38cb48a115173d42

fix: checkout options

view details

push time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha b289d76aa6ea565eeb683a725e53b2baaa6419a5

fix: add env var for gha

view details

Jesse Katsumata

commit sha 812eda2503f401385df49e91870098121dbacd95

Merge branch 'fix/action' of https://github.com/Naturalclar/react-native-sketchbook into fix/action

view details

push time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 06af2ee71df8f21a014e884ff7a596e051393f9e

Update .github/workflows/test.yml

view details

push time in 5 days

Pull request review commentNaturalclar/react-native-sketchbook

fix: work around for detached HEAD state

 jobs:         node-version: [10.18.1]     steps:       - uses: actions/checkout@v2+      - name: workaround for detached HEAD+        run: git checkout ${GITHUB_REF#refs/heads/} || git checkout -b ${GITHUB_REF#refs/heads/} && git pull
        run: git checkout ${GITHUB_REF#refs/heads/} || git checkout -b ${GITHUB_REF#refs/heads/} && git pull
        continue-on-error: true
Naturalclar

comment created time in 5 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha cb640f1b11f20a87706383e5cc283c0f5f6f92f4

fix: add workaround for detached HEAD

view details

push time in 5 days

PR opened Naturalclar/react-native-sketchbook

fix: add ref to master for github actions

adds ref to master to avoid detached HEAD state on github action

+2 -0

0 comment

1 changed file

pr created time in 5 days

create barnchNaturalclar/react-native-sketchbook

branch : fix/action

created branch time in 5 days

PR opened reg-viz/reg-suit

Fix grammar in an error message

What does this change?

Fixes an error message with correct grammar.

References

n/a

Screenshots

n/a

What can I check for bug fixes?

n/a

+1 -1

0 comment

1 changed file

pr created time in 5 days

push eventNaturalclar/reg-suit

Jesse Katsumata

commit sha 309c8b7b5177524cc445e3e1eeed356031c0d973

Fix grammar in an error message

view details

push time in 5 days

fork Naturalclar/reg-suit

:recycle: Visual Regression Testing tool

https://reg-viz.github.io/reg-suit

fork in 5 days

PR opened Naturalclar/react-native-sketchbook

feat: made button bigger

Made the round button bigger

+3 -2

0 comment

1 changed file

pr created time in 5 days

create barnchNaturalclar/react-native-sketchbook

branch : feat/biggerButton

created branch time in 5 days

delete branch Naturalclar/react-native-sketchbook

delete branch : feat/addRegSuit

delete time in 6 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha f3fef9e717c52e32e4f97b9b5792070dfa80854a

feat: setup reg-suit (#28)

view details

push time in 6 days

PR merged Naturalclar/react-native-sketchbook

feat: setup reg-suit

setup reg-suit for this repository

+1712 -80

2 comments

5 changed files

Naturalclar

pr closed time in 6 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 66d0c70d7274342bfb06ea5456be2241b2975ad3

feat: add visual regression for ci

view details

push time in 6 days

PR opened Naturalclar/react-native-sketchbook

feat: setup reg-suit

setup reg-suit for this repository

+1690 -80

0 comment

4 changed files

pr created time in 6 days

create barnchNaturalclar/react-native-sketchbook

branch : feat/addRegSuit

created branch time in 6 days

pull request commentnecolas/react-native-web

Support Modal Dialogs

I've been using a patched-version of react-native with this PR, and it's working great :+1:

imnotjames

comment created time in 7 days

push eventNaturalclar/react-native

Rubén Norte

commit sha 050a7dd019be435b848de0a86030599d83f8791d

Enable exact objects by default in the project template Summary: This template for new projects isn't configured with exact objects by default, which could cause issues with code in react-native assuming this option is enabled. Changelog: [Changed] Enabled exact_by_default in Flow for new projects using the template Reviewed By: cpojer Differential Revision: D22571745 fbshipit-source-id: da5affe903114484384764be2142e1c46244bfac

view details

Rubén Norte

commit sha 4409642811c787052e0baeb92e2679a96002c1e3

Migrate large amount of modules to flow strict and strict-local Summary: | Group | Before | After | Change | | Untyped | 50 | 49 | -1 | | flow | 197 | 155 | -42 | | flow strict-local | 226 | 185 | -41 | | flow strict | 33 | 117 | +84 Changelog: [Changed] Improved Flow typing of multiple modules (with migrations to `flow strict` and `flow strict-local` Reviewed By: motiz88 Differential Revision: D22549140 fbshipit-source-id: ed29415332cfce15b244ee4dea9e13d035543175

view details

Jesse Katsumata

commit sha 2c2267e95b7ffceb733eecaa265f246af3e15b81

Merge branch 'master' of https://github.com/Naturalclar/react-native into chore/removeFlowFixMe

view details

push time in 7 days

pull request commentNaturalclar/expo-typescript-starter

chore(deps-dev): bump fork-ts-checker-webpack-plugin from 1.0.0 to 5.0.14

Artifact can be viewed here: : https://439-170030551-gh.circle-artifacts.com/0/storybook-static/index.html

dependabot-preview[bot]

comment created time in 8 days

pull request commentNaturalclar/expo-typescript-starter

chore(deps-dev): bump fork-ts-checker-webpack-plugin from 1.0.0 to 5.0.13

Artifact can be viewed here: : https://435-170030551-gh.circle-artifacts.com/0/storybook-static/index.html

dependabot-preview[bot]

comment created time in 11 days

pull request commentNaturalclar/expo-typescript-starter

chore(deps-dev): bump eslint from 6.8.0 to 7.6.0

Artifact can be viewed here: : https://437-170030551-gh.circle-artifacts.com/0/storybook-static/index.html

dependabot-preview[bot]

comment created time in 11 days

delete branch Naturalclar/react-from-svg

delete branch : chore/addStopComponent

delete time in 11 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 5128078144553b16c642cecf65d4e8c50a7731a7

chore: update storybook (#27)

view details

push time in 13 days

delete branch Naturalclar/react-native-sketchbook

delete branch : chore/updateStorybook

delete time in 13 days

PR merged Naturalclar/react-native-sketchbook

chore: update storybook

experimenting with storybook v6 beta

+2270 -1298

1 comment

2 changed files

Naturalclar

pr closed time in 13 days

push eventNaturalclar/react-native-sketchbook

Jesse Katsumata

commit sha 73c24415c900444608f8d2a94b5d978ee4bf4887

chore: update version

view details

push time in 13 days

pull request commentNaturalclar/expo-typescript-starter

chore(deps): [security] bump elliptic from 6.4.1 to 6.5.3

Artifact can be viewed here: : https://433-170030551-gh.circle-artifacts.com/0/storybook-static/index.html

dependabot-preview[bot]

comment created time in 13 days

PR opened cats-oss/scaffdog

docs: fixes grammar

<!-- Thank you for your contribution to scaffdog! Please replace {Please write here} with your description -->

What does this do / why do we need it?

Fixes the grammar in the pull request template

How this PR fixes the problem?

Fixes the grammar in the pull request template

What should your reviewer look out for in this PR?

Wording

Check lists

  • [x] Test passed
  • [x] Coding style (indentation, etc)

Additional Comments (if any)

n/a

Which issue(s) does this PR fix?

n/a <!-- fixes # fixes # -->

+2 -2

0 comment

1 changed file

pr created time in 14 days

push eventNaturalclar/scaffdog

Jesse Katsumata

commit sha 4311d98603e9f73c623478610e3cbb4443ba3d1e

docs: fixes grammar

view details

push time in 14 days

create barnchNaturalclar/scaffdog

branch : docs/fixGrammar

created branch time in 14 days

more