profile
viewpoint

push eventMic92/openvpn-ddns

jerryoman

commit sha 55b09e4d6c3f711358313300a4d6a3891b2ad6d2

config example file: Variable is called private_zones and not privat_zones

view details

Jörg Thalheim

commit sha 129adf7c2a98540fb6d6383290ee7a9a88a40cce

Merge pull request #1 from jerryoman/patch-1 config example file: Variable is called private_zones and not privat_…

view details

push time in 15 hours

pull request commentNixOS/nixpkgs

rustc: add QA documentation

Yeah. Maybe I should add this as well, we usually prefer to merge rustc updates to staging.

Mic92

comment created time in 16 hours

pull request commentNixOS/nixpkgs

rustc: add QA documentation

Other usual suspects in rust land: cc @symphorien @jD91mZM2 @zimbatm

Mic92

comment created time in 16 hours

Pull request review commentNixOS/nixpkgs

rustc: add QA documentation

+# After updating check ...+# 1. if rustc can produce rust binaries on x86_64-linux, aarch64-linux and x86_64-darwin:+#    i.e. nix build -f . fd or @GrahamcOfBorg build fd on github

fd is just a simple rust example that should build on all platforms.

Mic92

comment created time in 16 hours

push eventMic92/nixpkgs

Jörg Thalheim

commit sha 7b935d5c864e18a157668b318f6e53679c949101

rustc: add QA documentation

view details

push time in 16 hours

Pull request review commentNixOS/nixpkgs

rustc: add QA documentation

+# After updating check ...+# 1. if rustc can produce rust binaries on x86_64-linux, aarch64-linux and x86_64-darwin:

@GrahamcOfBorg usually can build this in time. For aarch64 we have a beefy community builder: https://github.com/nix-community/aarch64-build-box which I have access to and usually try to build upgrades. For macOS alternatively I have a bunch of nixpkgs maintainer that I can ping instead. We followed this pattern for a while until you started merging rust upgrades without testing.

Mic92

comment created time in 16 hours

Pull request review commentNixOS/nixpkgs

rustc: add QA documentation

+# After updating check ...+# 1. if rustc can produce rust binaries on x86_64-linux, aarch64-linux and x86_64-darwin:+#    i.e. nix build -f . fd or @GrahamcOfBorg build fd on github+# 2. if our LLVM version matches with rust upstream+# 3. if firefox or thunderbird still build on x86_64-linux

Yes. Because this is a channel blocker. A way to fix it in that case is to to pin rust to an older version for firefox. However breaking firefox in unstable is undesired.

Mic92

comment created time in 16 hours

create barnchMic92/nixpkgs

branch : rustc

created branch time in 17 hours

pull request commentNixOS/nixpkgs

rustc: add QA documentation

cc @andir @edolstra

Mic92

comment created time in 17 hours

PR opened NixOS/nixpkgs

Reviewers
rustc: add QA documentation

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change
Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ ] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
Notify maintainers

cc @

+5 -0

0 comment

1 changed file

pr created time in 17 hours

push eventNixOS/nixpkgs

Théo Zimmermann

commit sha 72ef651f55fd2285716a5e61d6e458227e14da00

ocamlPackages.utop: fix source By using the provided tbz file instead of the auto-generated GitHub tarball, we ensure that strings like %%VERSION%% have been properly generated.

view details

Jörg Thalheim

commit sha a43702d670abf9b7e66d1e158617f01ecc074258

Merge pull request #73283 from Zimmi48/fix-utop-src ocamlPackages.utop: fix source

view details

push time in 17 hours

PR merged NixOS/nixpkgs

ocamlPackages.utop: fix source 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

By using the provided tbz file instead of the auto-generated GitHub tarball, we ensure that strings like %%VERSION%% have been properly generated.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+2 -2

1 comment

1 changed file

Zimmi48

pr closed time in 17 hours

delete branch Mic92/nixpkgs

delete branch : mypy

delete time in 17 hours

push eventNixOS/nixpkgs

Jörg Thalheim

commit sha 03e6ca15e205bf892eac08a5f561c3a16284c90a

test-driver: add mypy support It's a good idea to expand this in future to test code as well, so we get type checking there as well.

view details

Jörg Thalheim

commit sha 550f508bde31367fd1a2ce8dc9d2cc89173e5cc3

Merge pull request #73033 from Mic92/mypy test-driver: add mypy support

view details

push time in 17 hours

PR merged NixOS/nixpkgs

test-driver: add mypy support 10.rebuild-darwin: 0 10.rebuild-linux: 0 6.topic: nixos

It's a good idea to expand this in future to test code as well, so we get type checking there as well.

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change
Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
Notify maintainers

cc @

+103 -91

5 comments

2 changed files

Mic92

pr closed time in 17 hours

pull request commentNixOS/nixpkgs

test-driver: add mypy support

@GrahamcOfBorg test borgbackup

Mic92

comment created time in 17 hours

push eventNixOS/nixos-hardware

ilian

commit sha adecd1113c2d4137ef23237f9af450736fd8d2cc

apple: Add support for MacBook Air 3,X (#91)

view details

push time in a day

PR merged NixOS/nixos-hardware

apple: Add support for MacBook Air 3,X

Add support for MacBook Air 3,X, which only contains a NVIDIA GeForce 320M GPU instead of integrated Intel graphics. The configuration contains the black screen fix for this model.

+16 -0

2 comments

2 changed files

ilian

pr closed time in a day

Pull request review commentNixOS/nixos-hardware

apple: Add support for MacBook Air 3,X

+{ config, lib, ... }:++{+  imports = [ +    ../../.+    ../../../common/pc/laptop+    ../../../common/pc/ssd+  ];++  # Built-in iSight is recognized by the generic uvcvideo kernel module+  hardware.facetimehd.enable = false;++  hardware.cpu.intel.updateMicrocode =+    lib.mkDefault config.hardware.enableRedistributableFirmware;

Ah, just read about the NVIDIA GeForce 320M GPU

ilian

comment created time in a day

Pull request review commentNixOS/nixos-hardware

apple: Add support for MacBook Air 3,X

+{ config, lib, ... }:++{+  imports = [ +    ../../.+    ../../../common/pc/laptop+    ../../../common/pc/ssd+  ];++  # Built-in iSight is recognized by the generic uvcvideo kernel module+  hardware.facetimehd.enable = false;++  hardware.cpu.intel.updateMicrocode =+    lib.mkDefault config.hardware.enableRedistributableFirmware;

Why not using ../../../common/cpu/intel here?

ilian

comment created time in a day

Pull request review commentNixOS/nixpkgs

update contributors documentation for nix-review

 Additional information.     review uncommitted changes: <screen>nix-shell -p nix-review --run "nix-review wip"</screen>    </para>++   <para>+    review changes from last commit:+<screen>nix-shell -p nix-review --run "nix-review rev HEAD"</screen>

This could be even switched to the new nix run:

<screen>nix run nixpkgs.nix-review -c nix-review rev HEAD</screen>

This avoids pulling some dependencies/environment variables that nix-shell would do

DavHau

comment created time in a day

Pull request review commentNixOS/nixpkgs

MinGW: Enable C++ threads with mcfgthreads

+{ stdenv, fetchFromGitHub, autoreconfHook }:++stdenv.mkDerivation {+  pname = "mcfgthreads";+  version = "git";

We usually use date of commit here instead of git.

Ericson2314

comment created time in a day

Pull request review commentNixOS/nixpkgs

WIP: Windows cross compilation via LLVM

+commit 418f133acf9724564ddc30f9ac79c04648e3eb20+Author: John Ericson <git@JohnEricson.me>+Date:   Sun Nov 3 13:04:53 2019 -0500++    [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc+    +    Summary:+    Besides the Mingw toolchain, there is also the CrossWindows toolchain,+    which means GNU-style cli but genuine windows headers + libraries. LLD's+    MinGW driver is as good a fit as binutil's ld, but there is no easy way+    to select it when lld was being rewritten to lld-link.+    +    This makes lld always be the GNU-style one, consistent with the non-msvc+    case. It's a small breaking change for Windows, but the only+    straightforward way.+    +    It may seem silly to worry about the gnu-style flags, but it is useful+    for mixing software designed with MinGW in mind with "real" windows+    software that needs a MSVC C++ ABI, C++ threads, etc.+    +    Testing in conjunction with https://github.com/NixOS/nixpkgs/pull/72366,+    which might be the first fully automated way to cross compile to+    Windows.  I haven't taught Nixpkgs to wrap clang-cl like it wraps clang,+    so even for some packages that have separate MSVC and MinGW builds+    systems (e.g. zlib, opensll), I seem to be having better luck with the
    systems (e.g. zlib, openssl), I seem to be having better luck with the
Ericson2314

comment created time in a day

pull request commentNixOS/nixpkgs

makeFontsCache: Fix cross-compiling, missing fc-cache

@ebkalderon you can open also a new pr that fixes https://github.com/NixOS/nixpkgs/pull/67916#discussion_r319838459

baloo

comment created time in a day

push eventnix-community/NUR

Stig Palmquist

commit sha 4d864e4466a8e52f366d4125fd41ce4ef228431a

Add sgo repository

view details

Jörg Thalheim

commit sha c4f12ac2602c1c992696ba03c3ba86eac797ec5b

Add sgo repository (#155) Add sgo repository

view details

push time in a day

PR merged nix-community/NUR

Add sgo repository

The following points apply when adding a new repository to repos.json

  • [X] I ran ./bin/nur format-manifest after updating repos.json (We will use the same script in travis ci to make sure we keep the format consistent)
  • [X] By including this repository in NUR I give permission to license the content under the MIT license.

Clarification where license should apply: The license above does not apply to the packages built by the Nix Packages collection, merely to the package descriptions (i.e., Nix expressions, build scripts, etc.). It also might not apply to patches included in Nixpkgs, which may be derivative works of the packages to which they apply. The aforementioned artifacts are all covered by the licenses of the respective packages.

+3 -0

0 comment

1 changed file

stigtsp

pr closed time in a day

created tagMic92/iana-etc

tag20191111

Build /etc/protocols and /etc/services files from IANA's Assigned Internet Protocol Numbers

created time in a day

push eventMic92/iana-etc

Travis CI

commit sha 473badf675d37131d2d2da9c0cf8501690337a99

add new iana release 20191111

view details

push time in a day

push eventMic92/nixpkgs

Thibault Gagnaux

commit sha 43a761da72af3c70d4087085c3ed608c54d76baf

openconnect: Add darwin support The old build was failing on darwin because yubikey needs the PCSC framework dependency. I also upgraded to the latest vpnc-script as recommended on the openconnect homepage (see: https://www.infradead.org/openconnect/platforms.html). Lastly, I moved all dependencies which are not used at runtime from propagatedBuildInputs to buildInputs (Please correct me if that is wrong).

view details

Stig Palmquist

commit sha e662a44119be44fd235a64517667f50d6c069f63

perlPackages.MojoRedis: init at 3.24 dependencies: perlPackages.ProtocolRedis: init at 1.0010 perlPackages.ProtocolRedisFaster: init at 0.003

view details

Mathieu A.-Tetreault

commit sha 054ceb826e2aedd849be741a0ae1888eb87cd569

plymouth: Add extra config field Signed-off-by: Mathieu A.-Tetreault <alexandretm@amotus.ca>

view details

Robert Scott

commit sha f82fb81af89559979e90ca55471ab689f6f2da73

gdal_2: add patch for CVE-2019-17545

view details

Robert Scott

commit sha def17695b9b4dc6b030258872986f214c5a16aba

gdal: add patch for CVE-2019-17545

view details

Chris Rendle-Short

commit sha c972e1b0d5a38afea8a9597f5a6f1ab49af91672

crawl: 0.23.2 -> 0.24.0

view details

Jonathan Ringer

commit sha 880ae34123da26525d3f0aa980e111a9547d904b

vscode-extensions.redhat.vscode-yaml: init at 0.5.3

view details

Jonathan Ringer

commit sha 434185f35c3109bd32f8c720ffe2f14d44fec6ce

vscode-extensions.ms-azuretools.vscode-docker: init at 0.8.1

view details

Jonathan Ringer

commit sha f0e4e471056294e47bab84442a151b22b94cbd0b

vscode-extensions.vscodevim.vim: 1.3.0 -> 1.11.3

view details

Jonathan Ringer

commit sha 8f25c7aa2021fe69810bf89a7b9126d0d71c2134

vscode-extensions.ms-kubernetes-tools.vscode-kubernetes-tools: init at 1.0.6

view details

Jonathan Ringer

commit sha 5ae6ec21facdbb46a17e743a079beff0ec0bdb85

vscode-extensions.ms-vscode.Go: init 0.11.7

view details

Robert Scott

commit sha 5e8eaa676919206235d43a14aa5558030146068d

keepalived: 1.4.2 -> 1.4.5

view details

Robert Scott

commit sha 03d6145cb020aa4c782c78580d2d049b42ea5a28

keepalived: add patch for CVE-2018-19115

view details

ShaRose

commit sha 9e2308ed805eac8462343c90283d94c58a6e708b

nixos/dnsdist: Add CAP_NET_BIND_SERVICE to AmbientCapabilities It seems that dnsdist doesn't actually request CAP_NET_BIND_SERVICE, which is why normally it's executed and root and setuids to another, unprivileged, user. This means that as it is, dnsdist will be unable to bind to any port under 1024 and will fail with access denied. Removing CAP_SETGID and CAP_SETUID is also related to this as we don't actually change the uid or gid after the fact as we use DynamicUser. (That part isn't strictly NEEDED but there's no reason to have those capabilities if we don't use them). There are also some additional sandboxing we can remove from the service definition as they are assumed true or strict by DynamicUser: specifically PrivateTmp and ProtectSystem respectively. ProtectHome is still there, despite being assumed read-only as setting it to true means they are seen as empty. I don't think it really matters as I don't know if systemd will ignore it or not, but I didn't see any reason to go hunting for excuses to make it a bigger change.

view details

Nick Partridge

commit sha 4d54c9e368f902474b78783ae56c840092d0d6db

rPackages.glmnet: Add missing dependency Fixes the error: ld: library not found for -liconv

view details

Elis Hirwing

commit sha ee16c546a41f4970f542900e0ac256ec1f9ac8f6

transifex-client: Fix build We have updated python-slugify to 4.0.0 (or newer) which broke the build. This has happened several times before without actually breaking the software. So yeah, lets just accept newer versions and fix it if it breaks for some other reason in the future.

view details

R. RyanTM

commit sha 7d884032b26d7f2c1924d8ddb9c7b3a72e7bd06e

tome4: 1.5.10 -> 1.6.0

view details

worldofpeace

commit sha 4bdbbc1b339d3e74d13c964e120fd27ad6bf3303

nixos/gnome3: add sound-theme-freedesktop I've noticed a similar issue in Pantheon, without this sound theme installed there's no system sounds. I believe it's because the gnome theme and the pantheon theme inherit this one.

view details

worldofpeace

commit sha 4e2161f9ed88c4b34760a4b29fb68dc9aa9ef1df

nixos/xdg/sounds: add sound-theme-freedesktop

view details

Milan Pässler

commit sha 00ac18cdea8bbe9bc4c7f68b7de4e99ed27fdb54

qtwebengine: add patch for CVE-2019-13720

view details

push time in 2 days

push eventNixOS/nixpkgs

Florian Klink

commit sha a8e9a93493bca33f59b6c893cd8af459b18ab619

nixos/tests: fix succeed() with multiple commands we previously immediately returned the first commands output, and didn't execute any of the other commands. Now, return the last commands output. This should be documented in the method docstring.

view details

Jörg Thalheim

commit sha 556a169f14f4970927b8c18a997dbf323ed9a865

Merge pull request #73189 from flokli/python-tests-return-multiple nixos/tests: fix succeed() with multiple commands

view details

push time in 2 days

PR merged NixOS/nixpkgs

nixos/tests: fix succeed() with multiple commands 10.rebuild-darwin: 0 10.rebuild-linux: 0 6.topic: nixos

we previously immediately returned the first commands output, and didn't execute any of the other commands.

Now, return the last commands output. This should be documented in the method docstring.

cc @Mic92 #73033

Motivation for this change
Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ ] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc @marijanp

+5 -3

3 comments

1 changed file

flokli

pr closed time in 2 days

pull request commentNixOS/nixpkgs

test-driver: add mypy support

@marijanp fixed

Mic92

comment created time in 2 days

push eventMic92/nixpkgs

Jörg Thalheim

commit sha 01fa3d698475a6c435098a252ff88d4d3ec20679

test-driver: add mypy support It's a good idea to expand this in future to test code as well, so we get type checking there as well.

view details

push time in 2 days

Pull request review commentNixOS/nixpkgs

test-driver: add mypy support

 in rec {      nativeBuildInputs = [ makeWrapper ];     buildInputs = [ (python3.withPackages (p: [ p.ptpython ])) ];-    checkInputs = with python3Packages; [ pylint black ];+    checkInputs = with python3Packages; [ pylint black mypy ];      dontUnpack = true;      preferLocalBuild = true;      doCheck = true;     checkPhase = ''+      mypy --disallow-untyped-defs \+           --no-implicit-optional \+           --ignore-missing-imports ${testDriverScript}

Because third-party library are imported that do not have type annotations.

Mic92

comment created time in 3 days

Pull request review commentNixOS/nixpkgs

test-driver: add mypy support

 in rec {      nativeBuildInputs = [ makeWrapper ];     buildInputs = [ (python3.withPackages (p: [ p.ptpython ])) ];-    checkInputs = with python3Packages; [ pylint black ];+    checkInputs = with python3Packages; [ pylint black mypy ];      dontUnpack = true;      preferLocalBuild = true;      doCheck = true;     checkPhase = ''+      mypy --disallow-untyped-defs \+           --no-implicit-optional \+           --ignore-missing-imports ${testDriverScript}

Because third-party libraries are imported that do not have type annotations.

Mic92

comment created time in 3 days

push eventnix-community/NUR

Pamplemousse

commit sha 8a2f67d8b33a5813696e89c0f91c47904ce78d7a

Add pamplemousse repository

view details

Jörg Thalheim

commit sha 1cf50a0b4322494f3405f0e9f0dd357057d4eb29

Add pamplemousse repository (#153) Add pamplemousse repository

view details

push time in 3 days

PR merged nix-community/NUR

Add pamplemousse repository

The following points apply when adding a new repository to repos.json

  • [x] I ran nur/format-manifest.py after updating repos.json (We will use the same script in travis ci to make sure we keep the format consistent)
  • [x] By including this repository in NUR I give permission to license the content under the MIT license.
+3 -0

0 comment

1 changed file

Pamplemousse

pr closed time in 3 days

push eventnix-community/NUR

Jörg Thalheim

commit sha 6faa57ee38788d0bc73b9e04429a97dd8ebff237

fix new mypy errors

view details

push time in 3 days

Pull request review commentNixOS/nixpkgs

More flexible systemd expression for minimal builds

 in stdenv.mkDerivation {    preConfigure = ''     mesonFlagsArray+=(-Dntp-servers="0.nixos.pool.ntp.org 1.nixos.pool.ntp.org 2.nixos.pool.ntp.org 3.nixos.pool.ntp.org")+    export AR="gcc-ar"  # For LTO

This might need a prefix for cross compiling:

export AR="${stdenv.hostPlatform.config}-gcc-ar"
kirelagin

comment created time in 4 days

pull request commentMic92/nix-review

buildenv: simplify the config

Does this also break on current master?

zimbatm

comment created time in 4 days

PR closed Mic92/nix-review

set nixpkgs config as an attrset instead of a function

The nixpkgs manual seems to prefer attrset and we are not using the argument anyway.

I noticed this due to a recent breakage: https://github.com/NixOS/nixpkgs/pull/72376#discussion_r341883853

+1 -1

1 comment

1 changed file

veprbl

pr closed time in 4 days

pull request commentMic92/nix-review

set nixpkgs config as an attrset instead of a function

fixed in: https://github.com/Mic92/nix-review/pull/74

veprbl

comment created time in 4 days

push eventMic92/nix-review

zimbatm

commit sha c4e6037f0d577db8f59c7a503a2c90f9ebe1e6bd

buildenv: simplify the config It's not necessary to use a function since we don't use the pkgs attribute. The config can just be an attribute set. Related to https://github.com/NixOS/nixpkgs/pull/72376#discussion_r341883853

view details

Jörg Thalheim

commit sha 5c0dd9fb5eb1d1ec44f6e437ddd43d7dff898745

buildenv: simplify the config (#74) buildenv: simplify the config

view details

push time in 4 days

PR merged Mic92/nix-review

buildenv: simplify the config

It's not necessary to use a function since we don't use the pkgs attribute. The config can just be an attribute set.

Related to https://github.com/NixOS/nixpkgs/pull/72376#discussion_r341883853

+1 -1

0 comment

1 changed file

zimbatm

pr closed time in 4 days

Pull request review commentNixOS/nixpkgs

Add SGX packages

+{ stdenv, pkgs, fetchurl, lib, version, url, sha256, ... }:+stdenv.mkDerivation {+  name = "aesmd";+  version = version;+  src = fetchurl {+    url = url;+    name = "aesmd.deb";+    sha256 = sha256;+  };++  buildCommand = ''+    set -euo pipefail+    ar x $src+    mkdir -p $out+    tar -xaf data.tar.xz -C $out++    AESM_PATH=$out/opt/intel/libsgx-enclave-common/aesm+    mkdir -p $out/etc+    cp -rf $AESM_PATH/conf/aesmd.conf $out/etc/aesmd.conf++    patchelf \+      --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" \+      --set-rpath ${lib.makeLibraryPath (with pkgs; [ stdenv.cc.cc.lib openssl protobuf3_0 ])}:$AESM_PATH \

Is it not possible to compile it from source?

exFalso

comment created time in 4 days

Pull request review commentNixOS/nixpkgs

Add SGX packages

 in    intel-ocl = callPackage ../os-specific/linux/intel-ocl { }; +  intel-aesmd = callPackage ../os-specific/linux/intel-aesmd/2.7.0.nix { };+  intel-aesmd2_3_1 = callPackage ../os-specific/linux/intel-aesmd/2.3.1.nix { };+  intel-aesmd2_4_0 = callPackage ../os-specific/linux/intel-aesmd/2.4.0.nix { };+  intel-aesmd2_5_0 = callPackage ../os-specific/linux/intel-aesmd/2.5.0.nix { };+  intel-aesmd2_6_0 = callPackage ../os-specific/linux/intel-aesmd/2.6.0.nix { };+  intel-aesmd2_7_0 = callPackage ../os-specific/linux/intel-aesmd/2.7.0.nix { };

Than I only would add 2.4 and the latest.

exFalso

comment created time in 4 days

push eventMic92/nixpkgs

Jörg Thalheim

commit sha 830a690c074fef009490920f42c22b134dbd3e75

test-driver: add mypy support It's a good idea to expand this in future to test code as well, so we get type checking there as well.

view details

push time in 5 days

Pull request review commentNixOS/nixpkgs

lorri: init at version rolling-release-2019-10-30

+{ stdenv, pkgs, fetchFromGitHub, rustPlatform, CoreServices, Security+, cf-private }:++rustPlatform.buildRustPackage rec {+  pname = "lorri";+  version = "rolling-release-2019-10-30";++  src = fetchFromGitHub {+    owner = "target";+    repo = pname;+    rev = "03f10395943449b1fc5026d3386ab8c94c520ee3";+    sha256 = "0fcl79ndaziwd8d74mk1lsijz34p2inn64b4b4am3wsyk184brzq";+  };++  BUILD_REV_COUNT = src.revCount or 1;+  RUN_TIME_CLOSURE = pkgs.callPackage ./runtime.nix { };++  nativeBuildInputs = [ pkgs.nix pkgs.direnv pkgs.which ];+  buildInputs =+    stdenv.lib.optionals stdenv.isDarwin [ CoreServices Security cf-private ];++  cargoSha256 = "1daff4plh7hwclfp21hkx4fiflh9r80y2c7k2sd3zm4lmpy0jpfz";++  # Note that https://travis-ci.org/target/lorri/builds/605036891 passed.+  doCheck = false;

@curiousleo you can just point the NIX_PATH to $src. No need to have these nix files locally.

curiousleo

comment created time in 5 days

pull request commentNixOS/nixpkgs

rustc: add support for armv7l targets

@GrahamcOfBorg build rustc

urbas

comment created time in 5 days

push eventMic92/nixpkgs

Jörg Thalheim

commit sha 1363de56dd2539a871e867fee5199618414e3509

test-driver: add mypy support It's a good idea to expand this in future to test code as well, so we get type checking there as well.

view details

push time in 5 days

push eventMic92/nixpkgs

Marijan Petricevic

commit sha 5854aaf680e3c04629a62f36a2ea27dccd82fcae

nixos/tests: improve get_unit_info expressiveness on failure

view details

Jörg Thalheim

commit sha 438a0cd40b2e40c0b85f6ea2eafaca094bd16bae

Merge pull request #73032 from marijanp/improvement-test-driver-py nixos/tests: improve get_unit_info expressiveness on failure

view details

Jörg Thalheim

commit sha 27b634251d6d85f0de01c0aa1105d30c6fae4e3c

test-driver: add mypy support It's a good idea to expand this in future to test code as well, so we get type checking there as well.

view details

push time in 5 days

push eventNixOS/nixpkgs

Marijan Petricevic

commit sha 5854aaf680e3c04629a62f36a2ea27dccd82fcae

nixos/tests: improve get_unit_info expressiveness on failure

view details

Jörg Thalheim

commit sha 438a0cd40b2e40c0b85f6ea2eafaca094bd16bae

Merge pull request #73032 from marijanp/improvement-test-driver-py nixos/tests: improve get_unit_info expressiveness on failure

view details

push time in 5 days

PR merged NixOS/nixpkgs

nixos/tests: improve get_unit_info expressiveness on failure 10.rebuild-darwin: 0 10.rebuild-linux: 0 6.topic: nixos

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

The returning of None results in an unexpressive "'NoneType' object is not subscriptable" exception in wait_for_unit and require_unit_state when accessing the info dictionary.

Things done

Code conforms the Black coding style. Changed the simple.nix test and ran it to provocate a failure and check if the Exception is thrown.

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc @worldofpeace

+5 -1

0 comment

1 changed file

marijanp

pr closed time in 5 days

Pull request review commentNixOS/nixpkgs

nixos/tests: improve get_unit_info expressiveness on failure

 def wait_for_unit(self, unit, user=None):     def get_unit_info(self, unit, user=None):         status, lines = self.systemctl('--no-pager show "{}"'.format(unit), user)         if status != 0:-            return None+            raise Exception(

I agree with this. The current handling of this is buggy.

marijanp

comment created time in 5 days

pull request commentNixOS/nixpkgs

test-driver: add mypy support

cc @worldofpeace @flokli @marijanp

Mic92

comment created time in 5 days

pull request commentNixOS/nixpkgs

test-driver: add mypy support

Tested running borgbackup.nix

Mic92

comment created time in 5 days

PR opened NixOS/nixpkgs

test-driver: add mypy support

It's a good idea to expand this in future to test code as well, so we get type checking there as well.

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change
Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ ] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
Notify maintainers

cc @

+114 -92

0 comment

2 changed files

pr created time in 5 days

push eventMic92/nixpkgs

Benjamin Hipple

commit sha 34f31030b1f8b32ad3889f7adb0150900174293d

pythonPackages.measurement: init at 2.0.1

view details

Benjamin Hipple

commit sha b0fd85501529d68dd09956f2ba6eae7097005cb0

pythonPackages.myfitnesspal: init at 1.13.3

view details

William Casarin

commit sha 8a24d2ba448a474324f543578311513959069c4e

zoneminder: fix nginx config For some reason it doesn't seem to load things in the cache directory properly without this slash. Looks like this regression may have been introduced in: commit 19851ec1fce3fabec3c6f951c3fb7d5814d24691 nixos/zoneminder: Fix nginx config check Cc: Daniel Schaefer <git@danielschaefer.me> Cc: Peter Hoeg <peter@hoeg.com> Signed-off-by: William Casarin <jb55@jb55.com>

view details

Adam Saponara

commit sha 7a2084ee7b260c8282874ec45b6712a3c1b94966

maintainers: add adsr

view details

0x4A6F

commit sha 1bcc7027d99fae103953e989919b91b2bcaa25b3

eidolon: init at 1.4.6

view details

Adam Saponara

commit sha c7a92135050a1fdec5e7d0bb9bba150360397738

mle: init at 1.4.1

view details

Serhii Khoma

commit sha e92866d74f3a795dc4b6f50d53815b50dab01b37

write_stylus: fix error "cannot download icon.tar.gz from any mirror" error message was ``` trying https://oyra.eu/write/icon.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 curl: (22) The requested URL returned error: 404 Not Found error: cannot download icon.tar.gz from any mirror ```

view details

Nikolay Korotkiy

commit sha 6d4a015d6568688e15dad6144e121787aee73af4

lsd2dsl: init at 0.4.1

view details

Edmund Wu

commit sha 26ff3da4b774934cd877332f920dacedf544197d

linux_rpi: fix overrides

view details

Doron Behar

commit sha c7f682a59a3bb8106caab1e4f7d2fcc5480ff554

units: Add units_cur python script to $out

view details

Minijackson

commit sha 0309903c799a7445a2acddc63f3948a75e58f46d

rx: init at 0.2.0

view details

Edmund Wu

commit sha 436d94feeafeb32ca7f763da8f47e4cd87846454

linux_rpi: 1.20190906 -> 1.20190925

view details

Edmund Wu

commit sha 0266449187ebc8efe75124cc35f7f079d6976c0b

raspberrypifw: 1.20190819 -> 1.20190925

view details

Edmund Wu

commit sha 5766bd451a63eae11ba19d9eaaa55968129aa056

update-systemd-resolved: init at 1.3.0

view details

Francesco Gazzetta

commit sha f107623c138a3771a252c6027dc2bff51e76561a

qremotecontrol-server: init at 2.4.1

view details

Pierre Bourdon

commit sha 1b7783072c215ad6c5c98cd9c03e3e9517ac3a9d

lua5_1: rename patch file to match its CVE id

view details

Jonathan Ringer

commit sha c83aaba739c9efd60d56ffb3bc0fdfea2be949be

soulseekqt: fix build - Previous url returned a 404 - Updated expression to use new Qt utilities - Cleaned up expression

view details

Joseph G Lukasik

commit sha 4445c6657d73ba65bdcdf65fbd6866562ac7c7bd

perlPackages.Tirex: init at 0.6.1

view details

Doron Behar

commit sha e86ef91b58d23d28c327b59c9ed4b6041bd8c9cb

gaia: init at 2.4.5

view details

zfnmxt

commit sha 4af22ae959aa58d55fd4f1dd80e734d48f8a63c8

maintainers: add zfnmxt

view details

push time in 5 days

create barnchMic92/nixpkgs

branch : mypy

created branch time in 5 days

Pull request review commentNixOS/nixpkgs

signal-cli: enable dbus functionality

 stdenv.mkDerivation rec {     sha256 = "1gvdifscyxmxn2dwlkqi684ahy5kbcj84mqda0m8l4aa8iaq1d59";   }; -  buildInputs = [ makeWrapper ];+  buildInputs = [ libmatthew_java dbus dbus_java ];

This should fix evaluation on macOS:

It is not required on Linux as far as I can see?

erictapen

comment created time in 6 days

pull request commentNixOS/nixpkgs

signal-cli: enable dbus functionality

@GrahamcOfBorg build signal-cli

erictapen

comment created time in 6 days

issue commentNixOS/rfc-steering-committee

RFC Meeting 2019-10-31

Sorry. I feel sick today. Could someone else take over the meeting? Cheers.

shlevy

comment created time in 6 days

push eventNixOS/nixpkgs

Jörg Thalheim

commit sha d6292986d8d083b2a03b7dee0c29bdbd5639c94b

android-udev-rules: 20190315 -> 20191103

view details

push time in 8 days

delete branch Mic92/pass-import

delete branch : flag-fix

delete time in 9 days

push eventNixOS/nixpkgs

Andreas Rammhold

commit sha d1bef95b4cb0bc6df4a9bb92a97f68e62faaa465

dino: unstable-2019-09-12 -> unstable-2019-10-28 This fixes a crash when receiving files via OMEMO.

view details

Jörg Thalheim

commit sha 0afcd297bd10e54f6e0df86e1c04193bc8c617c5

Merge pull request #72575 from andir/dino dino: unstable-2019-09-12 -> unstable-2019-10-28

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
dino: unstable-2019-09-12 -> unstable-2019-10-28 10.rebuild-darwin: 0 10.rebuild-linux: 1-10

This fixes a crash when receiving files via OMEMO.

Motivation for this change

Fixing a crash when receiving OMEMO encrypted files.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [X] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [X] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

+3 -3

0 comment

1 changed file

andir

pr closed time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha ec4774d316bbdabf69dc41e21d6875bfbc2a3c7c

jgmenu: 3.4 -> 3.5

view details

Jörg Thalheim

commit sha d7bc19a340a2eada42853e9370b1e9a6d354125e

jgmenu: 3.4 -> 3.5 (#72527) jgmenu: 3.4 -> 3.5

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
jgmenu: 3.4 -> 3.5 10.rebuild-darwin: 0 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jgmenu/versions.

meta.description for jgmenu is: '"Small X11 menu intended to be used with openbox and tint2"'.

meta.homepage for jgmenu is: '"https://github.com/johanmalm/jgmenu"

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 3.5 with grep in /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5

  • directory tree listing: https://gist.github.com/265703ed1ca711a3a1e77955742daf89

  • du listing: https://gist.github.com/f7eebc8c33837d0e59000dc8e0923f63

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 0 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath jgmenu

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jgmenu https://github.com/r-ryantm/nixpkgs/archive/ec4774d316bbdabf69dc41e21d6875bfbc2a3c7c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5
ls -la /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5/bin

</details> <br/>

cc @romildo for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha 901f445cbe0ccfed9734353391989ed6621a2a96

jruby: 9.2.8.0 -> 9.2.9.0

view details

Jörg Thalheim

commit sha f36b98dbd294fd566d9c660fb74f224be5ebe1bb

Merge pull request #72528 from r-ryantm/auto-update/jruby jruby: 9.2.8.0 -> 9.2.9.0

view details

push time in 11 days

PR merged NixOS/nixpkgs

jruby: 9.2.8.0 -> 9.2.9.0 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jruby/versions.

meta.description for jruby is: '"Ruby interpreter written in Java"'.

meta.homepage for jruby is: '"http://jruby.org/"

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 9.2.9.0 with grep in /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0

  • directory tree listing: https://gist.github.com/6805850354c9e19ebd62e066a87114ca

  • du listing: https://gist.github.com/987234bbff11db3c89ac7ffdbc05d630

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath jruby

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jruby https://github.com/r-ryantm/nixpkgs/archive/901f445cbe0ccfed9734353391989ed6621a2a96.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0
ls -la /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0/bin

</details> <br/>

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha eaa967989747716e0016ebcb5924e129a4a31a17

hyperscan: 5.1.1 -> 5.2.1

view details

Jörg Thalheim

commit sha bf3c44b5adecb8307efc585e32f24ebb3407e787

Merge pull request #72526 from r-ryantm/auto-update/hyperscan hyperscan: 5.1.1 -> 5.2.1

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
hyperscan: 5.1.1 -> 5.2.1 10.rebuild-darwin: 0 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/hyperscan/versions.

meta.description for hyperscan is: '"High-performance multiple regex matching library"'.

meta.homepage for hyperscan is: '"https://www.hyperscan.io/"

Release on GitHub

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 5.2.1 with grep in /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1

  • directory tree listing: https://gist.github.com/6c919aecce1d41c01699290ef169585f

  • du listing: https://gist.github.com/bb37e9b6dce7b6b9dc519f2aeb8311af

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 0 x86_64-darwin rebuild(s) 0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath hyperscan rspamd suricata

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A hyperscan https://github.com/r-ryantm/nixpkgs/archive/eaa967989747716e0016ebcb5924e129a4a31a17.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1
ls -la /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1/bin

</details> <br/>

cc @avnik for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha 69390743f0625b44e18aa8f9e41ab5da11207d5c

jsonrpc-glib: 3.33.3 -> 3.34.0

view details

Jörg Thalheim

commit sha 187f68baa609a0723b3b9b2557a5671f7245ee39

Merge pull request #72531 from r-ryantm/auto-update/jsonrpc-glib jsonrpc-glib: 3.33.3 -> 3.34.0

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
jsonrpc-glib: 3.33.3 -> 3.34.0 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jsonrpc-glib/versions.

meta.description for jsonrpc-glib is: '"A library to communicate using the JSON-RPC 2.0 specification"'.

meta.homepage for jsonrpc-glib is: '"https://gitlab.gnome.org/GNOME/jsonrpc-glib"

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 3.34.0 with grep in /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0

  • directory tree listing: https://gist.github.com/6a4a91327b4ae66d8cbfef6ef284fd9b

  • du listing: https://gist.github.com/aa11d0ca1d9c9e56fd39597cb9fbac22

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

7 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s) 2 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath gnome-builder jsonrpc-glib

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jsonrpc-glib https://github.com/r-ryantm/nixpkgs/archive/69390743f0625b44e18aa8f9e41ab5da11207d5c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0
ls -la /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0/bin

</details> <br/>

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha b3799c562794aafe5564b4463fa7acebdbaf3e9c

jmol: 14.29.54 -> 14.29.55

view details

Jörg Thalheim

commit sha 04a079082c10b693762b7d2fb29f3da0263a67ae

Merge pull request #72539 from r-ryantm/auto-update/jmol jmol: 14.29.54 -> 14.29.55

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
jmol: 14.29.54 -> 14.29.55 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jmol/versions.

meta.description for jmol is: '"A Java 3D viewer for chemical structures"'.

meta.homepage for jmol is: '"https://sourceforge.net/projects/jmol"

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 14.29.55 with grep in /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55

  • directory tree listing: https://gist.github.com/7142220b28a433589c36507bc13d1c46

  • du listing: https://gist.github.com/71d06f28e64c4f76e94ff4579bf9823c

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath jmol

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jmol https://github.com/r-ryantm/nixpkgs/archive/b3799c562794aafe5564b4463fa7acebdbaf3e9c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55
ls -la /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55/bin

</details> <br/>

cc @timokau @mounium for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

pull request commentNixOS/nixpkgs

jetty: 9.4.16.v20190411 -> 9.4.22.v20191022

cc @yorickvP

r-ryantm

comment created time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha 3d13a8a42ce1ed09cd6c527ec2168e2ed8a96ac2

gpodder: 3.10.9 -> 3.10.11

view details

Jörg Thalheim

commit sha 245a706b8e9f87822c339d4f97166794c4f90d37

gpodder: 3.10.9 -> 3.10.11 (#72524) gpodder: 3.10.9 -> 3.10.11

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
gpodder: 3.10.9 -> 3.10.11 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gpodder/versions.

meta.description for gpodder is: '"A podcatcher written in python"'.

meta.homepage for gpodder is: '"http://gpodder.org/"

Release on GitHub

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 3.10.11 with grep in /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11

  • directory tree listing: https://gist.github.com/fb6963968cecc4ab12055864efd6a2de

  • du listing: https://gist.github.com/bb23fbc3014ca6c05309d2e809a9722a

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath gpodder

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A gpodder https://github.com/r-ryantm/nixpkgs/archive/3d13a8a42ce1ed09cd6c527ec2168e2ed8a96ac2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11
ls -la /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11/bin

</details> <br/>

cc @svenkeidel @mic92 for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

pull request commentNixOS/nixpkgs

esptool: 2.7 -> 2.8

espefuse.py tries to import our wrapped esptool, which fails due being wrapped.

$ espefuse.py
Traceback (most recent call last):
  File "/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin/.espefuse.py-wrapped", line 22, in <module>
    import esptool
  File "/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin/esptool.py", line 2
    export PATH='/nix/store/zdh16dcvjw99ybam59zd2ijb6bx138j0-python3-3.7.5/bin:/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin:/nix/store/2w9f7hqjnkv6xw63p3jvjr5z6m12d0w5-python3.7-pyserial-3.4/bin'${PATH:+':'}$PATH
              ^
SyntaxError: invalid syntax
r-ryantm

comment created time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha 177eeccaac4e3e52e356d5dbf1ed4bc0b6eb2cde

di: 4.47.1 -> 4.47.2

view details

Jörg Thalheim

commit sha 9f4d7c9941117d4e01222451b6f7c11dd41020a9

di: 4.47.1 -> 4.47.2 (#72481) di: 4.47.1 -> 4.47.2

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
di: 4.47.1 -> 4.47.2 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/di/versions.

meta.description for di is: '"Disk information utility; displays everything 'df' does and more"'.

meta.homepage for di is: '"https://gentoo.com/di/"

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 4.47.2 with grep in /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2

  • directory tree listing: https://gist.github.com/3a8343a35b778bbb9729cf2712937fe8

  • du listing: https://gist.github.com/988e0247e083f93438260316c941d685

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath di

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A di https://github.com/r-ryantm/nixpkgs/archive/177eeccaac4e3e52e356d5dbf1ed4bc0b6eb2cde.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2
ls -la /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2/bin

</details> <br/>

cc @manveru @ndowens for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

push eventNixOS/nixpkgs

Andrew Childs

commit sha a5ca97028ff9af0249b59b3a2f217ce0dd81844a

ec2-utils: init at 0.5.1

view details

Andrew Childs

commit sha 4c446b82682249e23a0141d27fa035e6ae8c515a

amazon-image: include ec2-utils in udev rules This sets up device mappings like /dev/xvda -> /dev/nvme0n1

view details

Jörg Thalheim

commit sha b55a7a3a57dd77ee3c160b7e83074dafa177adff

ec2-utils: init at 0.5.1, include in amazon-image profile (#67347) ec2-utils: init at 0.5.1, include in amazon-image profile

view details

push time in 11 days

PR merged NixOS/nixpkgs

ec2-utils: init at 0.5.1, include in amazon-image profile 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 6.topic: nixos 8.has: module (update) 8.has: package (new)

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Friendly device names on ec2 instances. This is the most "upstream" version I could find.

Note to reviewer: this package includes a handful of udev rules:

result/etc/udev/rules.d
├── 51-ec2-hvm-devices.rules
├── 52-ec2-vcpu.rules
├── 60-cdrom_id.rules
└── 70-ec2-nvme-devices.rules

I primarily want 70-ec2-nvme-devices.rules, but haven't thought carefully about the consequences of including the rest.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
+52 -0

2 comments

3 changed files

thefloweringash

pr closed time in 11 days

pull request commentNixOS/nixpkgs

ec2-utils: init at 0.5.1, include in amazon-image profile

Scripts looks legit. Have you tested this?

thefloweringash

comment created time in 11 days

push eventNixOS/nixpkgs

R. RyanTM

commit sha 22103e4f39b9274f36905a99c2132144e31dd3b0

ccls: 0.20190823.3 -> 0.20190823.4

view details

Jörg Thalheim

commit sha 67b79add8c08e3fe44ec8c62f5ccf6f4e855b921

Merge pull request #72462 from r-ryantm/auto-update/ccls ccls: 0.20190823.3 -> 0.20190823.4

view details

push time in 11 days

PR merged NixOS/nixpkgs

Reviewers
ccls: 0.20190823.3 -> 0.20190823.4 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ccls/versions.

meta.description for ccls is: '"A c/c++ language server powered by clang"'.

meta.homepage for ccls is: '"https://github.com/MaskRay/ccls"

Release on GitHub

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 0.20190823.4 with grep in /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4

  • directory tree listing: https://gist.github.com/9cb0e27461564c70f4383469f4f6a2dc

  • du listing: https://gist.github.com/b84f0207bacc49495bc2a8f63909004d

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath ccls

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A ccls https://github.com/r-ryantm/nixpkgs/archive/22103e4f39b9274f36905a99c2132144e31dd3b0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4
ls -la /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4/bin

</details> <br/>

cc @mic92 @tobim for testing.

+2 -2

0 comment

1 changed file

r-ryantm

pr closed time in 11 days

Pull request review commentNixOS/nixpkgs

rustc: add support for armv7l targets

-{ stdenv, buildPackages, fetchurl, fetchpatch, pkgconfig, libuuid, gettext, texinfo }:+{ stdenv, buildPackages, fetchurl, fetchpatch, pkgconfig, libuuid, gettext, texinfo, lib }:

Could you make this a separate commit?

urbas

comment created time in 11 days

PR opened roddhjav/pass-import

don't interpret password names as flags

When importing wifi passwords it might happen that filenames start with dash due to escaping. This is interpreted by pass's flag parsing.

+1 -1

0 comment

1 changed file

pr created time in 12 days

create barnchMic92/pass-import

branch : flag-fix

created branch time in 12 days

push eventNixOS/nixpkgs

oxalica

commit sha 24af7ef42704e70a76ad6e1b1bd483a648357a9d

rust-src: shrink the size

view details

Jörg Thalheim

commit sha 8b8eeb849118b845da4d124011024fa1369fe365

rust-src: shrink the size (#72434) rust-src: shrink the size

view details

push time in 12 days

PR merged NixOS/nixpkgs

Reviewers
rust-src: shrink the size 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 6.topic: rust

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

It should exclude sub-modules like llvm, but the name list for rm is outdated.

Closure size: 550 MiB -> 24.6 MiB

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
    • It's just source.
  • [x] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
Notify maintainers

cc @

+1 -1

0 comment

1 changed file

oxalica

pr closed time in 12 days

push eventNixOS/nixpkgs

exfalso

commit sha a588b1dfbc83c0915f2b4cf097d4892730b03482

build-support/rust: Add target option

view details

exfalso

commit sha bb7184d6a62f3eefdadb069091f8985871279b15

buildRustPackage: Add readme comment on target option

view details

Jörg Thalheim

commit sha 56240d7f20a2cc4b931a89617c37403586dc5b74

Merge pull request #71899 from decentriq/aslemmer/build-rust-package-add-target build-support/rust: Add target option

view details

push time in 12 days

PR merged NixOS/nixpkgs

build-support/rust: Add target option 10.rebuild-darwin: 0 10.rebuild-linux: 0 6.topic: rust 8.has: documentation
Motivation for this change

This PR adds a flag to buildRustPackage that can override the --target flag to cargo.

Things done

Added the flag, adjusted corresponding paths in the code.

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [x] other Linux distributions (Arch Linux)
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
Notify maintainers

cc @andir @Mic92

+16 -3

4 comments

2 changed files

exFalso

pr closed time in 12 days

push eventNixOS/nixpkgs

Jelle Besseling

commit sha c50a10bf20e788f520ab12ee21b01fec1b9ce28f

maintainers: add pingiun

view details

Jelle Besseling

commit sha a25d98f39937dda6f69ad658275d2cfe87cf5139

eternal-terminal: 5.1.10 -> 6.0.4

view details

Jörg Thalheim

commit sha 39e559212716e200347c5af4aa09940ea55b13b4

eternal-terminal: 5.1.10 -> 6.0.4 (#71915) eternal-terminal: 5.1.10 -> 6.0.4

view details

push time in 12 days

PR merged NixOS/nixpkgs

Reviewers
eternal-terminal: 5.1.10 -> 6.0.4 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Eternal Terminal has had new releases, also the repository name was changed.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x] NixOS
    • [x] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [x] Tested execution of all binary files (usually in ./result/bin/)
  • [x] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [x] Fits CONTRIBUTING.md.
Notify maintainers

cc @dezgeg

+23 -7

6 comments

2 changed files

pingiun

pr closed time in 12 days

push eventnix-community/NUR

Daniel Løvbrøtte Olsen

commit sha 45ac6d2f52f635ab73883352ba1ee0f3a10896bd

Add my nur-repo to the NUR :D Really cool project this here

view details

Jörg Thalheim

commit sha 6b8115c8f74ad4810ec43febb6d4f53205116d71

Merge pull request #152 from dali99/patch-1 Add my nur-repo to the NUR :D

view details

push time in 12 days

more