profile
viewpoint

hluk/CopyQ 2707

Clipboard manager with advanced features

johnpaparrizos/kshape 138

Python implementation of k-Shape

chaosbastler/opentraining 66

Android App for planing your fitness training.

devkid/nftables-systemd 21

Control script for nftables with a systemd service file

Mic92/ansible-lxc 18

Ansible Connection Plugin for lxc containers (https://linuxcontainers.org/)

Mic92/2048.ko 14

Play 2048 in the Linux kernel

devkid/QRearrangeableLayout 3

Use QSplitter elements to layout your GUI and let the user rearrange the widgets how he wishes.

Mic92/Algebra-I 3

Das inoffizielle Skript zur Vorlesung bei Prof. Schmidt

1hoch4/skyquad-maps 2

Plan your flight routes for your SkyQuad quadrotor on your Android device.

push eventMic92/dotfiles

Jörg Thalheim

commit sha 4cb38a04330a4d1001da608ca9c927db90b77649

github ci: fix cachix push

view details

push time in 11 minutes

push eventMic92/dotfiles

Jörg Thalheim

commit sha c2043db5fb74a5af27e244de9e4ae5f954071817

add custom doom configuration

view details

Jörg Thalheim

commit sha e25e557e1c6b29017c25e77d170f2bf49bcebb82

disable spacemacs stuff

view details

Jörg Thalheim

commit sha bb97492945f86926c9d23647bd7748b6a5c8a341

turingmachine: update secrets shell hook

view details

Jörg Thalheim

commit sha f8e0c0a0133e742deb05566b21f07f13688fc857

zshrc: disable emacs detection

view details

push time in 15 minutes

push eventMic92/dotfiles

Jörg Thalheim

commit sha 19e07645cf1d3f07c82520d170368f4e86a422a4

fix jq filter

view details

push time in an hour

push eventMic92/dotfiles

Jörg Thalheim

commit sha 9181b27272076fe9e02ee970fb3f4165af177ba1

add doom configuration

view details

push time in an hour

delete branch Mic92/dotfiles

delete branch : ci-test

delete time in 2 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha a1a08311b3596695a607c12c5ad06eea92a05bed

turingmachine: krops convert to flakes

view details

Jörg Thalheim

commit sha bdca70132ffa3425f3295893fd185a87660391f0

Merge pull request #5 from Mic92/ci-test turingmachine: krops convert to flakes

view details

push time in 2 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 1ad157985a7d0a3cbb4ee0ca7e7cb67cf8a33b08

fix nix path-info command

view details

push time in 2 hours

create barnchMic92/dotfiles

branch : ci-test

created branch time in 2 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha fdff3ac198315b716b7a39f6d91ee731d7636259

retiolum: checksum for networking.extraHosts

view details

push time in 2 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 0147beb40bba33a9df0ed1c717c9578b3a4e7c1e

create as many build users as cores

view details

push time in 3 hours

PR merged Mic92/dotfiles

turingmachine: krops convert to flakes
+7 -4

0 comment

1 changed file

Mic92

pr closed time in 3 hours

PR opened Mic92/dotfiles

turingmachine: krops convert to flakes
+7 -4

0 comment

1 changed file

pr created time in 3 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha c8f2ba3a36721344203d41072142f57cea04e303

disable latex for now

view details

push time in 4 hours

push eventMic92/nur-packages

Jörg Thalheim

commit sha 8487f7e65577a772eefa1b938ca418d6d68eea9e

python3.pkgs.chump: add expression file

view details

push time in 4 hours

created tagMic92/iana-etc

tag20200714

Build /etc/protocols and /etc/services files from IANA's Assigned Internet Protocol Numbers

created time in 4 hours

push eventMic92/iana-etc

Travis CI

commit sha 50949f9eecadf35fcc145f6ad07a8f17ecf921d1

add new iana release 20200714

view details

push time in 4 hours

push eventMic92/doctor-cluster-config

Jörg Thalheim

commit sha bbf26d91f638af4fb489ef1c2bc9ac1a2639bb4d

enable forwarding for docker

view details

push time in 4 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha f7f7c43bd565527eb30b5966ea2347112b862c6a

github action: fix quoting

view details

push time in 4 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha bf7ab603c9cb5a70823be75f912e98d5b354bccf

cachix: don't upload fixed-input derivations or packages from the binary cache

view details

push time in 4 hours

push eventMic92/doctor-cluster-config

Jörg Thalheim

commit sha 432cf178239b9cefb2d0f593cddc98e798efb9aa

scone: don't provide sgx-musl.conf This is better set by each project using SGX_CONFIG environment variable.

view details

push time in 7 hours

push eventMic92/doctor-cluster-config

Jörg Thalheim

commit sha 4ed0f25ae905d37ab86e68d21492de93930704ef

scone: use optimized configuration by i/o

view details

push time in 7 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha fef564d4d3efdca7b641b144a4222dc216f9e3b4

github ci: more space

view details

push time in 9 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha add8445cb316b9a796910a71e694d00291954ea4

github ci: more space

view details

push time in 9 hours

pull request commentNixOS/rfcs

[RFC 0070] Merge nixos-hardware in to nixpkgs (#70)

IIRC, these are NixOS system configuration snippets, which also interact a lot with the rest of the NixOS system. There seems to be the need to keep this tightly coupled. Moving it into a flake doesn't change the fact the code lives in a separate repo, and that pointers need to be manually synchronized. Also, refactorings with nixpkgs NixOS code gets much more complicated, as well as testing.

Having to use an experimental feature just to make some configuration snippets available seems a bit risky and overkill, which is also why I'm in favor of this RFC.

In any case, can the RFC Steering Committee move this RFC forward?

We will tomorrow. Last week there were not enough committee members present to set the shepherd team.

Mic92

comment created time in 10 hours

Pull request review commentNixOS/nixpkgs

singularity: 3.2.1 -> 3.6.0

 {stdenv , removeReferencesTo , lib-, fetchFromGitHub+, fetchurl , utillinux+, gpgme , openssl+, libuuid , coreutils , go , which , makeWrapper+, cryptsetup , squashfsTools , buildGoPackage}:  with lib;  buildGoPackage rec {   pname = "singularity";-  version = "3.2.1";+  version = "3.6.0"; -  src = fetchFromGitHub {-    owner = "sylabs";-    repo = "singularity";-    rev = "v${version}";-    sha256 = "14lhxwy21s7q081x7kbnvkjsbxgsg2f181qlzmlxcn6n7gfav3kj";+  src = fetchurl {+    url = "https://github.com/hpcng/singularity/releases/download/v${version}/singularity-${version}.tar.gz";+    sha256 = "0jckykq078m30yk049732vll9fbrv8maz55b2cwpw00ba4jhi0dq";   };    goPackagePath = "github.com/sylabs/singularity";   goDeps = ./deps.nix; -  buildInputs = [ openssl utillinux ];-  nativeBuildInputs = [ removeReferencesTo which makeWrapper ];+  hardeningDisable = [ "fortify" ]; # causes longjmp error++  buildInputs = [ gpgme openssl libuuid ];+  nativeBuildInputs = [ removeReferencesTo utillinux which makeWrapper cryptsetup ];   propagatedBuildInputs = [ coreutils squashfsTools ];    prePatch = ''

Usually we apply those in postPatch.

jbedo

comment created time in 10 hours

Pull request review commentNixOS/nixpkgs

singularity: 3.2.1 -> 3.6.0

 buildGoPackage rec {      # Don't install SUID binaries     sed -i 's/-m 4755/-m 755/g' builddir/Makefile-   '';    buildPhase = ''+    runHook preBuild     make -C builddir+    runHook postBuild   '';
  makeFlags = [ "-C" "builddir" ];
jbedo

comment created time in 10 hours

Pull request review commentNixOS/nixpkgs

singularity: 3.2.1 -> 3.6.0

 {stdenv , removeReferencesTo , lib-, fetchFromGitHub+, fetchurl , utillinux+, gpgme , openssl+, libuuid , coreutils , go , which , makeWrapper+, cryptsetup , squashfsTools , buildGoPackage}:  with lib;  buildGoPackage rec {   pname = "singularity";-  version = "3.2.1";+  version = "3.6.0"; -  src = fetchFromGitHub {-    owner = "sylabs";-    repo = "singularity";-    rev = "v${version}";-    sha256 = "14lhxwy21s7q081x7kbnvkjsbxgsg2f181qlzmlxcn6n7gfav3kj";+  src = fetchurl {+    url = "https://github.com/hpcng/singularity/releases/download/v${version}/singularity-${version}.tar.gz";+    sha256 = "0jckykq078m30yk049732vll9fbrv8maz55b2cwpw00ba4jhi0dq";   };    goPackagePath = "github.com/sylabs/singularity";   goDeps = ./deps.nix; -  buildInputs = [ openssl utillinux ];-  nativeBuildInputs = [ removeReferencesTo which makeWrapper ];+  hardeningDisable = [ "fortify" ]; # causes longjmp error

Is this issue known upstream as well?

jbedo

comment created time in 10 hours

Pull request review commentNixOS/nixpkgs

singularity: 3.2.1 -> 3.6.0

 buildGoPackage rec {      # Don't install SUID binaries     sed -i 's/-m 4755/-m 755/g' builddir/Makefile-   '';    buildPhase = ''+    runHook preBuild     make -C builddir+    runHook postBuild   '';    installPhase = ''+    runHook preInstall     make -C builddir install LOCALSTATEDIR=$out/var     chmod 755 $out/libexec/singularity/bin/starter-suid-    wrapProgram $out/bin/singularity --prefix PATH : ${stdenv.lib.makeBinPath propagatedBuildInputs}+    runHook postInstall   '';    postFixup = ''     find $out/libexec/ -type f -executable -exec remove-references-to -t ${go} '{}' + || true

Different PR, but should we include $out/libexec in buildGoPackage as well for removing references?

jbedo

comment created time in 10 hours

pull request commentNixOS/nixpkgs

singularity: 3.2.1 -> 3.6.0

Is this also broken in 20.03?

jbedo

comment created time in 10 hours

Pull request review commentMic92/nixpkgs-review

Add merge methods

 def parse_args(command: str, args: List[str]) -> argparse.Namespace:     comments_parser.set_defaults(func=show_comments)      merge_parser = subparsers.add_parser("merge", help="merge PR")+    merge_parser.add_argument("-m", "--method", default="merge", help="Merge method")

Did you forget to commit a file? merge_parser.method is not used anywhere.

0mbi

comment created time in 10 hours

push eventMic92/nixpkgs-review

David Arnold

commit sha d701731cf44c03bc050a959fa42ea51c0161a091

report: improve package list format as <ul>

view details

Jörg Thalheim

commit sha 7964e027aee28fe3f67c9f13fb2756ce218e5e4f

Merge pull request #118 from blaggacao/da-imp-report-list

view details

push time in 10 hours

PR merged Mic92/nixpkgs-review

report: improve package list format as <ul>

To make this anunordered list: image

+11 -9

3 comments

2 changed files

blaggacao

pr closed time in 10 hours

delete branch Mic92/dotfiles

delete branch : ci

delete time in 10 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha cecbee628fb7eba699f6bdc6d39fe18c069695b3

emacs: add unzip needed for dap mode

view details

Jörg Thalheim

commit sha 7be635d067c4bb81d084522fd4ef760c954445ef

ci: switch to nixFlakes

view details

Jörg Thalheim

commit sha 75a2dfd518f8b180628829ff51554e5f8f0f294c

remove nur override from nix path

view details

Jörg Thalheim

commit sha 171e491e79774c9d40b508b2a9fe91ae230b4e52

hack to set NIX_PATH from flakes

view details

Jörg Thalheim

commit sha 547c937073d8722d4afd05cc569f5c71d1f05cfe

Merge pull request #4 from Mic92/ci

view details

push time in 10 hours

PR merged Mic92/dotfiles

switch to nixFlakes
+99 -66

0 comment

8 changed files

Mic92

pr closed time in 10 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 171e491e79774c9d40b508b2a9fe91ae230b4e52

hack to set NIX_PATH from flakes

view details

push time in 10 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 235b2d9fa89da5f5e29cb9d4deda82f2f44c0cd6

hack to set NIX_PATH from flakes

view details

push time in 10 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 0abf41699493500a27ccef26f0220cd436707524

hack to set NIX_PATH from flakes

view details

push time in 11 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 75a2dfd518f8b180628829ff51554e5f8f0f294c

remove nur override from nix path

view details

Jörg Thalheim

commit sha cd4ebfc0fbb546f8f7fe10eabf8f5e3a4df6c07e

hack to set NIX_PATH from flakes

view details

push time in 11 hours

Pull request review commentNixOS/nixpkgs

nixos/systemd: Implement a packages option for tmpfiles

 in         unitConfig.X-StopOnReconfiguration = true;       }; +    systemd.tmpfiles.packages = [+      # Default tmpfiles rules provided by systemd+      (pkgs.runCommand "systemd-default-tmpfiles" {} ''+        mkdir -p $out/lib/tmpfiles.d+        cd $out/lib/tmpfiles.d++        ln -s "${systemd}/example/tmpfiles.d/home.conf"+        ln -s "${systemd}/example/tmpfiles.d/journal-nocow.conf"+        ln -s "${systemd}/example/tmpfiles.d/static-nodes-permissions.conf"+        ln -s "${systemd}/example/tmpfiles.d/systemd.conf"+        ln -s "${systemd}/example/tmpfiles.d/systemd-nologin.conf"+        ln -s "${systemd}/example/tmpfiles.d/systemd-nspawn.conf"+        ln -s "${systemd}/example/tmpfiles.d/systemd-tmp.conf"+        ln -s "${systemd}/example/tmpfiles.d/tmp.conf"+        ln -s "${systemd}/example/tmpfiles.d/var.conf"+        ln -s "${systemd}/example/tmpfiles.d/x11.conf"+      '')
        for f in ${systemd}/example/tmpfiles.d/*.conf; do
          ln -s $f
        done
      '')
dasJ

comment created time in 11 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 7be635d067c4bb81d084522fd4ef760c954445ef

ci: switch to nixFlakes

view details

push time in 12 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 11bad84d42209325c7bcd80ece423271dc28866f

ci: switch to nixFlakes

view details

push time in 12 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 74a5aef1a9125002c1919096fc5dfb026df64d4d

ci: switch to nixFlakes

view details

push time in 12 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 97564a64b6cef031a64fe0e2000d5efb96503381

ci: switch to nixFlakes

view details

push time in 12 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 9ed4c777a33fc318d8540b54a1e5e907ec1abc86

ci: switch to nixFlakes

view details

push time in 12 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha cecbee628fb7eba699f6bdc6d39fe18c069695b3

emacs: add unzip needed for dap mode

view details

Jörg Thalheim

commit sha 2f1671248fba310a5133a37ecb69b18385afe085

switch to nixFlakes

view details

push time in 12 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha a7fef9ca146df3b60d93d53719d553d4811fe06a

switch to nixFlakes

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha b4e1016541c30d69b42455f01ab835d5a9e55cd5

switch to nixFlakes

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 6ce88bc2a2d94084a62578c34f960cb8420b9d9b

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha b5753b6727cdd61a8b1969819ab0cb99574d2a3d

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 1e13f4cac0a16146346942c50ec7384cb2d936b8

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 7b8a36330771492ed891020ee0817d9da810d1ed

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 882cf5da276acfb8a8579d09f0795b0c7048300f

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha dfcdc2295666d324ebf40c7545bd026d63d5c6f6

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 62a8012accd94c7ff6a2a1b87f58059ceac2d299

nix flake installer

view details

push time in 20 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 44078a90286cc355bfe0665e2363f833b5f34ee5

switch to nixFlakes

view details

push time in 21 hours

PR opened Mic92/dotfiles

switch to nixFlakes
+3 -7

0 comment

1 changed file

pr created time in 21 hours

create barnchMic92/dotfiles

branch : ci

created branch time in 21 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 610a8bab6b5c797ba5eea1f76f8b1e57f14e37e7

remove turingmachine pass secrets

view details

Jörg Thalheim

commit sha 23005a198c067fd00e0a9def094576dbc4ae5148

convert eddie to sops-nix

view details

Jörg Thalheim

commit sha ba1bdd97ebccdd927d2e959f4b41fa3aefacb02e

flake.nix: add

view details

Jörg Thalheim

commit sha 434643eb86b3bc949d60eb25ee31e044eae405d3

eddie: use right key

view details

push time in 21 hours

push eventMic92/dotfiles

Jörg Thalheim

commit sha 76a0220b56cf61ea4d5b66877f8fd32d423cca05

add snippet to add breakpoint on lkl

view details

Jörg Thalheim

commit sha 083650bd3555fdeb8204853ed6e2dc7cc4a17cd1

switch to emacs git

view details

push time in 21 hours

pull request commentNixOS/nixpkgs

nixos/tests/initrd-network-ssh: fix with real initrd secrets implementation

@GrahamcOfBorg test initrd-network-ssh

lopsided98

comment created time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha a6d21fe0d8953195363fbade9fec1151184e9789

remove automerge

view details

push time in a day

delete branch Mic92/sops-nix

delete branch : permission-fixes

delete time in a day

PR opened Mic92/sops-nix

Permission fixes
+30 -1

0 comment

2 changed files

pr created time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha 90db85428c4264efbabe1cf35e963b53c322966f

add automerge workflow

view details

push time in a day

create barnchMic92/sops-nix

branch : permission-fixes

created branch time in a day

delete branch Mic92/sops-nix

delete branch : permission-fixes

delete time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha 8cdca9dd6d32679994a50971ab731ca5ed56a918

secring: open with more secure umask

view details

Jörg Thalheim

commit sha cf34042dc28bc0842f4970cc9845ab7037ad06ad

sops-install-secrets: log gpg fingerprint

view details

Jörg Thalheim

commit sha 5fbb07596637baffa19f56b9927e13b18c0da1f7

Merge pull request #7 from Mic92/permission-fixes

view details

push time in a day

PR merged Mic92/sops-nix

Permission fixes
+6 -1

0 comment

1 changed file

Mic92

pr closed time in a day

PR opened Mic92/sops-nix

Permission fixes
+6 -1

0 comment

1 changed file

pr created time in a day

create barnchMic92/sops-nix

branch : permission-fixes

created branch time in a day

delete branch Mic92/sops-nix

delete branch : permission-fixes

delete time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha 4eda6711baaa3910424cb593f10d1c7d9fb43731

fix /etc/secrets.d permissions

view details

Jörg Thalheim

commit sha 31f88818199479f8a982c699252717c149351130

Merge pull request #6 from Mic92/permission-fixes

view details

push time in a day

PR merged Mic92/sops-nix

fix /etc/secrets.d permissions
+8 -4

0 comment

2 changed files

Mic92

pr closed time in a day

PR opened Mic92/sops-nix

fix /etc/secrets.d permissions
+8 -4

0 comment

2 changed files

pr created time in a day

create barnchMic92/sops-nix

branch : permission-fixes

created branch time in a day

push eventNixOS/nixpkgs

Arnout Engelen

commit sha 58ecf0bfd508107d6141ee9ddea19d27ec3bb1fd

mastodon-bot: init at 1.0.2

view details

Jörg Thalheim

commit sha 1facbd61b179670e6ce6945957c83bf345ddb1b4

Merge pull request #92830 from raboof/nixpkgs-mastodon-bot-init-at-1.0.2

view details

push time in a day

PR merged NixOS/nixpkgs

Reviewers
mastodon-bot: init at 1.0.2 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 8.has: package (new) awaiting_reviewer marvin
Motivation for this change
Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

  • [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x] NixOS
    • [ ] macOS
    • [ ] other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ ] Tested execution of all binary files (usually in ./result/bin/)
  • [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ ] Ensured that relevant documentation is up to date
  • [ ] Fits CONTRIBUTING.md.
+1229 -621

4 comments

3 changed files

raboof

pr closed time in a day

pull request commentNixOS/nixpkgs

mastodon-bot: init at 1.0.2

Result of nixpkgs-review pr 92830 1 <details> <summary>1 package blacklisted:</summary> <br>- tests.nixos-functions.nixos-test </details> <details> <summary>32 packages built:</summary> <br>- antora <br>- bitwarden-cli <br>- create-cycle-app <br>- etcher <br>- gtop <br>- joplin <br>- lumo <br>- mastodon-bot <br>- parity-ui <br>- postcss-cli <br>- pscid <br>- pulp <br>- python37Packages.jupyterhub <br>- python37Packages.jupyterhub-ldapauthenticator <br>- python37Packages.oauthenticator <br>- python38Packages.jupyterhub <br>- python38Packages.jupyterhub-ldapauthenticator <br>- python38Packages.oauthenticator <br>- rambox-pro <br>- slack <br>- sloc <br>- teleprompter <br>- thelounge <br>- triton <br>- vimPlugins.coc-emmet <br>- vimPlugins.coc-git <br>- vimPlugins.coc-metals <br>- vimPlugins.coc-prettier <br>- vimPlugins.coc-rust-analyzer <br>- vimPlugins.coc-stylelint <br>- vimPlugins.coc-vetur <br>- wasm-text-gen </details>

raboof

comment created time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha 36ad7672c9d4dc92286be166dd69c4a0df5dd60a

add nixus

view details

push time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha 348dda0afebf71199e8bb8d7ec6b6fe7f959a8e9

buildkite stages

view details

push time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha b7b4f1f4d620daae4b9246a8b9c1c56b4d36f464

add test badge

view details

push time in a day

delete branch Mic92/sops-nix

delete branch : sops-pgp-hook

delete time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha fe7f6360e806efd470cd6d9a9d930a1c37c36572

add integration test for sops-pgp-hook

view details

Jörg Thalheim

commit sha 9b3c57d534837b75113c22dc45b843f73899741a

Merge pull request #5 from Mic92/sops-pgp-hook add integration test for sops-pgp-hook

view details

push time in a day

PR merged Mic92/sops-nix

add integration test for sops-pgp-hook
+87 -8

0 comment

10 changed files

Mic92

pr closed time in a day

push eventMic92/sops-nix

Jörg Thalheim

commit sha fe7f6360e806efd470cd6d9a9d930a1c37c36572

add integration test for sops-pgp-hook

view details

push time in a day

PR opened Mic92/sops-nix

add integration test for sops-pgp-hook
+87 -8

0 comment

10 changed files

pr created time in a day

create barnchMic92/sops-nix

branch : sops-pgp-hook

created branch time in a day

Pull request review commentNixOS/nixpkgs

lvm: cleanups

-{ stdenv, fetchgit, fetchpatch, pkgconfig, systemd, udev, utillinux, libuuid+{ stdenv+, fetchpatch+, fetchurl+, pkgconfig+, utillinux+, libuuid , thin-provisioning-tools, libaio-, enable_dmeventd ? false }:+, enable_cmdlib ? false+, enable_dmeventd ? false

camelCase seems to be the way to go for enable options:

, enableCmdlib ? false
, enableDmeventd ? false
flokli

comment created time in a day

Pull request review commentNixOS/nixpkgs

lvm: cleanups

 stdenv.mkDerivation rec {     sed -i /DEFAULT_PROFILE_DIR/d conf/Makefile.in     substituteInPlace scripts/lvm2_activation_generator_systemd_red_hat.c \       --replace /usr/bin/udevadm /run/current-system/systemd/bin/udevadm+    # https://github.com/lvmteam/lvm2/issues/36+    substituteInPlace udev/69-dm-lvm-metad.rules.in \+      --replace "(BINDIR)/systemd-run" /run/current-system/systemd/bin/systemd-run

Is there no $ before (BINDIR)?

flokli

comment created time in a day

Pull request review commentNixOS/nixpkgs

lvm: cleanups

 in {           + " mkpart primary 2048M -1s"  # PV2           + " set 2 lvm on",           "udevadm settle",+          "sleep 1",

Maybe add a comment why the sleep is necessary here.

flokli

comment created time in a day

Pull request review commentNixOS/nixpkgs

lvm: cleanups

 { config, lib, pkgs, ... }:  with lib;+let+  cfg = config.services.lvm;+in {+  options.services.lvm = {+    package = mkOption {+      type = types.package;+      default = if cfg.dmeventd.enable then pkgs.lvm2_dmeventd else pkgs.lvm2;+      internal = true;+      defaultText = "pkgs.lvm2";+      description = ''+        This option allows you to override the LVM package that's used on the system+        (udev rules, tmpfiles, systemd services).+        Defaults to pkgs.lvm2, or pkgs.lvm2_dmeventd if dmeventd is enabled.+      '';+    };+    dmeventd.enable = mkEnableOption "the LVM dmevent daemon";+    boot.thin.enable = mkEnableOption "support for booting from ThinLVs";+  }; -{--  ###### implementation+  config = mkMerge [+    (mkIf (!config.boot.isContainer) {+      environment.etc."tmpfiles.d/lvm2.conf".source = "${cfg.package}/lib/tmpfiles.d/lvm2.conf";+      environment.systemPackages = [ cfg.package ];+      systemd.packages = [ cfg.package ]; -  config = mkIf (!config.boot.isContainer) {+      # TODO: update once https://github.com/NixOS/nixpkgs/pull/93006 was merged+      services.udev.packages = [ cfg.package.out ];+    })+    (mkIf cfg.dmeventd.enable {+      systemd.sockets."dm-event".wantedBy = [ "sockets.target" ];+      systemd.services."lvm2-monitor".wantedBy = [ "sysinit.target" ]; -    environment.systemPackages = [ pkgs.lvm2 ];+      environment.etc."lvm/lvm.conf".text = ''+        dmeventd/executable = "${cfg.package}/bin/dmeventd"+      '';+    })+    (mkIf cfg.boot.thin.enable {+      boot.initrd = {+        kernelModules = [ "dm-snapshot" "dm-thin-pool" ]; -    services.udev.packages = [ pkgs.lvm2 ];+        extraUtilsCommands = ''+          copy_bin_and_libs ${pkgs.thin-provisioning-tools}/bin/pdata_tools+          copy_bin_and_libs ${pkgs.thin-provisioning-tools}/bin/thin_check+        '';+      }; -  };+      environment.etc."lvm/lvm.conf".text = ''+        global/thin_check_executable = "${pkgs.thin-provisioning-tools}/bin/thin_check"+      '';+    })+    (mkIf (cfg.dmeventd.enable || cfg.boot.thin.enable) {+      boot.initrd.preLVMCommands = ''+          mkdir -p /etc/lvm+          cat << EOF >> /etc/lvm/lvm.conf+          ${optionalString cfg.thin.enable ''+            global/thin_check_executable = "$(which thin_check)"+          ''}+          ${optionalString cfg.dmeventd.enable ''+            dmeventd/executable = "$(which false)"
            dmeventd/executable = "$(command -v false)"
flokli

comment created time in a day

Pull request review commentNixOS/nixpkgs

lvm: cleanups

 { config, lib, pkgs, ... }:  with lib;+let+  cfg = config.services.lvm;+in {+  options.services.lvm = {+    package = mkOption {+      type = types.package;+      default = if cfg.dmeventd.enable then pkgs.lvm2_dmeventd else pkgs.lvm2;+      internal = true;+      defaultText = "pkgs.lvm2";+      description = ''+        This option allows you to override the LVM package that's used on the system+        (udev rules, tmpfiles, systemd services).+        Defaults to pkgs.lvm2, or pkgs.lvm2_dmeventd if dmeventd is enabled.+      '';+    };+    dmeventd.enable = mkEnableOption "the LVM dmevent daemon";+    boot.thin.enable = mkEnableOption "support for booting from ThinLVs";+  }; -{--  ###### implementation+  config = mkMerge [+    (mkIf (!config.boot.isContainer) {+      environment.etc."tmpfiles.d/lvm2.conf".source = "${cfg.package}/lib/tmpfiles.d/lvm2.conf";+      environment.systemPackages = [ cfg.package ];+      systemd.packages = [ cfg.package ]; -  config = mkIf (!config.boot.isContainer) {+      # TODO: update once https://github.com/NixOS/nixpkgs/pull/93006 was merged+      services.udev.packages = [ cfg.package.out ];+    })+    (mkIf cfg.dmeventd.enable {+      systemd.sockets."dm-event".wantedBy = [ "sockets.target" ];+      systemd.services."lvm2-monitor".wantedBy = [ "sysinit.target" ]; -    environment.systemPackages = [ pkgs.lvm2 ];+      environment.etc."lvm/lvm.conf".text = ''+        dmeventd/executable = "${cfg.package}/bin/dmeventd"+      '';+    })+    (mkIf cfg.boot.thin.enable {+      boot.initrd = {+        kernelModules = [ "dm-snapshot" "dm-thin-pool" ]; -    services.udev.packages = [ pkgs.lvm2 ];+        extraUtilsCommands = ''+          copy_bin_and_libs ${pkgs.thin-provisioning-tools}/bin/pdata_tools+          copy_bin_and_libs ${pkgs.thin-provisioning-tools}/bin/thin_check+        '';+      }; -  };+      environment.etc."lvm/lvm.conf".text = ''+        global/thin_check_executable = "${pkgs.thin-provisioning-tools}/bin/thin_check"+      '';+    })+    (mkIf (cfg.dmeventd.enable || cfg.boot.thin.enable) {+      boot.initrd.preLVMCommands = ''+          mkdir -p /etc/lvm+          cat << EOF >> /etc/lvm/lvm.conf+          ${optionalString cfg.thin.enable ''+            global/thin_check_executable = "$(which thin_check)"
            global/thin_check_executable = "$(command -v thin_check)"
flokli

comment created time in a day

Pull request review commentnix-community/nix-environments

Add environment for JRuby

+# JRuby++Environment to build and run [JRuby](https://www.jruby.org/).

Fixed in 6329cf142f59e258c16a4647d7a53864221637f1

fzakaria

comment created time in 2 days

push eventnix-community/nix-environments

Jörg Thalheim

commit sha 1dc13b3cafc4fe5cce3169987afdfe8a649491bd

jruby: improve wording

view details

Jörg Thalheim

commit sha 6329cf142f59e258c16a4647d7a53864221637f1

reference jruby

view details

push time in 2 days

Pull request review commentnix-community/nix-environments

Add environment for JRuby

+# JRuby++Environment to build and run [JRuby](https://www.jruby.org/).

Build as in build from source?

fzakaria

comment created time in 2 days

push eventnix-community/nix-environments

Farid Zakaria

commit sha 0d2a6d82909062fe934dae4a07accde587ed2494

Added environment for JRuby

view details

Farid Zakaria

commit sha df6b2187e3572f44d2ab2d90805b7b71ea195434

Fix LOCAL_ARCHIVE export

view details

Jörg Thalheim

commit sha e7ffbd72900080f05bddb2c99d5712714c599519

Merge pull request #4 from fzakaria/jruby

view details

push time in 2 days

PR merged nix-community/nix-environments

Add environment for JRuby

JRuby unlike ruby in nixpkgs does not apply a patch to change the default gem installation directory. As a result whomever uses it must specify GEM_HOME.

I consider that gotcha enough to warrant having it in this repo as non-trivial.

+29 -0

1 comment

2 changed files

fzakaria

pr closed time in 2 days

push eventMic92/dotfiles

Jörg Thalheim

commit sha ef4b05cabc46f2b2f0bdbcaf075d8022b0f67b50

uncomment eddie

view details

push time in 2 days

more