Thanks!

…zones (typo)

Yeah. Maybe I should add this as well, we usually prefer to merge rustc updates to staging.

Other usual suspects in rust land: cc @symphorien @jD91mZM2 @zimbatm

fd is just a simple rust example that should build on all platforms.

@GrahamcOfBorg usually can build this in time. For aarch64 we have a beefy community builder: https://github.com/nix-community/aarch64-build-box which I have access to and usually try to build upgrades. For macOS alternatively I have a bunch of nixpkgs maintainer that I can ping instead. We followed this pattern for a while until you started merging rust upgrades without testing.

Yes. Because this is a channel blocker. A way to fix it in that case is to to pin rust to an older version for firefox. However breaking firefox in unstable is undesired.

cc @andir @edolstra

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [ ] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [ ] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [ ] Fits CONTRIBUTING.md.

Notify maintainers

cc @

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

By using the provided tbz file instead of the auto-generated GitHub tarball, we ensure that strings like %%VERSION%% have been properly generated.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [x] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [x] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [x] Fits CONTRIBUTING.md.

It's a good idea to expand this in future to test code as well, so we get type checking there as well.

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [x] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [x] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [x] Fits CONTRIBUTING.md.

Notify maintainers

cc @

@GrahamcOfBorg test borgbackup

Add support for MacBook Air 3,X, which only contains a NVIDIA GeForce 320M GPU instead of integrated Intel graphics. The configuration contains the black screen fix for this model.

Ah, just read about the NVIDIA GeForce 320M GPU

Why not using ../../../common/cpu/intel here?

This could be even switched to the new nix run:

<screen>nix run nixpkgs.nix-review -c nix-review rev HEAD</screen>

This avoids pulling some dependencies/environment variables that nix-shell would do

We usually use date of commit here instead of git.

    systems (e.g. zlib, openssl), I seem to be having better luck with the

@ebkalderon you can open also a new pr that fixes https://github.com/NixOS/nixpkgs/pull/67916#discussion_r319838459

The following points apply when adding a new repository to repos.json

• [X] I ran ./bin/nur format-manifest after updating repos.json (We will use the same script in travis ci to make sure we keep the format consistent)
• [X] By including this repository in NUR I give permission to license the content under the MIT license.

Clarification where license should apply: The license above does not apply to the packages built by the Nix Packages collection, merely to the package descriptions (i.e., Nix expressions, build scripts, etc.). It also might not apply to patches included in Nixpkgs, which may be derivative works of the packages to which they apply. The aforementioned artifacts are all covered by the licenses of the respective packages.

we previously immediately returned the first commands output, and didn't execute any of the other commands.

Now, return the last commands output. This should be documented in the method docstring.

cc @Mic92 #73033

Motivation for this change

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [ ] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [ ] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [ ] Fits CONTRIBUTING.md.

Notify maintainers

cc @tfc @marijanp

@marijanp fixed

Because third-party library are imported that do not have type annotations.

Because third-party libraries are imported that do not have type annotations.

The following points apply when adding a new repository to repos.json

• [x] I ran nur/format-manifest.py after updating repos.json (We will use the same script in travis ci to make sure we keep the format consistent)
• [x] By including this repository in NUR I give permission to license the content under the MIT license.

This might need a prefix for cross compiling:

export AR="${stdenv.hostPlatform.config}-gcc-ar"

Does this also break on current master?

The nixpkgs manual seems to prefer attrset and we are not using the argument anyway.

I noticed this due to a recent breakage: https://github.com/NixOS/nixpkgs/pull/72376#discussion_r341883853

fixed in: https://github.com/Mic92/nix-review/pull/74

It's not necessary to use a function since we don't use the pkgs attribute. The config can just be an attribute set.

Related to https://github.com/NixOS/nixpkgs/pull/72376#discussion_r341883853

Is it not possible to compile it from source?

Than I only would add 2.4 and the latest.

@curiousleo you can just point the NIX_PATH to $src. No need to have these nix files locally.

@GrahamcOfBorg build rustc

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

The returning of None results in an unexpressive "'NoneType' object is not subscriptable" exception in wait_for_unit and require_unit_state when accessing the info dictionary.

Things done

Code conforms the Black coding style. Changed the simple.nix test and ran it to provocate a failure and check if the Exception is thrown.

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [x] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [ ] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [x] Fits CONTRIBUTING.md.

Notify maintainers

cc @tfc @worldofpeace

I agree with this. The current handling of this is buggy.

cc @worldofpeace @flokli @marijanp

Tested running borgbackup.nix

It's a good idea to expand this in future to test code as well, so we get type checking there as well.

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [ ] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [ ] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [ ] Fits CONTRIBUTING.md.

Notify maintainers

cc @

This should fix evaluation on macOS:

It is not required on Linux as far as I can see?

@GrahamcOfBorg build signal-cli

Sorry. I feel sick today. Could someone else take over the meeting? Cheers.

This fixes a crash when receiving files via OMEMO.

Motivation for this change

Fixing a crash when receiving OMEMO encrypted files.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [X] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [X] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [X] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [ ] Fits CONTRIBUTING.md.

Notify maintainers

cc @Mic92

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jgmenu/versions.

meta.description for jgmenu is: '"Small X11 menu intended to be used with openbox and tint2"'.

meta.homepage for jgmenu is: '"https://github.com/johanmalm/jgmenu"

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 3.5 with grep in /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5

• directory tree listing: https://gist.github.com/265703ed1ca711a3a1e77955742daf89

• du listing: https://gist.github.com/f7eebc8c33837d0e59000dc8e0923f63

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 0 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath jgmenu

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jgmenu https://github.com/r-ryantm/nixpkgs/archive/ec4774d316bbdabf69dc41e21d6875bfbc2a3c7c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5
ls -la /nix/store/ry3lmq5hmz4q205gkbklvx9q4sq8iwd8-jgmenu-3.5/bin

</details> <br/>

cc @romildo for testing.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jruby/versions.

meta.description for jruby is: '"Ruby interpreter written in Java"'.

meta.homepage for jruby is: '"http://jruby.org/"

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 9.2.9.0 with grep in /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0

• directory tree listing: https://gist.github.com/6805850354c9e19ebd62e066a87114ca

• du listing: https://gist.github.com/987234bbff11db3c89ac7ffdbc05d630

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath jruby

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jruby https://github.com/r-ryantm/nixpkgs/archive/901f445cbe0ccfed9734353391989ed6621a2a96.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0
ls -la /nix/store/lw6y1azpf6j5srr68gjzwbpc5acs9djh-jruby-9.2.9.0/bin

</details> <br/>

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/hyperscan/versions.

meta.description for hyperscan is: '"High-performance multiple regex matching library"'.

meta.homepage for hyperscan is: '"https://www.hyperscan.io/"

Release on GitHub

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 5.2.1 with grep in /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1

• directory tree listing: https://gist.github.com/6c919aecce1d41c01699290ef169585f

• du listing: https://gist.github.com/bb37e9b6dce7b6b9dc519f2aeb8311af

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 0 x86_64-darwin rebuild(s) 0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath hyperscan rspamd suricata

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A hyperscan https://github.com/r-ryantm/nixpkgs/archive/eaa967989747716e0016ebcb5924e129a4a31a17.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1
ls -la /nix/store/z2nvcbpbcgk1xxvksyakl31avg0sxzix-hyperscan-5.2.1/bin

</details> <br/>

cc @avnik for testing.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jsonrpc-glib/versions.

meta.description for jsonrpc-glib is: '"A library to communicate using the JSON-RPC 2.0 specification"'.

meta.homepage for jsonrpc-glib is: '"https://gitlab.gnome.org/GNOME/jsonrpc-glib"

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 3.34.0 with grep in /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0

• directory tree listing: https://gist.github.com/6a4a91327b4ae66d8cbfef6ef284fd9b

• du listing: https://gist.github.com/aa11d0ca1d9c9e56fd39597cb9fbac22

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

7 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s) 2 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath gnome-builder jsonrpc-glib

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jsonrpc-glib https://github.com/r-ryantm/nixpkgs/archive/69390743f0625b44e18aa8f9e41ab5da11207d5c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0
ls -la /nix/store/fqzxzalbm93ll2183b47v5gzwqkcn902-jsonrpc-glib-3.34.0/bin

</details> <br/>

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jmol/versions.

meta.description for jmol is: '"A Java 3D viewer for chemical structures"'.

meta.homepage for jmol is: '"https://sourceforge.net/projects/jmol"

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 14.29.55 with grep in /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55

• directory tree listing: https://gist.github.com/7142220b28a433589c36507bc13d1c46

• du listing: https://gist.github.com/71d06f28e64c4f76e94ff4579bf9823c

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath jmol

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A jmol https://github.com/r-ryantm/nixpkgs/archive/b3799c562794aafe5564b4463fa7acebdbaf3e9c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55
ls -la /nix/store/a41qclklj88na75dlg8b610ylvzfh9lh-jmol-14.29.55/bin

</details> <br/>

cc @timokau @mounium for testing.

cc @yorickvP

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gpodder/versions.

meta.description for gpodder is: '"A podcatcher written in python"'.

meta.homepage for gpodder is: '"http://gpodder.org/"

Release on GitHub

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 3.10.11 with grep in /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11

• directory tree listing: https://gist.github.com/fb6963968cecc4ab12055864efd6a2de

• du listing: https://gist.github.com/bb23fbc3014ca6c05309d2e809a9722a

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath gpodder

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A gpodder https://github.com/r-ryantm/nixpkgs/archive/3d13a8a42ce1ed09cd6c527ec2168e2ed8a96ac2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11
ls -la /nix/store/2cq65gsqz76j0a734zvc2mb5flyvixd7-gpodder-3.10.11/bin

</details> <br/>

cc @svenkeidel @mic92 for testing.

espefuse.py tries to import our wrapped esptool, which fails due being wrapped.

$ espefuse.py
Traceback (most recent call last):
  File "/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin/.espefuse.py-wrapped", line 22, in <module>
    import esptool
  File "/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin/esptool.py", line 2
    export PATH='/nix/store/zdh16dcvjw99ybam59zd2ijb6bx138j0-python3-3.7.5/bin:/nix/store/5y2fc4ii19wpmykibcadlfzavdhnz71y-esptool-2.8/bin:/nix/store/2w9f7hqjnkv6xw63p3jvjr5z6m12d0w5-python3.7-pyserial-3.4/bin'${PATH:+':'}$PATH
              ^
SyntaxError: invalid syntax

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/di/versions.

meta.description for di is: '"Disk information utility; displays everything 'df' does and more"'.

meta.homepage for di is: '"https://gentoo.com/di/"

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 4.47.2 with grep in /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2

• directory tree listing: https://gist.github.com/3a8343a35b778bbb9729cf2712937fe8

• du listing: https://gist.github.com/988e0247e083f93438260316c941d685

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath di

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A di https://github.com/r-ryantm/nixpkgs/archive/177eeccaac4e3e52e356d5dbf1ed4bc0b6eb2cde.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2
ls -la /nix/store/jzgkxm7rqvf00nr0v31ni2417d747fig-di-4.47.2/bin

</details> <br/>

cc @manveru @ndowens for testing.

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Friendly device names on ec2 instances. This is the most "upstream" version I could find.

Note to reviewer: this package includes a handful of udev rules:

result/etc/udev/rules.d
├── 51-ec2-hvm-devices.rules
├── 52-ec2-vcpu.rules
├── 60-cdrom_id.rules
└── 70-ec2-nvme-devices.rules

I primarily want 70-ec2-nvme-devices.rules, but haven't thought carefully about the consequences of including the rest.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • [x] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [ ] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [x] Fits CONTRIBUTING.md.

Scripts looks legit. Have you tested this?

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ccls/versions.

meta.description for ccls is: '"A c/c++ language server powered by clang"'.

meta.homepage for ccls is: '"https://github.com/MaskRay/ccls"

Release on GitHub

Compare changes on GitHub

<details> <summary> Checks done (click to expand) </summary>

• built on NixOS

• The tests defined in passthru.tests, if any, passed

• 0 of 0 passed binary check by having a zero exit code.

• 0 of 0 passed binary check by having the new version present in output.

• found 0.20190823.4 with grep in /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4

• directory tree listing: https://gist.github.com/9cb0e27461564c70f4383469f4f6a2dc

• du listing: https://gist.github.com/b84f0207bacc49495bc2a8f63909004d

</details> <details> <summary> Rebuild report (if merged into master) (click to expand) </summary>

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s) 1 i686-linux rebuild(s) 1 x86_64-darwin rebuild(s) 1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath ccls

</details>

<details> <summary> Instructions to test this update (click to expand) </summary>

Either download from Cachix:

nix-store -r /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A ccls https://github.com/r-ryantm/nixpkgs/archive/22103e4f39b9274f36905a99c2132144e31dd3b0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4
ls -la /nix/store/cbklxsvvgxd8hcg5r87s378l79malr70-ccls-0.20190823.4/bin

</details> <br/>

cc @mic92 @tobim for testing.

Could you make this a separate commit?

When importing wifi passwords it might happen that filenames start with dash due to escaping. This is interpreted by pass's flag parsing.

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

It should exclude sub-modules like llvm, but the name list for rm is outdated.

Closure size: 550 MiB -> 24.6 MiB

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • [x] NixOS
  • [ ] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [x] Tested execution of all binary files (usually in ./result/bin/)
  • It's just source.
• [x] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [ ] Fits CONTRIBUTING.md.

Notify maintainers

cc @

Motivation for this change

This PR adds a flag to buildRustPackage that can override the --target flag to cargo.

Things done

Added the flag, adjusted corresponding paths in the code.

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • [x] NixOS
  • [ ] macOS
  • [x] other Linux distributions (Arch Linux)
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [ ] Tested execution of all binary files (usually in ./result/bin/)
• [ ] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [x] Fits CONTRIBUTING.md.

Notify maintainers

cc @andir @Mic92

<!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: https://github.com/NixOS/nixpkgs/pulls, for more about reviewing contributions: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#sec-reviewing-contributions. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! -->

Motivation for this change

Eternal Terminal has had new releases, also the repository name was changed.

Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

• [x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • [x] NixOS
  • [x] macOS
  • [ ] other Linux distributions
• [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• [x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• [x] Tested execution of all binary files (usually in ./result/bin/)
• [x] Determined the impact on package closure size (by running nix path-info -S before and after)
• [ ] Ensured that relevant documentation is up to date
• [x] Fits CONTRIBUTING.md.

Notify maintainers

cc @dezgeg