MeiKatz ( Gregor Mitzka )

@woollsta You're right, but the approach I realised in my referenced PR makes it a lot easier. Currently the problem is, that @mjackson and @ryanflorence are busy doing other stuff and therefore RRv6 makes no progress at all. Hopefully this will change in the near future. Would be a pity if not.

MeiKatz

comment created time in 10 days

pull request commentReactTraining/react-router

Add a 'useQueryString' hook

Currently each call to useQueryString returns a new object. You could memoize them with useMemo.

chenwenqin

comment created time in 10 days

startedjesuisundev/acrosstheuniverse

started time in 13 days

issue commentReactTraining/react-router

Comments on the v6 preload API

@phaux Yeah, I like this. But it should also pass the route params as argument of the callback function.

chrisvasz

comment created time in 16 days

startedCollusion/pickmybrain

started time in 16 days

startedwheelybird/ldap-user-manager

started time in 19 days

starteddiegomura/react-pdf

started time in 23 days

Pull request review commentReactTraining/react-router

Add `location` prop to useRoutes() for e.g. animated transitions between routes

 function useRoutes_(    basename = basename ? joinPaths([parentPathname, basename]) : parentPathname; -  let location = useLocation() as Location;-  let matches = React.useMemo(() => matchRoutes(routes, location, basename), [+  let currentLocation = useLocation() as Location;+  let usedLocation = location || currentLocation;++  let matches = React.useMemo(() => matchRoutes(routes, usedLocation, basename), [     location,

Thank you. I think I had this in but after all the edits I may have lost it.

MeiKatz

comment created time in a month

PullRequestReviewEvent

issue commentReactTraining/react-router

Release date/rough time estimate before React Router 6 will be released

Good question. I also want to know this. But @mjackson and @ryanflorence are kind of silent in the last weeks and months.

DeadManPoe

comment created time in a month

startedbaowenbo/DAIN

started time in a month

issue commentReactTraining/react-router

V6: Optional parameters

@robbinjanssen Understandable. But I don't think that there is any other way you can solve it. And I also think, that it is a clean way to do it. Also we could think about dropping the whole context stuff and pass the parameters to the <Outlet /> and from there to the element.

clarkd

comment created time in a month

issue commentReactTraining/react-router

V6: Optional parameters

@robbinjanssen Have you thought about using the <Outlet /> element?

<Route path="tickets" element={ <TicketsPage /> }>
  <Route path=":ticketId" element={ <ShowPage /> } />
  <Route path="" element={ <IndexPage /> } />
</Route>

const TicketContext = React.createContext( {} );

function TicketsPage() {
  const [ tickets, setTickets ] = useState({});

  useEffect(() => {
    // do some loading stuff
    const res = await fetch("/tickets");
    const tickets = await res.json();

    setTickets( tickets );
  }, []);

  return (
    <TicketContext.Provider value={ tickets }>
      <h1>My Tickets</h1>
      <Outlet />
    </TicketContext.Provider>
  );
}

function ShowPage() {
  const tickets = useContext( TicketContext );
  const { ticketId } = useParams();

  const ticket = tickets[ ticketId ];

  return (
    <div>{ JSON.stringify( ticket ) }</div>
  );
}

clarkd

comment created time in a month

issue commentReactTraining/react-router

History objects do not match

First: the @types lib is non of us, therefore we don't have our hands on it.

Second: yes, there should be a back method, but I am also not sure about this bug.

nolawnchairs

comment created time in a month

startedaatishb/maskmath

started time in a month

startedpa7/nude.js

started time in a month