profile
viewpoint

LINKIWI/modern-paste 236

A modern, feature-rich Pastebin alternative

LINKIWI/cloudflare-ddns-client 193

Linux client for automatic dynamic DNS updates on CloudFlare-managed domains

LINKIWI/react-elemental 151

Modern, flat React UI component library

LINKIWI/orion-web 130

Robust web visualization tool for OwnTracks location data

LINKIWI/endpoint 110

Super simple mock API endpoints for static JSON data

LINKIWI/orion-server 87

Database-backed storage solution for OwnTracks location data

LINKIWI/dotproxy 43

High-performance DNS-over-TLS proxy

LINKIWI/orion-docker 17

Dockerized deployment of the Orion platform

LINKIWI/repliqate 11

Daemon providing SQL -> Kafka replication for append-only workloads

push eventLINKIWI/webgrep

Kevin Lin

commit sha ded1603fafb284b8ad5168e7d8107912fddb56eb

More descriptive FileEntry handler names

view details

Kevin Lin

commit sha 068118ff6bb07aebf10f9cdb20de08c8b29c551f

Simplify higher order handler functions in CodeSnippetContainer

view details

Kevin Lin

commit sha 6cc24ee668e27c827ced0085f60afbd885ae149b

IconButton UI component

view details

Kevin Lin

commit sha f098bb2ee3865604350ff37a3400a485037acab5

Add rich interaction panel to source preview

view details

push time in 19 hours

push eventLINKIWI/webgrep

Kevin Lin

commit sha aecdcac0b7d4d32d5fcc811e6c9f28732e154442

Bump dependencies

view details

Kevin Lin

commit sha b915c8f568b77bd021a062c3fea968b0d5e04a35

Shared Tooltip abstraction

view details

Kevin Lin

commit sha dcbc029e68d97338af7dbd182e1476edb0e7020b

FloatingButton style and transition tweaks

view details

push time in a day

PR opened facebook/mcrouter

Fix OSS build: -lrpcmetadata to accommodate fbthrift change

fbthrift commit https://github.com/facebook/fbthrift/commit/0d079b3ca4943f86268a81a1a8b50e757b37e495 broke mcrouter OSS compilation by introducing a new rpcmetadata library target, which causes mcrouter build to fail e.g. https://travis-ci.org/github/facebook/mcrouter/jobs/713583896

<details> <summary>mcrouter build error symptom</summary>

```
/bin/bash ./libtool  --tag=CXX   --mode=link g++  -DLIBMC_FBTRACE_DISABLE -DDISABLE_COMPRESSION  -Wno-missing-field-initializers -Wno-deprecated -W -Wall -Wextra -Wno-unused-parameter -fno-strict-aliasing -g -O2  -L/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib -ljemalloc  -o mcrouter mcrouter-main.o mcrouter-StandaloneConfig.o mcrouter-StandaloneUtils.o libmcroutercore.a lib/libmcrouter.a -lthriftcpp2 -ltransport -lthriftprotocol -lasync -lconcurrency -lprotocol -lthrift-core -lfmt -lwangle -lfolly -lfizz -lsodium -lfolly -ldl -ldouble-conversion -lz -lssl -lcrypto -levent -lgflags -lglog  -L/usr/lib/x86_64-linux-gnu -lboost_context -lboost_filesystem       -lboost_program_options -lboost_system -lboost_regex       -lboost_thread -lpthread -pthread -ldl -lunwind       -lbz2 -llz4 -llzma -lsnappy -lzstd

libtool: link: g++ -DLIBMC_FBTRACE_DISABLE -DDISABLE_COMPRESSION -Wno-missing-field-initializers -Wno-deprecated -W -Wall -Wextra -Wno-unused-parameter -fno-strict-aliasing -g -O2 -o mcrouter mcrouter-main.o mcrouter-StandaloneConfig.o mcrouter-StandaloneUtils.o -pthread  -L/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib -ljemalloc libmcroutercore.a lib/libmcrouter.a -lthriftcpp2 -ltransport -lthriftprotocol -lasync -lconcurrency -lprotocol -lthrift-core -lfmt -lwangle -lfizz -lsodium -lfolly -ldouble-conversion -lz -lssl -lcrypto -levent -lgflags -lglog -L/usr/lib/x86_64-linux-gnu -lboost_context -lboost_filesystem -lboost_program_options -lboost_system -lboost_regex -lboost_thread -lpthread -ldl -lunwind -lbz2 -llz4 -llzma -lsnappy -lzstd -pthread

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::(anonymous namespace)::decodeResponseError(apache::thrift::rocket::RocketException&&, unsigned short, folly::Range<char const*>)':

RocketClientChannel.cpp:(.text+0x5fd): undefined reference to `apache::thrift::ResponseRpcError::ResponseRpcError()'

RocketClientChannel.cpp:(.text+0x8db): undefined reference to `apache::thrift::ResponseRpcMetadata::ResponseRpcMetadata()'

RocketClientChannel.cpp:(.text+0xe8a): undefined reference to `apache::thrift::ResponseRpcMetadata::~ResponseRpcMetadata()'

RocketClientChannel.cpp:(.text+0xe99): undefined reference to `apache::thrift::ResponseRpcMetadata::~ResponseRpcMetadata()'

RocketClientChannel.cpp:(.text+0xeb7): undefined reference to `apache::thrift::ResponseRpcError::~ResponseRpcError()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::RocketClientChannel::makeSetupFrame(apache::thrift::RequestSetupMetadata)':

RocketClientChannel.cpp:(.text+0x3abb): undefined reference to `unsigned int apache::thrift::RequestSetupMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

RocketClientChannel.cpp:(.text+0x3ad4): undefined reference to `unsigned int apache::thrift::RequestSetupMetadata::serializedSize<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter const*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::RocketClientChannel::sendRequestStream(apache::thrift::RpcOptions const&, folly::Range<char const*>, apache::thrift::SerializedRequest&&, std::shared_ptr<apache::thrift::transport::THeader>, apache::thrift::StreamClientCallback*)':

RocketClientChannel.cpp:(.text+0x4bd0): undefined reference to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()'

RocketClientChannel.cpp:(.text+0x4c3f): undefined reference to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::RocketClientChannel::sendRequestSink(apache::thrift::RpcOptions const&, folly::Range<char const*>, apache::thrift::SerializedRequest&&, std::shared_ptr<apache::thrift::transport::THeader>, apache::thrift::SinkClientCallback*)':

RocketClientChannel.cpp:(.text+0x4f4f): undefined reference to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()'

RocketClientChannel.cpp:(.text+0x4fd9): undefined reference to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::RocketClientChannel::sendThriftRequest(apache::thrift::RpcOptions const&, apache::thrift::RpcKind, folly::Range<char const*>, apache::thrift::SerializedRequest&&, std::shared_ptr<apache::thrift::transport::THeader>, std::unique_ptr<apache::thrift::RequestClientCallback, apache::thrift::RequestClientCallback::RequestClientCallbackDeleter>)':

RocketClientChannel.cpp:(.text+0x539a): undefined reference to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o):RocketClientChannel.cpp:(.text+0x5452): more undefined references to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()' follow

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::CodecConfig::~CodecConfig()':

RocketClientChannel.cpp:(.text._ZN6apache6thrift11CodecConfigD2Ev[_ZN6apache6thrift11CodecConfigD5Ev]+0x14): undefined reference to `apache::thrift::CodecConfig::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::CodecConfig::set_zlibConfig(apache::thrift::ZlibCompressionCodecConfig const&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift11CodecConfig14set_zlibConfigERKNS0_26ZlibCompressionCodecConfigE[_ZN6apache6thrift11CodecConfig14set_zlibConfigERKNS0_26ZlibCompressionCodecConfigE]+0x18): undefined reference to `apache::thrift::CodecConfig::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::CodecConfig::set_zstdConfig(apache::thrift::ZstdCompressionCodecConfig const&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift11CodecConfig14set_zstdConfigERKNS0_26ZstdCompressionCodecConfigE[_ZN6apache6thrift11CodecConfig14set_zstdConfigERKNS0_26ZstdCompressionCodecConfigE]+0x18): undefined reference to `apache::thrift::CodecConfig::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadExceptionMetadata::PayloadExceptionMetadata(apache::thrift::PayloadExceptionMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift24PayloadExceptionMetadataC2EOS1_[_ZN6apache6thrift24PayloadExceptionMetadataC5EOS1_]+0x15a): undefined reference to `apache::thrift::PayloadExceptionMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadExceptionMetadata::set_declaredException(apache::thrift::PayloadDeclaredExceptionMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift24PayloadExceptionMetadata21set_declaredExceptionEONS0_32PayloadDeclaredExceptionMetadataE[_ZN6apache6thrift24PayloadExceptionMetadata21set_declaredExceptionEONS0_32PayloadDeclaredExceptionMetadataE]+0x18): undefined reference to `apache::thrift::PayloadExceptionMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadExceptionMetadata::set_proxyException(apache::thrift::PayloadProxyExceptionMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift24PayloadExceptionMetadata18set_proxyExceptionEONS0_29PayloadProxyExceptionMetadataE[_ZN6apache6thrift24PayloadExceptionMetadata18set_proxyExceptionEONS0_29PayloadProxyExceptionMetadataE]+0x18): undefined reference to `apache::thrift::PayloadExceptionMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadExceptionMetadata::set_proxiedException(apache::thrift::PayloadProxiedExceptionMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift24PayloadExceptionMetadata20set_proxiedExceptionEONS0_31PayloadProxiedExceptionMetadataE[_ZN6apache6thrift24PayloadExceptionMetadata20set_proxiedExceptionEONS0_31PayloadProxiedExceptionMetadataE]+0x18): undefined reference to `apache::thrift::PayloadExceptionMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadExceptionMetadata::set_appClientException(apache::thrift::PayloadAppClientExceptionMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift24PayloadExceptionMetadata22set_appClientExceptionEONS0_33PayloadAppClientExceptionMetadataE[_ZN6apache6thrift24PayloadExceptionMetadata22set_appClientExceptionEONS0_33PayloadAppClientExceptionMetadataE]+0x18): undefined reference to `apache::thrift::PayloadExceptionMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o):RocketClientChannel.cpp:(.text._ZN6apache6thrift24PayloadExceptionMetadata22set_appServerExceptionEONS0_33PayloadAppServerExceptionMetadataE[_ZN6apache6thrift24PayloadExceptionMetadata22set_appServerExceptionEONS0_33PayloadAppServerExceptionMetadataE]+0x18): more undefined references to `apache::thrift::PayloadExceptionMetadata::__clear()' follow

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadMetadata::PayloadMetadata(apache::thrift::PayloadMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift15PayloadMetadataC2EOS1_[_ZN6apache6thrift15PayloadMetadataC5EOS1_]+0xc8): undefined reference to `apache::thrift::PayloadMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadMetadata::set_responseMetadata(apache::thrift::PayloadResponseMetadata&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift15PayloadMetadata20set_responseMetadataEONS0_23PayloadResponseMetadataE[_ZN6apache6thrift15PayloadMetadata20set_responseMetadataEONS0_23PayloadResponseMetadataE]+0x18): undefined reference to `apache::thrift::PayloadMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::PayloadMetadata::set_exceptionMetadata(apache::thrift::PayloadExceptionMetadataBase&&)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift15PayloadMetadata21set_exceptionMetadataEONS0_28PayloadExceptionMetadataBaseE[_ZN6apache6thrift15PayloadMetadata21set_exceptionMetadataEONS0_28PayloadExceptionMetadataBaseE]+0x1d): undefined reference to `apache::thrift::PayloadMetadata::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::FirstResponsePayload::~FirstResponsePayload()':

RocketClientChannel.cpp:(.text._ZN6apache6thrift20FirstResponsePayloadD2Ev[_ZN6apache6thrift20FirstResponsePayloadD5Ev]+0x18): undefined reference to `apache::thrift::ResponseRpcMetadata::~ResponseRpcMetadata()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `apache::thrift::rocket::unpack<apache::thrift::FirstResponsePayload>(apache::thrift::rocket::Payload&&)::{lambda()#1}::operator()() const':

RocketClientChannel.cpp:(.text._ZZN6apache6thrift6rocket6unpackINS0_20FirstResponsePayloadEEEN5folly3TryIT_EEONS1_7PayloadEENKUlvE_clEv[_ZZN6apache6thrift6rocket6unpackINS0_20FirstResponsePayloadEEEN5folly3TryIT_EEONS1_7PayloadEENKUlvE_clEv]+0x43): undefined reference to `apache::thrift::ResponseRpcMetadata::ResponseRpcMetadata()'

RocketClientChannel.cpp:(.text._ZZN6apache6thrift6rocket6unpackINS0_20FirstResponsePayloadEEEN5folly3TryIT_EEONS1_7PayloadEENKUlvE_clEv[_ZZN6apache6thrift6rocket6unpackINS0_20FirstResponsePayloadEEEN5folly3TryIT_EEONS1_7PayloadEENKUlvE_clEv]+0x72): undefined reference to `apache::thrift::ResponseRpcMetadata::~ResponseRpcMetadata()'

RocketClientChannel.cpp:(.text._ZZN6apache6thrift6rocket6unpackINS0_20FirstResponsePayloadEEEN5folly3TryIT_EEONS1_7PayloadEENKUlvE_clEv[_ZZN6apache6thrift6rocket6unpackINS0_20FirstResponsePayloadEEEN5folly3TryIT_EEONS1_7PayloadEENKUlvE_clEv]+0x434): undefined reference to `apache::thrift::ResponseRpcMetadata::~ResponseRpcMetadata()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `unsigned int apache::thrift::ResponseRpcError::read<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift16ResponseRpcError4readINS0_21CompactProtocolReaderEEEjPT_[_ZN6apache6thrift16ResponseRpcError4readINS0_21CompactProtocolReaderEEEjPT_]+0x2f): undefined reference to `void apache::thrift::ResponseRpcError::readNoXfer<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClientChannel.cpp.o): In function `unsigned int apache::thrift::ResponseRpcMetadata::read<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)':

RocketClientChannel.cpp:(.text._ZN6apache6thrift19ResponseRpcMetadata4readINS0_21CompactProtocolReaderEEEjPT_[_ZN6apache6thrift19ResponseRpcMetadata4readINS0_21CompactProtocolReaderEEEjPT_]+0x2f): undefined reference to `void apache::thrift::ResponseRpcMetadata::readNoXfer<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RpcMetadataUtil.cpp.o): In function `apache::thrift::detail::makeRequestRpcMetadata(apache::thrift::RpcOptions const&, apache::thrift::RpcKind, apache::thrift::ProtocolId, folly::Range<char const*>, std::chrono::duration<long, std::ratio<1l, 1000l> >, apache::thrift::transport::THeader&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&)':

RpcMetadataUtil.cpp:(.text+0x64): undefined reference to `apache::thrift::RequestRpcMetadata::RequestRpcMetadata()'

RpcMetadataUtil.cpp:(.text+0xbe6): undefined reference to `apache::thrift::RequestRpcMetadata::~RequestRpcMetadata()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RpcMetadataUtil.cpp.o): In function `apache::thrift::CodecConfig::operator=(apache::thrift::CodecConfig const&)':

RpcMetadataUtil.cpp:(.text._ZN6apache6thrift11CodecConfigaSERKS1_[_ZN6apache6thrift11CodecConfigaSERKS1_]+0x2b): undefined reference to `apache::thrift::CodecConfig::__clear()'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(PayloadUtils.cpp.o): In function `apache::thrift::rocket::Payload apache::thrift::rocket::detail::makePayload<apache::thrift::RequestRpcMetadata>(apache::thrift::RequestRpcMetadata const&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf> >)':

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_18RequestRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_18RequestRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x5b): undefined reference to `unsigned int apache::thrift::RequestRpcMetadata::serializedSizeZC<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter const*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_18RequestRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_18RequestRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x236): undefined reference to `unsigned int apache::thrift::RequestRpcMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_18RequestRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_18RequestRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x406): undefined reference to `unsigned int apache::thrift::RequestRpcMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(PayloadUtils.cpp.o): In function `apache::thrift::rocket::Payload apache::thrift::rocket::detail::makePayload<apache::thrift::ResponseRpcMetadata>(apache::thrift::ResponseRpcMetadata const&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf> >)':

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_19ResponseRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_19ResponseRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x5b): undefined reference to `unsigned int apache::thrift::ResponseRpcMetadata::serializedSizeZC<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter const*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_19ResponseRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_19ResponseRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x236): undefined reference to `unsigned int apache::thrift::ResponseRpcMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_19ResponseRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_19ResponseRpcMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x406): undefined reference to `unsigned int apache::thrift::ResponseRpcMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(PayloadUtils.cpp.o): In function `apache::thrift::rocket::Payload apache::thrift::rocket::detail::makePayload<apache::thrift::StreamPayloadMetadata>(apache::thrift::StreamPayloadMetadata const&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf> >)':

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_21StreamPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_21StreamPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x5b): undefined reference to `unsigned int apache::thrift::StreamPayloadMetadata::serializedSizeZC<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter const*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_21StreamPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_21StreamPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x236): undefined reference to `unsigned int apache::thrift::StreamPayloadMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_21StreamPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_21StreamPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x406): undefined reference to `unsigned int apache::thrift::StreamPayloadMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(PayloadUtils.cpp.o): In function `apache::thrift::rocket::Payload apache::thrift::rocket::detail::makePayload<apache::thrift::HeadersPayloadMetadata>(apache::thrift::HeadersPayloadMetadata const&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf> >)':

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_22HeadersPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_22HeadersPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x5b): undefined reference to `unsigned int apache::thrift::HeadersPayloadMetadata::serializedSizeZC<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter const*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_22HeadersPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_22HeadersPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x236): undefined reference to `unsigned int apache::thrift::HeadersPayloadMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

PayloadUtils.cpp:(.text._ZN6apache6thrift6rocket6detail11makePayloadINS0_22HeadersPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE[_ZN6apache6thrift6rocket6detail11makePayloadINS0_22HeadersPayloadMetadataEEENS1_7PayloadERKT_St10unique_ptrIN5folly5IOBufESt14default_deleteISB_EE]+0x406): undefined reference to `unsigned int apache::thrift::HeadersPayloadMetadata::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClient.cpp.o): In function `std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf> > apache::thrift::rocket::packCompact<apache::thrift::InteractionTerminate>(apache::thrift::InteractionTerminate&&)':

RocketClient.cpp:(.text._ZN6apache6thrift6rocket11packCompactINS0_20InteractionTerminateEEESt10unique_ptrIN5folly5IOBufESt14default_deleteIS6_EEOT_[_ZN6apache6thrift6rocket11packCompactINS0_20InteractionTerminateEEESt10unique_ptrIN5folly5IOBufESt14default_deleteIS6_EEOT_]+0x9b): undefined reference to `unsigned int apache::thrift::InteractionTerminate::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClient.cpp.o): In function `std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf> > apache::thrift::rocket::packCompact<apache::thrift::HeadersPayloadContent>(apache::thrift::HeadersPayloadContent&&)':

RocketClient.cpp:(.text._ZN6apache6thrift6rocket11packCompactINS0_21HeadersPayloadContentEEESt10unique_ptrIN5folly5IOBufESt14default_deleteIS6_EEOT_[_ZN6apache6thrift6rocket11packCompactINS0_21HeadersPayloadContentEEESt10unique_ptrIN5folly5IOBufESt14default_deleteIS6_EEOT_]+0x9b): undefined reference to `unsigned int apache::thrift::HeadersPayloadContent::write<apache::thrift::CompactProtocolWriter>(apache::thrift::CompactProtocolWriter*) const'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClient.cpp.o): In function `unsigned int apache::thrift::StreamPayloadMetadata::read<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)':

RocketClient.cpp:(.text._ZN6apache6thrift21StreamPayloadMetadata4readINS0_21CompactProtocolReaderEEEjPT_[_ZN6apache6thrift21StreamPayloadMetadata4readINS0_21CompactProtocolReaderEEEjPT_]+0x2f): undefined reference to `void apache::thrift::StreamPayloadMetadata::readNoXfer<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClient.cpp.o): In function `unsigned int apache::thrift::HeadersPayloadMetadata::read<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)':

RocketClient.cpp:(.text._ZN6apache6thrift22HeadersPayloadMetadata4readINS0_21CompactProtocolReaderEEEjPT_[_ZN6apache6thrift22HeadersPayloadMetadata4readINS0_21CompactProtocolReaderEEEjPT_]+0x2f): undefined reference to `void apache::thrift::HeadersPayloadMetadata::readNoXfer<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)'

/home/travis/build/facebook/mcrouter/mcrouter-install/install/lib/libthriftcpp2.a(RocketClient.cpp.o): In function `unsigned int apache::thrift::HeadersPayloadContent::read<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)':

RocketClient.cpp:(.text._ZN6apache6thrift21HeadersPayloadContent4readINS0_21CompactProtocolReaderEEEjPT_[_ZN6apache6thrift21HeadersPayloadContent4readINS0_21CompactProtocolReaderEEEjPT_]+0x2f): undefined reference to `void apache::thrift::HeadersPayloadContent::readNoXfer<apache::thrift::CompactProtocolReader>(apache::thrift::CompactProtocolReader*)'

collect2: error: ld returned 1 exit status
```

</details>

This change adds -lrpcmetadata to LDADD where relevant.

+6 -0

0 comment

4 changed files

pr created time in 9 days

push eventLINKIWI/mcrouter

Kevin Lin

commit sha 8fcf17f0a140ba35e4929aa32ec2897caaa36edb

Fix regression: SSL_CTX_set_security_level and OpenSSL version detection (#346) Summary: This fixes a compilation regression recently introduced by D22433603 (https://github.com/facebook/mcrouter/commit/e1a06dc0f70a6b9e27c5b9179427804054613806) (OSS e1a06dc0f70a6b9e27c5b9179427804054613806) when compiling under OpenSSL >= 1.0.2 but <= 1.1.0. `SSL_CTX_set_security_level` was first introduced in OpenSSL 1.1.0 per its manpage, but the compile guard `FOLLY_OPENSSL_HAS_ALPN` only checks for OpenSSL >= 1.0.2. Ref: https://github.com/facebook/folly/blob/b1d264ed8e7ee445f157a7ad7493b99f916eb6df/folly/portability/OpenSSL.h#L62 https://github.com/facebook/folly/blob/b1d264ed8e7ee445f157a7ad7493b99f916eb6df/folly/portability/OpenSSL.h#L88 Pull Request resolved: https://github.com/facebook/mcrouter/pull/346 Reviewed By: mingtaoy Differential Revision: D22510856 Pulled By: disylh fbshipit-source-id: 81b0be1c90f1504df5bf3c0aea0842aacffa1289

view details

Stuart Clark

commit sha 3df906edefb75db50c09d08a38330cf79aa3c500

Inherit from thrift structs Summary: As above Reviewed By: spalamarchuk Differential Revision: D22086084 fbshipit-source-id: 713b39794e926d342d864bb67acbcd68ef3871f9

view details

Stuart Clark

commit sha 9b544a5d7297697c0cb595cba0230105d94efb7f

Add mixin support to thrift namespace Summary: As above Reviewed By: jmswen Differential Revision: D22229256 fbshipit-source-id: 365a81efe1e82f9f5cef34e2a186e2406fd839f2

view details

Stanislau Hlebik

commit sha 7c6f297f70e5a9460183d8ff2cbce9b2a6bfe567

remediation of S205607 fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac

view details

Stanislau Hlebik

commit sha 491cc1ac48677a058e072e9de5ecf5a6c16fdfc4

remediation of S205607 fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3

view details

Ivan Babrou

commit sha c79cef19625f14beeecd8a9c85cc049e69dc2d11

Use full name of nullptr_t in FBTrace-inl.h (#347) Summary: Fixing this: ``` In file included from network/McClientRequestContext.cpp:8: In file included from network/McClientRequestContext.h:19: In file included from ../../mcrouter/lib/network/FBTrace.h:28: network/FBTrace-inl.h:33:8: error: unknown type name 'nullptr_t'; did you mean 'std::nullptr_t'? inline nullptr_t traceRequestReceived( ^~~~~~~~~ std::nullptr_t /usr/bin/../lib/gcc/aarch64-linux-gnu/8/../../../../include/aarch64-linux-gnu/c++/8/bits/c++config.h:242:29: note: 'std::nullptr_t' declared here typedef decltype(nullptr) nullptr_t; ``` Pull Request resolved: https://github.com/facebook/mcrouter/pull/347 Reviewed By: stuclar Differential Revision: D22609891 Pulled By: disylh fbshipit-source-id: 484b38b76b7a99921e037bc9f8b1651a2e339985

view details

generatedunixname89002005287564

commit sha 731f4f203e07c06ea74fa96a6d5508036a4087c2

Daily `arc lint --take CLANGFORMAT` Reviewed By: zertosh Differential Revision: D22624109 fbshipit-source-id: b8969ac0b8b44a8d60bd9d20416dbc051f4bcf4f

view details

Stuart Clark

commit sha efd76401bf7ad170c2ca0de4d1925f7c8292f13c

Support nested request structures Summary: As above Reviewed By: jmswen Differential Revision: D22513466 fbshipit-source-id: b9d0e3a15096836917c345e7d5d065f7fe09e6e1

view details

Martin Martin

commit sha 4f340a3e0168021886f130537c4203ddf6dfb006

Redo D20142226, which was reverted in D22305711. Summary: In FNA, we often have hosts, or processes, that are down for a long time. When we add or delete hosts from the config, it's important that we redirect the fewest possible requests. In particular, when hosts have been disabled for a while, and we then remove them from the config, it's important that all keys continue to go to the same hosts. Thus, the failover policy, when machine X is down, needs to match the primary policy, when machine X is removed. Since the primary policy is RendezvousHash, this failover policy uses the RendezvousHash logic to choose the failover. Reviewed By: ftimyo Differential Revision: D22775059 fbshipit-source-id: a2d27b66c4da31b0baa5d045bf63a96b5bf177f2

view details

Martin Martin

commit sha 1c77a448080d5f4d92885feb6434f3b7dd082bee

Change StringPiece argument from pass-by-reference to pass-by-value. Reviewed By: stuclar Differential Revision: D22791530 fbshipit-source-id: 524125f69681ea71b7890f739d8bbe4da73fb15c

view details

Misha Shneerson

commit sha fb93068be3936869c47bc8f1f88a6bcc32eaef17

periodic timers should not cause leaking of folly::RequestContext Summary: we do have some periodic maintentenance tasks... if those are initialized lazily on a requests handling path, they will capture current rctx and keep it it alive forever. Reviewed By: yfeldblum Differential Revision: D22859344 fbshipit-source-id: 3655d874dee22aaf74b4d80631d4a58e83539752

view details

Kevin Lin

commit sha 6cdb9c356e4d7497ce6e4b06501c42392696c646

Add -lrpcmetadata to linker args

view details

push time in 9 days

create barnchLINKIWI/mcrouter

branch : rpc-metadata

created branch time in 9 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha 314c9aa498218b2059f34991caac1e7e670702a5

Sync with web-boilerplate

view details

push time in 11 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha f9e1fe480acfe42f4a7288f01600b5cdb153fa53

Add explicit tags whitelist for new gauge events

view details

Kevin Lin

commit sha 19598858cb067f4d828279bbf1348c2ee3a5dfcd

Remove default empty telemetry tags

view details

push time in 23 days

push eventLINKIWI/supercharged

ci.internal.kevinlin.info

commit sha 4b683326e7c4c685a7d32aebd3d02fb032afa8c8

[automatic commit] supercharged:ced603e31bd025966c9f832cf8015d2c7eabbbce ci-deploy-source: https://ci.internal.kevinlin.info/job/task--static-deploy/50/ release-artifact: supercharged release-version: ced603e31bd025966c9f832cf8015d2c7eabbbce domain: supercharged.static.kevinlin.info

view details

push time in 24 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha ced603e31bd025966c9f832cf8015d2c7eabbbce

Request duration stopwatch in trace middleware

view details

push time in 24 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha eed627bb05f09188f307f075d924a7fc524469bc

Upgrade supercharged to disable reconnect decay

view details

push time in 24 days

push eventLINKIWI/supercharged

ci.internal.kevinlin.info

commit sha f7b8a368a71ed0f101b2f868d804a335d27f9ce9

[automatic commit] supercharged:8e191303a3bc18a873e47ae6a89c389b7a698d49 ci-deploy-source: https://ci.internal.kevinlin.info/job/task--static-deploy/49/ release-artifact: supercharged release-version: 8e191303a3bc18a873e47ae6a89c389b7a698d49 domain: supercharged.static.kevinlin.info

view details

push time in 24 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha 8e191303a3bc18a873e47ae6a89c389b7a698d49

Set client websocket reconnectDecay to 1

view details

push time in 24 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha beb19ad2f31840a3ef9c51b2c8474a42ccaf9e9f

CLICK_FILE_RESULT_POSITION telemetry gauge

view details

push time in 24 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha d932415f5cb1b7ab86966c34af37bade1d446f95

Safe access of response data fields in API instrumentation wrapper

view details

Kevin Lin

commit sha 94597980373c218abbfdb2eaeceb60bce34e85cb

Internally hosted supercharged release tarball dependency

view details

push time in 25 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha 93eb8e335ebb15cefc968ded8768f97ea407f861

Internal release and static deploy of npm tarball

view details

push time in 25 days

push eventLINKIWI/supercharged

ci.internal.kevinlin.info

commit sha af3fd8cc2f00a722268fa8f0286668d028314fc8

[automatic commit] supercharged:93eb8e335ebb15cefc968ded8768f97ea407f861 ci-deploy-source: https://ci.internal.kevinlin.info/job/task--static-deploy/47/ release-artifact: supercharged release-version: 93eb8e335ebb15cefc968ded8768f97ea407f861 domain: supercharged.static.kevinlin.info

view details

push time in 25 days

push eventLINKIWI/supercharged

ci.internal.kevinlin.info

commit sha 2d459e08dae29f4995fcd029dc8805c99cf2d3ba

[automatic commit] supercharged:d192bfce2617e3725d9b9b7d3dbc345a5a9e2f04 ci-deploy-source: https://ci.internal.kevinlin.info/job/task--static-deploy/46/ release-artifact: supercharged release-version: d192bfce2617e3725d9b9b7d3dbc345a5a9e2f04 domain: supercharged.static.kevinlin.info

view details

push time in 25 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha b530a68eb87221163b6ee426ee43045f4a93ff93

Bump dependencies

view details

Kevin Lin

commit sha 643aff4d521dea160b3daf1be66d99f04299be42

Request ID in global trace middleware

view details

Kevin Lin

commit sha d192bfce2617e3725d9b9b7d3dbc345a5a9e2f04

Internal release and static deploy of npm tarball

view details

push time in 25 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha 36b503e02340ddf4bbf0994bec81b57c7be1ced1

Internal release and static deploy of npm tarball

view details

Kevin Lin

commit sha e857fe9a8d5ba24681e1d2a3108f292493c3488e

Address lint errors

view details

push time in 25 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha d262ee02aabb67ffd408e733bd0d1acd2fe6d0bc

Address lint errors

view details

push time in 25 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha 21f232236911f77cfee331343c39c721c8e3bd26

Bump dependencies

view details

Kevin Lin

commit sha 13051961a8940328cf4b160f8c8544cc1ed49cf6

Request ID in global trace middleware

view details

Kevin Lin

commit sha c70a5ad2a767febf81ad2909bb149830f465c96b

Internal release and static deploy of npm tarball

view details

push time in 25 days

push eventLINKIWI/supercharged

Kevin Lin

commit sha 89954a79489fdeb90d1e267648a3dbc936322f44

Initial commit

view details

push time in 25 days

create barnchLINKIWI/supercharged

branch : static

created branch time in 25 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha 1afc6289272955dc3d96b943e7e973178c65f1fd

Allow overriding both button style and menu style in OverflowMenu

view details

Kevin Lin

commit sha 40714d0d16f2b7a755b9f21d7142d28c6e0a5383

Support mirrored style for OverflowMenu

view details

Kevin Lin

commit sha 784db9260b02273e334a48306e5417a599e94810

Static OverflowMenu button height instead of padding around text

view details

Kevin Lin

commit sha 5ea441a862b5c8d6f90d3b5c802d89b4c79859c2

SearchResultsContainer: shouldComponentUpdate -> onlyUpdateForKeys

view details

Kevin Lin

commit sha e37d63f139a7ab9d8bf73a19a46e1f61f028e3e1

Slightly increase size of ellipsis in OverflowMenu

view details

Kevin Lin

commit sha 663215b18a07295cd866a61f5da5420cd08461f4

CODE_SEARCH_FILE_RESULTS_LIMIT client-side preference

view details

Kevin Lin

commit sha b9119cef4a9f6182b47a7634a5232055cd7e6404

Move stopwatch instrumentation utility to shared

view details

Kevin Lin

commit sha 2046ddca0b5301be42a1f51548f3475baefcc918

Active and total session length telemetry

view details

Kevin Lin

commit sha 15ccf0cef00eec622935e1292534ddef461d5e27

Clipboard, source preview, single file search context menu on file results

view details

Kevin Lin

commit sha 7dcad9fc256f0e295b925563baeb609766421222

File entry source preview outside of main container, to properly disable hover state

view details

push time in 25 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha ae0abc3131bb5e8e783e20de1e5f560c0da8f1ae

File entry source preview outside of main container, to properly disable hover state

view details

push time in 25 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha e7ffff5e9382b977c92db7a9879303a2504e3f83

Allow overriding both button style and menu style in OverrideMenu

view details

Kevin Lin

commit sha 8947bf801d8e69643ee0c52592f793f5aa4b2bea

Support mirrored style for OverflowMenu

view details

Kevin Lin

commit sha 9c967454d2dc3a380fb1663db53b41cc9552dfcf

Static OverflowMenu button height instead of padding around text

view details

Kevin Lin

commit sha 3773772c63459d6b3c3e260006db378ee1fb9f4b

SearchResultsContainer: shouldComponentUpdate -> onlyUpdateForKeys

view details

Kevin Lin

commit sha 1b26f2b8a6d46c7b060e2cf4695ec9d8e9985754

Slightly increase size of ellipsis in OverflowMenu

view details

Kevin Lin

commit sha cdbf9547a13dbf8f1e1fbdf55b1326f89acd1437

CODE_SEARCH_FILE_RESULTS_LIMIT client-side preference

view details

Kevin Lin

commit sha 37d6657ec15871e7533b62aaf907431f8e66b0be

Move stopwatch instrumentation utility to shared

view details

Kevin Lin

commit sha 8946c65bccf5de1554cc861a5a903433a2425996

Active and total session length telemetry

view details

Kevin Lin

commit sha a357b70080fce75a87a3cd0b3f0a5608335ff168

Clipboard, source preview, single file search context menu on file results

view details

push time in 25 days

push eventLINKIWI/webgrep

Kevin Lin

commit sha 02c83aa7db6811e019f95b9b4fa3c14ce81d3c43

Change CLICK_CODE_RESULT_POSITION metric type to timer for percentile aggregation

view details

push time in a month

push eventLINKIWI/webgrep

Kevin Lin

commit sha c93bcb5db300593f14cf5c079f191ec31634d41f

Local repository source code viewer backend

view details

push time in a month

push eventLINKIWI/webgrep

Kevin Lin

commit sha 34915c07e47525529ebcaa600a6a5f68dd2992fa

Respect client-supplied telemetry value for counters

view details

Kevin Lin

commit sha 55ae958a4d806ef1696b334417393d815775eb85

CLICK_CODE_RESULT_POSITION telemetry event

view details

push time in a month

push eventLINKIWI/webgrep

Kevin Lin

commit sha 663324f97d7a0c9134bde6cdc7ee90fcc4bfb7be

Decouple telemetry event CLICK_CODE_RESULT_PATH from file result click

view details

push time in a month

push eventLINKIWI/webgrep

Kevin Lin

commit sha 63a980cfe9f0b18a429a451445330cb5a057561d

Sync with web-boilerplate: simplified NODE_ENV in build process

view details

push time in a month

Pull request review commentfacebook/mcrouter

Fix regression: SSL_CTX_set_security_level and OpenSSL verison detection

 std::shared_ptr<SSLContext> createClientSSLContext(   auto context = std::make_shared<ClientSSLContext>(ticketCache.get());   auto ciphers = folly::ssl::SSLCommonOptions::ciphers();   std::vector<std::string> cVec(ciphers.begin(), ciphers.end());-#if FOLLY_OPENSSL_HAS_ALPN+#if FOLLY_OPENSSL_IS_110

Thanks for taking a look. I've updated to only wrap SSL_CTX_set_security_level with the preprocessor guard.

LINKIWI

comment created time in a month

push eventLINKIWI/mcrouter

Kevin Lin

commit sha f76609c2fde9f8784a7293999629d32259c485c7

Revert "Stricter compile guard: FOLLY_OPENSSL_IS_110 for SSL_CTX_set_security_level" This reverts commit 652156b7541fabf7b93293ccf6c208d4b665e299.

view details

Kevin Lin

commit sha a3ce67375238a264860d901507f8536049d6c246

Only guard SSL_CTX_set_security_level with FOLLY_OPENSSL_IS_110

view details

push time in a month

pull request commentfacebook/mcrouter

Fix regression: SSL_CTX_set_security_level and OpenSSL verison detection

cc @knekritz @mingtaoy

LINKIWI

comment created time in a month

PR opened facebook/mcrouter

Fix regression: SSL_CTX_set_security_level and OpenSSL verison detection

This fixes a compilation regression recently introduced by D22433603 (OSS e1a06dc0f70a6b9e27c5b9179427804054613806) when compiling under OpenSSL >= 1.0.2 but <= 1.1.0.

SSL_CTX_set_security_level was first introduced in OpenSSL 1.1.0 per its manpage, but the compile guard FOLLY_OPENSSL_HAS_ALPN only checks for OpenSSL >= 1.0.2.

Ref: https://github.com/facebook/folly/blob/b1d264ed8e7ee445f157a7ad7493b99f916eb6df/folly/portability/OpenSSL.h#L62

+1 -1

0 comment

1 changed file

pr created time in a month

fork LINKIWI/folly

An open-source C++ library developed and used at Facebook.

https://groups.google.com/forum/?fromgroups#!forum/facebook-folly

fork in a month

create barnchLINKIWI/mcrouter

branch : openssl-110

created branch time in a month

push eventLINKIWI/mcrouter

Eden Zik

commit sha 9b5ce9a0610b53191c58c5fbba1182f329f2f9c9

Add dependency on needed in oss build Summary: Title Reviewed By: stuclar Differential Revision: D22284369 fbshipit-source-id: a5ec8945734bd28141d1282084c15b0ab16b83ce

view details

Eden Zik

commit sha 26e0787f7cc34c9630120e59b84147b83b190666

Added support for Acl Checks in Standalone Mcrouter Summary: Title. This is a proposed implementation, using `StandaloneConfig`. Reviewed By: stuclar Differential Revision: D21100048 fbshipit-source-id: fe293259a20938444ed4a17c964928ec5ad4903c

view details

Krishna Kondaka

commit sha 1619f3adb28e74d4ff0605522a4737d6df851f4c

Fix BigValueRoute from returning metadata when the lease-get is done on the key Summary: Fix BigValueRoute from returning metadata when the lease-get is done on the key after the key is deleted The following sequence causes the problem - 1. Create a big value item with key "k" 2. delete the item with key "k" (It does not matter if The chunks are deleted or not) 3. do lease-get on key "k" The returned value contains a string of format "Version-numChunks-suffix" which is internal metadata representation of big value items Reviewed By: disylh Differential Revision: D22267344 fbshipit-source-id: de09fc3a78cf2b2f0653c4194656a4b243ae758c

view details

Martin Martin

commit sha a4d7b10aae0865402003ffa98d5e421310d375c9

Rendezvous Hash based failover policy Summary: In FNA, we often have hosts, or processes, that are down for a long time. When we add or delete hosts from the config, it's important that we redirect the fewest possible requests. In particular, when hosts have been disabled for a while, and we then remove them from the config, it's important that all keys continue to go to the same hosts. Thus, the failover policy, when machine X is down, needs to match the primary policy, when machine X is removed. Since the primary policy is RendezvousHash, this failover policy uses the RendezvousHash logic to choose the failover. Reviewed By: ftimyo Differential Revision: D20142226 fbshipit-source-id: 7385d03222aeb1b904db2f4e0d7c11f659992a97

view details

Robin Naggi

commit sha 502fc2a5e9784a29a44568f291110b5be636ea44

Revert D20142226: Rendezvous Hash based failover policy Differential Revision: D20142226 (https://github.com/facebook/mcrouter/commit/a4d7b10aae0865402003ffa98d5e421310d375c9) Original commit changeset: 7385d03222ae fbshipit-source-id: 2748f13de45d9e39b0f944e7f24f455f1a9ab7a7

view details

Jon Maltiel Swenson

commit sha 25edb6f6b5cc9231489437c4752ce4d7f3fe246a

Rename RSRoutingHandler to RocketRoutingHandler Reviewed By: yfeldblum Differential Revision: D22264192 fbshipit-source-id: 63b905d49fb68e8db92233f773495976af5551ae

view details

Luke Ye

commit sha f5d1504cb20609b02ce4a398c93f7e726a61c035

Support server load from thrift server Summary: 1. add flag in fiber context for enabling thrift server load or not. 2. carbon code gen to put thrift load header in request when flag enabled. Also update server load from response. 3. In LoadbalancerRoute, set server load flag based on config Reviewed By: stuclar Differential Revision: D22041241 fbshipit-source-id: 116f09a3d8912d8e5e95adbbd2d0805b656f2be5

view details

Shai Szulanski

commit sha ad7a6eb9e81e01cf2f6d78898eabb3a96778c9d9

Run clang-format - 5/6 Summary: This directory is opted-in to clang-format but is not format-clean. This blocks continuous formatting from being enabled on fbcode, and causes hassle for other codemods that leave inconsistent formatting. This diff runs clang-format, which is widely used and considered safe. If you are unhappy with the formatting of a particular block, please *accept this diff* and then in a stacked commit undo the change and wrap that code in `// clang-format off` and `// clang-format on`, or `/* clang-format off */` and `/* clang-format on */`. drop-conflicts Reviewed By: jmswen Differential Revision: D22314269 fbshipit-source-id: 5cf97c4f1093055cf51eb3d4374d4dc9f77645fa

view details

Shai Szulanski

commit sha 08b10cad1c75dd1d64eaf4a5b25436c7a4dc80e8

Run clang-format - 2/6 Summary: This directory is opted-in to clang-format but is not format-clean. This blocks continuous formatting from being enabled on fbcode, and causes hassle for other codemods that leave inconsistent formatting. This diff runs clang-format, which is widely used and considered safe. If you are unhappy with the formatting of a particular block, please *accept this diff* and then in a stacked commit undo the change and wrap that code in `// clang-format off` and `// clang-format on`, or `/* clang-format off */` and `/* clang-format on */`. drop-conflicts Reviewed By: jmswen Differential Revision: D22314242 fbshipit-source-id: f8d06db779e31e3d87b58c790b126b57fc941c61

view details

Shai Szulanski

commit sha 882cd0e38ccfa194c010dab52fdf6f6e0776ae0b

Run clang-format - 1/6 Summary: This directory is opted-in to clang-format but is not format-clean. This blocks continuous formatting from being enabled on fbcode, and causes hassle for other codemods that leave inconsistent formatting. This diff runs clang-format, which is widely used and considered safe. If you are unhappy with the formatting of a particular block, please *accept this diff* and then in a stacked commit undo the change and wrap that code in `// clang-format off` and `// clang-format on`, or `/* clang-format off */` and `/* clang-format on */`. drop-conflicts Reviewed By: edenzik Differential Revision: D22314229 fbshipit-source-id: f06e5959dc627a36d37caa112c7742c35a84e49e

view details

Shai Szulanski

commit sha 4e663c58e7b8ad9bfdcad1a08036cc3ea958f180

Run clang-format - 3/6 Summary: This directory is opted-in to clang-format but is not format-clean. This blocks continuous formatting from being enabled on fbcode, and causes hassle for other codemods that leave inconsistent formatting. This diff runs clang-format, which is widely used and considered safe. If you are unhappy with the formatting of a particular block, please *accept this diff* and then in a stacked commit undo the change and wrap that code in `// clang-format off` and `// clang-format on`, or `/* clang-format off */` and `/* clang-format on */`. drop-conflicts Reviewed By: jmswen Differential Revision: D22314250 fbshipit-source-id: bfb0f9a5f4351e349e62684aa47a6aaed455c7b2

view details

Jon Maltiel Swenson

commit sha 164fe540f3b49e05e8362ae856b98019e751abef

Remove rsocket-cpp OSS dependency Summary: fbthrift no longer depends on rsocket-cpp. Reviewed By: bithree Differential Revision: D22272307 fbshipit-source-id: 2a68ed908e6fe1b78bf0d7b0d87742dda7bb5580

view details

Andres Suarez

commit sha 980a8d34b10a62dd61cfe9cae958a723eac61ee8

clang-format fix extra lines and namespace comments Summary: These are all of the files in fbcode that have opted into clang-format via `arc lint` and whose only formatting issues are incorrect namespace comments and extra empty lines. This diff does not include a handful of files that are dirsynced to xplat. And a few files were skipped because of merge conflicts. Methedology: 1. Edit `tools/clang-format/clang-format.ini` with `FixNamespaceComments: false`, `KeepEmptyLinesAtTheStartOfBlocks: true` and `MaxEmptyLinesToKeep: 5`. 2. Format all of fbcode with: `arc lint -a --take CLANGFORMAT --paths-cmd 'hg files fbcode'`. 3. Drop dirsync changes with: `perl -ne 'print "$1\n" if /\.fbcode\s*=\s*(.+)/' .hgdirsync | xargs hg revert --`. 4. Remove the `clang-format.ini` changes. 5. Commit the changes in `fbcode/` as "A". 6. Format all of fbcode again and drop the dirsync changes. 7. Commit the changes as `[codemod] clang-format fix extra lines and namespace comments`. 8. Rebase the codemod off of "A" with `hg rebase -d fbcode/warm -r . --tool ':local'`. 9. Remove any changes where clang-format fails to reach a steady state: `arc lint --take CLANGFORMAT --never-apply-patches --output summary | cut -d':' -f1 | xargs hg revert -r .~1 --`. 10. Amend. allow-large-files drop-conflicts Reviewed By: iahs Differential Revision: D22341115 fbshipit-source-id: c16cd608ec1fe1e89eb1439354f836558c88ea36

view details

Shai Szulanski

commit sha d10611a1c0d26865524585ac1d871e3addd4746a

Run clang-format - 4/6 Summary: This directory is opted-in to clang-format but is not format-clean. This blocks continuous formatting from being enabled on fbcode, and causes hassle for other codemods that leave inconsistent formatting. This diff runs clang-format, which is widely used and considered safe. If you are unhappy with the formatting of a particular block, please *accept this diff* and then in a stacked commit undo the change and wrap that code in `// clang-format off` and `// clang-format on`, or `/* clang-format off */` and `/* clang-format on */`. drop-conflicts Reviewed By: edenzik Differential Revision: D22314258 fbshipit-source-id: c9f0917e2428870045b03dafb39dabbbab8a7964

view details

Jorge Ochoa Lopez

commit sha dd4283d667978897d93d23bb3f50c57c019463cb

Delete L1 sentinel if L2 lookup fails Summary: If a previous lease-set to L1L2Split succeeded for large item, but on subsequent lookup to L2 fails, we failover to Gutter and get stuck in a loop where the lease-set never succeeds due to mismatched tokens between gutter and L1. More details: Details in https://fb.quip.com/HMp9A0kDynHe Long-term solution is to delete L1 sentinel whenever we have a L2 lookup failure on L1L2Split setup. Reviewed By: anidev Differential Revision: D22235357 fbshipit-source-id: 44f754559d3727f8f1df03aba8f0d2ddf389f365

view details

Shai Szulanski

commit sha ea79df41f5830094930fbf76a127b18feeb2f96c

Run clang-format - 6/6 Summary: This directory is opted-in to clang-format but is not format-clean. This blocks continuous formatting from being enabled on fbcode, and causes hassle for other codemods that leave inconsistent formatting. This diff runs clang-format, which is widely used and considered safe. If you are unhappy with the formatting of a particular block, please *accept this diff* and then in a stacked commit undo the change and wrap that code in `// clang-format off` and `// clang-format on`, or `/* clang-format off */` and `/* clang-format on */`. drop-conflicts Reviewed By: zertosh Differential Revision: D22314278 fbshipit-source-id: eebad9a4dbdb1654de67258375acba936786b813

view details

Eden Zik

commit sha 4cbc35eb0088dfca8a7fbc643fd45d95f89f8f74

Use routingKey instead of fullKey when evaluating prefix ACL's Summary: RequestAclChecker for Memcache should run on keys only after we've parsed out routing component. Reviewed By: stuclar Differential Revision: D22365429 fbshipit-source-id: 535261c7c9cef7ee561cef43a43867bb61a8360d

view details

Shai Szulanski

commit sha d343ce96d365fddbd6d6dc10d40924722904131b

clang-format fbcode Reviewed By: zertosh Differential Revision: D22392868 fbshipit-source-id: a839366565cd772b864e9a3b0cdc277a6c5757f2

view details

Luke Ye

commit sha 4b74b0873846cfe20f733cfee2cf3756e96239b1

test serialize & deserialize compatiblity between int enum types Reviewed By: stuclar Differential Revision: D22359100 fbshipit-source-id: f35f7f86710e0cfab306fe7357bda717830aa368

view details

Anton Likhtarov

commit sha af89738fec80b462c66003a6db4ad6746bd6a226

Use Thrift APIs in sfinae detectors Summary: Also switch to std::void_t for simplicity Reviewed By: stuclar Differential Revision: D22429080 fbshipit-source-id: 93c84725d80c71bbc9ee4d898e5f0676479547b4

view details

push time in a month

push eventLINKIWI/memcached

Tharanga Gamaethige

commit sha 7e64232119cd182f43617e628e660dc75b7bb411

fixing the basic tls test so it exits correctly when fails

view details

Tomas Korbar

commit sha 8e5148ca5c32fafca948e43c2e966db28a50a5f4

Use signal function instead of sigignore Sigignore has been marked as deprecated on Fedora rawhide and signal function is used already on multiple places in memcached.c fix #690

view details

prudhvi

commit sha f68e1f3fc6d60197271ca4820305adccde497318

skip setting the resource limits in debug builds if they are already greater than the maxconns

view details

Tharanga Gamaethige

commit sha 0271aa9e4c96a884a700070a3d7f3afffc276620

adding openssl errors to SSL certificate loading error messages

view details

dormando

commit sha 53b4d74234cdbf42263b49885499ff977b215451

fix leak in merged resp/read buffers The list grows toward next, not prev. Also wasn't zeroing out next ptr. Also didn't unmark free for first resp object. (thanks Prudhviraj!) Adds a couple counters so users can tell if something is wrong as well. response_obj_count is solely for response objects in-flight, they should not be held when idle (except for one bundle per worker thread).

view details

dormando

commit sha e190205e239b0338f1b539dcd2372bdcdd67d5b3

main: split text protocol into proto_text.c export a lot of the connection handling code from memcached.c

view details

dormando

commit sha e1bb1db06081d61e16ee42c791da22003357427b

main: split binary protocol into proto_bin.c also some missed text bits.

view details

Mark Hagger

commit sha 7bb69b80b1252d77766097567d1e1b40dd60775c

Improve page balancing when writes are bursty Extention to the existing slab reallocation model to better cope with eviction patterns that appear in short timeframe bursts. This means that if more than 25% of the total evictions in the window appear in this slab it becomes a candidate for needing more pages.

view details

dormando

commit sha e86a585d5afabb26dcd7774ba2ec34ba01959c41

Improve page balancing function (in-daemon) match the python changes for the scripts/memcached-automove copy of the algorithm.

view details

Guido Iaquinti

commit sha 9f2d28e429a9ba522a8f7d0b4cb21dffc19af476

Dockerfile - allow override of config opts

view details

push time in a month

issue commentLINKIWI/cloudflare-ddns-client

Cant pull docker image

There is no official published Docker image; the pull is not expected to work. You can build the image locally using the community-contributed Dockerfile though.

yeetenderyeeter

comment created time in a month

delete branch LINKIWI/mcrouter

delete branch : rendezvous-compile

delete time in a month

PR closed facebook/mcrouter

Fix compilation regression for RendezvousRouteHelpers CLA Signed

Commit 6f75b60618f6bd3f72bc0c743b01c07dea3dcadf (D20234501) introduced two new files RendezvousRouteHelpers.cpp and RendezvousRouteHelpers.h which are absent from the OSS Makefile SOURCES definition.

Adding these to the Makefile allows the compilation to complete successfully.

cc @stuclar as approver for the original change

+2 -0

1 comment

1 changed file

LINKIWI

pr closed time in a month

pull request commentfacebook/mcrouter

Fix compilation regression for RendezvousRouteHelpers

Looks like 9b5ce9a0610b53191c58c5fbba1182f329f2f9c9 contains the same patch.

LINKIWI

comment created time in a month

PR opened facebook/mcrouter

Fix compilation regression for RendezvousRouteHelpers

Commit 6f75b60618f6bd3f72bc0c743b01c07dea3dcadf (D20234501) introduced two new files RendezvousRouteHelpers.cpp and RendezvousRouteHelpers.h which are absent from the OSS Makefile SOURCES definition.

Adding these to the Makefile allows the compilation to complete successfully.

cc @stuclar as approver for the original change

+2 -0

0 comment

1 changed file

pr created time in a month

create barnchLINKIWI/mcrouter

branch : rendezvous-compile

created branch time in a month

fork LINKIWI/mcrouter

Mcrouter is a memcached protocol router for scaling memcached deployments.

fork in a month

push eventLINKIWI/webgrep

Kevin Lin

commit sha 9894df92e40c7c0f0421ceb3e393451a3ec675d8

Bump dependencies

view details

push time in 2 months

push eventLINKIWI/supercharged

Kevin Lin

commit sha e1a9e93cdd64820283f04ece7c900bae4655afa8

JSON.stringify instead of SHA256 as resource cache object hash

view details

Kevin Lin

commit sha 4491f6b70a7e6279c2585b3ffac6b4506de04238

Support optional message in success HTTP response

view details

Kevin Lin

commit sha c2dc9b2d015b29f0facc74230dfab16d12b0ab44

Upgrade dependencies and address breaking interface changes

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 7ef688ade6a53b8ce1d48262a63355a82c2ed552

Server-side latency measurement in endpoint instrumentation decorator

view details

Kevin Lin

commit sha 9807af6ac26c7d6f0dd56fa38daff13ce4983c6e

Use stopwatch in gRPC client for RPC latency instrumentation

view details

push time in 2 months

push eventLINKIWI/aperture

Kevin Lin

commit sha f31d79b99965bc2cbebe9f474543f4db50d1809c

transport: Unit tests for backend factory instantiation failure

view details

Kevin Lin

commit sha 5484e3085e07706d861a2549f6df1dfd607fb0bc

transport: >= comparison on threshold for reconnect

view details

push time in 2 months

push eventLINKIWI/aperture

Kevin Lin

commit sha 43f29b6ee0f4ba092985575d8a7ae25fede4b597

transport: Add Noop transport implementation

view details

Kevin Lin

commit sha e5dd1c5368591b2a1f2a1399ab6b699b3d8ff730

transport: Migrate Buffered transport constructor to transport factory

view details

Kevin Lin

commit sha 273a192c3e13bda9792e7d93d05758178de34300

root: Create Reconnecting transport for TransportProbeInterval config option

view details

push time in 2 months

push eventLINKIWI/aperture

Kevin Lin

commit sha be629d3e7e8a3d19f1cb7037c301ff05b60692d2

transport: Refactor BufferedTransport -> Buffered

view details

Kevin Lin

commit sha 93ef49ec0e90193790c0875383f0104b86d3629e

transport: Reconnecting transport wrapper

view details

Kevin Lin

commit sha 11d9d49ad2d4ff2db483bc0ff91bbe19f00b0553

transport: Export Factory in types

view details

Kevin Lin

commit sha 3e18414277ede87dd8dad06bec50d444622596c8

root: TransportProbeInterval config option

view details

Kevin Lin

commit sha 7b45bcb7db2515d60dcb5fb63c631722ee876d04

transport: Add Noop transport implementation

view details

push time in 2 months

push eventLINKIWI/aperture

Kevin Lin

commit sha e36e3a3a256cb014f8759cd565b3c037aa0f4c8c

root: Enable data race detection in build

view details

Kevin Lin

commit sha 804dac260a9ecfab80b4d2f3072cf8ce907459c0

.ci: Enable go vet in lint step

view details

push time in 2 months

push eventLINKIWI/aperture

Kevin Lin

commit sha 1f82d5b7ee15ff7a89ba9bc57464e6a4f8fd2be7

.ci: golint as toolchain dependency

view details

push time in 2 months

PR closed memcached/memcached

Restore SAN entries in testing TLS certificates merged/fixed for next

In the new hardened certs introduced by #671, it seems that the SAN names were removed from the certificates. This change regenerates the certs to include client and server SANs to be consistent with those present in 1.6.5 and earlier:

https://github.com/memcached/memcached/blob/1.6.5/t/client_crt.pem#L31

https://github.com/memcached/memcached/blob/1.6.5/t/server_crt.pem#L31

Currently, memcached does not actually depend on SANs for any functionality. This PR is a patch we use internally to fix some (additional out-of-tree) regressed unit tests, and I figure it would be harmless to propose it upstream as well.

This change also fixes some minor typos in the documented openssl commands used to generate the certs.

cc @TomasKorbar

+0 -0

1 comment

0 changed file

LINKIWI

pr closed time in 2 months

push eventLINKIWI/memcached

dormando

commit sha 2b7a9ed0c8dfa5a6a489ad6a6a6e90ac43de70f4

Fix TCP failure under OS X. sendmsg() on darwin doesn't like zero sized messages, apparently. Bails out with "message too long". Don't think I intended to run the syscall when there's nothing actually to send, anyway.

view details

minkikim89

commit sha 2b473a666d183b7d097a69facf6a20125c20274e

Changed the parts using strtol to use safe_strtol

view details

Kevin Lin

commit sha df1315225a6273b66f4d2aaecd8197ea44627600

Restore SAN entries in testing TLS certificates

view details

Tomas Korbar

commit sha cdeb988c28ca44d02e14c94467331af614cb976f

Do not join lru and slab maintainer threads if they do not exist If no_modern option was supplied then these threads did not run but memcached still attempted to join them, which resulted in a segfault. resolve #685

view details

dormando

commit sha d343e53b5a2f1dbab8ea79ea5d84a5937760e24b

net: carve response buffers from read buffers balancing start arguments for memory limits on read vs response buffers is hard. with this change there's a custom sub-allocator that cuts the small response objects out of larger read objects. it is somewhat complicated and has a few loops. the allocation path is short circuited as much as possible.

view details

dormando

commit sha 7c2df4a70d3aa50dd507ee92a0af4e0279433988

net: remove most response obj cache related code accept but warn if the commandline is used. also keeps the oom counter distinct so users have a chance of telling what type of memory pressure they're under.

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha d3b2fa0ea8c40256543915f1d9a4bae1c81f3df0

Server-side latency measurement in endpoint instrumentation decorator

view details

Kevin Lin

commit sha 3080b304b0270b2f2d816d128319ac7af9d99ec7

Use stopwatch in gRPC client for RPC latency instrumentation

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 09b8916521817cd15486bc3417fd261a97dded06

Server-side latency measurement in endpoint instrumentation decorator

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 0b4f40c92d899885ae2de46812ce3978b2f97c95

Secondary Toggle does not uppercase text by default

view details

Kevin Lin

commit sha d2caabac3205234dac91c9cb9e59b0393825ba4d

Suggestions text header for clarity of behavior

view details

Kevin Lin

commit sha 556371a934e179f271e2e533aaa6c3eee1184e10

Populate root directory suggestions as well as file extensions

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 31ee5527ae94e303037cd1fdb6dbe0891028f494

Use standard margin size between file path field and suggestions strip

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 1e0faa0216560c67e50fd05e68aeaab040ed8ee5

Ellipsis on file path search placeholder

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 198a986d9d48dd57ae6875748c04ff9aeb622ccb

Suggested file extension path filters based on current search results

view details

Kevin Lin

commit sha 83a1cf65a626f960db446e2c449b713abc4902e2

Automatically focus filter fields in flyouts on open

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha fe3d8633088e736b665e1fb8831fd85864ba37c9

Support secondary style and focus state styling on Toggle

view details

Kevin Lin

commit sha 5427674b54e9f21b0c0e289d5cf87de0650eb263

Suggested file extension path filters based on current search results

view details

push time in 2 months

push eventLINKIWI/cloudflare-ddns-client

BSoD-Ultimate

commit sha 24711e00f5d979f6f5eb0b288fb0ec45c58a0ece

Fix: The IPv6 address detection should ignore unique local IPv6 Address (#54) * Fix: The procedure of detecting IPv6 addresses should ignore Unique Local IPv6 Addresses. * do modifications for the pull request

view details

push time in 2 months

PR merged LINKIWI/cloudflare-ddns-client

Fix: The IPv6 address detection should ignore unique local IPv6 Address

Some network configurations might let the gateway assigns Unique Local Addresses to devices connected to the local network. The purpose of assigning this kind of address is to help devices on the same local network could communicate more conveniently since the IPv6 address on the Internet might change over time. This kind of IPv6 address could not be accessed outside the local network.

See RFC 4193: https://tools.ietf.org/html/rfc4193

+20 -2

5 comments

1 changed file

BSoD-Ultimate

pr closed time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 49a45d8379a2993d5ebb68570c2af3d87d167fd7

URL-encode file path parameter in URL

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha ff14a26c77bcc3e7dfd2066f3baf6f1c954c646f

Telemetry event for persisted search history item

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha ba74ccd965d367509e6e91b38d2c175fe9d2d715

Record search history item when executing a new search from source preview

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 2e23c94cc8a61dab8e1dae71a42dfd036d7521e2

Record search history item when executing a new search from source preview

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 0036a5f2ad87a82833d605067271579066c2b712

Fix blur event propagation for QueryField, causing recent searches to not persist

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha d2cb874b12294732e87503a74bde052882165b89

Support callback on updated state after search parameter changes

view details

Kevin Lin

commit sha 9507ad55794949d0b7904b0eeb00daa23111c969

Telemetry event EXECUTE_SEARCH_SINGLE_FILE

view details

Kevin Lin

commit sha 57ca18f618aa5629afb265d4621ace93d357682d

navigation.scroll utility

view details

Kevin Lin

commit sha a4766dfa922b7a9c3c2ec4504ad6c51c49ce085b

Single file search from code snippet

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha da8452e38135e6d7a8ee648265b5c6cfe46bb2c3

Smooth scrolling on source preview search

view details

push time in 2 months

pull request commentLINKIWI/cloudflare-ddns-client

Fix: The IPv6 address detection should ignore unique local IPv6 Address

Thanks. @Mygod any thoughts?

BSoD-Ultimate

comment created time in 2 months

push eventLINKIWI/cloudflare-ddns-client

WTPascoe

commit sha bd6ccfed14ac4313b439da1a40674040f8cb1d4d

Move from Ubuntu to Python Alpine image (#53)

view details

push time in 2 months

PR merged LINKIWI/cloudflare-ddns-client

Move from Ubuntu to Python Alpine image

The Python Alpine issue is smaller than the Ubuntu image, and has fewer non-required components.

+8 -15

0 comment

1 changed file

WTPascoe

pr closed time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha eb1408abe97fe33f8befd2eb4c23bea42a9bba1a

Release binary directory in dist/, build on Node 14

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha f8bd5d820f8025cec74594993facb99ccfc6f092

Menu items support optional icon

view details

Kevin Lin

commit sha 184975057e2f842e08ab1bfa1968aac26fad4c5c

Overflow menu icons in code snippet and admin repositories list

view details

push time in 2 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha bb8870517fbbff6d7d350efb1ad2e85e05bda3d1

QueryOptionControls prop types in class

view details

push time in 2 months

push eventLINKIWI/aperture

Kevin Lin

commit sha 1479dfbe17d0443c97fa009754ff64b11903af7b

lib: NoopStatsd Statsd convenience implementation

view details

push time in 3 months

push eventLINKIWI/cloudflare-ddns-client

WTPascoe

commit sha 8d714bc6c505ade7b40735fce58c4c91a909d03e

README changes and use env var for API_TOKEN (#51) * Typos in README * Allow API_TOKEN to be set in env var Co-authored-by: Wayne P <wayne@penguinpowered.org>

view details

push time in 3 months

PR merged LINKIWI/cloudflare-ddns-client

README changes and use env var for API_TOKEN

Allow API_TOKEN to be read from an environment variable instead of the config file. This is useful for a kubernetes deployment where this will be set from a k8s secret.

+5 -3

1 comment

2 changed files

WTPascoe

pr closed time in 3 months

pull request commentLINKIWI/cloudflare-ddns-client

README changes and use env var for API_TOKEN

Thanks, I wonder if there's value in a more robust configuration system in general that can support overriding any config value with environment variables.

WTPascoe

comment created time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 21b8da2ac20d3eb78ec0ec76970539c082ba71db

Better mobile compatibility with forced Flyout margins

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha d23ef745ddeed13f34712f080a982ad01ea56501

File path filter acts as a native form

view details

Kevin Lin

commit sha 6f0d970cb9a13f898c0763cc07dab5ab2ab1c80b

Use tighter default spacing size for flyout

view details

Kevin Lin

commit sha b719a42d10254bb4d9200b5a4272659da65483e5

Better mobile compatibility with forced Flyout margins

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha e684b35690861e373eaae6045cafa97f5bb38f5e

Increase width threshold for compact layout

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 5d707e9ead4fe963a179247ab77f0f4199a167f0

Remove non-working focus on file path flyout open

view details

Kevin Lin

commit sha d8a116d769fd016e184cd641a67b041c97b21678

Better compact layout for flyouts

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 041146a6fd80b3c794b82ef1a4cae036a3687f5f

start:server:watch only watches files in src/server/

view details

Kevin Lin

commit sha 8b2940de97aaaf16badaf4f3a53d8ba969a9460d

Proper handling of TextField blur by omitting HOC blur props

view details

Kevin Lin

commit sha f4be259543e1b27946f1ae1788f65d7dbc899362

Remove non-working focus on file path flyout open

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 6880fa4b975b14f72828322096a2ec8a8f490454

Support alpha/beta variant of Box for bolder Flyout shadow

view details

Kevin Lin

commit sha 33fe6aca5a6455ba365c35866a83a8aa43741fe9

Smaller button spacing in Flyout

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 13bb3d5414bfa879cd9e3e41457da91d118962a1

Window click listener passive component

view details

Kevin Lin

commit sha 5483af2c1fbd17bcdbcb84b4ec426495d77518e3

Keyboard listener trigger event keypress -> keydown

view details

Kevin Lin

commit sha bc98f631ce75cb82c6b59454d7deb955a15cff2e

Simplify QueryField with shared TextField component

view details

Kevin Lin

commit sha 5b5d57dd951797405b3cdb619478a23143697feb

Flyout UI component

view details

Kevin Lin

commit sha 5714eebcb3fdc08487c5b1a2d2c614588ed6ab7d

Support de/serialization of file path at query layer

view details

Kevin Lin

commit sha 70e7eed76e1d626c80dc5125697633a90c1742fa

File path and repository filters implemented as flyouts

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha abad290bca1e10fe1c41206e020a0737f911f7f8

Support ref forwarding in Toggle

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha ca71b9a3912c76d166b6a0377e7dd63671e2607c

Allow resetting repository filter list on empty toggle

view details

Kevin Lin

commit sha d3ba422e72c69315ccaa2df746d4ed41ea567014

Generify input DOM IDs for which keyboard shortcuts are disabled

view details

Kevin Lin

commit sha d732eac3b371e9898270b51d6eb52b361802374a

Support ref forwarding in Toggle

view details

push time in 3 months

push eventLINKIWI/webgrep

Kevin Lin

commit sha 5c49f071f8faf795612ef17e7ec1f48bf5827ea6

Bump dependencies, address breaking webpack config changes

view details

push time in 3 months

Pull request review commentLINKIWI/cloudflare-ddns-client

added --silent and --silent-unchanged flag, regarding #47

 def load_arguments():     parser.add_argument('--configure', action='store_true', help='Interactively configure the account and domain for the DDNS updates.')     parser.add_argument('--update-now', action='store_true', help='Update DNS records right now.')     parser.add_argument('--debug', action='store_true', help='Print detailed debug output.')+    parser.add_argument('--silent', action='store_true', help='Do not print any output.')+    parser.add_argument('--silent-unchanged', action='store_true', help='Only print DNS changes / warning / errors.')

Per the discussion in the other issue I would recommend removing this option entirely since it doesn't add much value; it's not really "silent" and just feels like a raised log level.

zaanposni

comment created time in 3 months

pull request commentLINKIWI/cloudflare-ddns-client

added quiet/silent unchanged mode, regarding #47

Is there really a need to have --silent-unchanged? Sounds like it is just normal behavior at a warn instead of info log level.

zaanposni

comment created time in 3 months

pull request commentLINKIWI/cloudflare-ddns-client

Changed python to python3 for compatibility

To the best of my knowledge the script should be backwards-compatible with Python 2 and we deliberately defer to your distro's choice of Python to choose one to use.

For the import error, I found some solutions by searching Google. Try pip install --upgrade backports.functools_lru_cache or similar.

Toby4213

comment created time in 3 months

pull request commentLINKIWI/cloudflare-ddns-client

added quiet/silent unchanged mode, regarding #47

Thanks, I think we can probably make this much simpler and do away with the global variables by simply not printing if the quiet flag is set.

I like the proposed idea of using the Python logging module and just setting the level to silent if the flag calls for it, so that there doesn't need extra logic to deal with that.

zaanposni

comment created time in 3 months

push eventLINKIWI/memcached

Kevin Lin

commit sha 125f4e850d30837b1153c026fb6a62ce158f3f1c

Restore SAN entries in testing TLS certificates

view details

push time in 3 months

PR opened memcached/memcached

Restore SAN entries in testing TLS certificates

In the new hardened certs introduced by #671, it seems that the SAN names were removed from the certificates. This change regenerates the certs to include client and server SANs to be consistent with those present in 1.6.5 and earlier:

https://github.com/memcached/memcached/blob/1.6.5/t/client_crt.pem#L31

https://github.com/memcached/memcached/blob/1.6.5/t/server_crt.pem#L31

Currently, memcached does not actually depend on SANs for any functionality. This PR is a patch we use internally to fix some (additional out-of-tree) regressed unit tests, and I figure it would be harmless to propose it upstream as well.

This change also fixes some minor typos in the openssl commands used to generate the certs.

cc @TomasKorbar

+228 -219

0 comment

7 changed files

pr created time in 3 months

push eventLINKIWI/memcached

Kevin Lin

commit sha 54d662e5958958e10a743d15b9cfa1d54c8423c3

Restore SAN entries in testing TLS certificates

view details

push time in 3 months

more