profile
viewpoint

vuejs/vue-next 9229

The next major version of Vue (WIP)

KaelWD/consola 0

🐨 Elegant Console Logger for Node.js and Browser

KaelWD/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

KaelWD/eslint-plugin-vue 0

Official ESLint plugin for Vue.js

KaelWD/idm-task-05 0

Website for a Digital Media project

KaelWD/rollup-plugin-vue 0

Roll .vue files

KaelWD/triage-new-issues 0

A GitHub App, built with Probot that adds `triage` label to newly-created issues which don't have labels

issue closedvuetifyjs/vuetify

[Bug Report] VGrid not exported by vuetify/lib

Environment

Vuetify Version: 2.2.14 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.100 OS: Mac OS 10.15.2

Steps to reproduce

Use this in any component.

import {VGrid} from 'vuetify/lib'
    export default {
        components: {
            VGrid
        },
    }

Run

npm install
npx webpack --mode=development --verbose

Expected Behavior

No warning about VGrid not being exported.

Actual Behavior

WARNING in ./src/main/webapp/js/fast/vue/components/staff/common/schoolSelection.vue?vue&type=script&lang=js& (./node_modules/vuetify-loader/lib/loader.js??ref--8-0!./node_modules/vue-loader/lib??vue-loader-options!./src/main/webapp/js/fast/vue/components/staff/common/schoolSelection.vue?vue&type=script&lang=js&) 48:12-17
"export 'VGrid' was not found in 'vuetify/lib'

Reproduction Link

<a href="https://codesandbox.io/s/quirky-jones-8vf4u" target="_blank">https://codesandbox.io/s/quirky-jones-8vf4u</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in a day

kxen42

issue commentvuetifyjs/vuetify

[Bug Report] VGrid not exported by vuetify/lib

You have to import individual components.

import { VContainer, VRow, VCol } from 'vuetify/lib'
kxen42

comment created time in a day

issue commentvuetifyjs/vuetify

[Bug Report] v-select custom item slot doesn't respond properly to item selection

This could do with an example implementation.

perdidao

comment created time in a day

release vuetifyjs/vuetify

v1.5.23

released time in 2 days

created tagvuetifyjs/vuetify

tagv1.5.23

🐉 Material Component Framework for Vue

created time in 2 days

push eventvuetifyjs/vuetify

Kael

commit sha 94113aceaa4d8f7bdc289075b42ba1b0469de51f

chore(release): publish v1.5.23

view details

push time in 2 days

issue closedvuetifyjs/vuetify

[Bug Report] VTextField: Syntax error in regular expression in function unmaskText in IE11

Environment

Vuetify Version: 1.5.17 Vue Version: 2.6.10 Browsers: Internet Explorer OS: Windows 10

Steps to reproduce

Make a <v-text-field> with a mask and type any text in IE11. The value will not be set and you will get the Syntax error in regular expression in the console.

Expected Behavior

The masked text fields should be usable in IE11.

Actual Behavior

You cannot fill in the masked text fields.

Reproduction Link

<a href="https://jsbin.com/majopojiqi/edit?js,console" target="_blank">https://jsbin.com/majopojiqi/edit?js,console</a> (open in IE11)

Other comments

The problem is in the file src/util/mask.ts, in the line:

const defaultDelimiters = /[-!$%^&*()_+|~=`{}[\]:";'<>?,./\\ ]/

which is used by the function unmaskText:

new RegExp(defaultDelimiters, 'g')

However, IE11 requires the new RegExp(pattern, flags) constructor to provide the pattern as a String, not a RegExp object. The solution is to set:

const defaultDelimiters = "[-!$%^&*()_+|~=`{}[\]:\";'<>?,./\\ ]"

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 2 days

niutech

push eventvuetifyjs/vuetify

Kael

commit sha 977e58690ca270f22c23c988b9ac2c8b7bdd5225

fix(VTextField): prevent IE11 error with mask delimiters fixes #8917

view details

push time in 2 days

issue closedvuetifyjs/vuetify

[Bug Report] Tab focus from v-select returns to the first focusable element

Environment

Vuetify Version: 1.5.6 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.106 OS: Windows 10

Steps to reproduce

Using macOS Safari 12.0.3, Edge, or IE11.

After focusing on v-select pressing the tab key does not focus to next focusable element. Instead focus is set to the first focusable item on the page.

In Google Chrome the tab focus works normally.

Expected Behavior

Tab focus should move to next focusable element from a v-select in Safari, Edge, and IE11

Actual Behavior

Tab focus does not move to next focusable element from a v-select in Safari, Edge, and IE11

Reproduction Link

<a href="https://codepen.io/anon/pen/RdwyQQ?editors=1010" target="_blank">https://codepen.io/anon/pen/RdwyQQ?editors=1010</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 2 days

maxshuty

push eventvuetifyjs/vuetify

Max

commit sha 49cb28b829fd638f1b54c5e0cef2fcd44153101a

fix(VSelect): resolve bug in Safari/Edge/IE with event order disparity (#10620) The ordering of events in Safari/Edge/IE casued our manual blur of the input to break tabbing through inputs. Additionally resolving duplicate blur events. fix #10609

view details

push time in 2 days

PR merged vuetifyjs/vuetify

fix(vselect): resolve bug in browsers with event order disparity C: VSelect C: VTextField T: bug lts

The ordering of events in Safari/Edge/IE caused our manual blur of the input to break tabbing through inputs. Additionally resolving duplicate blur events

"fix #10609"

<!-- MAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR https://vuetifyjs.com/getting-started/contributing

Testing and markup sections can be removed for documentation changes -->

<!-- Provide a general summary of your changes in the Title above --> <!-- Keep the title short and descriptive, as it will be used as a commit message -->

<!-- We use conventional-changelog-angular for all commit structures --> <!-- https://vuetifyjs.com/getting-started/contributing#commit-guidelines-w-commitizen -->

Description

<!-- Describe your changes in detail --> <!-- Note any issues that are resolved by this PR --> <!-- e.g. resolves #4213 or fixes #2312 --> Fixing tabbing so that it doesn't return to the first focusable element in Safari/Edge/IE (and possibly other browsers). Additionally fixing duplicate blur event. This PR piggy backs off of this PR for 2.0 here: https://github.com/vuetifyjs/vuetify/commit/5fa6a682634a0c159cf7c37897535bc2894131b9

Motivation and Context

<!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> This change is required to fix this open issue: https://github.com/vuetifyjs/vuetify/issues/10609

How Has This Been Tested?

<!-- All PR's should implement unit tests if possible --> <!-- Please describe how you tested your changes. --> <!-- Have you created new tests or updated existing ones? --> <!-- e.g. unit | visually | e2e | none --> I have updated an existing test, all tests pass, and additionally I was able to test in these environments:

  • Chrome Version 80.0.3987.106 (Official Build) (64-bit)
  • Firefox Version 73.0
  • Microsoft Edge 41.16299.1004.0
  • Internet Explorer 11 Version 11.1087.16299.0

Markup:

<!-- Information on how to setup your local development environment can be found here: --> <!-- https://vuetifyjs.com/getting-started/contributing#setup-dev-environment -->

<!-- Paste markup for testing your change ---> <details>

<template>
  <div>
    <v-text-field label="First Name"></v-text-field>
    <v-text-field label="Last Name"></v-text-field>
    <v-text-field label="Occupation"></v-text-field>
    <v-autocomplete
      v-model="model"
      :items="states"
      :label="'State'"
      prepend-icon="mdi-city"
    ></v-autocomplete>
    <v-text-field label="City"></v-text-field>
    <v-text-field label="E-mail"></v-text-field>	
  </div>
</template>

<script>
  export default {
    data () {
      return {
        isEditing: false,
        model: null,
        states: [
          'Alabama', 'Alaska', 'American Samoa', 'Arizona',
          'Arkansas', 'California', 'Colorado', 'Connecticut',
          'Delaware', 'District of Columbia', 'Federated States of Micronesia',
          'Florida', 'Georgia', 'Guam', 'Hawaii', 'Idaho',
          'Illinois', 'Indiana', 'Iowa', 'Kansas', 'Kentucky',
          'Louisiana', 'Maine', 'Marshall Islands', 'Maryland',
          'Massachusetts', 'Michigan', 'Minnesota', 'Mississippi',
          'Missouri', 'Montana', 'Nebraska', 'Nevada',
          'New Hampshire', 'New Jersey', 'New Mexico', 'New York',
          'North Carolina', 'North Dakota', 'Northern Mariana Islands', 'Ohio',
          'Oklahoma', 'Oregon', 'Palau', 'Pennsylvania', 'Puerto Rico',
          'Rhode Island', 'South Carolina', 'South Dakota', 'Tennessee',
          'Texas', 'Utah', 'Vermont', 'Virgin Island', 'Virginia',
          'Washington', 'West Virginia', 'Wisconsin', 'Wyoming'
        ]
      }
    }
  }
</script>

</details>

Types of changes

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

<!-- Go over all the following points, and put an x in all the boxes that apply. --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] The PR title is no longer than 64 characters.
  • [x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • [x] My code follows the code style of this project.
  • [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
+16 -10

0 comment

3 changed files

maxshuty

pr closed time in 2 days

issue commentvuetifyjs/vuetify

[Bug Report] VTooltip issue when activating only on click

Workaround: https://codepen.io/kaelwd/pen/JjdbPRB

deraw

comment created time in 2 days

pull request commentvuetifyjs/vuetify

feat(VForm): Add form level disabled prop

should I adjust this so the warning shows?

I think that was intentional, but yeah it probably doesn't make sense to use it in a form without radio-group.

VSimpleCheckbox

Not supposed to be a full replacement for VCheckbox, it's for performance critical stuff like data table selection. Oh also it's functional so that won't work anyway, just ignore it.

Logikgate

comment created time in 3 days

release vuetifyjs/vuetify

v2.2.14

released time in 3 days

created tagvuetifyjs/vuetify

tagv2.2.14

🐉 Material Component Framework for Vue

created time in 3 days

push eventvuetifyjs/vuetify

Kael

commit sha d8b3adc45d6146e7351b3607612d9b889610e309

chore(release): publish v2.2.14

view details

push time in 3 days

issue closedvuetifyjs/vuetify

[Bug Report] v-autocomplete menu error

Environment

Vuetify Version: 2.2.13 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.116 OS: Windows 10

Steps to reproduce

Write some text to input.

Expected Behavior

Open items menu

Actual Behavior

Gives error

Reproduction Link

<a href="https://codepen.io/navi3591/pen/abOmLXx?editable=true&editors=101" target="_blank">https://codepen.io/navi3591/pen/abOmLXx?editable=true&editors=101</a>

Other comments

On v-menu component this.dimensions.content is null in calculated hook. This causes the error.

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 3 days

navi35

issue commentvuetifyjs/vuetify

[Bug Report] v-autocomplete menu error

Duplicate of #10606

navi35

comment created time in 3 days

push eventvuetifyjs/vuetify

nekosaur

commit sha 0fe8a7ffc7570a38baa21409b211f407007bceb6

chore: bump vue version

view details

Kael

commit sha 2135c78acbe29434044f39ec9f4e66052fdda037

feat(goTo): use provided layout from v-app

view details

push time in 3 days

Pull request review commentvuetifyjs/vuetify

feat(VForm): Add form level disabled prop

 export type Registrable<T extends string, C extends VueConstructor | null = null  export function inject<   T extends string, C extends VueConstructor | null = null-> (namespace: T, child?: string, parent?: string): Registrable<T, C> {+> (namespace: T, child?: string, parent?: string, nestingOptional?: boolean): Registrable<T, C> {

Child/parent are only used for the warning, if it's optional you just don't use those arguments.

Logikgate

comment created time in 3 days

issue closedvuetifyjs/vuetify

[Bug Report] Cannot read property 'height' of null

Environment

Vuetify Version: 2.2.13 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.116 OS: Windows 10

Steps to reproduce

Just try to type: PROGRAMMING.

The error will show in the console.

This error broke up all combobox in my website.

Expected Behavior

Show Vmenu Control

Actual Behavior

Vmeno Control dont show up

Reproduction Link

<a href="https://codepen.io/oixan/pen/yLNaagY?editors=1010" target="_blank">https://codepen.io/oixan/pen/yLNaagY?editors=1010</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 3 days

oixan

issue commentvuetifyjs/vuetify

[Bug Report] Cannot read property 'height' of null

Duplicate of #10606

oixan

comment created time in 3 days

issue closedvuetifyjs/vuetify

[Bug Report] side v-navigation draw stays open on resize

Environment

Vuetify Version: 2.2.13 Vue Version: 3.0.0-alpha.0 Browsers: Chrome 80.0.3987.116 OS: Mac OS 10.15.3

Steps to reproduce

  1. Take the baseline template layout
  2. I changed data.drawer to empty string instead of null to set it to close by default when the browser loads
  3. If I resize my window right down to small, I can display the left hand drawer by clicking on the hamburger toggle. 4)However when I now resize the window the draw stays open and does not close although the background overlay disappears.

Expected Behavior

If the browser size is small, display the hambuger menu and toggle the left hand drawer on and off but close the drawer menu on the left when the browser hits a certain breakpoint

Actual Behavior

I can't find in the docs if there is a method or a slot to say if it is a browser size of > 900 close the menu on the left hand side that corresponds to the breakpoints that have been to for devices. there is no working example to show you how you would configure this or if you want to build a desktop web interface yet be mobile responsive

Reproduction Link

<a href="https://codesandbox.io/s/l761m0069m" target="_blank">https://codesandbox.io/s/l761m0069m</a>

Other comments

How can I close the drawer navigation with it is > 900px?

The left hand navigation draw is usually used for mobile devices, yet it is open by default and the inverse should be default

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 3 days

ottz0

issue commentvuetifyjs/vuetify

[Bug Report] side v-navigation draw stays open on resize

Duplicate of #10629

ottz0

comment created time in 3 days

issue commentvuetifyjs/vuetify

[Feature Request] Allow v-divider to use other tag than hr

Duplicate of #5469?

Magiczne

comment created time in 4 days

pull request commentvuetifyjs/vuetify

feat(VForm): Add form level disabled prop

See VExpansionPanel for example. VForm provides itself and the controls have a isDisabled computed property that checks this.form.disabled.

Logikgate

comment created time in 4 days

issue commentvuetifyjs/vuetify

[Feature Request] Button Groups should disable option

and it really not smooth if more than 50 button

Can you elaborate on this?

matamune94

comment created time in 4 days

issue commentvuetifyjs/vuetify

[Feature Request] [v-btn-toggle] Disable active state

Do you mean like #4325, that wasn't actually implemented IMHO.

esynaps

comment created time in 4 days

Pull request review commentvuetifyjs/vuetify

feat: typescript 3.8, nullish coalescing, optional chaining

 module.exports = {       modules: false,       corejs: { version: 2, proposals: true }     }]+  ],+  plugins: [+    [+      '@babel/plugin-proposal-optional-chaining',+      {

*autistic screeching*

{ loose: true }
jacekkarczmarczyk

comment created time in 4 days

Pull request review commentvuetifyjs/vuetify

feat: typescript 3.8, nullish coalescing, optional chaining

 if (['lib', 'es5'].includes(env)) { }  if (env !== 'lib') {-  module.exports.plugins.push('@babel/plugin-proposal-object-rest-spread')+  module.exports.plugins.push([+    '@babel/plugin-proposal-object-rest-spread',+    {+      loose: true,

Wrong line?

jacekkarczmarczyk

comment created time in 4 days

push eventvuetifyjs/vuetify

Kael

commit sha 08c503e2e6d3b10f9c9662b9386569826a258787

fix(VCombobox): blur on click outside when empty fixes #10612

view details

Kael

commit sha 5358676771df99ef0adeca1c2d230f6374e5189a

fix(VMenu): set dimensions to 0 if content does not exist yet fixes #10606

view details

push time in 4 days

issue closedvuetifyjs/vuetify

[Bug Report] V-Autocomplete does not work with asynchronous items

Environment

Vuetify Version: 2.2.13 Last working version: 2.2.12 Vue Version: 2.6.11 Browsers: Chrome 79.0.3945.130 OS: Mac OS 10.15.3

Steps to reproduce

Fill something in, check the console.

Expected Behavior

It does not throw console errors

Actual Behavior

It throws console errors and doesn't show any results

Reproduction Link

<a href="https://codepen.io/ellazlo/pen/WNvxXzP?editable=true&editors=101" target="_blank">https://codepen.io/ellazlo/pen/WNvxXzP?editable=true&editors=101</a>

Other comments

https://vuetifyjs.com/en/components/autocompletes#asynchronous-items

This is what can reproduce it

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 4 days

lassesteffen

issue closedvuetifyjs/vuetify

[Bug Report] v-combobox doesn't lose focus when empty

Environment

Vuetify Version: 2.2.13 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.106 OS: Mac OS 10.15.3

Steps to reproduce

  1. Click on the combobox to focus the field.
  2. Click outside the combobox to blur.

Expected Behavior

The combobox should return back to the initial state.

Actual Behavior

The combobox is still styled like it's focused.

Reproduction Link

<a href="https://codepen.io/dEradicated/pen/PoqzLoK" target="_blank">https://codepen.io/dEradicated/pen/PoqzLoK</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 4 days

d3radicated

issue commentvuetifyjs/vuetify

[Documentation] Wrong Codepen Example Code of Stepper Component

Duplicate of #10270

yamamo-t

comment created time in 4 days

IssuesEvent

issue closedvuetifyjs/vuetify

[Bug Report] v-combobox doesn't lose focus when empty

Environment

Vuetify Version: 2.2.13 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.106 OS: Mac OS 10.15.3

Steps to reproduce

  1. Click on the combobox to focus the field.
  2. Click outside the combobox to blur.

Expected Behavior

The combobox should return back to the initial state.

Actual Behavior

The combobox is still styled like it's focused.

Reproduction Link

<a href="https://codepen.io/dEradicated/pen/PoqzLoK" target="_blank">https://codepen.io/dEradicated/pen/PoqzLoK</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 4 days

d3radicated

issue commentvuetifyjs/vuetify

[Bug Report] v-combobox doesn't lose focus when empty

Duplicate of #10606

d3radicated

comment created time in 4 days

issue commentvuetifyjs/vuetify

[Bug Report] Dialog is closed by clicking on Snackbar

No, you should set z-index on the dialog instead.

jloewe

comment created time in 4 days

issue commentvuetifyjs/vuetify

[Bug Report] v-radio-group not selected initially with value type of "Object"

Or is it a bug? valueComparator was added in 78964e36893f34021989feb9e588d23dac0b76f9 but then radios were refactored to use VItemGroup instead, which doesn't have valueComparator.

haugero

comment created time in 4 days

IssuesEvent

Pull request review commentvuetifyjs/vuetify

feat: typescript 3.8, nullish coalescing, optional chaining

 if (['lib', 'es5'].includes(env)) {  if (env !== 'lib') {   module.exports.plugins.push('@babel/plugin-proposal-object-rest-spread')+  module.exports.plugins.push('@babel/plugin-proposal-optional-chaining')

Use loose mode? https://babeljs.io/docs/en/babel-plugin-proposal-optional-chaining#loose

jacekkarczmarczyk

comment created time in 4 days

Pull request review commentvuetifyjs/vuetify

feat: typescript 3.8, nullish coalescing, optional chaining

     "tags": "dist/json/tags.json",     "attributes": "dist/json/attributes.json"   },-  "web-types": "dist/json/web-types.json"+  "web-types": "dist/json/web-types.json",+  "dependencies": {+    "typescript": "^3.8.0-dev.20200206"

why dis here

jacekkarczmarczyk

comment created time in 4 days

Pull request review commentvuetifyjs/vuetify

feat: typescript 3.8, nullish coalescing, optional chaining

     "shelljs": "^0.8.3",     "ts-jest": "^24.0.2",     "tslint": "^5.18.0",-    "typescript": "^3.5.3",+    "typescript": "^3.8.0-dev.20200201",

https://github.com/microsoft/TypeScript/releases/tag/v3.8-rc

jacekkarczmarczyk

comment created time in 4 days

issue commentvuetifyjs/vuetify

[Bug Report] Dialog is closed by clicking on Snackbar

Damn that's sneaky. Note this will cause the dialog to have a higher z-index than the snackbar if the snackbar is open first.

jloewe

comment created time in 5 days

issue commentvuetifyjs/vuetify

[Bug Report] V-Autocomplete does not work with asynchronous items

Really caused by #8823, 5d8d487 just fixed a bug where everything was being rendered anyway.

lassesteffen

comment created time in 5 days

issue closedvuetifyjs/vuetify

[Bug Report] 在使用pagination组建的过程中的问题

Environment

Vuetify Version: 2.2.12 Vue Version: 2.6.11 Browsers: Chromium 80.0.3987.87 OS: Ubuntu undefined

Steps to reproduce

1.样式不能改变,特别是在宽度小的情况下几乎算是失效 2.prop里的length必须得绑定一个数字,一个真实的静态的数字,否则会报错

Vue warn]: Invalid prop: custom validator check failed for prop "length".
found in
---> <VPagination>

3.分页逻辑有错,不能够实现某一页进去某个项目之后,返回之后还在进入前的页面

Expected Behavior

1.样式不能改变,特别是在宽度小的情况下几乎算是失效 2.prop里的length必须得绑定一个数字,一个真实的静态的数字,否则会报错

Vue warn]: Invalid prop: custom validator check failed for prop "length".
found in
---> <VPagination>

3.分页逻辑有错,不能够实现某一页进去某个项目之后,返回之后还在进入前的页面

Actual Behavior

1.样式不能改变,特别是在宽度小的情况下几乎算是失效 2.prop里的length必须得绑定一个数字,一个真实的静态的数字,否则会报错

Vue warn]: Invalid prop: custom validator check failed for prop "length".
found in
---> <VPagination>

3.分页逻辑有错,不能够实现某一页进去某个项目之后,返回之后还在进入前的页面

Reproduction Link

<a href="https://github.com" target="_blank">https://github.com</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 5 days

yanhe98

issue commentvuetifyjs/vuetify

[Bug Report] 在使用pagination组建的过程中的问题

  • Please only use english
  • The issue template has sections for a reason, you can't just paste the same thing into all of them
  • You have not provided a reproduction of the issue
  • Length has to be an integer
yanhe98

comment created time in 5 days

issue commentvuetifyjs/vuetify

[Bug Report] DataTable click:row.ctrl Modifier Not Working

That also has the added drawback of just giving the method name in template @click.ctrl="nameOfMethod" not working since that only forwards the first argument to the handler

Incorrect

jim-brown-fst

comment created time in 5 days

issue closedvuetifyjs/vuetify

[Bug Report] V-Chip close icon aligned false with mdi/js

Environment

Vuetify Version: 2.2.12 Last working version: 2.2.8 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.106 OS: Windows 10

Steps to reproduce

Use a closable v-chip with @mdi/js as iconfont

Expected Behavior

Icon to be aligned right like in vuetify 2.2.8 CodeSandbox

Actual Behavior

Icon is aligned false

Reproduction Link

<a href="https://codesandbox.io/s/vuetify-2212-pnqyd?fontsize=14&hidenavigation=1&theme=dark" target="_blank">https://codesandbox.io/s/vuetify-2212-pnqyd?fontsize=14&hidenavigation=1&theme=dark</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 5 days

Oli22

issue commentvuetifyjs/vuetify

[Bug Report] V-Chip close icon aligned false with mdi/js

Duplicate of #10480

Oli22

comment created time in 5 days

push eventvuetifyjs/vuetify

Kael

commit sha f62afdaa8a2eeffcf02fe8fcd5e918ebf5611fc9

revert: fix(VCheckbox): use correct unchecked checkbox icon using FA4 This reverts commit 75280f02cee75d0b1de67dd335856ad0e24f8f30. fixes #10602

view details

push time in 5 days

issue closedvuetifyjs/vuetify

[Bug Report] Checkbox image bug when using Font Awesome4

Environment

Vuetify Version: 2.2.12 Vue Version: 2.5.17 Browsers: Chrome 80.0.3987.106 OS: Windows 7

Steps to reproduce

Switch icon settings to Font Awesome 4(fa4), then use checkbox component in vuetify

Expected Behavior

When checkbox is off, the square icon in Font Awesome 4 must be set

Actual Behavior

When the checkbox is on, the check-square icon in FontAwesome 4 is set. However, the square icon is not set when it is off, so the image of the broken font is shown.

Reproduction Link

<a href="https://codepen.io/feedback13/pen/ZEGOpZv?editable=true&editors=101" target="_blank">https://codepen.io/feedback13/pen/ZEGOpZv?editable=true&editors=101</a>

Other comments

"CheckboxOff's value is "far fa-square" in the icons Object value corresponding to fa4 after checking the vuetify.js source in the vuetify module(version 2.2.12). According to FontAwesome 4, the "fa fa-square" value seems to require modification.

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 5 days

feedback13

issue commentvuetifyjs/vuetify

[Bug Report] Incorrect checkbox `off-icon` when using font-awesome

Version locked codepen: https://codepen.io/kaelwd/pen/qBdNqOv

You've linked fontawesome 5.4.0 here, of course fa4 won't be displayed properly.

leftclickben

comment created time in 5 days

issue commentvuetifyjs/vuetify

[Bug Report] Checkbox image bug when using Font Awesome4

:thinking: 75280f02cee75d0b1de67dd335856ad0e24f8f30

feedback13

comment created time in 5 days

push eventvuetifyjs/vuetify

John Leider

commit sha 8a17dc2b6466ffca0eed7befb11ac220ab110ecb

docs(supporters): update backer logos

view details

John Leider

commit sha fb5c5ccc03c0c4741668e88fef5a8382750acedc

revert: fix(VBadge): re-enable pointer-events This reverts commit bc662b9e029c3cbc4250a95f0377a14e45ac080d.

view details

John Leider

commit sha 1583d7c127397e5b58d9fde979c135795da21993

fix(VBadge): re-enable pointer-events originally fixed in bc662b9 - regression discovered in v2.2.2 #10144 - reverted in fb5c5cc fixes #10125

view details

John Leider

commit sha 7ea1274a71bbd62f99a5ea609f31dd530f707dc8

chore(release): publish v2.2.3

view details

John Leider

commit sha e2849f2c855e850ada0d006c2e9ac7f35ef59c59

docs(sponsors): update information

view details

Afzal Sayed

commit sha 7d5d5be89afde96a69e3cf6bf09bae45a4d1d3a9

fix(VDataTable): fix default table header color (#10171)

view details

John Leider

commit sha fda7c3f11ae69ead5abaedd42ac71022d22e25d4

docs(VInput): add information about message slot resolves #9647

view details

John Leider

commit sha 6a1f4576c0b34e6fe7ab97749bd80007cc0736ef

refactor(api-generator): normalize how input props are designated

view details

John Leider

commit sha 8242e056a9f2f64f6f0102ce031dd6f0293ebcd0

fix(VTextField/VTextarea): change styles to match specification also fixed the misaligned prefix/suffix in v-text-area fixes #4639

view details

John Leider

commit sha 2ac739221d43b2d9ada4a970e084263d2124561f

fix(validatable): properly handle boolean false as fn return fixes #9976

view details

John Leider

commit sha 4f151bbdf4388e76d92920ca19c6271c022e6c3f

fix(VChip): scope close icon styles fixes #9451

view details

John Leider

commit sha 3a347a153e39cfe25f3ce6de1059c64a61ae7438

fix(css-reset): add missing comma for style declaration fixes #9521

view details

John Leider

commit sha 58792be8d0b419af3afa418baee76c915b7833b0

docs(VInput): add alert clarifying attributes use-case resolves #9528

view details

John Leider

commit sha f4bc5bddb796a6b6d42fe23e02369085e27b1a2c

fix(VItemGroup): update value when using mandatory and multiple comparison checked if value was null even though multiple requires an array fixes #10077

view details

John Leider

commit sha 792f183795ac8c914d1d6fcf244d713f89d8f035

fix(VTextarea): adjust height for smaller rows and dense fixes #9346

view details

John Leider

commit sha ba5cc5892e3ab5346b447ff5f08f5a8cc1173e52

fix(VSelect): disable menu when readonly was able to open menu by clicking on the inner icon fixes #9960

view details

John Leider

commit sha 2cbf929fca62cd1334cd6d65ad66ad5c3f2fd219

fix(VChipGroup): remove unnecessary color declaration for v-icon is already defined in v-icon's styles fixes #9604

view details

John Leider

commit sha 057bc3cf733cddd8f7a570adaa81766a62d15ef1

docs: remove v-list-item as root of v-list-group activator support for v-list-item as the root of the activator slot was removed a few patches ago resolves #9893

view details

John Leider

commit sha bc55564b32019bfcc212cf53631447f86f6f86e1

fix(VStepper): adjust svg size to match icon font-size fixes #8665

view details

Kael

commit sha c4866935a8949d1141f56d8f19d99b838cea6c52

fix(VChip): prevent navigation on close icon click fixes #10166

view details

push time in 5 days

issue commentvuetifyjs/vuetify

[Feature Request] How i can use my own SASS file globally?

Please explain what you're actually trying to do.

approached

comment created time in 6 days

issue commentvuetifyjs/vuetify

[Bug Report] Vuetify 2.2.6 breaks Vue 2.6.10 v-on click on v-dialog's activator slot

Still your fault. @click="$emit('click')" -> @click="$emit('click', $event)"

rowlo

comment created time in 6 days

issue commentvuetifyjs/vuetify

[Bug Report] Chrome(on Android) doesn't show vuetify page.

Displays fine in chrome 80.0.3987.99 on Android 7.0

Screenshot_2020-02-17-17-46-12-286_com android chrome

Yoshihide-Nishimoto

comment created time in 6 days

issue commentvuetifyjs/vuetify

[Bug Report] <v-list-item-group>'s v-model reports indexes above the length of the items inside

Workaround:

// StopListGroup.js

export default {
  provide: {
    isInGroup: false,
    listItemGroup: undefined
  },

  render () {
    return this.$scopedSlots.default()
  }
}
<v-list>
  <v-list-item-group v-model="foo">
    <v-list-item>
      <stop-list-group>
        <v-menu>
          <v-list>
            <v-list-item></v-list-item>
          </v-list>
        </v-menu>
      </stop-list-group>
    </v-list-item>
  </v-list-item-group>
</v-list>
inad9300

comment created time in 6 days

issue commentvuetifyjs/vuetify

[Bug Report] "$attrs is readonly" and "$listeners is readonly" console messages.

There seems to be some confusion around this as it can be caused by a few unrelated things:

Unit testing

We use Vue.extend in our components, so the vuetify plugin must be installed globally to work properly.

Incorrect:

import Vuetify from 'vuetify'
import { mount, createLocalVue } from '@vue/test-utils'
import component from './my-component.vue'

const localVue = createLocalVue()

localVue.use(Vuetify)

describe('module', () => {
  let vuetify
  beforeEach(() => {
    vuetify = new Vuetify()
  })

  it('should do something', () => {
    const wrapper = mount(component, {
      localVue,
      vuetify
    })
  })
})

Correct:

import Vue from 'vue'
import Vuetify from 'vuetify'
import { mount, createLocalVue } from '@vue/test-utils'
import component from './my-component.vue'

Vue.use(Vuetify)

const localVue = createLocalVue()

describe('module', () => {
  let vuetify
  beforeEach(() => {
    vuetify = new Vuetify()
  })

  it('should do something', () => {
    const wrapper = mount(component, {
      localVue,
      vuetify
    })
  })
})

Non-default vue import

Incorrect:

// main.js
import Vue from 'vue/dist/vue.runtime.esm.js'

Correct:

// main.js
import Vue from 'vue'

// webpack.config.js
module.exports = {
  //...
  resolve: {
    alias: {
      'vue$': 'vue/dist/vue.runtime.esm.js'
    }
  }
}

Monorepo/symlinks

If you have a directory structure like this:

project/
├── app/
│   └── node_modules/
│       └── vue/
└── library/
    └── node_modules/
        └── vue/

or are developing a library and testing it with yarn link

import Vue from 'vue' will resolve project/app/node_modules/vue in the app and project/library/node_modules/vue in the library, resulting in two copies of vue being loaded. We need to configure webpack to only load one. The first step is making sure the library doesn't include vue or vuetify when it's built:

// library/webpack.config.js
module.exports = {
  //...
  externals: {
    vue: {
      commonjs: 'vue',
      commonjs2: 'vue',
      amd: 'vue',
      root: 'Vue'
    },
    vuetify: {
      commonjs: 'vuetify',
      commonjs2: 'vuetify',
      amd: 'vuetify',
      root: 'Vuetify'
    }
  }
}

Then we tell the app to only load its copy:

// app/webpack.config.js
const path = require('path')
module.exports = {
  //...
  resolve: {
    symlinks: false,
    alias: {
      'vue$': 'vue/dist/vue.runtime.esm.js',
      '^vuetify': path.resolve(__dirname, 'node_modules/vuetify')
    }
  }
}
appurist

comment created time in 6 days

issue closedvuetifyjs/vuetify

[Bug Report] Reactivity lost when overriding value in event handler

Environment

Vuetify Version: 2.2.12 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.87 OS: Linux x86_64

Steps to reproduce

In the attached example, the input selector does not like you to set the value 'c' and will in its input handler change it to 'a'. The two native controls, input and select both work as expected: when selecting C, the value is changed to A.

Expected Behavior

The components (v-text-field and v-combobox) should not be allowed to display the value 'c'

Actual Behavior

For the two Vuetify components, this works the first time, but if you select C multiple times, it will not change, until you change to a legal value again.

Reproduction Link

<a href="https://codepen.io/solvemon/pen/GRJoBZB" target="_blank">https://codepen.io/solvemon/pen/GRJoBZB</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 9 days

solvemon

issue commentvuetifyjs/vuetify

[Bug Report] Reactivity lost when overriding value in event handler

Duplicate of #2931

solvemon

comment created time in 9 days

issue commentvuetifyjs/vuetify

[Feature Request] Overwriting Heading variables

Duplicate of #9306

ottz0

comment created time in 9 days

issue closedvuetifyjs/vuetify

[Feature Request] Overwriting Heading variables

Problem to solve

I am trying to overwrite the Vuetify Heading variables. I am using the variables.scss file in the scss folder as per setup and this works correctly as I can update $border-radius-root and $card-elevation variables in which it updates.

Iv'e looked at the vuetify SASS docs and have put the following in my variables doc

$headings: ( 'h1': ( 'size': 8.3125rem, 'line-height': 1.15em ) )

However it doe not update.

What are the steps and process to update and overwrite the $headings variables for H1,H2,body-1 etc as I have tried every approach.

Proposed solution

Documentation on how to update and overwrite heading variables

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 9 days

ottz0

issue closedvuetifyjs/vuetify-loader

(Vuetify 2.0.2+vue-loader 1.4.3+Jest) Jest unit test cases are failing, Vuetify component registration is failing

Note : Vuetify 1.0.* is working with jest for unit testing

Package.json has below npms

"vuetify": "^2.0.2", "jest-vue": "^0.8.2", "vuetify-loader": "1.4.3", "vue-loader": "^12.2.2", "babel-core": "^6.26.0", "babel-loader": "^7.1.2",

Package.json have below jest configs "jest": { "moduleFileExtensions": [ "js", "json", "vue" ], "testURL": "http://localhost/", "transform": { ".*\.(vue)$": "<rootDir>/node_modules/vue-jest", "^.+\.js$": "babel-jest" }, "setupFiles": [ "<rootDir>/test/jest-setup.js" ], "globals": { "vue-jest": { "tsConfig": { "importHelpers": true }, "babelConfig": { "presets": [ [ "env", { "useBuiltIns": "entry", "shippedProposals": true } ] ], "plugins": [ "syntax-dynamic-import" ], "env": { "test": { "plugins": [ "dynamic-import-node" ] } } } } } }

Issue : Keep getting below warnings for all vuetify components (eg : vcontainer , vrow, vcol, vcard etc)

<console.error node_modules/vue/dist/vue.runtime.common.dev.js:621 [Vue warn]: Unknown custom element: <v-card-actions> - did you register the component correctly? For recursive components, make sure to provide the "name" option.

found in

---> <somComponent>
       <Root>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 9 days

baluonline

issue commentvuetifyjs/vuetify-loader

(Vuetify 2.0.2+vue-loader 1.4.3+Jest) Jest unit test cases are failing, Vuetify component registration is failing

Vuetify-loader has not and will never work with jest.

https://vuetifyjs.com/en/getting-started/unit-testing#bootstrapping-vuetify

baluonline

comment created time in 9 days

issue commentvuetifyjs/vuetify

[Bug Report] ICONS - Font Awesome Duotone Incomplete Icons

We've never explicitly supported it

isFontAwesome5 checks for 'fad'

Dissociable

comment created time in 9 days

issue commentvuetifyjs/vuetify

[Bug Report] Dialog - broke in 2.2

That's intentional: #10167

GautierDele

comment created time in 10 days

issue commentvuetifyjs/vue-cli-plugins

[Bug Report] Using @vue/test-utils in sync mode leads to test failures

Duplicate of vuetifyjs/vuetify#9151

I suggest that any entry of @vue/test-utils be upgraded to >= 1.0.0-beta.30

This would break any existing tests, the upgrade should be done manually if needed.

kierans

comment created time in 10 days

issue commentvuejs/vue-next

Type of watch() doesn't take first run into account

Presumably you'd be checking that anyway with a type guard so undefined would be removed.

jacekkarczmarczyk

comment created time in 10 days

issue commentvuetifyjs/vuetify

[Bug Report] ICONS - Font Awesome Duotone Incomplete Icons

Duotone uses both ::before and ::after, and we started using ::after for the focus ring in 2.2.9.

Dissociable

comment created time in 10 days

issue commentvuetifyjs/vuetify

[Bug Report] Navigation-drawer disappears when fullscreen dialog opens for the second time

This is caused by the Dependent mixin

panjon

comment created time in 10 days

issue closedvuetifyjs/vuetify

[Bug Report] Vuetify Assumes All Apps Should Have "overflow-y: scroll" on HTML Element

Environment

Vuetify Version: 2.2.12 Vue Version: 2.6.11 Browsers: Chrome 79.0.3945.130 OS: Windows 10

Steps to reproduce

Apply Vuetify styles to any app.

Expected Behavior

Vuetify should not apply a scrollbar to the HTML element by default.

Actual Behavior

A scrollbar is applied to the page.

Reproduction Link

<a href="https://codepen.io/auzmartist/pen/dyoYKpO" target="_blank">https://codepen.io/auzmartist/pen/dyoYKpO</a>

Other comments

There is an easy workaround in this case, but I find that vuetify is too opinionated about this rule. Is it needed?

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 10 days

auzmartist

push eventvuetifyjs/vuetify

Jacek Karczmarczyk

commit sha 5d8d4871c3b916090b11749ca83852616f49415b

fix(VMenu): allow more than 1 content node (#10525) * fix(VMenu): allow more than 1 content node fixes #10522 * test * fix(VMenu): show transitions Co-authored-by: Kael <kaelwd@gmail.com>

view details

push time in 11 days

delete branch vuetifyjs/vuetify

delete branch : fix/#10522-menu-allow-more-than-1-content-node

delete time in 11 days

PR merged vuetifyjs/vuetify

fix(VMenu): allow more than 1 content node C: VMenu T: bug

Motivation and Context

fixes #10522

related https://github.com/vuetifyjs/vuetify/commit/cc17fe19751826d950ca5207749699935d227020

How Has This Been Tested?

playground, unit

Markup:

<!-- Information on how to setup your local development environment can be found here: --> <!-- https://vuetifyjs.com/getting-started/contributing#setup-dev-environment -->

<!-- Paste markup for testing your change ---> <details>

<template>
  <v-container>
    <v-subheader>VEditDialog</v-subheader>
    <v-edit-dialog large>
      <template #input><span>foo</span><span>bar</span></template>
      <span>foo</span><span>bar</span>
    </v-edit-dialog>

    <v-subheader>VMenu</v-subheader>
    <v-menu
      offset-y
      content-class="white"
    >
      <template #activator="{ on }">
        <v-btn v-on="on">Menu</v-btn>
      </template>
      <div>Foo</div>
      <div>Bar</div>
    </v-menu>

    <v-subheader>VTooltip</v-subheader>
    <v-tooltip bottom>
      <template #activator="{ on }">
        <v-btn v-on="on">Tooltip</v-btn>
      </template>
      <div>Foo</div>
      <div>Bar</div>
    </v-tooltip>

    <v-subheader>VWindow</v-subheader>
    <v-window>
      <v-window-item>
        <span>foo</span>
        <span>bar</span>
      </v-window-item>
    </v-window>

    <v-subheader>VExpansionPanels</v-subheader>
    <v-expansion-panels>
      <v-expansion-panel>
        <v-expansion-panel-header>
          <span>foo</span><span>bar</span>
        </v-expansion-panel-header>
        <v-expansion-panel-content>
          <span>foo</span><span>bar</span>
        </v-expansion-panel-content>
      </v-expansion-panel>
    </v-expansion-panels>

    <v-subheader>VCarousel</v-subheader>
    <v-carousel height="100">
      <v-carousel-item>
        <span>foo</span>
        <span>bar</span>
      </v-carousel-item>
    </v-carousel>

    <v-subheader>VListGroup</v-subheader>
    <v-list>
      <v-list-group>
        <template v-slot:activator>
          <v-list-item-content>
            <v-list-item-title>foo</v-list-item-title>
          </v-list-item-content>
        </template>
        <v-list-item>bar</v-list-item>
        <v-list-item>baz</v-list-item>
      </v-list-group>
    </v-list>
  </v-container>
</template>

</details>

Types of changes

<!-- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

<!-- Go over all the following points, and put an x in all the boxes that apply. --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [x] The PR title is no longer than 64 characters.
  • [x] The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • [x] My code follows the code style of this project.
  • [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
+140 -173

1 comment

12 changed files

jacekkarczmarczyk

pr closed time in 11 days

issue closedvuetifyjs/vuetify

[Bug Report] v-menu no longer rendering all the v-lists

Environment

Vuetify Version: 2.2.9 Last working version: 2.2.8 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.87 OS: Mac OS 10.14.6

Steps to reproduce

when more than one v-list is used inside a v-menu , its used to render all the lists. from 2.2.9 version , it renders only the first list and ignores the other .And no errors are shown. If vueitfy 2.2.8 version or lower is used , it renders all the lists with in the v-menu. Sudden change of behaviour with no error is hard to track down.Its not a blocking behaviour since code can be rewritten easily.But would like to know if this an intended behaviour or a glitch.

Expected Behavior

Till 2.2.8 , multiple v-lists were supported.Either render all the lists or show an error .

Actual Behavior

Doesnt render all the lists ,and also no errors .So its hard to track down

Reproduction Link

<a href="https://codepen.io/sar13/pen/rNVavYE" target="_blank">https://codepen.io/sar13/pen/rNVavYE</a>

Other comments

Would like to know if the 2.2.8 behaviour is gonna be supported or should rewrite so that multiple lists are not included in the v-list

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 11 days

saravankumarpa

issue commentnuxt-community/vuetify-module

Progressive image loading

important is that you refer to all images with the absolute path from the project folder

It uses the same rules as vue-loader: https://vue-loader.vuejs.org/guide/asset-url.html

dschreij

comment created time in 11 days

push eventvuetifyjs/eslint-plugin-vuetify

icleolion

commit sha ddbb81e9fc64575b07fc80808bc64d4ac119fb86

chore: add homepage and description to package.json (#15) closes #14

view details

push time in 12 days

issue closedvuetifyjs/eslint-plugin-vuetify

Homepage/versions as listed on npmjs.com

In vscode, the online package info fetched by the npm extension is garbled for eslint-plugin-vuetify and is missing the handy link to this repository: image

For vuetify this appears properly: image

Never published a package so not really sure what's wrong.

Also thanks for releasing beta.6, the warnings after an npm install were annoying. Unfortunately I didn't know about this release until now due to beta.5 being tagged as latest and beta.6 tagged as beta for the versions as listed on npmjs.com. This confused the Version Lens extension i'm using in vscode under default settings.

With beta.5 installed and default settings: image

It wasn't until I turned on additional functionality in the extension that it then showed me another beta had been released: image

Then going back to default settings after beta.6 is installed: image

closed time in 12 days

icleolion

PR merged vuetifyjs/eslint-plugin-vuetify

Package info fixes

Hopefully this is enough to fix the first part of what I raised in #14.

+2 -0

0 comment

1 changed file

icleolion

pr closed time in 12 days

issue commentvuetifyjs/eslint-plugin-vuetify

Homepage/versions as listed on npmjs.com

beta.5 being tagged as latest and beta.6 tagged as beta for the versions as listed on npmjs.com

ugh, thanks. John did the last release and he uses some dumb tool that tries to be helpful.

icleolion

comment created time in 12 days

issue closedvuetifyjs/eslint-plugin-vuetify

Can I convert my templates automatically?

Hi! Is there any way to convert templates automatically? Or this plugin only informs about problems?

Looks like I can run Eslint fix to convert my lemplates.

vue-cli-service lint --fix

Is it right way?

closed time in 12 days

progand

issue commentvuetifyjs/eslint-plugin-vuetify

Can I convert my templates automatically?

Is it right way?

Yes. Some things still need to be fixed manually though.

progand

comment created time in 12 days

issue closedvuetifyjs/vuetify

[Bug Report] VTextInput clearable icon doesn't have aria-label

Environment

Vuetify Version: 2.2.7 Vue Version: 2.6.11 Browsers: Opera 66.0.3515.44, Google Chrome OS: Mac OS 10.15.2

Steps to reproduce

  1. Create v-text-field
  2. Set clearable parameter to true

Expected Behavior

The append-inner-icon when clearable is set to true does not have aria-label, what reduces SEO Accessibility ranking.

Actual Behavior

The append-inner-icon when clearable is set to true should have aria-label

Reproduction Link

<a href="https://codepen.io/dawidstefaniak/pen/KKwLdrd" target="_blank">https://codepen.io/dawidstefaniak/pen/KKwLdrd</a>

Other comments

I think it will be okay to set hard-coded aria-label for the clearable icon.

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 12 days

dawidstefaniak

issue commentvuetifyjs/vuetify

[Bug Report] VTextInput clearable icon doesn't have aria-label

This was resolved in v2.2.9 with #10439

dawidstefaniak

comment created time in 12 days

Pull request review commentvuetifyjs/vuetify

fix(vicon.ts): svg size didn't match default icon size

 export default mixins(         props: {           right: true,         },+        attrs: {

Or use css to override the width/height/font-size on the .v-chip__close class if we want to keep the sass variable.

rachael-smith

comment created time in 12 days

Pull request review commentvuetifyjs/vuetify

fix(vicon.ts): svg size didn't match default icon size

 export default mixins(         props: {           right: true,         },+        attrs: {

did you try props: { size: 18 }?

rachael-smith

comment created time in 12 days

issue closedvuetifyjs/vuetify

[Bug Report] Dialog open transition does only on first open

Environment

Vuetify Version: 2.2.11 Last working version: 2.2.8 Vue Version: 2.6.11 Browsers: Chrome 80.0.3987.87 OS: Windows 10

Steps to reproduce

  • Open CodePen link
  • Click on "Click me"
  • Close dialog
  • Open it again

Expected Behavior

Recover transition

Actual Behavior

Dialog open transition does only on first open and never on close

Reproduction Link

<a href="https://codepen.io/Deepfreeze/pen/NWqqLwX?editors=1010" target="_blank">https://codepen.io/Deepfreeze/pen/NWqqLwX?editors=1010</a>

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 12 days

pepe-github

issue commentvuetifyjs/vuetify

[Bug Report] Dialog open transition does only on first open

Duplicate of #10536

pepe-github

comment created time in 12 days

issue commentvuetifyjs/vuetify

[Bug Report] No open and close animations on Dialog component

Duplicate of #10536

MaciejJanyska

comment created time in 12 days

issue closedvuetifyjs/vuetify

[Bug Report] v-app-bar hide-on-scroll is hiding when forcing scroll top (Safari only)

Environment

Vuetify Version: 2.2.11 Vue Version: 2.6.11 Browsers: Safari OS: Mac OS 10.14.5

Steps to reproduce

1- Enable design mode on safari 2- Scroll to the bottom until the bar disappears 3- Using the mac trackpad or the mobile scroll, scroll back to the top, bouncing a bit on top

Expected Behavior

The app-bar should be visible.

Actual Behavior

The app bar disappears like scrolling to the bottom

Reproduction Link

<a href="https://codesandbox.io/s/vuetify-scroll-bug-ios-cheqn" target="_blank">https://codesandbox.io/s/vuetify-scroll-bug-ios-cheqn</a>

Other comments

I've got this bug happening on safari running inside an iPhone X, but it's also possible to reproduce on safari desktop.

2020-02-10 13-59-33 2020-02-10 14_00_54

Thank you to @yannbf, helping to reproduce the bug

<!-- generated by vuetify-issue-helper. DO NOT REMOVE -->

closed time in 13 days

guilhermewaess
IssuesEvent

issue commentvuetifyjs/vuetify

[Bug Report] hide-on-scroll on Safari => works the reverse way

Are you still requesting information?

No.

guillim

comment created time in 13 days

push eventvuetifyjs/vuetify

Kael

commit sha 2e556524435bde7bd5a0ac7adb01bbe9411f9892

fix(VTooltip): lazy without transition

view details

push time in 13 days

more