profile
viewpoint
Juanito Fatas JuanitoFatas @Buildkite Tokyo, Japan https://juanitofatas.com Nice to meet you! I‘m a Rubyist at @Buildkite.

jch/html-pipeline 2064

HTML processing filters and utilities

gel-rb/gel 592

A modern gem manager

JuanitoFatas/active_sample 62

I'm feeling lucky! :game_die:

choonkeat/active_waiter 54

allow your users to wait for the completion of your `ActiveJob`

halogenandtoast/dagon 28

The programming language of the elder gods.

JuanitoFatas/active_error 26

Create an exception with backtrace has never been easier :heart:

JuanitoFatas/active_loader 22

:open_file_folder: Load YAML and JSON easily and safely with Active Loader.

JuanitoFatas/bin 4

My ~/bin and small scripts, written in Ruby <3

JuanitoFatas/99bottles-demo 3

TDD for 99bottles by Sandi Metz

push eventbuildkite/docs

Samuel Cochran

commit sha a4d5e2cbd7f15af73a6adf4ca640eb6636d2acc3

Make sure every page renders

view details

Juanito Fatas

commit sha f007cbc3f2970f3ae925532b8cebe0aad6f7fd28

Merge pull request #790 from buildkite/test/my-builds Add test for /docs/pipelines/my-builds

view details

push time in 12 hours

delete branch buildkite/docs

delete branch : test/my-builds

delete time in 12 hours

Pull request review commentbuildkite/docs

Add test for /docs/pipelines/my-builds

 class Check < Struct.new(:path, :source_link, :fragment, keyword_init: true)       /docs/tutorials/sso-setup-with-graphql       /docs/webhooks/setup       /docs/webhooks+      /docs/pipelines/my-builds

a4d5e2c spec tests 139 paths which 69 of them are covered in clicking links. So we are testing 70 extra paths, which I reckon is a win and how to properly marry them, we can think about later... 😅

JuanitoFatas

comment created time in 12 hours

push eventbuildkite/docs

Samuel Cochran

commit sha a4d5e2cbd7f15af73a6adf4ca640eb6636d2acc3

Make sure every page renders

view details

push time in 13 hours

PR opened buildkite/docs

Reviewers
Fix spelling of Red Hat

🤠

+2 -2

0 comment

2 changed files

pr created time in 14 hours

create barnchbuildkite/docs

branch : doc/redhat

created branch time in 14 hours

PR opened buildkite/docs

Reviewers
Add test for /docs/pipelines/my-builds

Follow up of #789.

+1 -0

0 comment

1 changed file

pr created time in 14 hours

create barnchbuildkite/docs

branch : test/my-builds

created branch time in 14 hours

started2ndQuadrant/pglogical

started time in 2 days

delete branch JuanitoFatas/guides-1

delete branch : patch-1

delete time in 3 days

PR opened thoughtbot/guides

Wrap in code to be consistent with line above’s factories.rb

4 lines above factories.rb is wrapped in code.

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchJuanitoFatas/guides-1

branch : patch-2

created branch time in 5 days

startedbensheldon/good_job

started time in 5 days

PR opened thoughtbot/guides

Fix typo in function components URL
+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchJuanitoFatas/guides-1

branch : patch-1

created branch time in 5 days

startedJetBrains/JetBrainsMono

started time in 6 days

startedbuildkite-plugins/slurm-buildkite-plugin

started time in 6 days

push eventbuildkite/docs

Juanito Fatas

commit sha b04c5d89078c5e324240a317bf0088556c5b9220

Change title for Command Step

view details

Juanito Fatas

commit sha 36183a2c793a3aeaae87b5d6522fb3ccf28869d9

Merge pull request #785 from buildkite/consistent-steps-references Change to Command Step for consistency

view details

push time in 7 days

delete branch buildkite/docs

delete branch : consistent-steps-references

delete time in 7 days

PR merged buildkite/docs

Reviewers
Change to Command Step for consistency

I notice across all step types, only command steps are plural and we probably want to keep them consistent, so changed to singular command step. Also the URL is singular https://buildkite.com/docs/pipelines/command-step.

スクリーンショット 2020-07-28 16 17 29 スクリーンショット 2020-07-28 16 17 52 スクリーンショット 2020-07-28 16 17 46 スクリーンショット 2020-07-28 16 17 40 スクリーンショット 2020-07-28 16 17 36

+1 -1

0 comment

1 changed file

JuanitoFatas

pr closed time in 7 days

push eventbuildkite/docs

Juanito Fatas

commit sha b04c5d89078c5e324240a317bf0088556c5b9220

Change title for Command Step

view details

push time in 7 days

PR opened buildkite/docs

Reviewers
Change to Command Step for consistency

I notice across all step types, only command steps are plural and we probably want to keep them consistent, so changed to singular command step.

スクリーンショット 2020-07-28 16 17 29 スクリーンショット 2020-07-28 16 17 52 スクリーンショット 2020-07-28 16 17 46 スクリーンショット 2020-07-28 16 17 40 スクリーンショット 2020-07-28 16 17 36

+13 -13

0 comment

5 changed files

pr created time in 8 days

create barnchbuildkite/docs

branch : consistent-steps-references

created branch time in 8 days

push eventbuildkite/docs

Juanito Fatas

commit sha 4a6150c6624afbec6e495d1e647fdf7e958b3b29

Use full name for YAML

view details

Juanito Fatas

commit sha 81aaf506512ea714471dadcdbaa6490a6ba63824

Merge pull request #784 from buildkite/doc/yaml Use full name for YAML

view details

push time in 8 days

delete branch buildkite/docs

delete branch : doc/yaml

delete time in 8 days

PR merged buildkite/docs

Reviewers
Use full name for YAML

Was browsing through and felt YAML is better :D

+4 -4

0 comment

4 changed files

JuanitoFatas

pr closed time in 8 days

startedbuildkite/lifecycled

started time in 9 days

PR opened buildkite/docs

Reviewers
Use full name for YAML

Was browsing through and felt YAML is better :D

+4 -4

0 comment

4 changed files

pr created time in 9 days

create barnchbuildkite/docs

branch : doc/yaml

created branch time in 9 days

delete branch buildkite/docs

delete branch : docs/blockstep

delete time in 9 days

push eventbuildkite/docs

Juanito Fatas

commit sha aafcb2f583147e3dd42551f1cba47334a75b2686

Use code tag in HTML because no markdown processing here

view details

Juanito Fatas

commit sha be7c818b7ddc0f5bdc95058fab754f6714ecd85b

Merge pull request #781 from buildkite/docs/blockstep Fix a code wrapping in block step doc

view details

push time in 9 days

PR merged buildkite/docs

Fix a code wrapping in block step doc
Before After
スクリーンショット 2020-07-27 14 26 34 スクリーンショット 2020-07-27 14 26 20
+1 -1

0 comment

1 changed file

JuanitoFatas

pr closed time in 9 days

push eventbuildkite/docs

Juanito Fatas

commit sha b09df57e3a88c361d9373f838a859ff91b62f102

Fix block step example link to GitHub

view details

Juanito Fatas

commit sha b22f8dce196cf0b0500634af045c7951c692d0f6

Merge pull request #780 from buildkite/docs/blockstep-example-pipeline-link Fix block step example link to GitHub

view details

push time in 9 days

delete branch buildkite/docs

delete branch : docs/blockstep-example-pipeline-link

delete time in 9 days

PR merged buildkite/docs

Reviewers
Fix block step example link to GitHub
Before After
スクリーンショット 2020-07-27 14 19 51 スクリーンショット 2020-07-27 14 19 45
+1 -1

0 comment

1 changed file

JuanitoFatas

pr closed time in 9 days

pull request commentbuildkite/docs

Update redhat.md.erb

Thank you so much, Guido! 👍

guidodobboletta

comment created time in 9 days

push eventbuildkite/docs

Guido Dobboletta

commit sha db79116f8d21784b018a5bc65bbcb8c76d24807b

Update redhat.md.erb Add missing sudo command

view details

Juanito Fatas

commit sha a226a46cd7e866ad6de4bf328d39542ba893bd40

Merge pull request #779 from guidodobboletta/patch-1 Update redhat.md.erb

view details

push time in 9 days

PR merged buildkite/docs

Update redhat.md.erb

Add missing sudo command

+1 -1

0 comment

1 changed file

guidodobboletta

pr closed time in 9 days

push eventbuildkite/docs

Juanito Fatas

commit sha aafcb2f583147e3dd42551f1cba47334a75b2686

Use code tag in HTML because no markdown processing here

view details

push time in 9 days

PR opened buildkite/docs

Reviewers
Fix a code wrapping in block step doc
Before After
スクリーンショット 2020-07-27 14 26 34 スクリーンショット 2020-07-27 14 26 20
+2 -2

0 comment

1 changed file

pr created time in 9 days

create barnchbuildkite/docs

branch : docs/blockstep

created branch time in 9 days

PR opened buildkite/docs

Reviewers
Fix block step example link to GitHub
Before After
スクリーンショット 2020-07-27 14 19 51 スクリーンショット 2020-07-27 14 19 45
+1 -1

0 comment

1 changed file

pr created time in 9 days

create barnchbuildkite/docs

branch : docs/blockstep-example-pipeline-link

created branch time in 9 days

startedbuildkite/charts

started time in 14 days

delete branch rubyapi/rubyapi

delete branch : patch/darkmode-repo-hover

delete time in 14 days

push eventrubyapi/rubyapi

Juanito Fatas

commit sha aa94673ca2a37ffdac167376769ec487994346e7

Fix hover on repos in top right nav menu in dark mode

view details

Juanito Fatas

commit sha 732f27bf9374354f1eb525e8472672b109adb032

Merge pull request #480 from rubyapi/patch/darkmode-repo-hover Fix hover on repos in top right nav menu in dark mode

view details

push time in 14 days

PR opened rubyapi/rubyapi

Fix hover on repos in top right nav menu in dark mode
Before After
スクリーンショット 2020-07-21 21 52 58 スクリーンショット 2020-07-21 21 52 52

🌒

+2 -2

0 comment

1 changed file

pr created time in 15 days

create barnchrubyapi/rubyapi

branch : patch/darkmode-repo-hover

created branch time in 15 days

startedanilmaurya/fast_jsonparser

started time in 19 days

startedgoogle/iree

started time in 21 days

delete branch JuanitoFatas/puma

delete branch : fix-minissl

delete time in a month

PR closed puma/puma

Improve MiniSSL for users without OpenSSL available

Description

SSL constants removed in https://github.com/puma/puma/commit/3a127f7d407eb2abea94b6e15e35863446899abb. And for people who did not install from OpenSSL extension, this change will end up here. https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L12 which HAVE_OPENSSL_BIO_H is false, then arrived at this code path https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L555-L562

resulted in SSLError.

Check if the OPENSSL_VERSION constant is defined to fix this.

Your checklist for this pull request

  • [x] I have reviewed the guidelines for contributing to this repository.
  • [ ] I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • [ ] I have added appropriate tests if this PR fixes a bug or adds a feature.
  • [x] My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • [ ] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • [ ] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed, including Rubocop.
+3 -2

9 comments

2 changed files

JuanitoFatas

pr closed time in a month

pull request commentpuma/puma

Improve MiniSSL for users without OpenSSL available

Closing this in favor of #2305. Thanks everyone!

JuanitoFatas

comment created time in a month

Pull request review commentbuildkite/docs

Replace web steps with YAML steps

 buildkite-agent start --tags "queue=building,queue=testing"  ## Targeting a queue -Just as you would target agents using a normal [agent tag](/docs/agent/v3/cli-start#setting-tags), you can target specific queues using `queue=name` in your build pipeline query rules.+Just as you would target agents using a normal [agent tag](/docs/agent/v3/cli-start#setting-tags), you can target specific queues using the `agents` attribute on your pipeline steps. 

Drop the Just :)

harrietgrace

comment created time in a month

delete branch buildkite/docs

delete branch : just

delete time in a month

PR closed buildkite/docs

Reviewers
Remove just from targeting a queue section

https://buildkite.com/docs/agent/v3/queues#targeting-a-queue

+4 -4

1 comment

2 changed files

JuanitoFatas

pr closed time in a month

PR opened buildkite/docs

Reviewers
Remove just from targeting a queue section
+4 -4

0 comment

2 changed files

pr created time in a month

create barnchbuildkite/docs

branch : just

created branch time in a month

create barnchJuanitoFatas/rails

branch : polymorphic-custom-primary-key-per-class

created branch time in a month

push eventJuanitoFatas/puma

Juanito Fatas

commit sha a97585c65bc896536ae12d66d5068ec8ff6f9463

Add a changelog for detecting OpenSSL in MiniSSL

view details

push time in a month

push eventJuanitoFatas/puma

Juanito Fatas

commit sha 5ed1f5b01a4ad409a9a27c3bcd153e7e319527e3

Check if OPENSSL_VERSION is defined in MiniSSL For people who did not install from OpenSSL extension, Here https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L12 is false, and they hit SSLError https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L555-L562 Check if the OPENSSL_VERSION is defined to fix this. Co-Authored-By: Matthew Draper <matthew@trebex.net> Co-Authored-By: Samuel Cochran <sj26@sj26.com>

view details

push time in a month

PR opened puma/puma

Check if OPENSSL_VERSION is defined in MiniSSL

Description

SSL constants are removed in https://github.com/puma/puma/commit/3a127f7d407eb2abea94b6e15e35863446899abb. And for people who did not install from OpenSSL extension, this change will end up here. https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L12 which HAVE_OPENSSL_BIO_H is false, then arrived at this code path https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L555-L562

resulted in SSLError.

Check if the OPENSSL_VERSION is defined to fix this.

Your checklist for this pull request

  • [ ] I have reviewed the guidelines for contributing to this repository.
  • [ ] I have added an entry to History.md if this PR fixes a bug or adds a feature. If it doesn't need an entry to HISTORY.md, I have added [changelog skip] the pull request title.
  • [ ] I have added appropriate tests if this PR fixes a bug or adds a feature.
  • [ ] My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • [ ] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • [ ] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed, including Rubocop.
+1 -1

0 comment

1 changed file

pr created time in a month

push eventJuanitoFatas/puma

Juanito Fatas

commit sha fa2b01b9a0169da858e11f8a8d65883a1da7a0c7

Check if OPENSSL_VERSION is defined in MiniSSL For people who did not install from OpenSSL extension, Here https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L12 is false, and they hit SSLError https://github.com/puma/puma/blob/91e57f4e173343746e122e8bb850b0244f508484/ext/puma_http11/mini_ssl.c#L555-L562 Check if the OPENSSL_VERSION is defined to fix this. Co-Authored-By: Matthew Draper <matthew@trebex.net> Co-Authored-By: Samuel Cochran <sj26@sj26.com>

view details

push time in a month

create barnchJuanitoFatas/puma

branch : fix-minissl

created branch time in a month

fork JuanitoFatas/puma

A Ruby/Rack web server built for concurrency

https://puma.io

fork in a month

fork JuanitoFatas/rubocop-rails_config

RuboCop configuration which has the same code style checking as official Ruby on Rails.

fork in a month

startedjohnste/finicky

started time in a month

startedblaknite/gigatron

started time in a month

push eventjch/html-pipeline

Juanito Fatas

commit sha 0b4f328e56afba60fbdcec572083de45edafd043

Bump version to 3.0.0 (Breaking Changes) and changelog

view details

push time in a month

PR opened jch/html-pipeline

HTML::Pipeline 3.0

Update terms in SanitizationFilter and CamoFilter.

Original motivation and community efforts please see https://github.com/rails/rails/pull/33681.

+52 -39

0 comment

7 changed files

pr created time in a month

push eventjch/html-pipeline

Juanito Fatas

commit sha 8c36d52fc33dfaaeab7706960d1b393df361526d

Bump version to 3.0.0 (Breaking Changes) and changelog

view details

push time in a month

create barnchjch/html-pipeline

branch : replace-term

created branch time in a month

delete branch buildkite/docs

delete branch : graphql-api-links

delete time in a month

push eventbuildkite/docs

Juanito Fatas

commit sha f03dfa91284350279f2b04dfaeabbd4b58d000fa

Update GraphQL Relay links

view details

Juanito Fatas

commit sha 407cd562aeda46f7dba5542ea47e02a5d3159f74

Merge pull request #761 from buildkite/graphql-api-links Update GraphQL Relay links

view details

push time in a month

PR merged buildkite/docs

Reviewers
Update GraphQL Relay links

The links now served by relay.dev, so 1 less page jump when people clicks 😄

+2 -2

0 comment

1 changed file

JuanitoFatas

pr closed time in a month

PR opened buildkite/docs

Update GraphQL Relay links

The links now served by relay.dev, so 1 less page jump when people clicks 😄

+2 -2

0 comment

1 changed file

pr created time in a month

create barnchbuildkite/docs

branch : graphql-api-links

created branch time in a month

startedtechknowlogick/gitea-buildkite-connector

started time in a month

push eventbuildkite/docs

Juanito Fatas

commit sha 101f1b765e3d51b4a785959bc764297291d17ffe

Upgrade to Rails 6.0.3.2

view details

Juanito Fatas

commit sha 9081b68c142a098ea34ab734ef81209ac02109b3

Merge pull request #757 from buildkite/security/action-pack Upgrade actionpack to 6.0.3.2

view details

push time in a month

delete branch buildkite/docs

delete branch : security/action-pack

delete time in a month

PR merged buildkite/docs

Reviewers
Upgrade actionpack to 6.0.3.2

We are not affected but this should make the alert go away:

Screenshot 2020-06-26 14 19 19

web-console also needs to be upgraded together because:

Resolving dependencies...
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    actionpack (= 6.0.3.2) was resolved to 6.0.3.2, which depends on
      activesupport (= 6.0.3.2)

    web-console was resolved to 4.0.2, which depends on
      activemodel (>= 6.0.0) was resolved to 6.0.3.1, which depends on
        activesupport (= 6.0.3.1)
+12 -12

0 comment

1 changed file

JuanitoFatas

pr closed time in a month

PR opened buildkite/docs

Reviewers
Upgrade actionpack to 6.0.3.2

We are not affected but this should make the alert go away:

Screenshot 2020-06-26 14 19 19

web-console also needs to be upgraded together because:

Resolving dependencies...
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    actionpack (= 6.0.3.2) was resolved to 6.0.3.2, which depends on
      activesupport (= 6.0.3.2)

    web-console was resolved to 4.0.2, which depends on
      activemodel (>= 6.0.0) was resolved to 6.0.3.1, which depends on
        activesupport (= 6.0.3.1)
+12 -12

0 comment

1 changed file

pr created time in a month

create barnchbuildkite/docs

branch : security/action-pack

created branch time in a month

push eventbuildkite/docs

Juanito Fatas

commit sha cfaa1b1362fcdfd764da716640730f6c35c94a20

Upgrade most of gems * Rails 6 * Lock rouge because syntax highlight changed * Use ActionController::Base renderer

view details

Juanito Fatas

commit sha 4365e28867b3fedf8700f03ed94396e5074a2ec4

Simplify Page#render to render from PagesController Co-Authored-By: Matthew Draper <matthew@trebex.net>

view details

Juanito Fatas

commit sha e7495416cd455f86127ba8fa225faeacea94680a

Merge pull request #742 from buildkite/upgrade-gems Upgrade most of gems

view details

push time in a month

delete branch buildkite/docs

delete branch : upgrade-gems

delete time in a month

PR merged buildkite/docs

Reviewers
Upgrade most of gems

This PR:

  • Use Rails 6 and other gems
  • Lock rouge because syntax highlight css classes changed (we should upgrade this separately)
  • Simplify Page#render
+89 -94

3 comments

4 changed files

JuanitoFatas

pr closed time in a month

push eventruby/www.ruby-lang.org

dependabot[bot]

commit sha 3e089f388cdb4068fc68bed23a1878fde986d8d7

Bump rack from 2.0.8 to 2.2.3 Bumps [rack](https://github.com/rack/rack) from 2.0.8 to 2.2.3. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](https://github.com/rack/rack/compare/2.0.8...2.2.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Juanito Fatas

commit sha 377df8009b4fc5636cf6fd6b3987d2cb7a039806

Merge pull request #2459 from ruby/dependabot/bundler/rack-2.2.3 Bump rack from 2.0.8 to 2.2.3

view details

push time in a month

delete branch ruby/www.ruby-lang.org

delete branch : dependabot/bundler/rack-2.2.3

delete time in a month

PR merged ruby/www.ruby-lang.org

Bump rack from 2.0.8 to 2.2.3 dependencies

Bumps rack from 2.0.8 to 2.2.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rack/rack/blob/master/CHANGELOG.md">rack's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file. For info on how to format all future additions to this file please reference <a href="https://keepachangelog.com/en/1.0.0/">Keep A Changelog</a>.</p> <h2>[3.0.0] - Unreleased</h2> <h3>Changed</h3> <ul> <li>BREAKING CHANGE: Require <code>status</code> to be an Integer. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1662">#1662</a>, <a href="https://github.com/olleolleolle">@olleolleolle</a>)</li> <li>Relax validations around <code>Rack::Request#host</code> and <code>Rack::Request#hostname</code>. (<a href="https://github-redirect.dependabot.com/rack/rack/issues/1606">#1606</a>, <a href="https://github.com/pvande">@pvande</a>)</li> <li>Removed antiquated handlers: FCGI, LSWS, SCGI, Thin. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1658">#1658</a>, <a href="https://github.com/ioquatix">@ioquatix</a>)</li> <li>Removed options from <code>Rack::Builder.parse_file</code> and <code>Rack::Builder.load_file</code>. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1663">#1663</a>, <a href="https://github.com/ioquatix">@ioquatix</a>)</li> </ul> <h3>Fixed</h3> <ul> <li>Fix using Rack::Session::Cookie with coder: Rack::Session::Cookie::Base64::{JSON,Zip}. (<a href="https://github-redirect.dependabot.com/rack/rack/issues/1666">#1666</a>, <a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li>Avoid NoMethodError when accessing Rack::Session::Cookie without requiring delegate first. (<a href="https://github-redirect.dependabot.com/rack/rack/issues/1610">#1610</a>, <a href="https://github.com/onigra">@onigra</a>)</li> <li>Handle cookies with values that end in '=' (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1645">#1645</a>, <a href="https://github.com/lukaso">@lukaso</a>)</li> </ul> <h2>[2.2.2] - 2020-02-11</h2> <h3>Fixed</h3> <ul> <li>Fix incorrect <code>Rack::Request#host</code> value. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1591">#1591</a>, <a href="https://github.com/ioquatix">@ioquatix</a>)</li> <li>Revert <code>Rack::Handler::Thin</code> implementation. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1583">#1583</a>, <a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li>Double assignment is still needed to prevent an "unused variable" warning. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1589">#1589</a>, <a href="https://github.com/kamipo">@kamipo</a>)</li> <li>Fix to handle same_site option for session pool. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1587">#1587</a>, <a href="https://github.com/kamipo">@kamipo</a>)</li> </ul> <h2>[2.2.1] - 2020-02-09</h2> <h3>Fixed</h3> <ul> <li>Rework <code>Rack::Request#ip</code> to handle empty <code>forwarded_for</code>. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1577">#1577</a>, <a href="https://github.com/ioquatix">@ioquatix</a>)</li> </ul> <h2>[2.2.0] - 2020-02-08</h2> <h3>SPEC Changes</h3> <ul> <li><code>rack.session</code> request environment entry must respond to <code>to_hash</code> and return unfrozen Hash. (<a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li>Request environment cannot be frozen. (<a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li>CGI values in the request environment with non-ASCII characters must use ASCII-8BIT encoding. (<a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li>Improve SPEC/lint relating to SERVER_NAME, SERVER_PORT and HTTP_HOST. (<a href="https://github-redirect.dependabot.com/rack/rack/pull/1561">#1561</a>, <a href="https://github.com/ioquatix">@ioquatix</a>)</li> </ul> <h3>Added</h3> <ul> <li><code>rackup</code> supports multiple <code>-r</code> options and will require all arguments. (<a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li><code>Server</code> supports an array of paths to require for the <code>:require</code> option. (<a href="https://github.com/khotta">@khotta</a>)</li> <li><code>Files</code> supports multipart range requests. (<a href="https://github.com/fatkodima">@fatkodima</a>)</li> <li><code>Multipart::UploadedFile</code> supports an IO-like object instead of using the filesystem, using <code>:filename</code> and <code>:io</code> options. (<a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> <li><code>Multipart::UploadedFile</code> supports keyword arguments <code>:path</code>, <code>:content_type</code>, and <code>:binary</code> in addition to positional arguments. (<a href="https://github.com/jeremyevans">@jeremyevans</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rack/rack/commit/1741c580d71cfca8e541e96cc372305c8892ee74"><code>1741c58</code></a> bump version</li> <li><a href="https://github.com/rack/rack/commit/5ccca4722668083732ea2d35c56565fcc25312f8"><code>5ccca47</code></a> When parsing cookies, only decode the values</li> <li><a href="https://github.com/rack/rack/commit/a5e80f01947954af76b14c1d1fdd8e79dd8337f3"><code>a5e80f0</code></a> Bump version.</li> <li><a href="https://github.com/rack/rack/commit/b0de37dc3b67d2fdcaa8b0236ff076a0a4db0b4f"><code>b0de37d</code></a> Remove trailing whitespace.</li> <li><a href="https://github.com/rack/rack/commit/1a784e54c867d42214d9e1f315651b1f2cea8591"><code>1a784e5</code></a> Prepare CHANGELOG for next patch release.</li> <li><a href="https://github.com/rack/rack/commit/a0d57d4a1d917596e03e0aa969aff7e890d2123c"><code>a0d57d4</code></a> Fix to handle same_site option for session pool</li> <li><a href="https://github.com/rack/rack/commit/a9b223b6781201ae8faa5d0a373cd1a24f6d97a3"><code>a9b223b</code></a> Ensure full match. Fixes <a href="https://github-redirect.dependabot.com/rack/rack/issues/1590">#1590</a>.</li> <li><a href="https://github.com/rack/rack/commit/f4c5645642ec99fa82a5a343a6c79d4aff8d6165"><code>f4c5645</code></a> Double assignment is still needed to prevent an "unused variable" warning</li> <li><a href="https://github.com/rack/rack/commit/5c121dd6853fa231d1b1253b6e8e7cfc927791ca"><code>5c121dd</code></a> Revert "Update Thin handler to better handle more options"</li> <li><a href="https://github.com/rack/rack/commit/961d9761bcb2bee17c80bba8b7bc9e285086d6c4"><code>961d976</code></a> Prepare point release.</li> <li>Additional commits viewable in <a href="https://github.com/rack/rack/compare/2.0.8...2.2.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in a month

startedtoshimaru/rubocop-rails_config

started time in a month

push eventbuildkite/docs

Juanito Fatas

commit sha 4365e28867b3fedf8700f03ed94396e5074a2ec4

Simplify Page#render to render from PagesController Co-Authored-By: Matthew Draper <matthew@trebex.net>

view details

push time in a month

PullRequestEvent

PR closed buildkite/docs

Reviewers
Upgrade most of gems

This PR:

  • Use Rails 6 and other gems
  • Lock rouge because syntax highlight css classes changed (we should upgrade this separately)
  • Simplify Page#render
+89 -94

3 comments

4 changed files

JuanitoFatas

pr closed time in a month

Pull request review commentbuildkite/docs

Upgrade most of gems

 def get_binding     end      def render(*args)-      av = ActionView::Base.new-      av.view_paths = ActionController::Base.view_paths-      av.view_paths << Rails.root.join("app/views/pages").to_s-      av.render(*args)+      ActionController::Base.append_view_path "app/views/pages"+      renderer = ActionController::Base.renderer.new+      renderer.render(partial: args.first)

Thanks! Fixed in 4488f93.

JuanitoFatas

comment created time in a month

PullRequestEvent

PR closed buildkite/docs

Reviewers
Upgrade most of gems

Will this work? 🤔

  • Use Rails 6
  • Lock rouge because syntax highlight css classes changed (we should upgrade this separately)
  • Use ActionController::Base renderer (the first of args are always the partial / view we want to render so it works)
+89 -94

3 comments

4 changed files

JuanitoFatas

pr closed time in a month

push eventbuildkite/docs

Harriet Lawrence

commit sha d101649f41f5a68b3a3174272c74ff0238a95b54

Notes for launchd plist examples

view details

Samuel Wright

commit sha 7841afea568597088a18493caf6c4085c425d8c4

Initial Alex config

view details

Vineet Gopal

commit sha 1a12bd62cdad3266119ce45647f3785bc120dd5a

Fix minor typos

view details

Samuel Wright

commit sha 3a3d4b0c385c8e0a66bcac6f8efb5b4ba85cd5f1

Allow "period"

view details

Samuel Wright

commit sha 50c952809a7e869d37ec0715e5ef6d25c2091aa7

Remove some simple stuff

view details

Vineet Gopal

commit sha 698c193fefe9b23bf7929ebac7b65fbad479d188

Better rewording

view details

Plaindocs

commit sha 29b6229cc7713f5d41e9f08dd5510fae87420c25

Merge pull request #746 from vineetgopal/minor-typos Fix minor typos

view details

Samuel Cochran

commit sha 4a2d9da517d429aa7527a9aefaf826626f04cedb

Remove duplicate TOC

view details

Samuel Wright

commit sha 3b04a033bd6dcb38d71077bd8d2899c74b1eb69b

Agent update for 3.22.1

view details

Plaindocs

commit sha 37461b2728e7a0a358086996fcfa743e202b9f46

Merge branch 'master' into agent-update-3.22.1

view details

Samuel Wright

commit sha b772f6751cb92ca86d8e973a62a66b359184f252

Typos

view details

Samuel Wright

commit sha 568a91c62b3d19b1fd0690c4221126fb0d602038

Merge branch 'agent-update-3.22.1' of github.com:buildkite/docs into agent-update-3.22.1

view details

Harriet Lawrence

commit sha bfa3f508421eabe8bf583aca78cac7579454247e

Notes to sentences, add formatting

view details

Tim Lucas

commit sha 50c93afdb2ccb67ea94cb6184daa2d4ff39743c5

Add a full post-deploy example

view details

Samuel Wright

commit sha 09cb64cf7d6a698d703589a3dfcbdb27c70030a8

Obey the linter

view details

Samuel Wright

commit sha 7a79f731a1e194927fcd5c5b9053dabc487dc18a

Merge remote-tracking branch 'origin/add-heroku-post-deploy-example' into sw-linting-alex

view details

Samuel Wright

commit sha f39c6af5183b97735a4a8bc1758ae747e5241bde

We only use some of the checks for now

view details

Samuel Wright

commit sha d4fba3cc063dbf7f12b15dcefa599c288f244bb8

Run Alex in the pipelines

view details

Samuel Wright

commit sha b191ad61c58878c49fafa2aa797c57388d535c1c

Now with extra command syntax

view details

Samuel Wright

commit sha bcccf6ea53b10d391b7e8408feadcca28c836451

INstall it

view details

push time in a month

startedhashikite/app

started time in a month

more