profile
viewpoint

JoshMcguigan/bubble-shell 51

A simple shell

JoshMcguigan/arr_macro 47

Initialize arrays with ease!

JoshMcguigan/belay 37

Run your CI checks locally to `git push` with confidence

JoshMcguigan/betafpv-f3 33

Board Support Crate for the BetaFPV F3 Drone Flight Controller

JoshMcguigan/amethyst-2d-platformer-demo 32

Demo game using the Amethyst engine

JoshMcguigan/dashr 15

A unix-style utility for responding programmatically to new ethernet devices joining a network

JoshMcguigan/cargo-run-script 9

Bringing `npm run-script` to Rust

JoshMcguigan/alacritty 1

A cross-platform, GPU-accelerated terminal emulator

JoshMcguigan/aoc-2018 1

Advent of Code 2018 - Solutions in Rust

JoshMcguigan/auto-import 1

Rust proc-macro example

issue commentJoshMcguigan/belay

Don't hardcode 'sh' / 'cmd' shells

Hi @nickolay, thanks for the report. Looks like github uses bash with a fallback to sh if bash is not available. I'd be open to a PR implementing this in belay! Bonus if it considers whatever the appropriate behavior for gitlab is.

nickolay

comment created time in 14 days

issue commentJoshMcguigan/arr_macro

Unable to use with locals inside another macro

Hi @drehren thanks for the report. I'm not sure this is directly related to anything being done by arr_macro, but it is interesting nonetheless.

A minimal example (derived from your repo, thanks for posting) follows:

use arr_macro::arr;

struct MyStruct {
    data: u32,
}

impl MyStruct {
    fn new(data: u32) -> Self {
        Self { data }
    }
}

macro_rules! expand {
    ($t:ty) => {{
        let mut i = 0;
        arr![<$t>::new({i += 1; i - 1}); 3]
    }}
}

fn main() {
    let _ = expand!(MyStruct);
}

The above results in the following error:

$ cargo check
    Checking arr_issue v0.1.0 (/home/josh/workspace/rust_arr_macro_bug)
error[E0425]: cannot find value `i` in this scope
  --> src/main.rs:21:13
   |
21 |     let _ = expand!(MyStruct);
   |             ^^^^^^^^^^^^^^^^^ not found in this scope
   |
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for mo
re info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0425`.
error: could not compile `arr_issue`.

To learn more, run the command again with --verbose.

Surprisingly, if I modify the expand macro to hardcode the name of the struct the error goes away:

// modified expand macro that doesn't cause the error
macro_rules! expand {
    ($t:ty) => {{
        let mut i = 0;
        arr![MyStruct::new({i += 1; i - 1}); 3]
    }}
}

I know this modification makes the macro useless, I was just trying to minimize the example as much as I could.

One additional interesting note is that if I use cargo-expand (by @dtolnay ) to expand the original code, the expanded version does compile without error.

drehren

comment created time in 25 days

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha 3fd68dfa8d0480a7104be97f69c8c4f5a5839da5

placeholder keyboard handling for normal window

view details

push time in a month

push eventJoshMcguigan/libps1

Erjan Kalybek

commit sha 26419d5a2fa3702b5cd7f3f8fa6f3434e34c6a96

Fix typo (#7)

view details

push time in 2 months

PR merged JoshMcguigan/libps1

Fix readme typo
+1 -1

1 comment

1 changed file

erjanmx

pr closed time in 2 months

pull request commentJoshMcguigan/libps1

Fix readme typo

Thanks @erjanmx for the contribution!

erjanmx

comment created time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha e4697a664b8b69e8ec3799123cc180c05315dcd0

WIP

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha 3e18a654f1c4d7bcaf4d943c851c98e3bd4bf6fe

temp capture wayland debug

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha 8af931a44bb2832f83a23494ff32c06817058c5b

WIP

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha 370d0e0f55512ae90d30bc090ebbe732e91c2434

WIP

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha a0eb96907eb9d44bc555d698b5b502fcdb92bb3c

WIP

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha 1dc33c26e84bb31a175b705d55803b6a9de15b97

WIP

view details

push time in 2 months

create barnchJoshMcguigan/waysay

branch : normal-window

created branch time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 975a3b19fb9e8d12f532c6d4dba47eab0711bba9

qutebrowser enable pdfjs and create binding for tab pin

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 495dc59724fc2a21e76d1bfde97c9f7ea032db98

set swaynag_command to waysay

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha 7d2744d8de03d5a261ea4905efe67584ec8f07d3

support reading detailed message from std in This does not include updates to the UI to display this detailed message.

view details

push time in 2 months

create barnchJoshMcguigan/waysay

branch : kb-demo

created branch time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha a23d974cd5452176fbf00ce1a99e3366c62358ec

initial commit

view details

push time in 2 months

push eventJoshMcguigan/waysay

Josh Mcguigan

commit sha f6c69423db8f54b976362eb7d6a0e03313ae7185

initial commit

view details

push time in 2 months

create barnchJoshMcguigan/waysay

branch : master

created branch time in 2 months

created repositoryJoshMcguigan/waysay

Native wayland desktop notifications - a drop-in replacement for swaynag written in rust

created time in 2 months

startedSmithay/client-toolkit

started time in 2 months

startedSmithay/andrew

started time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 2c97457ec715567c3213513c34ef0d01812857c0

set border for launcher

view details

push time in 2 months

issue commentswaywm/sway

swaynag: infinite loop on POLLHUP

I am also seeing this issue on Arch with Sway 1.4.

It is very repeatable, as OP describes.

  1. Break my sway config
  2. reload the config
  3. swaynag will consume 100% and leak memory
  4. fixing config and reloading sway does not make the sway nag process exit

This happens on my laptop without an external display attached.

    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND                   
  65277 josh      20   0   78740  60876   4924 R 100.0   0.4   0:04.75 swaynag                   

$ ls -l /proc/65277/fd
total 0
lr-x------ 1 josh users 64 Jun 21 19:11 0 -> 'pipe:[663938]'
lrwx------ 1 josh users 64 Jun 21 19:11 1 -> /dev/tty1
lrwx------ 1 josh users 64 Jun 21 19:11 12 -> /dev/dri/card0
lrwx------ 1 josh users 64 Jun 21 19:11 2 -> /dev/tty1
lr-x------ 1 josh users 64 Jun 21 19:11 48 -> /home/josh/workspace/dotfiles/config/sway/config
lrwx------ 1 josh users 64 Jun 21 19:11 99 -> 'socket:[663940]'

$ sudo strace -p 65277
strace: Process 65277 attached
poll([{fd=99, events=POLLIN}], 1, -1)   = 1 ([{fd=99, revents=POLLIN|POLLHUP}])

As stated by OP the poll shows up in strace thousands of times per second.

jfchevrette

comment created time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 7cc75bd00488b061bf421f9d2e4e908b1027fa91

update launcher config to remove some items that compgen included

view details

push time in 2 months

issue commentJoshMcguigan/libps1

Please don't hardcode the use of tico to shorten the working directory

There is are a couple other issues with the tico integration.

Firstly, we are using tico v1, but there is a v2 now.

The upside is that v2 handles replacing the home directory with ~, which is functionality that we are currently implementing. But it doesn't support using a custom string (rather than ~). We currently allow using any string as the home directory replacement, but if the user has also enabled cwd_shorten_directories with a custom home directory replacement which is longer than 1 character, only the first character would be displayed. This is a bug with our current setup, and switching to tico v2 wouldn't help fix it.

I think a reasonable solution here is to "fork" the tico codebase into a module within this repo, and make the necessary changes to support replacing the home directory with a string of arbitrary length.

joshtriplett

comment created time in 2 months

issue commentgreshake/i3status-rust

simply stops updating

@ammgws Do you think it is appropriate to solve this by spawning a thread per block, and allowing each block to update the main thread by sending new data back over a channel or something? I haven't looked at the source code yet, so I'm not sure if this approach would be totally impractical for some reason, just wanted to get some insight if you had already been thinking about solutions for this.

colemickens

comment created time in 2 months

issue commentjonhoo/rust-imap

Support BODYSTRUCTURE parsing for FETCH results

Ah, yes I'd think so :+1:

lberezy

comment created time in 2 months

issue commentjonhoo/rust-imap

Support BODYSTRUCTURE parsing for FETCH results

I believe this functionality was merged in tokio-imap with https://github.com/djc/tokio-imap/pull/48.

lberezy

comment created time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha 5cf6caf9cee858e1e010733fcc7be098c970ab35

add zsh usage to readme

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha 1095794b2907a96b0179dcc6be22ddfbbf3eba5d

add zsh usage to readme

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha d9e9e64ac2b29fe2cfc286b8908bd27d2ec36e7e

add zsh usage to readme

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha ba8601a799af82d1d8c391c4d98323ca8609a1af

remove unwraps in git handling

view details

push time in 2 months

delete branch JoshMcguigan/libps1

delete branch : ansi-color-sequences

delete time in 2 months

issue closedJoshMcguigan/libps1

Please support wrapping ANSI escape sequences in PS1

The issue at https://github.com/NerdyPepper/pista/issues/3 , referenced in the source, occurs because the ANSI color sequences take up zero width, and readline/bash expect them to take up width. bash has a method of dealing with this: if you surround all the ANSI color sequences (but not any printing characters) in \[ and \], bash will assume they take up zero width. libps1 could support emitting these sequences in the output. ansi_term does support this: instead of calling paint, print \[, then some_style.prefix(), then \], then the text, then \[, then some_style.suffix(), then \].

closed time in 2 months

joshtriplett

issue commentJoshMcguigan/libps1

Please support wrapping ANSI escape sequences in PS1

Closed in #6

joshtriplett

comment created time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha c0132491373c7d2fcfb7b3f8b6cad34e2f562632

Allow configuring prompt char separator (#6) * improve ansi color sequence output (#3) * allow configuring prompt char separator

view details

push time in 2 months

pull request commentJoshMcguigan/libps1

Allow configuring prompt char separator

Good to know that Style::default() produces no styles. I had been thinking about whether all of the Color configuration options should be Style, but the main hurdle is it seems like it would be less ergonomic to use (for users creating a custom configuration).

The more I think about it, the more this seems worth doing, but it would turn each Blue into Blue.normal() (taking blue as an arbitrary example) within a configuration.

JoshMcguigan

comment created time in 2 months

delete branch JoshMcguigan/libps1

delete branch : optional-shorten-cwd

delete time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha ec842860083c2421536f82d5812731143d090e94

update github URL in readme example

view details

Josh Mcguigan

commit sha aeb642b9167dafc07e3c2a80b7c1ddc9cf6d42d1

improve ansi color sequence output (#3)

view details

Josh Mcguigan

commit sha 11da8d7266fb9f9974405c1349148c6da49dafe7

allow configuring prompt char separator

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha ec842860083c2421536f82d5812731143d090e94

update github URL in readme example

view details

push time in 2 months

PR opened JoshMcguigan/libps1

Allow configuring prompt char separatorjjjj

Closes #2 and #3

Introduces a new configuration option, prompt_char_separator, to allow configuring the prompt character to be on the same line as the preceding text (as opposed to the default two line configuration).

Doing this required fixing the ansi color code handling.

In the future, I'd like to allow customizing the color of the prompt, or perhaps setting the color automatically based on the status code of the previous command. I did not do this because by default I think I'd like this to be the standard text color in the terminal (i.e. uncolored). An option here would be to allow this color to be Option<Color>, but that would be different than the other color configurations. I'm also not sure what API would make sense for allowing a user to specify either a color, default color, or color based on previous status code. Perhaps a custom enum is necessary here. In any event, this is out of scope for this PR.

cc @joshtriplett

+48 -20

0 comment

3 changed files

pr created time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha fd033936d7dbb8c7e047b0a0e440e7b626e50b9d

allow configuring prompt char separator

view details

push time in 2 months

create barnchJoshMcguigan/libps1

branch : ansi-color-sequences

created branch time in 2 months

issue commentJoshMcguigan/libps1

Please don't hardcode the use of tico to shorten the working directory

As of #5, this is configurable. But I'm leaving this issue open to track the option of making the tico dependency optional.

joshtriplett

comment created time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha 0e8cb26d1b3274b4756e51d4b9d6c14b60825499

Make current working directory shortening configurable (#5) * include configuration for how the working directory is displayed * update cwd shorten option names based on PR feedback

view details

push time in 2 months

PR merged JoshMcguigan/libps1

Make current working directory shortening configurable

This is related to #4. I'll leave #4 open because this doesn't make the tico dependency optional, and I still want to come back to look at that again, but as part of a different PR.

@joshtriplett I'd be interested in any feedback you have here.

+44 -23

3 comments

3 changed files

JoshMcguigan

pr closed time in 2 months

pull request commentJoshMcguigan/libps1

Make current working directory shortening configurable

Regarding making tico optional, the idea I had in mind was to add a feature flag to libps1 that controlled the tico dependency, and if disabled, that would also disable the use of it. (libps1::Prompt could then assert_eq!(shorten_cwd_components, false) if that feature flag was not set, with an explanatory message, or alternatively make the field just not exist without the feature flag.)

Yep, this makes sense to me. I just went to look at the tico source and it was about to send me down a (admittedly shallow) rabbit hole (for one, we are using tico version 1, and there is a version 2 now), so I wanted to push that off until after some of these higher priority items are taken care of.

JoshMcguigan

comment created time in 2 months

Pull request review commentJoshMcguigan/libps1

Make current working directory shortening configurable

 impl Default for Prompt {             git_status_clean_icon: "✓",             git_status_unstaged_icon: "×",             git_status_staged_icon: "±",+            shorten_cwd: false,

Good call on clarifying this, I went with shorten_cwd_directories.

JoshMcguigan

comment created time in 2 months

Pull request review commentJoshMcguigan/libps1

Make current working directory shortening configurable

 impl Default for Prompt {             git_status_clean_icon: "✓",             git_status_unstaged_icon: "×",             git_status_staged_icon: "±",+            shorten_cwd: false,+            shorten_home_cwd: Some("~"),

I really like the consistent prefix idea, so I took it a bit further and went with cwd_shorten_home so this will also be consistent with cwd_color.

JoshMcguigan

comment created time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha 51249c4ba06cef68163ccf76a54548cec1598847

update cwd shorten option names based on PR feedback

view details

push time in 2 months

PR opened JoshMcguigan/libps1

Make current working directory shortening configurable

This is related to #4. I'll leave #4 open because this doesn't make the tico dependency optional, and I still want to come back to look at that again, but as part of a different PR.

@joshtriplett I'd be interested in any feedback you have here.

+38 -15

0 comment

3 changed files

pr created time in 2 months

create barnchJoshMcguigan/libps1

branch : optional-shorten-cwd

created branch time in 2 months

startedportocodes/tico

started time in 2 months

issue commentJoshMcguigan/libps1

Configurable non-hardcoded newline?

First off, thanks for all of your feedback. I appreciate you making separate issues for them as well, so they can be tracked individually. I'd certainly like to add this configuration option, and I agree it is blocked (hopefully not for long) by #3.

As for the Option<&'static str>, is there a reason you prefer this to just a &'static str? In that case, it can still default to \n, but a user could overwrite with "" (empty string), " " (single whitespace), or whatever they prefer. Or perhaps even simpler, pista just had a boolean to optionally include the newline. Is there a benefit to the additional flexibility (and minor complexity) of using a string rather than a boolean to configure this?

joshtriplett

comment created time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha bb0c3f15ef6b2c1d3037bb5a9976944394533df5

qute browser load autoconfig, coc python use mpls

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha f8f572df86c5ece4717e8a556566552abeb0e3a3

update readme and example to include icon configuration

view details

Josh Mcguigan

commit sha dbe98d3f9ef2dddb2a875e9037637ce85240476d

rename README

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha d174a066e2f461890eee447c944ff4a4e29e0aab

use static string for icon config rather than boxed display trait

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha a433cd9b2efef3e7383b29ee03ce7ca53dfce9ca

update icon for clean git, make icons configurable

view details

push time in 2 months

push eventJoshMcguigan/libps1

Prabhanjan

commit sha 9ef9c7a50a57c9a0baa9accd01866d0d08ded6f7

[fix] spelling mistake

view details

Josh Mcguigan

commit sha 331edc42f2f784517f77e4e0a5dc927c40f64e7c

Merge pull request #1 from Sparkenstein/master [fix] spelling mistake

view details

push time in 2 months

PR merged JoshMcguigan/libps1

[fix] spelling mistake

The dependency URL was incorrect.

+1 -1

1 comment

1 changed file

Sparkenstein

pr closed time in 2 months

pull request commentJoshMcguigan/libps1

[fix] spelling mistake

Good eye! And thanks for the contribution!

Sparkenstein

comment created time in 2 months

pull request commentservo/rust-url

Unsafe audit

I've rebased and updated this based on the latest changes. Let me know if this needs anything else.

JoshMcguigan

comment created time in 2 months

Pull request review commentservo/rust-url

Unsafe audit

 impl<'a> Iterator for ByteSerialize<'a> {                 None => (self.bytes, &[][..]),             };             self.bytes = remaining;+            // This unsafe is appropriate because we have already checked these+            // bytes in byte_serialized_unchaged, which checks for a subset

Good catch, I've fixed this.

JoshMcguigan

comment created time in 2 months

push eventJoshMcguigan/rust-url

Josh Mcguigan

commit sha 8dfa679829359e93ec5b0d4c4d461637fb540598

unsafe audit

view details

push time in 2 months

push eventJoshMcguigan/rust-url

Josh Mcguigan

commit sha fa1d0ffa390a08969334870fea6abd333f3a0508

unsafe audit

view details

push time in 2 months

push eventJoshMcguigan/rust-url

Simon Sapin

commit sha 661eba3eed41c88fe84eaf48db18dbf22d731f97

Increment MSVR to 1.36.0 … because `unicode-normalization` did. Fixes https://github.com/servo/rust-url/issues/566 Closes https://github.com/servo/rust-url/pull/572

view details

Valentin Gosu

commit sha 622d26020491aa08c5a3c10ace046b2f35274576

Merge pull request #573 from servo/msvr Increment MSVR to 1.36.0

view details

Anthony Ramine

commit sha 1655a7601198c657dcd484881710d6b3973bbbb3

Update tests from wpt The two json files were taken from web-platform-tests/wpt@e69af8258d25011f3bdb7577323dcb98880445ea > test result: FAILED. 624 passed; 89 failed; 0 ignored; 0 measured

view details

Anthony Ramine

commit sha fa9f04487b3f3404281ae42dcbbab2d88a5144de

Fix percent encoding of fragments (closes #491) > test result: FAILED. 637 passed; 76 failed; 0 ignored; 0 measured

view details

Anthony Ramine

commit sha 412266a2f838ff009d2c1103ad7b93bea0a43478

Refactor parse_file to look more like the spec

view details

Anthony Ramine

commit sha e93f999dc5f6f8de61ccf6fe79cc8d11774f08b8

Fix a Windows quirk > test result: FAILED. 640 passed; 73 failed; 0 ignored; 0 measured

view details

Anthony Ramine

commit sha efe9ab98888e0229315c56b684f0e3fa8d40ca0d

Properly copy hosts of base file:// URLs when needed > test result: FAILED. 642 passed; 71 failed; 0 ignored; 0 measured

view details

Jeremy Lempereur

commit sha 54a158b7a239a4cca5c1c142aaafe4474a18ed4a

Path and file parsing.

view details

Jeremy Lempereur

commit sha 0586854c8b778c9d14bccd1a0213bc2263e9345a

Host parsing rules.

view details

Jeremy Lempereur

commit sha 26ccc0d6ea46b9d244f6015177f29958fb0f84c3

Hash getter and setter.

view details

Jeremy Lempereur

commit sha 7efdc53193adfdfd65c1d39bc7ad4762dd4c272b

Fix scheme setter > test result: FAILED. 650 passed; 63 failed; 0 ignored; 0 measured

view details

o0Ignition0o

commit sha 736d7bc7c305e2ea9f4b152d67b852d346a64ca8

removing unused imports.

view details

o0Ignition0o

commit sha a9ca033439001d05154dc4afd053570f4bfc0928

Pleasing the 1.33.0 borrow checker.

view details

o0Ignition0o

commit sha 8ef48471a8f82658fbb2eddad4a785ba54122d2e

Make sure a windows drive letter segment always ends with a slash.

view details

Jeremy Lempereur

commit sha aeef54febed316165625321a6aaf54eabbd906d8

trim file paths if needed.

view details

Jeremy Lempereur

commit sha 925ec94a6d0e2c3e66289f9922f90726d6b21e7f

Avoid allocation when checking for windows drive letters.

view details

o0Ignition0o

commit sha 446484009e49caca8147ba32cd7125c260d0246a

Comments and nits fixups.

view details

Valentin Gosu

commit sha 9cd6467b985600449031ded046fefe0bb6f55939

Merge pull request #537 from o0Ignition0o/40_tests_left Pass "new" tests

view details

Valentin Gosu

commit sha 159357866543d8017990e1cac92fb635610f1803

Update version to 2.1.1 PR #537 fixed a large number of issues which affected compliance with the URL spec. We should release a new crate version with these changes.

view details

bors-servo

commit sha f091d2b45b79958f9a40e2b98b844f75df6723de

Auto merge of #575 - valenting:version-2.1.1, r=SimonSapin Update version to 2.1.1 PR #537 fixed a large number of issues which affected compliance with the URL spec. We should release a new crate version with these changes.

view details

push time in 2 months

push eventJoshMcguigan/rust-url

Simon Sapin

commit sha 661eba3eed41c88fe84eaf48db18dbf22d731f97

Increment MSVR to 1.36.0 … because `unicode-normalization` did. Fixes https://github.com/servo/rust-url/issues/566 Closes https://github.com/servo/rust-url/pull/572

view details

Valentin Gosu

commit sha 622d26020491aa08c5a3c10ace046b2f35274576

Merge pull request #573 from servo/msvr Increment MSVR to 1.36.0

view details

Anthony Ramine

commit sha 1655a7601198c657dcd484881710d6b3973bbbb3

Update tests from wpt The two json files were taken from web-platform-tests/wpt@e69af8258d25011f3bdb7577323dcb98880445ea > test result: FAILED. 624 passed; 89 failed; 0 ignored; 0 measured

view details

Anthony Ramine

commit sha fa9f04487b3f3404281ae42dcbbab2d88a5144de

Fix percent encoding of fragments (closes #491) > test result: FAILED. 637 passed; 76 failed; 0 ignored; 0 measured

view details

Anthony Ramine

commit sha 412266a2f838ff009d2c1103ad7b93bea0a43478

Refactor parse_file to look more like the spec

view details

Anthony Ramine

commit sha e93f999dc5f6f8de61ccf6fe79cc8d11774f08b8

Fix a Windows quirk > test result: FAILED. 640 passed; 73 failed; 0 ignored; 0 measured

view details

Anthony Ramine

commit sha efe9ab98888e0229315c56b684f0e3fa8d40ca0d

Properly copy hosts of base file:// URLs when needed > test result: FAILED. 642 passed; 71 failed; 0 ignored; 0 measured

view details

Jeremy Lempereur

commit sha 54a158b7a239a4cca5c1c142aaafe4474a18ed4a

Path and file parsing.

view details

Jeremy Lempereur

commit sha 0586854c8b778c9d14bccd1a0213bc2263e9345a

Host parsing rules.

view details

Jeremy Lempereur

commit sha 26ccc0d6ea46b9d244f6015177f29958fb0f84c3

Hash getter and setter.

view details

Jeremy Lempereur

commit sha 7efdc53193adfdfd65c1d39bc7ad4762dd4c272b

Fix scheme setter > test result: FAILED. 650 passed; 63 failed; 0 ignored; 0 measured

view details

o0Ignition0o

commit sha 736d7bc7c305e2ea9f4b152d67b852d346a64ca8

removing unused imports.

view details

o0Ignition0o

commit sha a9ca033439001d05154dc4afd053570f4bfc0928

Pleasing the 1.33.0 borrow checker.

view details

o0Ignition0o

commit sha 8ef48471a8f82658fbb2eddad4a785ba54122d2e

Make sure a windows drive letter segment always ends with a slash.

view details

Jeremy Lempereur

commit sha aeef54febed316165625321a6aaf54eabbd906d8

trim file paths if needed.

view details

Jeremy Lempereur

commit sha 925ec94a6d0e2c3e66289f9922f90726d6b21e7f

Avoid allocation when checking for windows drive letters.

view details

o0Ignition0o

commit sha 446484009e49caca8147ba32cd7125c260d0246a

Comments and nits fixups.

view details

Valentin Gosu

commit sha 9cd6467b985600449031ded046fefe0bb6f55939

Merge pull request #537 from o0Ignition0o/40_tests_left Pass "new" tests

view details

Valentin Gosu

commit sha 159357866543d8017990e1cac92fb635610f1803

Update version to 2.1.1 PR #537 fixed a large number of issues which affected compliance with the URL spec. We should release a new crate version with these changes.

view details

bors-servo

commit sha f091d2b45b79958f9a40e2b98b844f75df6723de

Auto merge of #575 - valenting:version-2.1.1, r=SimonSapin Update version to 2.1.1 PR #537 fixed a large number of issues which affected compliance with the URL spec. We should release a new crate version with these changes.

view details

push time in 2 months

push eventJoshMcguigan/rust-url

Josh Mcguigan

commit sha bde25a95b7ffc0de332bff4cf9cf295a3a644442

unsafe audit

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 57f3e4e94c36c6be4802361f61097c30853c932e

run clippy on save in rust projects

view details

push time in 2 months

push eventJoshMcguigan/libps1

Josh Mcguigan

commit sha 9a2057d74a36bed192b7980f5389b12f0d698171

add screenshot to readme

view details

push time in 2 months

startedemersion/slurp

started time in 2 months

startedemersion/grim

started time in 2 months

pull request commentmackwic/colored

WIP: fix count for gnu readline

I can confirm that I had been using a version of pista which included this fix.

Also, I've recently been working on a shell prompt project of my own using ansi_term, and I can confirm ansi_term also has this issue.

I'd probably switch from ansi_term to colored for my own library if this fix were merged, as I currently have some limitations in place to work around this issue.

But I understand that this might be a niche use-case, and breaking away from the "reference implementation" isn't a decision to be taken lightly.

JoshMcguigan

comment created time in 2 months

create barnchJoshMcguigan/libps1

branch : master

created branch time in 2 months

created repositoryJoshMcguigan/libps1

An experimental shell prompt library

created time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 6956ff99eb9ec14fed339975d30e64751d533f8f

update shell prompt to use nord theme explicitly

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 8bd9205d0706ba10e5ef492f23db0497e0ee2134

style updates (nord theme)

view details

push time in 2 months

startedarcticicestudio/nord-vim

started time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 949007477d9f2aaf91baba025ad519e709b23df8

update fonts

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha f17817826b4e22f480433292a698043a3b2a0649

update color schemes

view details

push time in 2 months

startedcocopon/iceberg.vim

started time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha b465b64a760c377924cc0698e58c8cea2b02b9ad

configure git to rebase on pull

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha ff6553638b743fd92e50f148ec9ce813cf9055e2

initial commit

view details

push time in 2 months

startedswaywm/sway

started time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 27819a8f322a439119e381e64832742018d9a9ba

initial commit

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha c113dea6c386adeb074b3607f96b893f6c8a4fa0

initial commit

view details

push time in 2 months

push eventJoshMcguigan/dotfiles

Josh Mcguigan

commit sha 097ae3f1b0b99a458add7e1026de65842d2ed03b

initial commit

view details

push time in 2 months

create barnchJoshMcguigan/dotfiles

branch : master

created branch time in 2 months

created repositoryJoshMcguigan/dotfiles

created time in 2 months

startedgreshake/i3status-rust

started time in 2 months

issue commenthaikarainen/light

READ BEFORE YOU CREATE AN ISSUE: Arch package is broken

I can confirm adding myself to the video group and restarting solved the issue for me on arch.

haikarainen

comment created time in 2 months

issue commentSmithay/smithay

cargo build fails on fedora 29

I can confirm that libxkbcommon-devel, libinput-devel, and mesa-libgbm-devel are still the necessary dependencies on fedora 32.

rokit

comment created time in 2 months

pull request commentSmithay/wayland-rs

modernize simple_window example

Sounds good to me. I've reverted the ? back to .unwrap().

JoshMcguigan

comment created time in 2 months

push eventJoshMcguigan/wayland-rs

Josh Mcguigan

commit sha 5a59651349df4b3e988086ab893785c335d8628c

revert to unwrap

view details

push time in 2 months

push eventJoshMcguigan/dotvim

Josh Mcguigan

commit sha 5bf03f8e68c2d2787887bac6879220a7b7e8f537

load out dir

view details

push time in 2 months

PR opened Smithay/wayland-rs

modernize simple_window example

This follows #336 further modernizing the simple_window example.

  • remove extern crate
  • remove macro_use
  • nested use statements
  • replace unwraps with ? by returning Result from main
  • correct or allow all clippy lints

Let me know if there is anything you don't like in here. I also tried to update/extend the comments, but my wayland knowledge is minimal so there wasn't much I could do there. I'd be happy to do this for the remaining examples if there is interest in that.

+29 -24

0 comment

1 changed file

pr created time in 2 months

create barnchJoshMcguigan/wayland-rs

branch : josh/simple_window-example-updates

created branch time in 2 months

push eventJoshMcguigan/wayland-rs

Tadeo Kondrak

commit sha f9e80f8e77687a15daa9d3542fdcac87b53ac208

scanner: parse event type from xml See https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/82. Once protocol files are updated, this will remove the need for workarounds to specify these separately.

view details

Josh Mcguigan

commit sha 379c89b79c7c8b0801227581506e8292b4b6ad75

remove byteorder dependency for wayland-client example

view details

push time in 2 months

more