profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/HelioStrike/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sai Sandeep Mutyala HelioStrike Hyderabad, Telangana, India heliostrike.github.io Final year Computer Science student at Keshav Memorial Institude of Technology, Hyderabad.

eonr/CompVision 1

Some of my computer vision notebooks

HelioStrike/30-seconds-of-swift-code 0

A Swift implementation of 30-seconds-of-code: A curated collection of useful Swift 4 snippets that you can understand in 30 seconds or less.

startedtypesense/typesense

started time in 17 days

Pull request review commentaws/aws-cdk

fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token

 describe('import', () => {     expect(stack).not.toHaveResource('AWS::Elasticsearch::Domain');   }); +  test('static fromDomainAttributes(attributes) with token arn and endpoint does not throw validation error', () => {+    const domainArn = new CfnParameter(stack, 'domainArn', { type: 'String' }).valueAsString;+    const domainEndpoint = new CfnParameter(stack, 'domainEndpoint', { type: 'String' }).valueAsString;++    expect(() => {+      Domain.fromDomainAttributes(stack, 'Domain', { domainArn, domainEndpoint });+    }).not.toThrowError(/Invalid URL/);

Checked equality with the CfnParameters. I'm new to this repo, so not sure how to turn concrete values into Tokens and then use them.

HelioStrike

comment created time in a month

PullRequestReviewEvent

pull request commentaws/aws-cdk

fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token

@BenChaimberg Updated the PR. Had to change modes due to some permission issue with yarn. Reverted it now, and also modified tests to check equality. Also, when modifying a PR, should I force push modified commits, or add a commit on top?

HelioStrike

comment created time in a month

push eventHelioStrike/aws-cdk

Thorsten Hoeger

commit sha f23877930dfe785a4567986f25ac36caa6b72570

feat(pipelines): add pre-install commands to asset action (#15067) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

Niranjan Jayakar

commit sha 0fe236a14bbcaab70b1af7348ba6cf578fbb93cf

chore: clarify PR title and message in the contribution guide (#15225) Previously, the format was focused on the commit message. Apply the same rules, instead, to the pull request title and message. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

Kaito Udagawa

commit sha a760173feaf70af51f0cec4140b4c8124a2c6aed

chore(integ): correct --silent flag in yarn workspaces info (#15175) ## Overview The `--silent` flag in `yarn workspaces info` does not works. The `--json` flag is suggested in https://github.com/yarnpkg/yarn/issues/7881. The output of `yarn workspaces --json info` is as follows and requires `JSON.parse()` twice: ``` {"type":"log","data":"{\n \"aws-cdk-lib\": {\n \"location\" --- snip --- \"workspaceDependencies\": [],\n \"mismatchedWorkspaceDependencies\": []\n }\n}"} ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

Ross

commit sha 7bc6c6eb14ee73c490caa649aeff509e34eb2c52

feat(dynamodb): allow using Kinesis stream in Table (#15199) Add support for Kinesis Streams in DynamoDB tables with a new `kinesisStreamArn` table option. Closes #14534 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

Adam Ruka

commit sha 16b8a4e24d13948c9a7092df183693ddd2d4be0b

fix(core): parsing an ARN with a slash after a colon in the resource part fails (#15166) New-style ARNs are of the form `'arn:aws:s4:us-west-1:12345:/resource-type/resource-name'`. We didn't handle that correctly in `parseArn()`, and instead returned an `undefined` resource, which funnily enough should never happen according to our types. Introduce the concept of ARN formats, represented by an enum in core, and replace the `Stack.parseArn()` method by a new one `Stack.splitArn()`, taking that enum as a required second argument. Spotted in https://github.com/aws/aws-cdk/pull/15140/files#r653112073 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

arcrank

commit sha ce727c18cdd456feb5645a9b534f2844bf2c86f8

fix(servicecatalog): Portfolio fails validation when passed Tokens as its properties (#15208) We currently do not check if inputs are token when validating them which might throw errors if it is given a `ref`, adding them in here and corresponding unit tests that do not throw validation errors when given tokens with invalid inputs. Also updated one test which had mismatched description. Also moved core to qualified import for better consistency. Testing done ------------------ * `yarn build && yarn lint & yarn test` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

arcrank

commit sha 881737c30f14995e593d56c484a5616e69cf35d3

feat(servicecatalogappregistry): initial L2 construct for Application (#15140) Service Catalog AppRegistry application construct initial base version. Please note the ARNS for this construct have two '/' in them hence the slightly different ARN parsing. Testing done ------------------ * `yarn build && yarn test` * `yarn integ` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Co-authored-by: Dillon Ponzo <dponzo18@gmail.com>

view details

Sai Sandeep Mutyala

commit sha c67b10b3c66ff7c5e82348e62307dd0ffb60fe96

Merge branch 'master' into domainattributes

view details

push time in a month

pull request commentaws/aws-cdk

fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token

@BenChaimberg Updated the PR. Had to change modes due to some permission issue with yarn. Reverted it now, and also modified tests to check equality. Also, when modifying a PR, should I force push modified commits, or add a commit on top?

HelioStrike

comment created time in a month

push eventHelioStrike/aws-cdk

Dillon O'Donovan

commit sha af53798d8fdd7d244da344585602f4f24c09806b

fix(stepfunctions-tasks): checking for task token in EcsRunTask containerOverrides causes memory explosion (#15187) EcsRunTask containerOverrides had references to the entire construct tree causing a large amount of recursion when trying to validate that the task token was provided in the waitForTaskToken integration pattern. The only place for the task token to appear is in the environment of a containerOverride, so we should only check for it there. I also updated the error to mention JsonPath instead of Context since Context is deprecated. In addition to the unit tests, I packaged the library to dotnet and succesfully synthed the minimal reproduction. thanks to @BenChaimberg for providing the suggested fix fixes #15124 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

Ben Chaimberg

commit sha 8ed088a4cc5388b85776c3486cb657462836d923

chore(stepfunctions): deprecate InputPath.fromDataAt, fromContextAt (#15209) The [`fromDataAt`](https://github.com/aws/aws-cdk/blob/af53798d8fdd7d244da344585602f4f24c09806b/packages/%40aws-cdk/aws-stepfunctions/lib/input.ts#L44) and [`fromContextAt`](https://github.com/aws/aws-cdk/blob/af53798d8fdd7d244da344585602f4f24c09806b/packages/%40aws-cdk/aws-stepfunctions/lib/input.ts#L55) static methods in InputPath are functionally equivalent to [`fromJsonPathAt`](https://github.com/aws/aws-cdk/blob/af53798d8fdd7d244da344585602f4f24c09806b/packages/%40aws-cdk/aws-stepfunctions/lib/input.ts#L33) and exist as legacy names from when we had separate Data and Context objects that provided JSON path functionality. Since these objects no longer exist, having three methods that all do the exact same thing is confusing to our users and should be deprecated in favour of the preferred method. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

Taehyun Kim

commit sha 0556e6b710c53dacf6b65926b4cc5b82fb082ee6

feat(eks): taints for managed node groups (#14792) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

view details

HelioStrike

commit sha d6aad5486534566b79fab392a6af3338e2e71108

fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token

view details

push time in a month

push eventHelioStrike/aws-cdk

HelioStrike

commit sha 2b2182f994bd32bcd12446191d12d446121bf7fc

fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token

view details

push time in a month

PR opened aws/aws-cdk

fix(elasticsearch): Domain.fromDomainAttributes gives "Invalid URL" when endpoint is a token

Closes #15188.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

+12 -3

0 comment

2 changed files

pr created time in a month

create barnchHelioStrike/aws-cdk

branch : domainattributes

created branch time in a month

fork HelioStrike/aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

fork in a month

issue openedaws/aws-cdk

(@aws-cdk/aws-elasticsearch): Domain.fromDomainAttributes gives "Invalid URL"

<!-- description of the bug: -->

I'm getting a Invalid URL when trying to use Domain.fromDomainAttributes with a CfnDomain object. The CfnDomain object was retrieved from a CfnInclude object. Here's the snippet of code that's failing for me.

private getDomainFromTemplate(name: string, cfnTemplate: CfnInclude): IDomain {
    const cfnDomain = cfnTemplate.getResource(name) as CfnDomain;
    return Domain.fromDomainAttributes(this, name, {domainArn: cfnDomain.attrArn, domainEndpoint: cfnDomain.attrDomainEndpoint});
}

Reproduction Steps

Here's some minimal code that causes the bug.

import * as elasticsearch from '@aws-cdk/aws-elasticsearch';

const domain = new elasticsearch.CfnDomain(this, "domain", {
    domainName: "domainName"
});
elasticsearch.Domain.fromDomainAttributes(this, name, {domainArn: domain.attrArn, domainEndpoint: domain.attrDomainEndpoint});

<!-- minimal amount of code that causes the bug (if possible) or a reference.

The code sample should be an SSCCE. See http://sscce.org/ for details. In short, provide a code sample that we can copy/paste, run and reproduce. -->

What did you expect to happen?

The error shouldn't happen and the Domain object should be successfully created.

What actually happened?

<!-- What is the unexpected behavior you were seeing? If you got an error, paste it here. -->

internal/url.js:257
  throw new ERR_INVALID_URL(input);
  ^

TypeError [ERR_INVALID_URL]: Invalid URL: ${Token[TOKEN.1766]}
    at onParseError (internal/url.js:257:9)
    at new URL (internal/url.js:333:5)
    at extractNameFromEndpoint (/Users/saimuty/workplace/dr_infra/src/JuryDisputeResolutionNAWSCDK/node_modules/monocdk/lib/aws-elasticsearch/lib/domain.js:946:26)
    at Function.fromDomainAttributes (/Users/saimuty/workplace/dr_infra/src/JuryDisputeResolutionNAWSCDK/node_modules/monocdk/lib/aws-elasticsearch/lib/domain.js:903:28)

Environment

  • CDK CLI Version : 1.107.0 (build 52c4434)
  • Framework Version: 1.107.0 (build 52c4434)
  • Node.js Version: v12.21.0
  • OS : MacOS Big Sur 11.4
  • Language (Version): Typescript (4.0.5)

This is :bug: Bug Report

created time in a month