profile
viewpoint
Garth Braithwaite GarthDB @adobe Idaho Falls http://www.garthdb.com Product Designer and Front End Developer at @adobe on the PhoneGap Team; working on @topcoat. Founded @DesignOpen.

adobe/spectrum-css 699

The standard CSS implementation of the Spectrum design language.

GarthDB/Brackets-Stylus 18

An extension to add Stylus support to Brackets

connatser/hera 14

Hera, an elegant and easy to use static web site architecture.

GarthDB/Beautiful-Rectangles 12

A set of templates for UX Design workflows.

adrocknaphobia/Brackets-Vanity 4

Brackets project website.

GarthDB/Brackets-UI-Prototypes 3

UI Prototypes and works in progress on Brackets

adobe/focus-ring-polyfill 2

A simple polyfill for the `:focus-ring` spec

GarthDB/brackets-inline-color-editor 2

An inline color editor extension for brackets built in CoffeeScript, Jade, and Stylus

adobe/spectrum-css-grid 1

A CSS-Grid implementation of the Spectrum Design Language's grid system.

fork GarthDB/hyperterm-visor

Open your Hyper terminal from anywhere with a global hotkey.

fork in 2 days

issue commentbitfocus/companion-module-requests

Z Camera

Last I checked in the api there isn't full tally control. You can turn on and off the led indicator

GarthDB

comment created time in 4 days

push eventGarthDB/dotfiles

garthdb

commit sha 9f6aed77a0ee249b00c8888eccf6bc77a43059dd

added atem and hyper settings

view details

Garth Braithwaite

commit sha 11f6e0c4871a40b61668f410e4ad3c2c04e06d0e

merged with master

view details

push time in 5 days

issue openedadobe/spectrum-css

Finish matrix and prioritize items

created time in 6 days

issue openedadobe/spectrum-css

PoC update VRT to use SVG as baseline.

Instead of just Visual Regression, let's research if we can use SVGs generated from DNA values as the baseline screenshots.

created time in 6 days

delete branch adobe/spectrum-css

delete branch : tray

delete time in 7 days

PR opened adobe/spectrum-css

fix: added modal to tray component

Description

There are no tokens for tray bg so I brought in Modal to bring in the missing styles.

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+5 -6

0 comment

3 changed files

pr created time in 7 days

push eventadobe/spectrum-css

garthdb

commit sha 4a9a38c7f40a3ab14c5123e8c8be160c3c93036d

fix: added modal to tray component

view details

push time in 7 days

create barnchadobe/spectrum-css

branch : tray

created branch time in 7 days

delete branch adobe/spectrum-css

delete branch : rule-to-divider

delete time in 8 days

push eventadobe/spectrum-css

Larry Davis

commit sha b0ae0ad2e8049f1e151bde005fa0da952feee85c

build: add release:site to deploy dev site

view details

Larry Davis

commit sha 9967060d7abbd4d672ee4e88d5d40004ac8b17b6

docs: fix header scrolling away when anchors clicked

view details

Larry Davis

commit sha 7e1f01f42a197b96d043c7b0f12ea8ee1cf92b21

build: deploy to gh-pages with no history

view details

Larry Davis

commit sha 32d3fe05d2d69c2b0502cd7358cf818f1c4dc85e

chore(release): release - @spectrum-css/actionbar@3.0.0-beta.3 - @spectrum-css/actiongroup@1.0.0-beta.2 - @spectrum-css/actionmenu@3.0.0-beta.3 - @spectrum-css/alert@3.0.0-beta.3 - @spectrum-css/assetlist@3.0.0-beta.3 - @spectrum-css/breadcrumb@3.0.0-beta.3 - @spectrum-css/button@3.0.0-beta.3 - @spectrum-css/buttongroup@3.0.0-beta.3 - @spectrum-css/calendar@3.0.0-beta.3 - @spectrum-css/card@3.0.0-beta.3 - @spectrum-css/checkbox@3.0.0-beta.3 - @spectrum-css/coachmark@3.0.0-beta.3 - @spectrum-css/colorslider@1.0.0-beta.2 - @spectrum-css/cyclebutton@3.0.0-beta.3 - @spectrum-css/dialog@3.0.0-beta.3 - @spectrum-css/dropdown@3.0.0-beta.3 - @spectrum-css/fieldgroup@3.0.0-beta.3 - @spectrum-css/fieldlabel@3.0.0-beta.4 - @spectrum-css/inputgroup@3.0.0-beta.4 - @spectrum-css/miller@3.0.0-beta.3 - @spectrum-css/pagination@3.0.0-beta.4 - @spectrum-css/popover@3.0.0-beta.3 - @spectrum-css/quickaction@3.0.0-beta.3 - @spectrum-css/rule@3.0.0-beta.3 - @spectrum-css/search@3.0.0-beta.4 - @spectrum-css/searchwithin@3.0.0-beta.4 - @spectrum-css/site@2.0.0-beta.3 - @spectrum-css/splitbutton@3.0.0-beta.3 - @spectrum-css/stepper@3.0.0-beta.4 - @spectrum-css/table@3.0.0-beta.3 - @spectrum-css/tabs@3.0.0-beta.3 - @spectrum-css/tags@3.0.0-beta.3 - @spectrum-css/thumbnail@1.0.0-beta.2 - @spectrum-css/toast@3.0.0-beta.3 - @spectrum-css/treeview@3.0.0-beta.3 - @spectrum-css/bundle-builder@2.0.1

view details

Larry Davis

commit sha f58d8e071e5cce8db653e61c5a09b7690c236f63

build: introduce dist-site/ to hold a deployable version of the dev site * add gulp prepareSite

view details

garthdb

commit sha ce9ed1301d0ab8ee827f22c594b9b52ecb8c7505

docs: renamed master to main

view details

Jian Liao

commit sha c6d8dc6f6a14d2c30457fb0128be9c967d8bc175

VRT Update (#769) * test: provide a flag to disable footer * test: rename the DISABLE_FOOTER to VRT and hide sidebar * test: verify puppeteer on jenkins * test: verify puppeteer on jenkins 2 * test: upgrade backstopjs * test: completely disabled adobe globle footer in VRT mode * test: switch back to backstopjs@^4.3.2 to match test env * test: switch back to backstopjs@^4.3.2 to match test env 2 * test: bring back the side bar * test: impove VRT quality by implementing readySelector * test: switch to use customized backstopjs * test: enable readySelector for typekit * test: increase VRT capture limit to 5 * test: decrease VRT captureLimit to 2 * test: try travis-ci multiple jobs * test: continue travis multiple job * test: replace hard coded github repo with travis env var * test: replace hard code url to valid url * test: remove extra mv statement * test: correct the test scenarios url * test: make comment prettier * test: fix the test site url * test: change the message content * test: remove non-existing node script * test: remove redundant dependencis attribute * Update site/resources/js/site.js Co-authored-by: Larry Davis <lawdavis@adobe.com> * test: dev site build excludes css/site.css in VRT mode * test: revert - dev site build excludes css/site.css in VRT mode * test: change the default reference image path to essential package Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Larry Davis <lawdavis@adobe.com>

view details

Garth Braithwaite

commit sha 33d6638299a154e816665c4cc5ef9a3381c28551

feat: RSP V3 Dialog (#710) * feat: add Modal and Tray * chore: creating pr from react v3 work * fix: using modal in dialog examples * fix: dialog examples * feat: wip * feat: wip * feat: adjusted enhancement script * feat: aligned popover with rsp v3 * docs: added a better example for the Modal * fix: issue with fullscreen safari mobile see rsp-v3#517 * fix: replaced widths with inline-size * fix: added alias vars for globals Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Rob Snow <rsnow@adobe.com>

view details

Garth Braithwaite

commit sha d1081f05c6f8e21ae1e01e79cad0d59ff6bc01e3

feat: renamed dropdown to picker (#540)

view details

garthdb

commit sha c67051b15785ee838590351d5bcc1de54e15a651

refactor!: renamed rule to divider

view details

Garth Braithwaite

commit sha 8d4a61f49d4f3441f616032221eccf598891b318

Tray rsp v3 (#741) * feat: add Modal and Tray * chore: creating pr from react v3 work * fix: using modal in dialog examples * fix: dialog examples * feat: adjusted enhancement script * feat: aligned popover with rsp v3 * feat: tray from RSP v3 * fix: updated tray description from RSP site * docs: added a better example for the Modal * test: add VRT scenarios for tray component * fix: switched widths to inline-size Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Jian Liao <jianliao@adobe.com>

view details

garthdb

commit sha 2656f10283479d8c9157badb9ed5db0f32c15e03

Merge branch 'main' into rule-to-divider

view details

push time in 8 days

delete branch adobe/spectrum-css

delete branch : tray-rsp-v3

delete time in 8 days

push eventadobe/spectrum-css

Garth Braithwaite

commit sha 8d4a61f49d4f3441f616032221eccf598891b318

Tray rsp v3 (#741) * feat: add Modal and Tray * chore: creating pr from react v3 work * fix: using modal in dialog examples * fix: dialog examples * feat: adjusted enhancement script * feat: aligned popover with rsp v3 * feat: tray from RSP v3 * fix: updated tray description from RSP site * docs: added a better example for the Modal * test: add VRT scenarios for tray component * fix: switched widths to inline-size Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Jian Liao <jianliao@adobe.com>

view details

push time in 8 days

PR merged adobe/spectrum-css

Reviewers
Tray rsp v3

Description

Syncing up with React Spectrum V3 work on Dialog, Modal, and Tray.

It requires https://github.com/adobe/spectrum-css/pull/710

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+144 -11

5 comments

10 changed files

GarthDB

pr closed time in 8 days

push eventadobe/spectrum-css

garthdb

commit sha fc0fb9803642e4b6670383576b951031a270bfb6

feat: added tray

view details

push time in 8 days

pull request commentadobe/spectrum-css

Tray rsp v3

@bernhard-adobe I switch things to inline for rtl. Could you give me a review?

GarthDB

comment created time in 8 days

push eventadobe/spectrum-css

Larry Davis

commit sha b0ae0ad2e8049f1e151bde005fa0da952feee85c

build: add release:site to deploy dev site

view details

Larry Davis

commit sha 9967060d7abbd4d672ee4e88d5d40004ac8b17b6

docs: fix header scrolling away when anchors clicked

view details

Larry Davis

commit sha 7e1f01f42a197b96d043c7b0f12ea8ee1cf92b21

build: deploy to gh-pages with no history

view details

Larry Davis

commit sha 32d3fe05d2d69c2b0502cd7358cf818f1c4dc85e

chore(release): release - @spectrum-css/actionbar@3.0.0-beta.3 - @spectrum-css/actiongroup@1.0.0-beta.2 - @spectrum-css/actionmenu@3.0.0-beta.3 - @spectrum-css/alert@3.0.0-beta.3 - @spectrum-css/assetlist@3.0.0-beta.3 - @spectrum-css/breadcrumb@3.0.0-beta.3 - @spectrum-css/button@3.0.0-beta.3 - @spectrum-css/buttongroup@3.0.0-beta.3 - @spectrum-css/calendar@3.0.0-beta.3 - @spectrum-css/card@3.0.0-beta.3 - @spectrum-css/checkbox@3.0.0-beta.3 - @spectrum-css/coachmark@3.0.0-beta.3 - @spectrum-css/colorslider@1.0.0-beta.2 - @spectrum-css/cyclebutton@3.0.0-beta.3 - @spectrum-css/dialog@3.0.0-beta.3 - @spectrum-css/dropdown@3.0.0-beta.3 - @spectrum-css/fieldgroup@3.0.0-beta.3 - @spectrum-css/fieldlabel@3.0.0-beta.4 - @spectrum-css/inputgroup@3.0.0-beta.4 - @spectrum-css/miller@3.0.0-beta.3 - @spectrum-css/pagination@3.0.0-beta.4 - @spectrum-css/popover@3.0.0-beta.3 - @spectrum-css/quickaction@3.0.0-beta.3 - @spectrum-css/rule@3.0.0-beta.3 - @spectrum-css/search@3.0.0-beta.4 - @spectrum-css/searchwithin@3.0.0-beta.4 - @spectrum-css/site@2.0.0-beta.3 - @spectrum-css/splitbutton@3.0.0-beta.3 - @spectrum-css/stepper@3.0.0-beta.4 - @spectrum-css/table@3.0.0-beta.3 - @spectrum-css/tabs@3.0.0-beta.3 - @spectrum-css/tags@3.0.0-beta.3 - @spectrum-css/thumbnail@1.0.0-beta.2 - @spectrum-css/toast@3.0.0-beta.3 - @spectrum-css/treeview@3.0.0-beta.3 - @spectrum-css/bundle-builder@2.0.1

view details

Larry Davis

commit sha f58d8e071e5cce8db653e61c5a09b7690c236f63

build: introduce dist-site/ to hold a deployable version of the dev site * add gulp prepareSite

view details

garthdb

commit sha ce9ed1301d0ab8ee827f22c594b9b52ecb8c7505

docs: renamed master to main

view details

Jian Liao

commit sha c6d8dc6f6a14d2c30457fb0128be9c967d8bc175

VRT Update (#769) * test: provide a flag to disable footer * test: rename the DISABLE_FOOTER to VRT and hide sidebar * test: verify puppeteer on jenkins * test: verify puppeteer on jenkins 2 * test: upgrade backstopjs * test: completely disabled adobe globle footer in VRT mode * test: switch back to backstopjs@^4.3.2 to match test env * test: switch back to backstopjs@^4.3.2 to match test env 2 * test: bring back the side bar * test: impove VRT quality by implementing readySelector * test: switch to use customized backstopjs * test: enable readySelector for typekit * test: increase VRT capture limit to 5 * test: decrease VRT captureLimit to 2 * test: try travis-ci multiple jobs * test: continue travis multiple job * test: replace hard coded github repo with travis env var * test: replace hard code url to valid url * test: remove extra mv statement * test: correct the test scenarios url * test: make comment prettier * test: fix the test site url * test: change the message content * test: remove non-existing node script * test: remove redundant dependencis attribute * Update site/resources/js/site.js Co-authored-by: Larry Davis <lawdavis@adobe.com> * test: dev site build excludes css/site.css in VRT mode * test: revert - dev site build excludes css/site.css in VRT mode * test: change the default reference image path to essential package Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Larry Davis <lawdavis@adobe.com>

view details

Garth Braithwaite

commit sha 33d6638299a154e816665c4cc5ef9a3381c28551

feat: RSP V3 Dialog (#710) * feat: add Modal and Tray * chore: creating pr from react v3 work * fix: using modal in dialog examples * fix: dialog examples * feat: wip * feat: wip * feat: adjusted enhancement script * feat: aligned popover with rsp v3 * docs: added a better example for the Modal * fix: issue with fullscreen safari mobile see rsp-v3#517 * fix: replaced widths with inline-size * fix: added alias vars for globals Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Rob Snow <rsnow@adobe.com>

view details

Garth Braithwaite

commit sha d1081f05c6f8e21ae1e01e79cad0d59ff6bc01e3

feat: renamed dropdown to picker (#540)

view details

garthdb

commit sha eccb1aa59d8f8cb080d968e063b5fc699d717bda

feat: added tray

view details

push time in 8 days

delete branch adobe/spectrum-css

delete branch : dropdown-picker-rename

delete time in 8 days

push eventadobe/spectrum-css

Garth Braithwaite

commit sha d1081f05c6f8e21ae1e01e79cad0d59ff6bc01e3

feat: renamed dropdown to picker (#540)

view details

push time in 8 days

PR merged adobe/spectrum-css

refactor: rename dropdown to picker breaking change

<!-- Summarize your changes in the Title field -->

Description

Renaming Dropdown to Picker following design API discussions.

How and where has this been tested?

Testing locally

Screenshots

<!-- If applicable, add screenshots to show what you changed -->

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+588 -474

3 comments

19 changed files

GarthDB

pr closed time in 8 days

push eventadobe/spectrum-css

Larry Davis

commit sha b0ae0ad2e8049f1e151bde005fa0da952feee85c

build: add release:site to deploy dev site

view details

Larry Davis

commit sha 9967060d7abbd4d672ee4e88d5d40004ac8b17b6

docs: fix header scrolling away when anchors clicked

view details

Larry Davis

commit sha 7e1f01f42a197b96d043c7b0f12ea8ee1cf92b21

build: deploy to gh-pages with no history

view details

Larry Davis

commit sha 32d3fe05d2d69c2b0502cd7358cf818f1c4dc85e

chore(release): release - @spectrum-css/actionbar@3.0.0-beta.3 - @spectrum-css/actiongroup@1.0.0-beta.2 - @spectrum-css/actionmenu@3.0.0-beta.3 - @spectrum-css/alert@3.0.0-beta.3 - @spectrum-css/assetlist@3.0.0-beta.3 - @spectrum-css/breadcrumb@3.0.0-beta.3 - @spectrum-css/button@3.0.0-beta.3 - @spectrum-css/buttongroup@3.0.0-beta.3 - @spectrum-css/calendar@3.0.0-beta.3 - @spectrum-css/card@3.0.0-beta.3 - @spectrum-css/checkbox@3.0.0-beta.3 - @spectrum-css/coachmark@3.0.0-beta.3 - @spectrum-css/colorslider@1.0.0-beta.2 - @spectrum-css/cyclebutton@3.0.0-beta.3 - @spectrum-css/dialog@3.0.0-beta.3 - @spectrum-css/dropdown@3.0.0-beta.3 - @spectrum-css/fieldgroup@3.0.0-beta.3 - @spectrum-css/fieldlabel@3.0.0-beta.4 - @spectrum-css/inputgroup@3.0.0-beta.4 - @spectrum-css/miller@3.0.0-beta.3 - @spectrum-css/pagination@3.0.0-beta.4 - @spectrum-css/popover@3.0.0-beta.3 - @spectrum-css/quickaction@3.0.0-beta.3 - @spectrum-css/rule@3.0.0-beta.3 - @spectrum-css/search@3.0.0-beta.4 - @spectrum-css/searchwithin@3.0.0-beta.4 - @spectrum-css/site@2.0.0-beta.3 - @spectrum-css/splitbutton@3.0.0-beta.3 - @spectrum-css/stepper@3.0.0-beta.4 - @spectrum-css/table@3.0.0-beta.3 - @spectrum-css/tabs@3.0.0-beta.3 - @spectrum-css/tags@3.0.0-beta.3 - @spectrum-css/thumbnail@1.0.0-beta.2 - @spectrum-css/toast@3.0.0-beta.3 - @spectrum-css/treeview@3.0.0-beta.3 - @spectrum-css/bundle-builder@2.0.1

view details

Larry Davis

commit sha f58d8e071e5cce8db653e61c5a09b7690c236f63

build: introduce dist-site/ to hold a deployable version of the dev site * add gulp prepareSite

view details

garthdb

commit sha ce9ed1301d0ab8ee827f22c594b9b52ecb8c7505

docs: renamed master to main

view details

Jian Liao

commit sha c6d8dc6f6a14d2c30457fb0128be9c967d8bc175

VRT Update (#769) * test: provide a flag to disable footer * test: rename the DISABLE_FOOTER to VRT and hide sidebar * test: verify puppeteer on jenkins * test: verify puppeteer on jenkins 2 * test: upgrade backstopjs * test: completely disabled adobe globle footer in VRT mode * test: switch back to backstopjs@^4.3.2 to match test env * test: switch back to backstopjs@^4.3.2 to match test env 2 * test: bring back the side bar * test: impove VRT quality by implementing readySelector * test: switch to use customized backstopjs * test: enable readySelector for typekit * test: increase VRT capture limit to 5 * test: decrease VRT captureLimit to 2 * test: try travis-ci multiple jobs * test: continue travis multiple job * test: replace hard coded github repo with travis env var * test: replace hard code url to valid url * test: remove extra mv statement * test: correct the test scenarios url * test: make comment prettier * test: fix the test site url * test: change the message content * test: remove non-existing node script * test: remove redundant dependencis attribute * Update site/resources/js/site.js Co-authored-by: Larry Davis <lawdavis@adobe.com> * test: dev site build excludes css/site.css in VRT mode * test: revert - dev site build excludes css/site.css in VRT mode * test: change the default reference image path to essential package Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Larry Davis <lawdavis@adobe.com>

view details

Garth Braithwaite

commit sha 33d6638299a154e816665c4cc5ef9a3381c28551

feat: RSP V3 Dialog (#710) * feat: add Modal and Tray * chore: creating pr from react v3 work * fix: using modal in dialog examples * fix: dialog examples * feat: wip * feat: wip * feat: adjusted enhancement script * feat: aligned popover with rsp v3 * docs: added a better example for the Modal * fix: issue with fullscreen safari mobile see rsp-v3#517 * fix: replaced widths with inline-size * fix: added alias vars for globals Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Rob Snow <rsnow@adobe.com>

view details

garthdb

commit sha 7841a4b61d21212ae1150facd74fa7f8459e5cf4

refactor!: renamed dropdown to picker

view details

push time in 8 days

delete branch adobe/spectrum-css

delete branch : dialog-rsp-v3

delete time in 8 days

push eventadobe/spectrum-css

Garth Braithwaite

commit sha 33d6638299a154e816665c4cc5ef9a3381c28551

feat: RSP V3 Dialog (#710) * feat: add Modal and Tray * chore: creating pr from react v3 work * fix: using modal in dialog examples * fix: dialog examples * feat: wip * feat: wip * feat: adjusted enhancement script * feat: aligned popover with rsp v3 * docs: added a better example for the Modal * fix: issue with fullscreen safari mobile see rsp-v3#517 * fix: replaced widths with inline-size * fix: added alias vars for globals Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Rob Snow <rsnow@adobe.com>

view details

push time in 8 days

PR merged adobe/spectrum-css

Reviewers
feat: RSP V3 Dialog

<!-- Summarize your changes in the Title field -->

Description

Syncing up with React Spectrum V3 work on Dialog.

It has some breaking stuff by using grid and such, but it also breaks our examples.

How and where has this been tested?

  • How this was tested: <!-- Using steps in issue #000 -->
  • Browser(s) and OS(s) this was tested with: <!-- Chrome 75.0.3770.142 on Win 10 -->

Screenshots

<!-- If applicable, add screenshots to show what you changed --> image

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+945 -723

14 comments

16 changed files

GarthDB

pr closed time in 8 days

push eventadobe/spectrum-css

Larry Davis

commit sha b0ae0ad2e8049f1e151bde005fa0da952feee85c

build: add release:site to deploy dev site

view details

Larry Davis

commit sha 9967060d7abbd4d672ee4e88d5d40004ac8b17b6

docs: fix header scrolling away when anchors clicked

view details

Larry Davis

commit sha 7e1f01f42a197b96d043c7b0f12ea8ee1cf92b21

build: deploy to gh-pages with no history

view details

Larry Davis

commit sha 32d3fe05d2d69c2b0502cd7358cf818f1c4dc85e

chore(release): release - @spectrum-css/actionbar@3.0.0-beta.3 - @spectrum-css/actiongroup@1.0.0-beta.2 - @spectrum-css/actionmenu@3.0.0-beta.3 - @spectrum-css/alert@3.0.0-beta.3 - @spectrum-css/assetlist@3.0.0-beta.3 - @spectrum-css/breadcrumb@3.0.0-beta.3 - @spectrum-css/button@3.0.0-beta.3 - @spectrum-css/buttongroup@3.0.0-beta.3 - @spectrum-css/calendar@3.0.0-beta.3 - @spectrum-css/card@3.0.0-beta.3 - @spectrum-css/checkbox@3.0.0-beta.3 - @spectrum-css/coachmark@3.0.0-beta.3 - @spectrum-css/colorslider@1.0.0-beta.2 - @spectrum-css/cyclebutton@3.0.0-beta.3 - @spectrum-css/dialog@3.0.0-beta.3 - @spectrum-css/dropdown@3.0.0-beta.3 - @spectrum-css/fieldgroup@3.0.0-beta.3 - @spectrum-css/fieldlabel@3.0.0-beta.4 - @spectrum-css/inputgroup@3.0.0-beta.4 - @spectrum-css/miller@3.0.0-beta.3 - @spectrum-css/pagination@3.0.0-beta.4 - @spectrum-css/popover@3.0.0-beta.3 - @spectrum-css/quickaction@3.0.0-beta.3 - @spectrum-css/rule@3.0.0-beta.3 - @spectrum-css/search@3.0.0-beta.4 - @spectrum-css/searchwithin@3.0.0-beta.4 - @spectrum-css/site@2.0.0-beta.3 - @spectrum-css/splitbutton@3.0.0-beta.3 - @spectrum-css/stepper@3.0.0-beta.4 - @spectrum-css/table@3.0.0-beta.3 - @spectrum-css/tabs@3.0.0-beta.3 - @spectrum-css/tags@3.0.0-beta.3 - @spectrum-css/thumbnail@1.0.0-beta.2 - @spectrum-css/toast@3.0.0-beta.3 - @spectrum-css/treeview@3.0.0-beta.3 - @spectrum-css/bundle-builder@2.0.1

view details

Larry Davis

commit sha f58d8e071e5cce8db653e61c5a09b7690c236f63

build: introduce dist-site/ to hold a deployable version of the dev site * add gulp prepareSite

view details

garthdb

commit sha ce9ed1301d0ab8ee827f22c594b9b52ecb8c7505

docs: renamed master to main

view details

Jian Liao

commit sha c6d8dc6f6a14d2c30457fb0128be9c967d8bc175

VRT Update (#769) * test: provide a flag to disable footer * test: rename the DISABLE_FOOTER to VRT and hide sidebar * test: verify puppeteer on jenkins * test: verify puppeteer on jenkins 2 * test: upgrade backstopjs * test: completely disabled adobe globle footer in VRT mode * test: switch back to backstopjs@^4.3.2 to match test env * test: switch back to backstopjs@^4.3.2 to match test env 2 * test: bring back the side bar * test: impove VRT quality by implementing readySelector * test: switch to use customized backstopjs * test: enable readySelector for typekit * test: increase VRT capture limit to 5 * test: decrease VRT captureLimit to 2 * test: try travis-ci multiple jobs * test: continue travis multiple job * test: replace hard coded github repo with travis env var * test: replace hard code url to valid url * test: remove extra mv statement * test: correct the test scenarios url * test: make comment prettier * test: fix the test site url * test: change the message content * test: remove non-existing node script * test: remove redundant dependencis attribute * Update site/resources/js/site.js Co-authored-by: Larry Davis <lawdavis@adobe.com> * test: dev site build excludes css/site.css in VRT mode * test: revert - dev site build excludes css/site.css in VRT mode * test: change the default reference image path to essential package Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Larry Davis <lawdavis@adobe.com>

view details

garthdb

commit sha 7bfde62732805e7ae1fdcea2963043e7d4148612

fix: updating with latest main

view details

push time in 8 days

push eventadobe/spectrum-css

garthdb

commit sha 73e3a89608fb88cde5dd829266bcb9118110eda5

fix!: renamed toggle to switch; removed ab variant

view details

garthdb

commit sha 6fc60cb78674140351d42077b534495a02208e5e

fix: renamed dropdown to picker

view details

garthdb

commit sha 1ea01905b61c6da7825bf7fe0160802a0d196cbc

fix: removed deprecated avatar tokens

view details

garthdb

commit sha 281027d859025e3f6d36e5760794ffc5f82141e6

fix: removed deprecated tokens in button

view details

garthdb

commit sha ebbe6c1d6d8e0b2ece1d3f49392bd63ea6c53c15

fix: removed deprecated tokens in dialog

view details

garthdb

commit sha d97b026e46a09ce5122803600bc614f8b9b76c16

fix: removed deprecated tokens from searchWithin

view details

garthdb

commit sha cf1578434b221a884fffa9c71f8e01b1ec20913e

fix: removed deprecated tokens from underlay/overlay

view details

garthdb

commit sha 16a7e5ba588aa6209b2c32b4db7cd1fe8fc66b35

fix: removed deprecated tokens from toast

view details

garthdb

commit sha 1e543e4d5f4bfaebd77d61a84b2db7615a287938

fix: removed deprecated tokens from tabs and tags

view details

push time in 8 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Svelte Implementation

GanttStart: 2020-09-14 GanttDue: 2020-10-24

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Front End Prototype

GanttStart: 2020-09-21 GanttDue: 2020-09-28

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #14

GanttStart: 2020-11-30 GanttDue: 2020-12-04

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #13

GanttStart: 2020-11-23 GanttDue: 2020-11-30

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #12

GanttStart: 2020-11-16 GanttDue: 2020-11-23

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #11

GanttStart: 2020-11-09 GanttDue: 2020-11-16

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #10

GanttStart: 2020-11-02 GanttDue: 2020-11-09

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #9

GanttStart: 2020-10-26 GanttDue: 2020-11-02

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #8

GanttStart: 2020-10-19 GanttDue: 2020-10-26

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #7

GanttStart: 2020-10-12 GanttDue: 2020-10-19

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #6

GanttStart: 2020-10-05 GanttDue: 2020-10-12

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #5

GanttStart: 2020-09-27 GanttDue: 2020-10-03

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #4

GanttStart: 2020-09-20 GanttDue: 2020-09-26

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #3

GanttStart: 2020-09-14 GanttDue: 2020-09-18

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #2

GanttStart: 2020-09-07 GanttDue: 2020-09-11

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Weekly Newsletter #1

GanttStart: 2020-08-31 GanttDue: 2020-09-04

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Write newsletter topics

GanttStart: 2020-08-02 GanttDue: 2020-09-03

created time in 14 days

issue openedDesignSystemsEngineer/designsystemsengineer.github.io

Rough draft of Curriculum

What topics will be covered? 3-5 min videos Breakdown.

created time in 14 days

push eventadobe/spectrum-css

Larry Davis

commit sha b0ae0ad2e8049f1e151bde005fa0da952feee85c

build: add release:site to deploy dev site

view details

Larry Davis

commit sha 9967060d7abbd4d672ee4e88d5d40004ac8b17b6

docs: fix header scrolling away when anchors clicked

view details

Larry Davis

commit sha 7e1f01f42a197b96d043c7b0f12ea8ee1cf92b21

build: deploy to gh-pages with no history

view details

Larry Davis

commit sha 32d3fe05d2d69c2b0502cd7358cf818f1c4dc85e

chore(release): release - @spectrum-css/actionbar@3.0.0-beta.3 - @spectrum-css/actiongroup@1.0.0-beta.2 - @spectrum-css/actionmenu@3.0.0-beta.3 - @spectrum-css/alert@3.0.0-beta.3 - @spectrum-css/assetlist@3.0.0-beta.3 - @spectrum-css/breadcrumb@3.0.0-beta.3 - @spectrum-css/button@3.0.0-beta.3 - @spectrum-css/buttongroup@3.0.0-beta.3 - @spectrum-css/calendar@3.0.0-beta.3 - @spectrum-css/card@3.0.0-beta.3 - @spectrum-css/checkbox@3.0.0-beta.3 - @spectrum-css/coachmark@3.0.0-beta.3 - @spectrum-css/colorslider@1.0.0-beta.2 - @spectrum-css/cyclebutton@3.0.0-beta.3 - @spectrum-css/dialog@3.0.0-beta.3 - @spectrum-css/dropdown@3.0.0-beta.3 - @spectrum-css/fieldgroup@3.0.0-beta.3 - @spectrum-css/fieldlabel@3.0.0-beta.4 - @spectrum-css/inputgroup@3.0.0-beta.4 - @spectrum-css/miller@3.0.0-beta.3 - @spectrum-css/pagination@3.0.0-beta.4 - @spectrum-css/popover@3.0.0-beta.3 - @spectrum-css/quickaction@3.0.0-beta.3 - @spectrum-css/rule@3.0.0-beta.3 - @spectrum-css/search@3.0.0-beta.4 - @spectrum-css/searchwithin@3.0.0-beta.4 - @spectrum-css/site@2.0.0-beta.3 - @spectrum-css/splitbutton@3.0.0-beta.3 - @spectrum-css/stepper@3.0.0-beta.4 - @spectrum-css/table@3.0.0-beta.3 - @spectrum-css/tabs@3.0.0-beta.3 - @spectrum-css/tags@3.0.0-beta.3 - @spectrum-css/thumbnail@1.0.0-beta.2 - @spectrum-css/toast@3.0.0-beta.3 - @spectrum-css/treeview@3.0.0-beta.3 - @spectrum-css/bundle-builder@2.0.1

view details

Larry Davis

commit sha f58d8e071e5cce8db653e61c5a09b7690c236f63

build: introduce dist-site/ to hold a deployable version of the dev site * add gulp prepareSite

view details

garthdb

commit sha ce9ed1301d0ab8ee827f22c594b9b52ecb8c7505

docs: renamed master to main

view details

Jian Liao

commit sha c6d8dc6f6a14d2c30457fb0128be9c967d8bc175

VRT Update (#769) * test: provide a flag to disable footer * test: rename the DISABLE_FOOTER to VRT and hide sidebar * test: verify puppeteer on jenkins * test: verify puppeteer on jenkins 2 * test: upgrade backstopjs * test: completely disabled adobe globle footer in VRT mode * test: switch back to backstopjs@^4.3.2 to match test env * test: switch back to backstopjs@^4.3.2 to match test env 2 * test: bring back the side bar * test: impove VRT quality by implementing readySelector * test: switch to use customized backstopjs * test: enable readySelector for typekit * test: increase VRT capture limit to 5 * test: decrease VRT captureLimit to 2 * test: try travis-ci multiple jobs * test: continue travis multiple job * test: replace hard coded github repo with travis env var * test: replace hard code url to valid url * test: remove extra mv statement * test: correct the test scenarios url * test: make comment prettier * test: fix the test site url * test: change the message content * test: remove non-existing node script * test: remove redundant dependencis attribute * Update site/resources/js/site.js Co-authored-by: Larry Davis <lawdavis@adobe.com> * test: dev site build excludes css/site.css in VRT mode * test: revert - dev site build excludes css/site.css in VRT mode * test: change the default reference image path to essential package Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Larry Davis <lawdavis@adobe.com>

view details

garthdb

commit sha 989f7ff4edcdef28ee801bc6a288269c70989d27

Merge branch 'main' into spectrum-tokens-17

view details

push time in 14 days

issue openedadobe/spectrum-css

Update documentation on how to run VRT locally

Description

This stuff was helpful in getting my vrt to run locally, but wasn't in the readme.

  1. Upgrade the reference package to latest by yarn upgrade @spectrum-css/spectrum-css-vr-test-assets-essential
  2. Start local dev server with VRT=true yarn run dev
  3. Run npm run backstop:docker:test reference=node_modules/@spectrum-css/spectrum-css-vr-test-assets-essential/bitmaps_reference/

If it is still unable to completely run a VRT, try reducing the number for these two properties to 1 and 5. backstop_data/backstop_test.js#L143-L144

asyncCaptureLimit: captureLimit,
asyncCompareLimit: 50,

created time in 14 days

pull request commentadobe/spectrum-css

VRT Update

I got it to work locally and looks good. @jianliao I'll create issues for updating documentation for running locally and generating new screenshots when prs are merged into master.

jianliao

comment created time in 14 days

delete branch adobe/spectrum-css

delete branch : vrt-reference

delete time in 14 days

push eventadobe/spectrum-css

Jian Liao

commit sha c6d8dc6f6a14d2c30457fb0128be9c967d8bc175

VRT Update (#769) * test: provide a flag to disable footer * test: rename the DISABLE_FOOTER to VRT and hide sidebar * test: verify puppeteer on jenkins * test: verify puppeteer on jenkins 2 * test: upgrade backstopjs * test: completely disabled adobe globle footer in VRT mode * test: switch back to backstopjs@^4.3.2 to match test env * test: switch back to backstopjs@^4.3.2 to match test env 2 * test: bring back the side bar * test: impove VRT quality by implementing readySelector * test: switch to use customized backstopjs * test: enable readySelector for typekit * test: increase VRT capture limit to 5 * test: decrease VRT captureLimit to 2 * test: try travis-ci multiple jobs * test: continue travis multiple job * test: replace hard coded github repo with travis env var * test: replace hard code url to valid url * test: remove extra mv statement * test: correct the test scenarios url * test: make comment prettier * test: fix the test site url * test: change the message content * test: remove non-existing node script * test: remove redundant dependencis attribute * Update site/resources/js/site.js Co-authored-by: Larry Davis <lawdavis@adobe.com> * test: dev site build excludes css/site.css in VRT mode * test: revert - dev site build excludes css/site.css in VRT mode * test: change the default reference image path to essential package Co-authored-by: Jian Liao <jianliao@adobe.com> Co-authored-by: Larry Davis <lawdavis@adobe.com>

view details

push time in 14 days

PR merged adobe/spectrum-css

Reviewers
VRT Update

<!-- Summarize your changes in the Title field -->

Description

This PR is to address the following issues.

  1. Quality of VRT images. As spectrum-css depends on Adobe Typekit, sometimes due to the network latency, VRT images will capture without adobe clean web font loaded, which cause lots of VRT failures.

    To improve the VRT quality, I created a customized backstopjs package - backstopjs-spectrum. It enhanced the backstopjs with the new retry feature. I also enabled readySelector: 'html.wf-active' for all our VRT scenarios. wf-active css class on HTML element is a special flag that indicates Adobe Typekit are fully-loaded on the page. Due to the unpredictable network situation, enabling readySelector sometimes will fail the test. But with the retry feature, we can be more confident and even increase the concurrent asyncCaptureLimit threshold. If retry feature goes well, I will contribute it back to BackstopJS.

    Another small enhancement is in the VRT report, you can now directly navigate to the failure test page and start to investigate the root cause of failure.

image

  1. Due to the recent spectrum-css documentation site change, some of the documentation site styles are leaking into VRT test scenarios. VRT image capture needs to be run in a relative isolated environment(For example, excluding the Adobe Global footer and side navigation bar).

    Here I introduced a new spectrum-css build mode named VRT. When build the dev with VRT=true, the site will be generated without the site navigation and Adobe global footer.

image

  1. Speed up the CI build. The current travis-ci job is a sequential build process. Firstly, it will generate the dev site, then runs the VRT. It takes about 15mins to complete. If we can parallel execute them, it will be way faster.

    I re-configured the travis-ci build script to separate the build process into two jobs and report the result with adobe spectrum bot separately. Another side-effect of this change is that you can always get a Dev site build no matter the VRT success or not.

image

  1. Emojis in adobe spectrum bot comment on PR. I steal this idea from React-Spectrum.

image

How and where has this been tested?

  • How this was tested: <!-- Using steps in issue #000 -->
  • Browser(s) and OS(s) this was tested with: <!-- Chrome 75.0.3770.142 on Win 10 -->

Screenshots

<!-- If applicable, add screenshots to show what you changed -->

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+400 -339

11 comments

13 changed files

jianliao

pr closed time in 14 days

issue closedadobe/spectrum-css

VRT report should have directly link to each test page

Description

In our current VR report, when you hover your mouse on a scenario name, you will see a floating popover which includes a link to the test scenario. Currently, it points to an inaccessible URL. As we already upload and host the testing dev site. We should change it and point to a valid link. image

Why do you need this feature or component?

<!-- Tell us what this solves or why this is important to your use case --> Help the VR reviewer to be more productive. You can jump to the fail scenario with one click.

Additional context

<!-- Add any other context, workarounds, or screenshots about your request -->

closed time in 14 days

jianliao

pull request commentadobe/spectrum-css

VRT Update

@jianliao I ran yarn upgrade @spectrum-css/spectrum-css-vr-test-assets-essential , VRT=true yarn run dev , and then npm run backstop:docker:test in another terminal window, and still ran into an error. Here's the full log in a gist.

jianliao

comment created time in 14 days

pull request commentadobe/spectrum-css

VRT Update

I ran into an error running the branch in docker locally. Is there something I'm missing to fix it?

TimeoutError: waiting for selector "html.wf-active" failed: timeout 30000ms exceeded
Re-running scenario "breadcrumb-light-medium" on 2 time
Puppeteer encountered an error while running scenario "button-over-background-light-medium" on retry 1
TimeoutError: waiting for selector "html.wf-active" failed: timeout 30000ms exceeded
Re-running scenario "button-over-background-light-medium" on 2 time
      COMMAND | Command "test" ended with an error after [557.762s]
      COMMAND | TimeoutError: Timed out after 30000 ms while trying to connect to the browser! Only Chrome at revision r722234 is guaranteed to work.
                    at Timeout.onTimeout (/usr/local/lib/node_modules/backstopjs-spectrum/node_modules/puppeteer/lib/Launcher.js:761:14)
                    at ontimeout (timers.js:436:11)
                    at tryOnTimeout (timers.js:300:5)
                    at listOnTimeout (timers.js:263:5)
                    at Timer.processTimers (timers.js:223:10)
x Close Browser
x Close Browser
Browser Console Log 0: JSHandle:BackstopTools have been installed.
Browser Console Log 0: JSHandle:BackstopTools have been installed.
x Close Browser
x Close Browser
COMMAND | Executing core for "openReport"
openReport | Attempting to ping 
   COMMAND | Command "test" ended with an error after [704.362s]
   COMMAND | Error: docker run --rm -i -t=false --mount type=bind,source="/Users/garthdb/Spectrum/spectrum-css",target=/src --network host --shm-size 2048m jianliao/backstopjs:5.0.4 test "--moby" "--config=backstop_data/backstop_test.js" "--env=local" returned 1
                 at ChildProcess.<anonymous> (/Users/garthdb/Spectrum/spectrum-css/node_modules/backstopjs-spectrum/core/util/runDocker.js:68:18)
                 at ChildProcess.emit (events.js:196:13)
                 at Process.ChildProcess._handle.onexit (internal/child_process.js:257:12)
openReport | Remote not detected. Opening backstop_data/html_report/index.html
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! spectrum-css-monorepo@0.0.0 backstop:docker:test: `backstop test --docker --config=backstop_data/backstop_test.js --env=local`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the spectrum-css-monorepo@0.0.0 backstop:docker:test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/garthdb/.npm/_logs/2020-07-22T18_02_36_268Z-debug.log
jianliao

comment created time in 14 days

pull request commentadobe/spectrum-web-components

fix(slider): simplify application of the gradient backgrounds

@lazd agreed. If it is because of a feature that is going into a main release of chrome/blink and/or WebKit, we should be concerned, otherwise we don’t test or build for prerelease browsers.

Westbrook

comment created time in 15 days

Pull request review commentadobe/spectrum-css

Update to Spectrum Tokens Beta 17

 :root {-  --spectrum-badge-text-color: var(--spectrum-global-color-static-white);-  --spectrum-badge-error-background-color: var(--spectrum-semantic-negative-color-default);-  --spectrum-badge-info-background-color: var(--spectrum-semantic-informative-color-default);-  --spectrum-badge-warning-background-color: var(--spectrum-semantic-notice-color-default);+  --spectrum-badge-fuchsia-l-focus-ring-border-radius-key-focus: var(--spectrum-global-dimension-size-75);

@jluyau the CSS vars file has the size and color tokens. What's new in spectrum-badge file are the t-shirt sizes. T-shirt sizes are separate from scale (i.e., large, medium). We are going to see a ton of new tokens for each component that gets t-shirt sizing.

GarthDB

comment created time in 15 days

push eventadobe/spectrum-css

garthdb

commit sha ce9ed1301d0ab8ee827f22c594b9b52ecb8c7505

docs: renamed master to main

view details

push time in 15 days

PR closed adobe/spectrum-css

Reviewers
منصةشليله

مجموعة منصة شليلة الرياض المملكة العربية السعودية قمر شليله bot منصة شليله book قناة شليله android web etc. Webمنصةشليلة_Developer_Career_Guide_2019 1990/04/07 <br/> <p>

</p> ar حقوق النشر والملكية الفكرية منصة شليلة الرياض المملكة العربية السعودية ص.ب.12813 vip@ihdadi.com

<!-- Summarize your changes in the Title field -->

Description

<!-- Note: Before sending a pull request, make sure there's an issue for what you're changing

  • Search for issues: https://github.com/adobe/spectrum-css/issues
  • If there's no issue, file it: https://github.com/adobe/spectrum-css/issues/new/choose --> <!-- Describe what you changed and link to the relevant issue(s) (e.g., #000) -->

How and where has this been tested?

  • How this was tested: <!-- Using steps in issue #000 -->
  • Browser(s) and OS(s) this was tested with: <!-- Chrome 75.0.3770.142 on Win 10 -->

Screenshots

<!-- If applicable, add screenshots to show what you changed -->

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+1 -1

0 comment

1 changed file

shliilhpltfrom

pr closed time in 15 days

PR closed adobe/spectrum-css

make vertical Rule's height a variable,

<!-- Summarize your changes in the Title field -->

Description

<!-- Note: Before sending a pull request, make sure there's an issue for what you're changing

  • Search for issues: https://github.com/adobe/spectrum-css/issues
  • If there's no issue, file it: https://github.com/adobe/spectrum-css/issues/new/choose -->make vertical Rule's height a variable, <!-- Describe what you changed and link to the relevant issue(s) (e.g., #000) -->

How and where has this been tested?

  • How this was tested: <!-- Using steps in issue #000 -->
  • Browser(s) and OS(s) this was tested with: <!-- Chrome 75.0.3770.142 on Win 10 -->

Screenshots

<!-- If applicable, add screenshots to show what you changed -->

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [x] If my change impacts other components, I have tested to make sure they don't break.
  • [x] If my change impacts documentation, I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaining tasks here -->
  • [x] This pull request is ready to merge.
+22256 -6741

0 comment

405 changed files

ynppny

pr closed time in 15 days

PR closed adobe/spectrum-css

Update Readme

Beginner

<!-- Summarize your changes in the Title field -->

Description

<!-- Note: Before sending a pull request, make sure there's an issue for what you're changing

  • Search for issues: https://github.com/adobe/spectrum-css/issues
  • If there's no issue, file it: https://github.com/adobe/spectrum-css/issues/new/choose --> <!-- Describe what you changed and link to the relevant issue(s) (e.g., #000) -->

How and where has this been tested?

  • How this was tested: <!-- Using steps in issue #000 -->
  • Browser(s) and OS(s) this was tested with: <!-- Chrome 75.0.3770.142 on Win 10 -->

Screenshots

<!-- If applicable, add screenshots to show what you changed -->

To-do list

<!-- Put an "x" to indicate you've done each of the following -->

  • [ ] If my change impacts other components, I have tested to make sure they don't break.
  • [ ] If my change impacts documentation, I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document. <!-- If this pull request isn't ready, add any remaning tasks here -->
  • [ ] This pull request is ready to merge.
+2 -0

0 comment

1 changed file

Scorpion136

pr closed time in 15 days

delete branch adobe/spectrum-css

delete branch : master

delete time in 15 days

create barnchadobe/spectrum-css

branch : main

created branch time in 15 days

push eventGarthDB/jsondown

garthdb

commit sha eaeea406717c3b4a34ffafebd7608d665519f6bb

Enabled storing json values as json objects in file

view details

push time in 16 days

push eventGarthDB/jsondown

garthdb

commit sha 56e009b127888ae5250b0e0f0827715020be951c

wip

view details

push time in 16 days

create barnchGarthDB/jsondown

branch : jsencoding

created branch time in 17 days

push eventGarthDB/jsondown

garthdb

commit sha 940837eee4cef5fe6e4f365b29dc62c5e9bbd802

removed outdated guides for fake-fs

view details

push time in 19 days

push eventGarthDB/jsondown

garthdb

commit sha 0eaf120bdf2cff3b8a25a350b6048f922f606493

cleaning up coveralls coverage script

view details

push time in 19 days

push eventGarthDB/jsondown

garthdb

commit sha e2f0f20a24034163bddb531ed789fce31da8b6d8

switched from prototype to a class constructor

view details

push time in 19 days

push eventGarthDB/jsondown

garthdb

commit sha bde974478d8c201d879c2f595f4c2607368e9edd

improved code coverage

view details

push time in 19 days

push eventGarthDB/jsondown

Garth Braithwaite

commit sha 267fce7dc3bf70e47f607fe3c31f69a5fa9c4642

Update README.md

view details

push time in 20 days

push eventGarthDB/jsondown

garthdb

commit sha 838fd308b0bb8b94e57aa7b567e1b99f352b0d3f

added badges to README

view details

push time in 20 days

push eventGarthDB/jsondown

garthdb

commit sha e904c9d7bd4234aa5658b88f34ca796e7f7b51f7

fixed coverage reporting

view details

push time in 20 days

push eventGarthDB/jsondown

garthdb

commit sha f8643dbae01f016e0189e0de1ed0cad67f83e117

fixed coverage reporting

view details

push time in 20 days

push eventGarthDB/jsondown

garthdb

commit sha 5281c6be902d24f79a140be6386a29d081837378

fixed coverage reporting

view details

push time in 20 days

push eventGarthDB/jsondown

garthdb

commit sha 9dc22a000bfb36c73f487d8b1312157d43cd014b

replaced deprecated node functions new Buffer and fs.exists

view details

push time in 20 days

push eventGarthDB/jsondown

garthdb

commit sha 7ac53cd8f066c8d8200643e9ead57418a1dd22b2

Added test for batch operations

view details

push time in 21 days

pull request commenttoolness/jsondown

Updating dependencies

@staltz done with the last commit.

GarthDB

comment created time in 21 days

push eventGarthDB/jsondown

garthdb

commit sha 16002d3a6ae12a0e354772c4c0cb1b23577f969d

Added engines to package.json and fixed example in README.md with new constructor

view details

push time in 21 days

issue openedadobe/spectrum-css

Fix VRT since public site update

created time in 21 days

issue openedadobe/spectrum-css

Research: automated release of site

created time in 21 days

issue openedadobe/spectrum-css

Fix breaking DNA tokens

Latest version of DNA has breaking changes.

created time in 21 days

push eventGarthDB/jsondown

garthdb

commit sha 0ce22f5f55908fb1b340ec8a8512d6fbdf1a784d

increasing test coverage

view details

push time in 22 days

pull request commenttoolness/jsondown

Updating dependencies

https://github.com/toolness/jsondown/pull/9

GarthDB

comment created time in 22 days

more