Hi @MaghSamana thanks for your reply! Just to better understand, are you saying when you downgraded, you only replaced your piwik.js/matomo.js file but kept everything else at the higher Matomo version (ie, php code)?

And if you're still willing to help us find the issue, would you be able to check the browsers report for the days in the second site where there are no dom metrics, and post some of the browsers? It would also be helpful to see the site so we can take a look at the tracking code and see what the browsers do (you can email me at [email protected] if you don't want to post that publicly).

I haven't tested this yet, but for the second issue, would it also work to cancel ajax requests in the window's unload or beforeunload events? If that would work, the solution wouldn't depend on a timeout which might avoid edge cases where it takes a long time for the next page to start loading.

Description:

FYI @tsteur

Review

• [ ] Functional review done
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done see checklist
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

This was in regards to the Feedback controller methods that set the next reminder date. These methods don't output HTML or do any rendering, but of course there's no reason to put them in the API because why would anyone need to call them? I'm not sure how to better describe these outlier use cases.

I think I'll save my opinion until german speakers weigh in because I have no idea if that's more readable or not. :)

@sgiehl do you know why these commits are attributed to my user? Was it because I merged the original PR?

Updated submodules:

• plugins/Bandwidth
• plugins/CustomAlerts
• plugins/CustomVariables
• plugins/LogViewer
• plugins/LoginLdap
• plugins/MarketingCampaignsReporting
• plugins/Provider
• plugins/SecurityInfo
• plugins/TasksTimetable
• plugins/TrackingSpamPrevention
• plugins/VisitorGenerator

The three variants:

Current solution: Solution with truncating words (twig filter):

Solution with hyphens (this is css):

The 3rd one is very simple, I can just create a .hyphenate css class and add that in the twig file.

What do you prefer? @diosmosis @tsteur @sgiehl @Findus23

I like @diosmosis suggestion. That was my original idea, just wrap the text for equal lines, but looked weird, but just because I haven't added the - on the end 😄. Headers are already multi-line, we just break the lines only on spaces, that's why long words make wide columns.

I'll make some screenshots for different solutions and share it here.

Updated submodules:

• plugins/Bandwidth
• plugins/CustomAlerts
• plugins/CustomVariables
• plugins/LogViewer
• plugins/LoginLdap
• plugins/MarketingCampaignsReporting
• plugins/Provider
• plugins/SecurityInfo
• plugins/TasksTimetable
• plugins/TrackingSpamPrevention
• plugins/VisitorGenerator

Doc is 👍 could we maybe add at the end of this sentence maybe something like Most of the time adding an API method instead of a controller method should be considered.. You mention it already in this block but I'm thinking we might still want to make clear in most cases an API is likely the better solution. Or maybe instead of adding this we could explain with an example when the controller would be used instead of the API? I guess it's mostly only the case it the controller needs to access the session? Maybe that's what you meant with callable outside of a session?

Description:

FYI @tsteur

Review

• [ ] Functional review done
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done see checklist
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

Well changing the algorithm still means you have to deal w/ old hashes and new hashes, so I'm not sure it will really be aided by a hash table column, where we can put only one value.

FYI @tsteur

This solution seems a bit like taking on tech debt, but it's also very low risk, so it's probably the best short term solution 👍

I'm thinking it's actually the best long term solution since you want to be able to change the algorithm for how to calculate the hash at any time (eg different segment string or do it based on parsed segment expression). There is of course still the urlencode/urldecode thing but that's a different problem which we eventually will hopefully tackle with #17050 .

fyi @flamisz might be useful to know

FYI @tsteur

Good one, I do that too 👍

Thanks for this @peterbo I understand it now how it works technically. What is not 100% clear yet is when this becomes interesting or for which audience this is interesting. Of course with Matomo the benefit is this would come out of the box but spinning up a GCE is a bit more work etc so I wonder when / why companies/orgs make this effort. I'm assuming of course when they need to guarantee a certain data flow so thinking of websites with sensitive data (health/banks/...)? Does the server side usually forward cookies and IP addresses and also set cookies? I'm assuming this would need to be done to ensure things work the way they should? And the main benefit would be that if for example no consent is given then you can guarantee no such data is being processed?