profile
viewpoint
Thomas Ricouard Dimillian Glose France https://glose.com [Entrepreneur, iOS/Mac & Web dev] Work @glose Past: @google, Co-Founded @MySeeen (Share movies !) @RobinBrowser (The smart Browser).

startedCosmo/OpenSwiftUI

started time in 4 days

issue commentDimillian/SwiftUIFlux

use state in async action

In the app I'm using my library, the state is not null. Screenshot 2019-11-06 at 14 48 29

Maybe it's a side effect of something else?

megadidar

comment created time in 11 days

issue closedra1028/Carbon

Crash when building and launching for iOS 10, 11 and 12 simulator

dyld: Library not loaded: /System/Library/Frameworks/SwiftUI.framework/SwiftUI
  Referenced from: /Users/thomasricouard/Library/Developer/CoreSimulator/Devices/A09605A4-9BF2-4D63-9B5A-000D85C18FCA/data/Containers/Bundle/Application/92E5E64B-1EBD-46C3-A9A0-486C122D0E41/Glose Education Staging.app/Frameworks/Carbon.framework/Carbon
  Reason: no suitable image found.  Did find:
	/System/Library/Frameworks/SwiftUI.framework/SwiftUI: mach-o, but not built for iOS simulator

SwiftUI is not conditionally linked? I'm getting crash on launch as SwiftUI can't be linked on any earlier iOS version than 13.

closed time in 18 days

Dimillian

issue commentra1028/Carbon

Crash when building and launching for iOS 10, 11 and 12 simulator

Perfect thanks!

Dimillian

comment created time in 18 days

issue openedra1028/Carbon

Crash when building and launching for iOS 10, 11 and 12 simulator

dyld: Library not loaded: /System/Library/Frameworks/SwiftUI.framework/SwiftUI
  Referenced from: /Users/thomasricouard/Library/Developer/CoreSimulator/Devices/A09605A4-9BF2-4D63-9B5A-000D85C18FCA/data/Containers/Bundle/Application/92E5E64B-1EBD-46C3-A9A0-486C122D0E41/Glose Education Staging.app/Frameworks/Carbon.framework/Carbon
  Reason: no suitable image found.  Did find:
	/System/Library/Frameworks/SwiftUI.framework/SwiftUI: mach-o, but not built for iOS simulator

SwiftUI is not conditionally linked? I'm getting crash on launch as SwiftUI can't be linked on any earlier iOS version than 13.

created time in 20 days

startedpaololeonardi/WaterfallGrid

started time in 20 days

startedhexagons/UI3

started time in 24 days

issue commentra1028/Carbon

Weird behaviour as I scroll up

Thanks for the answer,

I have a lot of dynamic text and content, so calculating the height manually sound like a step back from self sizing UITableView. But I'll provide reference size to some static components and see if it improves.

The UITableViewReloadDataUpdater didn't helped at all :(

Dimillian

comment created time in 24 days

issue openedra1028/Carbon

Weird behaviour as I scroll up

Hello,

I'm making a fairly complexe UITableView, and I have some weird behaviours. As I scroll down, mostly no problem. As I scroll up I get really weird behaviours, like blank space (missing components?) and wrongly sized component.

Here is two images, one normal and one as I scroll up. IMG_0495 IMG_0496

Here is some code, this is a quite complexe project, so very hard for me to extract and isolate to make it easy to reproduce for you guys. But maybe something is wrong in my approach.

Here is my datasource Screenshot 2019-10-23 at 18 41 18

And also the code of one of my component as an example

struct ReadingActivityQuoteComponent: IdentifiableComponent {
    let quote: Quote?
    let isTop: Bool
    
    var id: String {
        quote?.id ?? "quoteLoading"
    }
    
    class View: UIView {
        var quote: Quote? {
            didSet {
                render()
            }
        }
        
        var isTop: Bool = false {
            didSet {
                if isTop {
                    cardView.maskedCorners = [.topLeft, .topRight]
                } else {
                    cardView.maskedCorners = []
                }
            }
        }
        
        let quoteLabel = QuoteDarkerLeft(frame: .zero)
        let cardView = CardView(frame: .zero)
        
        init() {
            super.init(frame: CGRect.zero)
            
            cardView.maskedCorners = []
            
            quoteLabel.showAnimatedGradientSkeleton()
            quoteLabel.numberOfLines = 0
        
            addSubview(cardView)
            cardView.addSubview(quoteLabel)

            
            constrain(self, cardView, quoteLabel) { parent, card, quote in
                card.top == parent.top
                card.left == parent.readableContentGuide.left + 12
                card.right == parent.readableContentGuide.right - 12
                card.bottom == parent.bottom
                
                quote.top == card.top + 12
                quote.left == card.left + 12
                quote.right == card.right - 12
                quote.bottom == card.bottom - 12
            }
        }
        
        required init?(coder: NSCoder) {
            fatalError("init(coder:) has not been implemented")
        }
        
        func render() {
            quoteLabel.hideSkeleton()
            quoteLabel.text = quote?.text
        }
    }
    
    func renderContent() -> ReadingActivityQuoteComponent.View {
        View()
    }
    
    func render(in content: ReadingActivityQuoteComponent.View) {
        content.quote = quote
        content.isTop = isTop
    }
}

Coming from a lot of SwiftUI lately, Carbon is really awesome to use in the UIKit world. But I'm having quite some issues right now. Again, I have no idea if my architecture is wrong or if I'm hitting some underlying Carbon or UITableView related bugs. I'm self sizing every component with auto layout using Cartography.

created time in 25 days

issue closedDimillian/MovieSwiftUI

App crashes on selection of the keywords cell

  1. Go to the movie detail view
  2. Wait for keywords cell to appear
  3. Select the cell
  4. App presents the next view, then navigates back to movie details view and crashes:
2019-07-05 17:04:38.789573+0100 MovieSwift[59287:8790893] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid update: invalid number of sections. The number of sections contained in the table view after the update (3) must be equal to the number of sections contained in the table view before the update (3), plus or minus the number of sections inserted or deleted (1 inserted, 0 deleted).'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff23af9c3e __exceptionPreprocess + 350
	1   libobjc.A.dylib                     0x00007fff50131de0 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff23af99b8 +[NSException raise:format:arguments:] + 88
	3   Foundation                          0x00007fff255749ad -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 191
	4   UIKitCore                           0x00007fff46e5975c -[UITableView _Bug_Detected_In_Client_Of_UITableView_Invalid_Number_Of_Sections:] + 193
	5   UIKitCore                           0x00007fff46e58861 -[UITableView _endCellAnimationsWithContext:] + 14394
	6   UIKitCore                           0x00007fff46e72a88 -[UITableView endUpdatesWithContext:] + 112
	7   UIKitCore                           0x00007fff46e72c34 -[UITableView _performBatchUpdates:withContext:completion:] + 253
	8   UIKitCore                           0x00007fff46e72d4c -[UITableView performBatchUpdates:completion:] + 98
	9   SwiftUI                             0x00007fff2c24c016 $s7SwiftUI25UpdateCoalescingTableView33_BFB370BA5F1BADDC9D83021565761A49LLC19performBatchUpdates_10completionyyycSg_ySbcSgtF + 470
	10  SwiftUI                             0x00007fff2c24c19f $s7SwiftUI25UpdateCoalescingTableView33_BFB370BA5F1BADDC9D83021565761A49LLC19performBatchUpdates_10completionyyycSg_ySbcSgtFTo + 175
	11  SwiftUI                             0x00007fff2c24e151 $s7SwiftUI19ListCoreCoordinator33_BFB370BA5F1BADDC9D83021565761A49LLC17updateUITableView_4from2toySo0mN0C_xxtF + 1521
	12  SwiftUI                             0x00007fff2c24cb61 $s7SwiftUI9_ListCore33_BFB370BA5F1BADDC9D83021565761A49LLV12updateUIView_7contextySo11UITableViewC_AA0L20RepresentableContextVyADyxq_GGtF + 657
	13  SwiftUI                             0x00007fff2c573361 $s7SwiftUI32PlatformViewRepresentableAdaptor33_19642D833A8FE469B137699ED1426762LLV06updateD8Provider_7contexty10UIViewTypeQz_AA0cdE7ContextVyADyxGGtF + 289
	14  SwiftUI                             0x00007fff2c2b322d $s7SwiftUI17PlatformViewChildV6update7contexty14AttributeGraph0H7ContextVyACyxGGz_tFyyXEfU_ + 2205
	15  SwiftUI                             0x00007fff2c2ae526 $s7SwiftUI17PlatformViewChildV6update7contexty14AttributeGraph0H7ContextVyACyxGGz_tF + 310
	16  SwiftUI                             0x00007fff2c2b4160 $s7SwiftUI17PlatformViewChildVyxG14AttributeGraph07UntypedF0AaeFP7_update_5graph9attributeySv_So10AGGraphRefaSo11AGAttributeatFZTW + 32
	17  AttributeGraph                      0x00007fff2f2f18c9 $sTA + 25
	18  AttributeGraph                      0x00007fff2f2db3ba _ZN2AG5Graph11UpdateStack6updateEv + 1104
	19  AttributeGraph                      0x00007fff2f2db639 _ZN2AG5Graph16update_attributeEjb + 377
	20  AttributeGraph                      0x00007fff2f2dff01 _ZN2AG8Subgraph6updateEj + 943
	21  SwiftUI                             0x00007fff2c18e5c0 $s7SwiftUI9ViewGraphC14runTransaction33_D63C4EB7F2B205694B6515509E76E98BLL2inySo10AGGraphRefa_tF + 224
	22  SwiftUI                             0x00007fff2c18e48d $s7SwiftUI9ViewGraphC15syncTransaction33_D63C4EB7F2B205694B6515509E76E98BLLyyAA0F0V_ySo10AGGraphRefaXEtFyAIXEfU_03$s7a23UI16AsyncTransaction33_ghijklmn18BLLC5applyyyFySo10O9RefaXEfU_AA0sF0AELLCTf1nnnc_n + 125
	23  SwiftUI                             0x00007fff2c18e374 $s7SwiftUI9ViewGraphC15syncTransaction33_D63C4EB7F2B205694B6515509E76E98BLLyyAA0F0V_ySo10AGGraphRefaXEtF03$s7a23UI16AsyncTransaction33_ghijklmn18BLLC5applyyyFySo10O9RefaXEfU_AA0sF0AELLCTf1ncn_n + 100
	24  SwiftUI                             0x00007fff2c18e2fd $s7SwiftUI16AsyncTransaction33_D63C4EB7F2B205694B6515509E76E98BLLC5applyyyF + 141
	25  SwiftUI                             0x00007fff2c1a6eac $sIeg_ytIegr_TR + 12
	26  SwiftUI                             0x00007fff2c45b031 $sIeg_ytIegr_TRTA + 17
	27  SwiftUI                             0x00007fff2c45b289 $sIeg_ytIegr_TRTA.8 + 9
	28  SwiftUI                             0x00007fff2c45a561 $s7SwiftUI16ViewRendererHostPAAE25dispatchPostUpdateActions33_6C396F98EFDD04A6B58F2F9112448013LLyyFyyXEfU_ + 193
	29  SwiftUI                             0x00007fff2c45a1e7 $s7SwiftUI16ViewRendererHostPAAE25dispatchPostUpdateActions33_6C396F98EFDD04A6B58F2F9112448013LLyyF + 439
	30  SwiftUI                             0x00007fff2c45402a $s7SwiftUI16ViewRendererHostPAAE9endUpdateyyF + 154
	31  SwiftUI                             0x00007fff2c45479d $s7SwiftUI16ViewRendererHostPAAE18performAfterUpdateyyyycF + 205
	32  SwiftUI                             0x00007fff2c182f36 $s7SwiftUI9ViewGraphC16asyncTransaction_8mutationyAA0F0V_xtAA0D8MutationRzlFAA012InvalidatingdH0V_Tg5Tm + 294
	33  SwiftUI                             0x00007fff2c2335fe $s7SwiftUI31AttributeInvalidatingSubscriberC010invalidateC033_986362D34F2D1941B9A0AD4E9CF57D06LLyyF + 334
	34  SwiftUI                             0x00007fff2c233683 $s7SwiftUI31AttributeInvalidatingSubscriberC7receivey7Combine11SubscribersO6DemandV6OutputQzF + 83
	35  SwiftUI                             0x00007fff2c233ad0 $s7SwiftUI31AttributeInvalidatingSubscriberCyxG7Combine0E0AaeFP7receiveyAE11SubscribersO6DemandV5InputQzFTW + 16
	36  Combine                             0x00007fff23245da7 $s7Combine10SubscriberP7receiveyAA11SubscribersO6DemandV5InputQzFTj + 7
	37  SwiftUI                             0x00007fff2c337083 $s7SwiftUI20SubscriptionLifetimeC10Connection33_584E3B65D1FB8867743A7329537CB053LLV7receivey7Combine11SubscribersO6DemandV6OutputQzF + 163
	38  SwiftUI                             0x00007fff2c337149 $s7SwiftUI20SubscriptionLifetimeC10Connection33_584E3B65D1FB8867743A7329537CB053LLVyx_qd__G7Combine10SubscriberAahIP7receiveyAH11SubscribersO6DemandV5InputQzFTW + 9
	39  Combine                             0x00007fff232466e3 $sTA.5 + 67
	40  Combine                             0x00007fff2321091a $s7Combine13AnySubscriberV7receiveyAA11SubscribersO6DemandVxF + 42
	41  Combine                             0x00007fff2321aa95 $s7Combine18PassthroughSubjectC7ConduitC5offeryyxF + 261
	42  Combine                             0x00007fff2321b506 $s7Combine18PassthroughSubjectC4sendyyxFyAC7ConduitCyxq__GXEfU_TA + 22
	43  Combine                             0x00007fff2321b524 $s7Combine18PassthroughSubjectC7ConduitCyxq__Gs5Error_pIggzo_AFsAG_pIegnzo_sAGR_r0_lTRTA + 20
	44  libswiftCore.dylib                  0x00007fff507395e4 $sSTsE7forEachyyy7ElementQzKXEKF + 452
	45  libswiftCore.dylib                  0x00007fff507b7a5d $ss26_RandomAccessCollectionBoxC8_forEachyyy7ElementQzKXEKF + 125
	46  libswiftCore.dylib                  0x00007fff508a0f8e $ss15_AnySequenceBoxC8_forEachyyyxKXEKFTj + 14
	47  Combine                             0x00007fff2321a949 $s7Combine18PassthroughSubjectC4sendyyxF + 457
	48  MovieSwift                          0x0000000109fd4966 $s11SwiftUIFlux5StoreC5statexvWyycfU_ + 182
	49  MovieSwift                          0x0000000109fd49ad $sIeg_IeyB_TR + 45
	50  libdispatch.dylib                   0x000000010a615e28 _dispatch_call_block_and_release + 12
	51  libdispatch.dylib                   0x000000010a616d9c _dispatch_client_callout + 8
	52  libdispatch.dylib                   0x000000010a624e54 _dispatch_main_queue_callback_4CF + 1500
	53  CoreFoundation                      0x00007fff23a5cbf9 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
	54  CoreFoundation                      0x00007fff23a57859 __CFRunLoopRun + 2329
	55  CoreFoundation                      0x00007fff23a56c16 CFRunLoopRunSpecific + 438
	56  GraphicsServices                    0x00007fff37a98bb0 GSEventRunModal + 65
	57  UIKitCore                           0x00007fff46c97bef UIApplicationMain + 1621
	58  MovieSwift                          0x0000000109e6dabb main + 75
	59  libdyld.dylib                       0x00007fff50fb24ad start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

closed time in 25 days

ekazaev

issue commentDimillian/MovieSwiftUI

App crashes on selection of the keywords cell

Yup. This was fixed by Apple in iOS 13 GM :)

ekazaev

comment created time in 25 days

startedmmackh/Catalyst-Helpers

started time in a month

issue closedDimillian/MovieSwiftUI

PopularityBadge's shadow position beyond the circle's boundary

When the score is 61%, the badge's shadow is out of the circle's boundary.

I have tested and verified that if the trim is to 0.61, the circle shape will become a part, its shadow will departure the original position.

How to solve this?

closed time in a month

liuwin7

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 21fd16b564bcab2afc0a9986a1f38d1990c8609b

New home fix for iPad + list as default

view details

push time in a month

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha a5894dda1dd16ed3d802caec8b35b5e946f4b033

New home UI Fixes + make it default

view details

push time in a month

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 3f5059ebcc0b038cbc2e24162d3da475a72ff802

WIP new home

view details

push time in a month

startedBabylonpartners/Bento

started time in a month

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 8b19083f581910076acf744fd1d7e81ef4863fb3

Fix popularity badge

view details

push time in a month

push eventDimillian/FrenchKitSwiftUIClassroom

Thomas Ricouard

commit sha 8c428272d2690d956f8c85523a14098601ecaade

Fixes app

view details

push time in a month

PublicEvent

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 73a8f2a6209dfd1b83a9ae60370dc81f0aed2429

Better state restore + iCloud

view details

push time in 2 months

startedaxi0mX/ipwndfu

started time in 2 months

issue commentReSwift/ReSwift

How to integrate with SwiftUI?

And for the interested I've made a very lightweight ReSwift for SwiftUI here: https://github.com/Dimillian/SwiftUIFlux

zhouhao27

comment created time in 2 months

starteddanielsaidi/SwiftUIBlurView

started time in 2 months

issue commentDimillian/MovieSwiftUI

UserDetaultWrapper.swift -> public var wrappedValue: T {... never sets value

If it works you could do a proper pull request, It's nice that the app will open back on the last used tab. Note; It could also be backed in a UIState in the redux app state, like the movies and peoples state, it could be saved on app quit, and restored on launch.

alancook

comment created time in 2 months

PR merged Dimillian/MovieSwiftUI

Fixes typo in `.topRated` case in APIService

I was perusing the code and noticed that this was probably intended to be .topRated.

+3 -3

1 comment

2 changed files

Steven0351

pr closed time in 2 months

push eventDimillian/MovieSwiftUI

Steven Sherry

commit sha bdfcd4aae466041235d936f80e367fc5b555e485

Fixes typo in `.topRated` case in APIService

view details

Thomas Ricouard

commit sha d23e9085d13d8a007c86432cf99950535bb7f9df

Merge pull request #27 from Steven0351/fix-top-rated-case Fixes typo in `.topRated` case in APIService

view details

push time in 2 months

pull request commentDimillian/MovieSwiftUI

Fixes typo in `.topRated` case in APIService

Thanks!

Steven0351

comment created time in 2 months

issue commentDimillian/MovieSwiftUI

UserDetaultWrapper.swift -> public var wrappedValue: T {... never sets value

My breakpoint is shown, so the code is called. Are you sure you touch save on the settings form? Screenshot 2019-09-10 at 07 45 57

alancook

comment created time in 2 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha da51805fe76a70655038eba4711fa9cff18ca4d2

Bump build + animation on buttons

view details

push time in 2 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 9ac1ac250fdfc37fb1628ecc89e837f2972563f9

Fixes for iOS 13 beta 2

view details

push time in 2 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 61a1dded908dec145047fa973a53511a63e8ed0f

Fixes

view details

push time in 3 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 8314b03c88c6d76773d9076d0ae6fb2afdafc5c7

Bump build

view details

push time in 3 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha b46e53a35aa4053df085af10bd72cf29b2ba4fa7

Add some animations + UI Fixes

view details

push time in 3 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 2d456d1c7fb903b366c08fff7a3f0841242f6b1e

UI Fixes

view details

push time in 3 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha d3e9ce75aeec1aedeb58277402ca3e8fb39240b7

UI Fixes discover

view details

push time in 3 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 102f006b03a9bab4ac655476c7436f92ccac7032

Bump build

view details

push time in 3 months

startedreduxkotlin/MovieSwiftUI-Kotlin

started time in 3 months

push eventDimillian/MovieSwiftUI

Thomas Ricouard

commit sha 25fe8fd91e2702e644f7b7cedd08366803a45fca

Upgraded for Xcode 11 beta 6

view details

push time in 3 months

more