profile
viewpoint
Benoît Jeaurond BenJeau @CDH-Studio Ottawa, Canada jeaurond.dev 4th year SEG student ~ Web, Mobile, Rust developer

BenJeau/arduino-tp-link-smart-plugs 5

Control TP-Link smart plugs with arduino and raspberry pi or any other linux system

BenJeau/JavaFX-Sudoku 5

Sudoku game with JavaFX while creating Sudoku board using a backtracking recursive algorithm

CDH-Studio/I-Talent 4

An improved directory and employee search tool

BenJeau/JavaFX-Tetris 2

Tetris game programmed in JavaFX

BenJeau/ExploreCarriere 1

Projet de la classe d'IU - SEG 3525

BenJeau/uozoneCalendar 1

Headless browser that extracts the course schedule's information from uoZone

BenJeau/WearOS-Smart-Lights 1

Quickly control TP Link smart plugs from your watch

coophub/Android-Application 1

Android application prototype for the coophub project in the SEG2900 class

BenJeau/Android-Smart-Lights 0

Control TP Link Smart plugs with an Android device

pull request commentCDH-Studio/I-Talent

[New] Add college list

Oh ok, the backend of the app is made so that it returns the English value if the French is not defined and vice-versa. I guess that is something that can be added as a notice on the admin dashboard for when people modify/add schools

MohamedRadwan

comment created time in 8 hours

pull request commentCDH-Studio/I-Talent

[New] Add college list

Yes, just so we don't have duplicate information in the database, in case they would like to update one name, they would only need to update the english one and not both

MohamedRadwan

comment created time in 8 hours

pull request commentCDH-Studio/I-Talent

[New] Add college list

I would accept it, but should the translations only be in the specified language? (I feel like it does, but if you think otherwise, I'll accept the PR)

MohamedRadwan

comment created time in 10 hours

startedsnobu/destreamer

started time in 17 hours

delete branch CDH-Studio/I-Talent

delete branch : fix-handle-error

delete time in 18 hours

issue closedCDH-Studio/I-Talent

Errors in the frontend are not properly caught - since Razzle.js

Describe the bug Since the introduction of Razzle.js, we are now using the <BrowserRouter /> instead of <Router /> because the server side rendering (SSR) from Razzle.js. The history instance cannot be passed to the <BrowserRouter />, that component creates the history instance inside of it. We need to somehow figure out how to navigate the user to the error page from that handleError() function.

I see two possible solution to this problem:

  1. Pass the history instance to the handleError() function everywhere that we call it
  2. Somehow figure out a way get an instance of history with <BrowserRouter /> (using the barebones <Router /> will cause the page to not render because of SSR)
  3. Just add a page reload after adding the /error path - the easiest solution

To Reproduce Steps to reproduce the behavior:

  1. Trigger an error
  2. See that the url has changed to /error but the content has not been refreshed

Expected behavior For the page to show the content of the /error page

closed time in 18 hours

BenJeau

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha eb46c523ced96a007be2baf30ee8d536081d378c

[Fix] Pass history to handleError (#1026) * Pass history to handleError * Fix table of errors * Cleanup error components * Fix eslint

view details

push time in 18 hours

PR merged CDH-Studio/I-Talent

Reviewers
[Fix] Pass history to handleError

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application --> Brings back what we used to have

  • Pass history object to the handleError function
  • Made the UnexpectedError page component use the same errorResult component as the other error components

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> I think this is good enough to close #800. Its not doing error boundaries, but I will open a new issue

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> Peek 2020-10-28 22-18

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+269 -248

1 comment

41 changed files

BenJeau

pr closed time in 18 hours

issue closedCDH-Studio/I-Talent

Change language toggle in navbar not vertically centered

Describe the bug The title says it

To Reproduce Steps to reproduce the behavior:

  1. Go to the landing page (logout)
  2. See the change language button not centered in the navbar

Expected behavior Fort the button to be centered vertically

Screenshots image

Additional context Potentially related to #1009

closed time in 19 hours

BenJeau

issue commentCDH-Studio/I-Talent

Change language toggle in navbar not vertically centered

Not happening anymore since the PR of the landing page

BenJeau

comment created time in 19 hours

push eventCDH-Studio/I-Talent

Mohamed Radwan

commit sha 38b1004ed19cc1d7704c2535dfd2aa9573c86698

[New] Update from Bizcharts to ChartJs (#1019) * update to charjs * reduce validator import * fix undefined issue * Remove comments

view details

Benoît Jeaurond

commit sha 5eb5813fd64d82b8f5e782ca615aa872ffaad8fb

Merge branch 'development' into fix-handle-error

view details

push time in 19 hours

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 352e09371fbf437648bc553acda3dc5b9899b09a

Fix eslint

view details

push time in 19 hours

issue commentCDH-Studio/I-Talent

Move back to npm from yarn

We should also take into consideration the benefits of yarn (parallel installation, caching of packages locally, and generation of license, if we care about that, with yarn licenses generate-disclaimer)

And from Jenkins logs, it seems to only take 2 seconds to install yarn image

Removing yarn from the docker image would mean using a custom docker image and not the official one from node.js, which is something I'm not sure we should do. Just saw the lts of node.js is v14.15, we should prob update them, if they don't introduce any bugs

Not saying that we shouldn't switch if its better, but we should look at both sides before switching

MohamedRadwan

comment created time in 19 hours

issue commentCDH-Studio/I-Talent

IE is not working (because of arrow functions)

not sure if I'll be able to touch this, this week @dynamic11 feel free to takeover - I know think its somehow related to neutrino, https://neutrinojs.org/packages/react/#polyfills, or maybe this https://neutrinojs.org/packages/web/#targets

BenJeau

comment created time in a day

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha ea4f71bb244ae16f087e5b8e82d5ae1c4a5232a9

Cleanup error components

view details

push time in a day

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 9fd586a466a5c26e23ddc5c098c341dbacf3316a

Fix table of errors

view details

push time in a day

PR opened CDH-Studio/I-Talent

Reviewers
[Fix] Pass history to handleError

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

  • Pass history object to the handleError function

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> I think this is good enough to close #800. Its not doing error boundaries, but I will open a new issue

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. -->

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+105 -76

0 comment

35 changed files

pr created time in a day

create barnchCDH-Studio/I-Talent

branch : fix-handle-error

created branch time in a day

issue openedCDH-Studio/I-Talent

Update UAT

Is your feature request related to a problem? Please describe. UAT is a month old and we should probably update it soon

Describe the solution you'd like Update UAT

Describe alternatives you've considered

Additional context

created time in a day

issue openedCDH-Studio/I-Talent

Capitalize header in OL card on profile

To Reproduce Steps to reproduce the behavior:

  1. Go to a profile
  2. Make sure the app is in French
  3. See the capitalization error in the card

Expected behavior For it to be properly capitalized

Screenshots image

created time in a day

issue openedCDH-Studio/I-Talent

Change language toggle in navbar not vertically centered

Describe the bug The title says it

To Reproduce Steps to reproduce the behavior:

  1. Go to the landing page (logout)
  2. See the change language button not centered in the navbar

Expected behavior Fort the button to be centered vertically

Screenshots image

Additional context Potentially related to #1009

created time in a day

delete branch CDH-Studio/I-Talent

delete branch : feat-landing-page

delete time in a day

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha d24b0e71ed7c48f2cdc39d78eaca5a0856fb8824

[Feat] Clean landing page (#1022) * Update landing page * Fixed layout * Actually fix it * Made mobile image a bit smaller * Fix linter

view details

push time in a day

PR merged CDH-Studio/I-Talent

[Feat] Clean landing page

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

  • Made page more responsive/centered
  • Changed images to ones from https://www.manypixels.co/gallery/

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> NA

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> Peek 2020-10-28 15-37

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+178 -85

2 comments

9 changed files

BenJeau

pr closed time in a day

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 95559628f00e11ad9f0cb3ac90766efb80ac13dd

Fix linter

view details

push time in a day

Pull request review commentCDH-Studio/I-Talent

[New] Update from Bizcharts to ChartJs

 const DashboardGraphsView = ({               }               loading={monthlyGrowth.length === 0}             >-              <Chart+              <Chart type="line" data={monthlyGrowthData} options={options} />++              {/* <Chart

Looks good, I would remove this comment and design wise for the charts, we can work on it after this is merged, unless you want to do it now

MohamedRadwan

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

push eventCDH-Studio/I-Talent

Sukhsimranpreet Sekhon

commit sha 69f274429f5f69b1f3db78715c74117d3d3b1ebd

[Fix] User dropdown tabbing (#1009) - Tab auto opens username dropdown - Will now instantly tab to dropdown elements when landing on username button/down arrow. - Also added comments for the tab index value and code.

view details

Benoît Jeaurond

commit sha 8fade44f9e628df2dfb18208720eb1d537ba064e

Remove ant design dayjs webpack plugin (#1015)

view details

Benoît Jeaurond

commit sha 5281b001096c328078f329f5fc954f0fd4efcc61

Merge branch 'development' into feat-landing-page

view details

push time in a day

delete branch CDH-Studio/I-Talent

delete branch : fix-datepicker

delete time in a day

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha 8fade44f9e628df2dfb18208720eb1d537ba064e

Remove ant design dayjs webpack plugin (#1015)

view details

push time in a day

PR merged CDH-Studio/I-Talent

Reviewers
[Fix] Ant-design datepickers

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

  • Remove ant design dayjs webpack plugin

@dynamic11 can you please test it locally to see if the date pickers works for you now?

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> fixes #1010

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> NA

+0 -10

0 comment

3 changed files

BenJeau

pr closed time in a day

issue closedCDH-Studio/I-Talent

Date pickers not working

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

closed time in a day

BenJeau

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 002f6125b9e4c165389de7282d5335a58424640f

Made mobile image a bit smaller

view details

push time in a day

pull request commentCDH-Studio/I-Talent

[New] Add college list

and to make the seeding automatic, feel free to add it to the package.json

MohamedRadwan

comment created time in 2 days

pull request commentCDH-Studio/I-Talent

[New] Add college list

Oh, I don't think we're talking about the same thing. I mean you are specifying the same thing for the French and English translations, in the init seed, it was only specified in the specific language, and was specified in the other if there would be a difference in the writing between language

MohamedRadwan

comment created time in 2 days

PR opened CDH-Studio/I-Talent

Reviewers
[Feat] Clean landing page

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

  • Made page properly responsive
  • Changed images to ones from https://www.manypixels.co/gallery/

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> NA

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> Peek 2020-10-28 15-37

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+179 -85

0 comment

9 changed files

pr created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventCDH-Studio/I-Talent

Mohamed Radwan

commit sha 74bb0f1b15a5df843c2ec4fe2fe4d413fdbea635

[Fix] update repo in template #1007

view details

Ali Nouri

commit sha 0621f223b199afa04b3acd9ba649ecf3909e9d8a

Update runtimeConfig.js (#1008)

view details

Benoît Jeaurond

commit sha c95ef50c6b8c408d99794cb68667437b7c1e9438

[Feat] Simplify ant-design custom styling (#1002) * Simplify styling * Cleanup more the override * Cleanup more * Removed comment Co-authored-by: Ali Nouri <dynamic11@users.noreply.github.com>

view details

Benoît Jeaurond

commit sha 1866c4ee53fe595f82352160eef907662ae9a080

[Feat] Switch to neutrino (#1000) * Switched to neutrino * Slimmed down validator.js * Potential fix for multiple babel-plugin-import * Remove craco config * Fixed babel issues with validator.js * Revert envs * Fix packages * Fix local env * Fix linter * Fixed env problem Co-authored-by: Ali Nouri <dynamic11@users.noreply.github.com>

view details

Benoît Jeaurond

commit sha 603e5cd5d6a2268d74227e0ef84670ee0d1c9ddb

Made path of favicon absolute (#1014)

view details

Sukhsimranpreet Sekhon

commit sha e6fe6746bac6b4959ae0ecd980780d896f8fbfad

[Fix] Search bar label in English/French (#946) - The search bar form input now has a label in English and French translation.

view details

Sukhsimranpreet Sekhon

commit sha 69f274429f5f69b1f3db78715c74117d3d3b1ebd

[Fix] User dropdown tabbing (#1009) - Tab auto opens username dropdown - Will now instantly tab to dropdown elements when landing on username button/down arrow. - Also added comments for the tab index value and code.

view details

Benoît Jeaurond

commit sha ebb1b567510bb3088882629096ff8df6f714c4d3

Merge branch 'development' into update-colleges

view details

push time in 2 days

pull request commentCDH-Studio/I-Talent

[New] Add college list

A small note here, we'll need to do the seeding in the our instances - @MohamedRadwan and @dynamic11 do we want the seeding to happen automatic? (so we don't forget in the future) If so, we just need to add yarn -s seed after the migration to this package.json script

https://github.com/CDH-Studio/I-Talent/blob/69f274429f5f69b1f3db78715c74117d3d3b1ebd/services/backend/package.json#L13

MohamedRadwan

comment created time in 2 days

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha 603e5cd5d6a2268d74227e0ef84670ee0d1c9ddb

Made path of favicon absolute (#1014)

view details

Sukhsimranpreet Sekhon

commit sha e6fe6746bac6b4959ae0ecd980780d896f8fbfad

[Fix] Search bar label in English/French (#946) - The search bar form input now has a label in English and French translation.

view details

Sukhsimranpreet Sekhon

commit sha 69f274429f5f69b1f3db78715c74117d3d3b1ebd

[Fix] User dropdown tabbing (#1009) - Tab auto opens username dropdown - Will now instantly tab to dropdown elements when landing on username button/down arrow. - Also added comments for the tab index value and code.

view details

Benoît Jeaurond

commit sha 3f6c03bcacd5d3e13d8cd8a685c999cb74d23052

Merge branch 'development' into fix-datepicker

view details

push time in 2 days

pull request commentCDH-Studio/I-Talent

[Fix] User dropdown tabbing

@SukhsimranpreetSekhon feel free to merge it

SukhsimranpreetSekhon

comment created time in 2 days

issue commentCDH-Studio/I-Talent

Google website analysis

Unsurprisingly keycloak is the request that takes the longest haha

MohamedRadwan

comment created time in 2 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 5d91e624381077ef751822ccaec853843d7af6f0

Fixed layout

view details

Benoit Jeaurond

commit sha 48d2c90500acc30d2d7f066508b0e3deaea3050d

Actually fix it

view details

push time in 2 days

create barnchCDH-Studio/I-Talent

branch : feat-landing-page

created branch time in 2 days

pull request commentCDH-Studio/I-Talent

[New] Update from Bizcharts to ChartJs

@MohamedRadwan maybe, we could use the babel plugin thing, but its not working with more than just one lib right now, I tried it and don't remember if it went down that much. I think if we see es in the analyze means that we are using the es?

MohamedRadwan

comment created time in 2 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha acb9b5c45af2f3bbcc88de3380c60e6cefaa442b

Clean up

view details

push time in 2 days

create barnchCDH-Studio/I-Talent

branch : fix-properly-set-browserlist

created branch time in 2 days

issue openedCDH-Studio/I-Talent

IE is not working (because of arrow functions)

Describe the bug The application is not working on IE

To Reproduce Steps to reproduce the behavior:

  1. Go on IE and see the application favicon forever

Expected behavior The application to work on IE

Screenshots image

Additional context I think this is related to the terser uglifier (just need to modify the arrow config https://github.com/terser/terser#compress-options)

created time in 2 days

delete branch CDH-Studio/I-Talent

delete branch : fix-loading-favicon

delete time in 2 days

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha 603e5cd5d6a2268d74227e0ef84670ee0d1c9ddb

Made path of favicon absolute (#1014)

view details

push time in 2 days

PR merged CDH-Studio/I-Talent

[Fix] Made path of favicon absolute

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application --> When loading the website not at root (landing or home screen), the loading favicon would not display. This is more visible in IE

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> fixes #1016

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> NA

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+1 -1

0 comment

1 changed file

BenJeau

pr closed time in 2 days

issue closedCDH-Studio/I-Talent

The loading I-Talent icon is not always visible (IE)

Describe the bug When loading the application not at the root path / (aka home or landing screen) and the loading icon is supposed to show, it would not.

To Reproduce Steps to reproduce the behavior:

  1. Go a path that is not root /
  2. Refresh the page (more visible in IE)
  3. See the logo not loading

Expected behavior To show the logo

closed time in 2 days

BenJeau

issue openedCDH-Studio/I-Talent

The loading I-Talent icon is not always visible (IE)

Describe the bug When loading the application not at the root path / (aka home or landing screen) and the loading icon is supposed to show, it would not.

To Reproduce Steps to reproduce the behavior:

  1. Go a path that is not root /
  2. Refresh the page (more visible in IE)
  3. See the logo not loading

Expected behavior To show the logo

created time in 2 days

issue commentCDH-Studio/I-Talent

Make frontend react bundle smaller

Kind of a regression here #1015, since I removed the ant design day.js webpack plugin (it was crashing the application, I would rather the app to be big than to crash right now)...

MohamedRadwan

comment created time in 2 days

PR opened CDH-Studio/I-Talent

Reviewers
[Fix] Ant-design datepickers

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

  • Remove ant design dayjs webpack plugin

@dynamic11 can you please test it locally to see if the date pickers works for you now?

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> #1010

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> NA

+0 -10

0 comment

3 changed files

pr created time in 2 days

create barnchCDH-Studio/I-Talent

branch : fix-datepicker

created branch time in 2 days

PR opened CDH-Studio/I-Talent

Reviewers
[Fix] Made path of favicon absolute

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application --> When loading the website not at root (landing or home screen), the loading favicon would not display. This is more visible in IE

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> NA

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> NA

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchCDH-Studio/I-Talent

branch : fix-loading-favicon

created branch time in 2 days

delete branch CDH-Studio/I-Talent

delete branch : feat-neutrino

delete time in 2 days

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha 1866c4ee53fe595f82352160eef907662ae9a080

[Feat] Switch to neutrino (#1000) * Switched to neutrino * Slimmed down validator.js * Potential fix for multiple babel-plugin-import * Remove craco config * Fixed babel issues with validator.js * Revert envs * Fix packages * Fix local env * Fix linter * Fixed env problem Co-authored-by: Ali Nouri <dynamic11@users.noreply.github.com>

view details

push time in 2 days

PR merged CDH-Studio/I-Talent

[Feat] Switch to neutrino

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

  • Removed everything related to craco
  • More deps (but smaller node_modules) - more control over the versions of our deps
  • Reduces the size of the build by a little
  • Added css minimizer and js uglifier

Note: wasn't able to apply the babel-plugin-import multiple times, https://github.com/neutrinojs/neutrino/issues/1646, hope to fix the related bug so we can have multiple instances of that plugin

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> closes #991

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> Screenshot from 2020-10-25 01-40-59

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+2388 -3978

11 comments

12 changed files

BenJeau

pr closed time in 2 days

issue closedCDH-Studio/I-Talent

Switch from craco to neutrinos.js

Is your feature request related to a problem? Please describe. I'm not sure how I didn't see this before, but react themselves recommend neutrino.js in their README. We should switch to it, since it does not rely on react-scripts and it will be less finicky updating our frontend packages. In addition, I'm not even sure if craco will support the latest version of react-scripts

Describe the solution you'd like Switch to neutrino.js

Describe alternatives you've considered We've tried react-app-rewired with customized-cra in the past, then switched to razzle.js, and now we are using craco.

Additional context https://github.com/gsoft-inc/craco/issues/205

closed time in 2 days

BenJeau

Pull request review commentCDH-Studio/I-Talent

[Fix] User dropdown tabbing

 const TopNavView = ({ isAdmin, loading, displaySearch, displayLogo, intl }) => {    // menu options for profile dropdown   const menu = (isDropdown, optionalStartMenuItems) => (-    <Menu className={isDropdown ? "dropDownMenu" : "hamburgerMenu"}>+    <Menu+      tabIndex={-1}+      tabindex="-1"

I would maybe put a small comment here explaining why this is done, and you'll need to fix the linting errors (https://cicd.ised-isde.canada.ca/blue/organizations/jenkins/DSD%2FI-Talent%2FI-Talent/detail/user-dropdown-accessibility/9/pipeline), for this one here, you'll just need to disable eslint for these two lines for the react/jsx-no-duplicate-props rule. Maybe something like /* eslint-disable react/jsx-no-duplicate-props */ then this afterwards /* eslint-enable react/jsx-no-duplicate-props */

SukhsimranpreetSekhon

comment created time in 3 days

PullRequestReviewEvent

pull request commentCDH-Studio/I-Talent

[Feat] Switch to neutrino

I fixed the local dev env issue, and not getting that keycloak error. Still looking into the react hot loader warning, but it should still work fine...

BenJeau

comment created time in 3 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 8d4c0506dba60755a53cf0af3a167f343c19317b

Fixed env problem

view details

push time in 3 days

PullRequestReviewEvent

issue commentCDH-Studio/I-Talent

Date pickers not working

Really unsure why its not working... Reverting the day.js for ant design fixes it @dynamic11 you think this is fine for now? just removing the antd-dayjs-webpack-plugin for now?

BenJeau

comment created time in 3 days

issue openedCDH-Studio/I-Talent

Date pickers not working

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

created time in 3 days

pull request commentCDH-Studio/I-Talent

[Fix] User dropdown tabbing

image

Just tried this on your branch, and it goes directly to the menu (but there still that tab twice bug, but I think its fine)

Peek 2020-10-27 13-21

SukhsimranpreetSekhon

comment created time in 3 days

issue closedCDH-Studio/I-Talent

API calls in the frontend should be standardized (using redux-thunk)

Current situation

Right now the components are making their own API calls to get data, and it may get messy passing the data to children components and making sure that the component hierarchy is structured well for passing the data down to the children. Also, we wouldn't want every child to make separate API calls, which would tax the server. In addition, this is also bloating our components with axios and the backend address import and taking into account the errors that the API may return scattered across the app/components.

Admin implementation

In the new backend change, while I was adapting the admin side of the application, I was making the API calls in the controller component and saving it to redux. Children components would subscribe to redux and get the information. But to get a good flow, I was also saving in redux if the data was loading and wasn't even saving in redux if there was an error, so the children component was not aware of an error (if one would arise).

Redux-thunk (the ultimate solution, in my opinion)

We can make asynchronous calls in redux with redux-thunk and since we are using redux-toolkit it is already built-in and way easier than using redux-thunk barebones. With redux-thunk the API calls would be made in redux, making the API calls central. It also automatically creates three action types/things the components can subscribe to, either pending, fulfilled, and rejected. To make the call, it would be similar to the custom admin implementation, where one component calls the API, but would instead dispatch an action to redux, which would in return call the API and the components wanting that information would subscribe to the action types created by redux-thunk.

I wanted to create this issue since it seems like it would clean a bit more the frontend code and remove duplication but is not super urgent to implement since our API calls are working. @dynamic11 what do you think about this?

closed time in 3 days

BenJeau

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha c95ef50c6b8c408d99794cb68667437b7c1e9438

[Feat] Simplify ant-design custom styling (#1002) * Simplify styling * Cleanup more the override * Cleanup more * Removed comment Co-authored-by: Ali Nouri <dynamic11@users.noreply.github.com>

view details

push time in 3 days

PR merged CDH-Studio/I-Talent

Reviewers
[Feat] Simplify ant-design custom styling

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application --> Just figured out that there's theming variables that can be overridden.... (which are these ones https://github.com/ant-design/ant-design/blob/master/components/style/themes/default.less)

  • Modify the ant-design theme variables instead of creating a big scss override file specifying the ant design css class names

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> NA

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. --> NA

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+71 -199

0 comment

10 changed files

BenJeau

pr closed time in 3 days

pull request commentCDH-Studio/I-Talent

[Feat] Switch to neutrino

Not sure why there's a warning about the hot reload, I can look into it, but I don't think it should cause any bug. For keycloack, I think thats related to an update, not 100% sure. But in your second image, it seems like the env.js file isn't getting created, but it worked for me yesterday.

I'll look into it

BenJeau

comment created time in 3 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 27210d69a2f80a6f9e1f822ad10a0e60bbbb84ed

Removed comment

view details

push time in 3 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 7fe51c5e9df87ac56e3bdbfb394b457fee782e18

Cleanup more

view details

push time in 3 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha d22dd91b52766d163ed6916389bd0f60611b2b4d

Fix linter

view details

push time in 3 days

issue commentneutrinojs/neutrino

Cannot use same babel plugin multiple times

Oh sorry, wasn't sure where this originated from. Thanks for the info and quick code explanation! I'll look at potentially making a fix/PR for @neutrinojs/babel-merge if I have time and it's only related to this section

BenJeau

comment created time in 4 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 8bdcc35945a076d883946b054546be9bacda2c38

Fix local env

view details

push time in 4 days

push eventCDH-Studio/I-Talent

Ali Nouri

commit sha 6a58676860118717a4f6c8e06adc730a122a53b5

[Feat] change to a drop down visibility selector (#987) - current visibility selector is not accessible - used dropdown instead of a radio group - convert popconfirm to modal due to accessibility

view details

Benoît Jeaurond

commit sha 88aa120638954f20ee6854d6d8cf0c6d2e67688f

[Feat] responsive admin (#997) * Fixed new design for hambuger menu * Made dashboard responsive * Make category table responsive * Made competency table responsive * Made collapsable side menu toggle more round * Made skills table responsive * Make diploma table responsive * Made school table responsive * Made user table responsive

view details

Mohamed Radwan

commit sha b75207389a71c1320c668c42665274893423fc2a

[Update] nodejs in docker (#1004) * Update Dockerfile.local Update to frontend to lts * Update Dockerfile * Update Dockerfile * Update Dockerfile.local

view details

Mohamed Radwan

commit sha 87fe090ea2d7bdf321f6c1dae3fd52e1f7e9bc9d

[Fix] Jenkins loadsh (#1001) * install lodash-es * update to lodash * fix lint * fix lint

view details

Benoît Jeaurond

commit sha 1b381cb62ce9a542947481470be49b16fc639dce

Changed navbar zIndex (#1005)

view details

Mohamed Radwan

commit sha 74bb0f1b15a5df843c2ec4fe2fe4d413fdbea635

[Fix] update repo in template #1007

view details

Ali Nouri

commit sha 0621f223b199afa04b3acd9ba649ecf3909e9d8a

Update runtimeConfig.js (#1008)

view details

Benoit Jeaurond

commit sha b1efc687e4b9741dc2da4e38f439a49c917857b6

Switched to neutrino

view details

Benoit Jeaurond

commit sha ff75753d2599c0d6b00c65c57fa6698c697fe451

Slimmed down validator.js

view details

Benoit Jeaurond

commit sha 980a08d3a1ee3a2b3c708c1ce72b430bfe55c5a0

Potential fix for multiple babel-plugin-import

view details

Benoit Jeaurond

commit sha 4bb254ab6b6c8e4977308d3eb950819b5c23e105

Remove craco config

view details

Benoit Jeaurond

commit sha a6b2d2bac8df207b44f2a47f5f150f813b34bf28

Fixed babel issues with validator.js

view details

Benoit Jeaurond

commit sha 139252960b5690f9a668bc6c8a7dec9069936fac

Revert envs

view details

Benoit Jeaurond

commit sha 26e9b45c886d57fc58379f9ca525b077ccf1847b

Fix packages

view details

push time in 4 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha cbd00baf0f2df23b9b896d53569fef8c3f3c3f8a

Revert envs

view details

Benoit Jeaurond

commit sha 8adad5bf0b4b3b432e7f1bb8c7974cf4bbcfbcc4

Fix packages

view details

push time in 4 days

delete branch CDH-Studio/I-Talent

delete branch : runtime-config

delete time in 4 days

push eventCDH-Studio/I-Talent

Ali Nouri

commit sha 0621f223b199afa04b3acd9ba649ecf3909e9d8a

Update runtimeConfig.js (#1008)

view details

push time in 4 days

PR merged CDH-Studio/I-Talent

Update runtimeConfig.js for separate variables for testing

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application -->

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) -->

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. -->

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+19 -2

0 comment

1 changed file

dynamic11

pr closed time in 4 days

PullRequestReviewEvent

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 7b9e9544cf76742a4de01e6ca6cdff51849c0375

Remove craco config

view details

Benoit Jeaurond

commit sha b214d0c047d1d092ba9fc8cc0b8e3de32bca9658

Fixed babel issues with validator.js

view details

push time in 4 days

push eventCDH-Studio/I-Talent

Benoit Jeaurond

commit sha 82d98cd6d80279aa1e7acf58a6d0a69ab04e331b

Cleanup more the override

view details

push time in 4 days

pull request commentCDH-Studio/I-Talent

[Fix] migrate to apex charts

What lol, that weird... I'll pull your branch and play with it a bit. But yeah, it does seem really big

MohamedRadwan

comment created time in 4 days

PullRequestReviewEvent

pull request commentCDH-Studio/I-Talent

[Fix] migrate to apex charts

For the analyze, you need to attach your shell to the frontend contianert

MohamedRadwan

comment created time in 4 days

issue commentCDH-Studio/I-Talent

Use scoped styling files

We should just utilize the nested scss/less feature maybe instead.

Ex:

.lang-header {}
.lang-title {}
.lang-buttonContainer {}

to

.lang {
  &-header {}
  &-title {}
  &-buttonContainer {}
}
BenJeau

comment created time in 4 days

delete branch CDH-Studio/I-Talent

delete branch : fix-navbar-overlay

delete time in 4 days

push eventCDH-Studio/I-Talent

Benoît Jeaurond

commit sha 1b381cb62ce9a542947481470be49b16fc639dce

Changed navbar zIndex (#1005)

view details

push time in 4 days

PR merged CDH-Studio/I-Talent

[Feat] Changed navbar zIndex

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application --> The navbar was too high and was rendering over the modals/dropdown (I think this error slipped when I was making the hamburger menu work)

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> NA

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. -->

image image

This PR: image image

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+2 -2

0 comment

1 changed file

BenJeau

pr closed time in 4 days

PR opened CDH-Studio/I-Talent

Reviewers
[Feat] Changed navbar zIndex

Changes introduced

<!-- Explain briefly in a small paragraph or in bullet form the changes this PR brings to the application --> The navbar was too high and was rendering over the modals/dropdown

Related issue(s)

<!-- If this PR fixes/closes an issue, please prepend that issue number with one of the github closing keywords (ex: fixes, closes, ...) --> NA

Screenshots (if applicable)

<!-- If you have made UI changes to the application, include a screenshot and if the change involves movement, include a GIF. If the UI changes when the application is in mobile view, show a mobile screenshot too. -->

image image

This PR: image image

Checklist

If the database has been modified:

  • [ ] Update database diagram <!-- Updated diagram located in the backend, at ./src/docs/I-Talent database.xml, with draw.io and updated the png image at ./src/docs/I-Talent database.png -->
  • [ ] Create new migration <!-- Ran yarn migrate:create in backend docker container -->

If API endpoints has been modified:

  • [ ] Update backend documentation <!-- Updated corresponding swagger documentation in the routers -->
  • [ ] Create/Update validators for the API endpoints <!-- Restrict and sanitize user input in the routers with express-validator.github.io -->
  • [ ] The API endpoints are properly secured with keycloak <!-- Use the keycloak.protect(roleName) express middleware in the routes -->

<!-- Optional for now, since tests are not working correctly

  • [ ] Create tests for your changes
  • [ ] Make sure the tests are passing -->

If the UI has been modified:

  • [ ] It is translated in both language (with no hard coded text) <!-- To sort the keys and remove unused keys in the translation files, run yarn i18n:cleanup -->
  • [ ] Has been tested on IE
  • [ ] The modifications are tab friendly
  • [ ] It is accessible
+2 -2

0 comment

1 changed file

pr created time in 4 days

create barnchCDH-Studio/I-Talent

branch : fix-navbar-overlay

created branch time in 4 days

pull request commentCDH-Studio/I-Talent

[Fix] Jenkins loadsh

I think you could add lodash to the package.json and it would work? I don't it would add it to the react-bundle, as weird as it sounds - but you can for sure just add another package.json (maybe one at the root of the repo?)

MohamedRadwan

comment created time in 4 days

push eventCDH-Studio/I-Talent

Mohamed Radwan

commit sha b75207389a71c1320c668c42665274893423fc2a

[Update] nodejs in docker (#1004) * Update Dockerfile.local Update to frontend to lts * Update Dockerfile * Update Dockerfile * Update Dockerfile.local

view details

Benoit Jeaurond

commit sha a2534bb1019a229b36e229407d7ad1144ed459ca

Simplify styling

view details

push time in 4 days

more