Andarist/babel-plugin-annotate-pure-calls 69
This plugins helps with annotating top level functions calls with #__PURE__ comment.
aaronshaf/react-callbag-subject 8
Asynchronous pipelines in React using callbags
Callbag source for connected gamepad inputs
aaronshaf/callbag-animation-frames 5
Callbag listenable source sending DOMHighResTimeStamp at display refresh rate
Callbag source for the keyboard
Andarist/are-hook-inputs-equal 3
A comparator function for previous and current React hook inputs.
aaronshaf/callbag-flatten-iter 2
Callbag operator that flattens iterables
Andarist/babel-check-duplicated-nodes 1
🐠 Babel helper module for transforms authors to check the AST against duplicated nodes.
push eventredux-saga/redux-saga
commit sha 1ecb1bed867eeafc69757df8acf1024b438a79e0
Update localized READMEs (#1888) so that they can follow the following changes https://github.com/redux-saga/redux-saga/commit/89a11479a6ed953c522b57ef23b6e14758d64278#diff-04c6e90faac2675aa89e2176d2eec7d8 https://github.com/redux-saga/redux-saga/commit/1a3b846908a0a0501955deb92a5660700646b4e8#diff-04c6e90faac2675aa89e2176d2eec7d8
commit sha 82fce4ffc16ed00139b17696e64f7d8f2a29b6ad
Version Packages
push time in an hour
push eventdavidkpiano/xstate
commit sha 7abc8c28d87286af190eb624612240a03b62426b
Small change to the type of State.inert (#2299)
commit sha 407724fa45e914f0bbe59fc5fbb97101f16b4544
Version Packages (next)
push time in an hour
pull request commentmattpocock/xstate-codegen
Fix issue with space in action/guard/etc. name
⚠️ No Changeset found
Latest commit: b289107d603daef13dedd6082007ee8d95145b34
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
<details><summary>This PR includes no changesets</summary>
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
</details>
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
comment created time in 4 hours
PR opened mattpocock/xstate-codegen
Fixes an issue whereby a space in the key name for an action, activity, guard, or service causes a failure. We do this by wrapping the name of those items in "quotes" in the output. This is achieved by editing the template file.
pr created time in 4 hours
issue openedredux-saga/redux-saga
actionChannel have a wrong typescript return type
Description of the bug/issue
actionChannel returns ActionChannelEffect type:
type ActionChannelEffect = SimpleEffect<'ACTION_CHANNEL', ActionChannelEffectDescriptor>
But take effect accepts only TakeableChannel type:
interface TakeableChannel<T> {
take(cb: (message: T | END) => void): void
}
Example
const chan = (yield actionChannel('TYPE')) as ReturnType<typeof actionChannel>;
yield take(chan); // Typescript error here
Actual results
Typescript error: Argument of type 'ActionChannelEffect' is not assignable to parameter of type 'TakeableChannel<unknown>'. Property 'take' is missing in type 'SimpleEffect<"ACTION_CHANNEL", ActionChannelEffectDescriptor>' but required in type 'TakeableChannel<unknown>'.
The Expected results
In runtime chan contains the following methods:
close: ƒ ()
flush: ƒ flush(cb)
put: ƒ put(input)
take: ƒ take(cb)
I expect that actionChannel should have a return type that covers all the above methods.
Environment information
redux-saga: 1.1.3 typescript: 4.3.2
created time in 11 hours
issue closedlivechat/angular-livechat
I've been trying to implement LiveChat in my angular website with a button in the navigation bar as opposed to the normal implementation of a button in the bottom right of the screen. I was able to make the LiveChat pop up when I click on this new button, however, it will only work when I clear my browser's cache/I visit the site for the VERY first time. If I refresh my page and then try clicking the button the LiveChat will no longer pop up. Do you know why this may be happening and how I could possibly resolve this issue?
closed time in 11 hours
nikhil-ismailissue commentemotion-js/emotion
TS Styled Plugin doesn't recognize the label property as legitimate
Since my errors were with typescript-styled-plugin
I had to use, in my tsconfig.json file
{
"extends": "expo/tsconfig.base",
"compilerOptions": {
"strict": true,
"plugins": [
{
"name": "typescript-styled-plugin",
"lint": {
"validProperties": [
"padding-vertical",
"padding-horizontal",
"shadow-color",
"shadow-offset",
"shadow-radius",
"shadow-opacity"
]
}
}
]
}
}
comment created time in 12 hours
pull request commentdavidkpiano/xstate
Small change to the type of `State.inert`
⚠️ No Changeset found
Latest commit: c8a7158527bcd440f0907828c4817cd116e8cc0e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
<details><summary>This PR includes no changesets</summary>
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
</details>
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
comment created time in 12 hours
startedAndarist/react-textarea-autosize
started time in 16 hours
pull request commentdavidkpiano/xstate
Fix non-working code example in typescript.md
This is fixed in #2235 >_>
comment created time in 16 hours
Pull request review commentdavidkpiano/xstate
Fix non-working code example in typescript.md
interface LightContext { elapsed: number; } -const lightMachine = createMachine<LightContext, LightStateSchema, LightEvent>({+const lightMachine = Machine<LightContext, LightStateSchema, LightEvent>({
const lightMachine = createMachine<LightContext, LightEvent>({
We want to use createMachine and discourage the use of StateSchema for now.
comment created time in 16 hours
pull request commentdavidkpiano/xstate
Fix non-working code example in typescript.md
⚠️ No Changeset found
Latest commit: 9661d1d33f9318b896697efcfd8575890b58b823
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
<details><summary>This PR includes no changesets</summary>
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
</details>
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
comment created time in 17 hours
PR opened davidkpiano/xstate
createMachine doesn't support this syntax: <LightContext, LightStateSchema, LightEvent>, but Machinesupports
pr created time in 17 hours
push eventdavidkpiano/xstate
commit sha 4f803e368d350cd09589988e2d62ae8151c56226
Restrict context to object or undefined
commit sha c25c4daf039b92c0a4da9ade15e5ceb9b7b5c705
Restrict context to only object, fix SCXML tests
commit sha eb0fc68b1a14411ba2da5f1de7f0d19d124b49b3
Refactor context types
commit sha f8b2869022580d2f6fc61d68c66486dcfc86295c
Fix tests
commit sha c0a6dcafa1a11a5ff1660b57e0728675f155c292
Add changeset
commit sha 0d59cf58452d508c1bfe5093107a80ae1dbbf27a
Update packages/core/src/StateNode.ts Co-authored-by: Mateusz Burzyński <[email protected]>
commit sha 7b0c44ebaffae864e7c16813d7402b2cf13a30c9
Update packages/xstate-graph/src/graph.ts Co-authored-by: Mateusz Burzyński <[email protected]>
commit sha 5cd04ee6a282047868b4a381c08618ac0704dd80
Add default context
commit sha 4b32de7e09b07737cfcdfed3d84b70302dd24bb3
Merge pull request #2294 from davidkpiano/v5/context-merging [v5] Restrict `context` to object
commit sha 01b43ceaf109df219e0d8e511378be1eb975bd6d
Version Packages (next)
push time in 17 hours
push eventdavidkpiano/xstate
commit sha 4f803e368d350cd09589988e2d62ae8151c56226
Restrict context to object or undefined
commit sha c25c4daf039b92c0a4da9ade15e5ceb9b7b5c705
Restrict context to only object, fix SCXML tests
commit sha eb0fc68b1a14411ba2da5f1de7f0d19d124b49b3
Refactor context types
commit sha f8b2869022580d2f6fc61d68c66486dcfc86295c
Fix tests
commit sha c0a6dcafa1a11a5ff1660b57e0728675f155c292
Add changeset
commit sha 0d59cf58452d508c1bfe5093107a80ae1dbbf27a
Update packages/core/src/StateNode.ts Co-authored-by: Mateusz Burzyński <[email protected]>
commit sha 7b0c44ebaffae864e7c16813d7402b2cf13a30c9
Update packages/xstate-graph/src/graph.ts Co-authored-by: Mateusz Burzyński <[email protected]>
commit sha 5cd04ee6a282047868b4a381c08618ac0704dd80
Add default context
commit sha 4b32de7e09b07737cfcdfed3d84b70302dd24bb3
Merge pull request #2294 from davidkpiano/v5/context-merging [v5] Restrict `context` to object
push time in 17 hours
PR merged davidkpiano/xstate
This PR restricts context passed into createMachine(...) or createModel(...) to be an object.
Closes https://github.com/davidkpiano/xstate/projects/1#card-40598611
pr closed time in 17 hours
Pull request review commentdavidkpiano/xstate
[v5] Restrict `context` to object
export class State< * @param stateValue * @param context */- public static from<TC, TE extends EventObject = EventObject>(- stateValue: State<TC, TE, any> | StateValue,- context?: TC | undefined- ): State<TC, TE, any> {+ public static from<+ TContext extends MachineContext,+ TEvent extends EventObject = EventObject+ >(+ stateValue: State<TContext, TEvent, any> | StateValue,+ context?: TContext | undefined+ ): State<TContext, TEvent, any> { if (stateValue instanceof State) { if (stateValue.context !== context) {- return new State<TC, TE>({+ return new State<TContext, TEvent>({ value: stateValue.value,- context: context as TC,+ context: context as TContext,
5cd04ee
comment created time in 18 hours
push eventdavidkpiano/xstate
commit sha 5cd04ee6a282047868b4a381c08618ac0704dd80
Add default context
push time in 18 hours
push eventdavidkpiano/xstate
commit sha 7b0c44ebaffae864e7c16813d7402b2cf13a30c9
Update packages/xstate-graph/src/graph.ts Co-authored-by: Mateusz Burzyński <[email protected]>
push time in 18 hours
push eventdavidkpiano/xstate
commit sha 0d59cf58452d508c1bfe5093107a80ae1dbbf27a
Update packages/core/src/StateNode.ts Co-authored-by: Mateusz Burzyński <[email protected]>
push time in 18 hours
push eventdavidkpiano/xstate
commit sha 849ec56c2a9db34e65a30af94e68a7a7a50b4158
Add changeset
push time in 18 hours
push eventdavidkpiano/xstate
commit sha 16f8dcdbfd0fbb7876a11a085ba3dea1d2ed2ed9
Add deprecation notice to docs
push time in 18 hours
push eventdavidkpiano/xstate
commit sha 7a5232de1c88c2082f29566dfeb8b12c56893c7c
Add deprecation notice
push time in 18 hours
push eventdavidkpiano/xstate
commit sha edd0625f9d992851fe45d2679f5ba8214c31d440
Update README.md
commit sha d580c1e09fb2d7f776abd41eda49535cf400212f
Remove closing bracket after timeOfDayMachine
commit sha 3b44be9eb5582a73bb7229c419c7a49a3fe9c9f3
Merge pull request #2296 from robertsargent/patch-1 Remove closing bracket after timeOfDayMachine
commit sha 23e1a0768e9d9c3695af9bcca09a2d80fc15b388
Merge branch 'main' into davidkpiano/deprecate-useservice
commit sha b79d1932c97e22f9528bfef9f85d6e13b32b4f4e
Clean up
push time in 18 hours
push eventdavidkpiano/xstate
commit sha b0cfc4823c285d0ea6546c8ecfffeb0c25cd29ca
Clean up
push time in 18 hours
pull request commentdavidkpiano/xstate
feat: add event meta to test machine event execution
Thanks for the PR! Thinking through this a bit more, instead of eventMeta, it might be useful to just pass the current State, which includes those transitions (+ meta) and potentially even more meta data that would be useful in executing the event.
comment created time in 18 hours
push eventdavidkpiano/xstate
commit sha c0a6dcafa1a11a5ff1660b57e0728675f155c292
Add changeset
push time in 19 hours
pull request commentdavidkpiano/xstate
Minor LifecycleSignal-related cleanup
There are more potential signals than starting and stopping:
export type ActorSignal =
| { type: ActorSignalType.Start }
| { type: ActorSignalType.PostStop }
| { type: ActorSignalType.Watch; ref: ActorRef<any> }
| { type: ActorSignalType.Terminated; ref: ActorRef<any> }
| { type: ActorSignalType.Subscribe; ref: ActorRef<any> }
| { type: ActorSignalType.Emit; value: any };
We have three choices:
- Give each of these signals their own method, like
.start()and.stop()(not a fan of this idea) - Add a
.receiveSignal(...)method just for these signals (would revert the previous PR, also not a fan) - Handle signals in
.receive(...)(no change, current behavior)
comment created time in 19 hours
issue openedredux-saga/redux-saga
<!--- Thanks for reporting!
Search open/closed issues before submitting since someone might have asked the same thing before! https://github.com/redux-saga/redux-saga/issues
If you have a question there is a chance that it was already answered on StackOverflow: https://stackoverflow.com/questions/tagged/redux-saga -->
Description
Please provide some context about the problem and some code examples if relevant. The best way to provide an example is repository or use Code Sandbox(there is a prepared template for Code Sandbox)
created time in a day
push eventdavidkpiano/xstate
commit sha d580c1e09fb2d7f776abd41eda49535cf400212f
Remove closing bracket after timeOfDayMachine
commit sha 3b44be9eb5582a73bb7229c419c7a49a3fe9c9f3
Merge pull request #2296 from robertsargent/patch-1 Remove closing bracket after timeOfDayMachine
commit sha fb878778e85acb46f8555777cd09f190e4d5ea59
Merge branch 'main' into next
commit sha 60cd118af09988aabd1d10a691f2962e4e543ab7
Version Packages (next)
push time in a day