profile
viewpoint
Paul O’Shannessy zpao Facebook Seattle, WA https://zpao.com I do open source things at @facebook.

reactjs/react-rails 5968

Integrate React.js with Rails views and controllers, the asset pipeline, or webpacker.

reactjs/rfcs 2653

RFCs for changes to React

reactjs/express-react-views 2409

This is an Express view engine which renders React components on server. It renders static markup and *does not* support mounting those views on the client.

sebmarkbage/art 898

Retained mode vector drawing API designed for multiple output modes. There's also a built-in SVG parser.

zpao/building-react-from-scratch 311

Code for my React Rally talk.

zpao/alwaysAsk 8

A Firefox extension to make sure you get a prompt when quitting Firefox.

petehunt/statics 4

static assets in npm

zpao/addon-compatability-reporter 2

Git clone of http://viewvc.svn.mozilla.org/vc/addons/trunk/compatibility/

zpao/aitc 2

Working space for Apps in the Cloud. Because Mercurial.

zpao/blarg 2

Blarg is my original attempt at a Ruby on Rails blogging app. It powered my website for a few years.

issue commentzpao/qrcode.react

Couldn't get lib folder

You should probably be browserifying the npm version since it's already built.

If you want to build locally clone, run yarn and run make.

iamdevelopergirl

comment created time in 8 days

push eventzpao/buck

Paul O’Shannessy

commit sha 9b1ec820184a583a94ac30757a1e22ec449efc59

Don't show appveyor status in README

view details

push time in 11 days

PR opened facebook/buck

Don't show appveyor status in readme
+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchzpao/buck

branch : rm-appveyor-readme

created branch time in 11 days

Pull request review commentfacebook/react

Move MS Windows build to CircleCI

 jobs:             RELEASE_CHANNEL: experimental           command: yarn test-build-prod --maxWorkers=2 +  test_ms_windows:+    executor:+      name: win/default+    environment: *ms_windows_environment+    steps:+      - run:+          # Fix line endings in Windows.+          command: git config --global core.autocrlf input

😑 Do we need to do this if we aren't making any commits? Also, doesn't input really only map to *nix use? (https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_code_core_autocrlf_code)

wittgenst

comment created time in 13 days

Pull request review commentfacebook/react

Move MS Windows build to CircleCI

 jobs:             RELEASE_CHANNEL: experimental           command: yarn test-build-prod --maxWorkers=2 +  test_ms_windows:+    executor:+      name: win/default+    environment: *ms_windows_environment+    steps:+      - run:+          # Fix line endings in Windows.+          command: git config --global core.autocrlf input+      - checkout+      - restore_cache:+          keys:+            - v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}+            - v2-win-node-{{ arch }}-{{ .Branch }}-+            - v2-win-node-{{ arch }}-+      - run:+          command: nvm install 10.18.1

Looks like 12.x is used on Linux, any reason to use 10.x? (it'll be in maintenance soon)

wittgenst

comment created time in 13 days

Pull request review commentfacebook/react

Move MS Windows build to CircleCI

 jobs:             RELEASE_CHANNEL: experimental           command: yarn test-build-prod --maxWorkers=2 +  test_ms_windows:+    executor:+      name: win/default+    environment: *ms_windows_environment+    steps:+      - run:+          # Fix line endings in Windows.+          command: git config --global core.autocrlf input+      - checkout+      - restore_cache:+          keys:+            - v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}+            - v2-win-node-{{ arch }}-{{ .Branch }}-+            - v2-win-node-{{ arch }}-

Should this just be - *restore_yarn_cache? Looks like that's what is used elsewhere for this step.

wittgenst

comment created time in 13 days

Pull request review commentfacebook/react

Move MS Windows build to CircleCI

 jobs:             RELEASE_CHANNEL: experimental           command: yarn test-build-prod --maxWorkers=2 +  test_ms_windows:+    executor:+      name: win/default+    environment: *ms_windows_environment+    steps:+      - run:+          # Fix line endings in Windows.+          command: git config --global core.autocrlf input+      - checkout+      - restore_cache:+          keys:+            - v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}+            - v2-win-node-{{ arch }}-{{ .Branch }}-+            - v2-win-node-{{ arch }}-+      - run:+          command: nvm install 10.18.1+      - run:+          command: nvm use 10.18.1+      - run:+          command: node --version+      - run:+          command: choco install yarn+      - run:+          command: yarn install --frozen-lockfile

Same with this *run_yarn

wittgenst

comment created time in 13 days

issue commentzpao/qrcode.react

The situation with parameters after the url will be invalid. Can you handle it? thanks(url后面带参数的情况会失效,可以处理下吗?)

There's an inherent risk to using an image in the QR Code. Specifically the risk is that it takes away too much of the actual scannable portion. By excavating (as seems to be the difference in your demos) you're actually taking away even more modules, not just the ones that are getting covered by the image. I don't have any protections in there to prevent embedding an image that covers up more than the error correction level can handle (the math got messy, transparent images change the math) so if you find yourself with a QR Code that doesn't scan, you need to correct that yourself. You have 2 options:

  1. Change the ratio of QR Code to image size. Make the image smaller or the QR Code bigger.
  2. Increase the Error level (level), which will result in smaller modules with a better ability to handle covered areas.
ctq123

comment created time in 14 days

Pull request review commentfacebook/buck

Added CircleCI macos jobs

-version: 2+version: 2.1  install_openjdk8: &install_openjdk8   name: Install OpenJDK8   command: |-    sudo apt-get update && sudo apt-get install openjdk-8-jdk-    sudo update-java-alternatives -s java-1.8.0-openjdk-amd64+    if [ "x${PLATFORM}" == "xlinux" ]+    then

I don't love having shell conditionals like this all over the place. Would it make more sense to just have separate install steps for mac & linux, rather than forcing re-use? You do that for some of the jobs, so it's not clear why not here as well.

v-jizhang

comment created time in 18 days

issue commentzpao/qrcode.react

Couldn't get lib folder

It looks like you're git cloneing and trying to build. If you're not working on this library, then I'd recommend installing using npm (or yarn if that's your jam). Does that help? If you are trying to work on this library I can help more.

iamdevelopergirl

comment created time in 18 days

MemberEvent

push eventzpao/buck

Paul O’Shannessy

commit sha 2b2395d213bdaa92c2ab6b801d4d25f9732c696d

maybe install pyenv to shell?

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha 66706dd63394c2801f1aad0ea1cff1d78519591e

run pyenv on own for more logging

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha 22b5094a5338ac30c2dbc4b6c3de42157bb8a4ed

no bashrc so run extra commands

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha 6430b45dc1e56069d69e3b73d39893587b6abf52

add pyenv to path

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha ee02221ace0baf1628ff14a4b7f35b8723e5f48d

fix fail fast

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha 2b7d154f2163525dffd0087d5cc6e23aaaa9fc1e

install pyenv, simplify matrix for now

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha c967e60ebc63a44ae69217d7fca82b9afb7f5bcc

run

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha 01cd4a36024d5fdaeebec45a8ba309550b974365

output java version better

view details

push time in a month

push eventzpao/buck

Paul O’Shannessy

commit sha ccbe3d87c24de53eb9a800031374485fff895f73

Fix actions parsing error

view details

push time in a month

push eventzpao/buck

Stiopa Koltsov

commit sha c9651f99551115ef37b6e5b83c14cf82130ec72e

configuration targets now always use ConfigurationForConfigurationTargets Summary: Internal state assertions in `TargetNodeFactory`: * configuration rules can now be only created with `ConfigurationForConfigurationTargets` * build rules (non-configuration rules) now cannot be created with `ConfigurationForConfigurationTargets` In particular, it's more clear now that configuration rules are non-configurable. It is done to avoid pitfall of possible multiple instantiations configuration rules by single unconfigured build target. Reviewed By: sbalabanov shipit-source-id: 1aee75c158

view details

Stiopa Koltsov

commit sha f13156e60cab6c34f395f3aaef8ab7ab32fae934

assert configuration target is requested with configuration target Summary: Safety net against entering endless loop of resolving configurations of configurations. Reviewed By: mykola-semko shipit-source-id: 92c32b230f

view details

Stiopa Koltsov

commit sha 9a45e768f68ab953cf6855010bff709ff4756664

rm NonResolvingRawTargetNodeToTargetNodeFactory Summary: Regular `RawTargetNodeToTargetNodeFactory` is now used for loading configuration targets instead of `NonResolvingRawTargetNodeToTargetNodeFactory`. Previous diffs assert that configurations are loaded with non-configurable platform, and this diff pulls assertion about non-configurable attributes in configuration targets into `DefaultRawTargetNodeFactory`. This is part of the work of merging configuration and build targets loading. Reviewed By: sbalabanov shipit-source-id: ce369b6d89

view details

Sean Gillespie

commit sha 18912d07e672dc297ca62a573da0c19eac74a246

Record GC collection events on the event bus Summary: Adds GC collection events to the Buck event bus so that we can correlate Buck events with potentially large GCs. Any consumer of the Buck event bus can subscribe to these events; this commit amends the MachineReadableLoggerListener to dump them to the machine readable log, but any log consumer can subscribe to them. In a follow-up diff I will try to strap it to the Chrome trace viewer to see if we can get GCs to show up there. Reviewed By: jtorkkola shipit-source-id: b73177b53a

view details

Stiopa Koltsov

commit sha 3261aa57e3b7432833ad53556f7337e5b19b12ca

remove android target_cpu_type_constraints Summary: Before this diff: ``` android_platform( name = "aaa", native_platforms = [ ":armv7", ":x86_64", ], ) android_binary( name = "bbb", cpu_filters = ["armv7", "x86_64"], target_cpu_type_constraints = { # these were used to match CPU to nested platforms "armv7": ":constraint-arvmv7", "x86_64": ":constraint-x86_64", }, ) ``` Now: ``` android_platform( name = "aaa", native_platforms = { "arvm7": ":armv7", "x86_64": ":x86_64", }, ) android_binary( name = "bbb", cpu_filters = ["armv7", "x86_64"], ) ``` Or in human words, CPU flavor to CPU configuration was previously specified per build rule, and now it is specified once per platform. Previous approach provided too much flexibility: we don't practically need different per-CPU constraints in different build rules. Not sure if current multiplatform implementation is good enough, but if it is, this changes should make it simpler. Reviewed By: sbalabanov shipit-source-id: 9a8f229628

view details

Sean Gillespie

commit sha 9dc8d58c626156df58a01f6807bf37e356f9fa61

Yet another anonymous class to static class Summary: This is a bug waiting to happen if this argument gets serialized to a ModernBuildRule (see D17831767). This is the final remaining Arg subclass that is anonymous or nested. Reviewed By: stepancheg shipit-source-id: 1eba6282ee

view details

Sean Gillespie

commit sha 980faf1f34b8b3ffc184e62961d0e123f9549703

Extract SynlinkProxyArg to static inner class Summary: Like D17539453, D17557066, and D17579771, ModernBuildRule does not allow anything captured in the transitive closure of a buildable to be an anonyous class. This converts (yet another) anonymous class to a private static class so that it can be captured by ModernBuildRules. I'd like to apply some static analysis to this so that we can stop playing whack-a-mole with random Buck crashes, but alas, for now fixing them as they pop up is effective. Reviewed By: rajyengi shipit-source-id: 8884b72f3b

view details

Michal Sienkiewicz

commit sha 38ae3c17bf57e94f79ad5c799e4f892d061258ef

Delete legacy thrift structs and utils Reviewed By: stepancheg shipit-source-id: 8ab6ca4396

view details

Michal Sienkiewicz

commit sha 5f22b9744e66ed1ca113b9a8dcafba9619f918ab

Mover remaining thrift (frontend) code from distributed to frontend package Summary: All code remaining in distributed/ is for communication with frontends so moving to frontend package. Reviewed By: stepancheg shipit-source-id: be2b65aef1

view details

Farris Nabulsi

commit sha 1011df358975a648af397ffcbfd22dcebe3e72d5

"Re-landing "Adding proper msvc supported system include prefix"" Summary: Re-submitting proper msvc system includes support. Previously when D17721437 landed, it caused some breakages for some clang-cl builds because their `cpp_type` and `cxxpp_type` were both set to `windows`. D17829765 fixed this, making this change safe to land. Reviewed By: stepancheg shipit-source-id: 657b9908d8

view details

Stiopa Koltsov

commit sha 7b3d954c00350b6be0d4691bdea4596afe07fa95

pull getName to ConstructorArg Summary: Each rule must have a name, even UDR, so pull `getName` into the most base `ConstructorArg` interface. Reviewed By: bobyangyf shipit-source-id: 5646eac2d1

view details

Stiopa Koltsov

commit sha bfe8fe8968a520fe93b742b4f0c43b849369cefc

validate rule arg is either configuration rule arg or build rule arg Summary: Each rule must be either configuration or build, exactly one of them. This diff validates `ConstructorArg` subclasses, each subclass must implement either `ConfigurationRuleArg` or `CommonDescriptionArg` (renamed to `BuildRuleArg` in the following diff). Assertion is not implemented for UDR, which should be build rules, but does not yet implement `CommonDescriptorArg`. Validation happens in `CoercedTypeCache`. Reviewed By: sbalabanov shipit-source-id: ebdbf5e79e

view details

Sergey Balabanov

commit sha b7b0841ca7aa520bf0991d0f455118197b03be64

Buck Graph Engine to honor synlinked build files Summary: If build file is a symlink, it is skipped during build file discovery if done with Graph Engine which causes commands like `buck targets --show-parse-state` //... to skip some packages, effectively not parsing the whole universe. Reviewed By: mykola-semko shipit-source-id: c006e003ca

view details

Michal Sienkiewicz

commit sha b209de19e20752862a773b5df3659f6ccd341780

Clean up LocalBuildExecutor Summary: Half of the API ad the existence of BuildExecutor interface was for the purpose of supporting Stampede. Deleting all that (+moving comments from the interface) Reviewed By: mykola-semko shipit-source-id: 0921990d8a

view details

Michal Sienkiewicz

commit sha d2710a23790a928c12eb64345f52d2f79c191899

Remove Local prefix from LocalBuildExecutor Summary: Local prefix is confusing now - it's a legacy name. Reviewed By: mykola-semko shipit-source-id: 15b4af2929

view details

Stiopa Koltsov

commit sha 6c489426afc7734a9b06a6cb80b444b402182c16

push HasTargetCompatibleWith to CommonDescriptionArg Summary: All build rules have compatibility parameter, so push them down to `CommonDescriptorArg` and remove `HasTargetCompatibleWith`. Reviewed By: sbalabanov shipit-source-id: 0c154ea8bd

view details

Stiopa Koltsov

commit sha 309691937130b787767028080547d6c03405199b

rename CommonDescriptorArg to BuildRuleArg Summary: `CommonDescriptorArg` is used for all build rules, and not used for any configuration rules, so rename it to `BuildRuleArg` for clarity. Reviewed By: mzlee shipit-source-id: ad6f5708de

view details

Stiopa Koltsov

commit sha 84ae397cd57bfe9edb9e9adfa6dc911774ffb455

Fix Buck log formatting Summary: Buck logger assumes `%s`-style formatting (it is in the javadoc). Buck logger is implemented using `java.util.logging`. `java.util.logging` assumes `{}`-style formatting. So we should invoke `String.format` before invoking `java.util.logging` functions to avoid violating `java.util.logging` protocol and supplying a custom formatter. Reviewed By: mykola-semko shipit-source-id: 6ff82d43e2

view details

Michal Sienkiewicz

commit sha 3281c799be9bee32a5c662d32700e2a0557ad1a5

Remove references to stampede/distbuild Summary: Removing remaining references in code: comments, constants, variables (including the whole executor service setup for "heavy download from cache" which was stampede-specific) and one more script. Reviewed By: stepancheg shipit-source-id: 240809b321

view details

Michal Sienkiewicz

commit sha a76d9fcb5b317e87af106fafde70c3b0939f1201

Cleanup config files Summary: Removing legacy configs Reviewed By: stepancheg shipit-source-id: 4c2573f580

view details

push time in a month

create barnchzpao/buck

branch : actions

created branch time in a month

issue closedzpao/qrcode.react

Incorrect canvas size parameters

When I rendered my QR code as PNG, I set the size property as 512, but when I'm downloading the PNG image I got a 1024x1024 image.

Снимок экрана 2019-07-12 в 20 25 10

The problem is you use incorrect canvas params when you render a canvas element.

I've got style="height: 512px; width: 512px;" but canvas attributes waswidth=1024 and height=1024.

How to solve this problem? May I do pull request to fix this? There is any way to solve the problem in the current version?

closed time in a month

CoonJS

issue closedzpao/qrcode.react

How can I render QR Code on a PDF?

HI,

I want to render a QR code generated on the fly to a PDF. For generating pdf I am using react-pdf/renderer.

Here is my code -

import React from "react";
import {Page, Text, View, Document, StyleSheet, Image} from "@react-pdf/renderer";
import QRCode from "qrcode.react";

export function PdfDocument(props) {
    return (
        <Document>
        <Page size="A4">    
          <View>
            <Text>Section #1</Text>
          </View>
          <View>
            <Text>Section #2</Text>
            <QRCode value="Hello" />
            
          </View>
        </Page>
      </Document>
    );
}

But I am getting the following error -

Error: Invalid element of type canvas passed to PDF renderer

From what I understand I think I need to convert the QR code to a png or jpeg before rendering it to a pdf. But I am not sure how to do it?

Can you please help me? How I can accomplish this?

closed time in a month

iCHAIT

issue commentzpao/qrcode.react

How can I render QR Code on a PDF?

I'm not planning on supporting alternate renderers. If you'd like to generate a data blob then you'll probably want to use the underlying qrcode library directly.

iCHAIT

comment created time in a month

issue commentzpao/qrcode.react

The situation with parameters after the url will be invalid. Can you handle it? thanks(url后面带参数的情况会失效,可以处理下吗?)

This works fine in every qrcode scanning app I tested with (iOS camera, iOS Firefox, 2 other qrcode readers). Do you have another example?

ctq123

comment created time in a month

create barnchfacebook/mysql-5.6

branch : gh-pages

created branch time in 2 months

issue closedzpao/qrcode.react

About inline styles on canvas

I don't think the inline styles 'width' and 'height' on canvas is necessary. It's not friendly for users to use their own css.

closed time in 2 months

limin19860601

issue commentzpao/qrcode.react

About inline styles on canvas

These are necessary in order to create high resolution qrcodes in canvas. We double the actual element height/width based on pixel ratio, draw everything twice as big, and use the inline style to downsize back to the actual size specified.

These styles can be overridden if desired. Please read through https://github.com/zpao/qrcode.react#custom-styles

limin19860601

comment created time in 2 months

issue closedzpao/qrcode.react

Add images inside the qr code

I am attempting to generate QR codes with a cut out in the middle so I can place an image inside. Something along the lines of:

<img src="https://user-images.githubusercontent.com/19930241/70221887-6bfcc300-1749-11ea-93ce-33cc4f9a1f20.png" width="100" height="100" />

Maybe this is a feature request, but more of an investigation. Is it possible to do something like this with this library?

closed time in 2 months

bitttttten

issue commentzpao/qrcode.react

Add images inside the qr code

Yes as of 1.0. Check the imageSettings prop: https://github.com/zpao/qrcode.react/blob/master/README.md#available-props

bitttttten

comment created time in 2 months

issue commentreactjs/express-react-views

Error: Cannot find module 'babel-core'

Did you get this worked out? Not much I can do about another package needing babel-core :/

blakewilson

comment created time in 3 months

push eventreactjs/express-react-views

Paul O’Shannessy

commit sha 8fdfa85fffefa26e0930c0e24057efb881504ec4

Fix dynamic example Fixes #140

view details

push time in 3 months

issue closedreactjs/express-react-views

Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3"

  • Downloaded examples/dynamic into a separate folder
  • Removed express-react-views dependency from package.json
  • Did npm install and npm install express-react-views
  • Ran npm start

Seeing the following error

C:\Users\vis\Desktop\express-react-views\dynamic>npm start

> dynamic-views@0.1.0 start C:\Users\vis\Desktop\express-react-views\dynamic
> browserify -t babelify views/main.js --standalone main -o public/main.js  && node app.js

Error: Requires Babel "^7.0.0-0", but was loaded with "6.26.3". If you are sure you have a compatible version of @babel/core, it is likely that something in your build process is loading the wrong version. Inspect the stack trace of this error to look for the first entry that doesn't mention "@babel/core" or "babel-core" to see what is calling Babel. (While processing preset: "C:\\Users\\vis\\Desktop\\express-react-views\\dynamic\\node_modules\\@babel\\preset-react\\lib\\index.js") while parsing file: C:\Users\vis\Desktop\express-react-views\dynamic\views\main.js

closed time in 3 months

informvisu

issue closedreactjs/express-react-views

Dynamic example is vulnerable to XSS

https://github.com/reactjs/express-react-views/blob/934ff60446101d0001eb45496f72966e9c42e051/examples/dynamic/views/Html.js#L51

Only "script" is escaped, so we can work around that

diff --git a/examples/dynamic/app.js b/examples/dynamic/app.js
index 1c405b6..cb8c81c 100644
--- a/examples/dynamic/app.js
+++ b/examples/dynamic/app.js
@@ -13,7 +13,7 @@ app.get('/', function(req, res) {
     items: [
       'document your code',
       'drop the kids off at the pool',
-      '</script><script>alert(666)</script>',
+      '</SCRIPT><SCRIPT>alert(666)</SCRIPT>',
     ],
     text: '',
   };

closed time in 3 months

Alexendoo

issue commentreactjs/express-react-views

Dynamic example is vulnerable to XSS

Eh, it's just an example and not meant to be a definitive way to use this. The dynamic example isn't officially supported as a pattern anyway. Appreciate the vigilance though :)

Alexendoo

comment created time in 3 months

issue commentreactjs/express-react-views

React component use

Not sure what the problem is here. Your error mentions eslint, which is odd. But you may need to override the babel config if you're using module syntax.

In all honesty, I'd recommend something like next.js these days.

hyphen1370

comment created time in 3 months

PR closed reactjs/express-react-views

fix regexp to match absolute paths CLA Signed

On my machine (Ubuntu 15, Node 6.7.0), require.cache[module].filename returns absolute paths. If a relative path was set for the view directory express-react-views wouldn't match the filenames.

This changes the regexp to now check for absolute and relative paths.

+5 -1

1 comment

1 changed file

CarlOlson

pr closed time in 3 months

pull request commentreactjs/express-react-views

fix regexp to match absolute paths

Haven't heard anything in long time and I failed to follow-up so just doing garbage collection. Sorry for my slacking and letting this fall through :(

CarlOlson

comment created time in 3 months

PR closed reactjs/express-react-views

Check for Modules Existence Before Deleting

We have some weird issue at PayPal where we see this module variable as undefined and it will blow up, but only when we have the webpack eslint plugin enabled. I don't know why it is, but this fixes the issue, assume eslint messes with the require.cache or something? A bit weird, but wondering if you'd consider this change (or not).

+1 -1

3 comments

1 changed file

xjamundx

pr closed time in 3 months

pull request commentreactjs/express-react-views

Check for Modules Existence Before Deleting

Doing cleanup and never followed up, so assuming this either got worked out (or y'all stopped using this).

xjamundx

comment created time in 3 months

PR closed reactjs/express-react-views

Use pure functions. CLA Signed

Views cannot have state. Using pure functions makes it easier to read the examples.

+18 -30

4 comments

1 changed file

gajus

pr closed time in 3 months

pull request commentreactjs/express-react-views

Use pure functions.

I had done this a while back and forgot to push :(. Readme has functional components now.

gajus

comment created time in 3 months

pull request commentreactjs/express-react-views

Babel preset ES2015 and react are required

These are explicitly deps as of v0.10, so no longer an issue.

mweibel

comment created time in 3 months

push eventreactjs/express-react-views

Bernabe Felix

commit sha 4e3de56a557ce16304e7e3951f63739dd57f7a63

Update readme links (#138)

view details

push time in 3 months

PR merged reactjs/express-react-views

Update readme links

Updated the following links:

  1. React
  2. EJS
  3. HBS
+3 -3

0 comment

1 changed file

BernabeFelix

pr closed time in 3 months

push eventreactjs/express-react-views

dependabot[bot]

commit sha 7d8ba205a4ed3cfc66e8ab90f093b6b723afe455

Bump lodash from 4.17.10 to 4.17.15 (#150) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.10...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 months

PR merged reactjs/express-react-views

Bump lodash from 4.17.10 to 4.17.15 dependencies

Bumps lodash from 4.17.10 to 4.17.15. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

1 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

push eventreactjs/express-react-views

dependabot[bot]

commit sha e004efb47f73e9e6fcaeca4b8e98478c45ede5a5

Bump react-dom from 16.5.2 to 16.12.0 (#152) Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) from 16.5.2 to 16.12.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v16.12.0/packages/react-dom) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 months

PR merged reactjs/express-react-views

Bump react-dom from 16.5.2 to 16.12.0 dependencies

Bumps react-dom from 16.5.2 to 16.12.0. <details> <summary>Release notes</summary>

Sourced from react-dom's releases.

16.12.0 (November 14, 2019)

React DOM

  • Fix passive effects (useEffect) not being fired in a multi-root app. (@​acdlite in #17347)

React Is

  • Fix lazy and memo types considered elements instead of components (@​bvaughn in #17278)

Artifacts

• react: https://unpkg.com/react@16.12.0/umd/ • react-art: https://unpkg.com/react-art@16.12.0/umd/ • react-dom: https://unpkg.com/react-dom@16.12.0/umd/ • react-is: https://unpkg.com/react-is@16.12.0/umd/ • react-test-renderer: https://unpkg.com/react-test-renderer@16.12.0/umd/ • scheduler: https://unpkg.com/scheduler@0.18.0/umd/

16.11.0 (October 22, 2019)

React DOM

  • Fix mouseenter handlers from firing twice inside nested React containers. @​yuanoook in #16928
  • Remove unstable_createRoot and unstable_createSyncRoot experimental APIs. (These are available in the Experimental channel as createRoot and createSyncRoot.) (@​acdlite in #17088)

Artifacts

• react: https://unpkg.com/react@16.11.0/umd/ • react-art: https://unpkg.com/react-art@16.11.0/umd/ • react-dom: https://unpkg.com/react-dom@16.11.0/umd/ • react-is: https://unpkg.com/react-is@16.11.0/umd/ • react-test-renderer: https://unpkg.com/react-test-renderer@16.11.0/umd/ • scheduler: https://unpkg.com/scheduler@0.17.0/umd/

16.10.2 (October 3, 2019)

React DOM

  • Fix regression in react-native-web by restoring order of arguments in event plugin extractors (@​necolas in #16978)

Artifacts

• react: https://unpkg.com/react@16.10.2/umd/ • react-art: https://unpkg.com/react-art@16.10.2/umd/ • react-dom: https://unpkg.com/react-dom@16.10.2/umd/ • react-is: https://unpkg.com/react-is@16.10.2/umd/ • react-test-renderer: https://unpkg.com/react-test-renderer@16.10.2/umd/ • scheduler: https://unpkg.com/scheduler@0.16.2/umd/

16.10.1 (September 28, 2019)

React DOM

</tr></table> ... (truncated) </details> <details> <summary>Changelog</summary>

Sourced from react-dom's changelog.

16.12.0 (November 14, 2019)

React DOM

  • Fix passive effects (useEffect) not being fired in a multi-root app. (@​acdlite in #17347)

React Is

  • Fix lazy and memo types considered elements instead of components (@​bvaughn in #17278)

16.11.0 (October 22, 2019)

React DOM

  • Fix mouseenter handlers from firing twice inside nested React containers. @​yuanoook in #16928
  • Remove unstable_createRoot and unstable_createSyncRoot experimental APIs. (These are available in the Experimental channel as createRoot and createSyncRoot.) (@​acdlite in #17088)

16.10.2 (October 3, 2019)

React DOM

  • Fix regression in react-native-web by restoring order of arguments in event plugin extractors (@​necolas in #16978)

16.10.1 (September 28, 2019)

React DOM

  • Fix regression in Next.js apps by allowing Suspense mismatch during hydration to silently proceed (@​sebmarkbage in #16943)

16.10.0 (September 27, 2019)

React DOM

Scheduler (Experimental)

  • Improve queue performance by switching its internal data structure to a min binary heap. (@​acdlite in #16245)
  • Use postMessage loop with short intervals instead of attempting to align to frame boundaries with requestAnimationFrame. (@​acdlite in #16214)

useSubscription

  • Avoid tearing issue when a mutation happens and the previous update is still in progress. (@​bvaughn in #16623)

</tr></table> ... (truncated) </details> <details> <summary>Commits</summary>

  • b53ea6c [Bugfix] Passive effects triggered by synchronous renders in a multi-root app...
  • 01bce8c Change legacy-events plugin nativeEventTarget to allow null (#17344)
  • b8f8258 Split ReactDOM entry point (#17331)
  • a7b4d51 Warn when doing createRoot twice on the same node (another approach) (#17329)
  • be3bfa6 [Flight] Basic Integration Test (#17307)
  • e701632 [react-interactions] Change unmount blur logic to a dedicated event (#17291)
  • dee0304 [Flight] Basic Streaming Suspense Support (#17285)
  • cb09dbe [react-interactions] Add handleSimulateChildBlur upon DOM node removal (#17225)
  • f4148b2 [Flight] Move around the Server side a bit (#17251)
  • fadc971 [Flight] Add Client Infrastructure (#17234)
  • Additional commits viewable in compare view </details> <details> <summary>Maintainer changes</summary>

This version was pushed to npm by lunaruan, a new releaser for react-dom since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+12 -4

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

push eventreactjs/express-react-views

dependabot[bot]

commit sha 6be59c341040dabccd8f3ef9d46870ec947d7bb9

Bump js-yaml from 3.12.0 to 3.13.1 (#151) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](https://github.com/nodeca/js-yaml/compare/3.12.0...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 months

PR merged reactjs/express-react-views

Bump js-yaml from 3.12.0 to 3.13.1 dependencies

Bumps js-yaml from 3.12.0 to 3.13.1. <details> <summary>Changelog</summary>

Sourced from js-yaml's changelog.

3.13.1 / 2019-04-05

  • Fix possible code execution in (already unsafe) .load(), #480.

3.13.0 / 2019-03-20

  • Security fix: safeLoad() can hang when arrays with nested refs used as key. Now throws exception for nested arrays. #475.

3.12.2 / 2019-02-26

  • Fix noArrayIndent option for root level, #468.

3.12.1 / 2019-01-05

  • Added noArrayIndent option, #432. </details> <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

pull request commentreactjs/express-react-views

Bump lodash from 4.17.10 to 4.17.15

@dependabot recreate

dependabot[bot]

comment created time in 3 months

push eventreactjs/express-react-views

dependabot[bot]

commit sha dae4b115f962ea613775e3283a9d0f3a5f2d0466

Bump eslint-utils from 1.3.1 to 1.4.3 (#147) Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.3. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](https://github.com/mysticatea/eslint-utils/compare/v1.3.1...v1.4.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 months

PR merged reactjs/express-react-views

Bump eslint-utils from 1.3.1 to 1.4.3 dependencies

Bumps eslint-utils from 1.3.1 to 1.4.3. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+9 -7

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

PR closed reactjs/express-react-views

chore() - update docs with functional components

This PR combines several updates of README.md:

  • use functional components (similar to PR #78)
  • updates links, rename Jade to Pug (similar to #138)

I think the examples in /examples also need some updating (maybe using hooks for the dynamic one). What do you think @zpao? I could create another PR for that.

+34 -47

3 comments

1 changed file

vnglst

pr closed time in 3 months

pull request commentreactjs/express-react-views

chore() - update docs with functional components

Sorry! I actually had basically these changes already committed locally and released in v0.11, just forgot to push (for a year… yikes). I just pushed them up. Appreciate the contribution though!

vnglst

comment created time in 3 months

push eventreactjs/express-react-views

Paul O’Shannessy

commit sha fb324d0ef755cab9e79ceb796fa5838db1327857

Just use yarn ┏┓ ┃┃╱╲ ┃╱╱╲╲ in this ╱╱╭╮╲╲ house ▔▏┗┛▕▔ we ╱▔▔▔▔▔▔▔▔▔▔╲ use yarn. ╱╱┏┳┓╭╮┏┳┓ ╲╲ ▔▏┗┻┛┃┃┗┻┛▕▔

view details

push time in 3 months

created tagreactjs/express-react-views

tagv0.11.0

This is an Express view engine which renders React components on server. It renders static markup and *does not* support mounting those views on the client.

created time in 3 months

push eventreactjs/express-react-views

Paul O’Shannessy

commit sha 22847fbcdc44f9f2897afda439c97d8615bf6c0e

Use function components in example/readme

view details

Paul O’Shannessy

commit sha 66cfbaf1047005ece72af8e787d90a2752e019ef

Update changelog for v0.11.0

view details

Paul O’Shannessy

commit sha 742d2792d0ed2a3b1dc9bd06b26c664d7af0e0bb

0.11.0

view details

Paul O’Shannessy

commit sha 54844987774de2befd57bb674b80cf2165498bcd

Merge branch 'master' of github.com:reactjs/express-react-views

view details

push time in 3 months

issue commentzpao/qrcode.react

QR creates wrong authenticator on iPhone X

You're qr decodes to

otpauth://totp/Venbot.ro?secret=INWTUSRBM5RUO6JX&algorithm=SHA512

I have no idea how you're generating that link but you have an algorithm specified already in there.

dandamian83

comment created time in 3 months

issue commentzpao/qrcode.react

QR creates wrong authenticator on iPhone X

That Binance qr doesn't specify an algorithm param. And the Google authenticator examples do but use sha1, which is the default anyway afaict. Your qr specified sha512. So I suspect you aren't actually testing the bad flow in any of the other examples.

dandamian83

comment created time in 3 months

pull request commentzpao/qrcode.react

add logo to qrcode

I shipped a new version last week.

cssivision

comment created time in 3 months

issue commentzpao/qrcode.react

QR creates wrong authenticator on iPhone X

Since other apps are generating correct tokens, and the decoded QR Code looks correct, I'm going to say that I suspect there's an issue with Google Authenticator. In fact, this part of their wiki seems particularly damning: https://github.com/google/google-authenticator/wiki/Key-Uri-Format#algorithm. If they're ignoring the algorithm argument and defaulting to a different one than you're expecting, then maybe that is what's causing the issue. Note though that while this open source version exists, they say it's not the same as what they actually ship (and the Android app is a different codebase) so may be a red herring.

dandamian83

comment created time in 3 months

issue closedzpao/qrcode.react

Chinese garbled-中文乱码

when I scan the qrCode which has Chinese content, the content on my phone is garbled. how can I do to solve it? has anyone can tell me some ways ? thanks a lot.

closed time in 3 months

Monkey-D-Jie

issue commentzpao/qrcode.react

qrcode.react 生成的二维码是永久的吗

What others said - with stable input (same options, like error level) the generated QR Code will be the same.

wangyapeng

comment created time in 3 months

issue closedzpao/qrcode.react

Error: code length overflow. (24532>23648)

Apparently passing a long value to <QrCode/> makes it crash. Any workaround for this?

closed time in 3 months

mehrdad-shokri

issue commentzpao/qrcode.react

Error: code length overflow. (24532>23648)

No, sorry. We use the byte mode encoding to get support for unicode. This means we have a max of 2,953 characters (actually less if using unicode since that's multibyte).

mehrdad-shokri

comment created time in 3 months

issue closedzpao/qrcode.react

Qrcode not working

Hi, Qrcode not working after build but working in development.

closed time in 3 months

jurjees23

issue commentzpao/qrcode.react

Qrcode not working

The fix for this shipped in v0.9.3 in February.

jurjees23

comment created time in 3 months

issue commentzpao/qrcode.react

什么时候可以更新 自己配置生成带logo的二维码?

I added this in v1.0.0 today. See the readme for usage.

yilin1013

comment created time in 3 months

issue closedzpao/qrcode.react

Feature Request: Support custom template

Hi, i need to combine an image as template with qr-code. i can create a canvas an draw two image in it, but do you have a better ideas a new feature?

closed time in 3 months

alieslamifard

issue closedzpao/qrcode.react

Feature Request: Support custom logo

Thanks for developing this tool. Is it possible to render a custom logo in the centre of the QR code please?

Something like:

<QRCode {...props}>
	<img src='./my-logo.png' alt='' />
</QRCode>

closed time in 3 months

artdevgame

issue commentzpao/qrcode.react

Feature Request: Support custom logo

I added this in v1.0.0 today. See the readme for usage.

artdevgame

comment created time in 3 months

issue closedzpao/qrcode.react

can i create qr code with logo?

can i create qr code with logo?

closed time in 3 months

hfutzhu

issue commentzpao/qrcode.react

can i create qr code with logo?

I added this in v1.0.0 today. See the readme for usage.

hfutzhu

comment created time in 3 months

issue closedzpao/qrcode.react

add img (logo) api not found?

is update release ?

closed time in 3 months

zhuoxiaoqiang

issue commentzpao/qrcode.react

add img (logo) api not found?

I added this in v1.0.0 today. See the readme for usage.

zhuoxiaoqiang

comment created time in 3 months

pull request commentzpao/qrcode.react

add img (logo) and download api

I added support for embedding in #81 (and shipped in v1.0.0). I didn't add support for downloading yet as I don't think I want to do it the way you have here. In particular, I'm not convinced always rendering to canvas is best and I can see an argument for downloading the vector format if rendered as SVG. I'll leave this open to revisit. Thanks for doing this and inspiring me to actually get something supported!

pastleo

comment created time in 3 months

push eventzpao/qrcode.react

Paul O’Shannessy

commit sha 68e217b18f748b2a5d197eaaedf51fe91bf3bf9c

Updates

view details

push time in 3 months

created tagzpao/qrcode.react

tagv1.0.0

A <QRCode/> component for use with React.

created time in 3 months

push eventzpao/qrcode.react

Paul O’Shannessy

commit sha cdc6521b143ef67874abc1cd6f43b5141c712c4e

Update changelog for v1.0.0

view details

Paul O’Shannessy

commit sha 64ab1ce2895baae6f5715829306b0dba9c97258d

1.0.0

view details

push time in 3 months

delete branch zpao/qrcode.react

delete branch : include-image

delete time in 3 months

PR closed zpao/qrcode.react

Upgrade dependencies

Just some housecleaning.

The only change to the published package is that the prop-types dependency foes from ^15.6.0 to 15.6.2.

+1044 -933

3 comments

2 changed files

realityking

pr closed time in 3 months

pull request commentzpao/qrcode.react

Upgrade dependencies

Just did a bunch of this myself (forgot this existed, sorry!)

realityking

comment created time in 3 months

pull request commentzpao/qrcode.react

style: reformat code using `yarn pretty`

Sorry, had reformatting in another PR and didn't mean to have flow-typed get formatted

eventualbuddha

comment created time in 3 months

push eventzpao/qrcode.react

Paul O’Shannessy

commit sha 2c23b2e96b2c5e6b7c1847249c773eff42a82540

Fix Prettier set-up Was resulting in flow-typed being formatted. Also locked the version in package.json just in case anybody contributing doesnn't use yarn.

view details

push time in 3 months

push eventzpao/qrcode.react

Paul O’Shannessy

commit sha 47caec9faa3e64c41acb0bc16471d333f0d84210

Upgrade dependencies

view details

Paul O’Shannessy

commit sha 7acb7207906c3ca79687df88b5107076ddf4fa7b

Upgrade Flow & import updated flow-typed defs

view details

push time in 3 months

issue closedzpao/qrcode.react

No usable data found

I had issue when using camera iphone hw with IOS:12.1.4 and messenger appear "No usable data found". How can i fix this issue.Sorry, my english is not good. Thanks

closed time in 3 months

v4n8877

issue commentzpao/qrcode.react

Incorrect canvas size parameters

In order to support high density displays (eg Macbook with retina), that size multiplying and setting style is needed. It does have the side effect of making the actual image 2x larger when downloaded. There's no way to really fix that right now :/

FWIW this is the same behavior you get if you just take a screenshot on your computer. The PNG you get out is actually 2x your screen resolution.

CoonJS

comment created time in 3 months

issue commentzpao/qrcode.react

android8.1无法显示二维码怎么办

Not sure, don't have such a device to test. Probably something with the browser not supporting canvas? Maybe try the SVG renderer.

chengliting

comment created time in 3 months

issue closedzpao/qrcode.react

new line in the QR code

How to make a new line in the QR code ,thanks

closed time in 3 months

myttrx

issue commentzpao/qrcode.react

new line in the QR code

Add them as you would in any other JS string - \n. eg value="this\ncontains\nnewlines"

myttrx

comment created time in 3 months

push eventzpao/qrcode.react

Paul O’Shannessy

commit sha 42e910815297769b582ce4153d40dbb6d50720d9

Add support for embedding an image into QRCode (#81)

view details

push time in 3 months

PR merged zpao/qrcode.react

Add support for embedding an image into QRCode

Obviously a much requested feature. I held off for so long in part because I didn't really like the options I've seen and because I haven't had the time needed to give. In particular, nothing really fits the spirit of leaving the QRCode itself as pure as possible (with modules partially obscured). I also really wanted to try to respect the error correction capacities of a QRCode and not allow images to cover more than what could be corrected, as well as not cover position and alignment markings nor timing patterns. Basically make it so that people couldn't screw it up.

I succeeded in the former (excavate option here), but not the latter. I'll have to settle for allowing people to shoot themselves in the foot.

Special thanks to @cssivision for opening #7 years ago. This was the simplest approach and I probably should have just merged this as a first step. Also to @pastleo for #72. This was much closer to what I would want but still not quite what I was looking for.

+346 -28

0 comment

4 changed files

zpao

pr closed time in 3 months

push eventzpao/qrcode.react

dependabot[bot]

commit sha 15fc3250dd470688704199a2f4f9fe0f51c0d858

Bump lodash from 4.17.11 to 4.17.15 (#94) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.15. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.15) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 3 months

more