profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/zoldar/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Adrian Gruntkowski zoldar @todo-computer Gdańsk, Poland https://todo.computer software developer

aerosol/Tabula 70

:u7533: Pretty printer for maps/structs collections (Elixir)

jaceklaskowski/librarian-clojure 22

Book manager in Clojure

zoldar/python-ldap-test 19

Easy to setup in-memory LDAP server for tests.

zoldar/HTTPhoton 3

WIP. Yet another HTTP client wrapper lib for Elixir. This time it's katipo.

zoldar/ldap-test-server-py4j 2

An LDAP test server for use with py4j gateway. Part of a library for easy testing of Python code speaking to LDAP.

zoldar/om-with-tests-template 2

A Leiningen template for creating Om applications with a continuous testing setup.

zoldar/hushchat 1

Playing around with ssh api in Elixir. Nothing interesting for now.

sketch-hq/absinthe 0

The GraphQL toolkit for Elixir

sketch-hq/phoenix_pubsub_redis 0

The Redis PubSub adapter for the Phoenix framework

zoldar/absinthe 0

The GraphQL toolkit for Elixir

push eventsketch-hq/sketch-assistants

Christian Klotz

commit sha 9ee7d596262656ac2ddb6a12ae0f326378902b8b

Update dependencies (#191) * Update dependencies * Update lockfile * Add changeset

view details

github-actions[bot]

commit sha 200ffba91e4ff7c0dbcebe22238bbfa665aaa096

Version Packages

view details

push time in a day

push eventsketch-hq/sketch-assistants

Christian Klotz

commit sha 9ee7d596262656ac2ddb6a12ae0f326378902b8b

Update dependencies (#191) * Update dependencies * Update lockfile * Add changeset

view details

push time in a day

delete branch sketch-hq/sketch-assistants

delete branch : chore/update-dependencies

delete time in a day

pull request commentsketch-hq/sketch-assistants

Update dependencies

🦋 Changeset detected

Latest commit: 728224eef0fa3e63e89c98ab2279ac14310a107b

The changes in this PR will be included in the next version bump.

<details><summary>This PR includes changesets to release 6 packages</summary>

Name Type
@sketch-hq/sketch-core-assistant Patch
@sketch-hq/sketch-assistant-cli Patch
@sketch-hq/sketch-assistant-utils Patch
@sketch-hq/sketch-naming-conventions-assistant Patch
@sketch-hq/sketch-reuse-suggestions-assistant Patch
@sketch-hq/sketch-tidy-assistant Patch

</details>

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

christianklotz

comment created time in a day

create barnchsketch-hq/sketch-assistants

branch : chore/update-dependencies

created branch time in a day

push eventelixir-ecto/ecto

José Valim

commit sha 651f55425bdfe1876effa0b60c276a6eb20c0221

Improve error message for giving replace to put_assoc

view details

push time in a day

PR opened sketch-hq/sketch-assistants

Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@sketch-hq/sketch-assistant-utils@6.5.0

Minor Changes

  • d034e3b: Change rule config merge behaviour. Instead of overwriting the entire rule config, options are overwritten individually.

@sketch-hq/sketch-assistant-cli@6.5.0

Patch Changes

  • Updated dependencies [d034e3b]
    • @sketch-hq/sketch-assistant-utils@6.5.0
+21 -13

0 comment

9 changed files

pr created time in a day

create barnchsketch-hq/sketch-assistants

branch : changeset-release/main

created branch time in a day

push eventsketch-hq/sketch-assistants

Christian Klotz

commit sha d034e3b530fdcc5445706d472c9c6b03db1570fb

Change config merge behaviour (#189) * Merge rule configurations from right to left Similar to rules themselves, the rule configurations are now merged from right to left so that options can be partially owerwritten. Resolves #188 * Add changeset * Use strict typing

view details

push time in a day

delete branch sketch-hq/sketch-assistants

delete branch : feature/188-change-config-merge-behaviour

delete time in a day

issue closedsketch-hq/sketch-assistants

Change config merge behaviour for extended Assistants

Currently, extending an Assistant will merge any new Assistant configuration with the configuration provided by the base Assistant. However, any existing rule configs are replaced, not merged, by newly provided rule configs.

Given an original configuration such as:

{
  rules: {
    'rule-1': {
      active: true,
    },
    'rule-2': {
      active: true,
      foo: 1,
    },
    'rule-3': {
      active: true,
      bar: "hello",
      baz: "world",
    },
  }
}

… extending the Assistant with the following config:

{
  rules: {
    'rule-1': {
      active: false,
    },
    'rule-3': {
      active: true,
      baz: "everyone",
    },
}

… will result in:

{
  rules: {
    'rule-2': {
      active: true,
      foo: 1,
    },
    'rule-3': {
      active: true,
      baz: "world",
    },
  }
}

This configuration is invalid because rule-3 does not include all required properties with bar missing. One option is to always provide a full configuration for each rule but this seems inconsistent given that the Assistant configuration overall can be partial.

Instead of shallow merging rules, it would be better to deep merge them as it makes it easier to tweak existing Assistants.

closed time in a day

christianklotz

push eventsketch-hq/sketch-assistants

Christian Klotz

commit sha 6b8c187dac123911bb416f0f60c316d2af8ae9d3

Use strict typing

view details

push time in a day

Pull request review commentsketch-hq/sketch-assistants

Change config merge behaviour

 const assign = (...sources: AssistantDefinition[]): AssistantDefinition => {         ...(typeof acc.config.defaultSeverity === 'undefined'           ? {}           : { defaultSeverity: acc.config.defaultSeverity }),-        rules: {-          ...curr.config.rules,-          ...acc.config.rules,-        },+        rules: Object.entries(curr.config.rules).reduceRight(+          (a: { [key: string]: any }, [name, opts]) => {

Is it feasible to avoid any here? Could maybe use Record?

Record<string, RuleConfigOption>

or similar?

christianklotz

comment created time in 2 days

issue commentsketch-hq/sketch-assistants

Change config merge behaviour for extended Assistants

Right, indeed … I omitted the one with the active: false. Your version is the desired one.

christianklotz

comment created time in 2 days

pull request commentsketch-hq/sketch-assistants

Change config merge behaviour

🦋 Changeset detected

Latest commit: 30f7bfc20d0e3c5858ff99f633bae5eb09c1c334

The changes in this PR will be included in the next version bump.

<details><summary>This PR includes changesets to release 2 packages</summary>

Name Type
@sketch-hq/sketch-assistant-utils Minor
@sketch-hq/sketch-assistant-cli Minor

</details>

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

christianklotz

comment created time in 2 days

push eventsketch-hq/sketch-assistants

Christian Klotz

commit sha 30f7bfc20d0e3c5858ff99f633bae5eb09c1c334

Add changeset

view details

push time in 2 days

issue commentsketch-hq/sketch-assistants

Change config merge behaviour for extended Assistants

I think your final code block above should be

{
  rules: {
    'rule-1': {
      active: false,
    },
    'rule-2': {
      active: true,
      foo: 1,
    },
    'rule-3': {
      active: true,
      baz: "everyone",
    },
  }
}
christianklotz

comment created time in 2 days

issue openedsketch-hq/sketch-assistants

Change config merge behaviour for extended Assistants

Currently, extending an Assistant will merge any new Assistant configuration with the configuration provided by the base Assistant. However, any existing rule configs are replaced, not merged, by newly provided rule configs.

Given an original configuration such as:

{
  rules: {
    'rule-1': {
      active: true,
    },
    'rule-2': {
      active: true,
      foo: 1,
    },
    'rule-3': {
      active: true,
      bar: "hello",
      baz: "world",
    },
  }
}

… extending the Assistant with the following config:

{
  rules: {
    'rule-1': {
      active: false,
    },
    'rule-3': {
      active: true,
      baz: "everyone",
    },
}

… will result in:

{
  rules: {
    'rule-2': {
      active: true,
      foo: 1,
    },
    'rule-3': {
      active: true,
      baz: "world",
    },
  }
}

This configuration is invalid because rule-3 does not include all required properties with bar missing. One option is to always provide a full configuration for each rule but this seems inconsistent given that the Assistant configuration overall can be partial.

Instead of shallow merging rules, it would be better to deep merge them as it makes it easier to tweak existing Assistants.

created time in 2 days

pull request commentelixir-ecto/ecto

Add Ecto.Enum.mappings/2

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

v0idpwn

comment created time in 3 days

push eventelixir-ecto/ecto

felipe stival

commit sha 790616281a787a9f5715476c62d811b8b64beedd

Add Ecto.Enum.mappings/2 and Ecto.Enum.dump_values/2 (#3676) * Add Ecto.Enum.mappings/2 The `mappings/2` function returns the enum values and their respective mappings in a keyword list. * Add Ecto.Enum.dump_values/2 This function return dump values for a given schema and field.

view details

push time in 3 days

PR merged elixir-ecto/ecto

Add Ecto.Enum.mappings/2

The mappings/2 function returns the enum values and their respective mappings in a keyword list.

+92 -32

7 comments

3 changed files

v0idpwn

pr closed time in 3 days

pull request commentelixir-ecto/ecto

Clearer error message when a map is expected for an embedded struct.

Ah right, thanks! I tried it but I'm still getting an exception from Ecto.Repo.Queryable.load!/5 first. I'll continue checking...

azizk

comment created time in 3 days

pull request commentelixir-ecto/ecto

Add Ecto.Enum.mappings/2

Sounds good to me. While dump_values doesn't seem like the most useful function, I think having it and values combined gives us enough consistency without sacrificing ergonomics. Will address that

v0idpwn

comment created time in 4 days

pull request commentelixir-ecto/ecto

Add Ecto.Enum.mappings/2

Another option is to have values, dump_values, and mappings. So we extend the existing API with two types of values for clarity?

v0idpwn

comment created time in 4 days

pull request commentelixir-ecto/ecto

Add Ecto.Enum.mappings/2

Added a commit with the deprecation. I'm not really a fan of it it because I find Ecto.Enum.values/2 to be really ergonomic.

v0idpwn

comment created time in 4 days