zertosh ( Andres Suarez )

I was looking to implement Div for Path and came across: https://github.com/rust-lang/rust/pull/62989#issuecomment-515697585, which led me here. The path! macro (https://github.com/dtolnay/trybuild/blob/9b92eb13813a6da4c5b135626a52ff18d9d7ba26/src/path.rs) implemented here is really cool. Any chance you can publish that as its own crate?

created time in 21 days

pull request commentfacebook/react-native

Remove FB copyright notices from iOS template

@TheSavior, the template/ directory is already excluded from the linter. If you want to make sure these files don't get license header by mistake, then just add a pattern lint for "copyright" that covers these files.

alloy

comment created time in 2 months

issue openedsoc/dirs-rs

sudo and $HOME

When running with sudo, dirs-rs returns directories for the user calling sudo and not the user that's running under sudo.

On the surface this can seem like expected behavior but it becomes a real problem when a tool is run with sudo, uses dirs::cache_dir, and ends up creating that directory when it doesn't exist.

Unsetting $HOME before using dirs-rs causes dirs-sys-rs's home_dir to use getpwuid_r in the "fallback" logic. This ends up returning the home dir for the user running under sudo. But it's a really ugly workaround. Although sudo has an -H flag to replace $HOME, you don't tend to expect a tool to end up creating a ~/.cache owned by say root when you don't use -H.

I'm not sure if it's a good idea to never trust $HOME, but would it be possible to offer another set of methods that use the "real home dir"?

created time in 2 months

pull request commentrust-lang/git2-rs

Bump versions of git2 and libgit2-sys

Thank you!

alexcrichton

comment created time in 3 months

pull request commentrust-lang/git2-rs

Add a missing initialization in `Patch::from_buffers`.

Can a release be made with this fix please?

alexcrichton

comment created time in 3 months

Pull request review commentrust-lang/git2-rs

Implement Debug for Patch and related diff structs

 impl<'a> Binding for DiffLine<'a> {     } } +impl<'a> std::fmt::Debug for DiffLine<'a> {+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {+        let mut ds = f.debug_struct("DiffLine");+        if let Some(old_lineno) = &self.old_lineno() {+            ds.field("old_lineno", old_lineno);+        }+        if let Some(new_lineno) = &self.new_lineno() {+            ds.field("new_lineno", new_lineno);+        }+        ds.field("num_lines", &self.num_lines())+            .field("content_offset", &self.content_offset())+            .field("content", &self.content())

I wonder if it makes more sense to print this field like so:

.field("content", &format_args!("[{} bytes]", self.content().len()))

zertosh

comment created time in 3 months

PR opened rust-lang/git2-rs

Implement Debug for Patch and related diff structs

These are tricky structs to debug and understand. They can really benefit from being Debug-printable.

+76 -0

1 commit in zertosh/git2-rs/tree/patch-debug rust-lang/git2-rs/tree/master

0 comment

2 changed files

pr created time in 3 months

create barnchzertosh/git2-rs

branch : patch-debug

created branch time in 3 months

fork zertosh/git2-rs

libgit2 bindings for Rust

https://docs.rs/git2

rust-lang/git2-rs zertosh/git2-rs

fork in 3 months

pull request commentpvinis/react-native

[pull] master from facebook:master

What's the reason for moving the LICENSE word to the next line?

I'm unifying the license headers internally. Our guidelines have had LICENSE on the second line for a long time, plus there are more files with LICENSE on the second line than on the first (across all Facebook projects). So it was hard to justify keeping a variant of this header with LICENSE on the first line.

pull[bot]