profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/yyoncho/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

emacs-ng/emacs-ng 912

A new approach to Emacs - Including TypeScript, Threading, Async I/O, and WebRender.

emacs-lsp/dap-mode 886

Emacs :heart: Debug Adapter Protocol

emacs-lsp/lsp-java 484

lsp-mode :heart: java

emacs-lsp/lsp-treemacs 233

lsp-mode :heart: treemacs

emacs-lsp/lsp-docker 145

Scripts and configurations to leverage lsp-mode in docker environment

emacs-lsp/lsp-sourcekit 76

lsp-mode :heart: Apple's sourcekit

emacs-lsp/helm-lsp 63

lsp-mode :heart: helm

yyoncho/company-box 6

A company front-end with icons

issue commentemacs-lsp/lsp-mode

Ability to disable hint diagnostics request

Before looking for other solutions, have you tried prefixing unused args with _?

herberthamaral

comment created time in 16 hours

issue commentemacs-lsp/lsp-mode

symbol-overlay like persistent highlights

@yyoncho do you think that would be possible to make an integration just like we did with iedit?

It seems like it will be possible with small adjustments on symbol-overlay side to allow plugging lsp-mode (cc @purcell)

mpenet

comment created time in 2 days

push eventemacs-lsp/lsp-mode

Saulius Menkevičius

commit sha d5d7a54dee2622d3fd884638617f4957e1876018

lsp-csharp.el: remove `--version xxx` when installing csharp-ls using dotnet tool (#3100) * lsp-csharp.el: remove `--version xxx` when installing csharp-ls using dotnet tool * New versions of csharp-ls no longer have -alpha suffix we don't need to bind to a particular version anymore; * Shortened naming style for lsp-csharp.el functions related to csharp-ls. * clients/lsp-csharp.el: use lsp-async-start-process to install csharp-ls

view details

push time in 3 days

PR merged emacs-lsp/lsp-mode

lsp-csharp.el: remove `--version xxx` when installing csharp-ls using dotnet tool client

A small future-proofing change so we don't need to update lsp-csharp.el every time csharp-ls gets an update released:

  • New versions of csharp-ls no longer have -alpha suffix we don't need to bind to a particular version anymore;

  • Shortened naming style for lsp-csharp.el functions related to csharp-ls.

+14 -15

0 comment

1 changed file

razzmatazz

pr closed time in 3 days

issue closedemacs-lsp/lsp-metals

dap-debug not working in gradle project

Describe the bug Unable to run gradle project via dap-debug, while lsp-lens functions well.

To Reproduce A minimal project to reproduce the issue: scala3gradle.zip

Logs

LSP :: `workspace/executeCommand' with `debug-adapter-start' failed.

(error "Internal error.")
lsp-metals-populate-config: Wrong type argument: hash-table-p, #("LSP :: `workspace/executeCommand' with `debug-adapter-start' failed.

closed time in 3 days

HuangBoHong

push eventemacs-lsp/lsp-metals

Iaroslav Zeigerman

commit sha 8b2efbc7e78181c148460c0a461a4a386134a6db

Add project ID setting support to the DAP debug templates to allow values other than 'root'

view details

Iaroslav Zeigerman

commit sha 021380e334e7ac58dadf066feb8a679686109daf

Rename the 'projectId' attribute to 'buildTarget' in DAP debug templates

view details

Ivan Yonchovski

commit sha 695291761b2a3db734c3f53bb7fc4acfe0a5eb94

Merge pull request #59 from izeigerman/issue-57 Resolve #57. Add project ID setting support to DAP debug templates to allow values other than 'root'

view details

push time in 3 days

PR merged emacs-lsp/lsp-metals

Resolve #57. Add project ID setting support to DAP debug templates to allow values other than 'root'

This is to support project layouts that don't have an umbrella module with name root which encompasses all submodules. More details can be found in the corresponding issue (https://github.com/emacs-lsp/lsp-metals/issues/57).

This change introduces a new setting projectId which can be specified as part of the DAP configuration template. Here is an example of a template which uses a new setting:

(dap-register-debug-template
  "Scala Attach Core"
  (list :type "scala"
        :request "attach"
        :name "Scala Attach Core"
        :projectId "core"
        :hostName "localhost"
        :port 5005))
+4 -1

6 comments

1 changed file

izeigerman

pr closed time in 3 days

pull request commentemacs-lsp/lsp-metals

Resolve #57. Add project ID setting support to DAP debug templates to allow values other than 'root'

@izeigerman I am not scala user, not sure how to test but I saw that @HuangBoHong tested it, so I will approve and merge it.

izeigerman

comment created time in 3 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha 4225e6d461a5da0140b622df9fa227b5a97b31f4

WIP

view details

push time in 4 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha ca983907ef8fd33f75a93e393b536223e976dffa

WIP

view details

push time in 4 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha 263aae82ab3b47ef4e83c82a5802335106cad88c

WIP

view details

push time in 4 days

Pull request review commentemacs-lsp/lsp-mode

lsp-csharp.el: remove `--version xxx` when installing csharp-ls using dotnet tool

 is returned so lsp-mode can display this file."                   (with-temp-buffer (insert-file-contents metadata-file-name)                                     (buffer-string)))))) +(defun lsp-csharp--cls-download-server (_client callback error-callback update?)+  "Install/update csharp-ls language server using `dotnet tool'.++Will invoke CALLBACK or ERROR-CALLBACK based on result. Will update if UPDATE? is t"+  (let ((exit-code (call-process "dotnet" nil nil nil+                                 "tool"+                                 (if update? "update" "install")+                                 "-g" "csharp-ls")))+    (if (zerop exit-code)+        (funcall callback)+      (funcall error-callback))))

here you should pass a message to the error callback. FTR we tend to use lsp-async-start-process to execute install processes which will pop up compilation buffer which will help the users figure out what the issue is.

razzmatazz

comment created time in 4 days

PullRequestReviewEvent

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha 7fb6f191933f8ad15a857b035afc671275ccc873

WIP

view details

push time in 4 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha 6b376039517cf1c0ed45b4fba444e670f7fe3e3d

WIP

view details

push time in 4 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha f3c3888ec90f2501894594c039e7f303af25a1cc

WIP

view details

push time in 4 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha 34abec7c66f5570172f29ddeae8fb1c62113ca6f

WIP

view details

push time in 4 days

push eventyyoncho/lsp-gitpod

Ivan Yonchovski

commit sha bef99f08f95d773eea1a13d386f884956ac818cc

WIP

view details

push time in 4 days

pull request commentemacs-lsp/dap-mode

drop '_' from test function/method prefix

Thank you!

TauPan

comment created time in 5 days

push eventemacs-lsp/dap-mode

Friedrich Delgado

commit sha 00e1a5d70c32019800b8eb09d2fbcecbcb727a16

drop '_' from test function/method prefix (#507) fixes #505

view details

push time in 5 days

issue closedemacs-lsp/dap-mode

Use prefix "test" instead of "test_" for matching test methods.

One minor quirk while testing #503 (with 5d1aa24a38bfc5dadedd6bd399791a550749e627 which arrived on melpa yesterday).

The test method must be named test_<something> for this to work... I usually name the first test method or function in a module/class simply test for lack of a better idea what I want to test (while exploring things), which is ok with pytest, and this promptly gave me the same error as before :-)

(defun dap-python--test-p (lsp-symbol)
  (let ((name (dap-python--symbol-name lsp-symbol)))
    (and (or (string= (dap-python--symbol-type lsp-symbol) "Function")
             (string= (dap-python--symbol-type lsp-symbol) "Method"))
         (s-starts-with? "test_" name))))

see https://docs.pytest.org/en/6.2.x/goodpractices.html#conventions-for-python-test-discovery which is not really consistent with the example in https://docs.pytest.org/en/6.2.x/getting-started.html#group-multiple-tests-in-a-class which speaks of test_ prefixed methods.

But this is not really important as my test methods or functions (and everybody elses, I guess) usually match the test_* glob.

Originally posted by @TauPan in https://github.com/emacs-lsp/dap-mode/issues/503#issuecomment-915901833

closed time in 5 days

TauPan

push eventemacs-lsp/dap-mode

Friedrich Delgado

commit sha 66128fd52b1deef86849dfb39695efd5b28586b1

make dap-python--debug-test-at-point work (#504)

view details

push time in 5 days

PR merged emacs-lsp/dap-mode

make dap-python--debug-test-at-point work

After #503 was merged I could run dap-debug and select the template, but binding dap-python-debug-test-at-point directly did not.

At first I got the error that the template is not a string and then that the templates doesn't have :type (which it did, it was just wrong and the error was misleading).

Fortunately I was able to fix those myself.

+2 -2

2 comments

1 changed file

TauPan

pr closed time in 5 days

startedmeain/evil-textobj-tree-sitter

started time in 6 days

push eventyyoncho/lsp-mode

Ivan Yonchovski

commit sha 6508d94540cc09a4dcef7aaac88ded5a97be5177

Better visuals for signature help - use page-break-lines-mode to separate the sections

view details

push time in 6 days

push eventyyoncho/lsp-mode

Aaron Gonzales

commit sha 192cbd69d19589299ed6483418b4bc7f0c10e598

feat: use `name` instead of `description` for bettter readability (#2977) * feat: use `name` instead of `description` for bettter readability * feat: use `description` & `name` for selection of `yaml` schema

view details

Ivan Yonchovski

commit sha 690e25f32ccaa2935b346faf15b5d19538deadb0

Move use-package integration in separate folder

view details

Stepan Lusnikov

commit sha 83a12d53622d6e0f7fb96e6c5576dee28c26e134

Add svelte to lsp-language-id-configuration (#2982)

view details

Wilfred Hughes

commit sha f80334da2f899e7bc176ff471b115a7d75a93265

Format lsp-rust variable docstrings (#2983) Replace \n with newlines and use quoting syntax that Emacs recognises.

view details

Jen-Chieh Shen

commit sha 8848d6288c6ecc671f65191b20a511a206e9f728

Allow error when fontlock (#2984)

view details

Jen-Chieh Shen

commit sha 2156708fdfef8ca9931bab5cf2c0dfecb435d4ab

Add comment for allow fontlock error (#2985)

view details

amnore

commit sha e3053b581464a8869df129b476d84919202fb4e9

Make enum behave as type in semantic highlighting (#2988)

view details

brotzeit

commit sha 44c05acfe87d236dc161a152d3e0414a7e1da813

fix docstring

view details

Vitalii

commit sha f96c7ad1b2ddb456fafde00cbf07ed3d27d0ce0b

add k8s-mode to lsp-yaml client (#2991)

view details

Daniel Neiter

commit sha 9aa22de1b2424a44c8c4a3f9e03b3f9a39636a77

Use hack-indent-offset for on-type-formatting in hack mode (#2992) Previously for lsp--get-indent-width was falling back to "default" case for hack-mode, resulting in inconsistent formatting (hack mode defaults to 2 spaces, default is 4). Add hack-mode case using correct hack-indent-offset.

view details

sebastiansturm

commit sha 1f7ccca8047321cee20288646c89b55825868d83

Address #2448 (#2790) * adds support for delta and refresh requests. Also fixes flicker in combination with underlying highlighting mechanisms if those mechanisms were to dynamically adjust font-lock regions (clojure mode's syntax highlighter and tree-sitter-hl are prominent examples) Address #2448 Co-authored-by: Sebastian Sturm <s.sturm@arkona-technologies.de>

view details

Eric Dallo

commit sha bdae0f406d040366193a359ab70f55af30e928ae

[semantic-tokens] Add/remove tokens when toggle minor-mode

view details

Eric Dallo

commit sha a186cfe0f9120477a9cf6cba84f66852cc148fe0

[docs] Update support link to github sponsors

view details

Eric Dallo

commit sha cd47168035c98c6ebf9177705b9b7da53fcc9f5f

Consider activation-fn from client during library-fn check (#3000) * Consider activation-fn from client during library-fn check * Use lsp--matching-clients?

view details

kiennq

commit sha 4a33a850307c9f44cc7a7ce1bc9fe8f001c4cccf

lsp-completion: fix completion context by using non-essential value (#3004)

view details

amnore

commit sha 21dd93ee4add2086d9006e0e6143553bdaa61519

Add missing semantic tokens from lsp spec (#3007)

view details

Sorixelle

commit sha 5dca1b02f352fadf06c8da295f871464d8069b01

Miscellaneous ESLint client changes and additions (#3008) * Cleanup and add new eslint client configuration options * Implement behaviour for lsp-eslint-validate * Support eslint client on Svelte files * Upgrade ESLint server 2.1.14 -> 2.1.23 * Add ESLint server version to lsp-eslint-unzipped-path to force update * Warn user to update ESLint server on execution permission prompt * Update CHANGELOG

view details

Gerry Agbobada

commit sha 888bfa496eec5932772c35de79f17dd7a3915508

[lsp-rust] Add stopAtEntry for debugging lens (#3009) * [lsp-rust] Add stopAtEntry for debugging lens This ensures to get control at least once when running a single test * [lsp-rust] Add control to dap args in debug lens

view details

sebastiansturm

commit sha 403307d61e9bdcfec661dd358b4f23c90d653488

Minor semantic tokens cleanup (#3001) * Pass workspace to lsp--semantic-tokens-on-refresh * Make semanticTokens/refresh handling configurable * Don't initialize semantic tokens twice per buffer Co-authored-by: Sebastian Sturm <s.sturm@arkona-technologies.de>

view details

Ivan Yonchovski

commit sha ed1735cf2a6a73b25e587125520edf36e02f30d1

Fix small issue related to debugging in lsp-rust

view details

push time in 6 days

pull request commentemacs-lsp/lsp-mode

Clarify enabling Rust inlay hints in docs

Thank you!

132ikl

comment created time in 6 days