profile
viewpoint

amasad/sane 328

sane aims to be fast, small, and reliable filesystem watcher. No bells and whistles, just change events.

bryan-bartow/homebridge-alarm.com 33

Alarm.com plugin for Homebridge

rean/rain-workload-toolkit 30

Rain is a statistics-based workload generation toolkit that uses parameterized and empirical distributions to model the different classes of workload variations.

yungsters/homebridge-daylight 14

Daylight plugin for Homebridge

yungsters/node-somfy-synergy 10

A JavaScript interface for the Somfy Synergy API (myLink).

yungsters/homebridge-urtsi 5

Somfy Universal RTS Interface (URTSI) plugin for Homebridge.

yungsters/homebridge-mylink 3

Somfy myLink plugin for Homebridge.

yungsters/fbjs 1

A collection of utility libraries used by other Facebook JS projects.

yungsters/flow-lint 1

Lints @flow files for unused types.

yungsters/jscodeshift 1

A JavaScript codemod toolkit.

push eventfacebookincubator/idx

dependabot[bot]

commit sha ae089e9c153539d8c31c559e15e0200b7fcc1975

Bump handlebars from 4.2.0 to 4.5.3 in /packages/idx (#96) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.0 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.2.0...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 6 days

PR merged facebookincubator/idx

Bump handlebars from 4.2.0 to 4.5.3 in /packages/idx CLA Signed dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps handlebars from 4.2.0 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+13 -8

0 comment

1 changed file

dependabot[bot]

pr closed time in 6 days

push eventfacebookincubator/idx

dependabot[bot]

commit sha 908602aa80b128e199d3aa60e537deb7445ba66a

Bump handlebars from 4.2.0 to 4.5.3 in /packages/babel-plugin-idx (#98) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.0 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.2.0...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 6 days

PR merged facebookincubator/idx

Bump handlebars from 4.2.0 to 4.5.3 in /packages/babel-plugin-idx CLA Signed dependencies

Bumps handlebars from 4.2.0 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+13 -8

0 comment

1 changed file

dependabot[bot]

pr closed time in 6 days

push eventfacebookincubator/idx

dependabot[bot]

commit sha 51f46fe58429d60dc7ffe4fd40581ce0bbb5644d

Bump handlebars from 4.2.0 to 4.5.3 (#97) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.2.0 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.2.0...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 6 days

PR merged facebookincubator/idx

Bump handlebars from 4.2.0 to 4.5.3 CLA Signed dependencies

Bumps handlebars from 4.2.0 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+37 -27

0 comment

3 changed files

dependabot[bot]

pr closed time in 6 days

issue commentfacebook/react-native

RN v0.62.0-rc.0 - Touchable[Highlight|WithoutFeedback] are rendering into a component without name under jest

@scotthovestadt is working on a fix to how Jest renders React.forwardRef in snapshots.

devproivansurzhenko

comment created time in a month

issue commentreact-native-community/discussions-and-proposals

Supporting dark mode and perhaps other themes

@tom-un, as you already know… I am a huge supporter of the PlatformColor proposal. Thank you so much for taking the time to put this together in writing and code.

I have a couple pieces of feedback.

Cross-Platform and Cross-Version Colors

One concern I have is with cross-platform and backward compatibility.

I have not taken a close look at the code, but I assume that PlatformColor('does-not-exist') either renders as null would (e.g. transparent).

But what would the idiomatic way to specify a color that must be supported on multiple platforms where colors have different names? Or multiple versions of the same platform where system colors may have been added or renamed?

I have a proposal that borrows from how font families are defined in browsers. We should allow providing a list of named color strings, where the first valid named color is used. For example:

PlatformColor('systemFillColor')
PlatformColor('systemFillColor', 'windowBackgroundColor')
// or
PlatformColor(['systemFillColor'])
PlatformColor(['systemFillColor', 'windowBackgroundColor'])

If you think this is a good idea, I do not have a strong feeling which one of the above we end up using. (The decision may be informed by my following piece of feedback.) What do you think?

Platform Options

The example that you provided for options was:

PlatformColor('', {
  dynamic: {
    light: 'black',
    dark: 'white'
  }
})

Can you explain in what scenarios this would be necessary or preferred instead of extending the platform colors on the platform?

Ultimately for cross-platform convergence between native and web platforms, I see PlatformColor as an opportunity to converge with CSS Variables. If I wanted to define a new color that behaved differently from existing colors (e.g. a "Facebook blue" which should be the same on dark and light and high contrast modes), I would define a new CSS Variable. Why wouldn't I do the same for native platforms?

One reason I can think of for wanting options is to be able to stay in JavaScript. But I personally do not think that this is a sufficient reason and would rather see a solution that makes introducing new platform colors easier.

turnrye

comment created time in 2 months

pull request commentfacebook/react-native

moved normalizeColor and changed dependencies

It was merged. 😄

isa3bel

comment created time in 3 months

pull request commentfacebook/react-native

Fix Issue 23870: Android API - View.getGlobalVisibleRect() does not properly clip result rect for ReactClippingViewGroups

There is no error message because the increase is in Android ANRs, which stands for “Application Not Responding”.

For example, prolonged execution on the UI thread as a result of this original pull request may cause an increase in ANRs.

For whatever reason, the stack trace that @mdvacca shared is when the increase in ANRs is happening.

davidbiedenbach

comment created time in 3 months

push eventfacebook/react

Eli White

commit sha bdcdb69a24612a4a6d88c39937968c32066ed5a6

Rename findHostInstance_deprecated to findHostInstance_DEPRECATED (#17228)

view details

push time in 4 months

pull request commentfacebook/react

Rename findHostInstance_deprecated to findHostInstance_DEPRECATED

Thanks. 👍

TheSavior

comment created time in 4 months

PR merged facebook/react

Reviewers
Rename findHostInstance_deprecated to findHostInstance_DEPRECATED CLA Signed

@yungsters wants this to be _DEPRECATED to be more obnoxious than the lower case version. It's also more consistent with our internal files that we deprecate. React also has methods prefixed with UNSAFE_ so the all caps seem reasonable.

+26 -24

0 comment

6 changed files

TheSavior

pr closed time in 4 months

push eventfacebookarchive/react-native-deprecated-modules

Tim Yung

commit sha 49ae154ef159e73528fb5edd7339af5b7a5ce022

v0.0.6

view details

push time in 4 months

push eventfacebook/fbjs

Tim Yung

commit sha e85f39ae37e9650191e832c1d1ed8f02c272e9d1

v3.3.0

view details

push time in 4 months

pull request commentfacebook/fbjs

inline-requires: Ignore modules with member assignmments

The Travis CI failures (running yarn run test from packages/fbjs) repros on master. I do not believe those failures are related to these changes.

yungsters

comment created time in 4 months

push eventyungsters/fbjs

Paul O’Shannessy

commit sha 17fad9eec9847a81671d0d7b4ad177760e8eb1ff

[fbjs-css-vars] v1.0.2

view details

Miguel Jimenez Esun

commit sha d55da0fa2c820fcb67d53bfc40748002e394548d

Safe fallback if an inlinement cannot happen

view details

Miguel Jiménez Esún

commit sha 326dd9df1a5e4cc32f76d7807d04e7e0ccfe9421

Merge pull request #327 from mjesun/inlinement-fallback

view details

Rick Hanlon

commit sha 776991b9a97e40d6588f6d70abb1150dd9698902

v3.1.1 babel-preset-fbjs

view details

Miguel Jiménez Esún

commit sha d5ac001046bacb03cdb9381dce4d3d1ae296694a

Merge pull request #328 from rickhanlonii/rh-release-babel-preset-fbjs Bump babel-preset-fbjs to v3.1.1

view details

Rick Hanlon

commit sha 903d3b556eeaad7432ae82c5b813621ed8f703f0

Fix Node 6 support

view details

Miguel Jiménez Esún

commit sha 6ba0b528833ee7bf70bf8b7fabc6d26c6e530b57

Merge pull request #329 from rickhanlonii/rh-fix-node-6 Fix Node 6 support

view details

Jan Kassens

commit sha f185a9b6218b70092419281386f66c36bab8b97e

[eslint-config-fbjs] remove relay dependency (#331) The Relay eslint plugin is intended for product code, I don't think it makes sense to pull in (likely outdated) GraphQL dependencies into the framework projects using the fbjs eslint config.

view details

Miguel Jimenez Esun

commit sha 88251ebd8c6ac40000704a6c7c9b9c7ae51e6d73

Include "require.resolve" of a "require" as an inlineable call

view details

Miguel Jimenez Esun

commit sha ce713687345f7a0cf9a6550a93794e75dc7c39cd

Fix nits

view details

Miguel Jiménez Esún

commit sha 1354528c3621298f43478a02847657ab443d6754

Merge pull request #334 from mjesun/loosen-inliner Include "require.resolve" of a "require" as an inlineable call

view details

Rick Hanlon

commit sha 83fcae8adbef95db1b2ea5fd4d18f5f7aa2e9ee1

Upgrade to 3.2.0

view details

Miguel Jiménez Esún

commit sha 1b477868efcf7031a03643459584d47ae549c79a

Merge pull request #335 from rickhanlonii/master Bump babel-preset-fbjs to 3.2.0

view details

Paul O’Shannessy

commit sha bf07d1577d133c1d1466a4459f100f20018c4b16

Install latest yarn on TravisCI (#333)

view details

Rubén Norte

commit sha 5ac12c6d18b76806b13712a944e6f24269470df5

Remove rootDir from jest transformer cache key (#339) * Fix trailing comma for Node 6

view details

Rubén Norte

commit sha 7dfcc3f9f222036f0d74c222aa1a26c777ff63b4

Bump fbjs-scripts to 1.1.0 (#340)

view details

Claudio Procida

commit sha cbf17a389f727e91b2281a5c57d147d7fdeb871b

Prevents error when accessing missing package data field (#342)

view details

John Watson

commit sha ccad8f1e81daa851d18cc84153b5e1d595f1edef

Update check-dependencies to read new format of `yarn --outdated` (#332) Summary: Indexes are different when using yarn workspaces, so use column names to more reliably parse out data. Test Plan: run check-dependencies in a separate project (works) Closes #332

view details

Paul O’Shannessy

commit sha 2ceb6187688ca7cf6faf2fe3a3a4ac19bd2e1115

Fix some missing health-related items - Added a CONTRIBUTING file - Referenced license in the readme - Added missing license headers in several file

view details

Matt Hargett

commit sha af9fefad110a04821f71593b17263e8dece089cb

Align versions to other facebook repos (#343) Align babel and eslint package versions to metro and react-native, to eliminate peer dependency warnings and an npm de-duplication problem. Main repo didn't lint or prettier cleanly for me. I ran the prettier yarn target, but left the lint warnings alone. The packages/* versions need to be bumped as well, but wasn't sure what the policy was. Tell me and I'll change them. Some additional notes: 1. I tried bumping babel-plugin-tester to 5.6.x to eliminate another npm warning, but got some unhelpful test failure messages that I didn't have time to debug: ``` FAIL plugins/__tests__/inline-requires-test.js ● inline-requires › ignores requires that are re-assigned AssertionError [ERR_ASSERTION]: Expected output to not change, but it did at tester (node_modules/babel-plugin-tester/dist/index.js:197:27) at Object.<anonymous> (node_modules/babel-plugin-tester/dist/index.js:143:13) at asyncGeneratorStep (node_modules/babel-plugin-tester/dist/index.js:21:103) at _next (node_modules/babel-plugin-tester/dist/index.js:23:194) ● inline-requires › ignores destructured properties of requires in `ignoredRequires` AssertionError [ERR_ASSERTION]: Expected output to not change, but it did ``` 2. I tried bumping to Jest 24.6 like the other facebook repos, but ran into needed test changes because of require mocking. I'm deferring that to a different PR.

view details

push time in 4 months

push eventyungsters/fbjs

Paul O’Shannessy

commit sha 17fad9eec9847a81671d0d7b4ad177760e8eb1ff

[fbjs-css-vars] v1.0.2

view details

Miguel Jimenez Esun

commit sha d55da0fa2c820fcb67d53bfc40748002e394548d

Safe fallback if an inlinement cannot happen

view details

Miguel Jiménez Esún

commit sha 326dd9df1a5e4cc32f76d7807d04e7e0ccfe9421

Merge pull request #327 from mjesun/inlinement-fallback

view details

Rick Hanlon

commit sha 776991b9a97e40d6588f6d70abb1150dd9698902

v3.1.1 babel-preset-fbjs

view details

Miguel Jiménez Esún

commit sha d5ac001046bacb03cdb9381dce4d3d1ae296694a

Merge pull request #328 from rickhanlonii/rh-release-babel-preset-fbjs Bump babel-preset-fbjs to v3.1.1

view details

Rick Hanlon

commit sha 903d3b556eeaad7432ae82c5b813621ed8f703f0

Fix Node 6 support

view details

Miguel Jiménez Esún

commit sha 6ba0b528833ee7bf70bf8b7fabc6d26c6e530b57

Merge pull request #329 from rickhanlonii/rh-fix-node-6 Fix Node 6 support

view details

Jan Kassens

commit sha f185a9b6218b70092419281386f66c36bab8b97e

[eslint-config-fbjs] remove relay dependency (#331) The Relay eslint plugin is intended for product code, I don't think it makes sense to pull in (likely outdated) GraphQL dependencies into the framework projects using the fbjs eslint config.

view details

Miguel Jimenez Esun

commit sha 88251ebd8c6ac40000704a6c7c9b9c7ae51e6d73

Include "require.resolve" of a "require" as an inlineable call

view details

Miguel Jimenez Esun

commit sha ce713687345f7a0cf9a6550a93794e75dc7c39cd

Fix nits

view details

Miguel Jiménez Esún

commit sha 1354528c3621298f43478a02847657ab443d6754

Merge pull request #334 from mjesun/loosen-inliner Include "require.resolve" of a "require" as an inlineable call

view details

Rick Hanlon

commit sha 83fcae8adbef95db1b2ea5fd4d18f5f7aa2e9ee1

Upgrade to 3.2.0

view details

Miguel Jiménez Esún

commit sha 1b477868efcf7031a03643459584d47ae549c79a

Merge pull request #335 from rickhanlonii/master Bump babel-preset-fbjs to 3.2.0

view details

Paul O’Shannessy

commit sha bf07d1577d133c1d1466a4459f100f20018c4b16

Install latest yarn on TravisCI (#333)

view details

Rubén Norte

commit sha 5ac12c6d18b76806b13712a944e6f24269470df5

Remove rootDir from jest transformer cache key (#339) * Fix trailing comma for Node 6

view details

Rubén Norte

commit sha 7dfcc3f9f222036f0d74c222aa1a26c777ff63b4

Bump fbjs-scripts to 1.1.0 (#340)

view details

Claudio Procida

commit sha cbf17a389f727e91b2281a5c57d147d7fdeb871b

Prevents error when accessing missing package data field (#342)

view details

John Watson

commit sha ccad8f1e81daa851d18cc84153b5e1d595f1edef

Update check-dependencies to read new format of `yarn --outdated` (#332) Summary: Indexes are different when using yarn workspaces, so use column names to more reliably parse out data. Test Plan: run check-dependencies in a separate project (works) Closes #332

view details

Paul O’Shannessy

commit sha 2ceb6187688ca7cf6faf2fe3a3a4ac19bd2e1115

Fix some missing health-related items - Added a CONTRIBUTING file - Referenced license in the readme - Added missing license headers in several file

view details

Matt Hargett

commit sha af9fefad110a04821f71593b17263e8dece089cb

Align versions to other facebook repos (#343) Align babel and eslint package versions to metro and react-native, to eliminate peer dependency warnings and an npm de-duplication problem. Main repo didn't lint or prettier cleanly for me. I ran the prettier yarn target, but left the lint warnings alone. The packages/* versions need to be bumped as well, but wasn't sure what the policy was. Tell me and I'll change them. Some additional notes: 1. I tried bumping babel-plugin-tester to 5.6.x to eliminate another npm warning, but got some unhelpful test failure messages that I didn't have time to debug: ``` FAIL plugins/__tests__/inline-requires-test.js ● inline-requires › ignores requires that are re-assigned AssertionError [ERR_ASSERTION]: Expected output to not change, but it did at tester (node_modules/babel-plugin-tester/dist/index.js:197:27) at Object.<anonymous> (node_modules/babel-plugin-tester/dist/index.js:143:13) at asyncGeneratorStep (node_modules/babel-plugin-tester/dist/index.js:21:103) at _next (node_modules/babel-plugin-tester/dist/index.js:23:194) ● inline-requires › ignores destructured properties of requires in `ignoredRequires` AssertionError [ERR_ASSERTION]: Expected output to not change, but it did ``` 2. I tried bumping to Jest 24.6 like the other facebook repos, but ran into needed test changes because of require mocking. I'm deferring that to a different PR.

view details

push time in 4 months

PR opened facebook/fbjs

inline-requires: Ignore modules with member assignmments

Currently, the inline-requires plugin breaks semantics when a property of a module is assigned a value. For example:

var X = require('X');
var origA = X.a;
X.a = function() {
  origA();
};

Currently, this will become:

require('X').a = function() {
  require('X').a();
};

Semantics are broken and this new code will loop infinitely. Instead, the intermediate origA alias must be preserved. This is the new output:

var origA = require('X').a;
require('X').a = function() {
  origA();
};

Test Plan:

Ran yarn test and verified Jest snapshots.

+197 -74

0 comment

3 changed files

pr created time in 4 months

create barnchyungsters/fbjs

branch : inline-requires

created branch time in 4 months

push eventyungsters/react-native-deprecated-modules

Tim Yung

commit sha 5f8a9ce42af8b72c1791414f5df49ccf6274149a

Remove dependency on `isEmpty` and `merge`.

view details

push time in 4 months

push eventfacebookincubator/idx

Tan Li Hau

commit sha e7c63b46c1d190d2d9768687d1255e57a42ac45d

Update README.md (#95) fix the return statement

view details

push time in 5 months

PR merged facebookincubator/idx

Update README.md CLA Signed

fix the return statement

+2 -2

1 comment

1 changed file

tanhauhau

pr closed time in 5 months

pull request commentfacebookincubator/idx

Update README.md

Thanks!

tanhauhau

comment created time in 5 months

Pull request review commentyungsters/node-somfy-synergy

Implement net-keepalive

 class SomfySynergy {       socket =>         new Promise((resolve, reject) => {           socket._socket.setKeepAlive(true, 5000);

Thanks for the explanation! I was indeed very confused.

I’ll merge this and release a new version when I find my way back to a computer.

hertzg

comment created time in 5 months

push eventyungsters/homebridge-mylink

Tim Yung

commit sha 575d74e165ef74128f48601a06b9275fbe849b2c

v1.2.1

view details

push time in 5 months

push eventyungsters/homebridge-mylink

Chris Bolt

commit sha 410c1767a37d0b7296842cb5dd085ea96fd9ef05

Add instructions for setting System ID and finding Target IDs

view details

push time in 5 months

PR merged yungsters/homebridge-mylink

Add instructions for setting System ID and finding Target IDs

Makes configuration a bit more straightforward.

+7 -0

0 comment

1 changed file

chrisbolt

pr closed time in 5 months

PR closed yungsters/homebridge-mylink

Speed and Error Improvements

Accidentally closed #6, sorry!

  • Add delay option to be passes along to SomfySynergyPlatform. For anyone not using composite targets it is nice to be able to set the delay to 0. I would even consider setting it to 0 by default if there are no composite targets.
  • Pass along errors from synergy to HomeKit. Without calling the callback with the error, HomeKit gets stuck in a perpetual state of "opening" or "closing".
  • Maintain currentValue internally. This allows us to handle a get request for currentPosition, which is what HomeKit uses to determine if the accessory is still responsive or not.
+42 -38

2 comments

1 changed file

dgreif

pr closed time in 5 months

pull request commentyungsters/homebridge-mylink

Speed and Error Improvements

I've applied the error handling changes via https://github.com/yungsters/homebridge-mylink/commit/04ddcc475c99ca6ede17aac3ce052e4caf3a04b7.

dgreif

comment created time in 5 months

push eventyungsters/homebridge-mylink

Tim Yung

commit sha 04ddcc475c99ca6ede17aac3ce052e4caf3a04b7

Propagate errors from SomfySynergy to Homebridge Thanks to @dgreif for suggesting this in yungsters/homebridge-mylink#8.

view details

push time in 5 months

push eventyungsters/homebridge-mylink

Tim Yung

commit sha ee664c8b14866d622323e9cff3458801cd43c31a

Propagate errors from SomfySynergy to Homebridge Thanks to @dgreif for suggesting this in yungsters/homebridge-mylink#8.

view details

push time in 5 months

Pull request review commentyungsters/homebridge-mylink

Speed and Error Improvements

 module.exports = homebridge => {       );        targetPosition.on('set', (targetValue, callback) => {-        const logError = error => {+        this.log(+          'Setting position of %s from %s to %s.',+          `target ${targetID} (${name})`,+          `${this.currentValue}%`,+          `${targetValue}%`,+        );+        positionState.setValue(+          targetValue < this.currentValue+            ? Characteristic.PositionState.DECREASING+            : targetValue > this.currentValue+            ? Characteristic.PositionState.INCREASING+            : Characteristic.PositionState.STOPPED,+        );++        const target = this.synergy.target(targetID);+        const promise =+          targetValue === 0+            ? target[orientation.closed]()+            : targetValue === 100+            ? target[orientation.opened]()+            : target[orientation.middle]();++        promise.then(() => {+          callback();

Thanks for this proposed fix.

dgreif

comment created time in 5 months

Pull request review commentyungsters/homebridge-mylink

Speed and Error Improvements

 module.exports = homebridge => {       );        targetPosition.on('set', (targetValue, callback) => {-        const logError = error => {+        this.log(+          'Setting position of %s from %s to %s.',+          `target ${targetID} (${name})`,+          `${this.currentValue}%`,+          `${targetValue}%`,+        );+        positionState.setValue(+          targetValue < this.currentValue+            ? Characteristic.PositionState.DECREASING+            : targetValue > this.currentValue+            ? Characteristic.PositionState.INCREASING+            : Characteristic.PositionState.STOPPED,+        );++        const target = this.synergy.target(targetID);+        const promise =+          targetValue === 0+            ? target[orientation.closed]()+            : targetValue === 100+            ? target[orientation.opened]()+            : target[orientation.middle]();++        promise.then(() => {+          callback();+          this.currentValue = targetValue;+          currentPosition.setValue(targetValue);+        }, error => {           this.log(             'Encountered an error setting target position of %s: %s',             `target ${targetID} (${name})`,             error.message,           );-        };--        currentPosition.getValue((error, currentValue) => {-          if (error) {-            logError(error);-            callback(error);-            return;-          }--          this.log(-            'Setting position of %s from %s to %s.',-            `target ${targetID} (${name})`,-            `${currentValue}%`,-            `${targetValue}%`,-          );-          positionState.setValue(-            targetValue < currentValue-              ? Characteristic.PositionState.DECREASING-              : targetValue > currentValue-                ? Characteristic.PositionState.INCREASING-                : Characteristic.PositionState.STOPPED,-          );-          callback();--          const target = this.synergy.target(targetID);-          const promise =-            targetValue === 0-              ? target[orientation.closed]()-              : targetValue === 100-                ? target[orientation.opened]()-                : target[orientation.middle]();--          promise.then(() => {-            currentPosition.setValue(targetValue);-            positionState.setValue(Characteristic.PositionState.STOPPED);-          }, logError);+          positionState.setValue(Characteristic.PositionState.STOPPED);+          callback(error);         });       }); +      currentPosition.on('get', (callback) => {

This is unnecessary because HAP-NodeJS already maintains this and will return the value on this characteristic's behalf if there is no get listener.

dgreif

comment created time in 5 months

Pull request review commentyungsters/homebridge-mylink

Speed and Error Improvements

 module.exports = homebridge => {     systemID,     targets,     compositeTargets,+    delay,

Nothing is using this.

dgreif

comment created time in 5 months

issue closedyungsters/homebridge-mylink

Issues on NPM install

I have a relatively clean install of Raspian and I am getting an error on install. pi@raspberrypi:~ $ sudo npm -g install homebridge-mylink (node:9540) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.npm ERR! tar.unpack untar error /root/.npm/generic-pool/3.7.1/package.tgz npm ERR! Error: Invalid Package: expected sinonjs/formatio but found @sinonjs/formatio npm ERR! at /usr/share/npm/lib/cache/add-local-tarball.js:161:14 npm ERR! at _combinedTickCallback (internal/process/next_tick.js:131:7) npm ERR! at process._tickCallback (internal/process/next_tick.js:180:9) npm ERR! If you need help, you may report this entire log, npm ERR! including the npm and node versions, at: npm ERR! http://github.com/npm/npm/issues

npm ERR! System Linux 4.14.98-v7+ npm ERR! command "/usr/bin/node" "/usr/bin/npm" "-g" "install" "homebridge-mylink" npm ERR! cwd /home/pi npm ERR! node -v v8.11.1 npm ERR! npm -v 1.4.21 npm ERR! npm ERR! Additional logging details can be found in: npm ERR! /home/pi/npm-debug.log npm ERR! not ok code 0

closed time in 5 months

markcsegal

issue commentyungsters/homebridge-mylink

Issues on NPM install

I just noticed this in the original logs:

npm ERR! node -v v8.11.1 npm ERR! npm -v 1.4.21

Your version of npm is extremely outdated. For reference, the latest version is npm@6.11.3.

Please consult the npm documentation for instructions on updating: https://docs.npmjs.com/about-npm-versions

markcsegal

comment created time in 5 months

issue closedyungsters/homebridge-mylink

Encountered an error setting target position - socket fails to connect to server

Hi there!

Installed and configured the plugin but receive the following error in the logs when attempting to open the blind:

[2018-3-6 20:24:02] [Somfy myLink] Setting position of target XXXXXXXX.1 (Awning) from 0% to 100%.
[2018-3-6 20:24:05] [Somfy myLink] Encountered an error setting target position of target XXXXXXXX.1 (Awning): socket fails to connect to server after 3000 milliseconds

Note XXXXXXXX is my Hardware ID which I found in the info section of the myLink app (iOS), I was not able to follow the instructions documented here (extract below):

Setup

You will need to use the Somfy myLink mobile app in order to configure your System ID, to obtain your Somfy myLink's IP address, and to obtain the Target IDs for each remotely controlled device.

Go to "Integration" and set a System ID by tapping "Change System ID" (which can be any string). Tap "Get Integration report" to view the System ID, IP address, and Target IDs.

closed time in 5 months

fab301s

issue commentyungsters/homebridge-mylink

Encountered an error setting target position - socket fails to connect to server

I am not familiar with the differences between what Somfy products are available in AU vs. US, but I do know that Somfy had previously released two versions of the myLink product.

See this blog post for more details: https://www.somfysystems.com/en-us/Blog/Post/2019-05-02-which-version-mylink-do-i-have-and-what-s-the-difference-

Maybe this is the problem? If not... consider consulting with your nearest Somfy dealer. (Unfortunately, I am not an authorized agent or expert for Somfy products.)

fab301s

comment created time in 5 months

push eventyungsters/homebridge-mylink

Tim Yung

commit sha 8d5b7a0a540dd04a321fa60aa621ba1e26d85ae4

Upgrade all dependencies

view details

Tim Yung

commit sha 56886823622e4f7e8a455181da2d9124ba7b8f40

Remove unused variable

view details

Tim Yung

commit sha 077af1695a559df957cf593a9e44bf52e1cff039

Upgrade husky configuration

view details

Tim Yung

commit sha 5b0ae5eb8209554f49a4bbac4b7d9a291f75cc7d

v1.2.0

view details

push time in 5 months

push eventyungsters/node-somfy-synergy

Tim Yung

commit sha 2535876797fcc7aa55e6da35a1a2e704c0754a14

v1.4.0

view details

push time in 5 months

issue closedyungsters/node-somfy-synergy

Auth problems

When I use the system id in the auth parameter, it says it's invalid.

Any ideas? I am on firmware version 5.17

closed time in 5 months

marcantoineveilleux

Pull request review commentyungsters/node-somfy-synergy

Implement net-keepalive

 class SomfySynergy {       socket =>         new Promise((resolve, reject) => {           socket._socket.setKeepAlive(true, 5000);

Importing net-keepalive enables the use of socket.setKeepAlive. In this case, the interval is being set to 5000. Why do you think we also need to set it to 1000 via setKeepAliveInterval?

hertzg

comment created time in 5 months

push eventyungsters/node-somfy-synergy

dgreif

commit sha 580b67a94c8469857e47f447ecad1d04b1f09b5c

Clear pending requests after they are processed

view details

push time in 5 months

PR merged yungsters/node-somfy-synergy

Clear pending requests after they are processed

The current synergy platform retains each record in the _pendingRequets map. This leads to issues when you have multiple targets, and are only trying to control one of them. For example if I close Target A and Target B with HomeKit, then open Target A with a remote (not through code). When I open Target B with HomeKit, SomfySynergy still thinks that Target A should be closed and will resend the command to MyLink to close it.

+1 -0

1 comment

1 changed file

dgreif

pr closed time in 5 months

issue commentyungsters/node-somfy-synergy

Auth problems

I am sorry, I do not have any ideas. Were you able to figure this out?

marcantoineveilleux

comment created time in 5 months

push eventyungsters/node-somfy-synergy

Tim Yung

commit sha a6fe29610ac84e6ef1a0a64347fa32815aaabaca

Upgrade all dependencies

view details

push time in 5 months

issue closedyungsters/homebridge-urtsi

Fails to install, serial port error

When I try to install I get "Failed at serialport@2.1.2 install script" error.

closed time in 5 months

DEA156

issue commentyungsters/homebridge-urtsi

Fails to install, serial port error

https://github.com/yungsters/homebridge-urtsi/commit/fa1616234ba998b50c83206faecf36a8a6c4a2f0 should fix this.

DEA156

comment created time in 5 months

push eventyungsters/homebridge-urtsi

Tim Yung

commit sha fa1616234ba998b50c83206faecf36a8a6c4a2f0

Upgrade node-urtsi dependency.

view details

push time in 5 months

push eventyungsters/node-urtsi

Tim Yung

commit sha 7f3dde526fdcf40b08a08b985ec3c636673b46c6

Upgrade serialport dependency.

view details

push time in 5 months

push eventyungsters/node-urtsi

Tim Yung

commit sha 402a48e873012541edd789a81b6560246cff384b

Upgrade serialport dependency

view details

push time in 5 months

issue commentyungsters/homebridge-urtsi

Fails to install, serial port error

Look a like the main request here is to upgrade the serialport dependency for node-urtsi, is that right?

I no longer have this device, but I can help update this dependency (and update call sites) if that will help make your’s and others’ lives easier.

DEA156

comment created time in 5 months

push eventfacebookincubator/idx

Tim Yung

commit sha 0c9215510d1cdc868a812d0cbe843bf8a33c134a

Scrub all yarn.lock files

view details

push time in 6 months

push eventfacebookincubator/idx

Tim Yung

commit sha f7bfcd562d67dda943c08923a4feed9f2b05f99c

idx: Delete babel-preset-env dependency

view details

push time in 6 months

push eventfacebookincubator/idx

Tim Yung

commit sha 25882580a2f8ecdda74b6f4cefe376ce22e5deea

idx: flow@^0.107.0

view details

push time in 6 months

push eventfacebookincubator/idx

Tim Yung

commit sha f67f59703cd18445a288b5644ed10ac6c8612e2e

idx: @babel/cli@^7.6.0 and jest@^24.9.0

view details

Tim Yung

commit sha 584c6f544a05e4593ac0262b560d429e478ef31b

babel-plugin-idx: @babel/cli@^7.6.0 and jest@^24.9.0

view details

push time in 6 months

push eventfacebookincubator/idx

Tim Yung

commit sha 23e8f673c1f8543874b8c53dfbdf4ca1eb5a3d0b

eslint@^5.1.0 and eslint-config-fbjs-opensource@^2.0.1

view details

push time in 6 months

push eventfacebookincubator/idx

Tim Yung

commit sha 9311bc8c2f0c026641d48fdfa7894775c8aba7b0

Cleanup copyright headers

view details

push time in 6 months

push eventfacebookincubator/idx

Timothy Yung

commit sha 10519c1f86cc165e9e4d0127d5c4ee4a3f6da0ff

Bump CircleCI to Node v8 Bumping to resolve the following job error on CircleCI: ``` error is-text-path@2.0.0: The engine "node" is incompatible with this module. Expected version ">=8". Got "6.17.1" error Found incompatible module ```

view details

push time in 6 months

more