profile
viewpoint

wjmao88/angular-http-throttler 0

AngularJS service for throttling $http requests

wjmao88/Batch 0

A lovingly designed and crafted suite of 300 (and counting) icons for web and user interface design.

wjmao88/bootstrap 0

Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!

wjmao88/bootstrap-1 0

The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.

wjmao88/boundjs 0

Hyper-compatible view bindings

wjmao88/circular 0

data binding/no back end experiment

push eventwjmao88/yarn-berry-3999

Wesley Mao

commit sha 55119e9dbee27b7af95732789fe16b2b40b6703a

distinguish tsconfig and portal

view details

push time in 3 days

issue commentyarnpkg/berry

[Bug?]: typescript auto import does not work with VSCode typescript SDK when trying to import from portal package

Thank you, the auto import doesn't work in your reproduction with both node_modules and PnP

Yeah I tried and it doesn't work with either linkers. Also tried on linux with slightly different results and updated in description.

wjmao88

comment created time in 3 days

issue commentyarnpkg/berry

[Bug?]: [Windows?] typescript auto import does not work with VSCode typescript SDK when trying to import from portal package

Please provide a reproduction that we don't have to manually set up. A cloneable git repo is preferred.

Regarding images of text please read https://meta.stackoverflow.com/questions/285551/why-not-upload-images-of-code-errors-when-asking-a-question/285557#285557

Added link to repo

wjmao88

comment created time in 3 days

push eventwjmao88/yarn-berry-3999

Wesley Mao

commit sha 7bf8c74d9a46814b9de7f42edaff1f7fa04dd9be

3999 repro

view details

push time in 3 days

create barnchwjmao88/yarn-berry-3999

branch : main

created branch time in 3 days

created repositorywjmao88/yarn-berry-3999

created time in 3 days

issue openedyarnpkg/berry

[Bug?]: [Windows?] typescript auto import does not work with VSCode typescript SDK when trying to import from portal package

Self-service

  • [ ] I'd be willing to implement a fix

Describe the bug

(On Windows at least) When setting VSCode to use yarn SDK's typescript server, it cannot find auto import (either via auto complete or the quick fix suggestion on hover) for anything inside a portal-ed dependency

To reproduce

  • setup a repo with yarn 3.1.1, pnp, VSCode sdk, typescript ~4.5.0 (resolves to 4.5.5) image image
  • create 2 workspaces, let's call them app and lib, and in app's package.json, specify dependency to lib as a portal. image image image
  • in app, have a tsconfig that specifies pathing to lib (as I understand this should not be required when I declare it as a dependency in package.json) image
  • in lib, create a file that exports something image
  • in app, create a file and tries to use that name image

Now, if I go select typescript sdk and select to use VSCode's version image then I can get this to show up (which, I understand is the tsconfig doing its thing, and this would not work without the path/include configs in there) image image

but, if I go and select the yarn sdk, image it no longer gives the import suggestion image if I manually write out the import myself, it can figure out where that is supposed to be, even if I remove the path and includes options from the tsconfig (and basically have a blank tsconfig). image

Environment

System:
    OS: Windows 10 10.0.19043
    CPU: (12) x64 Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
    Memory: 2.03 GB / 15.61 GB
  Binaries:
    Node: 12.22.9 - ~\AppData\Local\Temp\xfs-d4ae5021\node.CMD
    Yarn: 3.1.1 - ~\AppData\Local\Temp\xfs-d4ae5021\yarn.CMD
    npm: 6.14.15 - C:\Program Files\nodejs\npm.CMD

Additional context

No response

created time in 3 days

more