profile
viewpoint

vrana/adminer 4410

Database management in a single PHP file

vrana/dibi 3

dibi - excelent database abstraction layer

vrana/amazon-s3-php-class 2

A standalone Amazon S3 (REST) client for PHP 5.2.x using CURL that does not require PEAR.

vrana/composer-cleaner 2

Victor The Cleaner: removes unnecessary files from vendor directory

vrana/closure-library 1

Google's common JavaScript library

vrana/angular-bootstrap-lightbox 0

An AngularJS lightbox built using UI Bootstrap Modal.

vrana/angularjs.org 0

code for angularjs.org site

vrana/API 0

🏄Windy API, or Windy Leaflet Plugin, let you put animated weather map into your website and enjoy rich ecosystem of Leaflet library.

Pull request review commentenricocarraro/wp-fetch-metadata

Policies class unit tests and Enforce_Policies class integration tests.

+<?php+/**+ * Class Google\WP_Fetch_Metadata\Tests\PHPUnit\Integration\Enforce_Policies_Tests+ *+ * @package   Google\WP_Fetch_Metadata+ * @copyright 2020 Google LLC+ * @license   https://www.apache.org/licenses/LICENSE-2.0 Apache License 2.0+ * @link      https://wordpress.org/plugins/fetch-metadata+ */++namespace Google\WP_Fetch_Metadata\Tests\PHPUnit\Integration;++use Google\WP_Fetch_Metadata\Tests\PHPUnit\Framework\Integration_Test_Case;+use Google\WP_Fetch_Metadata\Policy\Isolation_Policy;+use Google\WP_Fetch_Metadata\Policy\Default_Navigation_Isolation_Policy;+use Google\WP_Fetch_Metadata\Policy\Default_Resource_Isolation_Policy;+use Google\WP_Fetch_Metadata\Policy_Registry;+use Google\WP_Fetch_Metadata\Enforce_Policies;+use Google\WP_Fetch_Metadata\Policies;+use Google\WP_Fetch_Metadata\Policies_Setting;+use Brain\Monkey\Functions;++/**+ * Class containing a Enforce_Policies Tests.+ */+class Enforce_Policies_Tests extends Integration_Test_Case {++	const DEST = 'HTTP_SEC_FETCH_DEST';+	const SITE = 'HTTP_SEC_FETCH_SITE';+	const MODE = 'HTTP_SEC_FETCH_MODE';++	/**+	 * Tests enforce() when all default policies are enabled and respected.+	 *+	 * @since 0.0.1+	 */+	public function testEnforceDefaultPoliciesEnabledRespected() {+		add_filter( 'wp_die_handler', 'wp_die_handler_filter' );

Please move these to setUp and tearDown.

enricocarraro

comment created time in a day

PullRequestReviewEvent
CommitCommentEvent
CommitCommentEvent

push eventvrana/windy-plugin-pg-mapa

Jakub Vrana

commit sha 29a942a71ea50503081cc14a11c9e22d479b21ec

Fix map links

view details

push time in 2 days

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

push eventvrana/windy-plugin-pg-mapa

Jakub Vrana

commit sha 08757ce6ec5eb1bf223eae423d05694b539e3601

Link parking map

view details

push time in 5 days

push eventvrana/windy-plugin-pg-mapa

Jakub Vrana

commit sha 44c3309fb65aa871621b432cd3879f317b985429

Add map links

view details

push time in 6 days

Pull request review commentenricocarraro/wp-fetch-metadata

Set 'Vary' header and HTTP 401 on policy violation.

 public function enforce() { 		$option   = $this->policies_setting->get(); 		$headers  = getallheaders(); -		if ( ! static::$enforced+		if ( 0 === $this->enforced_policies++

I rather put the increment as a separate statement (where the previous $enforced = true was).

enricocarraro

comment created time in 11 days

PullRequestReviewEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

Pull request review commentmediaelement/mediaelement

Strict CSP-compatibility: replace `javascript:` URIs with event handlers

 Object.assign(MediaElementPlayer.prototype, { 		mute.innerHTML = mode === 'horizontal' ? 			`<button type="button" aria-controls="${t.id}" title="${muteText}" aria-label="${muteText}" tabindex="0"></button>` : 			`<button type="button" aria-controls="${t.id}" title="${muteText}" aria-label="${muteText}" tabindex="0"></button>` +-			`<a href="javascript:void(0);" class="${t.options.classPrefix}volume-slider" ` ++			`<a href="about:blank" class="${t.options.classPrefix}volume-slider" ` +

# is usually used here which is better than about:blank if something fails.

enricocarraro

comment created time in 16 days

PullRequestReviewEvent

Pull request review commentWordPress/wordpress-develop

Inline event handlers refactoring

 function tb_show(caption, url, imageGroup) {//function called when the user clic 					urlNoQuery = url.split('TB_'); 					jQuery("#TB_iframeContent").remove(); 					if(params['modal'] != "true"){//iframe no modal-						jQuery("#TB_window").append("<div id='TB_title'><div id='TB_ajaxWindowTitle'>"+caption+"</div><div id='TB_closeAjaxWindow'><button type='button' id='TB_closeWindowButton'><span class='screen-reader-text'>"+thickboxL10n.close+"</span><span class='tb-close-icon'></span></button></div></div><iframe frameborder='0' hspace='0' allowtransparency='true' src='"+urlNoQuery[0]+"' id='TB_iframeContent' name='TB_iframeContent"+Math.round(Math.random()*1000)+"' onload='tb_showIframe()' style='width:"+(ajaxContentW + 29)+"px;height:"+(ajaxContentH + 17)+"px;' >"+thickboxL10n.noiframes+"</iframe>");+						jQuery("#TB_window").append("<div id='TB_title'><div id='TB_ajaxWindowTitle'>"+caption+"</div><div id='TB_closeAjaxWindow'><button type='button' id='TB_closeWindowButton'><span class='screen-reader-text'>"+thickboxL10n.close+"</span><span class='tb-close-icon'></span></button></div></div><iframe frameborder='0' hspace='0' allowtransparency='true' src='"+urlNoQuery[0]+"' id='TB_iframeContent' name='TB_iframeContent"+Math.round(Math.random()*1000)+"' style='width:"+(ajaxContentW + 29)+"px;height:"+(ajaxContentH + 17)+"px;' >"+thickboxL10n.noiframes+"</iframe>"); 					}else{//iframe modal 					jQuery("#TB_overlay").unbind();-						jQuery("#TB_window").append("<iframe frameborder='0' hspace='0' allowtransparency='true' src='"+urlNoQuery[0]+"' id='TB_iframeContent' name='TB_iframeContent"+Math.round(Math.random()*1000)+"' onload='tb_showIframe()' style='width:"+(ajaxContentW + 29)+"px;height:"+(ajaxContentH + 17)+"px;'>"+thickboxL10n.noiframes+"</iframe>");+						jQuery("#TB_window").append("<iframe frameborder='0' hspace='0' allowtransparency='true' src='"+urlNoQuery[0]+"' id='TB_iframeContent' name='TB_iframeContent"+Math.round(Math.random()*1000)+"' style='width:"+(ajaxContentW + 29)+"px;height:"+(ajaxContentH + 17)+"px;'>"+thickboxL10n.noiframes+"</iframe>");+						 					}+					jQuery("#TB_iframeContent").on("load", function() {

You can use .load() directly.

enricocarraro

comment created time in 16 days

PullRequestReviewEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

push eventvrana/windy-plugin-aladin

Jakub Vrana

commit sha 913d83faf08db74b260cc02bc6579d6c1f2b26d2

Always append aladinDiv to picker

view details

push time in 18 days

push eventvrana/windy-plugin-pg-mapa

Jakub Vrana

commit sha fdd9ffd8ff8507cecb1aad90eed83a5f086899e2

Update compiler

view details

Jakub Vrana

commit sha 5f78ff3cb8ac118aba8747570a29cb2f0215d346

Use new module path

view details

push time in 23 days

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

PR opened CesiumGS/cesium

Fix a typo
+1 -2

0 comment

1 changed file

pr created time in 2 months

push eventvrana/cesium

Jakub Vrána

commit sha 4a1d0ea3d71c51bfe43dad295102481ad477f671

Fix a typo

view details

push time in 2 months

CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent
CommitCommentEvent

push eventvrana/windy-plugin-pg-mapa

Jakub Vrana

commit sha 438824fd3aaf6e053a3811a62ed335c27848f821

Display superelevation in title

view details

push time in 2 months

push eventvrana/windy-plugin-flymet

Jakub Vrana

commit sha 26db752effdca24a51bf4cfbec190c030f6caf58

Add Stoupani 1500 m

view details

Jakub Vrana

commit sha 072fbf293860c7dcbb4fd2cfdd435032210ba904

Add help

view details

push time in 3 months

push eventvrana/windy-plugin-pg-mapa

Jakub Vrana

commit sha 6bd8934ef495f6372454becb74cf71c405a8d4d7

Display lower sites smaller

view details

push time in 3 months

push eventvrana/windy-plugin-flymet

Jakub Vrana

commit sha 0a6f2b9e29a63454a062a6af1c562be07cb5b56f

Display day after tomorrow

view details

push time in 3 months

fork vrana/list

The Public Suffix List

https://publicsuffix.org/

fork in 3 months

more