profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/vadimshvetsov/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Vadim Shvetsov vadimshvetsov ProLing LLC Moscow, Russia https://proling.ru/ TypeScript/Elixir Full-Stack Developer

vadimshvetsov/media-organizer 4

CLI program for creating dedicated folder structure by media metadata

vadimshvetsov/gatsby-remark-bracketed-spans 1

Adds attributes to span tags to MarkdownRemark using remark-bracketed-spans plugin

vadimshvetsov/absinthe 0

The GraphQL toolkit for Elixir

vadimshvetsov/apollo-absinthe-upload-link 0

A network interface for Apollo that enables file-uploading to Absinthe back ends.

vadimshvetsov/apollo-client 0

:rocket: A fully-featured, production ready caching GraphQL client for every UI framework and GraphQL server

vadimshvetsov/arc 0

:paperclip: Flexible file upload and attachment library for Elixir

vadimshvetsov/asciinema 0

Terminal session recorder 📹

vadimshvetsov/exiftool 0

A Node.js wrapper around exiftool, providing metadata extraction from numerous audio, video, document, and binary filetypes

vadimshvetsov/gatsby 0

⚛️📄🚀 Blazing fast site generator for React

startedTinkoffCreditSystems/tramvai

started time in 16 days

startedtlbootcamp/tlroadmap

started time in 18 days

Pull request review commentprojectstorm/react-diagrams

Fix set position bug

 export class PortModel<G extends PortModelGenerics = PortModelGenerics> extends 		}; 	} -	setPosition(point: Point);-	setPosition(x: number, y: number);-	setPosition(x, y?) {-		let old = this.position;-		super.setPosition(x, y);-		_.forEach(this.getLinks(), (link) => {-			let point = link.getPointForPort(this);-			point.setPosition(point.getX() + x - old.x, point.getY() + y - old.y);

I've returned this and I can't imagine why this does work and doesn't work without

vadimshvetsov

comment created time in 24 days

PullRequestReviewEvent

push eventvadimshvetsov/react-diagrams

Vadim Shvetsov

commit sha d07f3a30478385b8a2d81774fb44edefc822d450

Return setPosition for PortModel

view details

push time in 24 days

push eventvadimshvetsov/react-diagrams

Vadim Shvetsov

commit sha d21e8e8860a93e840f8faf2b5bf20814dd980e99

Fix typo in const vs import

view details

push time in 25 days

Pull request review commentprojectstorm/react-diagrams

Fix set position bug

 export class PortModel<G extends PortModelGenerics = PortModelGenerics> extends 		}; 	} -	setPosition(point: Point);-	setPosition(x: number, y: number);-	setPosition(x, y?) {-		let old = this.position;-		super.setPosition(x, y);-		_.forEach(this.getLinks(), (link) => {-			let point = link.getPointForPort(this);-			point.setPosition(point.getX() + x - old.x, point.getY() + y - old.y);

It looks like setting position for points in PortModel.setPosition do nothing because x and old.x always match.

vadimshvetsov

comment created time in 25 days

PullRequestReviewEvent

push eventvadimshvetsov/react-diagrams

Vadim Shvetsov

commit sha 25bf056b0a9aac6ccdb6456a2d353e605a8d533b

Remove setPosition from PortModel

view details

push time in 25 days

push eventvadimshvetsov/react-diagrams

Vadim Shvetsov

commit sha 5ebe6f84cd74aaf94a9c33b8312c8734d339c68e

Use this.position instead of this.getPosition() method

view details

push time in 25 days

push eventvadimshvetsov/react-diagrams

Vadim Shvetsov

commit sha adc173f68985f2f74dce70549bac46c81efba4b0

Change let to const in setPosition methods

view details

push time in 25 days

PR opened projectstorm/react-diagrams

fix: Fix set position bug

Checklist

  • [x] The code has been run through pretty yarn run pretty
  • [x] The tests pass on CircleCI
  • [x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • [x] The PR Template has been filled out (see below)
  • [x] Had a beer/coffee because you are awesome

What?

At NodeModel and PortModel method setPosition currently doesn't work properly if we pass only Point as a first argument.

Why?

Because NodeModel.setPosition for instance sets position to it's ports with this code:

https://github.com/projectstorm/react-diagrams/blob/dd68d1fe671925ba81d8e9e80ae6b3467e2d5c30/packages/react-diagrams-core/src/entities/node/NodeModel.ts#L42-L52

x can be PointModel and y we could never have, that's why ports never get correct position

How?

We should use this.getPosition().x and this.getPosition().y for getting correct position for ports and points.

Feel good image:

image

+25 -17

0 comment

3 changed files

pr created time in 25 days

create barnchvadimshvetsov/react-diagrams

branch : fix-set-position

created branch time in 25 days

issue commentprojectstorm/react-diagrams

DefaultNodeModel JSX

Hi. Could you provide more context? You could implement your own node model with extending NodeModel and create your own NodeWidget with images or any jsx component.

amrit981

comment created time in a month

pull request commentprojectstorm/react-diagrams

Fix circular dependencies in geometry

@dylanvorster is this PR has a chance to get in?

vadimshvetsov

comment created time in 2 months

issue commentsteebchen/kubectl

syntax error: unexpected redirection

@pratik-parikh01 @steebchen thanks, with specifying kubectl version as v.1.19.0 the problem has gone.

rodriguesl3

comment created time in 2 months

issue openedbylexus/docker-apache-php53

Can't be found on docker hub

Hi.

There is not repo on docker hub, is it possible to publish it back? https://hub.docker.com/r/bylexus/apache-php53

created time in 2 months

delete branch vadimshvetsov/react-diagrams

delete branch : fix-port-parent

delete time in 2 months

delete branch vadimshvetsov/react-diagrams

delete branch : fix-touch-mouse-event

delete time in 2 months

PR opened projectstorm/react-diagrams

Fix touch with mouse event bug

Checklist

  • [x] The code has been run through pretty yarn run pretty
  • [x] The tests pass on CircleCI
  • [x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • [x] The PR Template has been filled out (see below)
  • [x] Had a beer/coffee because you are awesome

What?

Getting Uncaught TypeError: Cannot read properties of undefined (reading 'x') when using SelectionBox

Closes https://github.com/projectstorm/react-diagrams/issues/867

Why?

Because SelectionBox code uses interface as class with instanceof. It's always false.

How?

Remove instanceof usage and rely on object props.

Feel good image:

image

+4 -4

0 comment

1 changed file

pr created time in 2 months

create barnchvadimshvetsov/react-diagrams

branch : fix-touch-mouse-event

created branch time in 2 months

issue commentprojectstorm/react-diagrams

Add Maintainers to Project

If @dylanvorster consider to add maintainers I'm happy to be one of them in my spare time.

rkesters

comment created time in 2 months

issue commentprojectstorm/react-diagrams

Is alive?

According to releases I'll say yes.

rougsig

comment created time in 2 months

issue commentprojectstorm/react-diagrams

Selection box cause an error

It comes from #828 . I'm ready to PR something like this:

getBoxDimensions(event: AbstractDisplacementStateEvent): ClientRect {
		let rel: Point;
	        if (event.event instanceof TouchEvent) {
		  const touch = event.event.touches[0];
		  rel = this.engine.getRelativePoint(touch.clientX, touch.clientY);
		} else {
                  rel = this.engine.getRelativePoint(event.event.clientX, event.event.clientY)
                }
                ...
	}

So I'm suggesting to use second path by default instead of assuming that it is MouseEvent. Do you have better idea for fast fix @renato-bohler ?

rougsig

comment created time in 2 months

PR opened projectstorm/react-diagrams

Fix port parent prop on clone

Checklist

  • [x] The code has been run through pretty yarn run pretty
  • [x] The tests pass on CircleCI
  • [x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • [x] The PR Template has been filled out (see below)
  • [x] Had a beer/coffee because you are awesome

What?

Port lost parent on clone

Why?

Because parent wrote to unused parentNode parent instead of parent

How?

Rename prop from parentNode to parent, then on this.getParent() we can get correct parent

Feel good image:

image

+2 -2

0 comment

1 changed file

pr created time in 2 months

create barnchvadimshvetsov/react-diagrams

branch : fix-port-parent

created branch time in 2 months

delete branch vadimshvetsov/react-diagrams

delete branch : fix-label

delete time in 2 months

issue commentsteebchen/kubectl

syntax error: unexpected redirection

I have the same thing and I use 1.19 kubectl version too. Maybe something with using this exact version or with using any custom version?

rodriguesl3

comment created time in 2 months

PR opened projectstorm/react-diagrams

Fix LabelModel deserialization and react incompatibility with react-dom which refutes Storybook to run

Checklist

  • [x] The code has been run through pretty yarn run pretty
  • [x] The tests pass on CircleCI
  • [x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • [x] The PR Template has been filled out (see below)
  • [x] Had a beer/coffee because you are awesome

What?

  1. LabelModel can't get deserialized because of #497 issue.
  2. Storybook can't be run from last master commit after building all packages.

Screenshot 2021-07-06 at 16 47 25

Why?

  1. The problem is that this.engine.getCanvas() return undefined on first render.
  2. Because react 16.8 can't work with react-dom 17.

How?

  1. With adding quotation mark to canvas which doesn't fall Closes #497
  2. With update react and react dependant deps to successfully run storybook

Feel good image:

image

+1219 -201

0 comment

4 changed files

pr created time in 2 months

create barnchvadimshvetsov/react-diagrams

branch : fix-label

created branch time in 2 months