profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tkremenek/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

apple/swift-format 1326

Formatting technology for Swift source code

tkremenek/swift 5

The Swift Programming Language

tkremenek/swift-corelibs-foundation 1

The Foundation Project, providing core utilities, internationalization, and OS independence

tkremenek/swift-package-manager 1

The Package Manager for the Swift Programming Language

tkremenek/rouge 0

A pure Ruby code highlighter that is compatible with Pygments

tkremenek/swift-corelibs-xctest 0

The XCTest Project, A Swift core library for providing unit test support

tkremenek/swift-lldb 0

This is the version of LLDB that supports the Swift programming language & REPL.

tkremenek/swift-source-compat-suite 0

The infrastructure and project index comprising the Swift source compatibility suite.

PullRequestReviewEvent

fork tkremenek/Yams

A Sweet and Swifty YAML parser.

https://jpsim.com/Yams

fork in a month

push eventapple/swift-evolution

Ted Kremenek

commit sha 3295e98aa281087c8fa75a66bcad64af51966074

Mark SE-0290 as implemented

view details

push time in 2 months

MemberEvent
MemberEvent

push eventapple/swift-driver

Butta

commit sha 6905cd939c022dd1c0ae2d41beeaf3bc70a6c7b1

Enable checking for -no-toolchain-stdlib-rpath and use it on this repo's binaries before installing

view details

Ted Kremenek

commit sha 1422de0841a486f906af6921ec07356ed3699008

Merge pull request #738 from buttaface/elf-rpath [5.5] Enable checking for -no-toolchain-stdlib-rpath and use it on this repo's binaries before installing

view details

push time in 2 months

PR merged apple/swift-driver

[5.5] Enable checking for -no-toolchain-stdlib-rpath and use it on this repo's binaries before installing

Cherry-pick of #732 and #767

  • Explanation: This matches the upstream driver and removes the build toolchain's rpath for this shipping swift-driver executable itself on ELF platforms.
  • Scope: Adds behavior to match upstream and remove an extraneous rpath from the swift-driver and other executables from this repo.
  • Risk: None
  • Testing: Passes all tests, as indicated in the upstream pull, and should now pass more tests from the compiler test suite.
  • Reviewer: @artemcm
+19 -1

11 comments

3 changed files

buttaface

pr closed time in 2 months

PullRequestReviewEvent

push eventapple/swift

Ted Kremenek

commit sha 13f04295c907782115f03d2b9271b04c0b1eb387

Update Swift version to 5.6 (#38574) * Update Swift version to 5.6 * Add Swift 5.6 to changelog

view details

push time in 2 months

PR merged apple/swift

Update Swift version to 5.6

Update Swift version to 5.6.

+10 -10

3 comments

6 changed files

tkremenek

pr closed time in 2 months

push eventtkremenek/swift

Ted Kremenek

commit sha 12040ff8c30dd7c03aad27aa88b23d06d959a644

Add Swift 5.6 to changelog

view details

push time in 2 months

MemberEvent

pull request commentapple/swift

Update Swift version to 5.6

Awesome! Should "Swift Next" in CHANGELOG.md become 5.6 as well?

Good catch. I'll push that change after CI testing completes, as that is a small cosmetic change.

tkremenek

comment created time in 2 months

pull request commentapple/swift

Update Swift version to 5.6

@swift-ci clean test

tkremenek

comment created time in 2 months

PR opened apple/swift

Update Swift version to 5.6

Update Swift version to 5.6.

+8 -8

0 comment

5 changed files

pr created time in 2 months

create barnchtkremenek/swift

branch : swift-5.6-version

created branch time in 2 months

push eventtkremenek/swift

swift-ci

commit sha 88cf178fab78229a9252381146cc517086b71a9c

Merge pull request #37888 from DougGregor/actor-isolation-defer

view details

Mishal Shah

commit sha a8ae401d0a2f2313b4f8254d94682dcce73e7af8

Strip i386 arch from tvOS simulator lib

view details

Ben Barham

commit sha 0eeaec178f37b2f23fbde75fd5ac64bad941f864

Merge pull request #37882 from hamishknight/a-non-complete-agreement [Async Refactoring] Add @discardableResult for defaulted completion

view details

Saleem Abdulrasool

commit sha 50fa6cfa91164b95c73d7d3d58fd0cbe7c46c1c8

Merge pull request #37775 from compnerd/static-deserialization IRGen: handle static imports in deserialised modules

view details

Varun Gandhi

commit sha 02afb9d49bf2930a5b5725dc3d4ad2c4f33ec2ef

[ModuleInterface] Print full type if ambiguous for extensions. The patch introduces a new setting instead of changing existing settings because the generated interfaces in the IDE have slightly different requirements; the extended type there is unconditionally not printed qualified (even if it is ambiguous). This is likely because the ambiguity heuristic is very weak; it doesn't even do name lookup. Simplifying that logic would be nice, but then we'd need to update a bunch of IDE/print* tests and end up with more more visual clutter in the IDE. Introducing the new setting means we can change the behavior for swiftinterface files without affecting the behavior for IDE interfaces. Fixes rdar://79093752.

view details

Slava Pestov

commit sha 19ab767ceb35c5e7479cdde3bc2eb71bd39934e3

Sema: Refactor resolveTopLevelIdentTypeComponent() a little

view details

Slava Pestov

commit sha c90d64d4feb4f9b9baeaa28cfcd960997d46d536

Sema: Reject generic arguments applied to 'Self' Previously these were simply ignored. Fixes https://bugs.swift.org/browse/SR-14731 / rdar://problem/79051797.

view details

NevinBR

commit sha ed0b7737fd3e0d305f413ddc21dd726405619351

[nfc] Fixed typos in comments in Sort.swift There is still an incongruity between where `srcHigh` and `destHigh` are displayed in the diagram: `srcHigh` is shown at the location it logically represents, not its true position which is one past that, whereas `destHigh` (as well as `bufferHigh`) is shown at its true position (past the end) not at the location it logically represents. I am not sure if that is intentional.

view details

Mishal Shah

commit sha 7af2ceb14faba0bec04767c1b695077a071182e5

Merge pull request #37889 from apple/strip-i386-tvos Strip i386 arch from tvOS simulator lib

view details

Evan Wilde

commit sha a53ab388bbbe86db37fd388201781f6a50f414c4

Add missing distributed requirement to test (#37886)

view details

swift-ci

commit sha e731f013ceb12acb744f842fb3a4ef38d9c21c10

Merge pull request #37703 from owenv/api-digester-lift-sdk-requirement

view details

Michael Gottesman

commit sha 18670fc389d70ae8f0e7a12194b6563a2713a74d

[assembly-vision] Rename opt remark generator to assembly vision remark generator. TLDR: The reason why I am doing this is that often times people confuse assembly vision remarks for normal opt remarks. I want to accentuate that this is actually trying to do something different than a traditional opt remark. To that end I renamed things in the compiler and added a true attribute `@_assemblyVision` to trigger the compiler to emit these remarks to help everyone remember what this is in their ontology. I explain below the difference. ---- Normal opt remarks work by the optimizer telling you if it succeeded or failed to perform an optimization. Another way of putting this is that opt remarks is trying to give back feedback to the user from an expert system about why it did or not do something. There is inherently an act of interpretation in the optimizer about whether or not to report an 'action' that it perpetrated to the user. Assembly Vision Remarks is instead trying to be an expert tool that acts like an xray. Instead of telling the user about what the optimizer did, it is instead a simple visitor that visits the IR and emits SourceLocations for where specific hazards ending up in the program. In this sense it is just telling the user where certain instructions ended up and using heuristics to relate this to information at the IR level. To a get a sense of this difference, consider the following Swift Code: ``` public class Klass { func doSomething() {} } var global: Klass = Klass() @inline(__always) func bar() -> Klass { global } @_assemblyVision @inline(never) func foo() { bar().doSomething() } ``` In this case, we will emit the following remarks: ``` test.swift:16:5: remark: begin exclusive access to value of type 'Klass' bar().doSomething() ^ test.swift:7:5: note: of 'global' var global: Klass = Klass() ^ test.swift:16:9: remark: end exclusive access to value of type 'Klass' bar().doSomething() ^ test.swift:7:5: note: of 'global' var global: Klass = Klass() ^ test.swift:16:11: remark: retain of type 'Klass' bar().doSomething() ^ test.swift:7:5: note: of 'global' var global: Klass = Klass() ^ test.swift:16:23: remark: release of type 'Klass' bar().doSomething() ^ test.swift:7:5: note: of 'global' var global: Klass = Klass() ^ ``` Notice how the begin/end exclusive access are marked as actually being before the retain, release of global. That seems weird since exclusive access to memory seems like something that should not escape an exclusivity scope... but in fact this corresponds directly to what we eventually see in the SIL: ``` // test.sil sil hidden [noinline] [_semantics "optremark"] @$ss3fooyyF : $@convention(thin) () -> () { bb0: %0 = global_addr @$ss6globals5KlassCvp : $*Klass %1 = begin_access [read] [dynamic] [no_nested_conflict] %0 : $*Klass %2 = load %1 : $*Klass end_access %1 : $*Klass %4 = class_method %2 : $Klass, #Klass.doSomething : (Klass) -> () -> (), $@convention(method) (@guaranteed Klass) -> () strong_retain %2 : $Klass %6 = apply %4(%2) : $@convention(method) (@guaranteed Klass) -> () strong_release %2 : $Klass %8 = tuple () return %8 : $() } // end sil function '$ss3fooyyF' ``` and assembly, ``` // test.S _$ss3fooyyF: pushq %rbp movq %rsp, %rbp pushq %r13 pushq %rbx subq $32, %rsp leaq _$ss6globals5KlassCvp(%rip), %rdi leaq -40(%rbp), %rsi xorl %edx, %edx xorl %ecx, %ecx callq _swift_beginAccess movq _$ss6globals5KlassCvp(%rip), %r13 movq (%r13), %rax movq 80(%rax), %rbx movq %r13, %rdi callq _swift_retain callq *%rbx movq %r13, %rdi callq _swift_release addq $32, %rsp popq %rbx popq %r13 popq %rbp retq ``` so as one can see what we are trying to do is inform the user of hazards in the code without trying to reason about it, automated a task that users often have to perform by hand: inspection of assembly to determine where runtime calls and other hazards ended up.

view details

Michael Gottesman

commit sha 3fdb0fd541c09209db677cc5e8774df62879a5d7

[assembly-vision] Add function attribute '@_assemblyVision' This is just a shortcut for @_semantics("optremark") to make it easier for people to remember how to enable assembly vision remarks. Now one can just type: ``` @_assemblyVision func foo() { ... } ``` and get all normal opt-remarks + assembly vision remarks.

view details

swift-ci

commit sha 38a8b008bc66b11fbc70c9d927177ce13a82fa97

Merge pull request #37857 from 3405691582/FixImplicitImport

view details

Michael Gottesman

commit sha 8eb14fccb1e7371ea4f409e64235ebde4fb21937

Merge pull request #37895 from gottesmm/assembly-vision-rebrand [assembly-vision] Finish rebranding of opt remark gen to Assembly Vision Remark and add @_assemblyVision Attr

view details

Minhyuk Kim

commit sha c3ab99a40561daad2f15480e3fbee1ed21c17bc4

[Sema] Offer 'is' replacement for unused 'if let' expression when the operand is optional

view details

swift-ci

commit sha 92580800e27747553348296b6ecb0e73cf3cb482

Merge pull request #35949 from fwcd/android-lib-path

view details

Alex Hoppen

commit sha e8d1a160e3e2074a93e41c127910e521b2a76f56

Merge pull request #37712 from kimdv/kimdv/add-helper-for-swift-syntax-default-value [SwiftSyntax] Add helper for default value in swift syntax builder inits

view details

Andrew Trick

commit sha 7d11dc50041378acf653de4076c0cd979ab366be

Fix DEBUG_TYPE=optimize-hop-to-executor

view details

Andrew Trick

commit sha c4f1f56ea75c79ca6a99adeb1025fe7fb89ce3d7

Add Builtin.hopToActor SILGen this builtin to a mandatory hop_to_executor with an actor type operand. e.g. Task.detached { Builtin.hopToActor(MainActor.shared) await suspend() } Required to fix a bug in _runAsyncMain.

view details

push time in 2 months

PullRequestReviewEvent

push eventapple/swift

Xi Ge

commit sha 788eb0128ef4b8c65039d9a68ed926b0d020dc2e

ModuleInterface: pass down -disable-availability-checking to module building command Related to: rdar://80703470

view details

Xi Ge

commit sha 2d5e4b521ff8baa308f8f4bf81dfa0f059e34d45

test: require X86_64 for disable-availability-checking.swift rdar://80799638

view details

Ted Kremenek

commit sha 75a48d8a5a9cc74604cc81711b353843ebf7e201

Merge pull request #38465 from nkcsgexi/80703470-5.5 [5.5]ModuleInterface: pass down -disable-availability-checking to module building command

view details

push time in 2 months

PR merged apple/swift

[5.5]ModuleInterface: pass down -disable-availability-checking to module building command

Related to: rdar://80703470

+20 -0

5 comments

2 changed files

nkcsgexi

pr closed time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventapple/swift

Xi Ge

commit sha 74c87db695ac334e0ce1d27614eabf905d3da36a

TextualInterface: print __conuming before accessors rdar://80535144

view details

Ted Kremenek

commit sha 5d2308058987a0aaa03a5f078592d8f1dc29ab47

Merge pull request #38423 from nkcsgexi/80535144-5.5 [5.5] TextualInterface: print __conuming before accessors

view details

push time in 2 months

PR merged apple/swift

[5.5] TextualInterface: print __conuming before accessors

rdar://80535144

+30 -1

1 comment

2 changed files

nkcsgexi

pr closed time in 2 months

PullRequestReviewEvent
MemberEvent
MemberEvent