profile
viewpoint
Steven Luscher steveluscher Vancouver, BC

pcrawfor/FayeObjC 133

Objective-C Client Library for the Faye Pub-Sub messaging server (http://faye.jcoglan.com/)

rcs/jsenv-brunch 34

Add support for processing .jsenv files to Brunch (http://brunch.io). Read environment values to compile to JS.

steveluscher/bookkeeper 20

A double-entry accounting system for Rails.

steveluscher/Blast-Mojo 4

Blast Mojo is a patterns-based JavaScript framework that provides a consistent event- driven architecture for complex client-side web applications, built on existing best-of- breed JS libraries. Its objectives are to provide a structured way of developing Rich Internet Applications, abstract complexities by separation of concerns, and maximize re-use of existing code, in order to maintain knowledge and improve on speed and quality of deliverables.

loyalchow/Blast-Mojo 2

Blast Mojo is a patterns-based JavaScript framework that provides a consistent event- driven architecture for complex client-side web applications, built on existing best-of- breed JS libraries. Its objectives are to provide a structured way of developing Rich Internet Applications, abstract complexities by separation of concerns, and maximize re-use of existing code, in order to maintain knowledge and improve on speed and quality of deliverables.

steveluscher/2013.cascadiajs.com 0

This is the official repo for the CascadiaJS 2013 conference.

steveluscher/2014.cascadiajs.com 0

This is the official repo for the CascadiaJS 2014 conference.

steveluscher/api.jqueryui.com 0

API documentation for jQuery UI

steveluscher/audjustable 0

A fast and extensible gapless AudioPlayer/AudioStreamer for OSX and iOS (iPhone, iPad)

issue commentghostery/ghostery-extension

Possible false positive with Adobe Test & Target rule (Facebook CDN)

That's great news; thank you!

steveluscher

comment created time in a month

issue openedghostery/ghostery-extension

Possible false positive with Adobe Test & Target rule (Facebook CDN)

Description

I have received a report of Ghostery blocking this resource. The block was made according to the ‘Adobe Test & Target’ rule:

https://static.xx.fbcdn.net/rsrc.php/v3/yM/r/MBOX6JqmhhS.js?_nc_x=yIsXPYraEd4

This is a resource from the Facebook CDN that, like many others like it, is critical for the operation of the website. Do you see anything about that file or that URL that would trigger that rule, and do you believe this to be a false positive that can be fixed?

Expected Behavior

Resource should trigger no rule.

Actual Behavior

Resource triggers the ‘Adobe Test & Target’ rule; gets blocked.

Steps to Reproduce

  1. Use Ghostery.
  2. Load the Beta version of facebook.com.
  3. Observe that https://static.xx.fbcdn.net/rsrc.php/v3/yM/r/MBOX6JqmhhS.js?_nc_x=yIsXPYraEd4 triggers the ‘Adobe Test & Target’ rule; gets blocked.

created time in 2 months

issue closedeslint/eslint

no-fallthrough reports false positive when commenting cases

Consider the following code:

var value = 'ONE';
switch (value) {
  case 'ONE':
  default:
    1 == 1;
    break;
  case 'TWO':
    1 == 1;
    break; 
}

Lint is fine with that, until such time as you try to add a comment admidst the cases.

var value = 'ONE';
switch (value) {
  case 'ONE':
  // A helpful comment.
  default:
    1 == 1;
    break;
  case 'TWO':
    1 == 1;
    break; 
}

…at which point the no-fallthrough error is raised.

A comment here doesn't affect the runtime behavior, right, so to error here is a false positive?

Repro link.

closed time in 2 months

steveluscher

issue openedeslint/eslint

no-fallthrough reports false positive when commenting cases

Consider the following code:

var value = 'ONE';
switch (value) {
  case 'ONE':
  default:
    1 == 1;
    break;
  case 'TWO':
    1 == 1;
    break; 
}

Lint is fine with that, until such time as you try to add a comment admidst the cases.

var value = 'ONE';
switch (value) {
  case 'ONE':
  // A helpful comment.
  default:
    1 == 1;
    break;
  case 'TWO':
    1 == 1;
    break; 
}

…at which point the no-fallthrough error is raised.

A comment here doesn't affect the runtime behavior, right, so to error here is a false positive?

Repro link.

created time in 3 months

more