profile
viewpoint

stefanmb/dehydrated-cloudflare-hook 2

My own shitty (yet better than anything else I've tried) version of a dns-01 hook and deploy script for dehydrated letsencrypt client

stefanmb/agent 0

The Buildkite Agent is an open-source toolkit written in Golang for securely running build jobs on any device or network

stefanmb/binutils-gdb 0

Unofficial mirror of sourceware binutils-gdb repository. Updated daily.

stefanmb/cluster-registry 0

Cluster Registry API

stefanmb/coredns 0

CoreDNS is a DNS server that chains plugins

stefanmb/dnsblast 0

A simple and stupid load testing tool for DNS resolvers

stefanmb/kubernetes-deploy 0

A command-line tool that helps you ship changes to a Kubernetes namespace and understand the result

stefanmb/kubernetes-namespace-reservation 0

An admission webhook that prevents the creation of specified namespaces

stefanmb/nginx 0

nginx docker instance

stefanmb/node 0

✨Node.js ✨

PR closed coredns/coredns

Custom tag support in trace plugin

1. Why is this pull request needed and what does it do?

This PR adds optional custom tag support to the trace plugin. Zero or more tags are supported, and they are added to the emitted spans.

I am managing a large deployment of CoreDNS instances with multiple configurations and exporting sampled traces to Stackdriver and Lightstep. Without custom tags it's hard to tell which instances the traces correspond to.

2. Which issues (if any) are related?

None

3. Which documentation changes (if any) need to be made?

trace README should explain the use of the tag block, this PR includes the necessary changes.

4. Does this introduce a backward incompatible change or deprecation?

No

+121 -8

8 comments

5 changed files

stefanmb

pr closed time in 2 months

pull request commentcoredns/coredns

Custom tag support in trace plugin

@miekg I dropped the ball on this due to other priorities. I'm going to close it for now, once I get a chance to redo it based on the feedback I can open up a new PR. Thanks for your patience.

stefanmb

comment created time in 2 months

more