profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/soleo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Xinjiang Shao soleo Peapod Digital Labs Chicago, IL https://www.xinjiangshao.com The dude who works as a software engineer, dreams about being a chef, and tries to design pleasant things

soleo/android-sleep-tracker 17

An app to track your sleep at night.

edgrosvenor/PrepHero-SDK-Collection 2

A collection of public development kits for PrepHero.com

soleo/awesome-reading 1

A collection of books or essays that I think it's worth to be read or shared with others

soleo/chinglish-ipsum-generator 1

Chinglish is going to rule the world, be prepared to accept the change.

soleo/code-challenges 1

A set of code challenges for practice

soleo/coinpayments-dashboard-wordpress-plugin 1

A plugin to display stats from coinpayments.net

PinIdea/woocommerce-pdf-invoices-packing-slips 0

Create, print & automatically email PDF invoices & packing slips for WooCommerce orders.

soleo/ansible-wordpress 0

Ansible playbook for configuring development and production servers with WordPress.

soleo/avatarify 0

Avatars for Zoom, Skype and other video-conferencing apps.

issue closedevanw/esbuild

esbuild does not tree shake implicit type import

It seems that esbuild shake the explicit import type { Draft} from 'immer' , but does not shake import { Draft } from 'immer' even though Draft is type only and I configure "importsNotUsedAsValues": "remove" in tsconfig.json. you can see the problem here https://github.com/reduxjs/redux-toolkit/pull/957#issuecomment-810725314

closed time in 2 hours

hardfist

issue commentevanw/esbuild

How to enable debug logging for path resolution

logLevel: 'debug' not working, but logLevel: 'verbose' works

hardfist

comment created time in 2 hours

issue closedevanw/esbuild

How to enable debug logging for path resolution

I sometimes met something like Could not resolve xxx problems, which is kind of hard to debug image

Typescript has something like --explainFiles to debug problem like this, it would be helpful to print the the default resolve process to debug problem like this.

closed time in 2 hours

hardfist

issue commentevanw/esbuild

how to get changed file info on watch mode

Oh, It seems that esbuild already has changed file info image

hardfist

comment created time in 2 hours

issue openedevanw/esbuild

how to get changed file info on watch mode

It seems that onRebuild hook doesn't expose any changed file info like rollup's watchChange hooks, and the changed file info is helpful when build custom HMR logic, I know I can implement this using increment && custom watcher, but it would be nice if esbuild could support this internally.

created time in 2 hours

issue openedevanw/esbuild

Uncaught Error: Dynamic require of "overlayscrollbars" is not supported

my js


  if (typeof OverlayScrollbars !== 'undefined') {

    OverlayScrollbars(document.querySelectorAll(SELECTOR_SIDEBAR), {

because i exculde ```js external: ['@types/overlayscrollbars', 'overlayscrollbars'],


error

```console
Uncaught Error: Dynamic require of "overlayscrollbars" is not supported

i have also added typeof with undefined ```js if (typeof OverlayScrollbars !== 'undefined') {

created time in 6 hours

issue openedevanw/esbuild

Error of missing dependencies when platform is set to neutral

When I try to create a ESM bundle with the platform set to neutral, it errors with the following:

error: Could not resolve "mitt" (mark it as external to exclude it from the bundle)

Works fine if the target is browser or node

created time in 6 hours

pull request commentistio/istio

fix gateway merge on same port

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lint_istio 205e077710a19716d3b8dbc2d6f3709c6d17a4cd link /test lint_istio

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

ramaraochavali

comment created time in 6 hours

pull request commentistio/istio

fix gateway merge on same port

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lint_istio 6d59cd385e45c348bd1140a2779ea309cde4a85b link /test lint_istio

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

ramaraochavali

comment created time in 6 hours

pull request commentistio/istio

fix gateway merge on same port

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
release-notes_istio e79a1a77f5719250469e7d2ac2c943dd4c89b0d0 link /test release-notes_istio
lint_istio e79a1a77f5719250469e7d2ac2c943dd4c89b0d0 link /test lint_istio

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

ramaraochavali

comment created time in 6 hours

pull request commentistio/istio

fix gateway merge on same port

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
release-notes_istio e79a1a77f5719250469e7d2ac2c943dd4c89b0d0 link /test release-notes_istio

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

ramaraochavali

comment created time in 6 hours

pull request commentistio/istio

fix gateway merge on same port

@ramaraochavali: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
release-notes_istio 8a49aae47406ba13db1a3ec41c1c778646c02574 link /test release-notes_istio

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

ramaraochavali

comment created time in 6 hours

PR opened istio/istio

fix gateway merge on same port

https://github.com/istio/istio/issues/33405

[ ] Configuration Infrastructure [ ] Docs [ ] Installation [X] Networking [ ] Performance and Scalability [ ] Policies and Telemetry [ ] Security [ ] Test and Release [ ] User Experience [ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

+31 -18

0 comment

2 changed files

pr created time in 6 hours

issue closedevanw/esbuild

File with 'import' statement still being treated as CJS module

Environment

  • esbuild version: 0.12.8
  • node.js version: 12.18.4

I've tried the example in architecture.md

<table> <tr><th>foo.js</th><th>bar.js</th><th>bundle.js</th></tr> <tr><td>

export const fn = () => 123

</td><td>

import {fn} from './foo'
console.log(fn())

</td><td>

// foo.js
const fn = () => 123;

// bar.js
console.log(fn());

</td></tr> </table>

But when I ran the command esbuild bar.js --bundle --format=esm, The expected ouput was

// foo.js
const fn = () => 123;

// bar.js
console.log(fn());

however, I got

var __esm = (fn2, res) => function __init() {
  return fn2 && (res = (0, fn2[Object.keys(fn2)[0]])(fn2 = 0)), res;
};
var __commonJS = (cb, mod) => function __require() {
  return mod || (0, cb[Object.keys(cb)[0]])((mod = { exports: {} }).exports, mod), mod.exports;
};

// foo.js
var fn;
var init_foo = __esm({
  "foo.js"() {
    fn = () => 123;
  }
});

// bar.js
var require_bar = __commonJS({
  "bar.js"() {
    init_foo();
    console.log(fn());
  }
});
export default require_bar();

It seems like bar.js is treated as CJS module, though this file contains import statement. And I found if I added export statement in bar.js, the file would be treated as ESM module. <table> <tr><th>foo.js</th><th>bar.js</th><th>bundle.js</th></tr> <tr><td>

export const fn = () => 123

</td><td>

import {fn} from './foo'
export const rua = 233
console.log(fn())

</td><td>

// foo.js
var fn = () => 123;

// bar.js
var rua = 233;
console.log(fn());
export {
  rua
};

</td></tr> </table>

I also found that if I modified the type field to module in package.json, the origin example could ran as expected.

// package.json
{
  "type": "module",
  // ....
}

So I'm wondering how esbuild distinguish the entry point is esm or cjs module, the behavior above seems not making sense.

closed time in 7 hours

fun4wut

issue commentevanw/esbuild

File with 'import' statement still being treated as CJS module

@evanw Great explanation! Thanks

fun4wut

comment created time in 7 hours

release sindresorhus/trash

v7.2.0

released time in 7 hours

issue commentistio/istio

Proxy leaks memory on 1.9.5 with constant ADS re-connections when DestinationRule TLS files are not mounted

@howardjohn @bianpengyuan I believe I have managed to replicate with a vanilla istio 1.9.5 installation (--set profile=demo + prom + grafana addons) and bookinfo install using

apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: no-certs
spec:
  host: google.com
  trafficPolicy:
    tls:
      mode: MUTUAL
      clientCertificate: /etc/certs/myclientcert.pem
      privateKey: /etc/certs/client_private_key.pem
      caCertificates: /etc/certs/rootcacerts.pem
---
apiVersion: networking.istio.io/v1alpha3
kind: ServiceEntry
metadata:
  name: google-com
spec:
  hosts:
  - google.com
  location: MESH_EXTERNAL
  ports:
  - number: 80
    name: http
    protocol: HTTP

Not 100% sure I am doing it right, but here's what I see. When I delete the DestinationRule+ServiceEntry subsequent profiles see no obvious leak anymore.

I do see Node::MergeFrom in the chain when it appears to be leaking.

image

profile010.pdf

Are the constant ADS reconnects expected in such a case (not withstanding a leak being unexpected)?

chadlwilson

comment created time in 8 hours

issue commentevanw/esbuild

File with 'import' statement still being treated as CJS module

Doing what you describe doesn't reproduce this:

$ cat foo.js 
export const fn = () => 123

$ cat bar.js
import {fn} from './foo'
console.log(fn())

$ echo {} > package.json
$ npm i esbuild@0.12.8

$ ./node_modules/.bin/esbuild bar.js --bundle --format=esm
// foo.js
var fn = () => 123;

// bar.js
console.log(fn());

If I explicitly add "type": "commonjs" to package.json, then I do get the output you describe. So I'm assuming that this is what you did and that having "type": "commonjs" in package.json is part of the steps to reproduce the issue you're describing.

However, that annotation says that files ending in .js are in CommonJS format which is clearly not the case here. So either these .js files shouldn't have ESM syntax in them if they are supposed to be CommonJS, or the package.json file shouldn't have "type": "commonjs" in it if the .js files aren't actually CommonJS. These two things are in conflict.

If esbuild was being strict about this, the import statement would be a syntax error if you do this. That's what happens when you try to run this in node:

$ node bar.js 
(node:23220) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
./bar.js:1
import {fn} from './foo'
^^^^^^

But esbuild is less strict than node. It actually parses a superset of CommonJS and ESM and then uses heuristics to try to make it work anyway. The heuristics first check for ESM exports (the export keyword), and then check for CommonJS exports (the exports or module variables), and then finally fall back to checking the type entry of package.json. The reason why the import keyword doesn't cause the module to become CommonJS is because there is code in the wild that uses ESM imports but CommonJS exports, and esbuild needs to be able to support such code. Anyway I believe that's why this is happening.

fun4wut

comment created time in 8 hours

startedvfxpro99/usd-resources

started time in 10 hours

release sindresorhus/cp-file

v9.1.0

released time in 10 hours

release sindresorhus/move-file

v2.1.0

released time in 10 hours

startedrqlite/rqlite

started time in 12 hours

issue commentistio/istio

Istio Ingressgateway Cannot Proxy HTTPS from port 443

Any idea, in which Istio version is this fixed? I'm getting same error when I'm trying to upgrade from 1.8.6 to 1.9.5.

hustshawn

comment created time in 12 hours

pull request commentistio/istio

Prometheus configuration samples for VMs

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2021-05-13. It will be closed on 2021-06-27 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

liminw

comment created time in 12 hours

pull request commentistio/istio

WIP: Add injectorUserAgent annotation

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2021-05-13. It will be closed on 2021-06-27 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

mandarjog

comment created time in 12 hours

issue commentistio/istio

Open existing Prometheus

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2020-12-15. It will be closed on 2021-06-28 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

alen-z

comment created time in 12 hours

issue commentistio/istio

dial istiod.istio-system.svc:15012 i/o timeout when create a large number of pods at the same time

🧭 This issue or pull request has been automatically marked as stale because it has not had activity from an Istio team member since 2021-03-15. It will be closed on 2021-06-28 unless an Istio team member takes action. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

AEGQ

comment created time in 12 hours

issue closedistio/istio

typed_extension_protocol_options of any type supported in istio

Describe the feature request Like in https://www.envoyproxy.io/docs/envoy/latest/configuration/overview/examples.html?highlight=typed_extension_protocol_options, typed_extension_protocol_options works as an general way to handle any protocol related configuration. After search code of istio, seems only HttpProtocolOptions handled in this scenario. Is it possible to support other protocol's typed_extension_protocol_options, for example RedisProtocolOptions, ThriftProtocolOptions or others?

Describe alternatives you've considered set the typed_extension_protocol_options at DestinationRule and pass it into envoy configuration.

[ ] Docs [ ] Installation [ ] Networking [ ] Performance and Scalability [x] Extensions and Telemetry [ ] Security [ ] Test and Release [ ] User Experience [ ] Developer Infrastructure

Additional context

closed time in 13 hours

durd07

issue commentistio/istio

typed_extension_protocol_options of any type supported in istio

@howardjohn thanks for your response. I just use envoyfilter to adapt Lister configuration before. I can have a try with cluster configurations with that.

durd07

comment created time in 13 hours