profile
viewpoint
Shawn Smith shawnps @fastly Tokyo, Japan http://goreportcard.com Co-author and maintainer of Go Report Card. Golang user/contributor for 8+ years.

client9/ipcat 445

Categorization of IP Addresses

gojp/nihongo 58

Japanese Dictionary

client9/reopen 20

freopen functionality for golang's io.Writers

client9/gosupplychain 16

Tools to help golang projects audit dependencies, check licenses, and create bill-of-materials

philips/tapkick 11

kegerator monitoring system (disclaimer: written while testing the system)

jaker/cutecode 6

Small code posting site

Kami/libcloud.rest 3

REST interface for Libcloud

shawnps/budget 3

super simple budget tool

ausocean/h264decode 2

Simplistic H264 decoder

shawnps/boto 1

Python interface to Amazon Web Services

pull request commentklauspost/compress

run vet on all versions but go 1.12

@klauspost through some trial and error I finally got this working if you want to bring it into your branch 👍

The failing builds are due to legitimate vet errors as you mentioned. Builds on 1.12 skip vet and continue:

https://travis-ci.org/klauspost/compress/jobs/652357469?utm_medium=notification&utm_source=github_status

shawnps

comment created time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 5cd44393ee1f29d6c5d8df3fe2615b0ba298b908

build: run vet on all versions but go 1.12

view details

push time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 9055eb95457802f52a75377af4a3388f345c7caf

build: run vet on all versions but go 1.12

view details

push time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha ad2804e8fea64d95f978e16ba23a6df47a7012a4

build: run vet on all versions but go 1.12

view details

push time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 86ee31de3ad29b42b92a1e4078ab4587501384ab

build: run vet on all versions but go 1.12

view details

push time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 72917b20f144690c5ca16f661f4241a5bed8aa2a

build: run vet on all versions but go 1.12

view details

push time in 4 days

pull request commentklauspost/compress

run vet on all versions but go 1.12

@klauspost however, looks like it's not working:

https://travis-ci.org/klauspost/compress/jobs/652321614?utm_medium=notification&utm_source=github_status

Let me see if I can do some digging and find out why.

shawnps

comment created time in 4 days

pull request commentklauspost/compress

run vet on all versions but go 1.12

@klauspost yes no problem, feel free to delete my commit, no need to do any cherry-picking if you don't feel like it.

shawnps

comment created time in 4 days

pull request commentklauspost/compress

use previously defined size var when making dst byte slice

FWIW, I found this issue through ineffassign:

https://goreportcard.com/report/github.com/klauspost/compress#ineffassign

There are more, but some seem like false positives. This one looks real:

https://github.com/klauspost/compress/blob/master/gzip/gzip_test.go#L214

But I wasn't sure how that file is maintained since it seems to be from the Go source. It appears fixed upstream:

https://github.com/golang/go/blob/master/src/compress/gzip/gzip_test.go#L216-L219

shawnps

comment created time in 4 days

delete branch shawnps/compress

delete branch : use-size-var

delete time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 469aa3c4c6a52e78b256404952fde15ef35681cb

build: run vet on all versions but go 1.12

view details

push time in 4 days

PR opened klauspost/compress

run vet on all versions but go 1.12

@klauspost This is a bit weird, but I think running go vet would still be useful even if you have to skip 1.12. Happy to throw this PR away if you think this is too much of a hack.

+1 -0

0 comment

1 changed file

pr created time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 406a2094e583c53087cb1b52a0b4e3c03a8ac62f

run vet on all versions but go 1.12

view details

push time in 4 days

create barnchshawnps/compress

branch : travis-vet-pt2

created branch time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 2dd61e3970592df5fd6edfb0465bc3d71a508ef0

use previously defined size var when making dst byte slice

view details

push time in 4 days

create barnchshawnps/compress

branch : use-size-var

created branch time in 4 days

PR opened klauspost/compress

fix typos
+3 -3

0 comment

2 changed files

pr created time in 4 days

push eventshawnps/compress

Shawn Smith

commit sha 4c6b15c67fc81990bdf9bf27b45b4717fc292563

fix typos

view details

push time in 4 days

fork shawnps/compress

Optimized compression packages

fork in 4 days

push eventshawnps/tailscale

Shawn Smith

commit sha 8c8b64b509cad0ed241f54673875e3f0374a333a

fix typos Signed-off-by: Shawn Smith <shawnpsmith@gmail.com>

view details

push time in 12 days

PR opened tailscale/tailscale

fix comment typos
+2 -2

0 comment

2 changed files

pr created time in 12 days

push eventshawnps/tailscale

Shawn Smith

commit sha 505e6a83bd9465b09cb5ff835911299e8cdc6ded

fix typos

view details

push time in 12 days

fork shawnps/tailscale

Private WireGuard networks made easy

https://tailscale.com/

fork in 12 days

push eventgojp/goreportcard

Shawn Smith

commit sha 3df7a09272deb832acf4880b87f645ff4a400a27

update front page sponsored report cards

view details

push time in 12 days

push eventgojp/goreportcard

Shawn Smith

commit sha 0e10c8060f5e4ef22915f9ff0893809505a04e56

check another missed error

view details

push time in 12 days

push eventgojp/goreportcard

Shawn Smith

commit sha 961b4ebe9895dd0d2351e37999a09d5eb6c0c69b

fix high scores bug unchecked error - closes #310

view details

push time in 12 days

issue closedgojp/goreportcard

High scores page broken

Looks like the high scores page broke with the badger migration. Need to figure out why.

closed time in 12 days

shawnps

pull request commentgojp/goreportcard

add badges assets for for-the-badge style

@micnncim no worries, let us know if we can help.

micnncim

comment created time in 12 days

pull request commentgojp/goreportcard

add badges assets for for-the-badge style

@micnncim hmm, maybe it's the spacing?

pkg.go.dev: image

go report: image

micnncim

comment created time in 12 days

issue openedgojp/goreportcard

High scores page broken

Looks like the high scores page broke with the badger migration. Need to figure out why.

created time in 12 days

push eventgojp/goreportcard

Shawn Smith

commit sha 9ec286975757ea6e6187a92ba3578d52bcb9e3cc

begin boltdb => badger migration

view details

Shawn Smith

commit sha 22675ec7b703b92bd90bebbe9880a084a2cf18fb

update protobuf library

view details

Shawn Smith

commit sha 7010bcacb94d90372f147ac95289c3d201392b69

remove unused tools, unused metabucket constant

view details

Shawn Smith

commit sha fd6f08d3ef678957c61e2f5186d389b0f5c8c032

badger migration: fix high scores handler

view details

Shawn Smith

commit sha 4b8f3b4d16db086ee1ed8171b34868c9b98fd82b

badger migration: add migration tool

view details

Shawn Smith

commit sha 19ede72e707883a044e408400be7143b22165fac

inject badger db into handlers

view details

Shawn Smith

commit sha 815bf67ea2d0d64176faeedd260fb163f6a6eb79

inject badger db into handlers part 2

view details

Shawn Smith

commit sha 9ba34e27ad28a3b88f6c7fed55cb122f2b732f39

fix boltdb path

view details

Shawn Smith

commit sha ec94215218442b5c8cada7011d2b57ef43468fdc

remove log line, save to cache when not found

view details

Shawn Smith

commit sha f3452d88db82ac0192bf873723780b65306d2bae

if repo not found in badger cache, check boltdb. if found in boltdb, set in badger and return

view details

Shawn Smith

commit sha 4df79763a680b36c85638352903c37f1021cc026

remove remaining boltdb logic

view details

push time in 12 days

push eventgojp/goreportcard

Sven Lechner

commit sha 1a21c18fd4a32f85e8395724e7afbf30755505b7

add json flag to output results as json This commit adds the ability to output the check results as json data. This functionality is intended for scripting purposes. Therefore the binary will always exit with code 0. The threshold flag is also ignored when '-j' has been specified.

view details

Shawn Smith

commit sha c2aae3355cbebab0773e9ded7ecef9b7e17c59ce

Merge pull request #293 from SirWindfield/add_json_flag add json flag to output results as json

view details

Shawn Smith

commit sha 41818f5fd2953c48a43e068020bd3b0241e7dffb

gofmt

view details

Chad Grant

commit sha 279a3680138f6b48541c38b5d78add9134c9d52f

Update Dockerfile Should create the base layer of apk add first so the cache is not invalidated when code changes Should not apk/apt upgrade in docker images (bloats image)

view details

Herman Schaaf

commit sha 9f81841636276fde3b99b1a970d5393a59f508a6

Merge pull request #306 from chadgrant/patch-1 Update Dockerfile

view details

micnncim

commit sha a63fd842d7f2ae29909df092e8c1637e62143e78

add badges assets for for-the-badge style

view details

Herman Schaaf

commit sha df965ca5b9ea4ec153a119a26e9bd8053eaa4656

Merge pull request #309 from micnncim/add-style-for-the-badge add badges assets for for-the-badge style

view details

Shawn Smith

commit sha 9ec286975757ea6e6187a92ba3578d52bcb9e3cc

begin boltdb => badger migration

view details

Shawn Smith

commit sha 22675ec7b703b92bd90bebbe9880a084a2cf18fb

update protobuf library

view details

Shawn Smith

commit sha 7010bcacb94d90372f147ac95289c3d201392b69

remove unused tools, unused metabucket constant

view details

Shawn Smith

commit sha fd6f08d3ef678957c61e2f5186d389b0f5c8c032

badger migration: fix high scores handler

view details

Shawn Smith

commit sha 4b8f3b4d16db086ee1ed8171b34868c9b98fd82b

badger migration: add migration tool

view details

Shawn Smith

commit sha 19ede72e707883a044e408400be7143b22165fac

inject badger db into handlers

view details

Shawn Smith

commit sha 815bf67ea2d0d64176faeedd260fb163f6a6eb79

inject badger db into handlers part 2

view details

Shawn Smith

commit sha 9ba34e27ad28a3b88f6c7fed55cb122f2b732f39

fix boltdb path

view details

Shawn Smith

commit sha ec94215218442b5c8cada7011d2b57ef43468fdc

remove log line, save to cache when not found

view details

Shawn Smith

commit sha f3452d88db82ac0192bf873723780b65306d2bae

if repo not found in badger cache, check boltdb. if found in boltdb, set in badger and return

view details

Shawn Smith

commit sha 4df79763a680b36c85638352903c37f1021cc026

remove remaining boltdb logic

view details

push time in 12 days

pull request commentgoogleapis/google-cloud-go

Fix snippet formatting in README

@hongalex ah, sorry I missed the CONTRIBUTING.md. Sure, I'll take a look tomorrow.

shawnps

comment created time in a month

delete branch shawnps/google-cloud-go

delete branch : patch-1

delete time in a month

push eventgojp/kana

Koji Nishikiori

commit sha 54cf7c77b8b979488193186196a48b2b02b59c27

Add tu

view details

Shawn Smith

commit sha 5456a3aa55f14cc22401d5eb0ac5250898e9772a

Merge pull request #33 from wataori/master Add tu

view details

push time in a month

PR merged gojp/kana

Add tu

Hello there.

I've used kana for several months, thanks. Today our customer confused because input tu as converted to tう. I feel its converter is based on Hepburn-Style spells and know tu was not defined there but actually people use it and no conflict with other. So I added tu.

+4 -2

1 comment

3 changed files

wataori

pr closed time in a month

pull request commentgojp/kana

Add tu

Makes sense to me! Thanks @wataori

wataori

comment created time in a month

push eventshawnps/google-cloud-go

Shawn Smith

commit sha 3cc4776a0093c05e2a6410856b22efd53acf46f9

Fix snippet formatting

view details

push time in a month

PR opened fastly/go-fastly

fix typos
+3 -3

0 comment

3 changed files

pr created time in 3 months

push eventshawnps/go-fastly

Shawn Smith

commit sha 0c8b698a4b5578991e9d192c78053a1a9c8c4bf2

fix typos

view details

push time in 3 months

fork shawnps/go-fastly

A golang Fastly API client library.

fork in 3 months

issue commentgojp/goreportcard

502 on `/report/github.com/minon*`

@minond could you try again? I've tried a couple of your repos and it seems to work now.

minond

comment created time in 3 months

push eventgojp/goreportcard

Shawn Smith

commit sha 033be3243b6c73dbddbc0f5bd04b7f6fdfa0acb3

remove remaining boltdb logic

view details

push time in 3 months

push eventgojp/goreportcard

Shawn Smith

commit sha 031630cfbb1915b434c848872c6d2e736f18e975

remove remaining boltdb logic

view details

push time in 3 months

issue commentgojp/goreportcard

502 on `/report/github.com/minon*`

Hi @minond

We were having some file corruption issues with boltdb, so we switched to dgraph's badger. But it looks like we're still using boltdb in one place, and the code went down that path and panicked when accessing the boltdb file.

I'll look into removing the last pieces of boltdb, but I'm not sure when I can get to it -- hopefully in the next couple of days.

minond

comment created time in 3 months

issue commentgojp/kana

Kanji characters not being translated, but Hiragana characters are translated

Hi @marv72 yes, this library only converts between hiragana, katakana, and romaji. We built this many years ago for use in our Japanese dictionary https://nihongo.io. I suppose we only did hiragana/katakana support for purposes of speed -- kanji would require building a large data structure and would slow the library down.

We use this library on nihongo.io to detect whether a word is Latin-based, and if it is we convert it to hiragana and katakana and search:

https://github.com/gojp/nihongo/blob/master/lib/dictionary/dictionary.go#L104-L110

marv72

comment created time in 3 months

PR opened square/ghostunnel

Some "ineffassign" fixes

Just some fixes that I found on Go Report Card.

Let me know if they're not necessary or the messages aren't quite right, happy to close it out or modify as needed.

+5 -0

0 comment

3 changed files

pr created time in 4 months

create barnchshawnps/ghostunnel

branch : ineffassign-fixes

created branch time in 4 months

issue commentsquare/ghostunnel

Enforce `gofmt` in CI

FWIW I've done something like this in past projects with success:

https://github.com/gojp/kana/blob/master/.travis.yml#L6

before_script:
  - fmtRes="$(gofmt -s -l .)" bash -c '[ "$fmtRes" == "" ] || (echo -e "The following files did not pass gofmt -s:\n" "$fmtRes" && exit 1)'

There is likely a better way though :)

mcpherrinm

comment created time in 4 months

PR opened square/ghostunnel

Style fixes

I also encountered some changes to go.mod and go.sum but figured this was not the right PR for those.

+6 -6

0 comment

4 changed files

pr created time in 4 months

create barnchshawnps/ghostunnel

branch : style-fixes

created branch time in 4 months

fork shawnps/ghostunnel

A simple SSL/TLS proxy with mutual authentication for securing non-TLS services

fork in 4 months

PR opened twmb/kafka-go

gofmt -s -w
+161 -161

0 comment

2 changed files

pr created time in 4 months

push eventshawnps/kafka-go

Shawn Smith

commit sha ba766949da0e749ace6bf33ea4efed52527ced0c

gofmt -s -w

view details

push time in 4 months

startedtwmb/kafka-go

started time in 4 months

issue commentgojp/goreportcard

Out of memory when checking format

@andydotxyz There's nothing you can do on the repo itself as far as I know. It's basically because we run this app on a single small instance and we've had to push it to its limit.

A couple of weeks ago I added an in-memory cache for the badge URL lookups. But that cache only gets bigger unless we restart the app (which I just did, and then re-ran your report which now seems fixed). I might try adding timeouts to the cache entries and have a poller running in the background which purges entries > a day old or something like that.

I was recently accepted into the GitHub Sponsors program, so I might possibly be able to take donations through that on behalf of Go Report Card and upgrade the server with the money. In the meantime we do have a Patreon as well: https://www.patreon.com/goreportcard

With more servers we'd probably split it out into 2 "worker" nodes and then a memcache/redis/etc. server for the caching. It would take some time and effort to re-architect everything. Unfortunately it hasn't been feasible since we don't make enough money at the moment.

andydotxyz

comment created time in 4 months

startedmmcloughlin/avo

started time in 4 months

issue commentgojp/goreportcard

Out of memory when checking format

@andydotxyz yeah, looks like our server is reaching its capacity :) I re-ran the report and it seems to be back to normal.

andydotxyz

comment created time in 4 months

startedkamranahmedse/git-standup

started time in 4 months

issue commentgojp/goreportcard

idea: Branch switching?

@johnfercher thanks for bringing this back to our attention. I'm discussing with @hermanschaaf but unfortunately we don't have much time recently to work on new features. Hopefully we will find some time in the future.

It's possible we will make it available to supporters at https://www.patreon.com/goreportcard.

hako

comment created time in 5 months

pull request commentausocean/h264decode

remove identical mbToSliceGroupMap[i] != mbToSliceGroupMap[i] comparison

Actually, I just realized this isn't quite right -- removing it changes the way the loop worked previously.

Before, it would have never incremented i because mbToSliceGroupMap[i] != mbToSliceGroupMap [i] is always false.

shawnps

comment created time in 5 months

create barnchausocean/h264decode

branch : remove-identical-comparison

created branch time in 5 months

PR opened ausocean/h264decode

Reviewers
check error returned by readFlags
+4 -0

0 comment

1 changed file

pr created time in 5 months

create barnchausocean/h264decode

branch : check-err

created branch time in 5 months

push eventgojp/kana

Emile

commit sha 1cc68558c7ac8fb64e9c0f3af491e86a24075439

added the godoc badge This helps other developers finding the documentation.

view details

Shawn Smith

commit sha adecbfd46f6c82d3ff20c9ee65b997b540b7b916

Merge pull request #31 from HanEmile/godoc-badge added the godoc badge

view details

push time in 5 months

PR merged gojp/kana

added the godoc badge

This helps other developers finding the documentation.

+1 -1

0 comment

1 changed file

HanEmile

pr closed time in 5 months

pull request commentgojp/japanese

added the godoc badge

Thanks!

HanEmile

comment created time in 5 months

push eventgojp/japanese

Emile

commit sha 0369c54a06e818a21b8b13718ed5785a3c9aa153

added the godoc badge

view details

Shawn Smith

commit sha f32ec16f5b31df7c9ada128850754875dea3afab

Merge pull request #13 from HanEmile/godoc-badge added the godoc badge

view details

push time in 5 months

PR merged gojp/japanese

added the godoc badge

added the godoc badge helping users find documentation for the package.

+1 -1

0 comment

1 changed file

HanEmile

pr closed time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 41818f5fd2953c48a43e068020bd3b0241e7dffb

gofmt

view details

push time in 5 months

PR closed gojp/goreportcard

Fix command for starting local server

It seems that the document is outdated. The start-dev command does not seem to exist in the Makefile anymore. Running the command fails:

make start-dev
make: *** No rule to make target `start-dev'.  Stop.

Is it correct to assume that the start command should be used for development and production environment? I change the documentation to reflect that assuming that's the case.

+1 -7

1 comment

1 changed file

bmuschko

pr closed time in 5 months

pull request commentgojp/goreportcard

Fix command for starting local server

Thanks for the PR -- it seems like the README got updated in a separate commit somewhere so I'm going to close this out.

bmuschko

comment created time in 5 months

push eventgojp/goreportcard

Sven Lechner

commit sha 1a21c18fd4a32f85e8395724e7afbf30755505b7

add json flag to output results as json This commit adds the ability to output the check results as json data. This functionality is intended for scripting purposes. Therefore the binary will always exit with code 0. The threshold flag is also ignored when '-j' has been specified.

view details

Shawn Smith

commit sha c2aae3355cbebab0773e9ded7ecef9b7e17c59ce

Merge pull request #293 from SirWindfield/add_json_flag add json flag to output results as json

view details

push time in 5 months

PR merged gojp/goreportcard

Reviewers
add json flag to output results as json

This commit adds the ability to output the check results as json data. This functionality is intended for scripting purposes. Therefore the binary will always exit with code 0. The threshold flag is also ignored when '-j' has been specified.

Closes #292.

+8 -0

1 comment

1 changed file

SirWindfield

pr closed time in 5 months

issue closedgojp/goreportcard

Add json output via flag

This would be useful when calling the cli from scripts. It would allow easier parsing of the results.

closed time in 5 months

SirWindfield

push eventgojp/goreportcard

Shawn Smith

commit sha f17ee946b023eaa6399ccf6a563c1e924d577ad0

if repo not found in badger cache, check boltdb. if found in boltdb, set in badger and return

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha ff72b610b71cc5011b11138b4dbb204ebc2eca07

remove log line, save to cache when not found

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 04f16191c2e8f40690e8fc5b6db7d522f93f85b9

fix boltdb path

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha cf852d7c2bb5b4778c6cb4d9e3f4f94a1737c1cb

inject badger db into handlers part 2

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 90cd98914bf63f56e9b46f9452c25ec950c69879

inject badger db into handlers

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha b0a6af7f9bb2796033d725440805ac55ab551cc6

badger migration: fix high scores handler

view details

Shawn Smith

commit sha fb05c729d46b8e95cada321a9b160964473cfb11

badger migration: add migration tool

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 2981fdc31ff49382345c0c9139b6d36ef127331a

remove unused tools, unused metabucket constant

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 3196d5eb5473a7ae5da3363a4701af13fd8cad9a

update protobuf library

view details

push time in 5 months

create barnchgojp/goreportcard

branch : migrate-boltdb-to-badger

created branch time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha dc8c7a48b6379dfa762d62b65ca1d011b65f595c

update footer

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 6abd3e64345026f8174583e4360644c24afc9c69

Update README.md

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 370c74a82f7b9ea30ba5f2c6ccebab3ec5b11b04

add sponsor logo

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 39b63a2fa7ba4115c9096ecf53f5c714261a088d

add sponsors

view details

push time in 5 months

PR opened dgraph-io/dgraph

Reviewers
x: increment loop variable

I may be mistaken but it seems that i should be getting incremented in this loop rather than retries.

+1 -1

0 comment

1 changed file

pr created time in 5 months

push eventshawnps/dgraph

Shawn Smith

commit sha 3edf5092da74ea4232d36501cb6cc1616a11b082

x: increment loop variable

view details

push time in 5 months

fork shawnps/dgraph

Fast, Distributed Graph DB

https://dgraph.io

fork in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 9e71b9371cfd2244a1cbbe814ac74b2cc09b24b6

update footer

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 7f263d2727c6548352a4ba5e3012ebe6d7271f2a

update clean-repos tool

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 57b0f4a56e03640481429ab8868541e7a8143fc0

add in-memory badge cache

view details

push time in 5 months

push eventgojp/goreportcard

Shawn Smith

commit sha 6acb1d20cc6342e561820d5eb85e9318f729f38e

Revert "add modules, remove vendor dir" This reverts commit 436d84b0bcf9f2c5eb3a357a7e66a5052a9a64c5.

view details

Shawn Smith

commit sha c93b8dd9e1fc4022b756394aa428b7f53b192349

add supporters template

view details

push time in 5 months

more