profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/shakaran/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ángel Guzmán Maeso shakaran Quijost Manzanares, Ciudad Real, España https://shakaran.net Senior Backend Engineer. Available for freelance work.

avanzu/AdminThemeBundle 281

Admin Theme based on the AdminLTE Template for easy integration into symfony

shakaran/AdminThemeBundle 2

Admin Theme based on the AdminLTE Template for easy integration into symfony

shakaran/adstxtparser 2

⤴ 📮 A open source implementation in PHP of Ads.txt Specification Version 1.0.1 (OpenRTB working group)

shakaran/apogeus 2

Open Source RPG

shakaran/Big-Big-RSS 2

✉️ :bookmark: A PHP and Ajax feed reader

cpeters5/orchidroots 0

Main branch of OrchidRoots project starting V4

shakaran/AlgoliaSearchBundle 0

Seamless integration of Algolia Search into your Symfony project.

shakaran/amazon-s3-php-class 0

A standalone Amazon S3 (REST) client for PHP 5.2.x using CURL that does not require PEAR.

shakaran/annotations 0

Annotations Docblock Parser

shakaran/api-php-sdk 0

Packlink API PHP SDK

pull request commentKnpLabs/KnpMenu

Make ancestorClass option consistency to underscore

Please, let me know if there are something more needed to get this merged. I would like sent the next PR with the other options

shakaran

comment created time in 10 days

push eventshakaran/AdminThemeBundle

Ángel Guzmán Maeso

commit sha 40ca6852d205a47dd3985615f8ec29b808362e3e

<feature> Use twig 3.0 filter apply for spaceless

view details

push time in 11 days

push eventavanzu/AdminThemeBundle

Ángel Guzmán Maeso

commit sha 40ca6852d205a47dd3985615f8ec29b808362e3e

<feature> Use twig 3.0 filter apply for spaceless

view details

push time in 11 days

push eventshakaran/AdminThemeBundle

Ángel Guzmán Maeso

commit sha fac0e8591cf58686bdbaf9f286230eb595137e31

<feature> Fix empty item routes warnings

view details

Ángel Guzmán Maeso

commit sha 033ec8dfb3d3e97c61a4c9d45f89bf1d2cd79a19

<feature> Update login template menu for more options based in Symfony

view details

Ángel Guzmán Maeso

commit sha e32b24a3d915b8bac8d0f0caedac3d3b7977f2ca

<feature> Small refactor

view details

Ángel Guzmán Maeso

commit sha e8f3d791b32762a729669c773c67189f2ca99d52

<feature> Prevent conflicts with same name of identifiers in menu

view details

Ángel Guzmán Maeso

commit sha 4c1e7104e48269fc94b3bc607dd9e45a321f35b3

<feature> Update default layout menu

view details

Ángel Guzmán Maeso

commit sha 4bc030da3f19b236fec662e75a2584d781c2a00a

<feature> Update close blogs with names

view details

push time in 11 days

push eventavanzu/AdminThemeBundle

Ángel Guzmán Maeso

commit sha fac0e8591cf58686bdbaf9f286230eb595137e31

<feature> Fix empty item routes warnings

view details

Ángel Guzmán Maeso

commit sha 033ec8dfb3d3e97c61a4c9d45f89bf1d2cd79a19

<feature> Update login template menu for more options based in Symfony

view details

Ángel Guzmán Maeso

commit sha e32b24a3d915b8bac8d0f0caedac3d3b7977f2ca

<feature> Small refactor

view details

Ángel Guzmán Maeso

commit sha e8f3d791b32762a729669c773c67189f2ca99d52

<feature> Prevent conflicts with same name of identifiers in menu

view details

Ángel Guzmán Maeso

commit sha 4c1e7104e48269fc94b3bc607dd9e45a321f35b3

<feature> Update default layout menu

view details

Ángel Guzmán Maeso

commit sha 4bc030da3f19b236fec662e75a2584d781c2a00a

<feature> Update close blogs with names

view details

push time in 11 days

PR opened FriendsOfPHP/PHP-CS-Fixer

Provide test case for issue #5950

The test will fail since there is a bug in #5950. After bug would be fixed, should be valid:

--- Expected
+++ Actual
@@ @@
-'<?php echo (function () {})();'
+'<?php echo(function  () {})();'

+4 -0

0 comment

1 changed file

pr created time in 20 days

create barnchshakaran/PHP-CS-Fixer

branch : test-no_spaces_after_function_name

created branch time in 20 days

issue commentFriendsOfPHP/PHP-CS-Fixer

setFinder and arrays

Does already PHPStan would handle this case?

uuf6429

comment created time in 20 days

delete branch shakaran/PHP-CS-Fixer

delete branch : patch-1

delete time in 20 days

pull request commentFriendsOfPHP/PHP-CS-Fixer

Add parallel capabilities to FixCommand

@AlbertoBarba did you have a chance for see the review comments? Your PR looks very promissing and a lot people would like to see it merged. Thanks for your great work!

AlbertoBarba

comment created time in 20 days

pull request commentFriendsOfPHP/PHP-CS-Fixer

PHPDocAlign - Make alignment of multi-line descriptions configurable

@dontub please, could you reupdate and solve the conflicts? Could be a chance to be merged in future releases and maintainer will probably comment about your last suggestion. Thanks for your effort

dontub

comment created time in 20 days

pull request commentFriendsOfPHP/PHP-CS-Fixer

Add variable name rule

@jmkoni could you rerun

php dev-tools/doc.php

For update README.rst and resolve the conflict, so it would look RTM for maintainers? Thanks

jmkoni

comment created time in 20 days

pull request commentFriendsOfPHP/PHP-CS-Fixer

Feature/declare strict types fixer split

@shakaran unfortunately I think rebasing is probably going to be non-trivial (given more than 4 years have passed since the initial PR). If anyone who currently works on the project is willing to lend a hand I'm happy to help too, but it seems interest has waned.

Since I cannot commit to your branch in this PR, I fork and make the changes in my own account, it is under

https://github.com/shakaran/PHP-CS-Fixer/tree/feature/DeclareStrictTypesFixer-split

If you can cherry pick my commits:

https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/d318f5fc5ba3c3ae8d58161564aafb2e1bada410

https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/380b040f11aaee372a2889f7a6b4ef471883d60b

https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/380b040f11aaee372a2889f7a6b4ef471883d60b

https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/777444074e36c174cdd09172c710dfeace7d499f

https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/51033fce507a695e5a0502b379fcc4ccaef08ef5

That update the docs as @keradus requested, and the intefaces, but the logic should be checked since not sure if all is ok, but at least you have a base to update the remaning changes and hopefully we get this merged soon ;)

Basically are only 4 files to update:

src/Fixer/Strict/DeclareStrictTypesFixer.php tests/Fixer/Strict/DeclareStrictTypesFixerTest.php tests/Fixtures/Integration/priority/declare_strict_types,declare_equal_normalize.test tests/Fixtures/Integration/priority/declare_strict_types,single_blank_line_before_namespace.test

Let me know if I can help more, I am just new with the fixers, but I am trying to learn and do my best here.

aidantwoods

comment created time in 20 days

push eventshakaran/PHP-CS-Fixer

Ángel Guzmán Maeso

commit sha 777444074e36c174cdd09172c710dfeace7d499f

Try to update DeclareStrictTypesPositionFixer

view details

Ángel Guzmán Maeso

commit sha 51033fce507a695e5a0502b379fcc4ccaef08ef5

Try to merge and rebase DeclareStrictTypesFixer

view details

push time in 20 days

create barnchshakaran/PHP-CS-Fixer

branch : feature/DeclareStrictTypesFixer-split

created branch time in 20 days

pull request commentKnpLabs/KnpMenu

Make ancestorClass option consistency to underscore

@stof as soon you can give me your RTM and merge it I will sent the next PR for the other options described in #171

shakaran

comment created time in 22 days

Pull request review commentKnpLabs/KnpMenu

Fix deprecation of PHPUnit\Framework\TestCase::prophesize()

 use Knp\Menu\Provider\ChainProvider; use Knp\Menu\Provider\MenuProviderInterface; use PHPUnit\Framework\TestCase;+use Prophecy\PhpUnit\ProphecyTrait;  final class ChainProviderTest extends TestCase {+    use ProphecyTrait;+     public function testHas(): void     {         $innerProvider = $this->getMockBuilder(MenuProviderInterface::class)->getMock();-        $innerProvider->expects($this->at(0))+        $innerProvider->expects($this->exactly(1))             ->method('has')             ->with('first')-            ->willReturn(true)-        ;-        $innerProvider->expects($this->at(1))+            ->willReturnOnConsecutiveCalls(true);

I think that still doesn't work, I am missing something

https://github.com/KnpLabs/KnpMenu/pull/352/commits/067973d087365e35f4b194b33c97093df6aed22a

I don't know if in the method expect() I should put $this->any() for the single expectation.

shakaran

comment created time in 23 days

PullRequestReviewEvent

push eventshakaran/KnpMenu

Ángel Guzmán Maeso

commit sha 067973d087365e35f4b194b33c97093df6aed22a

Use a single expectation and unify willReturnOnConsecutiveCalls()

view details

push time in 23 days

Pull request review commentKnpLabs/KnpMenu

Fix deprecation of PHPUnit\Framework\TestCase::prophesize()

         "symfony/http-foundation": "^4.4 || ^5.0",         "symfony/phpunit-bridge": "^5.3",         "symfony/routing": "^4.4 || ^5.0",-        "twig/twig": "^1.40 || ^2.9 || ^3.0"+        "twig/twig": "^1.40 || ^2.9 || ^3.0",+        "phpspec/prophecy-phpunit": "^2.0"

Done in https://github.com/KnpLabs/KnpMenu/pull/352/commits/db5d9a54bfa5d8da2bbb5926e48c1f7360ff9f60

shakaran

comment created time in 23 days

PullRequestReviewEvent

push eventshakaran/KnpMenu

Ángel Guzmán Maeso

commit sha db5d9a54bfa5d8da2bbb5926e48c1f7360ff9f60

Enable config sort packages alphabetically and reorder phpspec/prophecy-phpunit dependency

view details

push time in 23 days

Pull request review commentKnpLabs/KnpMenu

Fix deprecation of PHPUnit\Framework\TestCase::prophesize()

         "symfony/http-foundation": "^4.4 || ^5.0",         "symfony/phpunit-bridge": "^5.3",         "symfony/routing": "^4.4 || ^5.0",-        "twig/twig": "^1.40 || ^2.9 || ^3.0"+        "twig/twig": "^1.40 || ^2.9 || ^3.0",+        "phpspec/prophecy-phpunit": "^2.0"

it is under require-dev. where should be placed phpspec/prophecy-phpunit?

shakaran

comment created time in 23 days

PullRequestReviewEvent

push eventshakaran/PHP-CS-Fixer

SpacePossum

commit sha c905dc720d6200493b1272a792d23bbafd8241ee

bump year

view details

Ángel Guzmán Maeso

commit sha de18cb2b3f4fd3944c1f0e18373800029946750d

Reduce full path code for consistency in other parts with InvalidConfigurationException

view details

SpacePossum

commit sha 1b5ce079eb1712c1bb61882fcfdfbdd23a1f0b4b

minor #5933 Consistency invalid configuration exception for test (shakaran) This PR was merged into the master branch. Discussion ---------- Consistency invalid configuration exception for test Since I check that @SpacePossum [was doing this exact change](https://github.com/FriendsOfPHP/PHP-CS-Fixer/commit/98eed9f27b943ac28e811b0ca7b89f89a40d62c4#diff-dbe968ecfaa21d9e35844f2fd63b12bb1fec4265cb453961db3796bb40accf03L1076) in some part of code, I think that it is good for consistency that in other places appears in the same way. Also we are lacking of the inverse of fixer similar to "[fully_qualified_strict_types](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/doc/rules/import/fully_qualified_strict_types.rst)" that only works in methods declaration and not inside of methods and "[class_keyword_remove](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/master/doc/rules/language_construct/class_keyword_remove.rst)". Then I had to perform this manually with occurences on: `grep -rin 'ConfigurationException\\InvalidConfigurationException' | grep -v namespace | grep -v use | grep -v cover` Would be nice to have fixer to do this over other codebases. Commits ------- de18cb2b3 Reduce full path code for consistency in other parts with InvalidConfigurationException

view details

SpacePossum

commit sha d40f78eab5afc1b8d851e5d5a33bee5cc6acc801

minor #5931 logo copyright - bump year (SpacePossum) This PR was merged into the master branch. Discussion ---------- logo copyright - bump year Commits ------- c905dc720 bump year

view details

Ángel Guzmán Maeso

commit sha 625427cd351b464e5f9b026f88aa500157150b05

Merge branch 'master' into unify_blank_line_after_fixes

view details

push time in 23 days

issue closedshakaran/packlink-php-sdk

Hi there, we under dev our custom api.

U can find more at => https://github.com/MwSpaceLLC/packlink-php

closed time in 24 days

MwSpaceLLC

issue commentshakaran/packlink-php-sdk

Hi there, we under dev our custom api.

Thanks @MwSpaceLLC

I add in the commit https://github.com/shakaran/packlink-php-sdk/commit/0f5ae7de4dc04bbabdfdb0083bf3d29103cba6ab a link to your repo, since it seems more advanced than my implementation.

MwSpaceLLC

comment created time in 24 days

push eventshakaran/packlink-php-sdk

Ángel Guzmán Maeso

commit sha 0f5ae7de4dc04bbabdfdb0083bf3d29103cba6ab

Add more unofficial implementations

view details

push time in 24 days

delete branch shakaran/PHP-CS-Fixer

delete branch : consistency_invalid_configuration_fdqn

delete time in 24 days

pull request commentFriendsOfPHP/PHP-CS-Fixer

WIP: Try to implement a base for future BlankLineAfterStatementFixer

@keradus could you add the label "help wanted" to this PR?

shakaran

comment created time in 24 days