profile
viewpoint
Sebastian Rehnby sebreh Copenhagen, Denmark

sebreh/SBRXCallbackURLKit 87

Simple library that makes it easy to add x-callback-url support to your app.

sebreh/Flipper 22

A feature flipping library in Swift.

sebreh/APNS-Pusher 3

A simple cocoa app to send pushes via APNS

sebreh/SRGridLocation 3

SRGridLocation provides a convenient way to convert between Swedish grid and GPS coordinates.

sebreh/tomorrow-theme 2

Colour Schemes for Hackers

holm/sequelize 0

An easy-to-use multi SQL dialect ORM for Node.js

sebreh/AsyncDisplayKit 0

Smooth asynchronous user interfaces for iOS apps.

sebreh/bluebird 0

Bluebird is a full featured promise library with unmatched performance.

sebreh/DevCenter.me 0

Directory of developer center websites with memorable URL shortcuts

sebreh/DTCoreText 0

Methods to allow using HTML code with CoreText

pull request commentpeakon/saml2

Propagate thrown error for missing session index

https://github.com/Clever/saml2/pull/200

sebreh

comment created time in 3 months

PR opened Clever/saml2

Fix uncaught error "SessionIndex not an attribute of AuthnStatement"

There is an existing error being thrown from within get_session_info that is not checked by the caller and therefore not forwarded to the callback chain and as such, is causing the module to crash if triggered. Additionally, there was no test case for this error case. This PR includes both the fix to propagate the error and the missing test case.

+33 -1

0 comment

2 changed files

pr created time in 3 months

push eventpeakon/saml2

Sebastian Rehnby

commit sha 7b4e993c065406a5cc3656726fe7af93473418dd

Fix uncaught error

view details

Sebastian Rehnby

commit sha a7f8f7f6660cd941c027b8b4ed58773759144b06

Merge pull request #1 from peakon/fix_uncaught_error Propagate thrown error for missing session index

view details

push time in 3 months

PR merged peakon/saml2

Propagate thrown error for missing session index

There is an existing error being thrown from within get_session_info that is not checked by the caller and therefore not forwarded to the callback chain and as such, is causing the module to crash if triggered. Additionally, there was no test case for this error case. This PR includes both the fix to propagate the error and the missing test case.

+33 -1

3 comments

2 changed files

sebreh

pr closed time in 3 months

pull request commentpeakon/saml2

Propagate thrown error for missing session index

Yeah, if that's what you want for a particular case, otherwise it might be annoying :) Thanks for the review, will try to upstream the changes.

sebreh

comment created time in 3 months

pull request commentpeakon/saml2

Propagate thrown error for missing session index

thanks @papandreou. The only thing I was unsure about was whether defining session_info within the try/catch would make it available in the outer scope, which it seems to do (I assume because it transpiles to var session_info = ...), but I wasn't sure if I can rely on that behavior. Test case wise that seems fine though.

sebreh

comment created time in 3 months

PR opened peakon/saml2

Propagate thrown error for missing session index

There is an existing error being thrown from within get_session_info that is forwarded to the callback chain, and as such is causing the module to crash if triggered. Additionally, there was no test case for this error case. This PR includes both the fix to propagate the error and the missing test case.

+33 -1

0 comment

2 changed files

pr created time in 3 months

create barnchpeakon/saml2

branch : fix_uncaught_error

created branch time in 3 months

more