profile
viewpoint
Satyajit Sahoo satya164 @callstack Wrocław, Poland https://twitter.com/@satya164 JavaScript is life's love!

facebook/react-native 91675

A framework for building native apps with React.

expo/expo 12327

An open-source platform for making universal native apps with React. Expo runs on Android, iOS, and the web.

callstack/react-native-paper 6782

Material Design for React Native (Android & iOS)

callstack/linaria 6298

Zero-runtime CSS in JS library

callstack/haul 3439

Haul is a command line tool for developing React Native apps, powered by Webpack

airbnb/native-navigation 3127

Native navigation library for React Native applications

FormidableLabs/prism-react-renderer 779

🖌️ Renders highlighted Prism output to React (+ theming & vendored Prism)

ericvicenti/navigation-rfc 444

Better Navigation in React Native

Glucosio/glucosio-android 330

Glucosio Android App

hotice/AP-Hotspot 127

Automatically creates an infrastructure (Access Point mode) wireless hotspot in Ubuntu that should work with Android and Windows Phone devices

issue commentreact-navigation/react-navigation

UI flicker issue when orientation changes from portrait to landscape

Couldn't find version numbers for the following packages in the issue:

  • @react-navigation/native
  • @react-navigation/material-top-tabs

Can you update the issue to include version numbers for those packages? The version numbers must match the format 1.2.3.

Tanuja0064

comment created time in 29 minutes

issue openedreact-navigation/react-navigation

UI flicker issue when orientation changes from portrait to landscape

Current Behavior We are using @react-navigation/material-top-tabs library to build carousal navigation which have 6 screens. We are using video player in one of screens where we have the functionality to make the video full screen.

When we click on the full screen button, we are seeing the cut screen of top tab menu screen. it shows half part of two screens, connected for a fraction of second before loading the landscape mode. This issue is very sporadic.

Expected Behavior it should have a smooth transition from portrait to landscape and vice versa.

How to reproduce

  1. Create material top tab bar with multiple screens
  2. try to switch between portrait to landscape.

Your Environment Issue occurring on both IOS and Android

created time in 29 minutes

issue commentreact-navigation/react-navigation

Cannot listen to drawerOpen event inside DrawerContent

@satya164 sorry, I really don't remember exactly how this is related in my case. But I already have a workaround. I will open a new issue if I remember in the future.

Mavenic

comment created time in 36 minutes

startedsatya164/react-navigation-native-modal

started time in 2 hours

startedsatya164/react-navigation-native-modal

started time in 2 hours

issue commentreact-navigation/react-navigation

Deep links to unopened application fail with 'navigation' object hasn't been initialized yet

@davidmoss looking at that commit, it would only add a warning that the navigation is not yet initialized?

I will double check which version I'm using and test again, but if it was only that commit you referenced I wouldn't say that's a fix - it's just printing out to console the issue we are already discussing in this thread. Thanks a lot for the effort here, I'm super grateful, just trying to find a way to make navigating when opening a cold app from a deep link / notification work consistently.

timfpark

comment created time in 3 hours

issue commentreact-navigation/react-navigation

Deep links to unopened application fail with 'navigation' object hasn't been initialized yet

Updating to the latest @react-navigation/native fixes this since 5.8.6: https://github.com/react-navigation/react-navigation/commit/4c2379cec1e661aa132002fd1c50909ea64cb983

timfpark

comment created time in 3 hours

issue commentreact-navigation/react-navigation

Cannot listen to drawerOpen event inside DrawerContent

@satya164 I need to track open progress animation state

Mavenic

comment created time in 3 hours

issue commentreact-navigation/react-navigation

iOS screen is frozen when swiping to previous page

Do you have react-native-screens enabled in your project (i.e. calling enableScreens())? Can you remove it for iOS and see if fixes the issue? (or specify detachInactiveScreens to false https://reactnavigation.org/docs/stack-navigator#detachinactivescreens)

detachInactiveScreens to false solves the problem though what was the cause?

RnbWd

comment created time in 3 hours

issue commentreact-navigation/react-navigation

Accessing the 'state' property of the 'route' object is not supported.

I want to log every route change, and I tried quite some stuff but I always get this warning too, but I can't use getFocusedRouteNameFromRoute with the navigator ref, how can I manage ?

class App extends React.Component {

  onStateChange = async () => {
    if (!this.navigationRef) return;
    const currentRouteName = this.navigationRef.getCurrentRoute().name;
    if (currentRouteName === this.prevCurrentRouteName) return;
    this.prevCurrentRouteName = currentRouteName;
    console.log({ currentRouteName })
  };

  render() {
    return (
        <NavigationContainer
          ref={(r) => (this.navigationRef = r)}
          onStateChange={this.onStateChange}>
            {this.props.children}
        </NavigationContainer>
    );
  }
}
luco

comment created time in 5 hours

startedsatya164/react-native-tab-view

started time in 6 hours

issue commentsatya164/react-native-tab-view

Adding data to FlatList will cause re-render

My app was stuttering because of this and I decided to follow a tutorial on youtube and create it myself. It's not the same thing but quite similar.

https://www.youtube.com/watch?v=ZiSN9uik6OY Thanks for the solution, I used another tab component instead, and I will check the tutorial as well, thank you ~

AlexJeeee

comment created time in 6 hours

fork wangyinwei1/react-native-tab-view

A cross-platform Tab View component for React Native

fork in 6 hours

startedsatya164/react-native-tab-view

started time in 6 hours

pull request commentreact-navigation/react-navigation.github.io

Fix hyperlinks for Stack and Tab Router in routers doc (version 4.x)

Deploy preview for react-navigation-docs ready!

Built with commit affe3875b5a850e91a0d9da47740540ddf905db5

https://deploy-preview-897--react-navigation-docs.netlify.app

Kamalnrf

comment created time in 11 hours

PR opened react-navigation/react-navigation.github.io

Fix hyperlinks for Stack and Tab Router in routers doc (version 4.x)

The hyperlinks were pointing to the archived react-navigation repo so updated them to active repo and that particular branch file.

+2 -2

0 comment

1 changed file

pr created time in 11 hours

issue commentreact-navigation/react-navigation

Cannot listen to drawerOpen event inside DrawerContent

@Mavenic have you resolve this issue?

Mavenic

comment created time in 11 hours

startedsatya164/react-simple-code-editor

started time in 14 hours

startedsatya164/react-navigation-native-modal

started time in 16 hours

startedsatya164/react-native-tab-view

started time in 16 hours

pull request commentreact-navigation/react-navigation

fix: consider openByDefault prop when getting rehydrated drawer state

Codecov Report

Merging #9099 (e58f5eb) into main (1406eb8) will decrease coverage by 0.04%. The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9099      +/-   ##
==========================================
- Coverage   72.90%   72.85%   -0.05%     
==========================================
  Files         135      135              
  Lines        3454     3459       +5     
  Branches     1088     1067      -21     
==========================================
+ Hits         2518     2520       +2     
  Misses        827      827              
- Partials      109      112       +3     
Impacted Files Coverage Δ
...es/drawer/src/navigators/createDrawerNavigator.tsx 100.00% <ø> (ø)
packages/drawer/src/views/Drawer.tsx 53.25% <28.57%> (-0.41%) :arrow_down:
packages/routers/src/DrawerRouter.tsx 81.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1406eb8...e58f5eb. Read the comment docs.

sekonia

comment created time in 17 hours

pull request commentreact-navigation/react-navigation

fix: consider openByDefault prop when getting rehydrated drawer state

Deploy preview for react-navigation-example ready!

Built with commit 9e9dcddefe245faae059342c40dd4f54b885ed60

https://deploy-preview-9099--react-navigation-example.netlify.app

sekonia

comment created time in 18 hours

pull request commentreact-navigation/react-navigation

fix: consider openByDefault prop when getting rehydrated drawer state

I have opened an issue earlier today that describes the problem: #9098

sekonia

comment created time in 18 hours

issue commentreact-navigation/react-navigation

openByDefault={true} does not open the drawer on routes other than "/" with expo-linking

I think, I have found the problem and created a pull request #9099.

sekonia

comment created time in 18 hours

PR opened react-navigation/react-navigation

fix: consider openByDefault prop when getting rehydrated drawer state

openByDefault in connection with expo-links only works for getInitialState(). When a page of the application is refreshed, getRehydratedState() is called and the drawer stays closed. This should fix the issue.

+1 -1

0 comment

1 changed file

pr created time in 18 hours

issue commentreact-navigation/react-navigation

Tabbing back fast multiple times results in error

keep happening:

"@react-navigation/drawer": "^5.11.4", "@react-navigation/native": "^5.8.10", "@react-navigation/stack": "^5.12.8",

tknuts

comment created time in 19 hours

issue commentreact-navigation/react-navigation

Nested Navigation Not Working on Update of @react-navigation/core

Hi Satyajit, thanks for your reply. I am not using it directly. I had to downgrade the lib to get nested nav to work.

On Nov 24, 2020, at 7:10 AM, Satyajit Sahoo notifications@github.com wrote:  You shouldn't be using @react-navigation/core directly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

danj565

comment created time in 20 hours

IssuesEvent

issue closedreact-navigation/react-navigation

openByDefault={true} does not open the drawer on routes other than "/" with expo-linking

Current Behavior With routes defined (expo-linking and passed to NavigationContainer as linking-prop, the drawer does not open initially on any route other than / on the web, even though openByDefault is set to true on Drawer.Navigator. This applies to all drawerTypes other than permanent.

<NavigationContainer linking={linking}>
    <Drawer.Navigator openByDefault={true}>
        ...
    </Drawer.Navigator>
</NavigationContainer>

Expected Behavior The drawer should open by default when I refresh the page on /my/route. Currently the drawer only opens on /.

How to reproduce Define any linking object, set openByDefault to true and refresh the application on any route other than /.

Your Environment

software version
iOS or Android
@react-navigation/native 5.8.10
@react-navigation/drawer 5.11.4
react-native-reanimated 1.13.0
react-native-gesture-handler 1.7.0
react-native-safe-area-context 3.1.4
react-native-screens 2.10.1
react-native 63.2
expo 39.0.2
node 12.18.4
npm or yarn yarn

closed time in 20 hours

sekonia

issue commentreact-navigation/react-navigation

openByDefault={true} does not open the drawer on routes other than "/" with expo-linking

Ok, that's interesting... I had no empty route defined in my linking object because I wanted every route to have a name. I didn't think that this was impossible.

This works

const linking = {
    prefixes: [prefix],
    config: {
        screens: {
            Welcome: "",
            PersonalInformation: "personal-information",
            Payments: "payments",
            Subscriptions: "subscriptions",
        },
    },
};

while this doesn't

const linking = {
    prefixes: [prefix],
    config: {
        screens: {
            Welcome: "welcome",
            PersonalInformation: "personal-information",
            Payments: "payments",
            Subscriptions: "subscriptions",
        },
    },
};
sekonia

comment created time in 20 hours

more